[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca added a comment. In D140756#4051383 , @aaron.ballman wrote: > LGTM aside from some minor things you can correct when landing. > Thank you for the great suggestions! I'll try to correct it as soon as possible, hopefully this weekend. Sho

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

serge-sans-paille added a comment. LGTM Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:652 auto data = + llvm::MutableArrayRef(static_cast(buf), bytes_read); random nit: This could be rewritten as ``` llvm::MutableArrayRef data(static_

[PATCH] D141750: [docs] Add llvm & clang release notes for LoongArch

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Nice! Thanks for the detailed reporting. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141750/new/ https://reviews.llvm.org/D141750 _

[PATCH] D141811: [clang-format] Allow trailing return types in macros

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. What about `decltype(auto)`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141811/new/ https://reviews.llvm.org/D141811

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 489437. ChuanqiXu added a comment. Move the release note to `Deprecated Compiler Flags` section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[clang] 2563ad8 - [NFC] [Modules] Add test from PR60036

Author: Chuanqi Xu Date: 2023-01-16T15:08:16+08:00 New Revision: 2563ad8ef1a88907049715b582eb2342fd69cf89 URL: https://github.com/llvm/llvm-project/commit/2563ad8ef1a88907049715b582eb2342fd69cf89 DIFF: https://github.com/llvm/llvm-project/commit/2563ad8ef1a88907049715b582eb2342fd69cf89.diff LO

[PATCH] D141818: Add test for an invalid requirement in requires expr.

usaxena95 created this revision. usaxena95 added reviewers: ilya-biryukov, erichkeane. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The one introduced in D140547 w

[PATCH] D140001: [Driver] [C++20] [Modules] Don't emit unused-argument warning for ` -fmodule-output=` and `-fmodule-output`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcb6afb508c4: [Driver] [C++20] [Modules] Don't emit unused-argument warning for '-fmodule… (authored by ChuanqiXu). Herald added a project: clang. He

[clang] fcb6afb - [Driver] [C++20] [Modules] Don't emit unused-argument warning for '-fmodule-output' and '-fmodule-output='

Author: Chuanqi Xu Date: 2023-01-16T14:08:02+08:00 New Revision: fcb6afb508c420c3a95e6e1324b1586255a08f40 URL: https://github.com/llvm/llvm-project/commit/fcb6afb508c420c3a95e6e1324b1586255a08f40 DIFF: https://github.com/llvm/llvm-project/commit/fcb6afb508c420c3a95e6e1324b1586255a08f40.diff LO

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e9e8d6ef442: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2) (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 3e9e8d6 - [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

Author: Chuanqi Xu Date: 2023-01-16T14:01:05+08:00 New Revision: 3e9e8d6ef44244491e25f7bc918f6e91e16b7714 URL: https://github.com/llvm/llvm-project/commit/3e9e8d6ef44244491e25f7bc918f6e91e16b7714 DIFF: https://github.com/llvm/llvm-project/commit/3e9e8d6ef44244491e25f7bc918f6e91e16b7714.diff LO

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

ChuanqiXu updated this revision to Diff 489426. ChuanqiXu added a comment. Update since the dependent one changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp c

[clang] b1ac375 - [NFC] Only run clang/test/Driver/module-output.cppm on x86 registered targets

Author: Chuanqi Xu Date: 2023-01-16T13:49:37+08:00 New Revision: b1ac375e11c801be2a1e07e87be91ae54decf2eb URL: https://github.com/llvm/llvm-project/commit/b1ac375e11c801be2a1e07e87be91ae54decf2eb DIFF: https://github.com/llvm/llvm-project/commit/b1ac375e11c801be2a1e07e87be91ae54decf2eb.diff LO

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu added a reviewer: philnik. ChuanqiXu added a comment. Now it looks like the failure are not related to the patch. Although there are some clang-format related failures, the related changes are generated automatically and I roughly remember libcxx don't use libcxx. @philnik would you l

[PATCH] D141814: [llvm][ADT] Replace uses of `makeMutableArrayRef` with deduction guides

jloser created this revision. jloser added reviewers: MaskRay, serge-sans-paille, dblaikie. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, kosarev, ayermolo, sdasgup3, wenzhicui, wrengr, foad, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerb

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu added a comment. In D137534#4055323 , @h-vetinari wrote: >> Sorry for the misleading and thanks for the quick clarification. So it looks >> like the status quo is a little bit worse than I imaged... > > I opened a thread on discourse for more

[clang] 6f2e781 - [NFC] Require tests to skip on windows to avoid handling the different

Author: Chuanqi Xu Date: 2023-01-16T11:48:08+08:00 New Revision: 6f2e78195f644f024df5b5167e26bdd56b4c1c2b URL: https://github.com/llvm/llvm-project/commit/6f2e78195f644f024df5b5167e26bdd56b4c1c2b DIFF: https://github.com/llvm/llvm-project/commit/6f2e78195f644f024df5b5167e26bdd56b4c1c2b.diff LO

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

h-vetinari added a comment. > Sorry for the misleading and thanks for the quick clarification. So it looks > like the status quo is a little bit worse than I imaged... I opened a thread on discourse for more visibility: https://discourse.llvm.org/t/land-c-modules-changes-required-for-cmake-befo

[clang] f89327e - [Driver] [Modules] Support -fmodule-output (1/2)

Author: Chuanqi Xu Date: 2023-01-16T11:05:33+08:00 New Revision: f89327e28bc17a1d80fd5523520e62d8dd53c1cb URL: https://github.com/llvm/llvm-project/commit/f89327e28bc17a1d80fd5523520e62d8dd53c1cb DIFF: https://github.com/llvm/llvm-project/commit/f89327e28bc17a1d80fd5523520e62d8dd53c1cb.diff LO

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf89327e28bc1: [Driver] [Modules] Support -fmodule-output (1/2) (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. In D137534#4055286 , @h-vetinari wrote: > In D137534#4055283 , @ChuanqiXu > wrote: > >> @h-vetinari said it should be OK to backport these p

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/concat-nested-namespaces.cpp:173 +namespace n48 { +// CHECK-MESSAGES-DAG: :[[@LINE-2]]:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces] +//

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

h-vetinari added a comment. In D137534#4055283 , @ChuanqiXu wrote: > @h-vetinari said it should be OK to backport these patches to branched 16.x. That should be considered a comment from the peanut gallery, not a definite statement. What I had said in h

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu added a subscriber: h-vetinari. ChuanqiXu added a comment. @jansvoboda11 gentle ping~ (although I feel it may be hard to land this before the branching since I'll take a vacation in 19th until February, @h-vetinari said it should be OK to backport these patches to branched 16.x.) CHA

[PATCH] D137534: [C++20] [Modules] [ClangScanDeps] Allow clang-scan-deps to without specified compilation database in P1689 (3/4)

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Oh, I forgot to submit the inline comments. My bad. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137534/new/ https://reviews.llvm.org/D137534 ___ cfe-commits mailing list

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added a comment. In D137058#4050188 , @dblaikie wrote: > I really don't think this is the right thing to do - the Split DWARF code, > for instance, has support for GPU bundling that's missing in the module file > naming code, which seems likel

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu added a comment. In D141572#4050758 , @philnik wrote: > In D141572#4050492 , @ChuanqiXu > wrote: > >> @philnik when I run `ninja libcxx-generate-files` locally, it says `ninja: >> error: unknown target

[PATCH] D141572: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag

ChuanqiXu updated this revision to Diff 489412. ChuanqiXu added a comment. Update the header tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141572/new/ https://reviews.llvm.org/D141572 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticDriverKinds.td cla

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. non-reference `auto` shall work better in these cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141788/new/ https://reviews.llvm.org/D141

[PATCH] D133574: [C2x] reject type definitions in offsetof

ronlieb added a comment. our nekbone app is failing from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133574/new/ https://reviews.llvm.org/D133574 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D141573: [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141573/new/ https://reviews.llvm.org/D141573 ___

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added subscribers: nlopes, regehr. lebedev.ri added a comment. In D138958#4054903 , @jdoerfert wrote: > In D138958#4045567 , @efriedma > wrote: > >> From an IR semantics standpoint, I'm not sure the `m

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. rymiel added a project: clang-format. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The trailing return

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

barannikov88 added a comment. It would be nice to have comments reflecting the new behavior in the case of 0 / max value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141798/new/ https://reviews.llvm.org/D141798 _

[PATCH] D141803: [Clang] Reject in-class defaulting of previously declared comparison operators

royjacobson created this revision. royjacobson added a reviewer: clang-language-wg. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Comparison operators are not allowed to be defaulted if they were p

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

njames93 requested changes to this revision. njames93 added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/concat-nested-namespaces.cpp:173 +namespace n48 { +// CHECK-MESSAGES-DAG: :[[@LINE-2]]:1:

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

arsenm updated this revision to Diff 489394. arsenm added a comment. Rename CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141700/new/ https://reviews.llvm.org/D141700 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGenOpenCL/amdgpu-enqueue-kernel-linking.cl clang/test/Code

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/cl20-device-side-enqueue-attributes.cl:26 +// SPIR32-SAME: (ptr addrspace(1) align 4 [[A:%.*]], ptr addrspace(1) align 4 [[B:%.*]], i32 [[I:%.*]]) #[[ATTR0:[0-9]+]] !kernel_arg_addr_space !2 !kernel_arg_access_q

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

craig.topper added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:212 /// Only unsigned integral types are allowed. -/// -/// \param ZB the behavior on an input of 0. Only ZB_Max and ZB_Undefined are -/// valid arguments. -template T findFirstSet(T Val, Z

[PATCH] D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum

tom-anders updated this revision to Diff 489391. tom-anders added a comment. Factor out logic into helper function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141800/new/ https://reviews.llvm.org/D141800 Files: clang-tools-extra/clangd/CodeCom

[PATCH] D141620: clang/OpenCL: Apply default attributes to enqueued blocks

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/cl20-device-side-enqueue-attributes.cl:26 +// SPIR32-SAME: (ptr addrspace(1) align 4 [[A:%.*]], ptr addrspace(1) align 4 [[B:%.*]], i32 [[I:%.*]]) #[[ATTR0:[0-9]+]] !kernel_arg_addr_space !2 !kernel_arg_acces

[PATCH] D141700: AMDGPU: Move enqueued block handling into clang

Anastasia added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:12440 +/// AMDHSAKernelDescriptor.h) +static llvm::StructType *getKernelDescriptorType(llvm::LLVMContext &C) { + llvm::Type *Int8 = llvm::IntegerType::getInt8Ty(C); Is this AMDGPU targ

[PATCH] D141297: [OpenCL] Allow undefining header-only features

Anastasia added a comment. In D141297#4047148 , @svenvh wrote: > In D141297#4043122 , @Anastasia > wrote: > >> Btw I wonder if in the future we could add some error or warning in case >> someone uses the same ap

[clang] 931d04b - [ADT] Make StringRef::compare like std::string_view::compare

Author: Benjamin Kramer Date: 2023-01-15T20:59:21+01:00 New Revision: 931d04be2fc8f3f0505b43e64297f75d526cb42a URL: https://github.com/llvm/llvm-project/commit/931d04be2fc8f3f0505b43e64297f75d526cb42a DIFF: https://github.com/llvm/llvm-project/commit/931d04be2fc8f3f0505b43e64297f75d526cb42a.dif

[PATCH] D141800: [clangd] Fix qualifier not being dropped for using declaration referring to scoped enum

tom-anders created this revision. tom-anders added reviewers: nridge, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

jdoerfert added a comment. In D138958#4045567 , @efriedma wrote: > From an IR semantics standpoint, I'm not sure the `memory(none)` marking is > right if the function throws an exception. LangRef doesn't explicitly > exclude the possibility, but take t

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, kosarev, sdasgup3, wenzhicui, wrengr, ormris, foad, cota, teijeong, frasercrmck, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, kerbowa, liufengdb, aartbik, mgester, arpith-jacob, csig

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: VincentWu, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, jrtc2

[PATCH] D141793: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA

eopXD updated this revision to Diff 489370. eopXD edited the summary of this revision. eopXD added a comment. Update test cases that were leftout in the previous diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141793/new/ https://reviews.llvm.o

[PATCH] D141230: [clang-format-diff.py] give clang-format-diff a job pool (10x speed)

seanptmaher added a comment. I can't actually commit this -- could one of you? Or has it already been done? I remember reading that someone had to manually push the patch upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141230/new/ https://

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

kiranchandramohan added inline comments. Comment at: mlir/lib/Dialect/OpenMP/CMakeLists.txt:15 MLIRLLVMDialect + MLIRArithDialect ) TIFitis wrote: > kiranchandramohan wrote: > > TIFitis wrote: > > > kiranchandramohan wrote: > > > > Why is this needed here?

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. In D137205#4054534 , @Febbe wrote: > In D137205#4047828 , @Skylion007 > wrote: > >> I am trying this in the wild and getting some false positives where it tries >> to call std::move i

[PATCH] D100955: [-Wcalled-once] Do not run analysis on Obj-C++

vsavchenko added a comment. In D100955#4054569 , @thakis wrote: > Can you say a few words on _why_ this is emitted in only Objective-C? What's > missing for Objective-C++? I was surprised that this warning fired in a .m > file but not in a .mm file. Te

[PATCH] D141793: [WIP][14/15][Clang][RISCV] Change default policy from TAMU to TAMA

eopXD created this revision. Herald added subscribers: VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simo

[PATCH] D141792: [WIP][13/N][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics-autogenerated

eopXD created this revision. Herald added subscribers: VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simo

[PATCH] D100955: [-Wcalled-once] Do not run analysis on Obj-C++

thakis added a comment. Herald added a project: All. Can you say a few words on _why_ this is emitted in only Objective-C? What's missing for Objective-C++? I was surprised that this warning fired in a .m file but not in a .mm file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

SixWeining added a comment. Does anyone know why `patchable-function-entry` is not documented in https://llvm.org/docs/LangRef.html#function-attributes? Comment at: llvm/lib/Target/LoongArch/LoongArchMCInstLower.cpp:150 + .getAsInteger(10, Num)) +return fa

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry added a comment. In D141787#4054514 , @v1nh1shungry wrote: > This patch doesn't handle situations like: > > namespace a { > namespace b { > #define FOO > namespace c { > } > } > } It did. I must be mad :( Repository: rG LL

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry updated this revision to Diff 489350. v1nh1shungry added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141787/new/ https://reviews.llvm.org/D141787 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedName

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. In D137205#4047828 , @Skylion007 wrote: > I am trying this in the wild and getting some false positives where it tries > to call std::move inside loop conditions and in the boolean condition for an > if statement. Stuff like: > >

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 updated this revision to Diff 489347. njames93 added a comment. Extend test cases to check inline namespace, extension namespaces and alias namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137302/new/ https://reviews.llvm.org/D137

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry planned changes to this revision. v1nh1shungry added a comment. This patch doesn't handle situations like: namespace a { namespace b { #define FOO namespace c { } } } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141787/n

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis marked 4 inline comments as done. TIFitis added inline comments. Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:829 + VariadicOfVariadic:$map_operands, + DenseI32ArrayAttr:$map_operand_segments); + kiranchandramohan wr

[PATCH] D131915: [MLIR][OpenMP] Added target data, exit data, and enter data operation definition for MLIR.

TIFitis updated this revision to Diff 489345. TIFitis marked 7 inline comments as done. TIFitis added a comment. Added verifiers, removed use of magic constants and addressed other reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D141789: [WIP][12/N][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D141056: [SVE][CGBuiltins] Remove need for instcombine from ACLE tests.

This revision was automatically updated to reflect the committed changes. paulwalker-arm marked an inline comment as done. Closed by commit rG909ac0e97dcb: [SVE][CGBuiltins] Remove need for instcombine from ACLE tests. (authored by paulwalker-arm). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D137302: [clang-tidy] Add modernize-type-traits check

njames93 updated this revision to Diff 489342. njames93 marked an inline comment as done. njames93 added a comment. Remove unneeded static keyword Improved fix-it logic if there is a space between the template name and the `<` token Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

barannikov88 updated this revision to Diff 489341. barannikov88 added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141788/new/ https://reviews.llvm.org/D141788 Files: clang/docs/tools/clang-formatted-files.txt llvm

[PATCH] D141788: [NFC] Use `llvm::enumerate` in llvm/unittests/Object

barannikov88 created this revision. Herald added subscribers: s.egerton, simoncook, fedor.sergeev. Herald added a project: All. barannikov88 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, pcwang-thead. Herald added projects: clang, LLVM. Repository: rG LL

[PATCH] D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`

v1nh1shungry created this revision. v1nh1shungry added reviewers: carlosgalvezp, Eugene.Zelenko. Herald added a subscriber: xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang-tools-extra. Herald ad

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n created this revision. xen0n added reviewers: SixWeining, wangleiat, gonglingqin, MaskRay, xry111. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, hiraditya, arichardson. Herald added a reviewer: aaron.ballman. Herald added a project: All. xen0n requested review of this re

[PATCH] D141784: [clang][Interp] Fix binary comma operators

tbaeder updated this revision to Diff 489334. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141784/new/ https://reviews.llvm.org/D141784 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/SemaCXX/constexpr-duffs-device.cpp Index: clang/test/SemaCXX/constexpr-duffs-device.cp

[PATCH] D141784: [clang][Interp] Fix binary comma operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We left the result of RHS on the stack in case Di