[PATCH] D140415: [flang] stack arrays pass

2023-02-07 Thread Jean Perier via Phabricator via cfe-commits
jeanPerier accepted this revision. jeanPerier added a comment. I do not have any further comments, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https://reviews.llvm.org/D140415 ___ c

[PATCH] D143472: [clang] Cast the pointer to right type with different address space

2023-02-07 Thread Chunyang, Dai via Phabricator via cfe-commits
cdai2 created this revision. Herald added subscribers: pengfei, arichardson, Anastasia. Herald added a project: All. cdai2 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The source type has OpenCL general address space but dest type does n

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

2023-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 495407. kadircet added a comment. - Update tests after discussions in D143096 to be line-oriented, rather than being directive-oriented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D143093: [clangd] #undef macros inside preamble patch

2023-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 495409. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143093/new/ https://reviews.llvm.org/D143093 Files: clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/

[PATCH] D143095: [clangd] Respect preamble-patch when handling diags

2023-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 495410. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143095/new/ https://reviews.llvm.org/D143095 Files: clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clan

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

2023-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet marked an inline comment as done. kadircet added a comment. In D143096#4099662 , @sammccall wrote: > It looks like this fixes up the location only of diagnostics attached to > particular directives (`#include`) based on some "deep" idea about th

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

2023-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 495411. kadircet added a comment. - Change to a line based translation logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143096/new/ https://reviews.llvm.org/D143096 Files: clang-tools-extra/clangd/Parsed

[PATCH] D143399: [Tooling/Inclusion] Move the generated mapping .inc file to private places.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc751264aa198: [Tooling/Inclusion] Move the generated mapping .inc file to private places. (authored by hokein). Changed prior to commit: https://r

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

2023-02-07 Thread gehry via Phabricator via cfe-commits
Sockke updated this revision to Diff 495413. Sockke added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/InitVariablesCheck.cpp clang-tools-extra/test/clang-tidy/c

[clang] 03f5326 - [Tooling/Inclusion] Introduce a human-edit file for C++ std symbols

2023-02-07 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-02-07T10:15:50+01:00 New Revision: 03f5326d81665efa7db0b0d3dcd440e2ab632be2 URL: https://github.com/llvm/llvm-project/commit/03f5326d81665efa7db0b0d3dcd440e2ab632be2 DIFF: https://github.com/llvm/llvm-project/commit/03f5326d81665efa7db0b0d3dcd440e2ab632be2.diff LO

[PATCH] D143160: [include-mapping] Introduce a human-edit CXXSymbolMapping file

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03f5326d8166: [Tooling/Inclusion] Introduce a human-edit file for C++ std symbols (authored by hokein). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

2023-02-07 Thread Alex Zinenko via Phabricator via cfe-commits
ftynse added inline comments. Comment at: mlir/include/mlir/Target/LLVMIR/Dialect/Utils.h:13 + +#ifndef MLIR_DIALECT_UTILS_H +#define MLIR_DIALECT_UTILS_H This tag is wrong. It should be `MLIR_TARGET_LLVMIR_DIALECT_UTILS_H`. Comment at: mlir/in

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

2023-02-07 Thread Alex Zinenko via Phabricator via cfe-commits
ftynse added inline comments. Comment at: mlir/include/mlir/Target/LLVMIR/Dialect/Utils.h:27 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::OpenMPIRBuilder &builder, -

[clang] 8a09d60 - [Tooling/Inclusion] Move the StdSpecialSymbolMap.inc to the private lib place.

2023-02-07 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-02-07T10:31:41+01:00 New Revision: 8a09d60b71c0f9cac25834553c9eafb1e9bd58d6 URL: https://github.com/llvm/llvm-project/commit/8a09d60b71c0f9cac25834553c9eafb1e9bd58d6 DIFF: https://github.com/llvm/llvm-project/commit/8a09d60b71c0f9cac25834553c9eafb1e9bd58d6.diff LO

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: rovka, kiranchandramohan, Leporacanthicus, awarzynski, sscalpone, liaolucy. Herald added projects: Flang, All. sunshaoce requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project:

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. There should be some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143478/new/ https://reviews.llvm.org/D143478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143411: [NFC][clang] Fix static analyzer concern about uninitialized variable

2023-02-07 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8681797e595d: [NFC][clang] Fix static analyzer concern about uninitialized variable (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[clang] 8681797 - [NFC][clang] Fix static analyzer concern about uninitialized variable

2023-02-07 Thread Mariya Podchishchaeva via cfe-commits
Author: Mariya Podchishchaeva Date: 2023-02-07T04:40:44-05:00 New Revision: 8681797e595d52f0ee6710172b64aafd29b67ad1 URL: https://github.com/llvm/llvm-project/commit/8681797e595d52f0ee6710172b64aafd29b67ad1 DIFF: https://github.com/llvm/llvm-project/commit/8681797e595d52f0ee6710172b64aafd29b67a

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

2023-02-07 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: echristo, LiuChen3, erichkeane, GBuella. Herald added subscribers: steven.zhang, kbarton, nemanjai. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Curre

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

2023-02-07 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 495431. DmitryPolukhin added a comment. Fix clang-format sources Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/ClangdLSPSer

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. Thanks for working on this! Before diving any deeper - Does LLVM Flang require `flang-new -fc1as`? - If yes, why can't Flang and Clang share it? For better visibility, I suggest raising these questions on Discourse . As this could potenti

[PATCH] D143480: [clang][Interp] Fix derived-to-base casts for >1 levels

2023-02-07 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The GetPtrBasePop op we were using only works for

[PATCH] D143482: [SanitizerBinaryMetadata] Optimize used space for features and UAR stack args

2023-02-07 Thread Marco Elver via Phabricator via cfe-commits
melver created this revision. melver added a reviewer: dvyukov. Herald added subscribers: Enna1, hiraditya. Herald added a project: All. melver requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Optimi

[PATCH] D143484: [SanitizerBinaryMetadata] Emit constants as ULEB128

2023-02-07 Thread Marco Elver via Phabricator via cfe-commits
melver created this revision. melver added a reviewer: dvyukov. Herald added subscribers: Enna1, pengfei, hiraditya. Herald added a project: All. melver requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D143478#4109479 , @awarzynski wrote: > Thanks for working on this! Before diving any deeper > > - Does LLVM Flang require `flang-new -fc1as`? > - If yes, why can't Flang and Clang share it? > > For better visibility, I sugge

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D143478#4109412 , @clementval wrote: > There should be some tests. I'm not sure how to check the generated binaries, can you provide a test case for reference? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] cc14bf2 - [flang] add a pass to move array temporaries to the stack

2023-02-07 Thread Tom Eccles via cfe-commits
Author: Tom Eccles Date: 2023-02-07T10:27:52Z New Revision: cc14bf22bddf7abb1f13099c2d6ace5cdb8b7a5f URL: https://github.com/llvm/llvm-project/commit/cc14bf22bddf7abb1f13099c2d6ace5cdb8b7a5f DIFF: https://github.com/llvm/llvm-project/commit/cc14bf22bddf7abb1f13099c2d6ace5cdb8b7a5f.diff LOG: [f

[clang] bf81ba3 - [flang] add -fstack-arrays flag

2023-02-07 Thread Tom Eccles via cfe-commits
Author: Tom Eccles Date: 2023-02-07T10:27:52Z New Revision: bf81ba37262880a8391f63c1747d61e4851344c4 URL: https://github.com/llvm/llvm-project/commit/bf81ba37262880a8391f63c1747d61e4851344c4 DIFF: https://github.com/llvm/llvm-project/commit/bf81ba37262880a8391f63c1747d61e4851344c4.diff LOG: [f

[PATCH] D140415: [flang] stack arrays pass

2023-02-07 Thread Tom Eccles via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcc14bf22bddf: [flang] add a pass to move array temporaries to the stack (authored by tblah). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140415/new/ https

[PATCH] D140972: [flang] Add -fstack-arrays flag

2023-02-07 Thread Tom Eccles via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf81ba372628: [flang] add -fstack-arrays flag (authored by tblah). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D143484: [SanitizerBinaryMetadata] Emit constants as ULEB128

2023-02-07 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 495442. melver added a comment. Move AsmPrinter LEB128 helpers to AsmPrinter.cpp and use them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143484/new/ https://reviews.llvm.org/D143484 Files: clang/test/Code

[clang] 27aeb58 - [NFC][TargetParser] Remove llvm/Support/ARMTargetParser.h

2023-02-07 Thread Archibald Elliott via cfe-commits
Author: Archibald Elliott Date: 2023-02-07T11:05:58Z New Revision: 27aeb58ce4d12e15b966dba86738eb65a96703f7 URL: https://github.com/llvm/llvm-project/commit/27aeb58ce4d12e15b966dba86738eb65a96703f7 DIFF: https://github.com/llvm/llvm-project/commit/27aeb58ce4d12e15b966dba86738eb65a96703f7.diff

[clang] 4ae5400 - [NFC][TargetParser] Remove llvm/Support/ARMTargetParserCommon.h

2023-02-07 Thread Archibald Elliott via cfe-commits
Author: Archibald Elliott Date: 2023-02-07T11:05:59Z New Revision: 4ae540001a58d56659e3594ebbe9d1d1c57862fb URL: https://github.com/llvm/llvm-project/commit/4ae540001a58d56659e3594ebbe9d1d1c57862fb DIFF: https://github.com/llvm/llvm-project/commit/4ae540001a58d56659e3594ebbe9d1d1c57862fb.diff

[clang] b9a1c4d - [NFC][TargetParser] Remove llvm/Support/CSKYTargetParser.h

2023-02-07 Thread Archibald Elliott via cfe-commits
Author: Archibald Elliott Date: 2023-02-07T11:05:59Z New Revision: b9a1c4d5e13ce3129d957675fc966577da310f58 URL: https://github.com/llvm/llvm-project/commit/b9a1c4d5e13ce3129d957675fc966577da310f58 DIFF: https://github.com/llvm/llvm-project/commit/b9a1c4d5e13ce3129d957675fc966577da310f58.diff

[clang] a4c623e - [NFC][TargetParser] Remove llvm/Support/LoongArchTargetParser.h

2023-02-07 Thread Archibald Elliott via cfe-commits
Author: Archibald Elliott Date: 2023-02-07T11:05:59Z New Revision: a4c623e563ca46070284bc09d06f49d1f2426bc1 URL: https://github.com/llvm/llvm-project/commit/a4c623e563ca46070284bc09d06f49d1f2426bc1 DIFF: https://github.com/llvm/llvm-project/commit/a4c623e563ca46070284bc09d06f49d1f2426bc1.diff

[clang] b590f99 - [NFC][TargetParser] Remove llvm/Support/X86TargetParser.h

2023-02-07 Thread Archibald Elliott via cfe-commits
Author: Archibald Elliott Date: 2023-02-07T11:06:00Z New Revision: b590f997127fd565c93676bd5187d9fa5ec80389 URL: https://github.com/llvm/llvm-project/commit/b590f997127fd565c93676bd5187d9fa5ec80389 DIFF: https://github.com/llvm/llvm-project/commit/b590f997127fd565c93676bd5187d9fa5ec80389.diff

[clang] 8e3d7cf - [NFC][TargetParser] Remove llvm/Support/TargetParser.h

2023-02-07 Thread Archibald Elliott via cfe-commits
Author: Archibald Elliott Date: 2023-02-07T11:08:21Z New Revision: 8e3d7cf5dee8d80dce1004a66c8a375b9d3b5dca URL: https://github.com/llvm/llvm-project/commit/8e3d7cf5dee8d80dce1004a66c8a375b9d3b5dca DIFF: https://github.com/llvm/llvm-project/commit/8e3d7cf5dee8d80dce1004a66c8a375b9d3b5dca.diff

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

2023-02-07 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. Herald added a subscriber: jobnoorman. Friendly ping on this (I think mostly directed at @kito-cheng who was hoping to find time to review the linked abi issue ). CHANGES SINCE LAST ACTION https://reviews.l

[clang-tools-extra] ce6de98 - [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

2023-02-07 Thread via cfe-commits
Author: Sockke Date: 2023-02-07T19:34:54+08:00 New Revision: ce6de98b80ada8efbff93766b5303db5ab052efc URL: https://github.com/llvm/llvm-project/commit/ce6de98b80ada8efbff93766b5303db5ab052efc DIFF: https://github.com/llvm/llvm-project/commit/ce6de98b80ada8efbff93766b5303db5ab052efc.diff LOG: [

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

2023-02-07 Thread gehry via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGce6de98b80ad: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl (authored by Sockke). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138

[PATCH] D138655: [clang-tidy] Fix `cppcoreguidelines-init-variables` for invalid vardecl

2023-02-07 Thread gehry via Phabricator via cfe-commits
Sockke added a comment. @carlosgalvezp Thanks for your review! I committed it myself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138655/new/ https://reviews.llvm.org/D138655 ___ cfe-commits mailing li

[PATCH] D143486: [clangd] Fix a crash in semantic highlighting.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We encounter a few internal repo

[PATCH] D142893: [NFC] Class for building MultilibSet

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 495460. michaelplatings marked 6 inline comments as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142893/new/ https://

[PATCH] D142893: [NFC] Class for building MultilibSet

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:25 namespace driver { /// This corresponds to a single GCC Multilib, or a segment of one controlled peter.smith wrote: > It took a bit of reading to work out what the rel

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

2023-02-07 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3896 + if (D->hasAttrs()) +ToField->setAttrs(D->getAttrs()); ToField->setAccess(D->getAccess()); The import of attributes is handled in function `ASTImporter::Import(Decl*)`. This

[PATCH] D142905: Change multilib selection algorithm

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 495463. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 495464. michaelplatings added a comment. Herald added a subscriber: jobnoorman. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Thanks, it looks mostly good. This needs some work on rebase (as we have landed a few patches that change `StandardLibrary.cpp` file). I will rebase it and land it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1420

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 495477. hokein added a comment. - Rebase to main, and some small tweaks - unittest will be added when landing the https://reviews.llvm.org/D143280 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https:

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 495479. hokein added a comment. add a unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143280/new/ https://reviews.llvm.org/D143280 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc clang/to

[PATCH] D143207: Add codegen for llvm log2/log10 elementwise builtins

2023-02-07 Thread Florian Hahn via Phabricator via cfe-commits
fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jobnoorman. LGTM, thanks! Looks like a straight-forward extension of the existing builtins. Comment at: clang/test/Sema/aarch64-sve-vector-log-ops.c:

[clang] 1ab62d9 - [Tooling/Inclusion] Support multiple headers in the stdlib APIs.

2023-02-07 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-02-07T14:18:13+01:00 New Revision: 1ab62d9d8e964d41da9afa04fa226d300693a261 URL: https://github.com/llvm/llvm-project/commit/1ab62d9d8e964d41da9afa04fa226d300693a261 DIFF: https://github.com/llvm/llvm-project/commit/1ab62d9d8e964d41da9afa04fa226d300693a261.diff LO

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ab62d9d8e96: [Tooling/Inclusion] Support multiple headers in the

[clang] 3599cbd - [include-mapping] Better #includes support for std input/output symbols

2023-02-07 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-02-07T14:19:32+01:00 New Revision: 3599cbd3f6db94e7358dcc901f41c7e357716c77 URL: https://github.com/llvm/llvm-project/commit/3599cbd3f6db94e7358dcc901f41c7e357716c77 DIFF: https://github.com/llvm/llvm-project/commit/3599cbd3f6db94e7358dcc901f41c7e357716c77.diff LO

[PATCH] D143280: [include-mapping] Better #includes support for std input/output symbols

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3599cbd3f6db: [include-mapping] Better #includes support for std input/output symbols (authored by hokein). Repository: rG LLVM Github Monorepo C

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

2023-02-07 Thread Akash Banerjee via Phabricator via cfe-commits
TIFitis updated this revision to Diff 495493. TIFitis marked 4 inline comments as done. TIFitis added a comment. Changed namespace to mlir::LLVM for common files. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/

[PATCH] D143486: [clangd] Fix a crash in semantic highlighting.

2023-02-07 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:524 const auto *Tok = TB.spelledTokenAt(Loc); -assert(Tok); - +if (!Tok) + return std:

[PATCH] D143054: [include-mapping] Regenerate the mappings from the 20220730 html book.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4da283872ad9: [include-mapping] Regenerate the StdSymbolMap.inc from the 20220730 html book. (authored by VitaNuo, committ

[clang] 4da2838 - [include-mapping] Regenerate the StdSymbolMap.inc from the 20220730 html book.

2023-02-07 Thread Haojian Wu via cfe-commits
Author: Viktoriia Bakalova Date: 2023-02-07T14:52:18+01:00 New Revision: 4da283872ad925cbffca94f74800a987cc9ba85f URL: https://github.com/llvm/llvm-project/commit/4da283872ad925cbffca94f74800a987cc9ba85f DIFF: https://github.com/llvm/llvm-project/commit/4da283872ad925cbffca94f74800a987cc9ba85f.

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

2023-02-07 Thread Sergio Afonso via Phabricator via cfe-commits
skatrak created this revision. skatrak added reviewers: dpalermo, jsjodin, domada, raghavendhra. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added

[PATCH] D143486: [clangd] Fix a crash in semantic highlighting.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 495496. hokein marked an inline comment as done. hokein added a comment. add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143486/new/ https://reviews.llvm.org/D143486 Files: clang-tools-extra/clan

[clang-tools-extra] 41a6085 - [clangd] Fix a crash in semantic highlighting.

2023-02-07 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-02-07T14:54:39+01:00 New Revision: 41a6085252efe4c2b806e03d923c0b0b35fc3baa URL: https://github.com/llvm/llvm-project/commit/41a6085252efe4c2b806e03d923c0b0b35fc3baa DIFF: https://github.com/llvm/llvm-project/commit/41a6085252efe4c2b806e03d923c0b0b35fc3baa.diff LO

[PATCH] D143486: [clangd] Fix a crash in semantic highlighting.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41a6085252ef: [clangd] Fix a crash in semantic highlighting. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143214: [include-mapping] Add C-compatibility symbol entries.

2023-02-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 495502. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143214/new/ https://reviews.llvm.org/D143214 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc clang/tools/incl

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

2023-02-07 Thread praveen velliengiri via Phabricator via cfe-commits
pvellien created this revision. pvellien added reviewers: yaxunl, b-sumner. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. pvellien requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: cl

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

2023-02-07 Thread Richard Howell via Phabricator via cfe-commits
rmaz updated this revision to Diff 495512. rmaz edited the summary of this revision. rmaz added a comment. Use FileEntryRef, rename method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143414/new/ https://reviews.llvm.org/D143414 Files: clang/in

[PATCH] D143496: [clangd] Add support for missing includes analysis.

2023-02-07 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D143496: [clangd] Add support for missing includes analysis.

2023-02-07 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 495516. VitaNuo added a comment. Undo turning spellHeader method public. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h

[PATCH] D143496: [clangd] Add support for missing includes analysis.

2023-02-07 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 495517. VitaNuo added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cla

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 495522. sunshaoce added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143478/new/ https://reviews.llvm.org/D143478 Files: clang/include/clang/Driver/Options.h clang/include/clang/Dr

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

2023-02-07 Thread Akash Banerjee via Phabricator via cfe-commits
TIFitis updated this revision to Diff 495530. TIFitis edited the summary of this revision. TIFitis added a comment. Added explicit failure for use_device_ptr and use_device_addr clauses. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ htt

[PATCH] D142905: Change multilib selection algorithm

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 495532. michaelplatings marked an inline comment as done. michaelplatings added a comment. Apply improvements suggested by @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://

[PATCH] D142905: Change multilib selection algorithm

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings added inline comments. Comment at: clang/include/clang/Driver/Multilib.h:31 public: - using flags_list = std::vector; + using flags_list = std::set; + using arg_list = std::vector; peter.smith wrote: > would flags_set be a better name. I'm gue

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

2023-02-07 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. In what cases would this flag be used in practice? I've scanned Clang and couldn't find any answers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143493/new/ https://reviews.llvm.org/D143493 __

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

2023-02-07 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D143493#4110230 , @awarzynski wrote: > In what cases would this flag be used in practice? I've scanned Clang and > couldn't find any answers. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

2023-02-07 Thread Sergio Afonso via Phabricator via cfe-commits
skatrak added a comment. In D143493#4110230 , @awarzynski wrote: > In what cases would this flag be used in practice? I've scanned Clang and > couldn't find any answers. It is introduced to the arguments list in `Clang::AddPreprocessingOptions` in cer

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

2023-02-07 Thread Michael Buch via Phabricator via cfe-commits
Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. **Summary** This patch makes debug-info generation a

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

2023-02-07 Thread Michael Buch via Phabricator via cfe-commits
Michael137 added a comment. Herald added a subscriber: JDevlieghere. The alternative would be attaching the preferred name as a new attribute or an existing attribute like `DW_AT_description`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143501/ne

[PATCH] D143496: [clangd] Add support for missing includes analysis.

2023-02-07 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo updated this revision to Diff 495545. VitaNuo added a comment. Add header spelling to fix suggestion. Fix range to only underline the symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files:

[PATCH] D143233: [Clang][CodeGen] Fix this argument type for certain destructors

2023-02-07 Thread Jacob Young via Phabricator via cfe-commits
jacobly updated this revision to Diff 495543. jacobly added a comment. Added regression test specific to the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143233/new/ https://reviews.llvm.org/D143233 Files: clang/lib/CodeGen/CGCXXABI.h

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

2023-02-07 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. In D143493#4110272 , @skatrak wrote: > It is introduced to the arguments list in `Clang::AddPreprocessingOptions` in > certain cases to add the OpenMP wrapper "__clang_openmp_device_functions.h" > to the list of includes for

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

2023-02-07 Thread Andrew via Phabricator via cfe-commits
browneee added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? s_label : 0; + } else { When `res != NULL`, then `res` is derived from `*s`, not from `s`. e.g. ``` *ret_l

[PATCH] D142932: [NFC] Multilib YAML parsing

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 495554. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib.h clang/lib/Dri

[PATCH] D142933: Add -print-multi-selection-flags argument

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 49. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142933/new/ https://reviews.llvm.org/D142933 Files: clang/include/clang/Driver/Options.td clang/include

[PATCH] D143493: [flang][driver] Add support for -include flag in flang -fc1

2023-02-07 Thread Sergio Afonso via Phabricator via cfe-commits
skatrak added a comment. In D143493#4110323 , @awarzynski wrote: > In D143493#4110272 , @skatrak wrote: > >> It is introduced to the arguments list in `Clang::AddPreprocessingOptions` >> in certain cases to add

[PATCH] D143386: Add function pointer alignment to DataLayout

2023-02-07 Thread Guillaume Chatelet via Phabricator via cfe-commits
gchatelet added a comment. Herald added a subscriber: jobnoorman. In D143386#4107144 , @efriedma wrote: > Almost all the specifications you're specifying are wrong. Very few targets > should be using "i". Off the top of my head, 32-bit ARM, MIPS target

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 495557. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/Too

[PATCH] D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool

2023-02-07 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added a comment. Dupe of https://reviews.llvm.org/D143428 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143461/new/ https://reviews.llvm.org/D143461 ___ cfe-commits mailing list cfe-commits

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 495558. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[PATCH] D143075: BareMetal ToolChain multilib layering

2023-02-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 495559. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 Files: clang/lib/Driver/ToolChains/BareMetal.cpp clang/lib

[PATCH] D143414: [clang] refactor FileManager::GetUniqueIDMapping

2023-02-07 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir added a comment. > This should allow the path serialization of input files to use the paths used > when looking up a file entry, instead of the last reference. Isn't this at odds with not having the VFS-mapped paths? It's not obvious to me why we want these specific semantics. Else

[PATCH] D143507: [RISCV][MC] Mark Zawrs extension as non-experimental

2023-02-07 Thread Alex Bradbury via Phabricator via cfe-commits
asb created this revision. asb added reviewers: reames, craig.topper. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D143461: [ClangScanDeps] Fix data race in `clang-scan-deps` tool

2023-02-07 Thread Argyrios Kyrtzidis via Phabricator via cfe-commits
akyrtzi abandoned this revision. akyrtzi added a comment. In D143461#4110405 , @benlangmuir wrote: > Dupe of https://reviews.llvm.org/D143428 ? Indeed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143461

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

2023-02-07 Thread Viktoriia Bakalova via Phabricator via cfe-commits
VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

2023-02-07 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Please avoid the MLIR style in any other subproject. I know some of the OpenMP Builder stuff already uses `llvm::` and MLIR style names, but that is in itself bad, not something we should extend. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBu

[PATCH] D137756: [z/OS][pg] Throw error when using -pg on z/OS

2023-02-07 Thread Michael Francis via Phabricator via cfe-commits
francii updated this revision to Diff 495570. francii added a comment. Update test case verbosity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/tes

[PATCH] D143446: [clang][deps] Ensure module invocation can be serialized

2023-02-07 Thread Ben Langmuir via Phabricator via cfe-commits
benlangmuir updated this revision to Diff 495573. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143446/new/ https://reviews.llvm.org/D143446 Files: clang/include/clang/Frontend/CompilerInvocation.h clang/lib/Basic/LangOptions.cpp clang/lib/Frontend/CompilerInvocation.cpp clang/te

[PATCH] D143495: [AMDGPU ASAN] Remove reference to asan bitcode library

2023-02-07 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143495/new/ https://reviews.llvm.org/D143495 ___

[clang] 152f291 - [clang][deps] Fix race condition

2023-02-07 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-02-07T09:26:56-08:00 New Revision: 152f2914607ffe632202ee660208d6dfba6c8870 URL: https://github.com/llvm/llvm-project/commit/152f2914607ffe632202ee660208d6dfba6c8870 DIFF: https://github.com/llvm/llvm-project/commit/152f2914607ffe632202ee660208d6dfba6c8870.diff L

[PATCH] D143428: [clang][deps] Fix race condition

2023-02-07 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG152f2914607f: [clang][deps] Fix race condition (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143428/new/ https://reviews.llvm.or

  1   2   >