[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

melver marked an inline comment as done. melver added inline comments. Comment at: clang/test/Driver/fsanitize-metadata-ignorelist.c:6 +// RUN: %clang -target aarch64-linux-gnu -fexperimental-sanitize-metadata=all -fexperimental-sanitize-metadata-ignorelist=%t.good -fexperiment

[clang] dd380f9 - [NFC] Remove the unused parameter introduced in e135476

Author: Chuanqi Xu Date: 2023-02-10T16:03:29+08:00 New Revision: dd380f9243dec95744a43ff73723e85ad77abbdb URL: https://github.com/llvm/llvm-project/commit/dd380f9243dec95744a43ff73723e85ad77abbdb DIFF: https://github.com/llvm/llvm-project/commit/dd380f9243dec95744a43ff73723e85ad77abbdb.diff LO

[clang] 288f688 - [NFC] Add test to show that preprocess an import decl won't require to load it actually

Author: Chuanqi Xu Date: 2023-02-10T16:14:37+08:00 New Revision: 288f688e294a0d2ee162f99f745c06d1e95d3620 URL: https://github.com/llvm/llvm-project/commit/288f688e294a0d2ee162f99f745c06d1e95d3620 DIFF: https://github.com/llvm/llvm-project/commit/288f688e294a0d2ee162f99f745c06d1e95d3620.diff LO

[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

melver updated this revision to Diff 496353. melver marked an inline comment as done. melver added a comment. Make Driver test check that cc1 doesn't receive flag if not required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143664/new/ https://re

[clang] f4ef084 - [OPENMP][NFC] added loop bind to the support page

Author: Sandeep Kosuri Date: 2023-02-10T02:33:44-06:00 New Revision: f4ef08433fe78c31493688f5ab608b2f9689f478 URL: https://github.com/llvm/llvm-project/commit/f4ef08433fe78c31493688f5ab608b2f9689f478 DIFF: https://github.com/llvm/llvm-project/commit/f4ef08433fe78c31493688f5ab608b2f9689f478.diff

[clang] 421215b - [SanitizerBinaryMetadata] Support ignore list

Author: Marco Elver Date: 2023-02-10T10:25:48+01:00 New Revision: 421215b919d037a912cd4fffa73242852da41fc0 URL: https://github.com/llvm/llvm-project/commit/421215b919d037a912cd4fffa73242852da41fc0 DIFF: https://github.com/llvm/llvm-project/commit/421215b919d037a912cd4fffa73242852da41fc0.diff L

[PATCH] D143664: [SanitizerBinaryMetadata] Support ignore list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG421215b919d0: [SanitizerBinaryMetadata] Support ignore list (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

denis-fatkulin updated this revision to Diff 496375. denis-fatkulin added a comment. Review fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143638/new/ https://reviews.llvm.org/D143638 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOu

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

denis-fatkulin marked 3 inline comments as done. denis-fatkulin added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:395 // Bail out in templated classes, as it is hard to spell the class name, i.e // if the template parameter

[PATCH] D143657: [Clang][RISCV] Guard vector float16 type correctly with semantic analysis

eopXD updated this revision to Diff 496382. eopXD added a comment. Update code: use a more scalable way to check for RVV type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143657/new/ https://reviews.llvm.org/D143657 Files: clang/include/clang/

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

kito-cheng accepted this revision. kito-cheng added a comment. LGTM, Verified with GCC and two clang w/ and w/o this patch, clang with this patch is matching GCC's behavior. Also created an PR on psABI to clarify that: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/365 CHANGES SINC

[clang] 65f9719 - Revert "[C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)"

Author: Chuanqi Xu Date: 2023-02-10T17:56:02+08:00 New Revision: 65f9719913eca9c7c72d1abf4eddab767abaebf6 URL: https://github.com/llvm/llvm-project/commit/65f9719913eca9c7c72d1abf4eddab767abaebf6 DIFF: https://github.com/llvm/llvm-project/commit/65f9719913eca9c7c72d1abf4eddab767abaebf6.diff LO

[clang] d768bf9 - [NFC][TargetParser] Replace uses of llvm/Support/Host.h

Author: Archibald Elliott Date: 2023-02-10T09:59:46Z New Revision: d768bf994f508d7eaf9541a568be3d71096febf5 URL: https://github.com/llvm/llvm-project/commit/d768bf994f508d7eaf9541a568be3d71096febf5 DIFF: https://github.com/llvm/llvm-project/commit/d768bf994f508d7eaf9541a568be3d71096febf5.diff

[clang-tools-extra] d768bf9 - [NFC][TargetParser] Replace uses of llvm/Support/Host.h

Author: Archibald Elliott Date: 2023-02-10T09:59:46Z New Revision: d768bf994f508d7eaf9541a568be3d71096febf5 URL: https://github.com/llvm/llvm-project/commit/d768bf994f508d7eaf9541a568be3d71096febf5 DIFF: https://github.com/llvm/llvm-project/commit/d768bf994f508d7eaf9541a568be3d71096febf5.diff

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

uabelho added a comment. Hi, There seems to be something funny going on with the ClangScanDeps/P1689 .cppm testcase added in this patch. It fails randomly for me on top of tree (4ad8f7a189570 )

[clang] baca3c1 - Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-02-10T04:11:54-06:00 New Revision: baca3c150733c89686287ba4927c351eec9695e2 URL: https://github.com/llvm/llvm-project/commit/baca3c150733c89686287ba4927c351eec9695e2 DIFF: https://github.com/llvm/llvm-project/commit/baca3c150733c89686287ba4927c351eec9695e2.dif

[PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

This revision was automatically updated to reflect the committed changes. Closed by commit rGbaca3c150733: Move SIMD alignment calculation to LLVM Frontend (authored by domada). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://revie

[clang] bb8bd8c - [SanitizerBinaryMetadata] Fix ignorelist test under Windows

Author: Marco Elver Date: 2023-02-10T11:24:25+01:00 New Revision: bb8bd8c232e893441937d057a8b32760065c6e1d URL: https://github.com/llvm/llvm-project/commit/bb8bd8c232e893441937d057a8b32760065c6e1d DIFF: https://github.com/llvm/llvm-project/commit/bb8bd8c232e893441937d057a8b32760065c6e1d.diff L

[PATCH] D142893: [NFC] Class for building MultilibSet

peter.smith added a comment. Thanks for the updates, I'm happy with the changes and don't have any more comments. Happy to give my implicit approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142893/new/ https://reviews.llvm.org/D142893 _

[PATCH] D142905: Change multilib selection algorithm

peter.smith added a comment. Thanks for the updates, I'm happy with the changes and don't have any more comments. Happy to give my implicit approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142905/new/ https://reviews.llvm.org/D142905 _

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:188 + callee(functionDecl(hasName("::std::format", +hasAnyArgument(materializeTemporaryExpr( +

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

peter.smith added a comment. Looks good to me. Some small suggestions around execute-only as I expect this to be a useful multilib variant. Comment at: clang/lib/Driver/ToolChain.cpp:198 unsigned FPUKind = llvm::ARM::FK_INVALID; - tools::arm::getARMTargetFeatures(D, Triple

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 496415. michaelplatings marked 7 inline comments as done. michaelplatings added a comment. Incorporate suggestions from @peter.smith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://rev

[PATCH] D143587: [Docs] Multilib design

michaelplatings added a comment. > Could be worth adding a design principles section at the end That was a very helpful suggestion, thank you. Writing them out helped me examine the compatibility story more carefully. Consequently I added a requirement for a "minimumClangVersion" property, alth

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

peter.smith added a comment. A couple of small suggestions but otherwise looks good to me. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:233 + std::string Result = computeBaseSysRoot(getDriver(), getTriple()); + if (!SelectedMultilibs.empty()) { +Result += Selecte

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

covanam created this revision. covanam added reviewers: shchenz, rlavaee, jhenderson, hoyFB, MaskRay, llvm-commits, cfe-commits. Herald added subscribers: kristof.beyls, emaste. Herald added a project: All. covanam requested review of this revision. Herald added a project: LLVM. Support --symboli

[clang] 5cec69b - [clang] Update Clang version from 16 to 17 in scan-build.1.

Author: Frederic Cambus Date: 2023-02-10T13:50:39+01:00 New Revision: 5cec69bb43bc375dabe0d26e9a7aee1c71d00d3f URL: https://github.com/llvm/llvm-project/commit/5cec69bb43bc375dabe0d26e9a7aee1c71d00d3f DIFF: https://github.com/llvm/llvm-project/commit/5cec69bb43bc375dabe0d26e9a7aee1c71d00d3f.dif

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/tweaks/DefineOutlineTests.cpp:89 + // Not available on methods of unnamed classes. + EXPECT_UNAVAILABLE(R"cpp( +s

[PATCH] D139168: [C++20] [Modules] [ClangScanDeps] Enable to print make-style dependency file within P1689 format (4/4)

TWeaver added a comment. @ChuanqiXu Hi there, the revert of this patch has caused the following buildbot to start failing: https://lab.llvm.org/buildbot/#/builders/192/builds/267 It looks as though the removal of the // REQUIRES: !system-windows has caused the test to start running, and theref

[PATCH] D138702: support for HIP non hostcall printf

vikramRH abandoned this revision. vikramRH added a comment. A new implentation is under discussion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138702/new/ https://reviews.llvm.org/D138702 ___ cfe-commi

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

Szelethus added a comment. A small nit, otherwise LGTM. In D143194#4112538 , @balazske wrote: > Probably it is not always useful to explain why the argument is wrong. In > cases when we can find out that the value is exactly between two consecutive > v

[PATCH] D137526: [C++20] [Modules] [NFC] Add Preprocessor methods for named modules - for ClangScanDeps (1/4)

thakis added inline comments. Comment at: clang/unittests/Lex/CMakeLists.txt:21 clangBasic + clangFrontend clangLex It seems strange layering-wise that the Lex unit tests would depend on Frontend. Is there any way to prevent that dep? Repository: rG L

[PATCH] D143560: clang-format.el: fix warnings

DavidTruby accepted this revision. DavidTruby added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang-tools-extra] b252824 - [clangd] fix wrong CalleeArgInfo in the hover

Author: v1nh1shungry Date: 2023-02-10T22:16:16+08:00 New Revision: b252824e6e6ee0959051841e583860ba7ed1cd67 URL: https://github.com/llvm/llvm-project/commit/b252824e6e6ee0959051841e583860ba7ed1cd67 DIFF: https://github.com/llvm/llvm-project/commit/b252824e6e6ee0959051841e583860ba7ed1cd67.diff

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

This revision was automatically updated to reflect the committed changes. Closed by commit rGb252824e6e6e: [clangd] fix wrong CalleeArgInfo in the hover (authored by v1nh1shungry). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142014/new/ https://re

[PATCH] D143734: [NFC][clang][Modules] Refine test checks by adding `:`

Fznamznon created this revision. Fznamznon added reviewers: ChuanqiXu, Bigcheese. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The test can fail if wokring directory where the test was launched has

[clang] 067a5c6 - [amdgpu-arch] Fix build of amdgpu-arch with CLANG_LINK_CLANG_DYLIB

Author: Joseph Huber Date: 2023-02-10T08:23:49-06:00 New Revision: 067a5c68845c13d45e85ec9eaa11d2b2d829bab4 URL: https://github.com/llvm/llvm-project/commit/067a5c68845c13d45e85ec9eaa11d2b2d829bab4 DIFF: https://github.com/llvm/llvm-project/commit/067a5c68845c13d45e85ec9eaa11d2b2d829bab4.diff

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

thakis added a comment. Either this or D139168 is breaking tests on Windows: http://45.33.8.238/win/74780/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D143638: [clangd] Move function body to out-of-line: unnamed class method incorrect moving

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. denis-fatkulin marked 3 inline comments as done. Closed by commit rG04f4c4cc59db: [clangd] Move function body to out-of-line: unnamed class method incorrect… (authored

[clang-tools-extra] 04f4c4c - [clangd] Move function body to out-of-line: unnamed class method incorrect moving

Author: Denis Fatkulin Date: 2023-02-10T17:40:21+03:00 New Revision: 04f4c4cc59db0f4db9cddcc5846d98491d4b65f5 URL: https://github.com/llvm/llvm-project/commit/04f4c4cc59db0f4db9cddcc5846d98491d4b65f5 DIFF: https://github.com/llvm/llvm-project/commit/04f4c4cc59db0f4db9cddcc5846d98491d4b65f5.diff

[PATCH] D143587: [Docs] Multilib design

peter.smith added a comment. Thanks for the update, one nit in the language, otherwise looks good to me. It is a good reflection of the implementation. Comment at: clang/docs/Multilib.rst:250 + +The API need only multilib selection based on only a limited set of command +line

[PATCH] D143735: [clang][dataflow] Convert nonnull pointer parameter to a reference.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The parameter in question belongs to a fu

[PATCH] D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp:188 + callee(functionDecl(hasName("::std::format", +hasAnyArgument(materializeTemporaryExpr( +

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

dmgreen added a comment. Hello - I had to revert this because of some large regressions we got from routines in CMSIS-DSP. The llvm/test/Transforms/PhaseOrdering/ARM/arm_mult_q15.ll test shows the problem - that's why that test exists to ensure that any pipeline changes don't negatively affect

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 496460. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-

[PATCH] D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

tuliom created this revision. tuliom added a reviewer: qiucf. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. tuliom requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ensure the tests do not fail during cros

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 496463. VitaNuo added a comment. Expose API for lookup instead of retrieving the whole map. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-tools-extra

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo added a comment. Thanks for review! Comment at: clang-tools-extra/clangd/Headers.h:164 + llvm::StringMap> + buildMainFileIncludesBySpelling() const { +llvm::StringMap> BySpelling; kadircet wrote: > instead of building this on-demand, what about bu

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4118257 , @dmgreen wrote: > Hello - I had to revert this because of some large regressions we got from > routines in CMSIS-DSP. > > The llvm/test/Transforms/PhaseOrdering/ARM/arm_mult_q15.ll test shows the > problem

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

BigPeet added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142939/new/ https://reviews.llvm.org/D142939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

dmgreen added a comment. > It’s not clear from the original commit message why the test is related to > inlining order? It seems entirely testing vectorization cost model which > should be insensitive to these kind of changes, right? It's a phase ordering test - it's testing the entire pipeline

[PATCH] D142933: Add -print-multi-selection-flags argument

peter.smith added a comment. Thanks for the updates, changes look good to me. I think that we can get away without trying to break the floating point options into flags, at least for how floating point units are available in hardware today. Comment at: clang/lib/Driver/ToolCh

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

balazske updated this revision to Diff 496471. balazske added a comment. change of range descriptions, align comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143194/new/ https://reviews.llvm.org/D143194 Files: clang/lib/StaticAnalyzer/Chec

[PATCH] D143735: [clang][dataflow] Convert nonnull pointer parameter to a reference.

ymandel added a comment. Just realized this is actually more complicated to change, assuming I also want to update all the derived classes. For now, I'll limit the scope of the change to these files, but I'll follow up with an overload-based solution to admit either kind of derived class until

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

balazske updated this revision to Diff 496474. balazske added a comment. fixed another comment format problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143194/new/ https://reviews.llvm.org/D143194 Files: clang/lib/StaticAnalyzer/Checkers/Std

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

balazske updated this revision to Diff 496476. balazske added a comment. fixed another comment format problem Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143194/new/ https://reviews.llvm.org/D143194 Files: clang/lib/StaticAnalyzer/Checkers/Std

[PATCH] D143735: [clang][dataflow] Convert nonnull pointer parameter to a reference.

ymandel updated this revision to Diff 496477. ymandel added a comment. add fixme and fix compilation error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143735/new/ https://reviews.llvm.org/D143735 Files: clang/include/clang/Analysis/FlowSensiti

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

balazske added a comment. I changed the text descriptions to relational operators at some places, this is similar to how other clang analyzer messages look (for example notes at `if` statements), it is shorter, and probably more faster to understand ("<= 0" instead of "non-positive"). Reposit

[PATCH] D143735: [clang][dataflow] Convert nonnull pointer parameter to a reference.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa00f17d81efb: [clang][dataflow] Convert nonnull pointer parameter to a reference. (authored by ymandel). Repository: rG LLVM Github Monorepo CHAN

[clang] a00f17d - [clang][dataflow] Convert nonnull pointer parameter to a reference.

Author: Yitzhak Mandelbaum Date: 2023-02-10T15:53:28Z New Revision: a00f17d81efbd06080761aeef660e5269270a53f URL: https://github.com/llvm/llvm-project/commit/a00f17d81efbd06080761aeef660e5269270a53f DIFF: https://github.com/llvm/llvm-project/commit/a00f17d81efbd06080761aeef660e5269270a53f.diff

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:95 +QualType ArgT, BasicValueFactory &BVF, +DescString &

[PATCH] D143587: [Docs] Multilib design

peter.smith added inline comments. Comment at: clang/docs/Multilib.rst:125 +``-fno-exceptions`` multilib variant need only contain C++ libraries. + +Stability Although implicit in the mechanism, is it worth highlighting that layered multib.yaml authors will need

[PATCH] D143075: BareMetal ToolChain multilib layering

peter.smith added a comment. No comments on the implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143075/new/ https://reviews.llvm.org/D143075 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson created this revision. probinson added reviewers: rjmccall, MaskRay. Herald added a project: All. probinson requested review of this revision. People use -ffunction-sections to put each function into its own object-file section; this makes linker garbage-collection simpler. However, if t

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. This works in my simple test cases, but I'm not 100% sure it's (a) the best place to do this, or (b) the only place that needs to do this. Really we should guarantee that `comdat any` wins over `comdat nodeduplicate` in all cases. CHANGES SINCE LAST ACTION https://

[clang] 7da2d64 - [clang] [extract-api] Don't crash for category in libclang APIs

Author: Daniel Grumberg Date: 2023-02-10T16:30:19Z New Revision: 7da2d644e0398be39e188ea6eacab2a942e0fa7e URL: https://github.com/llvm/llvm-project/commit/7da2d644e0398be39e188ea6eacab2a942e0fa7e DIFF: https://github.com/llvm/llvm-project/commit/7da2d644e0398be39e188ea6eacab2a942e0fa7e.diff LO

[PATCH] D142101: [clang] [extract-api] Don't crash for category in libclang APIs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7da2d644e039: [clang] [extract-api] Don't crash for category in libclang APIs (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.cpp:76 +Out->MainFileIncludesBySpelling.try_emplace(Inc.Written) +.first->second.push_back(static_cast(*Inc.HeaderID)); } right now we're only storing "resolve

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

kadircet added a comment. oh forgot to mention, could you also please add some tests into llvm-project/clang-tools-extra/clangd/unittests/HeadersTests.cpp ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

asb added a comment. @pmatos and I have tried and failed to reproduce the assert in the stage3 msan build locally (both of us on separate machines, different environments). We've reached out to @vitalybuka via email for any help in reproducing, because we're somewhat stumped at the moment. Re

[PATCH] D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4)

TWeaver added a comment. @thakis @ChuanqiXu I have a revision up for review here https://reviews.llvm.org/D143749 that adds back the UNSUPPORTED: system-windows that was reverted in https://reviews.llvm.org/D139168 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D143750: [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2, sgatev. Herald added a subscriber: rnkovacs. Herald added a reviewer: njames93. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Removes a reference to g

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aemerson added a comment. In D143624#4118341 , @dmgreen wrote: >> It’s not clear from the original commit message why the test is related to >> inlining order? It seems entirely testing vectorization cost model which >> should be insensitive to these ki

[PATCH] D143751: [clang][analyzer][NFC] Refactor code of StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D143522: [AMDGPU] Set a data layout entry for buffer descriptors (addrspace 7)

krzysz00 updated this revision to Diff 496515. krzysz00 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Apparently clang has its own copy of this data layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1435

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The token annota

[PATCH] D143750: [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`.

xazax.hun added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/unchecked-optional-access.rst:278 + +Given that ``value()`` has well-defined program termination behavior, why treat +it the same as ``operator*()`` which causes undefined behavior (UB

[PATCH] D143750: [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`.

ymandel updated this revision to Diff 496527. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143750/new/ https://reviews.llvm.org/D143750 Files: clang-tools-extra/docs/clang-tidy/checks/bugprone/unchecke

[PATCH] D143750: [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/unchecked-optional-access.rst:278 + +Given that ``value()`` has well-defined program termination behavior, why treat +it the same as ``operator*

[PATCH] D143755: [clang-format] Add a space between an overloaded operator and '>'

vedgy added a comment. Hi @owenpan. Thank you for fixing this bug! Have you noticed this paragraph in my bug report? > I believe `clang_getTypeSpelling()`, or more likely `QualType::print()` used > by it, should insert a tab character between such tokens to pretty-print > compilable code. The t

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

paulkirth updated this revision to Diff 496529. paulkirth added a comment. Rebase on parent revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143692/new/ https://reviews.llvm.org/D143692 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/

[PATCH] D143587: [Docs] Multilib design

michaelplatings updated this revision to Diff 496533. michaelplatings added a comment. Tweak multilib.yaml spec slightly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143587/new/ https://reviews.llvm.org/D143587 Files: clang/docs/Multilib.rst

[PATCH] D142932: [NFC] Multilib YAML parsing

michaelplatings updated this revision to Diff 496534. michaelplatings added a comment. Make "variants" required Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142932/new/ https://reviews.llvm.org/D142932 Files: clang/include/clang/Driver/Multilib

[PATCH] D143763: [Clang] Add clangMinimumVersion to multilib.yaml

michaelplatings created this revision. michaelplatings added a reviewer: peter.smith. Herald added a subscriber: dmgreen. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This avoids a pot

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4117246 , @vedgy wrote: > In D143418#4116290 , @aaron.ballman > wrote: > >>> So how about a more sincere general solution: setPreferredTempDirPath()? >>> The documentati

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings updated this revision to Diff 496537. michaelplatings added a comment. Add clangMinimumVersion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142986/new/ https://reviews.llvm.org/D142986 Files: clang/lib/Driver/ToolChain.cpp cla

[PATCH] D143059: [NFC] Enable selecting multiple multilibs

michaelplatings updated this revision to Diff 496538. michaelplatings added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143059/new/ https://reviews.llvm.org/D143059 Files: clang/include/clang/Driver/Multilib.h clang/include

[clang-tools-extra] e7e577f - [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`.

Author: Yitzhak Mandelbaum Date: 2023-02-10T18:15:21Z New Revision: e7e577f6842135faaf2c960c7a4e69c71836dc0a URL: https://github.com/llvm/llvm-project/commit/e7e577f6842135faaf2c960c7a4e69c71836dc0a DIFF: https://github.com/llvm/llvm-project/commit/e7e577f6842135faaf2c960c7a4e69c71836dc0a.diff

[PATCH] D143750: [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rGe7e577f68421: [clang-tidy] Clarify documention of `bugprone-unchecked-optional-access`. (authored by ymande

[PATCH] D143692: [clang][driver] Emit error when enabling emulated tls on unsupported architectures

MaskRay accepted this revision. MaskRay added a comment. With nits Comment at: clang/test/Driver/emulated-tls.cpp:49 +// RISCV-NOT: unsupported option '-fno-emulated-tls' for target 'riscv64-unknown-linux-android' +// RISCV-ERROR: unsupported option '-femulated-tls' for targ

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

jhuber6 created this revision. jhuber6 added reviewers: aaronmondal, JonChesterfield, tra, jdoerfert, tianshilei1992. Herald added subscribers: kosarev, mattd, asavonic, kerbowa, tpr, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. He

[clang] 79a3803 - [ClangScanDeps] Add UNSUPPORTED: system-windows to test P1689.cppm

Author: Tom Weaver Date: 2023-02-10T18:29:41Z New Revision: 79a3803bb2ccdd852436cd1653017a1159a12157 URL: https://github.com/llvm/llvm-project/commit/79a3803bb2ccdd852436cd1653017a1159a12157 DIFF: https://github.com/llvm/llvm-project/commit/79a3803bb2ccdd852436cd1653017a1159a12157.diff LOG: [C

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

MaskRay added a comment. > [...] all functions with that attribute end up in a single section, defeating > the linker GC. This can be made preciser. Say we have __attribute__((section("foo"))) void f(i) {} __attribute__((section("foo"))) void g() {} `f` and `g` don't use COMDAT, therefore

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

ldionne added a comment. In D135341#4111884 , @cjdb wrote: > In D135341#4111673 , @ldionne wrote: > >> I've been looking at implementing `reference_constructs_from_temporary` & >> friends and this would be sweet

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

aaronmondal added a comment. Does this address the case where we have HSA headers present on the system? Since this only seems to modify link time behavior, I think building with this flag would still include "hsa/hsa.h" if they were present. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D143768: [Clang] Add options to disable direct linking of arch tools

jhuber6 added a comment. In D143768#4119021 , @aaronmondal wrote: > Does this address the case where we have HSA headers present on the system? > > Since this only seems to modify link time behavior, I think building with > this flag would still include

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

vitalybuka added a comment. In D122215#4118516 , @asb wrote: > @pmatos and I have tried and failed to reproduce the assert in the stage3 > msan build locally (both of us on separate machines, different environments). > We've reached out to @vitalybuka v

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

dmgreen added a comment. > I’ll take a look, but this indicates to me that there’s something missing > from the vectoriser or later passes rather than a problem with the inliners > behaviour. Sure. I'm not saying that this patch is wrong. I'm just saying that unfortunately it leads to some pre

[clang-tools-extra] a543d84 - Fix handling of -> calls for modernize-use-emplace

Author: BigPeet Date: 2023-02-10T18:52:56Z New Revision: a543d840ee0ac53ef9df70c0e2a996e1a222064b URL: https://github.com/llvm/llvm-project/commit/a543d840ee0ac53ef9df70c0e2a996e1a222064b DIFF: https://github.com/llvm/llvm-project/commit/a543d840ee0ac53ef9df70c0e2a996e1a222064b.diff LOG: Fix h

[PATCH] D142939: Fix handling of -> calls for modernize-use-emplace

This revision was automatically updated to reflect the committed changes. Closed by commit rGa543d840ee0a: Fix handling of -> calls for modernize-use-emplace (authored by BigPeet, committed by carlosgalvezp). Changed prior to commit: https://reviews.llvm.org/D142939?vs=493756&id=496552#toc Rep

  1   2   >