[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

klimek added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:287 // owned outside of and handed into the UnwrappedLineParser. + // FIXME: The above fixme doesn't work if we need to create tokens while + // parsing. sammccall wrote: > I'm

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

klimek updated this revision to Diff 497637. klimek marked an inline comment as done. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143070/new/ https://reviews.llvm.org/D143070 Files: clang/lib/Fo

[clang] 7cbbbc0 - clang: Rename misleading test name

Author: Matt Arsenault Date: 2023-02-15T08:32:57-04:00 New Revision: 7cbbbc0a045bf1597972dabd2e071786157c87bf URL: https://github.com/llvm/llvm-project/commit/7cbbbc0a045bf1597972dabd2e071786157c87bf DIFF: https://github.com/llvm/llvm-project/commit/7cbbbc0a045bf1597972dabd2e071786157c87bf.diff

Re: [clang] d05e1e9 - [clang][test][RISCV] Check for __riscv_i in riscv-target-features.c

Addressed in ddb704247b16002d916bba67e3aa9f54fd4bbace - thanks again. Best, Alex On 2023-02-14 20:58, Craig Topper wrote: > I don't have a better idea. > > ~Craig > > On Tue, Feb 14, 2023 at 12:32 PM Alex Bradbury wrote: > >> On 2023-02-14 19:56, Craig Topper wrote: >>> How does this interac

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 497633. pmatos added a comment. Rebased on current HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/clang/AST/Expr.h clang/include/clang/

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 497632. pmatos added a comment. Rebased on current HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/DeclBase.h clang/include/cl

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

pmatos updated this revision to Diff 497630. pmatos added a comment. Rebased against HEAD. Waiting for @vitalybuka go ahead to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.org/D122215 Files: clang/include/

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca added a comment. In D140756#4100387 , @aaron.ballman wrote: > @diseraluca -- do you need this cherry picked into Clang 16 or are you fine > if this goes into Clang 17 instead? Sorry for checking in so late, I noticed the notifications only n

[PATCH] D143989: [AArch64][NFC] Rename AEK_SMEF64 and AEK_SMEI64 feature flags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bb8ead4e9dc: [AArch64][NFC] Rename AEK_SMEF64 and AEK_SMEI64 feature flags (authored by CarolineConcatto). Repository: rG LLVM Github Monorepo

[clang] 5bb8ead - [AArch64][NFC] Rename AEK_SMEF64 and AEK_SMEI64 feature flags

Author: Caroline Concatto Date: 2023-02-15T11:39:00Z New Revision: 5bb8ead4e9dc4a03bddae1f7d3419e97eac37426 URL: https://github.com/llvm/llvm-project/commit/5bb8ead4e9dc4a03bddae1f7d3419e97eac37426 DIFF: https://github.com/llvm/llvm-project/commit/5bb8ead4e9dc4a03bddae1f7d3419e97eac37426.diff

[PATCH] D141666: [RISCV] Proper support of extensions Zicsr and Zifencei

eklepilkina updated this revision to Diff 497620. eklepilkina added a comment. - [RISCV] Prepare work to be ready for adding separate Zicsr and Zifencei extensions - [RISCV] Proper support of extensions Zicsr and Zifencei - Updated I extension verson - Fixing after updating Repository: rG LLV

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff added a comment. In D143919#4123922 , @rjmccall wrote: > In D143919#4123712 , @sepavloff > wrote: > >> In D143919#4123616 , @efriedma >> wrote: >> >>> We have

[PATCH] D143919: [Clang] Copy strictfp attribute from pattern to instantiation

sepavloff updated this revision to Diff 497609. sepavloff added a comment. Changed the way to copy strictfp attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143919/new/ https://reviews.llvm.org/D143919 Files: clang/include/clang/Sema/Sema

[PATCH] D143843: [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG45ddc157ca7c: [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14384

[clang-tools-extra] 45ddc15 - [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions

Author: Carlos Galvez Date: 2023-02-15T10:38:36Z New Revision: 45ddc157ca7c464ebbea627da0f682b1554e2390 URL: https://github.com/llvm/llvm-project/commit/45ddc157ca7c464ebbea627da0f682b1554e2390 DIFF: https://github.com/llvm/llvm-project/commit/45ddc157ca7c464ebbea627da0f682b1554e2390.diff LOG:

[PATCH] D143070: [clang-format] Enable FormatTokenSource to insert tokens.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/FormatTokenSource.h:74 public: - IndexedTokenSource(ArrayRef Tokens) + IndexedTokenSource(SmallVectorImpl &Tokens) : Tokens(T

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo added a comment. Thanks for the review! Comment at: clang-tools-extra/clangd/Headers.cpp:76 +Out->MainFileIncludesBySpelling.try_emplace(Inc.Written) +.first->second.push_back(static_cast(*Inc.HeaderID)); } kadircet wrote: > r

[PATCH] D143509: Move the BySpelling map to IncludeStructure.

VitaNuo updated this revision to Diff 497602. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143509/new/ https://reviews.llvm.org/D143509 Files: clang-too

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n updated this revision to Diff 497598. xen0n added a comment. Document the change in Clang release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141785/new/ https://reviews.llvm.org/D141785 Files: clang/docs/ReleaseNotes.rst clang/i

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

xen0n updated this revision to Diff 497596. xen0n added a comment. Rebase and change to lower the op in LoongArchAsmPrinter so as to make people's lives easier when they come to rebase D141785 on top of this. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

carlosgalvezp added a comment. > That's not so simple. At work we use clang-tidy for few big projects. I had > to explicitly add to some checks `unless(isExpansionInSystemHeader())` to > gain some performance improvement of clang-tidy. This check is one of them. > Problem is that some matchers o

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to control trailing underscore added to external names

clementval added a comment. The pre-commit check is still failing with these tests: Flang :: Fir/alloc.fir Flang :: Fir/embox.fir Flang :: Fir/optional.fir Flang :: Fir/rebox.fir Flang :: Lower/common-block.f90 Flang :: Lower/forall/character-1.f90 CHANGES SINCE LAST ACTION https:/

[PATCH] D144054: [Lex] Fix a crash in updateConsecutiveMacroArgTokens.

hokein added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1023 Partition = All.take_while([&](const Token &T) { - return T.getLocation() >= BeginLoc && T.getLocation() < Limit && - NearLast(T.getLocation()); + // NOTE: the Limit is included

[PATCH] D143194: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGddc5d40dd285: [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly (authored by balazske). Repository: rG LLVM Github Mono

[clang] ddc5d40 - [clang][analyzer] Make messages of StdCLibraryFunctionsChecker user-friendly

Author: Balázs Kéri Date: 2023-02-15T09:22:48+01:00 New Revision: ddc5d40dd285d6422dc66b9aa25064502af3218b URL: https://github.com/llvm/llvm-project/commit/ddc5d40dd285d6422dc66b9aa25064502af3218b DIFF: https://github.com/llvm/llvm-project/commit/ddc5d40dd285d6422dc66b9aa25064502af3218b.diff L

[PATCH] D143148: [clang-repl] Add basic multiline input support

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:260 + std::error_code()); +Token Tok; +do { I think we can simplify the heuristics here by asking if the end source

<    1   2