[PATCH] D143825: [clang-format] Put ports on separate lines in Verilog module headers

sstwcw marked 3 inline comments as done. sstwcw added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2836 + Tok = Tok->getNextNonComment(); + } else if (Tok->is(tok::hashhash)) { +// Concatenation. Skip. MyDeveloperDay wrot

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp created this revision. dkrupp added a reviewer: Szelethus. dkrupp added a project: clang. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, JDevlieghere, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a revi

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb abandoned this revision. krisb added a comment. Abandon in favor of https://discourse.llvm.org/t/rfc-dwarfdebug-fix-and-improve-handling-imported-entities-types-and-static-local-in-subprogram-and-lexical-block-scopes/68544. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144188: Tighten up a modules test

This revision was automatically updated to reflect the committed changes. Closed by commit rG17a90f1196c1: Tighten up a modules test (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144188/new/ ht

[clang] 17a90f1 - Tighten up a modules test

Author: Paul Robinson Date: 2023-02-17T06:35:01-08:00 New Revision: 17a90f1196c1a4b48b8d02c055497565ce5c785d URL: https://github.com/llvm/llvm-project/commit/17a90f1196c1a4b48b8d02c055497565ce5c785d DIFF: https://github.com/llvm/llvm-project/commit/17a90f1196c1a4b48b8d02c055497565ce5c785d.diff

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet added a comment. thanks for the review! Comment at: clang-tools-extra/clangd/Preamble.cpp:509 + // Check if AlternateLine matches all lines in the range. + if (llvm::any_of( + llvm::zip_equal(RangeContents, sammccall wrote: > why

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet updated this revision to Diff 498351. kadircet marked 4 inline comments as done. kadircet added a comment. - Use direct comparison of ArrayRefs - optional for closest - loop over lookup results rather than through iterator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

krisb created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez. krisb added projects: LLVM, debug-info. krisb published this revision for review. Herald added a project: clang. He

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134902 , @erichkeane wrote: > In D144192#4134900 , @philnik wrote: > >> In D144192#4134894 , @erichkeane >> wrote: >> >>> In D144192

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

krisb created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a reviewer: sscalpone. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez, ellis. krisb added projects: LLVM, debug-info. krisb publishe

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez. krisb added projects: LLVM, debug-info. krisb published this revision for review. Herald added a project: clang. He

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane added a comment. In D144192#4134900 , @philnik wrote: > In D144192#4134894 , @erichkeane > wrote: > >> In D144192#4134893 , @philnik >> wrote: >> >>> In D1441

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134894 , @erichkeane wrote: > In D144192#4134893 , @philnik wrote: > >> In D144192#4134887 , @erichkeane >> wrote: >> >>> Looks like

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane added a comment. In D144192#4134893 , @philnik wrote: > In D144192#4134887 , @erichkeane > wrote: > >> Looks like I have ot abandon this now? Anyway, fix was committed, but I >> forgot the differenti

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

philnik added a comment. In D144192#4134887 , @erichkeane wrote: > Looks like I have ot abandon this now? Anyway, fix was committed, but I > forgot the differential-revision line. You can also Close the revision instead of abandoning it to make it obv

[PATCH] D139741: [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf6c0b6d8c9d: [clang][CodeGen] Use base subobject type layout for potentially-overlapping… (authored by dzhidzhoev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] af6c0b6 - [clang][CodeGen] Use base subobject type layout for potentially-overlapping fields

Author: Vladislav Dzhidzhoev Date: 2023-02-17T15:11:42+01:00 New Revision: af6c0b6d8c9dc52485d56e82f79a03de09aa188f URL: https://github.com/llvm/llvm-project/commit/af6c0b6d8c9dc52485d56e82f79a03de09aa188f DIFF: https://github.com/llvm/llvm-project/commit/af6c0b6d8c9dc52485d56e82f79a03de09aa188

[PATCH] D144192: GH60642: Fix ICE when checking a lambda defined in a concept definition

erichkeane abandoned this revision. erichkeane added a comment. Looks like I have ot abandon this now? Anyway, fix was committed, but I forgot the differential-revision line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144192/new/ https://reviews.llvm.org/D144192 __

[clang] 4bf6cc6 - GH60642: Fix ICE when checking a lambda defined in a concept definition

Author: Erich Keane Date: 2023-02-17T06:09:52-08:00 New Revision: 4bf6cc63aa77a7fea7e410f7d45899abcde2b58a URL: https://github.com/llvm/llvm-project/commit/4bf6cc63aa77a7fea7e410f7d45899abcde2b58a DIFF: https://github.com/llvm/llvm-project/commit/4bf6cc63aa77a7fea7e410f7d45899abcde2b58a.diff L

[clang] 06621ec - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-02-17T15:08:50+01:00 New Revision: 06621ecdaf416d87968dcaf57a634c83cf0dc1b8 URL: https://github.com/llvm/llvm-project/commit/06621ecdaf416d87968dcaf57a634c83cf0dc1b8 DIFF: https://github.com/llvm/llvm-project/commit/06621ecdaf416d87968dcaf57a634c83cf0dc1b8.diff

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

PiotrZSL added a comment. I run this check on project that I work for, here my comments: False-positives (for me) std::optional&& obj + std::move(opj.value()); std::pair&& obj+ std::forward>(obj); Type1&& factory + factory.create() [on initialization list] (create is not && method) Type

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers planned changes to this revision. vabridgers added a comment. Changes are planned. Please do not waste any more time on this for now. This will probably be abandoned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142822/new/ https://rev

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

whisperity added a subscriber: vabridgers. whisperity added a comment. @vabridgers Please take a look at this, as per off-list discussion, in relation to D142822 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1405

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

whisperity added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:4627 } else { -Type *newType = - new (*this, TypeAlignment) InjectedClassNameType(Decl, TST); +Type *newType = new (*this, TypeAlignment) InjectedClassNameType(Decl, TST); Decl->TypeF

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/dcl58-cpp.cpp:5-6 + +// On arm and arch64 architectures, va_list is within the std namespace. +// D136886 exposed an issue in the cert-dcl58-cpp checker where +// implicit namespaces wer

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cert/dcl58-cpp.cpp:3 +// RUN: %check_clang_tidy -std=c++17-or-later %s cert-dcl58-cpp %t -- -- -I %clang_tidy_headers -target aarch64 +// RUN: %check_clang_tidy -std=c++17-or-later %s cert-d

[clang] 4901245 - Fix Clang sphinx build

Author: Aaron Ballman Date: 2023-02-17T07:57:31-05:00 New Revision: 4901245481b6588056638b8fc38598615039314a URL: https://github.com/llvm/llvm-project/commit/4901245481b6588056638b8fc38598615039314a DIFF: https://github.com/llvm/llvm-project/commit/4901245481b6588056638b8fc38598615039314a.diff

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG thanks! Comment at: clang-tools-extra/clangd/Preamble.cpp:496 +auto CurrentStartIt = CurrentContentsToLine.find(OldLines[OldStart]); +if (CurrentStartIt == C

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:625 +// same spelling. +static std::vector patchDiags(llvm::ArrayRef BaselineDiags, +const ScannedPreamble &BaselineScan, sammccall wrote: > I th

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet updated this revision to Diff 498308. kadircet marked 6 inline comments as done. kadircet added a comment. - Move patch translation logic to a separate class - Perform eager copies and use `bool translateX(X&)` type of APIs instead of returning optionals. - Perform multi line content che

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal added a comment. In D138037#4129160 , @xazax.hun wrote: > I am ok with committing this to unblock people hitting this assert, but at > the same time I wonder if we want to open a ticket on GitHub that we might > want to rethink how some of this

[clang] f3fa108 - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-02-17T11:56:00+01:00 New Revision: f3fa1086c7f83edcc473724a8ac7d675a9df11d7 URL: https://github.com/llvm/llvm-project/commit/f3fa1086c7f83edcc473724a8ac7d675a9df11d7 DIFF: https://github.com/llvm/llvm-project/commit/f3fa1086c7f83edcc473724a8ac7d675a9df11d7.diff

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

steakhal added a comment. I'm backporting this as #60834 to the 16.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138037/new/ https://reviews.llvm.org/D138037 __

[PATCH] D138037: [analyzer] Remove unjustified assertion from EQClass::simplify

This revision was automatically updated to reflect the committed changes. Closed by commit rGafcf70aa6de7: [analyzer] Remove unjustified assert from EquivalenceClass::simplify (authored by steakhal). Changed prior to commit: https://reviews.llvm.org/D138037?vs=475480&id=498301#toc Repository:

[clang] afcf70a - [analyzer] Remove unjustified assert from EquivalenceClass::simplify

Author: Balazs Benics Date: 2023-02-17T11:37:02+01:00 New Revision: afcf70aa6de77a0e99f6cb2d3e3824049203d6e2 URL: https://github.com/llvm/llvm-project/commit/afcf70aa6de77a0e99f6cb2d3e3824049203d6e2 DIFF: https://github.com/llvm/llvm-project/commit/afcf70aa6de77a0e99f6cb2d3e3824049203d6e2.diff

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM thanks! Let's give a couple more days for last reviews. It probably needs a rebase since the Release Notes have got a couple more checks. Repository: rG LLVM Github Monor

[PATCH] D144216: [clang-tidy] Extract string header from redundant-string-cstr checker

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/redundant-string-cstr.cpp:1 -// RUN: %check_clang_tidy %s readability-redundant-string-cstr %t - -typedef unsigned __INT16_TYPE__ char16; -typedef unsigned __INT32_TYPE__ char

[PATCH] D144003: [clang][analyzer] Improve bug reports of StdLibraryFunctionsChecker.

balazske added a comment. The plan is to bring the checker out of the alpha package, the bug reports should be good enough for that. To modify bug report text generation a new patch would be better, after the current is finished. Maybe all single numbers in all allowed ranges that are 1, 2 (or

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG159073bc0a87: [clang-repl] Support compound statement as a top-level statement. (authored by v.g.vassilev). Herald added a

[clang] 159073b - [clang-repl] Support compound statement as a top-level statement.

Author: Vassil Vassilev Date: 2023-02-17T09:09:04Z New Revision: 159073bc0a873b9aa2bc559a8ceba970b049cda2 URL: https://github.com/llvm/llvm-project/commit/159073bc0a873b9aa2bc559a8ceba970b049cda2 DIFF: https://github.com/llvm/llvm-project/commit/159073bc0a873b9aa2bc559a8ceba970b049cda2.diff LO

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

v.g.vassilev added a comment. This seems like a good candidate for a post commit review. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139798/new/ https://reviews.llvm.org/D139798 ___ cfe-commits mailing list cfe-commi

[clang] 57c8191 - [Clang] Convert update_cc_test_checks tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-02-17T09:07:15+01:00 New Revision: 57c81917d3a596f925f1c072ad04425b66bbd80e URL: https://github.com/llvm/llvm-project/commit/57c81917d3a596f925f1c072ad04425b66bbd80e DIFF: https://github.com/llvm/llvm-project/commit/57c81917d3a596f925f1c072ad04425b66bbd80e.diff

<    1   2