[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

nridge updated this revision to Diff 500087. nridge added a comment. use Constant rather than Variable for object-like macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/new/ https://reviews.llvm.org/D144703 Files: clang-tools-extra/cla

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added a comment. In D144696#4149516 , @craig.topper wrote: > Can you outline your full plan and why you want to do this. We need to see > the bigger picture. In D144696#4149545 , @ym1813382441 w

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

craig.topper added a comment. In D144696#4149545 , @ym1813382441 wrote: > F26630797: Screenshot from 2023-02-24 15-54-21.png > I meant what extensions are you planning to support multiple versions for and why? How

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

uabelho added a comment. Hello, I noticed that if I compile the compiler with ubsan, then lots of Clangd tests start failing with this patch: Failed Tests (165): Clangd :: ast-no-range.test Clangd :: ast.test Clangd :: call-hierarchy.test Clangd :: check-lines.test Clangd

[PATCH] D144646: [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144646/new/ https://reviews.llvm.org/D144646

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added a comment. In D144696#4149560 , @craig.topper wrote: > In D144696#4149545 , @ym1813382441 > wrote: > >> F26630797: Screenshot from 2023-02-24 15-54-21.png >>

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

balazske added a comment. Probably we can add a new function `ASTContext::getVaListTagDeclIfExists` that does not create declarations if these do not exist. These new mentioned test cases would probably fail, but with a new non-modifying get function it can work. Repository: rG LLVM Github

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

pcwang-thead added a comment. > My intention is to support RVV0.71, since specific cpu's exist for the > XuanTie C900 series. In LLVM use Feature to distinguish between different > versions of extensions. I am considering how to solve this problem, using > multiple `.td` files in the worst case

[PATCH] D144707: [C++20] [Modules] Deprecate to load C++20 Named Modules eagerly

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, dblaikie, Bigcheese. ChuanqiXu added a project: clang-modules. Herald added a subscriber: jvesely. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: c

[PATCH] D144708: [clangd] Fix UB in scanPreamble

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. getMemBufferCop

[PATCH] D142890: [clangd] Add config option for fast diagnostics mode

kadircet added a comment. In D142890#4149181 , @vitalybuka wrote: > One of your patches likely introduced UB > https://lab.llvm.org/buildbot/#/builders/85/builds/14558 > Can you please take a look? Thanks a lot Vitaly and sorry for not noticing this my

[PATCH] D143096: [clangd] Provide patched diagnostics with preamble patch

kadircet added a comment. thanks for the ping! see the discussion in https://reviews.llvm.org/D142890#4149679 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143096/new/ https://reviews.llvm.org/D143096 _

[PATCH] D144707: [C++20] [Modules] Deprecate to load C++20 Named Modules eagerly

ChuanqiXu added a comment. For example, the issue (https://github.com/llvm/llvm-project/issues/60085) disappears after we change the eagerly loading to lazily loading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144707/new/ https://reviews.llvm.

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

craig.topper added a comment. How much of the existing vector code in the backend including tablegen can be reused for 0.71? How much of the intrinsic interface can be used? If we’re talking about completely duplicating everything it is very unlikely we can accept it. RISCVGenDAGISel.inc, for e

[PATCH] D144708: [clangd] Fix UB in scanPreamble

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:351 auto PreambleContents = - llvm::MemoryBuffer::getMemBufferCopy(Contents.substr(0, Bounds.Size)); + llvm

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf created this revision. Herald added a project: All. AlexanderHederstaf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Qualifiers were not moved for non-pointer non-simple types. Remove the requirement for *,&,&& and

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks an improvement to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/new/ https://reviews.llvm.org/D144703 ___

[PATCH] D143560: clang-format.el: fix warnings

phst added a comment. I'm not super familiar with the process either, but IIRC @sammccall or @djasper have to merge this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf added a reviewer: MyDeveloperDay. AlexanderHederstaf added a comment. I tried to refactor QualifierAlignmentFixer to handle more types, notably removing the *,&,&& requirement as e.g. const Foo did not work. To avoid moving qualifiers too far, a test for "already east const" i

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

asb added a comment. @ym1813382441 thanks for the contribution. In many cases, this kind of incremental and tightly focused patch is a good way to start things. But in this case, there's a few bigger issues. - As has been pointed out, the discussion about supporting multiple ISA versions has b

[PATCH] D144708: [clangd] Fix UB in scanPreamble

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:351 auto PreambleContents = - llvm::MemoryBuffer::getMemBufferCopy(Contents.substr(0, Bounds.Size)); + llvm::MemoryBuffer::getMemBufferCopy(PI

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

ym1813382441 added a comment. In D144696#4149706 , @craig.topper wrote: > How much of the existing vector code in the backend including tablegen can be > reused for 0.71? How much of the intrinsic interface can be used? If we’re > talking about complet

[clang-tools-extra] c4972d3 - [clangd] Avoid using CompletionItemKind.Text for macro completions

Author: Nathan Ridge Date: 2023-02-24T04:41:27-05:00 New Revision: c4972d37290ff5ab1228ecfc7280bc07a9280f92 URL: https://github.com/llvm/llvm-project/commit/c4972d37290ff5ab1228ecfc7280bc07a9280f92 DIFF: https://github.com/llvm/llvm-project/commit/c4972d37290ff5ab1228ecfc7280bc07a9280f92.diff

[PATCH] D144703: [clangd] Avoid using CompletionItemKind.Text for macro completions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4972d37290f: [clangd] Avoid using CompletionItemKind.Text for macro completions (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144703/n

[clang-tools-extra] f393e1f - [clangd] Fix UB in scanPreamble

Author: Kadir Cetinkaya Date: 2023-02-24T10:43:12+01:00 New Revision: f393e1f6b3b42e8f355e64e2fb479c571ab939bc URL: https://github.com/llvm/llvm-project/commit/f393e1f6b3b42e8f355e64e2fb479c571ab939bc DIFF: https://github.com/llvm/llvm-project/commit/f393e1f6b3b42e8f355e64e2fb479c571ab939bc.dif

[PATCH] D144708: [clangd] Fix UB in scanPreamble

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rGf393e1f6b3b4: [clangd] Fix UB in scanPreamble (authored by kadircet). Changed prior to commit: https://

[clang] 385c8cd - [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t

Author: Kadir Cetinkaya Date: 2023-02-24T10:44:33+01:00 New Revision: 385c8cd3cd66052dee2dff01bfdbeb258191f2ff URL: https://github.com/llvm/llvm-project/commit/385c8cd3cd66052dee2dff01bfdbeb258191f2ff DIFF: https://github.com/llvm/llvm-project/commit/385c8cd3cd66052dee2dff01bfdbeb258191f2ff.dif

[PATCH] D144696: [RISCV][NFC] Package version number information using RISCVExtensionVersion.

pcwang-thead added a comment. In D144696#4149706 , @craig.topper wrote: > How much of the existing vector code in the backend including tablegen can be > reused for 0.71? How much of the intrinsic interface can be used? If we’re > talking about complet

[PATCH] D144646: [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG385c8cd3cd66: [Tooling][Inclusions] Add c-header and global namespace alternatives for size_t (authored by kadircet). Repository: rG LLVM Github M

[clang] e6e753d - [clang][dataflow] Fix wrong assert for CXXConstructExpr

Author: Paul Semel Date: 2023-02-24T09:51:10Z New Revision: e6e753d173db14bb1273db65387dec696b7d7a48 URL: https://github.com/llvm/llvm-project/commit/e6e753d173db14bb1273db65387dec696b7d7a48 DIFF: https://github.com/llvm/llvm-project/commit/e6e753d173db14bb1273db65387dec696b7d7a48.diff LOG: [c

[PATCH] D144546: [clang][dataflow] Fix assert for CXXConstructExpr argument number

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6e753d173db: [clang][dataflow] Fix wrong assert for CXXConstructExpr (authored by paulsemel). Herald added a subscriber: cfe-commits. Repository:

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin updated this revision to Diff 500117. cor3ntin marked 18 inline comments as done. cor3ntin added a comment. Address Shafik's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clan

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 500121. klimek marked 6 inline comments as done. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/includ

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22584 + Style.Macros.push_back("CALL(x)=f([] { x })"); + Style.Macros.push_back("ASSIGN_OR_RETURN(a, b, c)=a = (b) || (c)"); + sammccall wrote: > klimek wrote: > > sammccall wrote:

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144713 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSym

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

kadircet added inline comments. Comment at: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.inc:242 +// Macros +SYMBOL(NULL, , ) +SYMBOL(NULL, , ) we use `None` for global namespace rather than leaving empty. let's keep it that way? Repository: rG LL

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

hokein updated this revision to Diff 500126. hokein added a comment. oops, fix the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144713/new/ https://reviews.llvm.org/D144713 Files: clang/lib/Tooling/Inclusions/Stdlib/StdSpecialSymbolMap.in

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144713/new/ https://reviews.llvm.org/D144713

[PATCH] D144273: [clang][ASTImporter] Add VaList declaration to lookup table.

donat.nagy added a comment. @balazske Thanks for clarifying the side effects of the current solution and I support creating that side-effect-free getter function -- it sounds to be a good solution for this problem. One minor doubt: I can theoretically imagine the case when the TU object doesn't

[PATCH] D144709: [clang-format] Improve west to east const

MyDeveloperDay added a comment. Can you please add unit tests for the cases you added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 ___ cfe-commits mailing li

[clang] c86f05d - [Tooling/Inclusion] Add the missing NULL symbol to the table.

Author: Haojian Wu Date: 2023-02-24T12:59:52+01:00 New Revision: c86f05dd48d2efc5d1bb7c9962ba331653311795 URL: https://github.com/llvm/llvm-project/commit/c86f05dd48d2efc5d1bb7c9962ba331653311795 DIFF: https://github.com/llvm/llvm-project/commit/c86f05dd48d2efc5d1bb7c9962ba331653311795.diff LO

[PATCH] D144713: [Tooling/Includsion] Add the missing NULL symbol to the table.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGc86f05dd48d2: [Tooling/Inclusion] Add the missing NULL symbol to the table. (authored by hokein). Repositor

[PATCH] D143560: clang-format.el: fix warnings

MyDeveloperDay added subscribers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. MyDeveloperDay added a comment. I'm one of the code owners for clang-format, but I'm not an emacs user (don't hate me..), honestly I don't think you'll get a response from anyone others than the clang-format

[PATCH] D143560: clang-format.el: fix warnings

MyDeveloperDay added a comment. please mark the comments as done when you've addressed them CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143560/new/ https://reviews.llvm.org/D143560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great! The overloading impl is a little surprising to me. I was assuming that object would always win over function (or that it would be disallowed to combine the two). I think that is s

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/60964 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144721

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf added a comment. I will add new tests / examples as well as look into the volatile/const ordering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 _

[PATCH] D143496: [clangd] Add support for missing includes analysis.

kadircet added a comment. thanks! looks amazing, we're missing a little bit of test coverage though Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:280 +bool isFilteredByConfig(const Config &Cfg, llvm::StringRef HeaderSpelling) { + // Convert the path to Unix slashes

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

kadircet added a comment. this fixes the `abs` in the mentioned issue, but leaves the friends out :( those are specifically `std::labs, std::llabs, std::imaxabs` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144721/new/ https://reviews.llvm.org/D1

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

hokein added a comment. In D144721#4150122 , @kadircet wrote: > this fixes the `abs` in the mentioned issue, but leaves the friends out :( > those are specifically `std::labs, std::llabs, std::imaxabs` These symbols are already covered in the generated

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. oh right, i thought these were also provided by multiple headers, but looks like they're only provided by `cstdlib`, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang-tools-extra] 6b0cf1e - [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

Author: isuckatcs Date: 2023-02-24T13:46:47+01:00 New Revision: 6b0cf1e15f8f84e3d4b6f9522287f6460527a7bf URL: https://github.com/llvm/llvm-project/commit/6b0cf1e15f8f84e3d4b6f9522287f6460527a7bf DIFF: https://github.com/llvm/llvm-project/commit/6b0cf1e15f8f84e3d4b6f9522287f6460527a7bf.diff LOG

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b0cf1e15f8f: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer` (authored by isuckatcs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135495/ne

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. @rupprecht Great to hear! Sorry again for the disruption @shafik Thanks for the review! Comment at: clang/lib/Sema/SemaLambda.cpp:1010 + + // C++11 [expr.prim.lambda]p5: + // The closure type for a lambda-expression has a public inline function --

[clang] 4416e4a - [Tooling/Inclusion] Add the generic abs symbol to the table.

Author: Haojian Wu Date: 2023-02-24T13:56:00+01:00 New Revision: 4416e4a9ed0666cbeb3d34f43337d7205c09521a URL: https://github.com/llvm/llvm-project/commit/4416e4a9ed0666cbeb3d34f43337d7205c09521a DIFF: https://github.com/llvm/llvm-project/commit/4416e4a9ed0666cbeb3d34f43337d7205c09521a.diff LO

[PATCH] D144721: [Tooling/Inclusion] Add the generic abs symbol to the table.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4416e4a9ed06: [Tooling/Inclusion] Add the generic abs symbol to the table. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144684: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144684/new/ https://reviews.llvm.org/D144684 ___ cfe

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

aaron.ballman added reviewers: jyknight, clang-language-wg. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:43-45 +- The definition of ``USHRT_MAX`` in the freestanding no longer + overflows on AVR (where ``sizeof(unsigned int) == sizeof(unsigne

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

ManuelJBrito updated this revision to Diff 500149. ManuelJBrito added a comment. Update tests after D143593 . There are some performance regressions with casts from 128 to 512. The backend inserts vinsertf instructions. So that as to be fixed. In D130339

[PATCH] D143524: Make the -Wunused-template default.

aaron.ballman added a comment. In D143524#4148024 , @v.g.vassilev wrote: > Indeed the warning is noisy but it will potentially fix broken code which > were unable to diagnose before. Especially that in some cases where static > templates in header file

[PATCH] D143524: Make the -Wunused-template default.

v.g.vassilev added a comment. In D143524#4150286 , @aaron.ballman wrote: > In D143524#4148024 , @v.g.vassilev > wrote: > >> Indeed the warning is noisy but it will potentially fix broken code which >> were unab

[PATCH] D144269: [Analyzer] Show "taint originated here" note of alpha.security.taint.TaintPropagation checker at the correct place

dkrupp added a comment. > TaintBugReport is brilliant and we already have a precedent for subclassing > BugReport in another checker. However I'm somewhat worried that once we start > doing more of this, we'll eventually end up with multiple inheritance > situations when the report needs multip

[PATCH] D144115: [clang] Extend pragma dump to support expressions

aaron.ballman added a comment. In D144115#4148026 , @Endill wrote: > Despite having a dozen of `#pragma __debug` directives, none of them are > tested neither mentioned in any kind of documentation, including release > notes. Are you sure about this? If

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall created this revision. Herald added a subscriber: wenlei. Herald added a reviewer: NoQ. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is just a draft and a starting point, and needs mo

[PATCH] D143524: Make the -Wunused-template default.

aaron.ballman added a comment. In D143524#4150289 , @v.g.vassilev wrote: > In D143524#4150286 , @aaron.ballman > wrote: > >> In D143524#4148024 , @v.g.vassilev >> wrote

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall updated this revision to Diff 500166. sammccall added a comment. A little more docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files: clang/examples/CMakeLists.txt clang/examples/FlowSe

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall added a comment. Example textual log (though better with colors): === Beginning data flow analysis === int target(int x) { while (x > 0) { --x; } return x + 1; } FunctionDecl 0x2a9a300 line:1:5 target 'int (int)' |-ParmVarDecl

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall updated this revision to Diff 500172. sammccall added a comment. Fix colors, log source Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144730/new/ https://reviews.llvm.org/D144730 Files: clang/examples/CMakeLists.txt clang/examples/Fl

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4148003 , @vedgy wrote: > In D143418#4147578 , @aaron.ballman > wrote: > >> In D143418#4131156 , @vedgy wrote: >> >>> On second

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

erichkeane added a comment. That looks reasonable to me, though I fear all the libcxx failures are going to be related to this, please make sure to check them out! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144626/new/ https://reviews.llvm.org/D144626 __

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 500181. klimek marked 5 inline comments as done. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/includ

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:172 assert(defined(ID->TokenText)); + assert( + (!OptionalArgs && ObjectLike.find(ID->TokenText) != ObjectLike.end()) || sammccall wrote: > this assertion failure isn't going to

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Adding Erich as he's more familiar with ifunc and friends. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:345 + const llvm::GlobalValue *&GV, +

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a comment. Btw, these changes should come with a release note as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143803/new/ https://reviews.llvm.org/D143803 ___ cfe-commits maili

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane added a comment. >> which confuses me because an extern "C" block is not supposed to mangle any >> names, right? Appreciate any inputs on this. That IS strange, that has internal linkage, but so the 'extern "C"' doesn't do anything to it, so we choose to just mangle it. I guess ther

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman edited reviewers, added: erichkeane, royjacobson, clang-language-wg; removed: mizvekov. aaron.ballman added a subscriber: rjmccall. aaron.ballman added a comment. In D140996#4125177 , @bolshakov-a wrote: > @aaron.ballman, @rsmith, @mizveko

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

sammccall added a comment. Still LG Comment at: clang/lib/Format/MacroExpander.cpp:172 assert(defined(ID->TokenText)); + assert( + (!OptionalArgs && ObjectLike.find(ID->TokenText) != ObjectLike.end()) || klimek wrote: > sammccall wrote: > > this assert

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

erichkeane added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V)

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek updated this revision to Diff 500191. klimek added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144170/new/ https://reviews.llvm.org/D144170 Files: clang/include/clang/Format/Format.h clang/lib/Forma

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

klimek added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:4592 + !Macros.hasArity(ID->TokenText, Args->size())) { +// The macro is overloaded to be both object-like and function-like, +// but none of the function-like arities matc

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

aaron.ballman added a comment. Generally LGTM with a few comments sprinkled around. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[TypedefName], ErrorDiag>; +} pmatos wrote:

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added a reviewer: erichkeane. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:456 - class ArrayOrMatrixSubscriptExprBitfields { + class AMTSubscriptExprBitfields { friend class ArraySubscriptExpr; I am not ce

[PATCH] D144170: [clang-format] Add simple macro replacements in formatting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01402831aaae: [clang-format] Add simple macro replacements in formatting. (authored by klimek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0140283 - [clang-format] Add simple macro replacements in formatting.

Author: Manuel Klimek Date: 2023-02-24T15:44:24Z New Revision: 01402831aaae76e9c61595f9aa81a506b0d926eb URL: https://github.com/llvm/llvm-project/commit/01402831aaae76e9c61595f9aa81a506b0d926eb DIFF: https://github.com/llvm/llvm-project/commit/01402831aaae76e9c61595f9aa81a506b0d926eb.diff LOG:

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

0xdc03 added a comment. I will try to come up with a better diagnostic for this issue and will try and update the patch as soon as I can. In D143803#4150423 , @aaron.ballman wrote: > Btw, these changes should come with a release note as well. Are all

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf updated this revision to Diff 500215. AlexanderHederstaf added a comment. Fixed the const/volatile placement. Added a few tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 Files:

[PATCH] D143704: [Flang] Part one of Feature List action

jdoerfert added a comment. can we have a test? Comment at: flang/examples/FeatureList/FeatureList.cpp:605 + template bool Pre(const std::variant &) { return true; } + template void Post(const std::variant &) {} +}; Can you record the features we missed so

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. Roping in Erich as the attributes code owner. In general, I think this is going in roughly the right direction. One concern I have is that the distinction between a keyword spelling for an attribute is now a bit harder. W

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

vedgy added a comment. In D143418#4150360 , @aaron.ballman wrote: > So my intuition is that the current behavior works well enough and I doubt > anyone's going to propose changes to it in the future. So adding the `GlobalOptions` member to `CXIndexOpti

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added a comment. In D143803#4150624 , @0xdc03 wrote: > In D143803#4150423 , @aaron.ballman > wrote: > >> Btw, these changes should come with a release note as well. > > Are all functional changes lo

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:359-360 +if (ND->getName() == GV->getName()) { + Diags.Report(Location, diag::note_alias_requires_mangled_name) + << GV->getName() << Name; +} ---

[PATCH] D144730: [FlowSensitive][WIP] log analysis progress for debugging purposes

sammccall added a comment. I wanted to share this to get some initial thoughts as we'd discussed debuggability a while ago. As mentioned I'd at least want to get a reasonable HTML report before moving forward with it though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D143418: [libclang] Add API to set preferred temp dir path

aaron.ballman added a comment. In D143418#4150724 , @vedgy wrote: > In D143418#4150360 , @aaron.ballman > wrote: > >> So my intuition is that the current behavior works well enough and I doubt >> anyone's going

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

ahatanak updated this revision to Diff 500222. ahatanak added a comment. Remove AddressImpl altogether. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144686/new/ https://reviews.llvm.org/D144686 Files: clang/lib/CodeGen/Address.h Index: clang/l

[PATCH] D143803: [clang][alias|ifunc]: Add a diagnostic for mangled names

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:359-360 +if (ND->getName() == GV->getName()) { + Diags.Report(Location, diag::note_alias_requires_mangled_name) + << GV->getName() << Name; +}

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf updated this revision to Diff 500225. AlexanderHederstaf added a comment. Add test with advanced type that would not work before. Add pointer to member. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.ll

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

aaron.ballman added a comment. One thing that might also help is to split this into a few stages. 1) Add the new general functionality, 2) Replacing the existing implementation of keyword attributes with the new functionality where possible, 3) Add new attributes using the new functionality. It

[clang-tools-extra] 8ae5e9e - Revert "[clang-tidy] handle exceptions properly in `ExceptionAnalyzer`"

Author: David Spickett Date: 2023-02-24T16:37:14Z New Revision: 8ae5e9edcdb394794d8c4d1ee286f1b500aaf826 URL: https://github.com/llvm/llvm-project/commit/8ae5e9edcdb394794d8c4d1ee286f1b500aaf826 DIFF: https://github.com/llvm/llvm-project/commit/8ae5e9edcdb394794d8c4d1ee286f1b500aaf826.diff LOG

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

erichkeane added a comment. In D139028#4150761 , @aaron.ballman wrote: > One thing that might also help is to split this into a few stages. 1) Add the > new general functionality, 2) Replacing the existing implementation of > keyword attributes with th

[PATCH] D135495: [clang-tidy] handle exceptions properly in `ExceptionAnalyzer`

DavidSpickett added a comment. The test was timing out on Arm/AArch64 bots so I have reverted this change. I think because there were other test failures on the initial run, that obscured the time out. This is one of the first builds to include this change: https://lab.llvm.org/buildbot/#/build

  1   2   >