[PATCH] D144780: Explicit cast on customized offsetof should not be ignored when evaluating as const

danix800 created this revision. danix800 added a project: clang. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits. If ignored, the subexpr is a UnaryOperator (&

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan updated this revision to Diff 500387. zyounan marked an inline comment as done. zyounan added a comment. Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 Files: clang-tools-e

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:520 auto ExprStartLoc = SM.getTopMacroCallerLoc(E->getBeginLoc()); -auto Decomposed = SM.getDecomposedLoc(ExprStartLoc); +auto Decomposed = SM.getDecomposedExpansionLoc(ExprStartLoc);

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan updated this revision to Diff 500388. zyounan added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd/un

[PATCH] D144709: [clang-format] Improve west to east const

rymiel added a comment. just as a heads up, I'm applying https://reviews.llvm.org/D144537 since it's a quick bug fix; this patch *would* replace that one, but may need more time. (also conflicts may appear) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

rymiel added a comment. In D144537#4145545 , @MyDeveloperDay wrote: > maybe we should cherry pick into 16? It's up to one of you (mostly because I don't know how to do backports and I don't want to mess it up) Repository: rG LLVM Github Monorepo C

[clang] 7ba9101 - [clang-format] Rewrite how indent is reduced for compacted namespaces

Author: Emilia Dreamer Date: 2023-02-25T12:13:53+02:00 New Revision: 7ba91016c6ad4cb8f82ed154753ddeeb524f9a64 URL: https://github.com/llvm/llvm-project/commit/7ba91016c6ad4cb8f82ed154753ddeeb524f9a64 DIFF: https://github.com/llvm/llvm-project/commit/7ba91016c6ad4cb8f82ed154753ddeeb524f9a64.diff

[PATCH] D144296: [clang-format] Rewrite how indent is reduced for compacted namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ba91016c6ad: [clang-format] Rewrite how indent is reduced for compacted namespaces (authored by rymiel). Repository: rG LLVM Github Monorepo CHA

[clang] 393e197 - [clang-format] Don't move qualifiers past pointers-to-member

Author: Emilia Dreamer Date: 2023-02-25T12:19:20+02:00 New Revision: 393e197cd6eb8942c4eaec3fd6d05bc2e2289212 URL: https://github.com/llvm/llvm-project/commit/393e197cd6eb8942c4eaec3fd6d05bc2e2289212 DIFF: https://github.com/llvm/llvm-project/commit/393e197cd6eb8942c4eaec3fd6d05bc2e2289212.diff

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG393e197cd6eb: [clang-format] Don't move qualifiers past pointers-to-member (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf updated this revision to Diff 500403. AlexanderHederstaf added a comment. Add comments for different cases. Add more tests. Fix whitespace issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/

[PATCH] D144709: [clang-format] Improve west to east const

AlexanderHederstaf added a comment. Thanks for the review so far! Passes all tests and works in one shot on my test files as well as 3k+ files repository, i.e. it does not have to be run twice. As one use-case of this rule is to be able to checkout code and freely swap between left/right. Then

[PATCH] D143415: LibclangTest: remove libclang-test-* tmp dir reliably

vedgy added a comment. @aaron.ballman, this test fix is independent from D143418 and can be reviewed separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143415/new/ https://reviews.llvm.org/D143415 ___

[PATCH] D144709: [clang-format] Improve left to right const

MyDeveloperDay added a comment. when I originally did this work, I checked out the whole fresh area of LLVM and applied the both east then back to west const and built both to ensure I didn't break anything. Please ensure you do the same, I'm going to be honest you are changing it massively, I

[PATCH] D144709: [clang-format] Improve left to right const

MyDeveloperDay added a comment. can you rebase please Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D144709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, are there no test cases which are affected by this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144778/new/ https://reviews.llvm.org/D144778

[PATCH] D143704: [Flang] Part one of Feature List action

awarzynski added a comment. In D143704#4150680 , @jdoerfert wrote: > can we have a test? +1 Comment at: flang/examples/FeatureList/FeatureList.cpp:34 + +struct ASTVisitor { +private: There is no AST in Flang - could y

[clang] 0617413 - [C2x] Implement support for revised spelling of keywords

Author: Aaron Ballman Date: 2023-02-25T09:30:10-05:00 New Revision: 06174134e418251982d43eff9385674b7644007f URL: https://github.com/llvm/llvm-project/commit/06174134e418251982d43eff9385674b7644007f DIFF: https://github.com/llvm/llvm-project/commit/06174134e418251982d43eff9385674b7644007f.diff

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3036 if (!std::is_trivially_destructible::value) { - auto DestroyPtr = [](void *V) { static_cast(V)->~T(); }; - AddDeallocation(DestroyPtr, Ptr); + auto DestroyPtr = [](void *V

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

carlosgalvezp added a comment. Thanks for the fix! Looks good, have a couple minor comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:88-89 } + AST_MATCHER(CXXConstructExpr, isDefaultConstruction) { return Node.getConstructor()->isD

[clang] da846cc - Remove WG14 N2829 from the C status page; NFC

Author: Aaron Ballman Date: 2023-02-25T11:06:34-05:00 New Revision: da846cca8fb3b21d7c7674244015efe6670e48cb URL: https://github.com/llvm/llvm-project/commit/da846cca8fb3b21d7c7674244015efe6670e48cb DIFF: https://github.com/llvm/llvm-project/commit/da846cca8fb3b21d7c7674244015efe6670e48cb.diff

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

PiotrZSL updated this revision to Diff 500437. PiotrZSL marked 2 inline comments as done. PiotrZSL added a comment. Fix review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144217/new/ https://reviews.llvm.org/D144217 Files: clang-tools

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 500440. tianshilei1992 added a comment. Herald added subscribers: okura, kuter, steven_wu. update tests in LLVM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 added a comment. Only `llvm/test/Transforms/OpenMP/spmdization_constant_prop.ll` is left. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 ___ cfe

[clang-tools-extra] e08cc52 - [clang-tidy] Fix false-positive in readability-container-size-empty

Author: Piotr Zegar Date: 2023-02-25T18:19:40Z New Revision: e08cc52cfc23d9fcf2e87301e74bfa94d7a4bad0 URL: https://github.com/llvm/llvm-project/commit/e08cc52cfc23d9fcf2e87301e74bfa94d7a4bad0 DIFF: https://github.com/llvm/llvm-project/commit/e08cc52cfc23d9fcf2e87301e74bfa94d7a4bad0.diff LOG: [

[PATCH] D144217: [clang-tidy] Fix false-positive in readability-container-size-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rGe08cc52cfc23: [clang-tidy] Fix false-positive in readability-container-size-empty (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14421

[PATCH] D144218: [Clang] [AVR] Fix USHRT_MAX for 16-bit int.

mysterymath updated this revision to Diff 500442. mysterymath added a comment. Minor clarification to release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144218/new/ https://reviews.llvm.org/D144218 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

carlosgalvezp added a comment. Thanks for the fix! I have some suggestions for improved readability. Comment at: clang-tools-extra/clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp:97 /// Returns the magnitude bits of an integer type. +static std::pair Havi

[PATCH] D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class.

royjacobson added a comment. friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143851/new/ https://reviews.llvm.org/D143851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 500449. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. @dblaikie thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

royjacobson added a comment. There are no AST [de]serialization tests in this PR, right? Would be nice to add some. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___

[PATCH] D144790: [clang-tidy] readability-identifier-naming.HungarianNotation: rename CharPrinter to CharPointer

amurzeau created this revision. amurzeau added reviewers: njames93, alexfh, kazu, dougpuob, aaron.ballman, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. amurzeau requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a pr

[PATCH] D144537: [clang-format] Don't move qualifiers past pointers-to-member

owenpan added a comment. In D144537#4152225 , @rymiel wrote: > In D144537#4145545 , > @MyDeveloperDay wrote: > >> maybe we should cherry pick into 16? > > I don't know how to do backports and I don't want to mess

[PATCH] D144802: clang: Add __builtin_elementwise_round

arsenm created this revision. arsenm added reviewers: aaron.ballman, RKSimon, fhahn, junaire, bob80905, python3kgae, erichkeane. Herald added a subscriber: StephenFan. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. This would only differ fr

[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

brad added a comment. In D144778#4152443 , @dim wrote: > LGTM, are there no test cases which are affected by this? The stdc++ library test for FreeBSD 9 was removed in the previous diff and I don't see anything testing the header path. Repository: r

[PATCH] D144778: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4dd4eb939cae: [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD… (authored by brad). Repository: rG LLVM Github Monorepo C

[clang] 4dd4eb9 - [Driver][FreeBSD] Further simplify the Driver handling for older FreeBSD releases

Author: Brad Smith Date: 2023-02-25T20:36:04-05:00 New Revision: 4dd4eb939caef1138c655e22bb4adc8978f16427 URL: https://github.com/llvm/llvm-project/commit/4dd4eb939caef1138c655e22bb4adc8978f16427 DIFF: https://github.com/llvm/llvm-project/commit/4dd4eb939caef1138c655e22bb4adc8978f16427.diff LO

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

Eugene.Zelenko added a comment. @carlosgalvezp: Sorry, there are too much Clang specifics in this patch, so I could not be reviewer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142587/new/ https://reviews.llvm.org/D142587 __

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074

[PATCH] D144790: [clang-tidy] readability-identifier-naming.HungarianNotation: rename CharPrinter to CharPointer

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. Good catch, thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144790/new/ https://reviews.llvm.org/D144790 ___

[PATCH] D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support

carlosgalvezp added a comment. In D142587#4152943 , @Eugene.Zelenko wrote: > @carlosgalvezp: Sorry, there are too much Clang specifics in this patch, so I > could not be reviewer. No prob, thanks for letting us know :) Repository: rG LLVM Github Mo