[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL added a comment. And missing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL added a comment. Missing ReleaseNote entry. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:43 + // Consider only functions with a external and visible declaration. + if (auto *MemberDecl = dyn_cast(FuncDecl)) +if

[clang-tools-extra] edcc59c - [clang-tools-extra] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2023-04-15T22:39:17-07:00 New Revision: edcc59c70667e6b280e354dc7f9ae94a5ef0042f URL: https://github.com/llvm/llvm-project/commit/edcc59c70667e6b280e354dc7f9ae94a5ef0042f DIFF: https://github.com/llvm/llvm-project/commit/edcc59c70667e6b280e354dc7f9ae94a5ef0042f.diff

[PATCH] D148447: [clang-format] Fix regression with AlignTrailingComments set to true

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel, yusuke-kadowaki. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. owenpan requested review of this revision. In D132131 ,

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:98 + QualType getType() const; + Interpreter () const; + sgraenitz wrote: > Can we make this private and try not to introduce more

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513954. junaire marked an inline comment as done. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:88 return Sym.takeError(); - return Sym->getValue(); + return llvm::orc::ExecutorAddr(Sym->getValue()); } sgraenitz wrote:

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. junaire marked an inline comment as done. Closed by commit rGfe1f34453d7e: [clang-repl] JITTargetAddress -- ExecutorAddr, NFC (authored by junaire). Changed prior to

[clang] fe1f344 - [clang-repl] JITTargetAddress --> ExecutorAddr, NFC

Author: Jun Zhang Date: 2023-04-16T09:46:44+08:00 New Revision: fe1f34453d7ef2c0d5f308e0abdb185d6807cfa6 URL: https://github.com/llvm/llvm-project/commit/fe1f34453d7ef2c0d5f308e0abdb185d6807cfa6 DIFF: https://github.com/llvm/llvm-project/commit/fe1f34453d7ef2c0d5f308e0abdb185d6807cfa6.diff

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

nridge added a comment. In D146941#4264146 , @nridge wrote: > Do you have any thoughts on merging D147905 > first, with a view to backporting D147905 > to the 16.x branch? Since

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

jhuber6 created this revision. jhuber6 added reviewers: lntue, michaelrj, sivachandra, gchatelet, goldstein.w.n. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. jhuber6 requested review of this revision. Herald added a

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513946. sousajo added a comment. - inline string to be checked CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513945. sousajo added a comment. - removed `FormatStyle Style = getLLVMStyle();` as llvm is the default style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files:

[PATCH] D148436: [clang-tidy] Fix crash in --dump-config

This revision was automatically updated to reflect the committed changes. Closed by commit rG6128bcd02512: [clang-tidy] Fix crash in --dump-config (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148436/new/

[clang-tools-extra] 6128bcd - [clang-tidy] Fix crash in --dump-config

Author: Nathan James Date: 2023-04-15T22:58:17+01:00 New Revision: 6128bcd02512eeb0e0bbb8b0a9c4d82f6f9427b2 URL: https://github.com/llvm/llvm-project/commit/6128bcd02512eeb0e0bbb8b0a9c4d82f6f9427b2 DIFF: https://github.com/llvm/llvm-project/commit/6128bcd02512eeb0e0bbb8b0a9c4d82f6f9427b2.diff

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Thanks. Maybe you can fix this one detail and add a description like "Most of Orc and JITLink are movinng away from JITTargetAddress and use ExecutorAddr instead"? Otherwise LGTM.

[PATCH] D134130: [clangd] Add doxygen parsing for Hover [1/3]

vinniefalco added a comment. This is a beautiful patch, it has helped me understand the hierarchy of clang comment nodes much better. I will note that it only supports explicit briefs. That is, those for which the \brief or @brief command has appeared. But implicit briefs are also quite

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25432 +TEST_F(FormatTest, InterfaceAsFieldName) { + FormatStyle Style = getLLVMStyle(); Comment at: clang/unittests/Format/FormatTest.cpp:25433-25439 +

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo added a comment. As I dont have commit access if someone can land It for me: Jorge Pinto Sousa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 ___ cfe-commits mailing list

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta created this revision. xgupta added reviewers: vmiklos, alexander-shaposhnikov, kbobyrev, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-rename on a non existing file

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo created this revision. sousajo added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. sousajo requested review of this revision. Fixes:

[PATCH] D148436: [clang-tidy] Fix crash in --dump-config

njames93 added a comment. @PiotrZSL I hope you don't mind, I've put just the crash fix up here for D146842 and marked you as the coauthor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148436/new/

[PATCH] D148436: [clang-tidy] Fix crash in --dump-config

njames93 created this revision. njames93 added reviewers: PiotrZSL, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Fixes a crash in

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 513927. junaire added a comment. Sync Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:83 + Value() = default; + Value(void /*Interpreter*/ *In, void /*QualType*/ *Ty); + Value(const Value ); aaron.ballman wrote: > Why do

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513926. junaire marked an inline comment as done. junaire added a comment. Address more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:7226 + // assert(DeferredDeclsToEmit.empty() && + //"Should have emitted all decls deferred to emit."); assert(NewBuilder->DeferredDecls.empty() && aaron.ballman

[PATCH] D148435: [clang-repl] Do not assert if we have weak references left.

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rjmccall, rsmith, junaire. Herald added a project: All. v.g.vassilev requested review of this revision. Non-incremental Clang can also exit with the WeakRefReferences not empty upon such example. This patch makes

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire updated this revision to Diff 513924. junaire added a comment. Avoid unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148434/new/ https://reviews.llvm.org/D148434 Files: clang/include/clang/Interpreter/Interpreter.h

[PATCH] D144036: [clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check

PiotrZSL updated this revision to Diff 513923. PiotrZSL added a comment. Rebase due to broken baseline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036 Files:

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 4 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:83 /// mangled name. llvm::Expected getSymbolAddress(GlobalDecl GD) const; sgraenitz wrote: > Most of the Orc and JITLink

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D148434 Files:

[PATCH] D148433: [clang] Add tests for DRs about complete-class context

Endill created this revision. Endill added reviewers: erichkeane, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : The intent for CWG2335 (contra those of the

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked 16 inline comments as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + llvm::Error ParseAndExecute(llvm::StringRef Code, Value *V = nullptr); + llvm::Expected CompileDtorCall(CXXRecordDecl *CXXRD);

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513918. junaire added a comment. Address some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Decl.h

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL planned changes to this revision. PiotrZSL added a comment. TODO: Split tests into multiple files (to isolate issue). If possible remove usage of FileCheck. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/

[PATCH] D144036: [clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check

PiotrZSL updated this revision to Diff 513917. PiotrZSL added a comment. Fix check description in source file (white spaces, sync it with release notes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144036/new/ https://reviews.llvm.org/D144036

[PATCH] D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape

carlosgalvezp added a comment. There's a lot of changes in this patch (at least 6 as per commit message) - please split into smaller patches fixing 1 problem at a time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145865/new/

[clang] b9d84b5 - [clang][NFC] Fix DR test ordering

Author: Vlad Serebrennikov Date: 2023-04-15T18:25:08+03:00 New Revision: b9d84b57f680cb294da906a6eeca2d0598c11568 URL: https://github.com/llvm/llvm-project/commit/b9d84b57f680cb294da906a6eeca2d0598c11568 DIFF:

[PATCH] D144036: [clang-tidy] Add bugprone-non-zero-enum-to-bool-conversion check

carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land. LGTM, thanks! Would be good to fix the last nit before landing. Comment at: clang-tools-extra/clang-tidy/bugprone/NonZeroEnumToBoolConversionCheck.h:17 + +///

[clang-tools-extra] 4530c3b - [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

Author: Nathan James Date: 2023-04-15T15:07:44Z New Revision: 4530c3bc4897f6633577de07b61ceb1bf7e79f50 URL: https://github.com/llvm/llvm-project/commit/4530c3bc4897f6633577de07b61ceb1bf7e79f50 DIFF: https://github.com/llvm/llvm-project/commit/4530c3bc4897f6633577de07b61ceb1bf7e79f50.diff LOG:

[PATCH] D98416: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

carlosgalvezp added a comment. Took the liberty to land it for you, hope it's ok! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98416/new/ https://reviews.llvm.org/D98416 ___ cfe-commits mailing list

[PATCH] D98416: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

This revision was automatically updated to reflect the committed changes. Closed by commit rG4530c3bc4897: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive (authored by njames93, committed by carlosgalvezp). Changed prior to commit:

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

njames93 updated this revision to Diff 513911. njames93 added a comment. - Clang format changes - Update apply logic to not query the FS when its not a cross file edit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148423/new/

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 added a comment. In D146842#4271144 , @PiotrZSL wrote: > In D146842#4271089 , @njames93 > wrote: > >> I think this should be split up into 2 separate patches, one for each of the >> proposed changes

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp marked an inline comment as done. carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.h:1 +//===--- MisleadingCaptureDefaultByValueCheck.h - clang-tidy*- C++ +//-*-===//

[clang-tools-extra] d69c362 - [clang-tidy][NFC] Fix format of header file comment in MisleadingCaptureDefaultByValueCheck.h

Author: Carlos Galvez Date: 2023-04-15T14:49:20Z New Revision: d69c362dfdc09d9b866cbce007e6342c17af2b2a URL: https://github.com/llvm/llvm-project/commit/d69c362dfdc09d9b866cbce007e6342c17af2b2a DIFF: https://github.com/llvm/llvm-project/commit/d69c362dfdc09d9b866cbce007e6342c17af2b2a.diff

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MisleadingCaptureDefaultByValueCheck.h:1 +//===--- MisleadingCaptureDefaultByValueCheck.h - clang-tidy*- C++ +//-*-===// Split header comment. Repository: rG

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/AvoidEndlEndsCheck.cpp:28 + declRefExpr( + to(namedDecl(hasAnyName("endl", "ends")).bind("decl"))) + .bind("expr", njames93

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/AvoidEndlEndsCheck.cpp:28 + declRefExpr( + to(namedDecl(hasAnyName("endl", "ends")).bind("decl"))) + .bind("expr", Why are you

[PATCH] D141892: Implement modernize-use-constraints

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:63-65 +std::string Name = TheType.getType().getAsString(); +if (Name.find("enable_if<") == std::string::npos) + return std::nullopt; This

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL added a comment. To be honest I have no idea why it failed, simply because there is CHECK-MESSAGES for that log. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 513898. PiotrZSL added a comment. Small changes remove, file name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files:

[clang-tools-extra] 26e164f - Revert "[clang-tidy] Add misc-header-include-cycle check"

Author: Piotr Zegar Date: 2023-04-15T13:16:43Z New Revision: 26e164fada3721b0939e6b7c2dfe1793d95229bb URL: https://github.com/llvm/llvm-project/commit/26e164fada3721b0939e6b7c2dfe1793d95229bb DIFF: https://github.com/llvm/llvm-project/commit/26e164fada3721b0939e6b7c2dfe1793d95229bb.diff LOG:

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

thakis added a comment. This breaks tests: http://45.33.8.238/linux/104455/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL added a comment. In D146842#4271089 , @njames93 wrote: > I think this should be split up into 2 separate patches, one for each of the > proposed changes and each can be reviewed on their own. I don't plan to split this. Repository: rG LLVM

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ece8753d5e6: [clang-tidy] Add misc-header-include-cycle check (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 9ece875 - [clang-tidy] Add misc-header-include-cycle check

Author: Piotr Zegar Date: 2023-04-15T12:43:22Z New Revision: 9ece8753d5e6f49c31c2d988ef69225c036b25e0 URL: https://github.com/llvm/llvm-project/commit/9ece8753d5e6f49c31c2d988ef69225c036b25e0 DIFF: https://github.com/llvm/llvm-project/commit/9ece8753d5e6f49c31c2d988ef69225c036b25e0.diff LOG:

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 513896. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Fix one small nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files:

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM: Just one small nit. Comment at: clang-tools-extra/clang-tidy/misc/HeaderIncludeCycleCheck.cpp:148-150 +return std::any_of( +

[PATCH] D148426: [clang][Interp] IntegralComplexToBoolean casts

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1165 +return visit(LV); + return false; Since complex types are arrays with two elements, we can't dereference them like normal. This change just ignore the dereference.

[PATCH] D148426: [clang][Interp] IntegralComplexToBoolean casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I wanted to avoid adding too many opcodes for

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. Ok, taking a step back here, this patch is trying to address 2 unrelated things at once: - using `--dump-config` with bad check options results in a crash - using

[PATCH] D148424: [clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default-by-value

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa3de2ed2964: [clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] fa3de2e - [clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default-by-value

Author: Carlos Galvez Date: 2023-04-15T12:07:18Z New Revision: fa3de2ed2964d18dd0b7457e77416fb4e688c8bd URL: https://github.com/llvm/llvm-project/commit/fa3de2ed2964d18dd0b7457e77416fb4e688c8bd DIFF: https://github.com/llvm/llvm-project/commit/fa3de2ed2964d18dd0b7457e77416fb4e688c8bd.diff

[PATCH] D147815: [clang][deps] Print timing information

akyrtzi added a comment. > Could you also add a -terse option, to avoid printing the full dependency info Note I added something like this in https://reviews.llvm.org/D148369, so ignore it for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148425: [clang-repl] Correctly disambiguate dtor declarations from statements

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, aaron.ballman. Herald added a project: All. v.g.vassilev requested review of this revision. Repository: rC Clang https://reviews.llvm.org/D148425 Files: clang/lib/Parse/ParseTentative.cpp

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 513886. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Small redesign (review comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files:

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL marked 4 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/HeaderIncludeCycleCheck.cpp:134-135 +do { + if (CurrentIt->Name.empty()) +continue; + njames93 wrote: > Is this a case that

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:61-69 struct NamesAndOptions { llvm::StringSet<> Names; llvm::StringSet<> Options; + std::vector Errors; }; NamesAndOptions njames93 wrote: > I don't think this is

[libclc] 1ef4c3c - Revert "Revert "[CMake] Bumps minimum version to 3.20.0.""

Author: Mark de Wever Date: 2023-04-15T13:12:04+02:00 New Revision: 1ef4c3c859728008cf707cad8d67f45ae5070ae1 URL: https://github.com/llvm/llvm-project/commit/1ef4c3c859728008cf707cad8d67f45ae5070ae1 DIFF: https://github.com/llvm/llvm-project/commit/1ef4c3c859728008cf707cad8d67f45ae5070ae1.diff

[PATCH] D146842: [clang-tidy] Fix crash when handling invalid config values

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.h:61-69 struct NamesAndOptions { llvm::StringSet<> Names; llvm::StringSet<> Options; + std::vector Errors; }; NamesAndOptions I don't think this is the correct

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/HeaderIncludeCycleCheck.cpp:134-135 +do { + if (CurrentIt->Name.empty()) +continue; + Is this a case that can ever come up? If it does come up, surely any notes

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

This revision was automatically updated to reflect the committed changes. PiotrZSL marked an inline comment as done. Closed by commit rG35f466eb14b7: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 35f466e - [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

Author: Piotr Zegar Date: 2023-04-15T10:29:39Z New Revision: 35f466eb14b7e57e8bd33a8eb98e89fe3a4cd839 URL: https://github.com/llvm/llvm-project/commit/35f466eb14b7e57e8bd33a8eb98e89fe3a4cd839 DIFF: https://github.com/llvm/llvm-project/commit/35f466eb14b7e57e8bd33a8eb98e89fe3a4cd839.diff LOG:

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

carlosgalvezp accepted this revision. carlosgalvezp added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/dangling-handle.cpp:55-56 - operator basic_string_view() const noexcept; + typedef

[PATCH] D148424: [clang-tidy][NFC] Improve doc of cppcoreguidelines-misleading-capture-default-by-value

carlosgalvezp created this revision. Herald added subscribers: PiotrZSL, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

This revision was automatically updated to reflect the committed changes. Closed by commit rG9556409957bb: [clang-tidy] Exclude template instantiations in modernize-use-override (authored by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D147924?vs=513871=513880#toc Repository:

[clang-tools-extra] 9556409 - [clang-tidy] Exclude template instantiations in modernize-use-override

Author: Piotr Zegar Date: 2023-04-15T10:16:03Z New Revision: 9556409957bbf85ca751ccff8f3a4d981a094b73 URL: https://github.com/llvm/llvm-project/commit/9556409957bbf85ca751ccff8f3a4d981a094b73 DIFF: https://github.com/llvm/llvm-project/commit/9556409957bbf85ca751ccff8f3a4d981a094b73.diff LOG:

[PATCH] D148260: [clang] Mark CWG2331 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG19ef8e8446df: [clang] Mark CWG2331 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148260/new/ https://reviews.llvm.org/D148260

[clang] 19ef8e8 - [clang] Mark CWG2331 as N/A

Author: Vlad Serebrennikov Date: 2023-04-15T13:15:45+03:00 New Revision: 19ef8e8446df10b6bebf6301c1a3e9e8000f842c URL: https://github.com/llvm/llvm-project/commit/19ef8e8446df10b6bebf6301c1a3e9e8000f842c DIFF:

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

njames93 added a comment. Theres definitely scope to improve this in follow ups. We could support this for template methods and classes template struct A { void [[Foo]]() {} template void [[Bar]]() {} }; // Both ranges transformed to template struct A { void Foo();

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

PiotrZSL marked an inline comment as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/dangling-handle.cpp:55-56 - operator basic_string_view() const noexcept; + typedef basic_string_view str_view; + operator str_view()

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/performance/avoid-endl.cpp:46 +void bad() { + std::cout << "World" << std::endl; + // CHECK-MESSAGES: :[[@LINE-1]]:27: warning: do not use std::endl with iostreams; use '\n' instead

[PATCH] D148318: [clang-tidy] Add `performance-avoid-endl` check

AMS21 updated this revision to Diff 513878. AMS21 marked 12 inline comments as done. AMS21 added a comment. Implement suggested fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148318/new/ https://reviews.llvm.org/D148318 Files:

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

This revision was automatically updated to reflect the committed changes. Closed by commit rGeedbe81b1c6d: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this… (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] eedbe81 - [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

Author: Carlos Galvez Date: 2023-04-15T10:10:04Z New Revision: eedbe81b1c6dfbd85c2a46093e9e862335ad6516 URL: https://github.com/llvm/llvm-project/commit/eedbe81b1c6dfbd85c2a46093e9e862335ad6516 DIFF: https://github.com/llvm/llvm-project/commit/eedbe81b1c6dfbd85c2a46093e9e862335ad6516.diff

[PATCH] D148418: [clang-tidy] Fix typedefs handling in bugprone-dangling-handle

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/dangling-handle.cpp:55-56 - operator basic_string_view() const noexcept; + typedef basic_string_view str_view; + operator str_view() const noexcept;

[PATCH] D148423: [clangd] Support define outline tweak for non cross file edits

njames93 created this revision. njames93 added reviewers: kadircet, sammccall, nridge. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp updated this revision to Diff 513875. carlosgalvezp added a comment. Remove excessive whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148340/new/ https://reviews.llvm.org/D148340 Files:

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp updated this revision to Diff 513874. carlosgalvezp added a comment. Fix check ordering. Align check documentation across header, .rst file and Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148340/new/

[PATCH] D148340: [clang-tidy] Apply cppcoreguidelines-avoid-capture-default-when-capturin-this only to by-value capture default

carlosgalvezp updated this revision to Diff 513873. carlosgalvezp marked 2 inline comments as done. carlosgalvezp added a comment. Rename check to latest proposal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148340/new/

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

carlosgalvezp accepted this revision. carlosgalvezp added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-override-templates.cpp:46 + // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-override-templates.cpp:46 + // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override] + //

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

PiotrZSL updated this revision to Diff 513871. PiotrZSL marked an inline comment as done. PiotrZSL added a comment. Remove of fix start/end marker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147924/new/ https://reviews.llvm.org/D147924 Files:

[libunwind] ca4fb46 - [libunwind] Sync Unwind_AppleExtras.cpp with downstream version

Author: Louis Dionne Date: 2023-04-15T10:37:28+01:00 New Revision: ca4fb463187ce244d61dc62a8f4e3e01d1872cc2 URL: https://github.com/llvm/llvm-project/commit/ca4fb463187ce244d61dc62a8f4e3e01d1872cc2 DIFF: https://github.com/llvm/llvm-project/commit/ca4fb463187ce244d61dc62a8f4e3e01d1872cc2.diff

[PATCH] D147924: [clang-tidy] Exclude template instantiations in modernize-use-override

carlosgalvezp added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-override-templates.cpp:46 + // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override] + //

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

jonpa accepted this revision. jonpa added a comment. This revision is now accepted and ready to land. In D143813#4269073 , @efriedma wrote: > Please don't upload reviews for followup patches on top of the original > patch; it confuses the history of

  1   2   >