[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25432 +TEST_F(FormatTest, InterfaceAsFieldName) { + FormatStyle Style = getLLVMStyle(); Comment at: clang/unittests/Format/FormatTest.cpp:25433-25439 + Format

[PATCH] D134130: [clangd] Add doxygen parsing for Hover [1/3]

vinniefalco added a comment. This is a beautiful patch, it has helped me understand the hierarchy of clang comment nodes much better. I will note that it only supports explicit briefs. That is, those for which the \brief or @brief command has appeared. But implicit briefs are also quite preval

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Thanks. Maybe you can fix this one detail and add a description like "Most of Orc and JITLink are movinng away from JITTargetAddress and use ExecutorAddr instead"? Otherwise LGTM. ===

[clang-tools-extra] 6128bcd - [clang-tidy] Fix crash in --dump-config

Author: Nathan James Date: 2023-04-15T22:58:17+01:00 New Revision: 6128bcd02512eeb0e0bbb8b0a9c4d82f6f9427b2 URL: https://github.com/llvm/llvm-project/commit/6128bcd02512eeb0e0bbb8b0a9c4d82f6f9427b2 DIFF: https://github.com/llvm/llvm-project/commit/6128bcd02512eeb0e0bbb8b0a9c4d82f6f9427b2.diff

[PATCH] D148436: [clang-tidy] Fix crash in --dump-config

This revision was automatically updated to reflect the committed changes. Closed by commit rG6128bcd02512: [clang-tidy] Fix crash in --dump-config (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148436/new/ https://reviews.llvm

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513945. sousajo added a comment. - removed `FormatStyle Style = getLLVMStyle();` as llvm is the default style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files: clang/lib/Format/UnwrappedLineParser.c

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513946. sousajo added a comment. - inline string to be checked CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp In

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

jhuber6 created this revision. jhuber6 added reviewers: lntue, michaelrj, sivachandra, gchatelet, goldstein.w.n. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. jhuber6 requested review of this revision. Herald added a p

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

nridge added a comment. In D146941#4264146 , @nridge wrote: > Do you have any thoughts on merging D147905 > first, with a view to backporting D147905 > to the 16.x branch? Since ther

[clang] fe1f344 - [clang-repl] JITTargetAddress --> ExecutorAddr, NFC

Author: Jun Zhang Date: 2023-04-16T09:46:44+08:00 New Revision: fe1f34453d7ef2c0d5f308e0abdb185d6807cfa6 URL: https://github.com/llvm/llvm-project/commit/fe1f34453d7ef2c0d5f308e0abdb185d6807cfa6 DIFF: https://github.com/llvm/llvm-project/commit/fe1f34453d7ef2c0d5f308e0abdb185d6807cfa6.diff LOG

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. junaire marked an inline comment as done. Closed by commit rGfe1f34453d7e: [clang-repl] JITTargetAddress --> ExecutorAddr, NFC (authored by junaire). Changed prior to

[PATCH] D148434: [clang-repl] JITTargetAddress --> ExecutorAddr

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:88 return Sym.takeError(); - return Sym->getValue(); + return llvm::orc::ExecutorAddr(Sym->getValue()); } sgraenitz wrote: >

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 513954. junaire marked an inline comment as done. junaire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/AST/Dec

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire marked an inline comment as done. junaire added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:98 + QualType getType() const; + Interpreter &getInterpreter() const; + sgraenitz wrote: > Can we make this private and try not to intro

[PATCH] D148447: [clang-format] Fix regression with AlignTrailingComments set to true

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel, yusuke-kadowaki. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. owenpan requested review of this revision. In D132131 , `

[clang-tools-extra] edcc59c - [clang-tools-extra] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2023-04-15T22:39:17-07:00 New Revision: edcc59c70667e6b280e354dc7f9ae94a5ef0042f URL: https://github.com/llvm/llvm-project/commit/edcc59c70667e6b280e354dc7f9ae94a5ef0042f DIFF: https://github.com/llvm/llvm-project/commit/edcc59c70667e6b280e354dc7f9ae94a5ef0042f.diff L

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL added a comment. Missing ReleaseNote entry. Comment at: clang-tools-extra/clang-tidy/llvmlibc/InlineFunctionDeclCheck.cpp:43 + // Consider only functions with a external and visible declaration. + if (auto *MemberDecl = dyn_cast(FuncDecl)) +if (MemberDecl->getPar

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL added a comment. And missing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D148444: [clang-tidy] Prevent `llvmlibc-inline-function-decl` triggering on lambdas

PiotrZSL requested changes to this revision. PiotrZSL added a comment. This revision now requires changes to proceed. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148444/new/ https://reviews.llvm.org/D148444 _

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added a comment. I added some of background and historical notes. I hope that helps. Comment at: clang/include/clang/Interpreter/Interpreter.h:59 + + Value LastValue; aaron.ballman wrote: > I think I'm surprised to see this as a data member of `

<    1   2