[PATCH] D146490: [Support] On Windows, ensure that UniqueID is really stable

falhumai96 added a comment. Hello devs, I would like to follow up on this issue whether or not there has been an update on it. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146490/new/ https://reviews.llvm.org/D146490

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Haha. My bad for misunderstanding. > I think rather if the common ancestor isn't completely selected, evaluation > shouldn't happen. I don't think it is a feasible approach to simply opt out of partial selection. Please consider this snippet: #define SizeOf sizeof

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 518118. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149389/new/ https://reviews.llvm.org/D149389

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

This revision was automatically updated to reflect the committed changes. Closed by commit rGe52a8b89adda: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e52a8b8 - [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

Author: Manna, Soumi Date: 2023-04-28T18:58:55-07:00 New Revision: e52a8b89addaec496fd726a3a90bcf82d42065c9 URL: https://github.com/llvm/llvm-project/commit/e52a8b89addaec496fd726a3a90bcf82d42065c9 DIFF: https://github.com/llvm/llvm-project/commit/e52a8b89addaec496fd726a3a90bcf82d42065c9.diff

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

shafik added a comment. In D149389#4306605 , @ayzhao wrote: > In D149389#4303966 , @shafik wrote: > >> So the change makes sense but the original issue: >> https://github.com/llvm/llvm-project/issues/62266 it

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

lanza added a comment. Actually, this still is consumed even without that flag being passed. Anybody know the rational for not having at least an llvm major version check here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149504/new/

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

lanza created this revision. lanza added a reviewer: bruno. Herald added subscribers: wlei, wenlei, arphaman. Herald added a project: All. lanza requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we're using an old instrprof profile and

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518106. void added a comment. Change sanitizer scope because instructions may be created. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148381/new/ https://reviews.llvm.org/D148381 Files:

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149498/new/ https://reviews.llvm.org/D149498

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149497/new/ https://reviews.llvm.org/D149497

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

michaelmaitland added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:176 // MCPU-SIFIVE-X280-SAME: "-target-feature" "+zicsr" "-target-feature" "+zifencei" +// MCPU-SIFIVE-X280-SAME: "-target-feature" "+zfh" // MCPU-SIFIVE-X280-SAME: "-target-feature" "+zba"

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

michaelmaitland marked an inline comment as done. michaelmaitland added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:181 + FeatureStdExtZvfh, + FeatureStdExtZba, +

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVProcessors.td:181 + FeatureStdExtZvfh, + FeatureStdExtZba, + FeatureStdExtZbb],

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:176 // MCPU-SIFIVE-X280-SAME: "-target-feature" "+zicsr" "-target-feature" "+zifencei" +// MCPU-SIFIVE-X280-SAME: "-target-feature" "+zfh" // MCPU-SIFIVE-X280-SAME: "-target-feature" "+zba"

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147847/new/ https://reviews.llvm.org/D147847

[PATCH] D149498: [RISCV] Add Scheduling information for Zfh to SiFive7 model

michaelmaitland updated this revision to Diff 518089. michaelmaitland added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add zfh to `clang/test/Driver/riscv-cpus.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149495: [RISCV] Add sifive-x280 processor and support V extenstion in SiFive7

michaelmaitland updated this revision to Diff 518086. michaelmaitland added a comment. Remove zfh from x280 check in `clang/test/Driver/riscv-cpus.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149495/new/ https://reviews.llvm.org/D149495

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

michaelmaitland created this revision. michaelmaitland added reviewers: craig.topper, kito-cheng, reames. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D149495: Add sifive-x280 processor and support V extenstion in SiFive7

michaelmaitland created this revision. michaelmaitland added reviewers: craig.topper, kito-cheng, reames, pcwang-thead. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4301977 , @aaron.ballman wrote: > Thank you for working on this! These changes should come with test coverage > (we have a handful of verifier tests in `clang/test/Frontend` -- you can add > a new test file

[PATCH] D149492: [clang] makes built-in traits match their stdlib counterparts' names

cjdb created this revision. cjdb added reviewers: rsmith, aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The original names apparently broke convention by not making them the same as the

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

ayzhao added a comment. In D149389#4303966 , @shafik wrote: > So the change makes sense but the original issue: > https://github.com/llvm/llvm-project/issues/62266 it worked for the first > once but not the second, it also worked for the non-paren

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + bolshakov-a wrote: > bolshakov-a wrote: > > efriedma wrote: > > > bolshakov-a

[PATCH] D149389: [clang] Fix default initializers being ignored when initializing templated aggregate types

ayzhao updated this revision to Diff 518054. ayzhao added a comment. rebase + add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149389/new/ https://reviews.llvm.org/D149389 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + bolshakov-a wrote: > efriedma wrote: > > bolshakov-a wrote: > > > efriedma

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + efriedma wrote: > bolshakov-a wrote: > > efriedma wrote: > > > bolshakov-a

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm added a comment. In D149272#4306103 , @aaron.ballman wrote: > LGTM, but please add a release note when landing. Thanks, I do not have permission to land, are you able to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149272: [clang] Call printName to get name of Decl

dankm updated this revision to Diff 518050. dankm added a comment. Rebase & add add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.org/D149272 Files: clang/docs/ReleaseNotes.rst

[PATCH] D148274: [clang] Fix overly aggressive lifetime checks for parenthesized aggregate initialization

ayzhao updated this revision to Diff 518044. ayzhao added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148274/new/ https://reviews.llvm.org/D148274 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149436: [clang] Do not attempt to zero-extend _BitInt(1) when not required

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/test/CodeGen/ext-int.c:8 +unsigned _BitInt(1) GlobSize1 = 0; +// CHECK: @GlobSize1 = {{.*}}global i1 false + Interesting, it looks like `true` and `false` are valid for `i1` all the

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + bolshakov-a wrote: > efriedma wrote: > > bolshakov-a wrote: > > > efriedma

[PATCH] D145088: [RISCV] Add attribute(riscv_rvv_vector_bits(N)) based on AArch64 arm_sve_vector_bits.

rjmccall added a comment. Thanks, a couple very minor fixes / requests, but feel free to commit afterwards. Comment at: clang/include/clang/Basic/AttrDocs.td:2323 + let Content = [{ +The ``riscv_rvv_vector_bits(N)`` attribute is used to define fixed-length +variants of

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + efriedma wrote: > bolshakov-a wrote: > > efriedma wrote: > > > Weird

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

efriedma added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + bolshakov-a wrote: > efriedma wrote: > > Weird indentation > I agree. Don't

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1250 + for (unsigned I = 1, IE = ID->getChainingSize(); I < IE; ++I) +mangleSourceName(""); + efriedma wrote: > Weird indentation I agree. Don't know why clang-format

[PATCH] D149380: [clang] Add -Wunused-result-always warning

gpanders updated this revision to Diff 518024. gpanders added a comment. Remove cast to (void) in unused-expr.c This cast is not necessary for this test, because foo does not have a "warn_unused_result" attribute and is not marked const or pure. Removing the cast improves the usefuless of the

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

This revision was automatically updated to reflect the committed changes. Manna marked 3 inline comments as done. Closed by commit rG4faf3fcf3fb2: [NFC][CLANG] Fix coverity remarks about large copy by values (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 4faf3fc - [NFC][CLANG] Fix coverity remarks about large copy by values

Author: Manna, Soumi Date: 2023-04-28T12:17:10-07:00 New Revision: 4faf3fcf3fb253cb3e68d6ae7b124e7a39f9ccff URL: https://github.com/llvm/llvm-project/commit/4faf3fcf3fb253cb3e68d6ae7b124e7a39f9ccff DIFF: https://github.com/llvm/llvm-project/commit/4faf3fcf3fb253cb3e68d6ae7b124e7a39f9ccff.diff

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void updated this revision to Diff 518013. void marked an inline comment as done. void added a comment. Fix the way the source ranges are imported via the ASTImporter. Do other minor fixes according to feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148381: [WIP][Clang] Add element_count attribute

void marked an inline comment as done. void added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4170 +private: + mutable SmallVector CountFieldRanges; +public: nickdesaulniers wrote: > `mutable`...my least favorite keyword in C++.

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:189 + /// Deprecated. Use *getDataflowAnalysisContext().getOptions().Log instead. Logger () const { return

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

ymandel added a comment. In D149464#4306226 , @bazuzi wrote: > Thanks! Seems like you have commit access, Yitzie; could you commit this for > me as "Samira Bazuzi "? Sure. Let's wait til Gabor approves, but then I'll go ahead. Repository: rG LLVM

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi added a comment. Thanks! Seems like you have commit access, Yitzie; could you commit this for me as "Samira Bazuzi "? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149464/new/ https://reviews.llvm.org/D149464

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

Endill added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule =

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

xgupta added a comment. In D149405#4305856 , @aaron.ballman wrote: > Thank you, this is a great suggestion! Just some minor wording changes, but > otherwise LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rGa70485493803: [Clang][Doc] Added an open project for improving command line docs (authored by xgupta).

[clang] a704854 - [Clang][Doc] Added an open project for improving command line docs

Author: Shivam Gupta Date: 2023-04-28T23:32:37+05:30 New Revision: a70485493803d2e22cbc79184b78861b098ba416 URL: https://github.com/llvm/llvm-project/commit/a70485493803d2e22cbc79184b78861b098ba416 DIFF: https://github.com/llvm/llvm-project/commit/a70485493803d2e22cbc79184b78861b098ba416.diff

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

xgupta updated this revision to Diff 517996. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149405/new/ https://reviews.llvm.org/D149405 Files: clang/www/OpenProjects.html Index:

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders added a comment. (ping) Does this make sense or are more adjustments needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143112/new/ https://reviews.llvm.org/D143112 ___ cfe-commits mailing

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:986 + const FunctionDecl *FD = nullptr; + llvm::SmallVector Args; + nridge wrote: > tom-anders wrote: > > Unfortunately, while CallExpr and CXXConstructExpr basically have the

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6241-6244 def ext_flexible_array_empty_aggregate_ms : Extension< "flexible array member %0 in otherwise empty " "%select{struct|interface|union|class|enum}1 is a Microsoft

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders updated this revision to Diff 517994. tom-anders marked an inline comment as done. tom-anders added a comment. Use ArrayRef instead of SmallVector to avoid copy (also fix 2 typos in the comment below) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149272: [clang] Call printName to get name of Decl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/

[PATCH] D147846: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b4fd953f44: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo (authored by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] a7b4fd9 - [clangd] Hover: resolve forwarding parameters for CalleeArgInfo

Author: Tom Praschan Date: 2023-04-28T21:46:32+02:00 New Revision: a7b4fd953f44b790f8832a5b57d7598bd12adfb2 URL: https://github.com/llvm/llvm-project/commit/a7b4fd953f44b790f8832a5b57d7598bd12adfb2 DIFF: https://github.com/llvm/llvm-project/commit/a7b4fd953f44b790f8832a5b57d7598bd12adfb2.diff

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon updated this revision to Diff 517985. Fznamznon edited the summary of this revision. Fznamznon added a comment. Apply some of the comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7696 if (isa(DC)) { -for (auto Lexical : TULexicalDecls) +for (const auto : TULexicalDecls) Visit(Lexical.first, Lexical.second); This returns `std::vector` in

[clang] 024bb62 - [Driver] Pass --target2= to linker from baremetal toolchain

Author: Mikhail Maltsev Date: 2023-04-28T18:30:49+01:00 New Revision: 024bb62ffd072e9a90343e88c92e40b5849c2632 URL: https://github.com/llvm/llvm-project/commit/024bb62ffd072e9a90343e88c92e40b5849c2632 DIFF:

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG024bb62ffd07: [Driver] Pass --target2= to linker from baremetal toolchain (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4428 // Mark selectors as out of date. - for (auto Sel : SelectorGeneration) + for (const auto : SelectorGeneration) SelectorOutOfDate[Sel.first] = true; Here Object of

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6241-6244 def ext_flexible_array_empty_aggregate_ms : Extension< "flexible array member %0 in otherwise empty " "%select{struct|interface|union|class|enum}1 is a Microsoft

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

paquette added a comment. Sorry for the inconvenience and thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149361/new/ https://reviews.llvm.org/D149361 ___ cfe-commits mailing list

[clang] 15f0491 - [NFC] Fix a mem-sanitizer found issue in AutoType

Author: Erich Keane Date: 2023-04-28T10:09:26-07:00 New Revision: 15f0491d3963d91202aef659acc20f59aa83fae7 URL: https://github.com/llvm/llvm-project/commit/15f0491d3963d91202aef659acc20f59aa83fae7 DIFF: https://github.com/llvm/llvm-project/commit/15f0491d3963d91202aef659acc20f59aa83fae7.diff

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks and welcome! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149464/new/ https://reviews.llvm.org/D149464

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. rebase to see if it clears up the buildbot issue (currently the failing test appears to be unrelated and passes on my machine after a rebase) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi created this revision. bazuzi added reviewers: ymandel, gribozavr2. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. bazuzi requested review of this revision. Herald added a project: clang. This will eliminate the need for more

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon updated this revision to Diff 517968. agozillon added a comment. - Move hostIRFilePath initialize invocation to ModuleTranslation.cpp to respect TargetOp patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you, this is a great suggestion! Just some minor wording changes, but otherwise LGTM. Comment at: clang/www/OpenProjects.html:40-44 other

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149458/new/ https://reviews.llvm.org/D149458 ___ cfe-commits mailing list

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. In D149276#4305780 , @shafik wrote: > I see that we do have an issue but so far the examples in the tests don't > feel very natural and so I would like to understand if there is a larger > motivation here. The context is that

[PATCH] D148381: [WIP][Clang] Add element_count attribute

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4170 +private: + mutable SmallVector CountFieldRanges; +public: `mutable`...my least favorite keyword in C++. If you drop `const` from `addCountFieldSourceRange`

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 517964. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index:

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dblaikie added a comment. In D149193#4302981 , @scott.linder wrote: > I am OK to give LGTM, assuming the other reviewers don't still have > reservations? Some - planning to get to this next week. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

shafik added a comment. I see that we do have an issue but so far the examples in the tests don't feel very natural and so I would like to understand if there is a larger motivation here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/

[PATCH] D149460: [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros

donat.nagy created this revision. donat.nagy added reviewers: gamesh411, Szelethus, steakhal, dkrupp. Herald added subscribers: manas, ASDenysPetrov, martong, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All.

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:58 Clang will only search for std::coroutine_traits for coroutines then. +- Clang doesn't accept flexible array members in unions in C++ anymore. Comment at:

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM. This is consistent with the target2 support that I added to LLD several years ago in https://reviews.llvm.org/D25684 will be good to give some time for other reviewers to add

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. rebased and clang-formatted the *hopefully* final file clang-format is angry at. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162 ___

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon updated this revision to Diff 517958. agozillon added a comment. - [Clang][OpenMP][IRBuilder] Tidy up function calls with helpful reviewer advice - [Clang][OpenMP][IRBuilder] Replace all getTargetEntryUniqueInfo with IRBuilder version - [Clang][OpenMP][IRBuilder] Run clang-format and

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

miyuki created this revision. miyuki added reviewers: peter.smith, phosek, michaelplatings. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. miyuki requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

donat.nagy marked an inline comment as done. donat.nagy added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149259/new/ https://reviews.llvm.org/D149259 ___ cfe-commits mailing list

[PATCH] D142967: [clangd] Introduce source.organizeImports code action.

hokein updated this revision to Diff 517948. hokein added a comment. rebase and polish the implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142967/new/ https://reviews.llvm.org/D142967 Files:

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a subscriber: rsmith. cor3ntin added a comment. @rsmith @hubert.reinterpretcast do you see any reason not to go ahead with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276

[PATCH] D149456: Basic documentation of -mrecip=... option

tim.schmielau created this revision. Herald added a project: All. tim.schmielau requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation is still rather terse because it needs to fit onto a single line of clang --help output. But

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

steakhal added a comment. Sure, Ill look at this on Tuesday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149259/new/ https://reviews.llvm.org/D149259 ___ cfe-commits mailing list

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:96 + + size_t getEffectivePTUSize() const; + It looks like this can be private? Also, just a note (not something you have to deal with in this review), the local

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim added a comment. In D148822#4305188 , @simonbutcher wrote: > I can't see anything wrong with this patch and it looks pretty > straightforward to me, but is it necessary? > > '-Wtypedef-redefinition' is documented as not applying to system headers

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis planned changes to this revision. TIFitis added a comment. @kiranchandramohan I am in the process of submitting a new patch for review which moves the map processing from Clang Codegen to OMPIRBuilder. Once that is moved we can just use that for dealing with the map operands. Thus

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 517921. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D149364: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

yaxunl accepted this revision. yaxunl added a comment. LGTM. This issue does not affect HIP as HIP headers have removed `__noinline__` as a macro since https://reviews.llvm.org/D124866 and `__attribute__((__noinline__))` is equivalent to `__attribute__((noinline))` for HIP. Repository: rG

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4305202 , @ilya-biryukov wrote: > In D148663#4301589 , > @DmitryPolukhin wrote: > >> And, if they do so, this diff will just does nothing because there is an >> exact

[PATCH] D149436: [clang] Do not attempt to zero-extend _BitInt(1) when not required

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks right to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149436/new/ https://reviews.llvm.org/D149436

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. balazske requested review of this revision. Herald added a

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa updated this revision to Diff 517903. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 Files: clang/lib/Basic/Targets/Mips.cpp clang/test/Driver/mips-abi.c clang/test/Driver/mips-cpu64abi32.c

  1   2   >