[PATCH] D149816: [clang][Interp] Implement __builtin_strcmp

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make our Function class keep a list of parameter

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

tbaeder added a comment. This patch was submitted by a beginner, because https://github.com/llvm/llvm-project/issues/62305 has the "good first issue" label. From the last few comments, I'm not sure they know how to proceed. Could you summarize what the next steps are? CHANGES SINCE LAST

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

owenpan added a comment. Please mark review comments as done after addressing them. Comment at: clang/unittests/Format/QualifierFixerTest.cpp:1356 + "template Foo const f();", + Style, std::vector(1, tooling::Range(0, 36))); +

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and introduce Bfloat16 arithmetic type.

codemzs added a comment. Thank you @erichkeane for your insightful review. I have addressed the feedback from your previous review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3486-3489 + Expanded.InsertBraces = true; + Passes.emplace_back([&](const Environment ) { +return BracesInserter(Env, Expanded).process(/*SkipAnnotation=*/true); });

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

chapuni added a comment. Please come in; https://discourse.llvm.org/t/rfc-let-mvt-generated-and-restore-mvt-into-llvm-codegen/69547/3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ https://reviews.llvm.org/D148767

[PATCH] D149809: [Clang][Docs] Fix man page build

tstellar added a comment. I think we could remove some of the duplication by making the docs_target parameter into a list and passing both docs-clang-html and docs-clang-man to it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149809/new/

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#4314612 , @xen0n wrote: > Hi, any update on this? Given the `$`-less style has been long established at > this time, and present in released GCC versions, it seems we indeed have to > follow suit (and later make

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

Manna updated this revision to Diff 519337. Manna retitled this revision from "[NFC][Clang]Fix static analyzer tool remarks about large copies by value" to "[NFC][Clang]Fix static analyzer tool remarks about large copies by values". Manna edited the summary of this revision. Manna added a

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman added reviewers: aaron.ballman, tstellar, rnk. aidengrossman added a comment. Posting this as when I was setting up a new dev environment with `-DLLVM_ENABLE_SPHINX`, it defaults to having `SPHINX_OUTPUT_HTML` and `SPHINX_OUTPUT_MAN` on, and the man build was broken so when I

[PATCH] D149809: [Clang][Docs] Fix man page build

aidengrossman created this revision. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes the man page build. It currently doesn't work as SOURCE_DIR isn't set correctly (just

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna updated this revision to Diff 519331. Manna added a comment. Fix clang-format errors and typo in comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files: clang/include/clang/Analysis/BodyFarm.h

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

tejohnson added a subscriber: yamauchi. tejohnson added a comment. Previously @yamauchi did a bunch of work related to this called PGSO (Profile Guided Size Optimization). See the functions in https://github.com/llvm-mirror/llvm/blob/master/lib/Transforms/Utils/SizeOpts.cpp, which are used to

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

efriedma added a comment. Is there some alternative way we can write this? Even if each of the overrides is only technically used in one place, it's a repeating pattern, and writing the casts inline makes it really hard to read. (Maybe the helpers can be somewhere else?) Repository: rG

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/6]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa added a comment. @MaskRay ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd93532dfc45: [MS ABI] Fix C++ mangling references to declarations. (authored by bolshakov-a, committed by efriedma). Repository: rG LLVM Github

[clang] cd93532 - [MS ABI] Fix C++ mangling references to declarations.

Author: Bolshakov Date: 2023-05-03T18:20:16-07:00 New Revision: cd93532dfc455255cb2fa553090d14aaa52b106b URL: https://github.com/llvm/llvm-project/commit/cd93532dfc455255cb2fa553090d14aaa52b106b DIFF: https://github.com/llvm/llvm-project/commit/cd93532dfc455255cb2fa553090d14aaa52b106b.diff

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

peixin added a comment. > @peixin , wdyt? @awarzynski Hi Andrzej, sorry for the late reply. I am distracted by several internal projects and other things in my life recently (just came back from vacation). My boss has not decided to let me continue working on LLVM Flang this year, yet.

[PATCH] D149666: [OpenMP][OMPIRBuilder] Migrate MapCombinedInfoTy from Clang to OpenMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149666/new/ https://reviews.llvm.org/D149666

[PATCH] D149802: [clang][modules] Avoid unnecessary writes of .timestamp files

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese, gribozavr. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

mtrofin added a comment. high level question, why not have it as a pass that runs after profiles (of whatever kind - instrumented or sample-based) are ingested. The pass would attribute functions as described. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

aeubanks added a comment. looking for feedback if this makes sense at all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149800/new/ https://reviews.llvm.org/D149800 ___ cfe-commits mailing list

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

aeubanks created this revision. Herald added subscribers: wlei, Enna1, ormris, wenlei, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. The performance of cold

[PATCH] D125171: [clang-format] Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 519293. jrmolin added a comment. more code review updates. pulled main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125171/new/ https://reviews.llvm.org/D125171 Files:

[PATCH] D149796: [clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file

davidstone created this revision. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `Sema.h` is huge. This makes a small reduction to it by moving `EnterExpressionEvaluationContext` into a new header,

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

barannikov88 added a comment. In D148767#4316464 , @chapuni wrote: > In D148767#4312692 , @barannikov88 > wrote: > >> Sorry, I don't follow. They may theoretically depend on anything. Why >>

[PATCH] D149791: [clang][deps] NFC: Replace a vector with an array

davidstone created this revision. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `ResourceDirectoryCache::findResourceDir` uses a `std::vector` when a `std::array` would do. Make this replacement

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 519259. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. In D147717#4312066 , @Fznamznon wrote: > In D147717#4275410 , @cjdb wrote: > >> I'm gonna get started on this today! > > @cjdb , how is this going? I've seen >

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. P.S. Landed. If it survives in the trunk this time - I'll send a follow-up diff with the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178

[clang] 3a54022 - [Clang][Sema] Fix comparison of constraint expressions

Author: Alexander Shaposhnikov Date: 2023-05-03T21:06:12Z New Revision: 3a540229341e3c8dc6d8ee61309eafaf943ea254 URL: https://github.com/llvm/llvm-project/commit/3a540229341e3c8dc6d8ee61309eafaf943ea254 DIFF:

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie marked an inline comment as done. dblaikie added a comment. In D149182#4312202 , @aaron.ballman wrote: > Precommit CI found a valid issue (at least on Debian, the Windows failure > appears to be unrelated but it's really hard to tell from that

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie updated this revision to Diff 519247. dblaikie added a comment. Describe condition in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149182/new/ https://reviews.llvm.org/D149182 Files: clang/docs/ReleaseNotes.rst

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie updated this revision to Diff 519245. dblaikie added a comment. Release note Restrict change to Clang ABI 16 and above (& test that condition) Fix AIX test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149182/new/

[PATCH] D149777: [clang][deps] Teach dep directive scanner about #pragma clang system_header

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b492d1be0ea: [clang][deps] Teach dep directive scanner about #pragma clang system_header (authored by benlangmuir). Repository: rG LLVM Github

[clang] 7b492d1 - [clang][deps] Teach dep directive scanner about #pragma clang system_header

Author: Ben Langmuir Date: 2023-05-03T13:53:21-07:00 New Revision: 7b492d1be0ea5b767cc567ca2792a291242f9973 URL: https://github.com/llvm/llvm-project/commit/7b492d1be0ea5b767cc567ca2792a291242f9973 DIFF: https://github.com/llvm/llvm-project/commit/7b492d1be0ea5b767cc567ca2792a291242f9973.diff

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

nikic added a comment. The demangling test shouldn't be modified at all. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140538/new/ https://reviews.llvm.org/D140538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

MaskRay added a comment. `-march=` `-mcpu=` `-mtune=` are from GCC and they traditionally have many opinions on the features. If GCC is going to have `-march=help`, I think adding `-march=help` to Clang to match is fine. But I'd really like to avoid aliases for non-compatibility reasons. They

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24f36a215b4e: [Modules] Move modulemaps to header search directories. NFC intended. (authored by vsapsai). Changed prior to commit:

[clang] 24f36a2 - [Modules] Move modulemaps to header search directories. NFC intended.

Author: Volodymyr Sapsai Date: 2023-05-03T13:07:47-07:00 New Revision: 24f36a215b4eabd1d0e4abcce0c9277085d88a96 URL: https://github.com/llvm/llvm-project/commit/24f36a215b4eabd1d0e4abcce0c9277085d88a96 DIFF:

[clang] 3aaf0be - Account for whitespace in the test regex

Author: Aaron Ballman Date: 2023-05-03T16:05:27-04:00 New Revision: 3aaf0bed1c68f0b0052a569437cbdf489ff68b56 URL: https://github.com/llvm/llvm-project/commit/3aaf0bed1c68f0b0052a569437cbdf489ff68b56 DIFF: https://github.com/llvm/llvm-project/commit/3aaf0bed1c68f0b0052a569437cbdf489ff68b56.diff

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added a comment. In D147626#4316535 , @efriedma wrote: > In D147626#4316212 , @aaron.ballman > wrote: > >> In D147626#4316190 , @efriedma >> wrote: >>

[PATCH] D149752: WIP: Debug symlink creation

ldionne updated this revision to Diff 519218. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Poke CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149752/new/ https://reviews.llvm.org/D149752

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 519216. oontvoo added a comment. Herald added a subscriber: ormris. - defined equivalent flag in the clang driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999

[clang] 24f8122 - Speculative fix for 9bb28a18d962e8f6e3fa8f48bd2c6dc183154d26

Author: Aaron Ballman Date: 2023-05-03T15:46:47-04:00 New Revision: 24f81228abaf158460157f26b0b6db2bfe2f05df URL: https://github.com/llvm/llvm-project/commit/24f81228abaf158460157f26b0b6db2bfe2f05df DIFF: https://github.com/llvm/llvm-project/commit/24f81228abaf158460157f26b0b6db2bfe2f05df.diff

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 519215. aeubanks added a comment. add -verify to module test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include/clang/AST/Expr.h

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Just some minor nits from me, but LG with those fixed up. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:230-232 def CXX20Designator :

[PATCH] D149776: Re-land "[AMDGPU] Define data layout entries for buffers""

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0415f2a456d: Re-land [AMDGPU] Define data layout entries for

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

kuganv added a comment. In D148088#4316352 , @kadircet wrote: > Sorry I was trying to give some brief idea about what it might look like in > `Implementation Concerns` section above, but let me give some more details; > > I think we can just change the

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

efriedma added a comment. In D147626#4316212 , @aaron.ballman wrote: > In D147626#4316190 , @efriedma > wrote: > >>> If there's not indications of this being disruptive on non-MSVC-compatible >>> targets, then

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:46 + +#define REPL_BUILTIN_TYPES \ + X(bool, Bool) \

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

nikic added a comment. In D143624#4316357 , @aeubanks wrote: > In D143624#4315508 , @nikic wrote: > >> In D143624#4315468 , @dmgreen >> wrote: >> >>> It looks like there

[clang] 298d9be - Another fix for 9bb28a18d962e8f6e3fa8f48bd2c6dc183154d26

Author: Aaron Ballman Date: 2023-05-03T15:27:59-04:00 New Revision: 298d9becef655c34731512ff3d41e3fbb3fca155 URL: https://github.com/llvm/llvm-project/commit/298d9becef655c34731512ff3d41e3fbb3fca155 DIFF: https://github.com/llvm/llvm-project/commit/298d9becef655c34731512ff3d41e3fbb3fca155.diff

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

tahonermann added inline comments. Comment at: clang/lib/Format/Format.cpp:3486-3489 + Expanded.InsertBraces = true; + Passes.emplace_back([&](const Environment ) { +return BracesInserter(Env, Expanded).process(/*SkipAnnotation=*/true); });

[PATCH] D149777: [clang][deps] Teach dep directive scanner about #pragma clang system_header

benlangmuir created this revision. benlangmuir added a reviewer: akyrtzi. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This ensures we get the correct FileCharacteristic during scanning. In a

[clang] b210ebe - Fix test bot breakage from 9bb28a18d962e8f6e3fa8f48bd2c6dc183154d26

Author: Aaron Ballman Date: 2023-05-03T15:18:48-04:00 New Revision: b210ebe5c545ab566488d303788b1d12a91fc767 URL: https://github.com/llvm/llvm-project/commit/b210ebe5c545ab566488d303788b1d12a91fc767 DIFF: https://github.com/llvm/llvm-project/commit/b210ebe5c545ab566488d303788b1d12a91fc767.diff

[PATCH] D149693: [clang][deps] Make clang-scan-deps write modules in raw format

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe8d69ddf88: [clang][deps] Make clang-scan-deps write modules in raw format (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8fe8d69 - [clang][deps] Make clang-scan-deps write modules in raw format

Author: Ben Langmuir Date: 2023-05-03T12:07:46-07:00 New Revision: 8fe8d69ddf881db70cb8df31e614a06e633e2c5f URL: https://github.com/llvm/llvm-project/commit/8fe8d69ddf881db70cb8df31e614a06e633e2c5f DIFF: https://github.com/llvm/llvm-project/commit/8fe8d69ddf881db70cb8df31e614a06e633e2c5f.diff

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

chapuni added a comment. In D148767#4312692 , @barannikov88 wrote: > Sorry, I don't follow. They may theoretically depend on anything. Why > CodeGen/CodeGenTypes, specifically? > If they don't require it, why add it? I added deps pessimistically,

[PATCH] D149776: Re-land "[AMDGPU] Define data layout entries for buffers""

krzysz00 created this revision. Herald added subscribers: kosarev, jeroen.dobbelaere, foad, wenlei, okura, kuter, kerbowa, arphaman, zzheng, hiraditya, tpr, dstuttard, yaxunl, jvesely, kzhuravl, arsenm, MatzeB. Herald added a project: All. krzysz00 requested review of this revision. Herald added

[PATCH] D148800: [C2x] Update 'nullptr' implementation based on CD comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9bb28a18d962: [C2x] Update nullptr implementation based on CD comments (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES

[clang] 9bb28a1 - [C2x] Update 'nullptr' implementation based on CD comments

Author: Aaron Ballman Date: 2023-05-03T14:50:15-04:00 New Revision: 9bb28a18d962e8f6e3fa8f48bd2c6dc183154d26 URL: https://github.com/llvm/llvm-project/commit/9bb28a18d962e8f6e3fa8f48bd2c6dc183154d26 DIFF: https://github.com/llvm/llvm-project/commit/9bb28a18d962e8f6e3fa8f48bd2c6dc183154d26.diff

[PATCH] D148924: [clang] Show error if defaulted comparions operator function is volatile or has ref-qualifier &&.

aaron.ballman added reviewers: hubert.reinterpretcast, shafik, rsmith. aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. Did you verify that the rest of P2002R1 was implemented correctly? There are a lot more changes in that paper than just this tiny bit, so if we're not

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga updated this revision to Diff 519190. oskarwirga edited the summary of this revision. oskarwirga added a comment. Turns out the lowering of ubsantrap() to a single instruction resulted in binaries that did NOT have nonmerged traps, so this is going back to what we had before. I also

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3486-3489 + Expanded.InsertBraces = true; + Passes.emplace_back([&](const Environment ) { +return BracesInserter(Env, Expanded).process(/*SkipAnnotation=*/true); });

[PATCH] D149640: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG791b0fd02668: [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG (authored by kinu, committed by mboehme). Repository: rG LLVM

[clang] 791b0fd - [clang][dataflow] Change PruneTriviallyFalseEdges for building CFG

Author: Kinuko Yasuda Date: 2023-05-03T18:42:15Z New Revision: 791b0fd02668fd0fcf07788d4e16bb468434f4bf URL: https://github.com/llvm/llvm-project/commit/791b0fd02668fd0fcf07788d4e16bb468434f4bf DIFF: https://github.com/llvm/llvm-project/commit/791b0fd02668fd0fcf07788d4e16bb468434f4bf.diff

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

pkasting added a comment. Thanks @rsmith; I don't have commit access, so can you land the updated patch for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149713/new/ https://reviews.llvm.org/D149713

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

pkasting updated this revision to Diff 519188. pkasting added a comment. Update test per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149713/new/ https://reviews.llvm.org/D149713 Files: clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4315508 , @nikic wrote: > In D143624#4315468 , @dmgreen wrote: > >> It looks like there is quite a lot more optimization that happens to the >> function being always-inlined

[PATCH] D148088: [RFC][clangd] Move preamble index task to a seperate task

kadircet added a comment. Sorry I was trying to give some brief idea about what it might look like in `Implementation Concerns` section above, but let me give some more details; I think we can just change the signature for PreambleParsedCallback

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay added a comment. In D149193#4316293 , @dblaikie wrote: > I guess my main question is: What's the motivation for implementing this? Do > you have a need/use for this? (it doesn't seem to be motivated by GCC > compatibility - as discussed, looks

[PATCH] D149693: [clang][deps] Make clang-scan-deps write modules in raw format

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149693/new/ https://reviews.llvm.org/D149693 ___ cfe-commits mailing list

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:3486-3489 + Expanded.InsertBraces = true; + Passes.emplace_back([&](const Environment ) { +return BracesInserter(Env, Expanded).process(/*SkipAnnotation=*/true); });

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

peter.smith added a comment. My apologies for not responding. If I've got this right there are 4 related patches: D148573 (approved) D148785 Use type hashes rather than RTTI D148827 support

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

MyDeveloperDay added a comment. ok! I'm not a massive lambda expert, but aren't we passing by const reference e.g. `const FormatStyle `, can someone give me a lession as to why it thinks its by value? maybe I'm looking at the wrong "pass by" Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dblaikie added a comment. I guess my main question is: What's the motivation for implementing this? Do you have a need/use for this? (it doesn't seem to be motivated by GCC compatibility - as discussed, looks like we're diverging in a bunch of ways from their behavior and the argument made

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

Manna added a comment. Thanks @erichkeane for response. @MyDeveloperDay, Our internal Coverity link won't work without login. This is what Coverity was complaining about. Big parameter passed by value Copying large values is inefficient, consider passing by reference; Low, medium, and high

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added a comment. In D147626#4316190 , @efriedma wrote: >> If there's not indications of this being disruptive on non-MSVC-compatible >> targets, then we may still be able to get away with rejecting the extension >> there. > > If we need

[PATCH] D148800: [C2x] Update 'nullptr' implementation based on CD comments

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148800/new/ https://reviews.llvm.org/D148800 ___ cfe-commits mailing list

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

efriedma added a comment. > If there's not indications of this being disruptive on non-MSVC-compatible > targets, then we may still be able to get away with rejecting the extension > there. If we need to have the codepath anyway, there isn't much harm in allowing it on all targets, I think.

[PATCH] D149149: [clang][Interp] Check one-past-the-end pointers in GetPtrField

shafik added a subscriber: rsmith. shafik added inline comments. Comment at: clang/test/AST/Interp/records.cpp:509 constexpr A *a2 = + 1; // expected-error {{must be initialized by a constant expression}} \ // expected-note {{cannot access

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

donat.nagy added a comment. > It's gonna be bumpy. Yup :) but it's not impossible... > Also, note that this is in production here, so it will take me time to verify > the patches. So, I'd probably prefer to have a patch stack, and do the > evaluation for some selected patches - basically

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

erichkeane added a comment. In D149647#4316134 , @MyDeveloperDay wrote: > Can you link to the Coverity issue so we can see what it was complaining > about? Unfortunately this is from an internal-run of Coverity that Intel is running. I'd be shocked

[PATCH] D149650: Give NullabilityKind a printing operator<

aaron.ballman added a comment. In D149650#4315211 , @sammccall wrote: > In D149650#4312389 , @aaron.ballman > wrote: > >> I guess I'm not seeing much motivation for this change. We already have >>

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

MyDeveloperDay added a comment. Can you link to the Coverity issue so we can see what it was complaining about? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647

[PATCH] D149643: [clang-format] Correctly limit formatted ranges when specifying qualifier alignment

MyDeveloperDay added a comment. Thanks for the patch...this tells me people are starting to use this feature in anger!! i.e. your formatting via git-clang-format (which is brave!) ;-) which means you have the code modifying features perhaps on my default... LGTM, if you will need someone to

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added a comment. In D147626#4315283 , @Fznamznon wrote: > I've got an error from buildbot on Windows: > > C:\Program Files (x86)\Windows > Kits\10\include\10.0.19041.0\um\winioctl.h:13404:51: error: flexible array > member 'Lev1Depends'

[PATCH] D149695: MS inline asm: remove obsolete code adding AOK_SizeDirective (e.g. dword ptr)

MaskRay added a comment. In D149695#4315194 , @hans wrote: >> The AOK_SizeDirective part from 5b37c181291210bedfbb7a6af5d51229f3652ef0 >> (2014-08) seems unneeded nowadays (the root cause has likely been fixed >> elsewhere). > > Would it be possible to

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

aaron.ballman added subscribers: v.g.vassilev, junaire, rsmith. aaron.ballman added a comment. Adding in some of the clang-repl folks because they are likely to run into this as well, and adding Richard in case he has more historical context. What I understand of the historical context here is

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with the extra test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149713/new/ https://reviews.llvm.org/D149713

[PATCH] D149460: [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c22cbea87be: [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros (authored by donat.nagy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149713: [Sema] Avoid emitting warnings for constant destruction.

rsmith added a comment. I think this would be an interesting test: struct S { /*not constexpr*/ S(); constexpr ~S() {} }; S s; // no warning struct T { /*not constexpr*/ T(); constexpr ~T() { if (b) {} } bool b; }; T t; // expected-warning {{exit-time

[clang] 8c22cbe - [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros

Author: Donát Nagy Date: 2023-05-03T18:52:27+02:00 New Revision: 8c22cbea87beb74da3dc5891c40cdf574cd5fe56 URL: https://github.com/llvm/llvm-project/commit/8c22cbea87beb74da3dc5891c40cdf574cd5fe56 DIFF: https://github.com/llvm/llvm-project/commit/8c22cbea87beb74da3dc5891c40cdf574cd5fe56.diff

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! I did not spot any other concerns beyond the macro value one. Thank you for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149553/new/

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi updated this revision to Diff 519131. giulianobelinassi added a comment. Incorporate some of Aron suggestions: - Replace isDeclspecAttribute with isStandardAttributeSyntax - Avoid multiple calls to getAsFunction - Use AttrPrintLoc:: instead of referencing the value directly -

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - thanks, then I'm going to give it another try. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 ___

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam added a comment. (Sorry for taking so long to get to it!) Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >