[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added a comment. Sorry, I'm a little occupied lately and don't have time to fix the test failure. I'll try to fix that in this week. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:400 + bool ActiveKindLookup[static_cast(HighlightingKind::LastKind)

[PATCH] D150089: [LoongArch] Support fcc* (condition flag) registers in inlineasm clobbers

xen0n accepted this revision. xen0n added a comment. It's confirmed offline that LA32 also has 8 `$fcc`'s, so the existing assumption holds, and the code changes are correct. (Apparently the "LA32 Reduced" subset is not supported right now, which only has one `$fcc0`.) Repository: rG LLVM

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

pcwang-thead added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSiFive7.td:15 +class SiFive7IsWorstCaseMX MxList> { + string LLMUL = LargestLMUL.r; + bit c = !eq(mx, LLMUL); I think I have fixed the issue that `defar` can't refer to template

[PATCH] D150089: [LoongArch] Support fcc* (condition flag) registers in inlineasm clobbers

hev accepted this revision. hev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150089/new/ https://reviews.llvm.org/D150089 ___

[clang] 749b4ad - [clang] Modernize LoopHint (NFC)

Author: Kazu Hirata Date: 2023-05-08T20:23:33-07:00 New Revision: 749b4ad315215534f0c6de2c9c732e1de750d8af URL: https://github.com/llvm/llvm-project/commit/749b4ad315215534f0c6de2c9c732e1de750d8af DIFF: https://github.com/llvm/llvm-project/commit/749b4ad315215534f0c6de2c9c732e1de750d8af.diff

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay updated this revision to Diff 520573. MaskRay added a comment. use `llvm::sys::path::stem(getDefaultImageName())` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149193/new/ https://reviews.llvm.org/D149193 Files:

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay marked 3 inline comments as done. MaskRay added a comment. In D149193#4328452 , @dblaikie wrote: >> I agree that for most(all?) split DWARF users will not see any difference >> since they always use -c -o and don't combine compilation and

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4c87f8ccacc: [clang-format] Fix consecutive alignments in #else blocks (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D150057?vs=520137=520560#toc Repository: rG LLVM

[clang] a4c87f8 - [clang-format] Fix consecutive alignments in #else blocks

Author: Owen Pan Date: 2023-05-08T19:45:30-07:00 New Revision: a4c87f8ccaccc76fd7d1c6c2e639ca84b9ec7794 URL: https://github.com/llvm/llvm-project/commit/a4c87f8ccaccc76fd7d1c6c2e639ca84b9ec7794 DIFF: https://github.com/llvm/llvm-project/commit/a4c87f8ccaccc76fd7d1c6c2e639ca84b9ec7794.diff

[PATCH] D150057: [clang-format] Fix consecutive alignments in #else blocks

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:6394 + "#elif BAZ\n" + "bool ab = true;\n" + "#endif\n" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Thank you for the opinions. I've updated and please take a look. Comment at: clang-tools-extra/clangd/Hover.cpp:705 + + // If macro expands to one single token, rule out punctuator or digraph. + // E.g., for the case `array L_BRACKET 42 R_BRACKET;`

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 520555. zyounan marked 2 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files:

[PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:259-265 +static unsigned getPtrOrVecOfPtrsAddressSpace(Type *Ty) { + if (Ty->isVectorTy()) { +Ty = cast(Ty)->getElementType(); + } + assert(Ty->isPointerTy()); + return

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

vsapsai added a comment. In D148776#4328425 , @dblaikie wrote: > Got a link to a design discussion motivating this change? No design discussion. I though that doing less work is not contentious. > I'd have thought it made sense to put modulemaps in

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dblaikie added a comment. > I agree that for most(all?) split DWARF users will not see any difference > since they always use -c -o and don't combine compilation and linking in one > command. Given that, I'm not sure that this is worth implementing, but if it suits you I guess.

[clang] e494ebf - [OpenMP] Fix incorrect interop type for number of dependencies

Author: Joseph Huber Date: 2023-05-08T21:02:43-05:00 New Revision: e494ebf9d09b1112dcf4f22984bdb51bbf5d8cd7 URL: https://github.com/llvm/llvm-project/commit/e494ebf9d09b1112dcf4f22984bdb51bbf5d8cd7 DIFF: https://github.com/llvm/llvm-project/commit/e494ebf9d09b1112dcf4f22984bdb51bbf5d8cd7.diff

[PATCH] D150156: [OpenMP] Fix incorrect interop type for number of dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe494ebf9d09b: [OpenMP] Fix incorrect interop type for number of dependencies (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 ___ cfe-commits mailing list

[PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

dblaikie added a comment. Got a link to a design discussion motivating this change? I'd have thought it made sense to put modulemaps in subdirectories - since they cover the whole directory, putting them in the root of an include path would be problematic if there are multiple distinct

[PATCH] D149495: [RISCV] Add support for V extension in SiFive7

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSchedSiFive7.td:112 + // Note: c >= 1 since the smallest VLUpperBound is 512 / 8 = 8, and the + // largest division performed on VLUpperBound is in MF8 case with division + // by 8. Therefore, there

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2042 + + SmallVector Operands; + if (ResultType->isIntOrIntVectorTy(1)) { Don't use SmallVector for a fixed number of items. You can use a plain array.

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak added a comment. In D148851#4328345 , @shafik wrote: > In D148851#4328084 , @dblaikie > wrote: > >> In D148851#4311266 , @ahatanak >> wrote: >> >>> Disable

[PATCH] D150156: [OpenMP] Fix incorrect interop type for number of dependencies

jhuber6 updated this revision to Diff 520543. jhuber6 added a comment. Fix `add_attributes.ll` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150156/new/ https://reviews.llvm.org/D150156 Files: clang/test/OpenMP/interop_irbuilder.cpp

[PATCH] D150156: [OpenMP] Fix incorrect interop type for number of dependencies

jhuber6 added a comment. In D150156#4328360 , @tianshilei1992 wrote: > Does this cause the IR issue? Not sure, I just get an undefined symbol error in the linker now. Not sure if that means it's resolved or I just can't reproduce it. Repository:

[PATCH] D150156: [OpenMP] Fix incorrect interop type for number of dependencies

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Does this cause the IR issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150156/new/ https://reviews.llvm.org/D150156

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:109-113 +Warnings + +- Address a false positive in ``-Wpacked`` when applied to a non-pod type using + Clang ABI >= 15 (fixes `#62353`_, +

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

shafik added a comment. In D148851#4328084 , @dblaikie wrote: > In D148851#4311266 , @ahatanak > wrote: > >> Disable llvm-symbolizer when running lit tests. > > This seems problematic though - when lit tests

[clang] 793c5b1 - Fix for release notes (follow-up to D149182/a8b0c6fa)

Author: David Blaikie Date: 2023-05-09T00:40:11Z New Revision: 793c5b12b9a70e363be40c5da2e26d7151fbbf41 URL: https://github.com/llvm/llvm-project/commit/793c5b12b9a70e363be40c5da2e26d7151fbbf41 DIFF: https://github.com/llvm/llvm-project/commit/793c5b12b9a70e363be40c5da2e26d7151fbbf41.diff

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

dblaikie added inline comments. Comment at: clang/docs/ReleaseNotes.rst:109-113 +Warnings + +- Address a false positive in ``-Wpacked`` when applied to a non-pod type using + Clang ABI >= 15 (fixes `#62353`_, +

[PATCH] D149182: Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dblaikie marked an inline comment as done. Closed by commit rGa8b0c6fa28ac: Remove -Wpacked false positive for non-pod types where the layout isnt… (authored by

[clang] a8b0c6f - Remove -Wpacked false positive for non-pod types where the layout isn't directly changed

Author: David Blaikie Date: 2023-05-09T00:13:45Z New Revision: a8b0c6fa28acced71db33e80bd0b51d00422035b URL: https://github.com/llvm/llvm-project/commit/a8b0c6fa28acced71db33e80bd0b51d00422035b DIFF: https://github.com/llvm/llvm-project/commit/a8b0c6fa28acced71db33e80bd0b51d00422035b.diff

[PATCH] D150156: [OpenMP] Fix incorrect interop type for number of dependencies

jhuber6 updated this revision to Diff 520526. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150156/new/ https://reviews.llvm.org/D150156

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added a comment. In D141451#4312256 , @aaron.ballman wrote: > In D141451#4311199 , @dblaikie > wrote: > >>> probably too much, but then I wonder "how do we make Fortify work?". >> >> (I'm still sort of

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. In D148851#4311266 , @ahatanak wrote: > Disable llvm-symbolizer when running lit tests. This seems problematic though - when lit tests fail it's quite helpful to get a symbolized stack trace. Repository: rG LLVM Github

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

dschuff added a comment. or use `--keep-section` to match objcopy/strip? https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/llvm-objcopy/wasm/basic-keep.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

dschuff added a comment. Yeah, I think that would work. Or maybe `--preserve-sections=sec1,sec2` since we might want to preserve multiple sections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149917/new/ https://reviews.llvm.org/D149917

[PATCH] D150151: [clang] Prevent creation of new submodules in ASTWriter

benlangmuir added a comment. No test, because I haven't come up with a test case that wouldn't be invalidated by https://reviews.llvm.org/D103930. Let me know if you have any ideas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150151/new/

[PATCH] D150151: [clang] Prevent creation of new submodules in ASTWriter

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid inferring new submodules for headers in ASTWriter's collection of

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5da7f30f24c4: [AIX][Clang][K] Create `-K` Option for AIX. (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5da7f30 - [AIX][Clang][K] Create `-K` Option for AIX.

Author: Michael Francis Date: 2023-05-08T22:53:44Z New Revision: 5da7f30f24c4620c4f4425206fbdd0921d333dc0 URL: https://github.com/llvm/llvm-project/commit/5da7f30f24c4620c4f4425206fbdd0921d333dc0 DIFF: https://github.com/llvm/llvm-project/commit/5da7f30f24c4620c4f4425206fbdd0921d333dc0.diff

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 520502. francii added a comment. Remove leftover marker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 520496. HerrCai0907 marked 2 inline comments as done. HerrCai0907 added a comment. use 1 replace 0 as length Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2583 +if (ArraySize->containsErrors()) { + RecoveryExpr *RE = RecoveryExpr::Create( + Context, ArraySize->getType(), ArraySize->getBeginLoc(), erichkeane wrote: >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

rnk edited reviewers, added: hans, efriedma; removed: majnemer, rnk, aeubanks. rnk added a comment. Thanks for working on this, this is also an issue for our users. I've been out on leave. I replaced myself as a reviewer with Hans. CHANGES SINCE LAST ACTION

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 520491. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor fixup as noted Comment at: clang/test/Driver/aix-ld.c:1123 +// CHECK-K-UNUSED: clang: warning: -K: 'linker' input unused

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Seems pretty reasonable to add a bounds check here. You should probably add a comment explaining the reasoning though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

benlangmuir added a comment. We have several new build failures with this change that I'm looking through. So far, a common one is an error of the form /source/module.modulemap: error: redefinition of module /build/Foo.framework/Modules/module.modulemap: note: previously defined here ie.

[PATCH] D149917: [lld][WebAssembly] Add --preserve-features flag

sbc100 added a comment. In D149917#4322367 , @dschuff wrote: > Do we want to make this any more general? In the future we might want to > preserve other sections, e.g. passing optimization or profiling info from > LLVM to Binaryen. Or maybe JSPI info?

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

rnk added a subscriber: hans. rnk added a comment. This feels to me like we are still working around some incompatibilities between the MSVC intrin.h / intrin0.h model. I would prefer it if we could always use `static inline` consistently in our intrinsic headers so we don't have to worry

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu added a comment. In D149867#4325040 , @jrtc27 wrote: > So GCC gives me: > > warning: ‘stdcall’ attribute directive ignored [-Wattributes] > > when trying to use `__attribute__((stdcall))` on m68k, which matches the fact > it's only mentioned in

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

shafik added inline comments. Comment at: clang/test/AST/Interp/lambda.cpp:5 +constexpr int a = 12; +constexpr int f = [c = a]() { return c; }(); +static_assert(f == a); Fun case ``` int constexpr f() { return [x = 10] { decltype(x) y; // type int

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 520478. bolshakov-a added a subscriber: hubert.reinterpretcast. bolshakov-a added a comment. Avoid binding references in template arguments to bit-fields. @erichkeane, @hubert.reinterpretcast, please verify. CHANGES SINCE LAST ACTION

[PATCH] D150136: [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2c917f7f668: [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain (authored by jhuber6). Repository: rG LLVM Github Monorepo

[clang] c2c917f - [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

Author: Joseph Huber Date: 2023-05-08T15:54:50-05:00 New Revision: c2c917f7f6680ec7a1214af9f5105c2beb9ba162 URL: https://github.com/llvm/llvm-project/commit/c2c917f7f6680ec7a1214af9f5105c2beb9ba162 DIFF: https://github.com/llvm/llvm-project/commit/c2c917f7f6680ec7a1214af9f5105c2beb9ba162.diff

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

erichkeane added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:302 unsigned Shift = llvm::countr_zero(Mask); + assert(Shift >= 64 && "Shift is out of encodable range"); return (V << Shift) & Mask; Shouldn't this be:

[clang] ca06638 - [SYCL][NFC] Remove dead code

Author: Elizabeth Andrews Date: 2023-05-08T13:08:23-07:00 New Revision: ca06638bbbf42a511d1be141fc7c547c7995ed29 URL: https://github.com/llvm/llvm-project/commit/ca06638bbbf42a511d1be141fc7c547c7995ed29 DIFF:

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna created this revision. Manna added reviewers: erichkeane, tahonermann. Herald added a subscriber: ctetreau. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Static Analyzer Tool, Coverity: Bad bit shift operation The

[PATCH] D150137: [clang][dataflow][NFC] Remove `SkipPast` param from `getValue(const ValueDecl &)`.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! It's really exciting to see this concept being erased from the API! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150137/new/

[PATCH] D150136: [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. > right now all it's used for is HostTriple.isOSWindows() OK. In that case we may want to rename the parameter to `BuildHostTriple` to make it clear which host we have in mind. Repository: rG

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

jsjodin added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4376 +function_ref CustomMapperCB) { + auto EmitNonContiguousDescriptor = [&]() { +MapInfosTy::StructNonContiguousInfo = I don't think we need a lambda function, it

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

efriedma added a comment. I'm having a bit of trouble following how exactly the thunk creation is working here... do we generate different code depending on whether the call operator and/or the static invoker are referenced? Why is the function in EmitLambdaInAllocaCallOpFn not getting

[PATCH] D150139: [clang-repl] Enable basic multiline support.

v.g.vassilev created this revision. v.g.vassilev added reviewers: junaire, sunho, aaron.ballman. Herald added a project: All. v.g.vassilev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. This patch allows the users to use

[PATCH] D150136: [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

jhuber6 added a comment. In D150136#4327570 , @tra wrote: > The change may be an improvement, but we may still have a potential issue > here. > > E.g. ideally we may want to be able to cross-compile a CUDA app on a powerpc > or ARM build host targeting

[PATCH] D150136: [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

tra added a comment. The change may be an improvement, but we may still have a potential issue here. E.g. ideally we may want to be able to cross-compile a CUDA app on a powerpc or ARM build host targeting NVIDIA GPU on a x86 host. So, the compilation tools would need to be found for the

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. Thanks! That was blocking our jupyter integration so I decided to go ahead here since we already missed the clang17 train... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

aaron.ballman added a comment. LGTM :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D147920: [clang] Add test for CWG399

aaron.ballman accepted this revision. aaron.ballman added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CXX/drs/dr3xx.cpp:1439 + +namespace dr399 { // dr399: 11 + // NB: reuse dr244 test aaron.ballman

[PATCH] D150137: [clang][dataflow][NFC] Remove `SkipPast` param from `getValue(const ValueDecl &)`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This parameter was already a no-op, so removing

[PATCH] D150072: [clang] Fix __is_trivially_equality_comparable for non-trivially-copyable types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG465d48748131: [clang] Fix __is_trivially_equality_comparable for non-trivially-copyable types (authored by philnik). Repository: rG LLVM Github

[clang] 465d487 - [clang] Fix __is_trivially_equality_comparable for non-trivially-copyable types

Author: Nikolas Klauser Date: 2023-05-08T12:07:28-07:00 New Revision: 465d487481313492e13435f3f03874b923b86ce3 URL: https://github.com/llvm/llvm-project/commit/465d487481313492e13435f3f03874b923b86ce3 DIFF:

[PATCH] D150136: [Clang] Change default triple to LLVM_HOST_TRIPLE for the CUDA toolchain

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl. Herald added a subscriber: mattd. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When cross-compiling NVPTX we use the

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149193/new/ https://reviews.llvm.org/D149193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150075/new/ https://reviews.llvm.org/D150075

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 520455. francii added a comment. Don't claim `-k` when checking target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D149612: [Sema] avoid merge error type

erichkeane requested changes to this revision. erichkeane added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Sema/SemaType.cpp:2583 +if (ArraySize->containsErrors()) { + RecoveryExpr *RE = RecoveryExpr::Create( +

[clang] 96bc786 - [Clang] Update warning on some designator initializer cases involving unions

Author: Shafik Yaghmour Date: 2023-05-08T11:14:33-07:00 New Revision: 96bc78631f16fe5ce2e7e6000b74d790b32f7a16 URL: https://github.com/llvm/llvm-project/commit/96bc78631f16fe5ce2e7e6000b74d790b32f7a16 DIFF:

[PATCH] D149694: [Clang] Update warning on some designator initializer cases involving unions

This revision was automatically updated to reflect the committed changes. Closed by commit rG96bc78631f16: [Clang] Update warning on some designator initializer cases involving unions (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 520447. to268 added a comment. Fixed auto char arrays with explicit brackets c auto foo[] = "bar"; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files:

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. Hi all! The CI builds are all clean now. Any further comment/review on this? Would love to close this out soon. Thanks! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144999/new/ https://reviews.llvm.org/D144999

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2c4620c1dadc: [clang-repl] Consider the scope spec in template lookups for deduction guides. (authored by v.g.vassilev).

[clang] 2c4620c - [clang-repl] Consider the scope spec in template lookups for deduction guides.

Author: Vassil Vassilev Date: 2023-05-08T17:54:56Z New Revision: 2c4620c1dadc032f968ce0aa835a441f268a8cdb URL: https://github.com/llvm/llvm-project/commit/2c4620c1dadc032f968ce0aa835a441f268a8cdb DIFF: https://github.com/llvm/llvm-project/commit/2c4620c1dadc032f968ce0aa835a441f268a8cdb.diff

[PATCH] D147319: [clang-repl] Consider the scope spec in template lookups for deduction guides

v.g.vassilev added a comment. Let's rely on a post-commit review here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147319/new/ https://reviews.llvm.org/D147319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe updated this revision to Diff 520439. mikecrowe added a comment. Address many more review comments, including: - Only add casts for signed/unsigned discrepancy if StrictMode option is set. - Use IncludeInserter to add or other required header. Review comments still outstanding: -

[PATCH] D149981: [clang][AST][NFC] Factor out check for structural equivalence of names.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94252713f9a7: [clang][AST][NFC] Factor out check for structural equivalence of names. (authored by davidstone, committed by aaron.ballman).

[clang] 9425271 - [clang][AST][NFC] Factor out check for structural equivalence of names.

Author: David Stone Date: 2023-05-08T13:27:36-04:00 New Revision: 94252713f9a7fdeeb18a7e43a9d414ea09fc0c13 URL: https://github.com/llvm/llvm-project/commit/94252713f9a7fdeeb18a7e43a9d414ea09fc0c13 DIFF: https://github.com/llvm/llvm-project/commit/94252713f9a7fdeeb18a7e43a9d414ea09fc0c13.diff

[PATCH] D149981: [clang][AST][NFC] Factor out check for structural equivalence of names.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I'll fix up the nits when I land on your behalf. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1456-1467 +static bool

[PATCH] D149834: [clang][Interp] Fix ignoring TypeTraitExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149834/new/ https://reviews.llvm.org/D149834 ___ cfe-commits mailing

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ayzhao updated this revision to Diff 520429. ayzhao marked an inline comment as done. ayzhao added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150001/new/ https://reviews.llvm.org/D150001 Files:

[PATCH] D150071: [clang-tidy] Fix bugprone-assert-side-effect to actually give warnings

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/Inputs/assert-side-effect/assert.h:1 +int abort() { return 0; } + There should

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7579b25df78: [Clang] Improve compile times when forming a DeclRef outside of a capturing… (authored by cor3ntin). Changed prior to commit:

[clang] a7579b2 - [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

Author: Corentin Jabot Date: 2023-05-08T18:41:24+02:00 New Revision: a7579b25df78a9f53d62300020d4ae3c4734 URL: https://github.com/llvm/llvm-project/commit/a7579b25df78a9f53d62300020d4ae3c4734 DIFF:

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Fantastic, that's some nice green in there. LGTM modulo nits, please add `NFC` to the patch summary when landing so folks know not to expect test coverage. Repository: rG

[PATCH] D149965: [clang][Interp] Fix tests for ignored expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594 +if (DiscardResult) + return true; + tbaeder wrote: >

[PATCH] D149965: [clang][Interp] Fix tests for ignored expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594 +if (DiscardResult) + return true; + aaron.ballman wrote: > For my own understanding -- why do we not need to call `discard()` on the > operand expression? Is

[PATCH] D149965: [clang][Interp] Fix tests for ignored expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:593-594 +if (DiscardResult) + return true; + For my own understanding -- why do we not need to call `discard()` on the operand expression?

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LG pending test coverage being ready to land Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr,

[clang] 8cd90fd - [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

Author: Alvin Wong Date: 2023-05-09T00:07:40+08:00 New Revision: 8cd90fd1a8233b2dcb96451eab7c6baea3180f54 URL: https://github.com/llvm/llvm-project/commit/8cd90fd1a8233b2dcb96451eab7c6baea3180f54 DIFF: https://github.com/llvm/llvm-project/commit/8cd90fd1a8233b2dcb96451eab7c6baea3180f54.diff

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

This revision was automatically updated to reflect the committed changes. Closed by commit rG8cd90fd1a823: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only (authored by alvinhochun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   3   >