[PATCH] D127910: [Clang][AArch64][SME] Add vector load/store (ld1/st1) intrinsics

bryanpkc updated this revision to Diff 522064. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127910/new/ https://reviews.llvm.org/D127910 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/include/clang/Basic/BuiltinsARM.def clang/incl

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments! Comment at: clang/lib/Driver/ToolChains/AIX.cpp:132 +// possible. Then `-bforceimprw` changes such sections to R

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

bryanpkc added a comment. Rebased on main, and removed dependence on the SME attributes patch as per https://reviews.llvm.org/D127910?vs=522039&id=522064#inline-1451681. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128648/new/ https://reviews.llv

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein updated this revision to Diff 522067. hokein marked 3 inline comments as done. hokein added a comment. Herald added a subscriber: mgrang. address comments and polish implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added a comment. I have polished the implementation about the fix-all for missing-include diagnostics, please take a look on the new code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/ https://reviews.llvm.org/D149437 _

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

alejandro-alvarez-sonarsource added a comment. In D150258#4337880 , @aaron.ballman wrote: > LGTM! Do you need me to commit on your behalf? If so, what name and email > address would you like used for patch attribution? Thanks a lot! And yes, I would ne

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme updated this revision to Diff 522075. mboehme added a comment. Set `-fnodelayed-template-parsing` again. This is needed to make tests pass on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/ https://reviews.llvm.org/D1503

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2537 -TEST(TransferTest, DerefDependentPtr) { std::string Code = R"( mboehme wrote: > gribozavr2 wrote: > > This `DerefDependentPtr` test was originally added

[PATCH] D150191: [clang][Diagnostics] Provide a source range for 'use of undeclared identifier' diagnostics

tbaeder abandoned this revision. tbaeder added a comment. Abandoning this. The code in question was dead before as far as I can tell, since the `Ranges` list was always empty. I can't add this without regressing any of the existing tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. In D149718#4341052 , @uabelho wrote: > Compiling with clang 15.0.5 I get the following warning/error with this patch: > > ../../clang/include/clang/Sema/ParsedAttr.h:705:18: error: explicitly > defaulted move assignment operato

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv updated this revision to Diff 522083. kuganv added a comment. Fixed tests clangd/unittests/TUSchedulerTests.cpp require re-warite due to delayed onPreambleAST callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148088/new/ https://revie

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149733/new/ https://reviews.llvm.org/D149733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D150548: [clangd] Deduplicate diagnostic codeaction fixes when the codeaction fixes multiple diagnostics

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman created this revision. jobnoorman added reviewers: chandlerc, grosbach, andreadb, MaskRay, craig.topper. Herald added subscribers: bviyer, asb, luke, Moerafaat, zero9178, bzcheeseman, pmatos, sdasgup3, wenzhicui, wrengr, ormris, foad, cota, teijeong, frasercrmck, rdzhabarov, tatianash

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme updated this revision to Diff 522096. mboehme added a comment. Spell `-fno-delayed-template-parsing` correctly (it was missing a hyphen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/ https://reviews.llvm.org/D150352 Files: c

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan added a comment. To enable specific EEW for specific insturction in instruction selection, I will create some parent revisions. Here is the first one. https://reviews.llvm.org/D150550 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15025

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. @aaron.ballman this won;t get approve by core un In D149276#4302700 , @aaron.ballman wrote: > The changes generally LGTM, but: > >> in a way consistent with the proposed resolution to CWG1223. > > What are the chances that CWG

[PATCH] D150552: [analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive

mkmvzlb created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mkmvzlb requested review of this revision.

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

egorzhdan added a comment. @Bigcheese, @ChuanqiXu, could you please take a look at this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149850/new/ https://reviews.llvm.org/D149850 ___ cfe-commits m

[PATCH] D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Sorry for misleading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149850/new/ https://reviews.llvm.org/D149850 ___ cfe-commits mailing

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. If it would be possible to get some poor reviewers precious time on this I would greatly appreciate it! Thank you very much ahead of time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/ https://reviews.llvm.or

[clang] 1a42f79 - [clang][dataflow] Don't analyze templated declarations.

Author: Martin Braenne Date: 2023-05-15T11:04:51Z New Revision: 1a42f795587b9d57291d009989aace6efd0a7a7f URL: https://github.com/llvm/llvm-project/commit/1a42f795587b9d57291d009989aace6efd0a7a7f DIFF: https://github.com/llvm/llvm-project/commit/1a42f795587b9d57291d009989aace6efd0a7a7f.diff LOG

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a42f795587b: [clang][dataflow] Don't analyze templated declarations. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/ https

[clang] b321738 - [clang][parser] Fix namespace dropping after malformed declarations

Author: Alejandro Álvarez Ayllón Date: 2023-05-15T07:39:58-04:00 New Revision: b321738f71259d138c9b2002944eb65f099ec2a6 URL: https://github.com/llvm/llvm-project/commit/b321738f71259d138c9b2002944eb65f099ec2a6 DIFF: https://github.com/llvm/llvm-project/commit/b321738f71259d138c9b2002944eb65f099

[PATCH] D150258: [clang][parser] Fix namespace dropping after malformed declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rGb321738f7125: [clang][parser] Fix namespace dropping after malformed declarations (authored by alejandro-alvarez-sonarsource, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

aaron.ballman accepted this revision. aaron.ballman added a comment. In D149997#4338897 , @mstorsjo wrote: > Updated to check for `defined(_WIN32) && !defined(__MINGW32__)`. It's a kinda > ugly way of checking for an MSVC-like environment specifically (w

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D149276#4341552 , @cor3ntin wrote: > @aaron.ballman this won;t get approve by core un > > In D149276#4302700

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. @krisb is out of office for some time, so she asked to retake and wrap up this patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. See https://reviews.llvm.org/D143984#4341780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

dzhidzhoev commandeered this revision. dzhidzhoev added a reviewer: krisb. dzhidzhoev added a comment. See https://reviews.llvm.org/D143984#4341780 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006

[clang-tools-extra] d0e8911 - [clangd] Fix fixAll not shown when there is only one unused-include and missing-include diagnostics.

Author: Haojian Wu Date: 2023-05-15T14:02:20+02:00 New Revision: d0e89116aff224ac2d8d3f88029ae44e12c9b6cc URL: https://github.com/llvm/llvm-project/commit/d0e89116aff224ac2d8d3f88029ae44e12c9b6cc DIFF: https://github.com/llvm/llvm-project/commit/d0e89116aff224ac2d8d3f88029ae44e12c9b6cc.diff LO

[PATCH] D149822: [clangd] Fix fixAll not shown when there is only one unused-include and missing-include diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0e89116aff2: [clangd] Fix fixAll not shown when there is only one unused-include and missing… (authored by hokein). Repository: rG LLVM Github Mo

[PATCH] D150450: Add C++26 compile flags.

aaron.ballman added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions We shouldn't call it `ISO C++ 2026` until it's published by I

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 522132. qiongsiwu1 added a comment. Thanks so much @hubert.reinterpretcast !! The comments are addressed. I will land the patch when the pre-commit CI finishes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev updated this revision to Diff 522136. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c cla

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 522138. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files: clang/test/CodeGenCXX/debug-info-namespace.cpp llvm/include

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

dzhidzhoev updated this revision to Diff 522140. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen/debug-info-codeview-unnamed.c clang/test

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis marked 3 inline comments as done. TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 ___ cfe-commits mailing li

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

aaron.ballman added a comment. In D149733#4321610 , @kadircet wrote: >> However, I'm not keen on us playing whack-a-mole with the kinds of checks >> from this review. For starters, that's going to have a long-tail that makes >> it hard to know if we've

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

Szelethus requested changes to this revision. Szelethus added inline comments. This revision now requires changes to proceed. Comment at: clang/docs/analyzer/checkers.rst:2457 If the user disables the checker then the argument violation warning is suppressed. However, the assum

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kadircet added a comment. i think something went wrong with the diff, you don't seem to update PreambleCallbacks to trigger indexing on a different thread at all (and also there are certain lifetime issues). is this the final version of the patch or did I bump into a WIP version unknowingly ?

[PATCH] D150563: clang-format: [JS] terminate import sorting on `export type X = Y`

jankuehle created this revision. jankuehle added projects: clang, clang-format. Herald added a project: All. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. jankuehle requested review of this revision. https://reviews.llvm.org/D1

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. Please wait a day before submitting. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:455-468 + auto Buf = MemoryBuffer::getFile(HostFilePath)

[PATCH] D150563: clang-format: [JS] terminate import sorting on `export type X = Y`

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150563/new/ https://reviews.llvm.org/D150563 _

[clang] 292a6c1 - Fix build error caused by https://reviews.llvm.org/D149718

Author: Manna, Soumi Date: 2023-05-15T06:03:47-07:00 New Revision: 292a6c1c2395f990bbde8d968825243e4fe9b954 URL: https://github.com/llvm/llvm-project/commit/292a6c1c2395f990bbde8d968825243e4fe9b954 DIFF: https://github.com/llvm/llvm-project/commit/292a6c1c2395f990bbde8d968825243e4fe9b954.diff

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. Thank you very much @kiranchandramohan! More than happy to wait a day incase anyone else wishes to do a final review. I'll add the Nits where possible when I commit the patch upstream and it should hopefully update the review with the alterations! Repository: rG L

[PATCH] D150566: [clang] Provide source range to 'invalid subexpr in const expr' diags

tbaeder created this revision. tbaeder added reviewers: cjdb, aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150566 Files

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet added a comment. > I think we probably should have a broader discussion before moving forward > here. It's not that this isn't incremental progress fixing an issue, but it's > more that this same justification works to add the workaround 200 more times > without ever addressing the und

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 522157. domada added a comment. Patch rebased because I applied remarks for parent revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D150354 Files: clang/include/clang/Driver/Options.td clang/lib/Driver

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kuganv added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:106-113 +CI.setSema(nullptr); +CI.setASTConsumer(nullptr); +if (CI.getASTReader()) { + CI.getASTReader()->setDeserializationListener(nullptr); + /* This just sets consumer to nul

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada added a comment. In D150354#4337148 , @awarzynski wrote: > All in all LGTM, but I'm not sure whether Flang should be defaulting to > OpenMP 5.0. AFAIK, that's not supported yet. If you wish I can set to OpenMP 4.5. But then we need to have two s

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

aaron.ballman added a comment. Thank you for working on this! Just a few minor things. Comment at: clang/docs/ReleaseNotes.rst:279-281 +- Clang now correctly diagnoses when the argument to alignas is an incomplete type. + (`#55175:

[clang] e1f34b7 - clang-format: [JS] terminate import sorting on `export type X = Y`

Author: Jan Kuhle Date: 2023-05-15T15:37:18+02:00 New Revision: e1f34b735b669c5978bfdead874ee59d33f99eb0 URL: https://github.com/llvm/llvm-project/commit/e1f34b735b669c5978bfdead874ee59d33f99eb0 DIFF: https://github.com/llvm/llvm-project/commit/e1f34b735b669c5978bfdead874ee59d33f99eb0.diff LOG

[PATCH] D150563: clang-format: [JS] terminate import sorting on `export type X = Y`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1f34b735b66: clang-format: [JS] terminate import sorting on `export type X = Y` (authored by jankuehle, committed by krasimir). Repository: rG LL

[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

gysit added a comment. Herald added subscribers: bviyer, Moerafaat. @omri123 are you interested in rebasing and landing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136746/new/ https://reviews.llvm.org/D136746 ___ cfe-commits mailing l

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4339561 , @awson wrote: > Now, this > > #include > #include > > auto drop1(const std::vector& s){ > return s | std::views::drop(1); > } > > when compiled against gcc's-13.1 libstdc++ spits: > > b

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet updated this revision to Diff 522165. hazohelet added a comment. Rebase and Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146358/new/ https://reviews.llvm.org/D146358 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticASTKinds.td clang/lib/AST/E

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked an inline comment as done. pmatos added a comment. @tlively @aaron.ballman pinging both to get final reviews on the LLVM and Clang parts respectively. It would be great to have this merged soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D150553: [SVE ACLE] Change the lowering of SVE integer mla_u/mls_u builtins

mgabka added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1665 def int_aarch64_sve_mla_lane : AdvSIMD_3VectorArgIndexed_Intrinsic; +def int_aarch64_sve_mla_u : AdvSIMD_Pred3VectorArg_Intrinsic; def int_aarch64_sve_mls: AdvSIMD_Pred3Vecto

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

yaxunl added a comment. Please make sure we can consume old IR using unmangled llvm.amdgcn.permlanex16 by fixing auto upgrade. Otherwise, it may cause regressions for device libs or existing apps. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D150394: [OpenMP 5.2] Deprecate MINUS (-) operator on reduction clauses

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10487-10488 "a reduction list item with incomplete type %0">; +def err_omp_reduction_minus_type : Error< + "a reduction list item with minus(-) operator is not supported">; +def warn_o

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11329 + /// directive. + void ActOnOpenMPImplicitDeclareTarget(Decl *D); + Do I understand correctly, that the variable itself is marked explicitly, but the initializer shall be marked

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D149733#4342095 , @kadircet wrote: >> I think we probably should have a broader discussion before moving forward >> here. It's not th

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added a comment. In D149718#4341384 , @uabelho wrote: > In D149718#4341052 , @uabelho wrote: > >> Compiling with clang 15.0.5 I get the following warning/error with this >> patch: >> >> ../../clang/includ

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Pre-commit CI x64 Debian is failing https://buildkite.com/llvm-project/premerge-checks/builds/152189 because the build machine's cmake version is too old. I am landing this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

uabelho added a comment. In D149718#4342320 , @Manna wrote: > In D149718#4341384 , @uabelho wrote: > >> In D149718#4341052 , @uabelho >> wrote: >> >>> Compiling with clan

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 522180. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Parser.h

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added a comment. It looks like several comments are left unaddressed, are you planning on making the suggested changes? Comment at: clang/lib/AST/DeclPrinter.cpp:52-58 +enum AttrPrintLoc { + SIDE_NONE = 0, + SIDE_LEFT = 1, + SIDE_MIDDLE = 2, +

[clang] ba9eaf5 - Update __cplusplus for C++23, add C++23 diag group alias.

Author: Erich Keane Date: 2023-05-15T07:48:52-07:00 New Revision: ba9eaf59a8a3bb0713956da3bfb3492669971a62 URL: https://github.com/llvm/llvm-project/commit/ba9eaf59a8a3bb0713956da3bfb3492669971a62 DIFF: https://github.com/llvm/llvm-project/commit/ba9eaf59a8a3bb0713956da3bfb3492669971a62.diff L

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:694 Result->MainIsIncludeGuarded = CapturedInfo.isMainFileIncludeGuarded(); -return Result; +CapturedCtx.emplace(CapturedInfo.takeLife()); +return std::make_pair(Result, CapturedCtx

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

balazske updated this revision to Diff 522192. balazske added a comment. Applied review suggestions, removed the list of functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149447/new/ https://reviews.llvm.org/D149447 Files: clang/docs/anal

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

amyk added a comment. Hi, I just wanted to give a heads up that it appears that this patch is causing failures on some of the PPC buildbots. In particular, the `const-str-array-decay.cl` appears to be failing. The failing build can be seen in: https://lab.llvm.org/buildbot/#/builders/36/builds/

[PATCH] D141714: Fix ast print of variables with attributes

erichkeane added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:270 + + // FIXME: Find a way to use the AttrList.inc. We use if-else statements + // to classify each of them. I think this is something we need to just do the right way, right

[PATCH] D137706: [clang][Interp] Implement IntegralToPointer casts

tbaeder abandoned this revision. tbaeder added a comment. I've already abandoned this locally, pretty sure I'll end up taking another approach. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137706/new/ https://reviews.llvm.org/D137706 ___ cf

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/docs/analyzer/checkers.rst:2490-2523 +**List of checked functions** + +``fgetc``, ``fread``, ``fwrite``, ``getc``, ``getchar``, ``getdelim``, +``getenv``, ``getline``, ``isalnum``, ``isal

[PATCH] D147621: [clang][Interp] Start handling mutable record members

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147621/new/ https://reviews.llvm.org/D147621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.llvm.org/D147875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150040: [clang][Interp] Call invalid destructors

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150040/new/ https://reviews.llvm.org/D150040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

barannikov88 added a comment. In D150520#4342429 , @amyk wrote: > Hi, I just wanted to give a heads up that it appears that this patch is > causing failures on some of the PPC buildbots. > In particular, the `const-str-array-decay.cl` appears to be faili

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

uabelho added a comment. Hello, ../../clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:43:27: error: 'build' is deprecated: Use the version that takes a const Decl & instead [-Werror,-Wdeprecated-declarations] ControlFlowContext::build(&FuncDecl, *FuncDecl.getBo

[PATCH] D150450: Add C++26 compile flags.

erichkeane marked 8 inline comments as done. erichkeane added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions aaron.ballman wrote

[PATCH] D150450: Add C++26 compile flags.

Mordante added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:206-210 + Working draft for ISO C++ 2026 + + | ``gnu++2c`` + + Working draft for ISO C++ 2026 with GNU extensions erichkeane wrote: > aaron.ballman wrote: > > We shouldn't call it

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 522199. erichkeane added a comment. Aarons comments, split 23 changes into a separate patch and rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst clan

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150111/new/ https://reviews.llvm.org/D150111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D150226#4340166 , @manojgupta wrote: > https://github.com/bminor/binutils-gdb/blob/master/include/diagnostics.h > > gdb only suppresses the warning. So this patch will likely break gdb. > > As per commit: > https://gith

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin updated this revision to Diff 522201. yronglin added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/

[PATCH] D150579: [*]: fix syntax errors in HTML files

VoltrexMaster created this revision. VoltrexMaster added reviewers: Amir, samsonov, STL_MSFT, jordan_rose, rsmith. Herald added a reviewer: bollu. Herald added subscribers: Enna1, wenlei, jvesely, arphaman. Herald added a project: All. VoltrexMaster requested review of this revision. Herald added p

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin marked 3 inline comments as done. yronglin added a comment. Thanks a lot for your review @aaron.ballman ! BTW, does the most good approach is that we just add a new `ParsedAttribute` with `TypeSourceInfo` but not an `UnaryExprOrTypeTraitExpr`? Comment at: clang/docs/

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder updated this revision to Diff 522204. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeEmitter.h clang/lib/AST/In

[PATCH] D89046: [AST] Build recovery expression by default for all language.

shafik added a comment. Herald added a project: All. Hello folks, it looks like this PR is linked to a crash bug: https://github.com/llvm/llvm-project/issues/62711 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89046/new/ https://reviews.llvm.org/D

[PATCH] D141714: Fix ast print of variables with attributes

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:270 + + // FIXME: Find a way to use the AttrList.inc. We use if-else statements + // to classify each of them. erichkeane wrote: > I think this is something we need to just d

[clang] 9715af4 - [AIX][clang] Storage Locations for Constant Pointers

Author: Qiongsi Wu Date: 2023-05-15T11:31:00-04:00 New Revision: 9715af434579022b5ef31781be40b722d7e63bee URL: https://github.com/llvm/llvm-project/commit/9715af434579022b5ef31781be40b722d7e63bee DIFF: https://github.com/llvm/llvm-project/commit/9715af434579022b5ef31781be40b722d7e63bee.diff LO

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9715af434579: [AIX][clang] Storage Locations for Constant Pointers (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

aaron.ballman added a comment. In D150528#4342535 , @yronglin wrote: > Thanks a lot for your review @aaron.ballman ! BTW, does the most good > approach is that we just add a new `ParsedAttribute` with `TypeSourceInfo` > but not an `UnaryExprOrTypeTraitE

[PATCH] D147321: [RFC][Flang][OMPIRBuilder] Add nounwind attribute to the LLVM IR

jdoerfert added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5063 + } +} + Style `F` Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:5063 + } +} + jdoerfert wrote: > Style `F` Why does this bel

[PATCH] D150450: Add C++26 compile flags.

erichkeane added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:456 + // FIXME: Use correct value for C++26. + Builder.defineMacro("__cplusplus", "202402L"); +else if (LangOpts.CPlusPlus23) erichkeane wrote: > aaron.ballman wro

[PATCH] D150450: Add C++26 compile flags.

erichkeane updated this revision to Diff 522214. erichkeane added a comment. change __cplusplus to match GCC's plan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 Files: clang/docs/CommandGuide/clang.rst clang/docs/ReleaseNotes.rst cla

[PATCH] D150450: Add C++26 compile flags.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you Erich! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. This patch is causing some buildbot failures. Specifically https://lab.llvm.org/buildbot/#/builders/139/builds/40652 https://lab.llvm.org/buildbot/#/builders/258/builds/810 I am looking into them. Please revert if this cannot wait. Thanks! Repository: rG LLVM Gith

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn updated this revision to Diff 522215. john.brawn edited the summary of this revision. john.brawn added a comment. I've gone with handling the _GNU_SOURCE problem in the clang-tidy tests by re-using the list of feature test macros in shouldWarnOnMacroDef, and not warning if there's a m

  1   2   3   >