[PATCH] D151537: [NFC] Update cpu_specific test to use a newer CPU

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151537/new/ https://reviews.llvm.org/D151537 _

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM - Missing release notes entry. - I'm not sure about change in StmtCXX.h, do we need it ? Coudn't we just use children() + getBody() - CHECK-MESSAGES-NOT get me a little bit confused.

[clang] 46deb40 - [CodeGen] Use llvm::LLVMContext::MD_nontemporal (NFC)

Author: Kazu Hirata Date: 2023-05-29T00:41:51-07:00 New Revision: 46deb4092d84c02463c5e8ebd664288eab6cdc56 URL: https://github.com/llvm/llvm-project/commit/46deb4092d84c02463c5e8ebd664288eab6cdc56 DIFF: https://github.com/llvm/llvm-project/commit/46deb4092d84c02463c5e8ebd664288eab6cdc56.diff L

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. In D151547#4375613 , @asb wrote: > Thanks for the patch. > > Is the __riscv_ntl_* interface finalised and agreed? I'm wary of repeating > the mistake we made with the V extension where we exposed intrinsics that > weren't ye

[clang] e20931b - [clang] Restrict Inline Builtin to non-static, non-odr linkage

Author: serge-sans-paille Date: 2023-05-29T10:02:18+02:00 New Revision: e20931b2ccd10de2fd25d9a6fbe9c166e7430f23 URL: https://github.com/llvm/llvm-project/commit/e20931b2ccd10de2fd25d9a6fbe9c166e7430f23 DIFF: https://github.com/llvm/llvm-project/commit/e20931b2ccd10de2fd25d9a6fbe9c166e7430f23.d

[PATCH] D148723: [clang] Restrict Inline Builtin to non-static, non-odr linkage

This revision was automatically updated to reflect the committed changes. Closed by commit rGe20931b2ccd1: [clang] Restrict Inline Builtin to non-static, non-odr linkage (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge updated this revision to Diff 526408. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151190/new/ https://reviews.llvm.org/D151190 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tool

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge updated this revision to Diff 526409. nridge added a comment. slight simplification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151190/new/ https://reviews.llvm.org/D151190 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added inline comments. Comment at: llvm/test/Transforms/InstCombine/fsh.ll:664 +; CHECK-NEXT:[[T1:%.*]] = and i32 [[A:%.*]], -65536 +; CHECK-NEXT:[[T2:%.*]] = call i32 @llvm.fshl.i32(i32 [[T1]], i32 [[T1]], i32 16) ; CHECK-NEXT:ret i32 [[T2]]

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Yea, it still looks okay. Let me know if you don't have commit access. In that case, also let me know what should be used for the commit author. Repository: rG LLVM Github Monorepo CHA

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

steakhal added a comment. Ah, I can see that pre-merge bots failed due to clang-format violations. Please make all the touched lines as clang-formatted prior to committing anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ https:/

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked 3 inline comments as done. pmatos added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2288 +argument is the index to which to store the value into, and the +third argument is a value of reference type to store in the table. +It returns nothing.

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci updated this revision to Diff 526430. denizevrenci added a comment. - Update release notes - Remove checks for no messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417 Files: clang-tools

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci added a comment. Addressed 1 and 3. As for the new methods in StmtCXX.h, I think they may be used elsewhere too where we need to make a distinction between the visible body of the coroutine and the desugared version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 526436. pmatos marked an inline comment as done. pmatos added a comment. Address the comments wrt the documentation. Added link to Wasm spec. @aaron.ballman What do you think? I added the reference to the top level of the WebAssembly section, rather than to t

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > qiongsiwu1 wrote: > > > tra wrote: > > > > qiongsiwu1 wrote: > > > > > Do we need an install targ

[PATCH] D151590: [Driver] Add ClangFlags::TargetSpecific to simplify err_drv_unsupported_opt_for_target processing

qiongsiwu1 added a comment. Thanks for the patch! Recently we added the options `mxcoff-roptr` and `mno-xcoff-roptr` https://reviews.llvm.org/D144190 that fall into this the scope of this patch (e.g. https://github.com/llvm/llvm-project/blob/0508ac32cfcc1a9fc5a81d16de8d418dc5a0666b/clang/lib/D

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci updated this revision to Diff 526438. denizevrenci added a comment. - Rebase on trunk - Remove unused helpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417 Files: clang-tools-extra/clang-

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

royjacobson created this revision. royjacobson added reviewers: chaitanyav, PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang-tools-extra. Herald

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

royjacobson updated this revision to Diff 526440. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151650/new/ https://reviews.llvm.org/D151650 Files: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp Index: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp

[PATCH] D151651: [StaticAnalyzer] Fix block pointer type nullability check

tripleCC created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, szepet, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. tripleCC requested review of this revision. Herald added a project: cl

[PATCH] D151651: [StaticAnalyzer] Fix block pointer type nullability check

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Looks good. That pesky ObjC :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151651/new/ https://reviews.llvm.org/D151651 _

[PATCH] D151651: [StaticAnalyzer] Fix block pointer type nullability check

tripleCC added a comment. In D151651#4379144 , @steakhal wrote: > Looks good. > That pesky ObjC :D I don't have commit access, could you help me to commit it? thanks --author "tripleCC " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

rsmith added inline comments. Comment at: clang/include/clang/Sema/TemplateDeduction.h:338 public: - TemplateSpecCandidateSet(SourceLocation Loc, bool ForTakingAddress = false) : Loc(Loc), ForTakingAddress(ForTakingAddress) {} Do we need to allow the loc

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

PiotrZSL added a comment. LGTM but update documentation for this check abseil::Status is listed there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151650/new/ https://reviews.llvm.org/D151650 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D150430: Implement BufferOverlap check for sprint/snprintf

ArnaudBienner updated this revision to Diff 526463. ArnaudBienner added a comment. - Code review comments: change back the string buffer check + run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150430/new/ https://reviews.llvm.org/D15

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

nikic added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:927-933 +if (I->getOperand(0) != I->getOperand(1)) { + APInt DemandedMaskLHS(DemandedMask.lshr(ShiftAmt)); + APInt DemandedMaskRHS(DemandedMask.shl(

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

royjacobson updated this revision to Diff 526468. royjacobson added a comment. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151650/new/ https://reviews.llvm.org/D151650 Files: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueC

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40af06ccc7bf: [clang-tidy] Update UnusedReturnValueCheck types (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 40af06c - [clang-tidy] Update UnusedReturnValueCheck types

Author: Roy Jacobson Date: 2023-05-29T23:02:32+03:00 New Revision: 40af06ccc7bf9989b8deb410ed78a4795c22aa73 URL: https://github.com/llvm/llvm-project/commit/40af06ccc7bf9989b8deb410ed78a4795c22aa73 DIFF: https://github.com/llvm/llvm-project/commit/40af06ccc7bf9989b8deb410ed78a4795c22aa73.diff

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

mstorsjo created this revision. mstorsjo added reviewers: Endill, hans, aaron.ballman. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. This uses the same logic as in c2b256a990590dc8b69930259650cfeb085add03

[PATCH] D151662: [clang] [test] Fix test failures due to -Wbuiltin-macro-redefined in MinGW mode

mstorsjo created this revision. mstorsjo added reviewers: john.brawn, aaron.ballman. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. These tests undefine __declspec or __stdcall, both which are builtin macros in MinGW mode. Therefore, build t

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

DiggerLin added inline comments. Comment at: clang/test/Driver/aix-integrated-as.c:9 +// CHECK-IAS32: "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0" "-emit-obj" +// CHECK-IAS32: "aix-integrated-as.o" + both -fno-integrated-as and -fintegrated-as output the same file n

[PATCH] D151650: [clang-tidy] Update UnusedReturnValueCheck types

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/unused-return-value.rst:53 By default the following function return types are checked: - `::std::error_code`, `::std::expected`, `::boost::system::error_code`, `::abseil::Status`

[clang-tools-extra] 5bbb66c - [clangd] Remove unused variable IsBroadcasting

Author: Kazu Hirata Date: 2023-05-29T14:17:03-07:00 New Revision: 5bbb66cae7d19836b0177f453fe6633a491f9590 URL: https://github.com/llvm/llvm-project/commit/5bbb66cae7d19836b0177f453fe6633a491f9590 DIFF: https://github.com/llvm/llvm-project/commit/5bbb66cae7d19836b0177f453fe6633a491f9590.diff L

[clang-tools-extra] 32fc78c - [cland] Remove unused declaration getCurrentPreamble

Author: Kazu Hirata Date: 2023-05-29T14:17:01-07:00 New Revision: 32fc78c26ff591f627d3a6d4f8e0ab7c2092f1e5 URL: https://github.com/llvm/llvm-project/commit/32fc78c26ff591f627d3a6d4f8e0ab7c2092f1e5 DIFF: https://github.com/llvm/llvm-project/commit/32fc78c26ff591f627d3a6d4f8e0ab7c2092f1e5.diff L

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci added a comment. Hi @PiotrZSL if you are happy with the changes, could you commit the diff for me as I don't have commit access to LLVM repo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417

[PATCH] D150645: [Driver] Support multi /guard: options

glandium added a comment. In D150645#4351266 , @aeubanks wrote: > this causes `./build/rel/bin/clang-cl /c /tmp/a.cc /Fo/tmp/a > /guard:cf,nochecks` to go from no warnings to > > clang-cl: warning: argument unused during compilation: '/guard:cf,nocheck

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

glandium added a comment. There seem to still be two problems with this change, with mingw: - with `-fms-extensions`: echo '#include "cpuid.h"' | ./clang/bin/clang++ --target=x86_64-w64-windows-gnu -xc++ - -fms-extensions In file included from :1: /tmp/clang/lib/clang/17/include/cpuid.h:3

[PATCH] D148827: -fsanitize=function: support C

glandium added a comment. This breaks sqlite: /builds/worker/checkouts/gecko/third_party/sqlite3/src/sqlite3.c:137791:5: runtime error: call to function sqlite3DeleteTable through pointer to incorrect function type 'void (*)(struct sqlite3 *, void *)' /builds/worker/checkouts/gecko/third_pa

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei added a comment. In D150645#4379536 , @glandium wrote: > In D150645#4351266 , @aeubanks > wrote: > >> this causes `./build/rel/bin/clang-cl /c /tmp/a.cc /Fo/tmp/a >> /guard:cf,nochecks` to go from no war

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417 ___ cfe-commits mailing list cfe-comm

[PATCH] D148827: -fsanitize=function: support C

MaskRay added a comment. In D148827#4379560 , @glandium wrote: > This breaks sqlite: > > /builds/worker/checkouts/gecko/third_party/sqlite3/src/sqlite3.c:137791:5: > runtime error: call to function sqlite3DeleteTable through pointer to > incorrect fun

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added subscribers: wlei, wenlei, jdoerfert, dmgreen. Herald added a project: All. philnik requested review of this revision. Herald added subscribers: lldb-commits, cfe-commits, jplehr, sstefan1, MaskRay. Hera

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:119 if (CollectInactiveRegions) { - ServerCallbacks->onInactiveRegionsReady( - Path, std::move(AST.getMacros().SkippedRanges)); + std::vector SkippedRanges(

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/test/ParserHLSL/group_shared.hlsl:14 -// expected-error@+1 {{expected expression}} float groupshared [[]] i = 12; Should this also get an extension warning/sho

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs updated this revision to Diff 526519. codemzs retitled this revision from "[Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and adapt __bf16 to be arithmetic type" to "[Clang][C++23] Implement core language changes from P1467R9

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

Endill accepted this revision. Endill added a comment. This revision is now accepted and ready to land. Thank you! I've asked Aaron what is the best way to check for MSVC-like triple before relanding this test. So today we both learned. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] bf916ae - [clang] Solidate the implicit-module-header-maps.cpp lit test.

Author: Haojian Wu Date: 2023-05-30T08:41:36+02:00 New Revision: bf916aeebd8c96c0618a1ccbb01a1517710f8766 URL: https://github.com/llvm/llvm-project/commit/bf916aeebd8c96c0618a1ccbb01a1517710f8766 DIFF: https://github.com/llvm/llvm-project/commit/bf916aeebd8c96c0618a1ccbb01a1517710f8766.diff LO

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

codemzs updated this revision to Diff 526524. codemzs added a comment. Remove unused header file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/cl

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs abandoned this revision. codemzs added a comment. Closing this as it has been resolved by D150913 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150291/new/ https://reviews.llvm.org/D150291 ___ cfe-

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

mstorsjo added a comment. In D150646#4379543 , @glandium wrote: > There seem to still be two problems with this change, with mingw: > > - with `-fms-extensions`: > > echo '#include "cpuid.h"' | ./clang/bin/clang++ > --target=x86_64-w64-windows-gnu -xc+

[PATCH] D151661: [clang] [test] Narrow down an MSVC specific behaviour to only not covever MinGW

mstorsjo added a comment. In D151661#4379958 , @Endill wrote: > Thank you! > I've asked Aaron what is the best way to check for MSVC-like triple before > relanding this test. So today we both learned. Generally, the canonical way to check for it is `#if