[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

barannikov88 added a comment. Is SmallVector.h still required in Error.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 ___ cfe-commits mailing list cfe-commi

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

rogfer01 updated this revision to Diff 532546. rogfer01 added a comment. ChangeLog: - Update clang tests that now, on RISC-V only, observe a larger precompiled module file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 Files: clang/includ

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The code for

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

nridge added a comment. As this patch involves copying a bit of code from CXXRecordDecl::lookupDepenentName() to HeuristicResolver, I wanted to mention a couple of alternatives I considered: 1. Copy things in the other direction, i.e. implement some of the necessary parts of resolveTypeToRecor

[clang-tools-extra] 87a3253 - [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

Author: Felix Date: 2023-06-19T07:22:20Z New Revision: 87a3253a394ddf3a799b452df5d290fea2473fe2 URL: https://github.com/llvm/llvm-project/commit/87a3253a394ddf3a799b452df5d290fea2473fe2 DIFF: https://github.com/llvm/llvm-project/commit/87a3253a394ddf3a799b452df5d290fea2473fe2.diff LOG: [clang-

[PATCH] D152764: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support regular expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG87a3253a394d: [clang-tidy] Reserved-identifier: Improved AllowedIdentifiers option to support… (authored by felix642, committed by PiotrZSL). Changed prior to commit: https://reviews.llvm.org/D152764?v

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM with comments. Comment at: clang/lib/Sema/SemaModule.cpp:824-827 + bool AllUnnamed = true; + for (auto *D : DC->decls()) +AllUnnamed &= checkExportedDecl(S,

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. > if we do not adjust the typo fixes, we will regress diagnostics. What the kind of diagnostics will be regressed? I mean, it looks weird to me that we suggest typo fixes from hidden names. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D152548: [Clang][Interp] Diagnose uninitialized ctor of global record arrays

hazohelet updated this revision to Diff 532554. hazohelet marked an inline comment as done. hazohelet added a comment. Address comment from @tbaeder - NFC stylistic change in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152548/new/ https://reviews.llvm.org/D152548 Files: clang

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Fixes

[PATCH] D152093: [clang][Analysis] Handle && and || against variable and its negation as tautology

hazohelet updated this revision to Diff 532557. hazohelet marked an inline comment as done. hazohelet added a comment. Address review comment - NFC stylistic change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152093/new/ https://reviews.llvm.org/D152093 Files: clang/docs/ReleaseNo

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains marked 2 inline comments as done. iains added a comment. In D145965#4431846 , @ChuanqiXu wrote: >> if we do not adjust the typo fixes, we will regress diagnostics. > > What the kind of diagnostics will be regressed? I mean, it looks weird to me > t

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:286-287 + SVal V, + std::function); I'd highly suggest making this a template taking the functor that way. Given that we m

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet updated this revision to Diff 532558. courbet marked an inline comment as done. courbet added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153131/new/ https://reviews.llvm.org/D153131 Files: clang/incl

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet added a comment. Thanks. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1046 def ThreadSafetyPrecise: DiagGroup<"thread-safety-precise">; def ThreadSafetyReference : DiagGroup<"thread-safety-reference">; +def ThreadSafetyReturn : DiagGroup<"thread-

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet updated this revision to Diff 532559. courbet added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153131/new/ https://reviews.llvm.org/D153131 Files: clang/include/clang/Analysis/Analyses/ThreadSafety.h clang/include/

[PATCH] D153175: [Frontend] Don't output skipped includes from predefines

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. > -H is supposed to skip outputting headers from -include command line > arguments, but -fshow-skipped-includes was outputting any skipped > includes encountered via -include. I was thrown off by t

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. In D145965#4431888 , @iains wrote: > In D145965#4431846 , @ChuanqiXu > wrote: > >>> if we do not adjust the typo fixes, we will regress diagnostics. >> >> What the kind of diagnostics w

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains marked 3 inline comments as done. iains added a comment. I will look at the rest of the comments once back in the office. In D145965#4431929 , @ChuanqiXu wrote: > In D145965#4431888 , @iains wrote: > >> In

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added a comment. Pign CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 762cb1d - [clang][dataflow] Create `Value`s for integer literals.

Author: Martin Braenne Date: 2023-06-19T08:37:41Z New Revision: 762cb1d377362daff234ac5172c2c1db4918f6d3 URL: https://github.com/llvm/llvm-project/commit/762cb1d377362daff234ac5172c2c1db4918f6d3 DIFF: https://github.com/llvm/llvm-project/commit/762cb1d377362daff234ac5172c2c1db4918f6d3.diff LOG

[PATCH] D152813: [clang][dataflow] Create `Value`s for integer literals.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG762cb1d37736: [clang][dataflow] Create `Value`s for integer literals. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

h-vetinari added a comment. Mark P2615 as implemented in https://github.com/llvm/llvm-project/blame/main/clang/www/cxx_status.html? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152946/new/ https://reviews.llvm.org

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added a comment. > It is a case that we have supported; the user puts in a use of a decl but > forgets to import the module exporting it (I agree it is not _exactly_ a > "typo" in terms of names, but the diagnostics counts it in the same way) I got your point. But I prefer to implemen

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme updated this revision to Diff 532568. mboehme added a comment. Minor style changes in response to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153006/new/ https://reviews.llvm.org/D153006 Files: clang/include/clang/Anal

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme marked 2 inline comments as done. mboehme added a comment. In D153006#4424980 , @xazax.hun wrote: > I am not opposed to this solution, but I do anticipate some performance > problems in the future. I wonder if copy-on-write, or some persistent da

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains marked an inline comment as done. iains added a comment. In D145965#4431997 , @ChuanqiXu wrote: >> It is a case that we have supported; the user puts in a use of a decl but >> forgets to import the module exporting it (I agree it is not _exactly_ a

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

zixuan-wu added a comment. Hi, Comment at: clang/test/CodeGenCXX/macro-prefix-map-lambda.cpp:11 + auto *s = lambdatest([](){}); +// CHECK: @"__PRETTY_FUNCTION__._Z10lambdatestIZ4mainE3$_0EDaOT_" = private unnamed_addr constant [{{[0-9]+}} x i8] c"auto lambdatest(f &&) [f = (l

[PATCH] D153152: Adds tweak to add declarations for pure virtuals

robot updated this revision to Diff 532575. robot added a comment. Remove left-over test file of other ptch from CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153152/new/ https://reviews.llvm.org/D153152 Files: clang-tools-extra/c

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

Hahnfeld abandoned this revision. Hahnfeld added a comment. Ok, I understand that fixing `ODRHash` is the wrong approach for our needs - we'll likely need to implement a custom hashing of template arguments to work as a lookup for lazy loading. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D153003: [ODRHash] Fix ODR hashing of template names

ChuanqiXu added a comment. Yeah, but I feel the most important problem for the patch is that the reproducer is not valid according to the wording. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153003/new/ https://reviews.llvm.org/D153003

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

hokein added inline comments. Comment at: clang/lib/Index/IndexDecl.cpp:708 } else if (const auto *NTTP = dyn_cast(TP)) { +IndexCtx.indexTypeSourceInfo(NTTP->getTypeSourceInfo(), Parent); if (NTTP->hasDefaultArgument()) since this is a cha

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

hokein added a comment. In D153248#4431780 , @nridge wrote: > As this patch involves copying a bit of code from > CXXRecordDecl::lookupDepenentName() to HeuristicResolver, I wanted to mention > a couple of alternatives I considered: > > 1. Copy things i

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

Destroyerrrocket added inline comments. Comment at: clang-tools-extra/clangd/ModulesManager.cpp:413-414 + else +WaitingCallables[Filename.str()].push_back( +{std::move(ReadyCallback), std::move(ReadyCallback)}); +} ChuanqiXu wrote: > Destroyerrrocket

[PATCH] D151445: [Flang] Add main-file-name flag to flang -fc1

domada updated this revision to Diff 532588. domada edited the summary of this revision. domada added a comment. Patch rebased. Detailed discussion about the need of introduction of the new flag can be found on LLVM discourse

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm updated this revision to Diff 532590. arsenm marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153233/new/ https://reviews.llvm.org/D153233 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Builtins.d

[PATCH] D153233: clang: Add __builtin_elementwise_rint and nearbyint

arsenm added inline comments. Comment at: clang/test/CodeGen/strictfp-elementwise-bulitins.cpp:13-14 +// CHECK-NEXT:[[ADD:%.*]] = tail call <2 x float> @llvm.experimental.constrained.fadd.v2f32(<2 x float> [[TMP0]], <2 x float> [[TMP1]], metadata !"round.dynamic", metadata

[PATCH] D153259: [clangd] Store offsets in MacroOccurrence

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Remove the existing `Rng` field.

[PATCH] D153236: [NFC] Fix potential dereferencing of nullptr.

Fznamznon added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:887 + else { +assert(DeepestParsedCaseStmt && "DeepestParsedCaseStmt cannot be null"); Actions.ActOnCaseStmtBody(DeepestParsedCaseStmt, Case.get()); The assert that

[PATCH] D147034: [clangd] Replace the hacky include-cleaner macro-reference implementation.

hokein updated this revision to Diff 532598. hokein marked 3 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147034/new/ https://reviews.llvm.org/D147034 Files: clang-tools-extra/cl

[PATCH] D147034: [clangd] Replace the hacky include-cleaner macro-reference implementation.

hokein added a comment. thanks for the comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:145 +for (const auto &Ref : MAndRefs.second) { + auto L = sourceLocationInMainFile(SM, Ref.Rng.start); + if (!L) { kadircet wrote: > it's unfo

[PATCH] D85471: Make clang HIP headers compatible with C++98

arsenm added a comment. Herald added a project: All. I don't understand why this is necessary. What does cmake have to do with it? Is HIP just not defaulting to the correct default C++ standard? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85471/n

[PATCH] D85471: Make clang HIP headers compatible with C++98

arsenm added a comment. Can you either 1. Add test coverage 2. Delete this entirely Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85471/new/ https://reviews.llvm.org/D85471 ___ cfe-commits mailing list

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

mboehme updated this revision to Diff 532604. mboehme marked an inline comment as done. mboehme added a comment. Use `cast_or_null` instead of `cast` in `VisitCXXOperatorCallExpr`. Added a test that crashes without this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D138397: HIP: Directly call ldexp builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138397/new/ https://reviews.llvm.org/D138397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa032dc139dda: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ h

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, erichkeane. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. On mismatch of arity of functions like void func( int aa, int bb) {} void callsite() {

[clang] 85232b0 - HIP: Directly call isfinite builtins

Author: Matt Arsenault Date: 2023-06-19T08:48:48-04:00 New Revision: 85232b0ecbf817bc1d70ae602cf44cf6ea03c0e6 URL: https://github.com/llvm/llvm-project/commit/85232b0ecbf817bc1d70ae602cf44cf6ea03c0e6 DIFF: https://github.com/llvm/llvm-project/commit/85232b0ecbf817bc1d70ae602cf44cf6ea03c0e6.diff

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM. The diff looks weird for some reason, but the downloadable `.diff` file looks fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 __

[clang] f407a73 - clang/HIP: Remove __llvm_amdgcn_* wrapper hacks

Author: Matt Arsenault Date: 2023-06-19T08:55:10-04:00 New Revision: f407a7399575a6821940973c54754d42e72dd9ce URL: https://github.com/llvm/llvm-project/commit/f407a7399575a6821940973c54754d42e72dd9ce DIFF: https://github.com/llvm/llvm-project/commit/f407a7399575a6821940973c54754d42e72dd9ce.diff

[PATCH] D138504: clang/HIP: Remove __llvm_amdgcn_* wrapper hacks

arsenm closed this revision. arsenm added a comment. f407a7399575a6821940973c54754d42e72dd9ce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138504/new/ https://reviews.llvm.org/D138504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D153271: [include-cleaner] Bailout on invalid code for the command-line tool

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. The binary tool only works on working source code, if the source code is not compilable, don't perform any analysis and

[PATCH] D144802: clang: Add __builtin_elementwise_round

arsenm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:647 + T __builtin_elementwise_round(T x) round x to the nearest integer value in floating point format, floating point types + rounding halfway cases to

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

uabelho added inline comments. Comment at: clang/tools/libclang/CXFile.h:18 +inline CXFile makeCXFile(OptionalFileEntryRef FE) { + return CXFile(FE ? &FE->getMapEntry() : nullptr); +} Gcc warns here: ``` ../../clang/tools/libclang/CXFile.h:18:50: warning: cast f

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

tuliom added inline comments. Comment at: clang/test/CodeGenCXX/macro-prefix-map-lambda.cpp:11 + auto *s = lambdatest([](){}); +// CHECK: @"__PRETTY_FUNCTION__._Z10lambdatestIZ4mainE3$_0EDaOT_" = private unnamed_addr constant [{{[0-9]+}} x i8] c"auto lambdatest(f &&) [f = (lamb

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D153273: CPP-4465 Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

tomasz-kaminski-sonarsource created this revision. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch reworks generation for the `CFGScopeBegin`,

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

jhuber6 added a subscriber: ronlieb. jhuber6 added a comment. ping @ronlieb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https://reviews.llvm.org/D152391 ___ cfe-commits mailing list cfe-com

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 532642. dzhidzhoev added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeGen/debug-info-codeview-unnamed.c clang/test

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

zahiraam updated this revision to Diff 532643. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D153128: [AArch64][RCPC3] Add Neon intrinsics for LDAP1 and STL2

tmatheson accepted this revision. tmatheson added a comment. This revision is now accepted and ready to land. LGTM. ACLE PR here: https://github.com/ARM-software/acle/pull/265 Comment at: clang/lib/CodeGen/CGBuiltin.cpp:6769 + // and vstl1(q)_lane, but codegen is equivalent fo

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new `InvalidCast` op for this purpose and emi

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 532649. hnrklssn added a comment. Rebase after reformatting with Black, update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 Files: clang/test/uti

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. It is possible to add note tags to show decisions at standard functions. For example at `fileno` show if it has failed or not failed. The most simple way is to add it to all places, this means a note will show up on any bug path at all standard function usages. This is

[clang] fa45f81 - [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

Author: Roger Ferrer Ibanez Date: 2023-06-19T14:37:46Z New Revision: fa45f81ff7ea9fc2a2a40fea8dd7626ecc3a8dbb URL: https://github.com/llvm/llvm-project/commit/fa45f81ff7ea9fc2a2a40fea8dd7626ecc3a8dbb DIFF: https://github.com/llvm/llvm-project/commit/fa45f81ff7ea9fc2a2a40fea8dd7626ecc3a8dbb.diff

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa45f81ff7ea: [clang][Serialization][RISCV] Increase the number of reserved predefined type… (authored by rogfer01). Repository: rG LLVM Github Mo

[clang] 66511b4 - [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

Author: Vladislav Dzhidzhoev Date: 2023-06-19T16:42:43+02:00 New Revision: 66511b401042f28c74d2ded3aac76d19a53bd7c4 URL: https://github.com/llvm/llvm-project/commit/66511b401042f28c74d2ded3aac76d19a53bd7c4 DIFF: https://github.com/llvm/llvm-project/commit/66511b401042f28c74d2ded3aac76d19a53bd7c

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66511b401042: [DebugMetadata][DwarfDebug] Support function-local types in lexical block… (authored by dzhidzhoev). Repository: rG LLVM Github Mono

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4431456 , @jdoerfert wrote: > could you put a little more information in the commit message please. "It > won't do X when we do Y", could mean a lot of things. We don't do Y anymore, > or we do X' now, with various c

[PATCH] D152548: [Clang][Interp] Diagnose uninitialized ctor of global record arrays

tbaeder accepted this revision. tbaeder added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152548/new/ https://reviews.llvm.org/D152548 ___ cfe-commits mailing list cfe-commits

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

tbaeder added a comment. LGTM but let's wait for a second opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153267/new/ https://reviews.llvm.org/D153267 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

DavidTruby created this revision. DavidTruby added reviewers: tblah, vzakhari, awarzynski. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. DavidTruby requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, Mas

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:110 FeatureBitset Features; + char Mangling; + bool OnlyForCPUDispatchSpecific; Do we have a documented list of the mangling values anywhere? The values below look too much

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently we emit `DW_AT_deleted` for `deleted` speci

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Michael137 updated this revision to Diff 532664. Michael137 added a comment. - fix test comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153282/new/ https://reviews.llvm.org/D153282 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/Code

[PATCH] D153281: [flang] add -flang-experimental-polymorphism flag to flang-new

tblah accepted this revision. tblah added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153281/new/ https://reviews.llvm.org/D153281

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': hnrklssn wrote: > nikic wrote: > > We should also not print the `all` argument for `--check-g

[PATCH] D144802: clang: Add __builtin_elementwise_round

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144802/new/ https://reviews.llvm.org/D144802 ___ cfe-commits mailing list cfe-co

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

michaelplatings created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously if no matching multilib was found then the user

[clang] 2a488b4 - clang: Add __builtin_elementwise_round

Author: Matt Arsenault Date: 2023-06-19T11:32:56-04:00 New Revision: 2a488b4443a9c0aa0f368aed901676508ced202f URL: https://github.com/llvm/llvm-project/commit/2a488b4443a9c0aa0f368aed901676508ced202f DIFF: https://github.com/llvm/llvm-project/commit/2a488b4443a9c0aa0f368aed901676508ced202f.diff

[PATCH] D144802: clang: Add __builtin_elementwise_round

arsenm closed this revision. arsenm added a comment. 2a488b4443a9c0aa0f368aed901676508ced202f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144802/new/ https://reviews.llvm.org/D144802 __

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > hnrklssn wrote: > > nikic wrote: > > > We should also not print the `all` argu

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij updated this revision to Diff 532684. stuij added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149444/new/ https://reviews.llvm.org/D149444 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/test/Dr

[PATCH] D149443: [ARM] add Thumb-1 8-bit movs/adds relocations to LLVM

stuij updated this revision to Diff 532685. stuij marked 3 inline comments as done. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149443/new/ https://reviews.llvm.org/D149443 Files: clang/lib/Driv

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > nikic wrote: > > hnrklssn wrote: > > > nikic wrote: > > > > We should also not

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

abel-bernabeu updated this revision to Diff 532686. abel-bernabeu added a comment. Rebased on top of the latest changes in RISCVAsmParser.cpp Moved the testing to llc-mc test cases under lvm/test/MC/RISCV/ Covered with tests for every single case where the parser consumes a token and a potential

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij marked an inline comment as done. stuij added a comment. Comment at: clang/test/Driver/arm-execute-only.c:1 -// RUN: not %clang -c -target thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: %clang -c -### --target=thumbv6m-eabi -mexecute-only %s 2>&1 | \ +// RUN: FileCh

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Since a boolean flag is effectively free in DWARF as it can be stored in the abbreviations, this looks like a good change to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej created this revision. Herald added subscribers: pmatos, asb, delcypher, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. dicej requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay, aheejin. Herald added projects:

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Immediate invocations do not need to run cleanups themselves and the destructors need to run after each full-expression

[PATCH] D138278: TableGen: honor LLVM_LINK_LLVM_DYLIB by default

nhaehnle added a comment. Herald added a subscriber: wangpc. I haven't looked at this in a while, sorry. I do plan to cycle back to it eventually, but right now my work scheduling is more stack-based than FIFO and this is fairly low down... Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152435: [analyzer][CStringChecker] Adjust the invalidation operation on the super region of the destination buffer during string copy

OikawaKirie added a comment. BTW, what does the `Done` checkbox mean in the code comments? Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:286-287 + SVal V, + std::function); steakhal wrote: > I'd hig

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10399 +DeviceID = CGF.Builder.getInt64(OMP_DEVICEID_UNDEF); + } jdoerfert wrote: > Move this behind the if generation and guard the emit scalar with a > conditional, all is o

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

sbc100 added a comment. Herald added a subscriber: ormris. Nice! lgtm with a couple of nits Comment at: clang/docs/ReleaseNotes.rst:705 +- The `wasm32-wasi` target now supports `Emscripten-style shared libraries +

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yronglin Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153296 Files: clang/lib/AST

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added a comment. Oops, compiler explorer website seems crashed, Once it's recovery, I'll append a link. :2:13: error: use of undeclared identifier 'f' 2 | switch (f) { | ^ clang++: /root/llvm-project/llvm/lib/Support/APInt.cpp:282: int llvm::APInt::com

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp, isuckatcs, JonasToth, baloghadamsoftware. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subs

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. Thanks for the review. I'll post an update shortly. Comment at: clang/docs/ReleaseNotes.rst:705 +- The `wasm32-wasi` target now supports `Emscripten-style shared libraries + `

[clang] aeb99dc - Revert "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)"

Author: Vladislav Dzhidzhoev Date: 2023-06-19T19:16:13+02:00 New Revision: aeb99dc48a58f872465e818d0eda7d9c3f221e06 URL: https://github.com/llvm/llvm-project/commit/aeb99dc48a58f872465e818d0eda7d9c3f221e06 DIFF: https://github.com/llvm/llvm-project/commit/aeb99dc48a58f872465e818d0eda7d9c3f221e0

  1   2   >