[PATCH] D153208: [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-20 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGbca11bafba97: [clang-format] Add InsertNewlineAtEOF to .clang-format files (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153208/new/

[clang] bca11ba - [clang-format] Add InsertNewlineAtEOF to .clang-format files

2023-06-20 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-06-20T08:30:09-07:00 New Revision: bca11bafba9788dd80135b76a187c5f00e64f735 URL: https://github.com/llvm/llvm-project/commit/bca11bafba9788dd80135b76a187c5f00e64f735 DIFF: https://github.com/llvm/llvm-project/commit/bca11bafba9788dd80135b76a187c5f00e64f735.diff LOG:

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

2023-06-20 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, cjdb, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. Now that clang supports printing of multiple lines of code snippet in diagnostics, source rang

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

2023-06-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:648 + {"bool operator==(const Foo &) const noexcept = default", +Re

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

2023-06-20 Thread Jens Massberg via Phabricator via cfe-commits
massberg marked 2 inline comments as done. massberg added a comment. Thanks for the comments, I have added an additional test to FindTargetTest. See also my other comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:4051 +TEST(Hover, RewrittenBinaryOperato

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

2023-06-20 Thread Jens Massberg via Phabricator via cfe-commits
massberg updated this revision to Diff 532921. massberg added a comment. Add test to FindTargetTests and extend test in HoverTests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-ext

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

2023-06-20 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.readlane.ll:5 +declare i16 @llvm.amdgcn.readlane.i16(i16, i32) #0 +declare half @llvm.amdgcn.readlane.f16(half, i32) #0 +declare float @llvm.amdgcn.readlane.f32(float, i32) #0 arsenm w

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

2023-06-20 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:209 +bool is16Bit = +(EltType->isIntegerTy() && EltType->getIntegerBitWidth() == 16) || +(EltType->isHalfTy()); isIntegerTy(16). Also, just check the

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

2023-06-20 Thread Nuno Lopes via Phabricator via cfe-commits
nlopes added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULateCodeGenPrepare.cpp:213 + +Value *Result = UndefValue::get(Ty); +for (int i = 0; i < EC; i += 1 + is16Bit) { Please use poison wherever possible. In this case it seems it's just a

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

2023-06-20 Thread David Goldman via Phabricator via cfe-commits
dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:131 return HighlightingKind::Interface; - if (isa(D)) + if (isa(D)) return HighlightingKind::Namespace; kadircet wrote: > let's do this in a separate change,

[PATCH] D153248: [clangd] Use resolveTypeToRecordDecl() to resolve the type of a base specifier during heuristic resolution

2023-06-20 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. OK, fair enough. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153248/new/ https://reviews.llvm.org/D153248 ___

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

2023-06-20 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153340 Files: clang-tools-extra/include-cleaner/tes

[PATCH] D153339: [clang] Support vectors in __builtin_isfpclass

2023-06-20 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff created this revision. sepavloff added reviewers: rjmccall, aaron.ballman, arsenm, kpn, qiucf, efriedma. Herald added a project: All. sepavloff requested review of this revision. Herald added a subscriber: wdng. Herald added a project: clang. Builtin function `__builtin_isfpclass` now c

[PATCH] D153338: [clang-format] vim integration: Mention python3 variant of bindings

2023-06-20 Thread Jannik Silvanus via Phabricator via cfe-commits
jsilvanus created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. jsilvanus requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automa

[PATCH] D152442: [LinkerWrapper] Support linking vendor bitcode late

2023-06-20 Thread Joseph Huber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGefacdfc235e3: [LinkerWrapper] Support linking vendor bitcode late (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152442/new/ https://r

[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

2023-06-20 Thread Joseph Huber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8784b6a8540f: [Clang] Allow bitcode linking when the input is LLVM-IR (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152391/new/ https

[clang] efacdfc - [LinkerWrapper] Support linking vendor bitcode late

2023-06-20 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-20T08:02:59-05:00 New Revision: efacdfc235e327341d2b8a733d9963fb526cf17b URL: https://github.com/llvm/llvm-project/commit/efacdfc235e327341d2b8a733d9963fb526cf17b DIFF: https://github.com/llvm/llvm-project/commit/efacdfc235e327341d2b8a733d9963fb526cf17b.diff

[clang] 8784b6a - [Clang] Allow bitcode linking when the input is LLVM-IR

2023-06-20 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2023-06-20T08:02:58-05:00 New Revision: 8784b6a8540f4a333690e7233587859f1d82f620 URL: https://github.com/llvm/llvm-project/commit/8784b6a8540f4a333690e7233587859f1d82f620 DIFF: https://github.com/llvm/llvm-project/commit/8784b6a8540f4a333690e7233587859f1d82f620.diff

[PATCH] D153330: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

2023-06-20 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG149f309f50cd: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D153330?vs=532863&id=532870#toc Repository: rG LLV

[clang-tools-extra] 149f309 - [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

2023-06-20 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-06-20T14:26:55+02:00 New Revision: 149f309f50cd981ed320c948f772aa571eaa9afa URL: https://github.com/llvm/llvm-project/commit/149f309f50cd981ed320c948f772aa571eaa9afa DIFF: https://github.com/llvm/llvm-project/commit/149f309f50cd981ed320c948f772aa571eaa9afa.diff LO

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

2023-06-20 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. I think this may not hard break mesa. I believe mesa bypasses the intrinsic creation API, and just declares the string name of the intrinsic. The type name mangling suffix is technically irrelevant, and as long as you use a consistent type with a consistent suffix things

[PATCH] D153330: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

2023-06-20 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:219 +// as they don't contribute to the main-file #include. +if (isa(VD)) + return true

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

2023-06-20 Thread Henrik G Olsson via Phabricator via cfe-commits
hnrklssn added a comment. In D148216#4434171 , @nikic wrote: > There are some test failures. > > I believe there is one bug with the handling of unnamed globals. Previously > we produced this: > > ; NOTE: Assertions have been autogenerated by utils/upd

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

2023-06-20 Thread Henrik G Olsson via Phabricator via cfe-commits
hnrklssn updated this revision to Diff 532868. hnrklssn marked 4 inline comments as done. hnrklssn added a comment. Added back regex matchers for anonymous global values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

2023-06-20 Thread Jens Massberg via Phabricator via cfe-commits
massberg updated this revision to Diff 532867. massberg added a comment. Fix test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331/new/ https://reviews.llvm.org/D153331 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

2023-06-20 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks, this looks pretty good! > I'm not sure if I the hover test which is added in this patch is the right > one, > but at least is passed with this patch and fails without it :) This is nice to have, but you add a unittest to FindTargetTest too? That's the most di

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

2023-06-20 Thread Jens Massberg via Phabricator via cfe-commits
massberg created this revision. massberg added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In C++20 some

[PATCH] D153330: [include-cleaner] Ignore the ParmVarDecl itself in WalkAST.cpp

2023-06-20 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: kristof.beyls. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This will fix a false positive where a ParamVarDecl happend to be the same na

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

2023-06-20 Thread Vladislav Dzhidzhoev via Phabricator via cfe-commits
dzhidzhoev added a comment. Thank you for reports! I've reverted it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 ___ cfe-commits mailing list cfe-commits@li

[clang] 6bea833 - Revert "Reland "[DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)" (2)"

2023-06-20 Thread Vladislav Dzhidzhoev via cfe-commits
Author: Vladislav Dzhidzhoev Date: 2023-06-20T13:08:47+02:00 New Revision: 6bea8331f9e09ba94a225c65becd4224a1a473af URL: https://github.com/llvm/llvm-project/commit/6bea8331f9e09ba94a225c65becd4224a1a473af DIFF: https://github.com/llvm/llvm-project/commit/6bea8331f9e09ba94a225c65becd4224a1a473a

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

2023-06-20 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. We're seeing assertion failures in Chromium too. Reproducer for x86_64 Linux here: https://bugs.chromium.org/p/chromium/issues/detail?id=1456288#c2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llv

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

2023-06-20 Thread Manuel Brito via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG36d50348a8b1: [clang][NFC] Drop alignment in builtin-nondeterministic-value test (authored by ManuelJBrito). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[clang] 36d5034 - [clang][NFC] Drop alignment in builtin-nondeterministic-value test

2023-06-20 Thread via cfe-commits
Author: ManuelJBrito Date: 2023-06-20T11:38:37+01:00 New Revision: 36d50348a8b12db01d786c5fa3d0ed7a911e1f68 URL: https://github.com/llvm/llvm-project/commit/36d50348a8b12db01d786c5fa3d0ed7a911e1f68 DIFF: https://github.com/llvm/llvm-project/commit/36d50348a8b12db01d786c5fa3d0ed7a911e1f68.diff

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

2023-06-20 Thread Yurong via Phabricator via cfe-commits
yronglin updated this revision to Diff 532853. yronglin added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153296/new/ https://reviews.llvm.org/D153296 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/switch.cpp

[PATCH] D151938: [clang][index] NFCI: Make `CXFile` a `FileEntryRef`

2023-06-20 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added inline comments. Comment at: clang/tools/libclang/CXFile.h:18 +inline CXFile makeCXFile(OptionalFileEntryRef FE) { + return CXFile(FE ? &FE->getMapEntry() : nullptr); +} uabelho wrote: > Gcc warns here: > ``` > ../../clang/tools/libclang/CXFil

[clang] 1c64c41 - [clang][index] Fix cast warning

2023-06-20 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-06-20T12:22:18+02:00 New Revision: 1c64c414ed6a7ba2973f881a380d322adb5767a2 URL: https://github.com/llvm/llvm-project/commit/1c64c414ed6a7ba2973f881a380d322adb5767a2 DIFF: https://github.com/llvm/llvm-project/commit/1c64c414ed6a7ba2973f881a380d322adb5767a2.diff L

[PATCH] D153176: [Frontend] Remove ShowIncludesPretendHeader

2023-06-20 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153176/new/ https://reviews.llvm.org/D153176 ___ cfe

[PATCH] D144970: [llvm-c] Remove bindings for creating legacy passes

2023-06-20 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. In D144970#4434305 , @yamt wrote: > at least some of these stuff is used by wasm-micro-runtime. do you have a > suggestion about how to adapt it? > https://github.com/bytecodealliance/wasm-micro-runtime/blob/72fc872afe9a51228b2a32b

[PATCH] D144970: [llvm-c] Remove bindings for creating legacy passes

2023-06-20 Thread YAMAMOTO Takashi via Phabricator via cfe-commits
yamt added a comment. at least some of these stuff is used by wasm-micro-runtime. do you have a suggestion about how to adapt it? https://github.com/bytecodealliance/wasm-micro-runtime/blob/72fc872afe9a51228b2a32bc7b08475b176f187f/core/iwasm/compilation/aot_compiler.c#L2666-L2670 Repository:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

2023-06-20 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 532839. eopXD added a comment. Add SemaChecking and corresponding test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_ve

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

2023-06-20 Thread Abel Bernabeu via Phabricator via cfe-commits
abel-bernabeu updated this revision to Diff 532837. abel-bernabeu added a comment. I just this flashback... For code coverage of one of the Lex() calls in ParseInstruction we needed one case where an instruction has no operands. We had, not one, but three. Am keeping just the "nop" case, which

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

2023-06-20 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGAtomic.cpp:1474 Address AtomicInfo::emitCastToAtomicIntPointer(Address addr) const { llvm::IntegerType *ty = as it no longer emits anything. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

2023-06-20 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings marked an inline comment as done. michaelplatings added a comment. Thanks @simon_tatham. I agree there's definitely scope to improve this. The behaviour is quite specific so I kept the code in the BareMetal toolchain rather than as part of the core Multilib class. Other toolchain

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

2023-06-20 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 532836. eopXD added a comment. Rebase: Add `sew` parameter that other templates have added too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/c

[PATCH] D153292: [Driver][BareMetal] Error if no matching multilib

2023-06-20 Thread Simon Tatham via Phabricator via cfe-commits
simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM. One of the thoughts I mentioned offline before this patch was written was that maybe the error would need to be conditional, via a directive inside `multilib.yaml` itself –

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

2023-06-20 Thread Mariya Podchishchaeva via Phabricator via cfe-commits
Fznamznon updated this revision to Diff 532831. Fznamznon added a comment. Rebase, fix nit, expand the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153294/new/ https://reviews.llvm.org/D153294 Files: clang/docs/ReleaseNotes.rst clang/lib

[PATCH] D152879: [RISCV] Model vxrm control for vsmul, vssra, vssrl, vnclip, and vnclipu

2023-06-20 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 532830. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152879/new/ https://reviews.llvm.org/D152879 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking.

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

2023-06-20 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 532828. eopXD added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151397/new/ https://reviews.llvm.org/D151397 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking.c

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

2023-06-20 Thread Ben Shi via Phabricator via cfe-commits
benshi001 added inline comments. Comment at: llvm/lib/Target/AVR/AVRISelLowering.cpp:2207 + MF->push_back(LoopBB); + MachineBasicBlock *ExitBB = EntryBB->splitAt(MI, false); + Patryk27 wrote: > Alright, this is wrong, after all - I've just tested it on a more e

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

2023-06-20 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. There are some test failures. I believe there is one bug with the handling of unnamed globals. Previously we produced this: ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals --version 2 ; RUN: opt -S < %s | FileCheck

[clang] c146df9 - [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

2023-06-20 Thread Michael Buch via cfe-commits
Author: Michael Buch Date: 2023-06-20T09:19:19+01:00 New Revision: c146df9618764d5548c38ce61edc45147094b26f URL: https://github.com/llvm/llvm-project/commit/c146df9618764d5548c38ce61edc45147094b26f DIFF: https://github.com/llvm/llvm-project/commit/c146df9618764d5548c38ce61edc45147094b26f.diff

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

2023-06-20 Thread Michael Buch via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc146df961876: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

2023-06-20 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 532812. mboehme added a comment. Now that integer literals are associated with `Value`s, use them in tests instead of using a helper variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153006/new/ https://r

[PATCH] D153314: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

2023-06-20 Thread Nikita Popov via Phabricator via cfe-commits
nikic added inline comments. Comment at: clang/lib/CodeGen/CGNonTrivialStruct.cpp:370 llvm::Value *DstArrayEnd = CGF.Builder.CreateInBoundsGEP(CGF.Int8Ty, BC.getPointer(), SizeInBytes); DstArrayEnd = CGF.Builder.CreateBitCast( Only `BC.getPoin

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

2023-06-20 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. This change triggers failed asserts when compiling code for at least arm and aarch64. It is reproducible with this reduced testcase: $ cat repro.c typedef long long a; typedef int b(); int c, d; long e, f; short g, j; void *h; short i[]; char k; a l,

[PATCH] D152696: Prevent deadlocks in death tests.

2023-06-20 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152696/new/ https://reviews.llvm.org/D152696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] c307502 - [clangd] Index the type of a non-type template parameter

2023-06-20 Thread Nathan Ridge via cfe-commits
Author: Nathan Ridge Date: 2023-06-20T03:22:52-04:00 New Revision: c3075023850bbb7276085198d42b69938d48380d URL: https://github.com/llvm/llvm-project/commit/c3075023850bbb7276085198d42b69938d48380d DIFF: https://github.com/llvm/llvm-project/commit/c3075023850bbb7276085198d42b69938d48380d.diff

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

2023-06-20 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc3075023850b: [clangd] Index the type of a non-type template parameter (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153251/new/ https

[PATCH] D153251: [clangd] Index the type of a non-type template parameter

2023-06-20 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153251/new/ https://reviews.llvm.org/D153251

[PATCH] D153321: [OpenMP] Fix lvalue reference type generation in untied task loop

2023-06-20 Thread Zhiheng Xie via Phabricator via cfe-commits
eastb233 created this revision. eastb233 added a reviewer: ABataev. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. eastb233 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald add

[PATCH] D152696: Prevent deadlocks in death tests.

2023-06-20 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added a comment. In D152696#4430238 , @mgorny wrote: > This change is causing a lot of unittests to fail on Gentoo. I've tested both > on amd64 and arm64; on amd64 additionally the test suite seems to hang. > ... Sorry, only just saw this now. I

[PATCH] D153271: [include-cleaner] Bailout on invalid code for the command-line tool

2023-06-20 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGab32cc6c02f5: [include-cleaner] Bailout on invalid code for the command-line tool (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153271/

[clang-tools-extra] ab32cc6 - [include-cleaner] Bailout on invalid code for the command-line tool

2023-06-20 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2023-06-20T09:07:27+02:00 New Revision: ab32cc6c02f539bc87e71fefc9670f28a7fc7f56 URL: https://github.com/llvm/llvm-project/commit/ab32cc6c02f539bc87e71fefc9670f28a7fc7f56 DIFF: https://github.com/llvm/llvm-project/commit/ab32cc6c02f539bc87e71fefc9670f28a7fc7f56.diff LO

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

2023-06-20 Thread Yueh-Ting (eop) Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 532800. eopXD added a comment. Fix ManualCodegen for vfadd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td clang/i

<    1   2