[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

This revision was automatically updated to reflect the committed changes. tomasz-kaminski-sonarsource marked an inline comment as done. Closed by commit rGfeafbb9fda57: [analyzer] Differentiate lifetime extended temporaries (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github

[clang] feafbb9 - [analyzer] Differentiate lifetime extended temporaries

Author: Tomasz Kamiński Date: 2023-07-05T07:39:14+02:00 New Revision: feafbb9fda57dc77d5349a352b8495b6ef0f1bf5 URL: https://github.com/llvm/llvm-project/commit/feafbb9fda57dc77d5349a352b8495b6ef0f1bf5 DIFF:

[PATCH] D153957: [C++20] [Modules] Allow Stmt::Profile to treat lambdas as equal conditionally

ChuanqiXu added a comment. I'd like to land this in the next week if no objections come in. Since clang-17 is going to be branched and this one is small and relevant. Also this one prevents the testing of the std modules. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153957/new/

[PATCH] D153695: [clang][Interp] Fix passing parameters of composite type

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.h:71 - /// Parameter indices. - llvm::DenseMap Params; + /// Parameter indices. > + llvm::DenseMap Params; shafik wrote: > I don't

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153693: [clang][Interp] Handle InitListExprs of composite type

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153693/new/ https://reviews.llvm.org/D153693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag

phosek added a comment. In D143052#4468485 , @ldionne wrote: > What is the status of this? We now require CMake 3.20, can this be rebased > and landed in some form? The issue I ran into is that `check_linker_flag` annoyingly behaves differently from

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added a comment. In D154221#4472112 , @steakhal wrote: > @tripleCC Could you clarify the status. Do you need some help or review? Do > you have concerns? > You made some inline comments that I couldn't put into context. @steakhal Yes, I need

[PATCH] D154467: [clang-format] Add Verilog suffixes to the scripts

sstwcw created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team Automated

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw marked an inline comment as done. sstwcw added a comment. In D154091#4470158 , @MyDeveloperDay wrote: > What would happen in a \r\n example If the entire `\r\n` part fits on the first line, the break is after `\r\n`. If only the part up to

[PATCH] D154091: [clang-format] Recognize escape sequences when breaking strings

sstwcw updated this revision to Diff 537190. sstwcw added a comment. - Add tests for other escape sequences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154091/new/ https://reviews.llvm.org/D154091 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D150221: Add option -fkeep-persistent-storage-variables to emit all variables that have a persistent storage duration

qianzhen added inline comments. Comment at: clang/test/CodeGen/keep-persistent-storage-variables.cpp:32-39 +int test1() { + g1 = 3; + return g1; +} + +int test2() { + return g2; hubert.reinterpretcast wrote: > Why add functions that use `g1` and `g2`? Is

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

qianzhen updated this revision to Diff 537175. qianzhen added a comment. Update to address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150221/new/ https://reviews.llvm.org/D150221 Files:

[PATCH] D154460: [ODRHash] Stop hashing `ObjCMethodDecl::isPropertyAccessor` as it doesn't capture inherent method quality.

vsapsai created this revision. vsapsai added reviewers: ChuanqiXu, jansvoboda11, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `isPropertyAccessor`

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537163. massberg marked 2 inline comments as done. massberg added a comment. Add test case that isn't correctly handled yet and add FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/

[PATCH] D154459: [ODRHash] Stop hashing `ObjCMethodDecl::isOverriding` as it doesn't capture inherent method quality.

vsapsai created this revision. vsapsai added reviewers: ChuanqiXu, jansvoboda11, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `isOverriding` depends on

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg marked 7 inline comments as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:327 +return ""; + return "<" + Signature.substr(FirstComma + 2); +} sammccall wrote: > I don't love the arithmetic, the

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537161. massberg added a comment. Update code by resolving comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/ https://reviews.llvm.org/D154450 Files:

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537160. Jake-Egan added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/llvm/CodeGen/AsmPrinter.h

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537156. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Updated to use both a newline and null byte to separate command lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

steakhal added a comment. @tripleCC Could you clarify the status. Do you need some help or review? Do you have concerns? You made some inline comments that I couldn't put into context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154221/new/

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

ldionne added a comment. LGTM, but as a matter of process, please try to wait for someone from the libc++ review group before submitting. Thanks for the fix! Comment at: libcxx/include/__tree:379-380 _LIBCPP_ASSERT_UNCATEGORIZED(__z != nullptr, "The node to remove should

[PATCH] D86993: Document Clang's expectations of the C standard library.

RalfJung added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. What is the status of this patch? It has not been committed as far as I can tell. I was looking into this coming from Rust, where we do worry a bit about LLVM calling `memcpy`, `memmove` or `memset`

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

sammccall added a comment. Cool! This makes sense, and is much cheaper than actually working out how to render the abbreviated arg list and store it in the index. Nice that TopLevel gives us some of these contexts, but I suspect it's not all. (If not, it's fine to handle just this case for now

[clang] 0d40973 - [clang][Interp][NFC] Move CastFP to Interp.h

Author: Timm Bäder Date: 2023-07-04T17:35:28+02:00 New Revision: 0d40973644ba7f3efe666735306646579a7ffe5e URL: https://github.com/llvm/llvm-project/commit/0d40973644ba7f3efe666735306646579a7ffe5e DIFF: https://github.com/llvm/llvm-project/commit/0d40973644ba7f3efe666735306646579a7ffe5e.diff

[clang] a936357 - [clang][Interp][NFC] Return integer from Boolean::bitWidth()

Author: Timm Bäder Date: 2023-07-04T17:35:28+02:00 New Revision: a93635794813ab26a751f72ccb78534e288390b2 URL: https://github.com/llvm/llvm-project/commit/a93635794813ab26a751f72ccb78534e288390b2 DIFF: https://github.com/llvm/llvm-project/commit/a93635794813ab26a751f72ccb78534e288390b2.diff

[clang] 74514e8 - [clang][Interp][NFC] Fix GetFnPtr signature

Author: Timm Bäder Date: 2023-07-04T17:35:28+02:00 New Revision: 74514e8713bfcd31faeb6f4cfd5e29824413e1c1 URL: https://github.com/llvm/llvm-project/commit/74514e8713bfcd31faeb6f4cfd5e29824413e1c1 DIFF: https://github.com/llvm/llvm-project/commit/74514e8713bfcd31faeb6f4cfd5e29824413e1c1.diff

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added inline comments. Comment at: clang/test/Analysis/nullability-arc.mm:25 [self foo:nil]; + // expected-warning@-1{{nil passed to a callee that requires a non-null 1st parameter}} I think there should be a warning when we call the foo: method

[PATCH] D154437: [analyzer][NFC] Make AnalyzerConfig round-tripping deterministic

steakhal abandoned this revision. steakhal added a comment. Ah, D142861 is only on `main`, that's why we don't have that. I'll cherry-pick that then. @jansvoboda11 Thanks for the xref! Confirmed, that fixes the issue. Abandoning this one. Repository: rG

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp:556 + bool IsLocal = + isa_and_nonnull(MR) && + isa(MR->getMemorySpace()); tomasz-kaminski-sonarsource wrote: > xazax.hun wrote: > > I think strictly

[clang] df5213c - [clang][Interp][NFC] Return a const pointer from Pointer::getRecord()

Author: Timm Bäder Date: 2023-07-04T17:21:51+02:00 New Revision: df5213c4420e40dace6506d39bba28459a91c2a4 URL: https://github.com/llvm/llvm-project/commit/df5213c4420e40dace6506d39bba28459a91c2a4 DIFF: https://github.com/llvm/llvm-project/commit/df5213c4420e40dace6506d39bba28459a91c2a4.diff

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp:556 + bool IsLocal = + isa_and_nonnull(MR) && + isa(MR->getMemorySpace());

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

xazax.hun accepted this revision. xazax.hun added a comment. I love it, I think we can land this as is. If there are further comments, we can address those in follow-up PRs. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:1190 CXXRecordDecl::field_iterator

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added inline comments. Comment at: clang/test/Analysis/nullability-arc.mm:26 [self foo:nil]; -#if __has_feature(objc_arc) - // expected-note@-2{{Calling 'foo:'}} - // expected-note@-3{{Passing nil object reference via 1st parameter 'param'}} -#endif + //

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; yronglin wrote: > aaron.ballman wrote: > > yronglin wrote: > > > hokein wrote: > > > > The constant evaluator is not aware of the

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

steakhal added a comment. Fixed remarks, cleaned up residual includes, rebased. Should be read to land. Final thoughts? Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:501 public: +const iterator *() const { return *this; } +

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp:556 + bool IsLocal = + isa_and_nonnull(MR) && + isa(MR->getMemorySpace()); I think strictly speaking this might be "unsound" resulting in false positives

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'd appreciate some review on this, given that a lot of you would be affected by the changes of CFG. By changes I mean, fixes for goto statements, properly calling destructors and stuff.

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC updated this revision to Diff 537110. tripleCC added a comment. try to fix nullability-arc.mm test case error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154221/new/ https://reviews.llvm.org/D154221 Files:

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1282 + LLVM_ATTRIBUTE_RETURNS_NONNULL + const Expr *getExpr() const { return Ex; } + LLVM_ATTRIBUTE_RETURNS_NONNULL

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM > Fixed. Does this test case exist somewhere? I couldn't find it upstream. That wasn't an existing test case. Though if you add a `--check-globals

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin marked 3 inline comments as done. yronglin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; aaron.ballman wrote: > yronglin wrote: > > hokein wrote: > > > The constant evaluator is

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 537092. tomasz-kaminski-sonarsource added a comment. Reformatting and link to revelant core issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added a comment. In D151325#4470832 , @xazax.hun wrote: > Overall looks good to me. I think the changes to the notes already make the > analyzer more useful so

[clang] 044be8f - [clang][Interp][NFC] Add some missing const qualifiers

Author: Timm Bäder Date: 2023-07-04T16:16:17+02:00 New Revision: 044be8f5d12fcb35cb5c30fa05d95b1abbf19232 URL: https://github.com/llvm/llvm-project/commit/044be8f5d12fcb35cb5c30fa05d95b1abbf19232 DIFF: https://github.com/llvm/llvm-project/commit/044be8f5d12fcb35cb5c30fa05d95b1abbf19232.diff

[clang] 843ff75 - [clang][Interp][NFC] Return std::nullopt explicitly

Author: Timm Bäder Date: 2023-07-04T16:16:18+02:00 New Revision: 843ff7581408a02e852c0f1f7ebf176cabbc7527 URL: https://github.com/llvm/llvm-project/commit/843ff7581408a02e852c0f1f7ebf176cabbc7527 DIFF: https://github.com/llvm/llvm-project/commit/843ff7581408a02e852c0f1f7ebf176cabbc7527.diff

[clang] 1c8c5a8 - [clang][Interp][NFC] Merge two if statements

Author: Timm Bäder Date: 2023-07-04T16:16:17+02:00 New Revision: 1c8c5a89c59cee16d6500a4e83c8c29b8a4a37a4 URL: https://github.com/llvm/llvm-project/commit/1c8c5a89c59cee16d6500a4e83c8c29b8a4a37a4 DIFF: https://github.com/llvm/llvm-project/commit/1c8c5a89c59cee16d6500a4e83c8c29b8a4a37a4.diff

[PATCH] D154443: [clangd] Downgrade deprecated warnings to hints

This revision was automatically updated to reflect the committed changes. Closed by commit rGa59b24be47ed: [clangd] Downgrade deprecated warnings to hints (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154443/new/

[clang-tools-extra] a59b24b - [clangd] Downgrade deprecated warnings to hints

Author: Kadir Cetinkaya Date: 2023-07-04T16:07:08+02:00 New Revision: a59b24be47ed6263c254d168567b9ebba391fac9 URL: https://github.com/llvm/llvm-project/commit/a59b24be47ed6263c254d168567b9ebba391fac9 DIFF:

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added a comment. In D153366#4471320 , @TWeaver wrote: > My apologies but I've had to revert this change for now until the author can > address the buildbot failures. Thanks for the revert, and sorry for the disruption - I expected to be

[PATCH] D154443: [clangd] Downgrade deprecated warnings to hints

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154443/new/ https://reviews.llvm.org/D154443

[PATCH] D154443: [clangd] Downgrade deprecated warnings to hints

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This tries

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1e35e93e30c2: [libc++] Disable tree invariant check in asserts mode (authored by hans). Repository: rG LLVM Github

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

hans added a comment. In D154417#4471141 , @alexfh wrote: > Given the comment in https://reviews.llvm.org/D153672#4468348, I think, this > should be fine to submit. Sounds good to me. Happy to follow up if libc++ maintainers have more input.

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. My apologies but I've had to revert this change for now until the author can address the buildbot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366

[clang] 7a72ce9 - Revert "[dataflow] Add dedicated representation of boolean formulas"

Author: Tom Weaver Date: 2023-07-04T14:05:54+01:00 New Revision: 7a72ce98224be76d9328e65eee472381f7c8e7fe URL: https://github.com/llvm/llvm-project/commit/7a72ce98224be76d9328e65eee472381f7c8e7fe DIFF: https://github.com/llvm/llvm-project/commit/7a72ce98224be76d9328e65eee472381f7c8e7fe.diff

[PATCH] D154437: [analyzer][NFC] Make AnalyzerConfig round-tripping deterministic

steakhal added a comment. In D154437#4471225 , @jansvoboda11 wrote: > Has this not been addressed by D142861 > already? Hm, The same failure. This must be related. I'll have a look. But, you can try it yourself that

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. Ruturaj4 added a reviewer: dang. Ruturaj4 edited the summary of this revision. Ruturaj4 edited the summary of this revision. Ruturaj4 updated this revision to Diff 537064. Ruturaj4 added a comment.

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0be47c51cfd: [clang][dataflow] Make `runDataflowReturnError()` a non-template function. (authored by mboehme). Repository: rG LLVM Github

[clang] d0be47c - [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

Author: Martin Braenne Date: 2023-07-04T12:44:49Z New Revision: d0be47c51cfdb8b94eb20279c02e8e2875380919 URL: https://github.com/llvm/llvm-project/commit/d0be47c51cfdb8b94eb20279c02e8e2875380919 DIFF: https://github.com/llvm/llvm-project/commit/d0be47c51cfdb8b94eb20279c02e8e2875380919.diff

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. Hello and good afternoon from the UK, I believe this change has introduced test failures on the following buildbot: https://lab.llvm.org/buildbot/#/builders/139/builds/44269 are you able to take a look see? Much appreciated, Tom W Repository: rG LLVM Github

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman added a comment. In D61508#4469426 , @garymm wrote: > @aaron.ballman what's remaining for this to be mergeable? It needs to be rebased onto trunk and it looks like there's some test coverage missing for unsupported styles. It should

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 537065. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Add comments about Mangling and OnlyForCPUDispatchSpecific, and remove the supporting more/new CPU names for cpu_specific/dispatch feature. Repository: rG LLVM Github Monorepo

[PATCH] D154434: [clang-tidy] Don't emit the whole spelling include header in include-cleaner diagnostic message

This revision was automatically updated to reflect the committed changes. Closed by commit rG2444fb96435e: [clang-tidy] Dont emit the whole spelling include header in include-cleaner… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 2444fb9 - [clang-tidy] Don't emit the whole spelling include header in include-cleaner diagnostic message

Author: Haojian Wu Date: 2023-07-04T14:32:27+02:00 New Revision: 2444fb96435ecae73211f3ced3d06e48719afe97 URL: https://github.com/llvm/llvm-project/commit/2444fb96435ecae73211f3ced3d06e48719afe97 DIFF: https://github.com/llvm/llvm-project/commit/2444fb96435ecae73211f3ced3d06e48719afe97.diff

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; yronglin wrote: > hokein wrote: > > The constant evaluator is not aware of the "error" concept, it is only > > aware of

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added a comment. I finally got around to testing this patch on compiles of explicit modules. The number of elapsed CPU cycles decreased (by up to 1.8% for large modules) and the cumulative size of PCM files decreased by 2% (though small modules are a few bytes larger). These

[PATCH] D154437: [analyzer][NFC] Make AnalyzerConfig round-tripping deterministic

jansvoboda11 added a comment. Has this not been addressed by D142861 already? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154437/new/ https://reviews.llvm.org/D154437

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

steakhal planned changes to this revision. steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:501 public: +const iterator *() const { return *this; } +

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/80815/step_7.txt Please take a look etc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

mboehme updated this revision to Diff 537061. mboehme added a comment. Rename `runDataflowReturnError()` as discussed in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154339/new/ https://reviews.llvm.org/D154339 Files:

[PATCH] D154437: [analyzer][NFC] Make AnalyzerConfig round-tripping deterministic

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, jansvoboda11. Herald added subscribers: PiotrZSL, carlosgalvezp, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, mgrang, szepet, baloghadamsoftware. Herald added a reviewer:

[PATCH] D154421: [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG880f306226fc: [clang][dataflow] Add a test for a struct that is directly self-referential… (authored by mboehme). Repository: rG LLVM Github

[PATCH] D154420: [clang][dataflow] Model variables / fields / funcs used in default initializers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e7329cd79c5: [clang][dataflow] Model variables / fields / funcs used in default initializers. (authored by mboehme). Repository: rG LLVM Github

[clang] 1e7329c - [clang][dataflow] Model variables / fields / funcs used in default initializers.

Author: Martin Braenne Date: 2023-07-04T12:06:10Z New Revision: 1e7329cd79c53165f113edfe6a2ff06d12899632 URL: https://github.com/llvm/llvm-project/commit/1e7329cd79c53165f113edfe6a2ff06d12899632 DIFF: https://github.com/llvm/llvm-project/commit/1e7329cd79c53165f113edfe6a2ff06d12899632.diff

[clang] 880f306 - [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

Author: Martin Braenne Date: 2023-07-04T12:06:13Z New Revision: 880f306226fcb97d85d422480954eb8765ff31c7 URL: https://github.com/llvm/llvm-project/commit/880f306226fcb97d85d422480954eb8765ff31c7 DIFF: https://github.com/llvm/llvm-project/commit/880f306226fcb97d85d422480954eb8765ff31c7.diff

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

donat.nagy added a comment. I don't have concrete remarks, but I would like to note that I'm happy to see this cleanup :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154325/new/ https://reviews.llvm.org/D154325

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

uabelho added a comment. Failed Tests (6): Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/BoolValueDebugStringTest/ComplexBooleanWithSomeNames Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/BoolValueDebugStringTest/Conjunction

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin marked 3 inline comments as done. yronglin added a comment. Thanks a lot for your comments! @hokein Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; hokein wrote: > The constant evaluator is not aware

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

alexfh added a comment. Given the comment in https://reviews.llvm.org/D153672#4468348, I think, this should be fine to submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154417/new/ https://reviews.llvm.org/D154417

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults, - DataflowAnalysisOptions

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

alexfh accepted this revision. alexfh added a comment. Thanks for the temporary fix, Hans! We're also affected by this. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154417/new/ https://reviews.llvm.org/D154417

[PATCH] D154421: [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154421/new/ https://reviews.llvm.org/D154421 ___ cfe-commits mailing list

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults, - DataflowAnalysisOptions

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults, - DataflowAnalysisOptions

[PATCH] D154434: [clang-tidy] Don't emit the whole spelling include header in include-cleaner diagnostic message

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project:

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults, - DataflowAnalysisOptions

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc68ba12abf49: [clang][modules] Mark fewer identifiers as out-of-date (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES

[clang] c68ba12 - [clang][modules] Mark fewer identifiers as out-of-date

Author: Jan Svoboda Date: 2023-07-04T12:58:44+02:00 New Revision: c68ba12abf490716fd7a57bba9c2dda1d537b19c URL: https://github.com/llvm/llvm-project/commit/c68ba12abf490716fd7a57bba9c2dda1d537b19c DIFF: https://github.com/llvm/llvm-project/commit/c68ba12abf490716fd7a57bba9c2dda1d537b19c.diff

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1282 + LLVM_ATTRIBUTE_RETURNS_NONNULL + const Expr *getExpr() const { return Ex; } +

[PATCH] D154421: [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

mboehme updated this revision to Diff 537029. mboehme added a comment. Actually make the test pass. It was missing an indirection. No idea how I missed this on the initial upload... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154421/new/

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Overall looks good to me. I think the changes to the notes already make the analyzer more useful so there are some observable benefits to this patch. Comment at:

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG2fd614efc1bb: [dataflow] Add dedicated representation of boolean formulas (authored by sammccall).

[clang] 2fd614e - [dataflow] Add dedicated representation of boolean formulas

Author: Sam McCall Date: 2023-07-04T12:19:44+02:00 New Revision: 2fd614efc1bb9c27f1bc6c3096c60a7fe121e274 URL: https://github.com/llvm/llvm-project/commit/2fd614efc1bb9c27f1bc6c3096c60a7fe121e274 DIFF: https://github.com/llvm/llvm-project/commit/2fd614efc1bb9c27f1bc6c3096c60a7fe121e274.diff

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall marked 11 inline comments as done. sammccall added inline comments. Herald added a subscriber: wangpc. Comment at: clang/include/clang/Analysis/FlowSensitive/Formula.h:69 + + Atom atom() const { +assert(kind() == AtomRef); gribozavr2 wrote: >

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:501 public: +const iterator *() const { return *this; } + Is this just a dummy to make sure this satisfies

[PATCH] D154420: [clang][dataflow] Model variables / fields / funcs used in default initializers.

mboehme added a comment. pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154420/new/ https://reviews.llvm.org/D154420 ___ cfe-commits mailing list

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. @nikic Are you happy with the current patchset? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall closed this revision. sammccall added a comment. Herald added a subscriber: wangpc. This relanded as 1e010c5c4fae43c52d6f5f1c8e8920c26bcc6cc7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >