[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

cor3ntin added a comment. Thanks, this looks good! (the libc++ test seems completely unrelated, it happens before compilation starts). Can you add re release note though? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/ https://reviews.llvm.org/D154675 ___

[PATCH] D154597: [clang][dataflow] Various refactorings to UncheckedOptionalAccessModel.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf653d14065a3: [clang][dataflow] Various refactorings to UncheckedOptionalAccessModel. (authored by mboehme). Repository: rG LLVM Github Monorepo

[PATCH] D154586: [clang][dataflow] Various changes to handling of modeled fields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a1560d1de9: [clang][dataflow] Various changes to handling of modeled fields. (authored by mboehme). Changed prior to commit: https://reviews.llv

[clang] f653d14 - [clang][dataflow] Various refactorings to UncheckedOptionalAccessModel.

Author: Martin Braenne Date: 2023-07-10T06:45:55Z New Revision: f653d14065a362c98114082c4e9a3b1ede7a90f5 URL: https://github.com/llvm/llvm-project/commit/f653d14065a362c98114082c4e9a3b1ede7a90f5 DIFF: https://github.com/llvm/llvm-project/commit/f653d14065a362c98114082c4e9a3b1ede7a90f5.diff LOG

[clang] e8a1560 - [clang][dataflow] Various changes to handling of modeled fields.

Author: Martin Braenne Date: 2023-07-10T06:45:53Z New Revision: e8a1560d1de9514d3f1631388fe966476778e540 URL: https://github.com/llvm/llvm-project/commit/e8a1560d1de9514d3f1631388fe966476778e540 DIFF: https://github.com/llvm/llvm-project/commit/e8a1560d1de9514d3f1631388fe966476778e540.diff LOG

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154586: [clang][dataflow] Various changes to handling of modeled fields.

mboehme added a comment. libcxx failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154586/new/ https://reviews.llvm.org/D154586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154597: [clang][dataflow] Various refactorings to UncheckedOptionalAccessModel.

mboehme added a comment. libcxx and clangd failures look unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154597/new/ https://reviews.llvm.org/D154597 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. > What is left for this to be reverted, in the quest to fully enable IAS for > AIX? See `XCOFFAsmParser::ParseDirectiveCSect()` and I think qual symbol names in AIX assembly(quite common for AIX assembly) can also not be parsed with llvm's asm parser. Repository: r

[PATCH] D154764: [clang] ASTImport: force recomputing ASTRecordLayout when importing

danix800 updated this revision to Diff 538500. danix800 added a comment. Apply git-clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154764/new/ https://reviews.llvm.org/D154764 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/Rec

[PATCH] D148490: [AIX] use system assembler for assembly files

brad added a comment. What is left for this to be reverted, in the quest to fully enable IAS for AIX? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-co

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

kito-cheng marked an inline comment as done. kito-cheng added inline comments. Comment at: clang/lib/Headers/riscv_int.h:10 + +#ifndef __RISCV_INT_H + craig.topper wrote: > Don't you have to `#define __RISCV_INT_H` after this to make this a complete > include gu

[PATCH] D154706: [RISCV] Add XLEN width integer type: riscv_int.h

kito-cheng updated this revision to Diff 538497. kito-cheng added a comment. Changes: - Define __RISCV_INT_H Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154706/new/ https://reviews.llvm.org/D154706 Files: clang/lib/Headers/CMakeLists.txt cl

[PATCH] D154130: [lit] Avoid os.path.realpath on Windows due to MAX_PATH limitations

ChuanqiXu added a comment. I don't write module map a lot neither. But I am curious where is the definition for the term `%>/t`? It is indeed a little bit odd at the first look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154130/new/ https://rev

[PATCH] D154801: C++20 Modules: update pr59999.cppm to reflect a reproducible state

ChuanqiXu added a comment. Thanks for working on this. The message from the CI bot shows there is something wrong with the updating. > I'm trying to run this patch using LLVM sources on my machine, but > unfortunately, I'm facing disk space issues (it's an old Windows machine). In this case, y

[PATCH] D154576: [RISCV] RISCV vector calling convention (1/2)

lhtin added a comment. In D154576#4476300 , @4vtomat wrote: > In D154576#4476291 , @craig.topper > wrote: > >> Does this only change the calling convention when >> `__attribute__((riscv_vector_cc))` is used? The

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik added a comment. @aaron.ballman I can't figure out why the libcxx bot failed, can you understand why? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/ https://reviews.llvm.org/D154675 ___ cfe-commits mailing list cfe-commits@

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

owenpan marked an inline comment as done. owenpan added a comment. In D154484#4483659 , @sstwcw wrote: > Did you forget about GNU statement expressions? > > if (({ > foo(); > bar(); > })) { > } Thanks! CHANGES SINCE LAST ACTIO

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

owenpan updated this revision to Diff 538470. owenpan added a reviewer: sstwcw. owenpan removed a subscriber: sstwcw. owenpan added a comment. Don't treat `(` as `l_paren` if it's followed by `{`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154484/new/ https://reviews.llvm.org/D154484

[clang] 3450272 - [Driver][FreeBSD] Generalise lib32 handling to support arm

Author: Jessica Clarke Date: 2023-07-10T01:40:58+01:00 New Revision: 3450272fc281979388bb845a9fffb59b42cc2e7e URL: https://github.com/llvm/llvm-project/commit/3450272fc281979388bb845a9fffb59b42cc2e7e DIFF: https://github.com/llvm/llvm-project/commit/3450272fc281979388bb845a9fffb59b42cc2e7e.diff

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

Fako432 added a comment. Herald added a subscriber: wangpc. In D128059#3640564 , @cor3ntin wrote: > In D128059#3640544 , > @hubert.reinterpretcast wrote: > >> In D128059#3640424

[PATCH] D154790: [HIP] Use native math functions for `-fcuda-approx-transcendentals`

arsenm added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:163 +__DEVICE__ +float __expf(float __x) { return __ocml_native_exp_f32(__x); } + arsenm wrote: > __builtin_expf Maybe this should just be __builtin_amdgcn_exp2f CHANGES SINCE LAST

[PATCH] D154790: [HIP] Use native math functions for `-fcuda-approx-transcendentals`

arsenm added a comment. This would be a lot easier if we clang fp was fully featured. As far as I can tell it lets you set #pragma clang fp reassociate(on), and contract(fast), but doesn't have a way to set arcp, afn, ninf or nnan Comment at: clang/lib/Headers/__clang_hip_mat

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik marked an inline comment as done. shafik added a comment. Found a new issue https://github.com/llvm/llvm-project/issues/63759 but this feels different enough that I will deal with it separately. Comment at: clang/test/SemaCXX/cxx2a-initializer-aggregates.cpp:182 +namesp

[PATCH] D154675: [Clang] Fix crash when emitting diagnostic for out of order designated initializers in C++

shafik updated this revision to Diff 538456. shafik added a comment. - Stopped using `NumBases` when calculating `OldIndex` - Added bases classes to the test and added more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154675/new/ https://reviews.llvm.org/D154675 Files: cl

[PATCH] D154801: C++20 Modules: update pr59999.cppm to reflect a reproducible state

m4c0 created this revision. Herald added a project: All. m4c0 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a extension for #5 tests in order to make them reproduce the issue reported. After local tests, I found out the defi

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

michaelmaitland added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2381 + if HasVV then { +defvar suffix = !if(!or(HasVS, !eq(NAME, "vsm4r")), "vv", "v"); +// We don't need suffix in Zvkb extension since it's consider as normal

[PATCH] D154484: [clang-format] Add an option to remove redundant parentheses

sstwcw added a comment. Did you forget about GNU statement expressions? if (({ foo(); bar(); })) { } Comment at: clang/docs/ReleaseNotes.rst:804 - Add ``KeepEmptyLinesAtEOF`` to keep empty lines at end of file. +- Add ``RemoveParenthese`` to remove r

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseStdFormatCheck.cpp:46 +void UseStdFormatCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(argumentCountAtLeast(1), hasArgument(0, stringLiteral()), -

[PATCH] D154797: [CUDA][HIP] Rename and fix `-fcuda-approx-transcendentals`

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay, b-sumner. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. Rename `-fcuda-approx-transcendentals` as `-fgpu-approx-transcendentals` and pass it to both device a

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

michaelmaitland added a comment. Can you please add a description for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 ___ cfe-commits mailing list c

[PATCH] D154552: [clang-format] Add note directive generation for docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ec5dc694478: [clang-format] Add note directive generation for docs (authored by gedare, committed by owenpan). Repository: rG LLVM Github Monorep

[clang] 9ec5dc6 - [clang-format] Add note directive generation for docs

Author: Gedare Bloom Date: 2023-07-09T12:24:55-07:00 New Revision: 9ec5dc6944781b0c233e874a4ed8d12106df14ac URL: https://github.com/llvm/llvm-project/commit/9ec5dc6944781b0c233e874a4ed8d12106df14ac DIFF: https://github.com/llvm/llvm-project/commit/9ec5dc6944781b0c233e874a4ed8d12106df14ac.diff

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Thanks for the patch! But I share the concern that the test is added to a wrong layer (https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer). We

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:48 + case llvm::Triple::thumb: +if (Arg *A = Args.getLastArg(options::OPT_mlittle_endian, + options::OPT_mbig_endian)) We can check the option

[PATCH] D154795: [clang][Interp] Check pointers for live-ness when returning them

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We might be trying to return a pointer or reference

[PATCH] D154790: [HIP] Use native math functions for `-fcuda-approx-transcendentals`

b-sumner added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:304 +__DEVICE__ +float __tanf(float __x) { return __ocml_tan_f32(__x); } +// END INTRINSICS We could consider multiplying native_sin here with the native_recip of native_cos. CHAN

[clang] b4e09c0 - [RISCV] Update test case riscv-attr-builtin-alias.c (NFC)

Author: eopXD Date: 2023-07-09T08:41:59-07:00 New Revision: b4e09c0dea866e48be83eae8c2f269162f6f04e0 URL: https://github.com/llvm/llvm-project/commit/b4e09c0dea866e48be83eae8c2f269162f6f04e0 DIFF: https://github.com/llvm/llvm-project/commit/b4e09c0dea866e48be83eae8c2f269162f6f04e0.diff LOG: [R

[PATCH] D154693: [RISCV] Remove redundant _ta suffix in RVV intrinsics builtins. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5704630ec40d: [RISCV] Remove redundant _ta suffix in RVV intrinsics builtins. NFC (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGE

[clang] 5704630 - [RISCV] Remove redundant _ta suffix in RVV intrinsics builtins. NFC

Author: eopXD Date: 2023-07-09T08:40:36-07:00 New Revision: 5704630ec40dbf1ebc7b16181b226e1545f8eb5c URL: https://github.com/llvm/llvm-project/commit/5704630ec40dbf1ebc7b16181b226e1545f8eb5c DIFF: https://github.com/llvm/llvm-project/commit/5704630ec40dbf1ebc7b16181b226e1545f8eb5c.diff LOG: [R

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx updated this revision to Diff 538437. AlexVlx added a comment. Herald added a subscriber: wangpc. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 Files: clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/li

[PATCH] D154758: [clang][Interp] Emit correct diagnostic for uninitialized reads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc54ff51be9c1: [clang][Interp] Emit correct diagnostic for uninitialized reads (authored by tbaeder). Changed prior to commit: https://reviews.llvm

[clang] c54ff51 - [clang][Interp] Emit correct diagnostic for uninitialized reads

Author: Timm Bäder Date: 2023-07-09T16:27:49+02:00 New Revision: c54ff51be9c1192214eb56fc5c8dea2b73557406 URL: https://github.com/llvm/llvm-project/commit/c54ff51be9c1192214eb56fc5c8dea2b73557406 DIFF: https://github.com/llvm/llvm-project/commit/c54ff51be9c1192214eb56fc5c8dea2b73557406.diff LO

[clang] 193db1e - [clang][Interp][NFC] Make pointer chain management more robust

Author: Timm Bäder Date: 2023-07-09T16:27:49+02:00 New Revision: 193db1ebf09ac8a7661b4273e2847de34430a9af URL: https://github.com/llvm/llvm-project/commit/193db1ebf09ac8a7661b4273e2847de34430a9af DIFF: https://github.com/llvm/llvm-project/commit/193db1ebf09ac8a7661b4273e2847de34430a9af.diff LO

[clang] 254ad7d - [clang][Interp][NFC] Move isGloballyIndexed() to Context

Author: Timm Bäder Date: 2023-07-09T16:27:49+02:00 New Revision: 254ad7dd412308855ca29b97e9fd8079088cbef5 URL: https://github.com/llvm/llvm-project/commit/254ad7dd412308855ca29b97e9fd8079088cbef5 DIFF: https://github.com/llvm/llvm-project/commit/254ad7dd412308855ca29b97e9fd8079088cbef5.diff LO

[PATCH] D154788: [clang-tidy] Don't split \r\n in modernize-use-std-print check

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154788/new/ https://reviews.llvm.org/D154788 ___

[clang] fa1e9c3 - [clang][Interp][NFC] Add std:: qualifiers to all malloc/free calls

Author: Timm Bäder Date: 2023-07-09T16:13:19+02:00 New Revision: fa1e9c3a5aacb1183fa3da410cb9dfd24b1a6d15 URL: https://github.com/llvm/llvm-project/commit/fa1e9c3a5aacb1183fa3da410cb9dfd24b1a6d15 DIFF: https://github.com/llvm/llvm-project/commit/fa1e9c3a5aacb1183fa3da410cb9dfd24b1a6d15.diff LO

[clang] b9e1679 - [clang][Interp][NFC] Clear stack memory even on success

Author: Timm Bäder Date: 2023-07-09T16:13:19+02:00 New Revision: b9e167994f01172c20716de28ea24f202b45b6a7 URL: https://github.com/llvm/llvm-project/commit/b9e167994f01172c20716de28ea24f202b45b6a7 DIFF: https://github.com/llvm/llvm-project/commit/b9e167994f01172c20716de28ea24f202b45b6a7.diff LO

[clang] 88d65e1 - [clang][Interp][NFC] Fix a doc comment mixup

Author: Timm Bäder Date: 2023-07-09T16:13:19+02:00 New Revision: 88d65e13464ab200f36082bf4f2613835e677144 URL: https://github.com/llvm/llvm-project/commit/88d65e13464ab200f36082bf4f2613835e677144 DIFF: https://github.com/llvm/llvm-project/commit/88d65e13464ab200f36082bf4f2613835e677144.diff LO

[clang] 3262aea - [clang][Interp][NFC] Add missing return statement

Author: Timm Bäder Date: 2023-07-09T16:13:18+02:00 New Revision: 3262aea06d36b1fbf3eb16d47afec742c18fd5e8 URL: https://github.com/llvm/llvm-project/commit/3262aea06d36b1fbf3eb16d47afec742c18fd5e8 DIFF: https://github.com/llvm/llvm-project/commit/3262aea06d36b1fbf3eb16d47afec742c18fd5e8.diff LO

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe updated this revision to Diff 538427. mikecrowe marked 3 inline comments as done. mikecrowe added a comment. Address review comments and improve documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154287/new/ https://reviews.llvm

[PATCH] D154788: [clang-tidy] Don't split \r\n in modernize-use-std-print check

mikecrowe created this revision. mikecrowe added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscribe

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe marked 9 inline comments as done. mikecrowe added a comment. Thanks for the reviews! Comment at: clang-tools-extra/clang-tidy/modernize/UseStdFormatCheck.cpp:81 + << ReplacementFormatFunction + << OldFunction->ge

[clang] a83079f - [clang][ConstExpr][NFC] Make Frame::describe() const

Author: Timm Bäder Date: 2023-07-09T15:49:32+02:00 New Revision: a83079f754a529b9a6d21480f834269b847220d3 URL: https://github.com/llvm/llvm-project/commit/a83079f754a529b9a6d21480f834269b847220d3 DIFF: https://github.com/llvm/llvm-project/commit/a83079f754a529b9a6d21480f834269b847220d3.diff LO

[clang] 5191214 - [clang][Interp][NFC] Make some Frame pointers const

Author: Timm Bäder Date: 2023-07-09T15:49:33+02:00 New Revision: 51912142381d190dfa56ef13df1a2f7384391c9d URL: https://github.com/llvm/llvm-project/commit/51912142381d190dfa56ef13df1a2f7384391c9d DIFF: https://github.com/llvm/llvm-project/commit/51912142381d190dfa56ef13df1a2f7384391c9d.diff LO

[clang] 1402c43 - [clang][Interp][NFC] Remove duplicate private specifier

Author: Timm Bäder Date: 2023-07-09T15:49:32+02:00 New Revision: 1402c4313820da984805b70e1bb6661217706499 URL: https://github.com/llvm/llvm-project/commit/1402c4313820da984805b70e1bb6661217706499 DIFF: https://github.com/llvm/llvm-project/commit/1402c4313820da984805b70e1bb6661217706499.diff LO

[PATCH] D154683: [RISCV] Split __builtin_riscv_brev8 into _32 and _64 builtin.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154683/new/ https://reviews.llvm.org/D154683 ___ cfe-

[PATCH] D154681: [RISCV] Split __builtin_riscv_xperm4/8 into separate _32 and _64 builtins.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154681/new/ https://reviews.llvm.org/D154681 ___ cfe-

[PATCH] D154786: [Clang][Driver] Pass through the --be8 endian flag to linker in BareMetal driver For Arm.

simpal01 created this revision. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. simpal01 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. When linking a big-endian image for Arm, clang has to select betw

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 abandoned this revision. Patryk27 added a comment. Superseded by: - https://reviews.llvm.org/D154785 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153197/new/ https://reviews.llvm.org/D153197 _

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin added a comment. I'm not sure if we should limit the value of `NumSubExprs` when build `PseudoObjectExpr` for `__builtin_dump_struct`, This cost too much memory when the nested members of the record are very deep and the num of member is very large. Repository: rG LLVM Github Mono

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin updated this revision to Diff 538418. yronglin added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154784/new/ https://reviews.llvm.org/D154784 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Expr.h clan

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

yronglin created this revision. Herald added a project: All. yronglin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: yrong Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154784 Files: clang/docs/Relea

[PATCH] D154778: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays of non-trivially equality comparable types

tbaeder added inline comments. Comment at: clang/lib/AST/Type.cpp:2676 + if (Type->isArrayType()) +Type = Type->getBaseElementTypeUnsafe()->getCanonicalTypeUnqualified(); + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154778: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays of non-trivially equality comparable types

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154778/new/ https://reviews.llvm.org/D154778 __

[PATCH] D154773: [AST] Use correct APSInt width when evaluating string literals

cor3ntin accepted this revision. cor3ntin added a subscriber: aaron.ballman. cor3ntin added a comment. This revision is now accepted and ready to land. I think this is fine, and it's a nice simplification. However it doesn't seem to do much of anything in practice: if you look at `StringLiteral:

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

benshi001 added a comment. In D153197#4483230 , @Patryk27 wrote: > ping ping, @benshi001 👀 Could you please upload your final version of this patch ? I see you have made some changes, but only mentioned in your comment. Repository: rG LLVM Github Mo

[PATCH] D131533: [Flang][Driver] Enable PIC in the frontend

awarzynski added inline comments. Comment at: flang/test/Driver/pic-flags.f90:3 -! RUN: %flang -### %s --target=aarch64-linux-gnu 2>&1 | FileCheck %s --check-prefix=CHECK-NOPIE -! RUN: %flang -### %s --target=aarch64-linux-gnu -fno-pie 2>&1 | FileCheck %s --check-prefix=CHECK

[PATCH] D153197: [AVR] Expand shifts during AVRISelLowering

Patryk27 added a comment. ping ping, @benshi001 👀 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153197/new/ https://reviews.llvm.org/D153197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https: