[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

sandeepkosuri added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9866 + (CGM.getLangOpts().OpenMP >= 51 && + needsTaskBasedThreadLimit(D.getDirectiveKind()) && + D.hasClausesOfKind()); ABataev wrote: > I think you don't need

[clang] b82c2b9 - Reland "Fix __cfi_check not aligned to 4k on relocatable files with no executable code"

Author: Yi Kong Date: 2023-08-04T16:02:27+09:00 New Revision: b82c2b9ac2baae0f2a9dd65770cfb37fdc2a80a9 URL: https://github.com/llvm/llvm-project/commit/b82c2b9ac2baae0f2a9dd65770cfb37fdc2a80a9 DIFF: https://github.com/llvm/llvm-project/commit/b82c2b9ac2baae0f2a9dd65770cfb37fdc2a80a9.diff LOG:

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin, hazohelet. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. In D148997#4559646 , @bnbarham wrote: >> Are there other users of incremental processing mode, other than the REPL / >> IncrementalParser? > > It seems Swift's clang importer also uses incremental processing mode, I'm > ass

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156221/new/ https://reviews.llvm.org/D156221 ___ cfe-commits mailing list cfe-commits

[PATCH] D146023: [AMDGPU] Remove Code Object V2

Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5598 return ParseDirectiveHSAMetadata(); } else { -if (IDVal == ".hsa_code_object_version") cfang wrote: > Are you sure Non-HSA does not have the four

[PATCH] D157075: [clang][ExtractAPI] Add support for C++ class templates and concepts Depends on D157007

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add has_template template, DeclarationFragments, and seri

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add has_template template, DeclarationFragmentBuilder fun

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

jcsxky updated this revision to Diff 547124. jcsxky added a comment. add unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/lib/AST/ASTImporter.cpp clang/test/Analysis/Inputs/ctu-fr

[clang] 2df05cd - [RISCV] Support overloaded version ntlh intrinsic function

Author: Piyou Chen Date: 2023-08-04T00:39:25-07:00 New Revision: 2df05cd01c17f3ef720e554dc7cde43df27e5224 URL: https://github.com/llvm/llvm-project/commit/2df05cd01c17f3ef720e554dc7cde43df27e5224 DIFF: https://github.com/llvm/llvm-project/commit/2df05cd01c17f3ef720e554dc7cde43df27e5224.diff LO

[PATCH] D156221: [RISCV] Support overloaded version ntlh intrinsic function

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2df05cd01c17: [RISCV] Support overloaded version ntlh intrinsic function (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[libunwind] 3537338 - [libc++][libunwind] Fixes to allow GCC 13 to compile libunwind/libc++abi/libc++

Author: Nikolas Klauser Date: 2023-08-04T00:51:43-07:00 New Revision: 3537338d1ab9b6da4b58499877953deb81c59e5e URL: https://github.com/llvm/llvm-project/commit/3537338d1ab9b6da4b58499877953deb81c59e5e DIFF: https://github.com/llvm/llvm-project/commit/3537338d1ab9b6da4b58499877953deb81c59e5e.dif

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon added a comment. Hmm, clang-format reports failure, but applying git-clang-format to the commit doesn't give me anything. It seems the whole SemaOverload.cpp file has broken formatting, maybe that is the reason for the failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] af91092 - [clang] Do not crash on use of a variadic overloaded operator

Author: Podchishchaeva, Mariya Date: 2023-08-04T01:44:10-07:00 New Revision: af91092c449d6d4bcf60b0cd233c48cd8a41e0e1 URL: https://github.com/llvm/llvm-project/commit/af91092c449d6d4bcf60b0cd233c48cd8a41e0e1 DIFF: https://github.com/llvm/llvm-project/commit/af91092c449d6d4bcf60b0cd233c48cd8a41e

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf91092c449d: [clang] Do not crash on use of a variadic overloaded operator (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

kadircet created this revision. kadircet added a reviewer: hokein. Herald added a subscriber: ChuanqiXu. Herald added a project: All. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Some tools can register virtual buffe

[PATCH] D157007: [clang][ExtractAPI] Add support for C++ classes with fix

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157007/new/ https://reviews.llvm.org/D157007 ___ cfe

[clang-tools-extra] 734da23 - [clangd] Dont assert on specific uris for diagnostics docs

Author: Kadir Cetinkaya Date: 2023-08-04T11:09:19+02:00 New Revision: 734da23e21eb687ff4a613d520cbef5348e26a65 URL: https://github.com/llvm/llvm-project/commit/734da23e21eb687ff4a613d520cbef5348e26a65 DIFF: https://github.com/llvm/llvm-project/commit/734da23e21eb687ff4a613d520cbef5348e26a65.dif

[PATCH] D157071: [clangd] Dont assert on specific uris for diagnostics docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG734da23e21eb: [clangd] Dont assert on specific uris for diagnostics docs (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157071/new/ h

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

Michael137 added a comment. Could you please elaborate in the commit message what exactly the issue currently is and how the patch addresses it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 __

[clang-tools-extra] 31873d3 - [include-cleaner] Handle files with unnamed buffers

Author: Kadir Cetinkaya Date: 2023-08-04T11:13:03+02:00 New Revision: 31873d3fca38e32a17c2b0aa8975e09aca0f8f89 URL: https://github.com/llvm/llvm-project/commit/31873d3fca38e32a17c2b0aa8975e09aca0f8f89 DIFF: https://github.com/llvm/llvm-project/commit/31873d3fca38e32a17c2b0aa8975e09aca0f8f89.dif

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

This revision was automatically updated to reflect the committed changes. Closed by commit rG31873d3fca38: [include-cleaner] Handle files with unnamed buffers (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157078/new/ https://

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

cor3ntin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2835 if (RHS == 0) { - Info.FFDiag(E, diag::note_expr_divide_by_zero); + Info.FFDiag(E, diag::note_expr_divide_by_zero) << RHSRange; return false; Why not just use `

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

florianhumblot created this revision. florianhumblot added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. florianhumblot requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. When using clangd as

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

tbaeder updated this revision to Diff 547145. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157074/new/ https://reviews.llvm.org/D157074 Files: clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Interp.h clang/test/Misc/constexpr-source-ranges.cpp Index: clang/test/Misc/constexp

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2835 if (RHS == 0) { - Info.FFDiag(E, diag::note_expr_divide_by_zero); + Info.FFDiag(E, diag::note_expr_divide_by_zero) << RHSRange; return fa

[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

florianhumblot updated this revision to Diff 547150. florianhumblot added a comment. Forgot to update the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157080/new/ https://reviews.llvm.org/D157080 Files: clang-tools-extra/clangd/Protocol.cpp clang-tools-extra/clangd/test/sym

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

jcsxky added a comment. In D156693#4560023 , @Michael137 wrote: > Could you please elaborate in the commit message what exactly the issue > currently is and how the patch addresses it? In D156693#4560023 , @M

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

balazske added a comment. The summary tells nothing about what is the real problem to fix here. In the lit test I see that an error message is displayed, this causes the test failure. The problem is that the structural equivalence check is not good for this special case. The imported AST contai

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBitcast.cpp:71 +/// All offsets are in bytes. +struct ByteTracker { + std::vector Initialized; aaron.ballman wrote: > Don't we need to track this at the *bit* level instead of the *byte* level

[PATCH] D157011: [Clang][Tooling] Accept preprocessed input files

jryans updated this revision to Diff 547159. jryans added a comment. - Fixed formatting - Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157011/new/ https://reviews.llvm.org/D157011 Files: clang/lib/Tooling/Tooling.cpp clang/unittests/T

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/InterpBitcast.cpp:71 +/// All offsets are in bytes. +struct ByteTracker { + std::vector Initialized; tbaeder wrote: > aaron.ballman wrote: > > Don't we need to track this at the *bit* level in

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hazohelet added inline comments. Comment at: clang/docs/ReleaseNotes.rst:103-137 +- When describing the failure of static assertion of `==` expression, clang prints the integer + representation of the value as well as its character representation when + the user-provided expre

[PATCH] D156728: [Sema] Ignore nullability qualifiers when deducing types for `auto` and `__auto_type`

gribozavr2 added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3933 // type are ignored for type deduction. + // Ignore top level nullability qualifiers too. ArgType = ArgType.getUnqualifiedType(); ahatanak wrote: > gr

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aaron.ballman added subscribers: jdoerfert, ABataev, rnk. aaron.ballman added a comment. In D150646#4558543 , @aidengrossman wrote: > I'm not opposed to a revert, but I know some downstream users like MinGW have > already adapted to this change so I'm n

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor tweaks (some extra parens to remove, a spurious comment to remove). Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4359 + llvm::fin

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

tianshilei1992 added a comment. Is this patch to support `thread_limit` on `target` directive on the host? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152054/new/ https://reviews.llvm.org/D152054 ___ c

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld __cnfn sqrt(float __x) { + return __builtin_elementwise_sqrt(__x); arsenm wrote: > svenvh wrote: > > Anastasia wrote: > > > Is this a generic implementation

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak created this revision. skatrak added reviewers: kiranchandramohan, jsjodin, domada, agozillon, TIFitis, raghavendhra. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. skatrak requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribe

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

skatrak updated this revision to Diff 547181. skatrak added a comment. Add missing newline at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157090/new/ https://reviews.llvm.org/D157090 Files: clang/docs/tools/clang-formatted-files.t

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:103-137 +- When describing the failure of static assertion of `==` expression, clang prints the integer + representation of the value as well as its character representation when + the user-provided e

[clang] 5d8bbe1 - Reword the intro to the code owners file

Author: Aaron Ballman Date: 2023-08-04T09:09:53-04:00 New Revision: 5d8bbe196a0782f5e003e2ba080745b2111a22f0 URL: https://github.com/llvm/llvm-project/commit/5d8bbe196a0782f5e003e2ba080745b2111a22f0 DIFF: https://github.com/llvm/llvm-project/commit/5d8bbe196a0782f5e003e2ba080745b2111a22f0.diff

[clang] 16a0fc2 - Add my Discord, IRC, and Discourse handles

Author: Aaron Ballman Date: 2023-08-04T09:12:14-04:00 New Revision: 16a0fc2bb81f1d66ff66f08053e45d8857afd66d URL: https://github.com/llvm/llvm-project/commit/16a0fc2bb81f1d66ff66f08053e45d8857afd66d DIFF: https://github.com/llvm/llvm-project/commit/16a0fc2bb81f1d66ff66f08053e45d8857afd66d.diff

[PATCH] D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.

VitaNuo created this revision. Herald added subscribers: carlosgalvezp, kadircet, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

aaron.ballman added a comment. Herald added a subscriber: wangpc. I've not spotted any major concerns with this patch, but I did have some minor nits to look into. I'd love to hear from @rsmith and @erichkeane before signing off on this, as the changes are pretty involved and they've both done s

[clang] 5d49276 - [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.

Author: Viktoriia Bakalova Date: 2023-08-04T14:15:01Z New Revision: 5d492766a8fbfadb39c9830ebb64137edddfe0e5 URL: https://github.com/llvm/llvm-project/commit/5d492766a8fbfadb39c9830ebb64137edddfe0e5 DIFF: https://github.com/llvm/llvm-project/commit/5d492766a8fbfadb39c9830ebb64137edddfe0e5.diff

[PATCH] D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d492766a8fb: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 547206. cor3ntin marked an inline comment as done. cor3ntin added a comment. Fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://reviews.llvm.org/D153536 Files: clang/docs/ReleaseNote

[clang] a8bef88 - [Clang] Implement P2169 A nice placeholder with no name

Author: Corentin Jabot Date: 2023-08-04T16:51:15+02:00 New Revision: a8bef8865e4a4226ee608df327fddd380870c620 URL: https://github.com/llvm/llvm-project/commit/a8bef8865e4a4226ee608df327fddd380870c620 DIFF: https://github.com/llvm/llvm-project/commit/a8bef8865e4a4226ee608df327fddd380870c620.diff

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8bef8865e4a: [Clang] Implement P2169 A nice placeholder with no name (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

donat.nagy created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. donat.nagy requested review of this revi

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

donat.nagy added a comment. Note: this commit is split off from the larger commit https://reviews.llvm.org/D150446, which combined this simple improvement with other, more complex changes that had problematic side-effects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D156320: [FLang] Add support for Rpass flag

awarzynski added a comment. Hey @victorkingi , thank you for working on this :) There's quite a lot going on here and I am thinking that it might be good to split this into a few patches? Also, please note that Flang's driver, unlike Clang, uses MLIR's coding style (use `camelCase` instead of `

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 547231. Krishna-13-cyber added a comment. - Addressed the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst clang/

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy abandoned this revision. donat.nagy added a comment. Herald added a subscriber: wangpc. I'm abandoning this commit because it amalgamates several unrelated changes and I think it'd be better to handle them separately: 1. First, there is a very simple, independent improvement related t

[clang] df6b35e - Fix Clang Sphinx bot

Author: Aaron Ballman Date: 2023-08-04T11:43:35-04:00 New Revision: df6b35e329ebecad6dc3bfb83183e482eb7a0020 URL: https://github.com/llvm/llvm-project/commit/df6b35e329ebecad6dc3bfb83183e482eb7a0020 DIFF: https://github.com/llvm/llvm-project/commit/df6b35e329ebecad6dc3bfb83183e482eb7a0020.diff

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

donat.nagy added reviewers: dkrupp, steakhal, Szelethus, gamesh411. donat.nagy added a comment. I'll try to upload results on open source projects, probably on Tuesday (I'm on vacation on Monday). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15710

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 547241. capfredf marked 2 inline comments as done. capfredf added a comment. changes per discussions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/i

[PATCH] D157114: [clang][ASTImporter] Improve StructuralEquivalence algorithm on repeated friends

danix800 created this revision. danix800 added reviewers: balazske, steakhal, aaron.ballman, shafik, martong. Herald added a reviewer: a.sidorin. Herald added a project: All. danix800 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repeated

[PATCH] D157114: [clang][ASTImporter] Improve StructuralEquivalence algorithm on repeated friends

steakhal resigned from this revision. steakhal added a comment. In general, I'm not really involved with the ASTImporter. Please, put me as a reviewer if the ASTImporter directly affects the Static Analyzer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

steakhal added a comment. In D150446#4560892 , @donat.nagy wrote: > I'm abandoning this commit because it amalgamates several unrelated changes > and I think it'd be better to handle them separately: > > 1. First, there is a very simple, independent imp

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

bnbarham added a comment. In D148997#4559788 , @v.g.vassilev wrote: > I'd prefer to avoid adding a new flag. Is there a way to see how does the > diff looks like? You mean for a new flag? I don't have one prepared, but it would basically just be addin

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. In D148997#4561015 , @bnbarham wrote: > In D148997#4559788 , @v.g.vassilev > wrote: > >> I'd prefer to avoid adding a new flag. Is there a way to see how does the >> diff looks like

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

aidengrossman created this revision. Herald added a project: All. aidengrossman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit 2df77ac20a1ed996706b164b0c4ed5ad140f635f

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

bnbarham added a comment. In D148997#4561022 , @v.g.vassilev wrote: > I meant that I'd like to figure out if we could use the > `annot_repl_input_end` before considering a new flag. Oh sure, that's why I'm here :). Just trying to figure out what we thi

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

aidengrossman added a comment. Assuming everyone agrees to this going in, I'll land it and then open a backport for the 17 release and reland once the auxiliary triple issues are resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157115/new/

[PATCH] D156948: [clang][modules] Add -Wsystem-headers-in-module=

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/DiagnosticOptions.h:128 + /// whether -Wsystem-headers is enabled on a per-module basis. + std::vector SystemHeaderWa

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. eandrews requested review of this revision.

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547265. evelez7 added a comment. Format DeclarationFragments.h, try to address buildbot fail on clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 Files:

[PATCH] D156948: [clang][modules] Add -Wsystem-headers-in-module=

benlangmuir updated this revision to Diff 547266. benlangmuir added a comment. Use `llvm::is_contained` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156948/new/ https://reviews.llvm.org/D156948 Files: clang/include/clang/Basic/DiagnosticOptions.h clang/include/clang/Driver/Options

[PATCH] D156948: [clang][modules] Add -Wsystem-headers-in-module=

benlangmuir marked an inline comment as done. benlangmuir added inline comments. Comment at: clang/include/clang/Basic/DiagnosticOptions.h:128 + /// whether -Wsystem-headers is enabled on a per-module basis. + std::vector SystemHeaderWarningsModules; + jansvobo

[PATCH] D156378: [clang][CGExprConstant] handle unary negation on integrals

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156378/new/ https://reviews.llvm.org/D156378 ___

[PATCH] D156466: [clang][CGExprConstant] handle implicit widening/narrowing Int-to-Int casts

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156466/new/ https://reviews.llvm.org/D156466 ___

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs created this revision. jroelofs added a reviewer: steven_wu. Herald added subscribers: PiotrZSL, kadircet, steakhal, carlosgalvezp, abrachet, martong, arphaman, kbarton, nemanjai. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added a project: All. jroelofs reques

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. related discussion: https://discourse.llvm.org/t/rfc-permanently-fixing-the-missing-tablegen-dependency-issue/70442/14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119 __

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

steven_wu accepted this revision. steven_wu added subscribers: aprantl, dblaikie. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. @aprantl @dblaikie who cares about module builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers added a comment. (I am working on rebasing this; tests need updating for opaque ptr) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commi

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. In D148997#4561068 , @bnbarham wrote: > In D148997#4561022 , @v.g.vassilev > wrote: > >> I meant that I'd like to figure out if we could use the >> `annot_repl_input_end` before con

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

nickdesaulniers updated this revision to Diff 547271. nickdesaulniers retitled this revision from "[IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas" to "Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas". nickdesaulniers edited the s

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

DmitryPolukhin added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. @ldionne and @dexonsmith, it seems that this diff breaks clang-tools like clang-tidy and clangd if `-isysroot` is specified in the compilation database. Moreover, clang from Xcode 14 and 15 uses path

[clang] 2fb1c10 - cmake: add missing dependencies on ClangDriverOptions tablegen

Author: Jon Roelofs Date: 2023-08-04T10:27:19-07:00 New Revision: 2fb1c1082c01ddf9b2531083196ff2dace1fdab7 URL: https://github.com/llvm/llvm-project/commit/2fb1c1082c01ddf9b2531083196ff2dace1fdab7 DIFF: https://github.com/llvm/llvm-project/commit/2fb1c1082c01ddf9b2531083196ff2dace1fdab7.diff L

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fb1c1082c01: cmake: add missing dependencies on ClangDriverOptions tablegen (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. back-porting to the release branch: https://github.com/llvm/llvm-project/issues/64432 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119 ___

[clang] 3d756c3 - cmake: add missing dependencies on ClangDriverOptions tablegen

Author: Jon Roelofs Date: 2023-08-04T10:43:31-07:00 New Revision: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd URL: https://github.com/llvm/llvm-project/commit/3d756c32cdf005d0f4c05f561fec4a37b64b7ddd DIFF: https://github.com/llvm/llvm-project/commit/3d756c32cdf005d0f4c05f561fec4a37b64b7ddd.diff L

[PATCH] D157029: [llvm] Construct option spelling at compile-time

benlangmuir added inline comments. Comment at: llvm/include/llvm/Option/Option.h:103 + StringLiteral getSpelling() const { +assert(Info && "Must have a valid info!"); This could use a doc comment to differentiate it from other string representations. How

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

jroelofs added a comment. missed one more: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119 _

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM though there may be some additional changes worth considering; I don't insist on changes though. Comment at: clang/lib/AST/StmtPrinter.cpp:178 void StmtP

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

saiislam marked 2 inline comments as done. saiislam added a comment. In D156928#4555121 , @yaxunl wrote: > `-mcode-object-version=none` was intentionally designed to work with `clang > -cc1` only, since it does not work with clang driver if users link wi

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 547297. saiislam added a comment. Another attempt at cov5 support by using CodeGen for buitlin_amdgpu_workgroup_size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D139730

[PATCH] D157029: [llvm] Construct option spelling at compile-time

jansvoboda11 updated this revision to Diff 547298. jansvoboda11 added a comment. Improve `Option::getPrefixedName()` instead of introducing new `Option::getSpelling()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Option/Option.h:103 + StringLiteral getSpelling() const { +assert(Info && "Must have a valid info!"); benlangmuir wrote: > This could use a doc comment to differentiate it from other string

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

MaskRay added a comment. This increases the size of `Info` (static data size and static relocations). In return, some dynamic relocations are saved. Is this a net win? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

aaron.ballman added a comment. Thank you for this! The revert LGTM, but please wait for @mstorsjo to confirm this won't cause problems for MinGW folks. In terms of solving the underlying issue with aux triple so that we can re-land this, I went digging to see if there's an existing issue tracki

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

bnbarham added a comment. In D148997#4561211 , @v.g.vassilev wrote: https://github.com/llvm/llvm-project/blob/df6b35e329ebecad6dc3bfb83183e482eb7a0020/clang/lib/Parse/ParseExprCXX.cpp#L4070 >>> >>> That looks a bit obscure to me. Looks like we are t

[PATCH] D157033: [clang][CFG] Fix 2 memory errors in interval computation.

ymandel updated this revision to Diff 547305. ymandel added a comment. rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157033/new/ https://reviews.llvm.org/D157033 Files: clang/lib/Analysis/IntervalPartition.cpp clang/unittests/

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 added a comment. In D157029#4561490 , @MaskRay wrote: > This increases the size of `Info` (static data size and static relocations). > In return, some dynamic relocations are saved. Is this a net win? If that's a concern, I can remove `Inf

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 547304. koops added a comment. 1. Support for PCH Serilization/deserilization for the PrevMapLoopConstruct variable in OMPExecutableDirective. 2. Modification of clang/test/PCH/pragma-loop.cpp to include "#pragma omp loop bind" with different parameters for bi

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17146 +Value *ABIVersion; +if (ABIVersionC) { + ABIVersion = CGF.Builder.CreateAlignedLoad(CGF.Int32Ty, ABIVersionC, this must always pass Comment at: openmp

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added a comment. Could you explain briefly what the approach here is? I'm confused as to what's actually changed and how we're handling this difference. I thought if this was just the definition of some builtin function we could just rely on the backend to figure it out. Why do we need

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 ___ cfe-commits mailing list cfe-commits@l

  1   2   >