[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoScatter XinWang10 wrote: > ska

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo marked an inline comment as done. mstorsjo added a comment. Thanks a lot for the guidance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157332/new/ https://reviews.llvm.org/D157332 ___ cfe-comm

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo updated this revision to Diff 549575. mstorsjo added a comment. Move the existing comment into the new if statement, add a comment to the new if. Add a comment to the second part of the testcase, which probably is good to keep anyway. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 549572. iana added a comment. Let clang-format update stddef.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang/lib/Headers/stddef.h clang/test/Headers/s

[clang] c053345 - [clang] Fix typos in documentation

Author: Kazu Hirata Date: 2023-08-11T21:44:33-07:00 New Revision: c053345b059bd3fa7f0e5f51498c71095b7a1d88 URL: https://github.com/llvm/llvm-project/commit/c053345b059bd3fa7f0e5f51498c71095b7a1d88 DIFF: https://github.com/llvm/llvm-project/commit/c053345b059bd3fa7f0e5f51498c71095b7a1d88.diff L

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 marked 4 inline comments as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549571. XinWang10 added a comment. - resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16899 + uint32_t CodePoint = static_cast(V.getInt().getZExtValue()); + PrintCharLiteralPrefix(BTy->getKind(), OS); + OS << '\''; hubert.reinterpre

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

hubert.reinterpretcast added inline comments. Comment at: clang/test/Parser/c2x-attributes.c:29 +[[deprecated(L"abc")]] void unevaluated_string(void); +// expected-warning@-1 {{encoding prefix 'L' on an unevaluated string literal has no effec}} + "Typo" fix. =

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

brad created this revision. brad added a reviewer: nielx. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Here is a first cut at moving the Haiku header search path management to the driver as has be

[PATCH] D155986: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

JonChesterfield added a comment. Thanks! Happy to see function calls getting cheaper Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155986/new/ https://reviews.llvm.org/D155986 ___ cfe-commits mailing lis

[PATCH] D157331: [clang] Implement C23

ZijunZhao added a comment. In D157331#4576540 , @aaron.ballman wrote: > In D157331#4575224 , @ZijunZhao > wrote: > >> Another followup question: I check >> https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2683

[clang] 182de29 - Add argument to static_assert() call to work with compilers that default to c++14 or earlier.

Author: Douglas Yung Date: 2023-08-11T17:54:58-07:00 New Revision: 182de296f7bac49c655304d5c9f6b0edadf48302 URL: https://github.com/llvm/llvm-project/commit/182de296f7bac49c655304d5c9f6b0edadf48302 DIFF: https://github.com/llvm/llvm-project/commit/182de296f7bac49c655304d5c9f6b0edadf48302.diff

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman added a comment. The main issue here is that there's no way to reliably detect whether the built in is defined (can't check if a function is defined in the preprocessor, preprocessor macro isn't exposed correctly in all configurations), which ends up breaking some configurations.

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16930-16936 +case BuiltinType::Char_S: +case BuiltinType::Char_U: +case BuiltinType::Char8: +case BuiltinType::Char16: +case BuiltinType::Char32: +

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

rnk added a comment. I think MSVC defines `_MSC_EXTENSIONS` under one of its compatibility modes as well, so it's not a good indicator of "is this compiler MSVC-like". I think we should be exposing the `__cpudex` builtin any time we are being MSVC-like, not under `fms-compatibility`. Would that

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 549547. iana marked an inline comment as done. iana added a comment. Update the tests to handle diagnostics from stddef.h Fix stddef.h to support defining __STDC_WANT_LIB_EXT1__ if stddef.h has already been included Repository: rG LLVM Github Monorepo CHANG

[PATCH] D155986: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd77c62053c94: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI (authored by cfang). Herald added a project: clang. Herald added

[clang] d77c620 - [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

Author: Changpeng Fang Date: 2023-08-11T16:37:42-07:00 New Revision: d77c62053c944652846c00a35c921e14b43b1877 URL: https://github.com/llvm/llvm-project/commit/d77c62053c944652846c00a35c921e14b43b1877 DIFF: https://github.com/llvm/llvm-project/commit/d77c62053c944652846c00a35c921e14b43b1877.diff

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

arsenm closed this revision. arsenm added a comment. 9e3d9c9eae03910d93e2312e1e0845433c779998 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156737/new/ https://reviews.llvm.org/D156737 __

[clang] 9e3d9c9 - clang: Add __builtin_elementwise_sqrt

Author: Matt Arsenault Date: 2023-08-11T19:32:39-04:00 New Revision: 9e3d9c9eae03910d93e2312e1e0845433c779998 URL: https://github.com/llvm/llvm-project/commit/9e3d9c9eae03910d93e2312e1e0845433c779998 DIFF: https://github.com/llvm/llvm-project/commit/9e3d9c9eae03910d93e2312e1e0845433c779998.diff

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16899 + uint32_t CodePoint = static_cast(V.getInt().getZExtValue()); + PrintCharLiteralPrefix(BTy->getKind(), OS); + OS << '\''; cor3ntin wrote: >

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

rnk added a comment. What are the next steps here? Have concerns been addressed? The CI failures seem unrelated (libcxx tests is an AIX bot out of disk, clang CI is an interpreter test that seems unrelated, but please confirm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added inline comments. Comment at: clang/test/Headers/stddef.c:20-23 +// rsize_t will only be defined if __STDC_WANT_LIB_EXT1__ is set to >= 1. +// It would be nice to test the default undefined behavior, but that emits +// a note comin

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Thanks! My concerns are addressed, but please confirm that Eli's are too. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -if (var->

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

efriedma added inline comments. Comment at: clang/test/Headers/stddef.c:20-23 +// rsize_t will only be defined if __STDC_WANT_LIB_EXT1__ is set to >= 1. +// It would be nice to test the default undefined behavior, but that emits +// a note coming from stddef.h "rsize_t, did you m

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

akhuang created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This attribute should match the behavior of MSVC's [[msvc::no_unique_address]] attr

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana added inline comments. Comment at: clang/test/Headers/stddefneeds.c:85-87 +// __need_nullptr_t generates an error in https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 ___ cfe-commits mailing list cfe-commits@

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

tra added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions shenh

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added inline comments. Comment at: clang/test/Headers/stddef.c:20-23 +// rsize_t will only be defined if __STDC_WANT_LIB_EXT1__ is set to >= 1. +// It would be nice to test the default undefined behavior, but that emits +// a note comin

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 ___

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added inline comments. Comment at: clang/lib/Headers/stddef.h:112 #if defined(_MSC_EXTENSIONS) && defined(_NATIVE_NULLPTR_SUPPORTED) -namespace std { typedef decltype(nullptr) nullptr_t; } -using ::std::nullptr_t; +// __need_NULL would

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana updated this revision to Diff 549534. iana added a comment. Don't define nullptr_t in C++ if __need_NULL is set without __need_nullptr_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 Files: clang

[clang] 368a0ac - Revert part of "[test][asan] Disable new test from D157552 on Android"

Author: Vitaly Buka Date: 2023-08-11T15:07:29-07:00 New Revision: 368a0acea56e8f89860f5a64b4d0587bce6cff54 URL: https://github.com/llvm/llvm-project/commit/368a0acea56e8f89860f5a64b4d0587bce6cff54 DIFF: https://github.com/llvm/llvm-project/commit/368a0acea56e8f89860f5a64b4d0587bce6cff54.diff L

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

arsenm added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1281-1282 +else + WithColor::warning() + << "-fsplit-machine-functions is only valid for X86.\n"; } You cannot spam warnings here. The other instance of printing

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

efriedma added inline comments. Comment at: clang/lib/Headers/stddef.h:112 #if defined(_MSC_EXTENSIONS) && defined(_NATIVE_NULLPTR_SUPPORTED) -namespace std { typedef decltype(nullptr) nullptr_t; } -using ::std::nullptr_t; +// __need_NULL would previously define nullptr_t for C+

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1278 } -addPass(createMachineFunctionSplitterPass()); +if (TM->getTargetTriple().isX86()) + addPass(createMachineFunctionSplitterPass()); snehasish wrote: > Can you

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions t

[PATCH] D157747: Support Unicode Microsoft predefined macros

RIscRIpt added a comment. This implementation preserves support for identifiers `L__FUNCSIG__` and `L__FUNCTION__` (which have never been supported by MSVC), and adds other identifiers for all supported encodings: L, u8, u, U. If breaking backwards compatibility in clang (with Microsoft Extensi

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana created this revision. iana added reviewers: aaron.ballman, rsmith, steplong, efriedma, jyknight, erichkeane. Herald added a subscriber: ributzka. Herald added a project: All. iana requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang.

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

efriedma added a comment. This approach looks fine. Comment at: clang/lib/CodeGen/CGCall.cpp:5781 // If the value is offset in memory, apply the offset now. + if (!isEmptyRecord(getContext(), RetTy, true)) { The isEmptyRecord call could use a comm

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

mstorsjo updated this revision to Diff 549517. mstorsjo added a comment. Updated to just check isEmptyRecord in EmitCall. The second part of the test probably is kinda redundant/pointless at this point, and I guess the test comment needs updating too; can do that later when the implementation i

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

tra added a comment. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:9 + +// Check that -fsplit-machine-functions is passed to both x86 and cuda compilation and does not cause driver error. +// MFS2: -fsplit-machine-functions We will

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

snehasish added a subscriber: dhoekwater. snehasish added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1278 } -addPass(createMachineFunctionSplitterPass()); +if (TM->getTargetTriple().isX86()) + addPass(createMachineFunctionSplitterPass());

[PATCH] D157661: [clang][NFC] Robustify testcase

This revision was automatically updated to reflect the committed changes. Closed by commit rGe789bcbb967f: [clang][NFC] Robustify testcase (authored by urnathan). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] e789bcb - [clang][NFC] Robustify testcase

Author: Nathan Sidwell Date: 2023-08-11T15:59:52-04:00 New Revision: e789bcbb967f391d4f641bc8fa0403a45039a592 URL: https://github.com/llvm/llvm-project/commit/e789bcbb967f391d4f641bc8fa0403a45039a592 DIFF: https://github.com/llvm/llvm-project/commit/e789bcbb967f391d4f641bc8fa0403a45039a592.diff

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

ellis added a comment. In D157632#4580576 , @zequanwu wrote: > BTW, I noticed something strange with `-pgo-function-entry-coverage` when > merging via llvm-profdata. This is intentional. The two raw profiles individually store blocks as either covered

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2697 +bool SanitizeBuiltin = SanOpts.has(SanitizerKind::Builtin); +bool SanitizeOverflow = SanOpts.has(SanitizerKind::SignedIntegerOverflow); + artem wrote: > efriedma wrote: > >

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan created this revision. shenhan added reviewers: xur, snehasish. Herald added subscribers: mattd, asavonic, pengfei, hiraditya. Herald added a project: All. shenhan requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang,

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

efriedma added a comment. You can't, in general, check whether a type is stored in a no_unique_address field. Consider the following; the bad store is in the constructor S2, but the relevant no_unique_address attribute doesn't even show up until the definition of S3. struct S {}; S f();

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

arsenm updated this revision to Diff 549490. arsenm added a comment. Release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156737/new/ https://reviews.llvm.org/D156737 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Builtins.def

[PATCH] D157040: [OpenMP][IR] Set correct alignment for internal variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGc384e79675fe: [OpenMP][IR] Set correct alignment for internal variables (authored by erjin, committed by congzhe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] c384e79 - [OpenMP][IR] Set correct alignment for internal variables

Author: Hao Jin Date: 2023-08-11T15:20:15-04:00 New Revision: c384e79675fe44cd2651dbd9d506d0a421c37533 URL: https://github.com/llvm/llvm-project/commit/c384e79675fe44cd2651dbd9d506d0a421c37533 DIFF: https://github.com/llvm/llvm-project/commit/c384e79675fe44cd2651dbd9d506d0a421c37533.diff LOG:

[PATCH] D156726: Make globals with mutable members non-constant, even in custom sections

efriedma added a comment. Sure, diverging from MSVC here seems fine. I agree it's unlikely anyone would actually want to put a variable that will be modified in a "const" section. Comment at: clang/lib/Sema/SemaDecl.cpp:14254 int SectionFlags = ASTContext::PSF_Read; -

[PATCH] D157747: Support Unicode Microsoft predefined macros

RIscRIpt created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, martong. Herald added a reviewer: shafik. Herald added a reviewer: njames93. Herald added a project: All. RIscRIpt requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a su

[PATCH] D155794: [OpenMP][OpenMPIRBuilder] Migrate setPropertyExecutionMode() from Clang to OpenMPIRBuilder.

raghavendhra abandoned this revision. raghavendhra added a comment. setPropertyExecutionMode function is no longer present / used in clang because of a change in https://reviews.llvm.org/D142569 So abandoning this patch to migrate that function into OMPIRBuilder. Repository: rG LLVM Github M

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman added a comment. In D156565#4580716 , @Endill wrote: > In D156565#4547909 , @aaron.ballman > wrote: > >> In D156565#4543503 , >> @aaron.ballman wrote: >> >

[PATCH] D157130: [RISCV] Check type size for lax conversions between RVV builtin types and VectorType::RVVFixedLengthDataVector.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157130/new/ https://reviews.llvm.org/D157130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:809-811 + Updater.AddAvailableValue( + Alloca.getParent(), + getInitialValueOfAllocation(&Alloca, nullptr, VectorTy)); arsenm wrote: > This is very specifically h

[PATCH] D157738: [OpenMP] Emit offloading entries for indirect target variables

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo, ABataev, RaviNarayanaswamy. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cjdb added inline comments. Comment at: clang/test/SemaCXX/warn-constant-evaluated-constexpr.cpp:38 constexpr int fn5() { - if constexpr (__builtin_is_constant_evaluated()) // expected-warning {{'__builtin_is_constant_evaluated' will always evaluate to 'true' in a manifestly

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Anastasia added inline comments. Comment at: llvm/unittests/TargetParser/TripleTest.cpp:1307 + EXPECT_TRUE(T.isSPIRV()); + T.setArch(Triple::spirv32); pmatos wrote: > Keenuts wrote: > > pmatos wrote: > > > I am not well-versed in SPIRV for gfx but if we are u

[PATCH] D156565: Diagnose use of VLAs in C++ by default

Endill added a comment. In D156565#4547909 , @aaron.ballman wrote: > In D156565#4543503 , @aaron.ballman > wrote: > >> In D156565#4543414 , @jrtc27 wrote: >> >>> Given G

[PATCH] D156737: clang: Add __builtin_elementwise_sqrt

bob80905 added a comment. Shouldn't this new builtin be mentioned in Release Notes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156737/new/ https://reviews.llvm.org/D156737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575 + // If we are here with a 'target teams loop' then we are emitting the + // 'parallel' region of the 'target teams distribute parallel for' + // emitted in place of the 'target teams loop'

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:122 llvm::DenseSet SeenSymbols; + std::string ResourceDir = HS->getHeaderSearchOpts().ResourceDir; // FIXME: Find a way to have less code duplication b

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 549449. yronglin added a comment. Only create addational metarialized temporary in for-range-init. FIXME: Need to handle function default argument, and add more test to make sure the generated LLVM IR is correct. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D157197: [clang][CodeGen][OpenMP] Fix if-clause for 'target teams loop'

ddpagan added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575 + // If we are here with a 'target teams loop' then we are emitting the + // 'parallel' region of the 'target teams distribute parallel for' + // emitted in place of the 'target teams loop'

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:809-811 + Updater.AddAvailableValue( + Alloca.getParent(), + getInitialValueOfAllocation(&Alloca, nullptr, VectorTy)); This is very specifically handling alloca, n

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 549443. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 Files: clang-too

[PATCH] D150647: [WIP][analyzer] Fix EnumCastOutOfRangeChecker C++17 handling

steakhal added a comment. Isn't D153954 superseded this one? If so, consider abandoning it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150647/new/ https://reviews.llvm.org/D150647

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155773/new/ https://reviews.llvm.org/D155773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154603: [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker

steakhal added a comment. I'm sorry starting the review of this one only now, but I'm quite booked. Is it still relevant? If so, I'll continue. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp:116-117 +const NoteTag *Note = +C.getNoteTag([Reg

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. BTW, I noticed something strange with `-pgo-function-entry-coverage` when merging via llvm-profdata. In this file `compiler-rt/test/profile/Linux/instrprof-debug-info-correlate.c`, I ran the following: // RUN: %clang_pgogen -o %t.cov.normal -mllvm --pgo-function-entr

[PATCH] D157684: [clang][ASTImporter] Repeated friend templates are partially imported

danix800 updated this revision to Diff 549436. danix800 added a comment. Turn off `Complain` mode on `IsEquivalentFriend` checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157684/new/ https://reviews.llvm.org/D157684 Files: clang/lib/AST/A

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

Mordante accepted this revision as: libc++. Mordante added a comment. I only looked at the libc++ changes. The libc++ AIX CI failures are unrelated to your patch. LGTM modulo one nit. Comment at: libcxx/test/std/utilities/utility/pairs/pairs.pair/ctor.pair_U_V_move.pass.cpp:1

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. As I don't use this checker, thus I cannot speak of my experience. However, the reasons look solid and I'm fine with moving this checker to `unix.StdCLibraryFunctions`. Let some time for ot

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been rev

[clang-tools-extra] 887bece - [clang-tidy][NFC] Update clang-analyzer-cplusplus.PlacementNew doc

Author: Piotr Zegar Date: 2023-08-11T16:06:45Z New Revision: 887bece66c80fe2bc3f9010f34f4fccf0a2f964e URL: https://github.com/llvm/llvm-project/commit/887bece66c80fe2bc3f9010f34f4fccf0a2f964e DIFF: https://github.com/llvm/llvm-project/commit/887bece66c80fe2bc3f9010f34f4fccf0a2f964e.diff LOG: [

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGa3a66de37fc0: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D157649: [clang-tidy] Fix crash when diagnostic is emit with invalid location

This revision was automatically updated to reflect the committed changes. Closed by commit rGefd44f80a5a8: [clang-tidy] Fix crash when diagnostic is emit with invalid location (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1576

[clang-tools-extra] efd44f8 - [clang-tidy] Fix crash when diagnostic is emit with invalid location

Author: Piotr Zegar Date: 2023-08-11T16:04:15Z New Revision: efd44f80a5a8194b9fe26ff3244ce702cd8dab73 URL: https://github.com/llvm/llvm-project/commit/efd44f80a5a8194b9fe26ff3244ce702cd8dab73 DIFF: https://github.com/llvm/llvm-project/commit/efd44f80a5a8194b9fe26ff3244ce702cd8dab73.diff LOG: [

[clang] a3a66de - [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

Author: Piotr Zegar Date: 2023-08-11T16:04:15Z New Revision: a3a66de37fc038d46d7146c9dfe55f26fd3a URL: https://github.com/llvm/llvm-project/commit/a3a66de37fc038d46d7146c9dfe55f26fd3a DIFF: https://github.com/llvm/llvm-project/commit/a3a66de37fc038d46d7146c9dfe55f26fd3a.diff LOG: [

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added a comment. In D157632#4578582 , @ellis wrote: > I've just published https://reviews.llvm.org/D157664, so you'll want to > rebase ontop of it if it lands soon. I would also like to see some more tests > added to `instrprof-merge-error.c` t

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

steakhal accepted this revision. steakhal added a comment. Looks safe and good. I'm interested in the diff though. Let me know once you have the results. I wanna have a look before we land this. Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:184 +// s

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu added inline comments. Comment at: compiler-rt/lib/profile/InstrProfilingMerge.c:129 + // enabled. + if (Header->DataSize == 0) { +if (!(__llvm_profile_get_version() & VARIANT_MASK_DBG_CORRELATE)) { ellis wrote: > Since we don't have the data secti

[PATCH] D157632: [Profile] Allow online merging with debug info correlation.

zequanwu updated this revision to Diff 549424. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157632/new/ https://reviews.llvm.org/D157632 Files: clang/lib/Cod

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

steakhal added a comment. In D157702#4580384 , @PiotrZSL wrote: > In D157702#4580310 , @steakhal > wrote: > >> Do we have other typos like this? > > I don't think so, only mess in overall documentation: > https:

[PATCH] D141714: Fix ast print of variables with attributes

strimo378 added a comment. @aaron.ballman I had today a teams meeting with @giulianobelinassi and we discussed both patches as well as that we want to work together in improving AST print. Both patches are fine for us since they improve the attribute printing. The features of the respective oth

[PATCH] D155081: Specify the developer policy around links to external resources

tahonermann added a comment. This looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155081/new/ https://reviews.llvm.org/D155081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

PiotrZSL added a comment. In D157702#4580310 , @steakhal wrote: > Do we have other typos like this? I don't think so, only mess in overall documentation: https://github.com/llvm/llvm-project/issues/64614 I updated gen-static-analyzer-docs.py, and it sho

[PATCH] D157727: [clang] Fix copy-and-paste error in CXXRecordDecl tabledef

cblichmann created this revision. cblichmann added reviewers: clang, rsmith, zahiraam. cblichmann added a project: clang. Herald added a project: All. cblichmann requested review of this revision. Herald added a subscriber: cfe-commits. This change just updates the comment in the tabledef, no chan

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

steakhal added a comment. Do we have other typos like this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157702/new/ https://reviews.llvm.org/D157702 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D157702: [clang][analyzer][NFC] Change PlacementNewChecker into PlacementNew in documentation

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Correct. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157702/new/ https://reviews.llvm.org/D157702 ___

[PATCH] D155081: Specify the developer policy around links to external resources

rZhBoYao added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewed

[PATCH] D157517: [AArch64][SVE] Add asm predicate constraint Uph

This revision was automatically updated to reflect the committed changes. Closed by commit rGc52d9509d40d: [AArch64][SVE] Add asm predicate constraint Uph (authored by MattDevereau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157517/new/ https://

[clang] c52d950 - [AArch64][SVE] Add asm predicate constraint Uph

Author: Matt Devereau Date: 2023-08-11T14:48:19Z New Revision: c52d9509d40d3048914b144618232213e6076e05 URL: https://github.com/llvm/llvm-project/commit/c52d9509d40d3048914b144618232213e6076e05 DIFF: https://github.com/llvm/llvm-project/commit/c52d9509d40d3048914b144618232213e6076e05.diff LOG:

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

skan added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoScatter Does "Prefer no gather in

[PATCH] D157637: [ASTImporter][NFC] Fix typo in testcase

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafff91de082d: [ASTImporter][NFC] Fix typo in testcase (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D157584: [clang][Sema] Skip access check on arrays of zero-length element

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f73a2406a16: [clang][Sema] Skip access check on arrays of zero-length element (authored by dingfei ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

  1   2   >