[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy updated this revision to Diff 549688. Pivnoy added a comment. Herald added subscribers: luke, pmatos, frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal, johnruss

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

Arsenic created this revision. Arsenic added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. Arsenic requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Create and use extractapi::RecordLocation instead

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

Arsenic updated this revision to Diff 549691. Arsenic added a comment. Fix minor typo in code comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157810/new/ https://reviews.llvm.org/D157810 Files: clang/include/clang/ExtractAPI/API.h clang

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong semant

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

steakhal added a comment. I notices some inconsistency between this `-fstrict-flex-arrays=N` flag and what the `RecordDecl::hasFlexibleArrayMember()` returns for an example like this: typedef unsigned long size_t; void *malloc(size_t); void free(void *); void field(void) { struct

[clang] 094539c - Fix Wdocumentation "unknown parameter". NFC.

Author: Simon Pilgrim Date: 2023-08-13T11:33:00+01:00 New Revision: 094539cfcb46f55824402565e5c18580df689a67 URL: https://github.com/llvm/llvm-project/commit/094539cfcb46f55824402565e5c18580df689a67 DIFF: https://github.com/llvm/llvm-project/commit/094539cfcb46f55824402565e5c18580df689a67.diff

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers @alexguirre Please post your full name / email and I'll commit this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15742

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher added inline comments. Comment at: clang/docs/ClangRepl.rst:393-396 + +.. image:: autoprint.png + :align: center + :alt: autoprint design Please replace the image reference with the following Graphviz code (do not delete the image .png for now, w

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

v.g.vassilev added inline comments. Comment at: clang/docs/ClangRepl.rst:221 + +Execution Results Handling features discussed below help extend the Clang-REPL +functionality by creating an interface between the execution results of a We should probably spell co

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

alexguirre added a comment. Alejandro Aguirre alexguirre...@gmail.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157420/new/ https://reviews.llvm.org/D157420 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher added a comment. @Krishna-13-cyber added Graphviz code snippets to replace all .png images Comment at: clang/docs/ClangRepl.rst:248-250 +.. image:: valuesynth.png + :align: center + :alt: valuesynth design v.g.vassilev wrote: > Can we replace t

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 created this revision. kaz7 added a reviewer: efocht. kaz7 added projects: clang, VE. Herald added a project: All. kaz7 requested review of this revision. Herald added subscribers: cfe-commits, wangpc, MaskRay. Change to enable VPU flag for VE by default in order to support vector intrinsics

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 549715. yronglin added a comment. Handle default argument and dependent context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 Files: clang/include/clang/Sema/Se

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

serge-sans-paille updated this revision to Diff 549717. serge-sans-paille added a comment. Fix typo in example CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157808/new/ https://reviews.llvm.org/D157808 Files: clang/include/clang/AST/JSONNodeDumper.h clang/lib/AST/JSONNodeDumper.cpp

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. FIXME: Need add test in `clang/test/CXX/special/class.temporary/p6.cpp` to check generated LLVM IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 _

[PATCH] D157814: [clang] Add missing field to TLSModelAttr json AST dump

serge-sans-paille created this revision. serge-sans-paille added a reviewer: aaron.ballman. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://review

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added a comment. Should we dump the real default argument AST but not only `CXXDefaultArgExpr` if `CXXDefaultArgExpr` has been rewritted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701

[PATCH] D157817: [clang] Fix ClangScanDeps test for #61006.

ingomueller-net created this revision. ingomueller-net added a reviewer: ChuanqiXu. Herald added a project: All. ingomueller-net requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch solves two problems with the recently added test, wh

[clang] 1800038 - [clang] Fix ClangScanDeps test for #61006.

Author: Ingo Müller Date: 2023-08-13T18:23:34Z New Revision: 1800038fba42741c4013c64ee307611251118ee3 URL: https://github.com/llvm/llvm-project/commit/1800038fba42741c4013c64ee307611251118ee3 DIFF: https://github.com/llvm/llvm-project/commit/1800038fba42741c4013c64ee307611251118ee3.diff LOG: [

[PATCH] D157817: [clang] Fix ClangScanDeps test for #61006.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1800038fba42: [clang] Fix ClangScanDeps test for #61006. (authored

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

nielx added a comment. I will test the patch and see if it works as expected. Note that we currently have the following preset header paths in our GCC port

[PATCH] D157568: [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:177 llvm::Regex("^/[/*] *(end (of )?)? *(anonymous|unnamed)? *" -

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 549739. capfredf added a comment. Herald added a subscriber: ChuanqiXu. changes per discussions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/includ

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.h:91 + +class IncrementalSyntaxOnlyAction : public SyntaxOnlyAction { + const CompilerInstance *ParentCI; Can we not move this class definition locally to the CodeComplete in

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added a reviewer: sammccall. v.g.vassilev added a subscriber: sammccall. v.g.vassilev added a comment. This looks mostly good to me. I noticed that @sammccall has done some work in that area in clangd and I was wondering if he has some thoughts about this patch. Repository: rG L

[PATCH] D151904: [clang-repl][CUDA] Add an unit test for interactive CUDA

v.g.vassilev added a comment. @argentite what is the fate of this patch? Should we move forward with it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151904/new/ https://reviews.llvm.org/D151904 ___ cfe

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber updated this revision to Diff 549745. Krishna-13-cyber added a comment. - Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156858/new/ https://reviews.llvm.org/D156858 Files: clang/docs/ClangRepl.rst clang/do

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 549749. capfredf added a comment. up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Frontend/ASTUnit.h clang/include/clang/Interprete

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

QuillPusher accepted this revision. QuillPusher added a comment. This revision is now accepted and ready to land. Thanks @Krishna-13-cyber for the prompt efforts @v.g.vassilev it is ready to commit as far as I can see Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 549750. capfredf added a comment. up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Frontend/ASTUnit.h clang/include/clang/Interprete

[PATCH] D157568: [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments

owenpan added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:177 llvm::Regex("^/[/*] *(end (of )?)? *(anonymous|unnamed)? *" - "([a-zA-Z0-9_]+)\\(([a-zA-Z0-9:_]*)\\)\\.? *(\\*/)?$", + "([a-zA-Z0-9_]+)\\(([a-zA-

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 549751. capfredf added a comment. use auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Frontend/ASTUnit.h clang/include/clang/Inte

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

mstorsjo added a comment. In D150646#4581664 , @rnk wrote: > I think we should be exposing the `__cpudex` builtin any time we are being > MSVC-like, not under `fms-compatibility`. Would that make things sensible > again? I think that might sound reason

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/CodeCompletion.cpp:1 +//===-- CodeCompletion.cpp - Code Completion for ClangRepl ---===// +// I would propose to rename this file to `InterpreterCodeCompletion.cpp` and implement the `

[PATCH] D157825: [clang] Implement constexpr bit_cast for vectors

DaPorkchop_ created this revision. DaPorkchop_ added a project: clang. Herald added a project: All. DaPorkchop_ requested review of this revision. Herald added a subscriber: cfe-commits. This makes __builtin_bit_cast support converting to and from vector types in a constexpr context. Without thi

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

brad updated this revision to Diff 549757. brad added a comment. Removed: /boot/system/develop/headers/os/arch Added: /boot/system/develop/headers/gnu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157767/new/ https://reviews.llvm.org/D157767 File

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 549759. capfredf added a comment. move everything into InterpreterCodeCompletion. the entry point for code completion is now a function, codeCompletion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 549760. capfredf added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Frontend/ASTUnit.h clang/include/clang/Interp

[PATCH] D156344: Disable call to fma for soft-float

shchenz added a comment. compiler-rt builtins library should not just undefining fma for PPC, right (see https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html)? If so, maybe we should at least first try not generating fma for soft-float at the first place where fmul + fadd is f

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. felix642 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Improved chec

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 marked an inline comment as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

4vtomat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146054/new/ https://reviews.llvm.org/D146054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter updated this revision to Diff 549777. ccotter marked 9 inline comments as done. ccotter added a comment. - Fix docs, handle C++20 simplification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239 Fil

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectEnableIfCheck.cpp:61-62 + + FixItHint TypenameHint = + FixItHint::CreateInsertion(ElaboratedLoc->getBeginLoc(), "typename "); + FixItHint Ty

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt marked an inline comment as done. yamt added a comment. can this land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 ___ cfe-commits mailing list cfe-com

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh is available

jacquesguan updated this revision to Diff 549779. jacquesguan added a comment. Add Zhinx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157693/new/ https://reviews.llvm.org/D157693 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/Lan

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zhinx is available

jacquesguan marked an inline comment as done. jacquesguan added inline comments. Comment at: clang/docs/LanguageExtensions.rst:815 * X86 (if SSE2 is available; natively if AVX512-FP16 is also available) + * RISC-V (natively if Zfh is available) craig.topper

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zhinx is available

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157693/new/ https://reviews.llvm.org/D157693 ___

[PATCH] D157693: [clang][doc] Mark _Float16 is support natively when Zfh or Zhinx is available

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jacquesguan marked an inline comment as done. Closed by commit rG9d0cf88e7086: [clang][doc] Mark _Float16 is support natively when Zfh or Zhinx is available (authored b

[clang] 9d0cf88 - [clang][doc] Mark _Float16 is support natively when Zfh or Zhinx is available

Author: Jianjian GUAN Date: 2023-08-14T11:27:15+08:00 New Revision: 9d0cf88e70860b29615253fbbd4d2d62eb08886a URL: https://github.com/llvm/llvm-project/commit/9d0cf88e70860b29615253fbbd4d2d62eb08886a DIFF: https://github.com/llvm/llvm-project/commit/9d0cf88e70860b29615253fbbd4d2d62eb08886a.diff

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter marked an inline comment as done. ccotter added a comment. > Do you have plans to also detect the bugprone scenario described in the Notes > here? I didn't have plans in this review, or in the immediate future after. I did name this check broadly as "bugprone-incorrect-enable-if," so I

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

MaskRay added a comment. > Apple needs a __need_ macro for va_list. Add one, and also ones for > va_start/va_arg/va_end, __va_copy, va_copy. Do you have a link to the specification or the source that this is needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM once the https://reviews.llvm.org/D157151#4582109 "Default" naming discussion is agreed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added a comment. In D157793#4583663 , @MaskRay wrote: >> Apple needs a __need_ macro for va_list. Add one, and also ones for >> va_start/va_arg/va_end, __va_copy, va_copy. > > Do you have a link to the specification or the source that this is needed

[clang] a23d65a - [RISCV] Add missing Xsfvcp extension check in clang sema

Author: 4vtomat Date: 2023-08-13T22:33:52-07:00 New Revision: a23d65ac89ce1263b58690fa051e81d7cd0b139d URL: https://github.com/llvm/llvm-project/commit/a23d65ac89ce1263b58690fa051e81d7cd0b139d DIFF: https://github.com/llvm/llvm-project/commit/a23d65ac89ce1263b58690fa051e81d7cd0b139d.diff LOG:

[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. 4vtomat marked an inline comment as done. Closed by commit rGa23d65ac89ce: [RISCV] Add missing Xsfvcp extension check in clang sema (authored by 4vtomat). Repository:

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu created this revision. ChuanqiXu added reviewers: rjmccall, ilya-biryukov, weiwang, cor3ntin, clang-language-wg. Herald added a project: All. ChuanqiXu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Close https://github.com/llvm

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:158-169 +assert(Result && "Why can't we find the record type from the common " + "expression of a coroutine suspend expression? " + "Maybe we missed some typ

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

ChuanqiXu updated this revision to Diff 549795. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157833/new/ https://reviews.llvm.org/D157833 Files: clang/docs/ReleaseNotes.rst clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGCoroutine.cpp clang/lib/CodeGen/CodeGenFunction.h clang

[PATCH] D156344: Disable call to fma for soft-float

long5hot added a comment. In D156344#4583559 , @shchenz wrote: > compiler-rt builtins library should not just undefining fma for PPC, right > (see https://gcc.gnu.org/onlinedocs/gccint/Soft-float-library-routines.html)? > If so, maybe we should at least

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 updated this revision to Diff 549802. XinWang10 added a comment. - mov definition to tuning features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157680/new/ https://reviews.llvm.org/D157680 Files: clang/include/clang/Driver/Options.t

[PATCH] D157680: [X86]Support options -mno-gather -mno-scatter

XinWang10 marked an inline comment as done. XinWang10 added inline comments. Comment at: llvm/lib/Target/X86/X86.td:437 +: SubtargetFeature<"prefer-no-gather", "PreferGather", "false", + "Indicates if gather prefer to be disabled">; +def FeaturePreferNoS

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

lygstate added a comment. In D157297#4571572 , @pengfei wrote: > The description is not clear to me. You should describe the reason rather > than phenomenon. > > My understanding is double colon operator cannot resolve functions with > parentheses. http

[clang-tools-extra] 32870da - Fix typos in documentation

Author: Chris Cotter Date: 2023-08-13T23:46:44-07:00 New Revision: 32870da3ba38ab0ab0710867d92465aacc6349e6 URL: https://github.com/llvm/llvm-project/commit/32870da3ba38ab0ab0710867d92465aacc6349e6 DIFF: https://github.com/llvm/llvm-project/commit/32870da3ba38ab0ab0710867d92465aacc6349e6.diff

[clang] 32870da - Fix typos in documentation

Author: Chris Cotter Date: 2023-08-13T23:46:44-07:00 New Revision: 32870da3ba38ab0ab0710867d92465aacc6349e6 URL: https://github.com/llvm/llvm-project/commit/32870da3ba38ab0ab0710867d92465aacc6349e6 DIFF: https://github.com/llvm/llvm-project/commit/32870da3ba38ab0ab0710867d92465aacc6349e6.diff

[PATCH] D156461: [clang][ASTImporter] Merge implicit ctors with definition

balazske added a comment. It looks not good to remove an invalid node from the DeclContext that otherwise remains in the AST. I checked the problem and found that the existing move constructor (originally in the To AST which had no definition) gets a `getNumCtorInitializers` value of 1 but the