[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:20888 + " { 7, 5,\"!!\" }\n" + "};\n", + Style); galenelias wrote: > owenpan wrote: > > > This is consistent with basically every

[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

galenelias updated this revision to Diff 553783. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158795/new/ https://reviews.llvm.org/D158795 Files: clang/lib/Format/WhitespaceManager.cpp clang/unittests/Format/FormatTest.cpp Index: clang/unittests/Format/FormatTest.cpp ==

[PATCH] D158795: Fix AlignArrayOfStructures + Cpp11BracedListStyle=false

galenelias marked an inline comment as done. galenelias added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:1247 if (Previous && Previous->isNot(TT_LineComment)) { - Changes[Next->Index].Spaces = 0; + Changes[Next->Index].Spaces =

[PATCH] D158948: [clang][ASTImporter] Add import of type-related nodes

danix800 created this revision. danix800 added a reviewer: balazske. danix800 added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision. Herald added a subs

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 updated this revision to Diff 553779. danix800 added a comment. Update doc: fix improper naming in objc testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158872/new/ https://reviews.llvm.org/D158872 Files: clang/docs/LibASTMatchers

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

This revision was automatically updated to reflect the committed changes. Closed by commit rG08bbff4aad57: [OpenMP] Codegen support for thread_limit on target directive for host (authored by sandeepkosuri, committed by Sandeep Kosuri ). Repository: rG LLVM Github

[clang] 08bbff4 - [OpenMP] Codegen support for thread_limit on target directive for host

Author: Sandeep Kosuri Date: 2023-08-26T22:18:49-05:00 New Revision: 08bbff4aad57c70a38d5d2680a61901977e66637 URL: https://github.com/llvm/llvm-project/commit/08bbff4aad57c70a38d5d2680a61901977e66637 DIFF: https://github.com/llvm/llvm-project/commit/08bbff4aad57c70a38d5d2680a61901977e66637.diff

[PATCH] D158947: [clang-format][NFC] Test formatting the input before messing it up

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D15

[clang] f2b8666 - [ORC][clang-repl] Fix clang-repl -host-supports-jit option after 122ebe3b500.

Author: Lang Hames Date: 2023-08-26T19:46:33-07:00 New Revision: f2b866653169d479a964f99b7679738742f6a6a2 URL: https://github.com/llvm/llvm-project/commit/f2b866653169d479a964f99b7679738742f6a6a2 DIFF: https://github.com/llvm/llvm-project/commit/f2b866653169d479a964f99b7679738742f6a6a2.diff LO

[clang] 19e3dfa - [clang-format][NFC] Chang some verifyFormat() to verifyNoChange()

Author: Owen Pan Date: 2023-08-26T19:44:05-07:00 New Revision: 19e3dfad58d36ed5aee798fc1b0af2a449002afc URL: https://github.com/llvm/llvm-project/commit/19e3dfad58d36ed5aee798fc1b0af2a449002afc DIFF: https://github.com/llvm/llvm-project/commit/19e3dfad58d36ed5aee798fc1b0af2a449002afc.diff LOG:

[PATCH] D158946: Delete Ananas support

brad created this revision. brad added a reviewer: MaskRay. brad added a project: LLVM. Herald added subscribers: ormris, hiraditya. Herald added a project: All. brad requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After looking at this fur

[PATCH] D158945: [clang-format] Handle Template Arguments with AlignConsecutiveXX

HazardyKnusperkeks created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, owenpan, MyDeveloperDay. HazardyKnusperkeks requested review of this revision. This fixes https://github.com/llvm/llvm-project/issues/6

[PATCH] D158925: [clang-format][NFC] Skip stability test if input is pre-formatted

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8521451708a: [clang-format][NFC] Skip stability test if input is pre-formatted (authored by owenpan). Changed prior to commit: https://reviews.llvm.org/D158925?vs=553714&id=553765#toc Repository: rG

[clang] c852145 - [clang-format][NFC] Skip stability test if input is pre-formatted

Author: Owen Pan Date: 2023-08-26T14:48:04-07:00 New Revision: c8521451708a49a5a55cf02c28189efac11b779e URL: https://github.com/llvm/llvm-project/commit/c8521451708a49a5a55cf02c28189efac11b779e DIFF: https://github.com/llvm/llvm-project/commit/c8521451708a49a5a55cf02c28189efac11b779e.diff LOG:

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

MaskRay added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1379 +void init_cpu_features_resolver(unsigned long hwcap, const __ifunc_arg_t *arg) { + if (__aarch64_cpu_features.features) It seems that we don't need the `_constructor` functi

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 553762. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang-tools-extra/clangd/CodeComplete.cpp clang/include/clang/Frontend/ASTUnit.h clang/include/cla

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 553759. capfredf added a comment. fix potential memory issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang-tools-extra/clangd/CodeComplete.cpp cl

[PATCH] D158925: [clang-format][NFC] Skip stability test if input is pre-formatted

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestBase.h:88 testing::ScopedTrace t(File, Line, ::testing::Message() << Code.str()); -EXPECT_EQ(Expected.str(), - format(Expected, Style, SC_ExpectComplete, Ranges)) -<< "Expect

[PATCH] D158933: [clang] Implement -funsigned-bitfields

DavidFerencSzabo updated this revision to Diff 553745. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158933/new/ https://reviews.llvm.org/D158933 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td clang/lib/Sema/SemaDecl.cpp clang/test/Sema/uns

[clang] 2c9372e - [clang-format] Rename qualifier file comments (#64354)

Author: MyDeveloperDay Date: 2023-08-26T16:48:52+01:00 New Revision: 2c9372e78d7c183ba7f28095cee0e2fb6a074c88 URL: https://github.com/llvm/llvm-project/commit/2c9372e78d7c183ba7f28095cee0e2fb6a074c88 DIFF: https://github.com/llvm/llvm-project/commit/2c9372e78d7c183ba7f28095cee0e2fb6a074c88.diff

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya added a comment. > I'm marking as requiring changes mostly for the latter comment about > CLANG_INCLUDE_TESTS. Added CLANG_INCLUDE_TESTS to the conditional. btw when CLANG_INCLUDE_TESTS is OFF, `ninja check-clang-tools` target doesn't get created so adding CLANG_INCLUDE_TESTS here di

[PATCH] D158566: Add CLANGD_INCLUDE_TESTS as a separate flag to control clangd tests

hiraditya updated this revision to Diff 553738. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158566/new/ https://reviews.llvm.org/D158566 Files: clang-tools-extra/clangd/CMakeLists.txt Index: clang-tools-extra/clangd/CMakeLists.txt ===

[PATCH] D158933: [clang] Implement -funsigned-bitfields

DavidFerencSzabo created this revision. Herald added a project: All. DavidFerencSzabo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158933 Files: clang/include/cl

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

Arsenic updated this revision to Diff 553730. Arsenic added a comment. Fix minor typo is comments - Move creation of DocComment in it's own seperate function - Update the Underlying DataType used by RecordLocation - Update the patch to account for new C++ APIRecords Repository: rG LLVM Github

[PATCH] D154093: [clang-format] Break long string literals in C#, etc.

sstwcw updated this revision to Diff 553729. sstwcw added a comment. Stop using `SmallString` in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D158697: [clang-format][doc] Correct typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d0061fc5e1f: [clang-format][doc] Correct typos (authored by sstwcw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 1d0061f - [clang-format][doc] Correct typos

Author: sstwcw Date: 2023-08-26T13:55:21Z New Revision: 1d0061fc5e1fe68f34135a6d9520bde4679b43db URL: https://github.com/llvm/llvm-project/commit/1d0061fc5e1fe68f34135a6d9520bde4679b43db DIFF: https://github.com/llvm/llvm-project/commit/1d0061fc5e1fe68f34135a6d9520bde4679b43db.diff LOG: [clang

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

nridge added a comment. (I'm away on travels, will get back to this within the next week) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 ___ cfe-commits mailin

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

FlashSheridan added a comment. Thank you, looks promising and I will test it on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158929/new/ https://reviews.llvm.org/D158929 ___ cfe-commits mailing

[PATCH] D158929: [clang-tidy] Add exit code support to clang-tidy-diff.py

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Modify script to fail

[PATCH] D158928: [clang-tidy] Add IgnoreTypes option to modernize-use-nullptr

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang-tools-extra. New option add

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added a comment. Gently ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Gently ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Closes ht

[PATCH] D158925: [clang-format][NFC] Skip stability test if input is pre-formatted

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. This shortens the run-time of `FormatTests` by about 10% on average

[PATCH] D158923: [clang-c] Visit ranged for initializer

kiloalphaindia added a comment. Can we get this into release/17.x still? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158923/new/ https://reviews.llvm.org/D158923 ___ cfe-commits mailing list cfe-commit

[PATCH] D158923: [clang-c] Visit ranged for initializer

kiloalphaindia created this revision. kiloalphaindia added reviewers: HAPPY, aaron.ballman. kiloalphaindia added a project: clang-c. Herald added a subscriber: arphaman. Herald added a project: All. kiloalphaindia requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Overall looks to be fine, but I didn't get too deep into AST matchers. I assume that tests cover them. Please wait like 2 weeks before pushing this, so someone else could be able to verify

[PATCH] D158691: [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator

This revision was automatically updated to reflect the committed changes. Closed by commit rGffad4f8fcac5: [clang-tidy] Container-size-empty fixed c++ version in tests to support… (authored by felix642, committed by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang-tools-extra] ffad4f8 - [clang-tidy] Container-size-empty fixed c++ version in tests to support string_literals operator

Author: Felix Date: 2023-08-26T07:23:05Z New Revision: ffad4f8fcac5fa5e65b979ab2a2fcf903a66e5e2 URL: https://github.com/llvm/llvm-project/commit/ffad4f8fcac5fa5e65b979ab2a2fcf903a66e5e2 DIFF: https://github.com/llvm/llvm-project/commit/ffad4f8fcac5fa5e65b979ab2a2fcf903a66e5e2.diff LOG: [clang-