[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

nridge accepted this revision. nridge added a comment. I'm fine with allowing partial selection for consistency with other expressions. I think this patch is in a good state. Thanks for your patience with the review :) Let me know if you need me to commit it for you. Repository: rG LLVM Gith

[clang-tools-extra] cbd6ac6 - [clangd] Show parameter hints for operator()

Author: Younan Zhang Date: 2023-09-10T15:56:00+08:00 New Revision: cbd6ac6165e683f2eed4a5066c1ccf53bed0696d URL: https://github.com/llvm/llvm-project/commit/cbd6ac6165e683f2eed4a5066c1ccf53bed0696d DIFF: https://github.com/llvm/llvm-project/commit/cbd6ac6165e683f2eed4a5066c1ccf53bed0696d.diff

[PATCH] D158926: [clangd] Show parameter hints for operator()

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd6ac6165e6: [clangd] Show parameter hints for operator() (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158926/new/ https://reviews.

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/HighCommander4 requested changes to this pull request. Thanks for the patch! There is some prior work on this which I've looked over and will summarize: * This change was previously proposed in [D138546](https://reviews.llvm.org/D138546) * During its review, we discovered

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

@@ -87,12 +87,13 @@ struct DriverArgs { std::string Lang; std::string Sysroot; std::string ISysroot; + std::string Target; bool operator==(const DriverArgs &RHS) const { return std::tie(Driver, StandardIncludes, StandardCXXIncludes, Lang, -S

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/mincrmatt12 updated https://github.com/llvm/llvm-project/pull/65824: >From e5f74b064b303a53b267caa12738af381c17c65f Mon Sep 17 00:00:00 2001 From: Matthew Mirvish Date: Fri, 8 Sep 2023 19:59:58 -0400 Subject: [PATCH] [clangd] Forward --target to system include extraction Som

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

@@ -87,12 +87,13 @@ struct DriverArgs { std::string Lang; std::string Sysroot; std::string ISysroot; + std::string Target; bool operator==(const DriverArgs &RHS) const { return std::tie(Driver, StandardIncludes, StandardCXXIncludes, Lang, -S

[clang-tools-extra] [clangd] Forward --target to system include extraction (PR #65824)

https://github.com/mincrmatt12 resolved https://github.com/llvm/llvm-project/pull/65824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 18b6e21 - [Driver] Replace usage of -Bshareable linker flag with -shared (#65842)

Author: Brad Smith Date: 2023-09-10T04:35:58-04:00 New Revision: 18b6e2139ff8520bb33c3057ae6794a4cf6822e9 URL: https://github.com/llvm/llvm-project/commit/18b6e2139ff8520bb33c3057ae6794a4cf6822e9 DIFF: https://github.com/llvm/llvm-project/commit/18b6e2139ff8520bb33c3057ae6794a4cf6822e9.diff LO

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/65842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti added a comment. Thank you. Could you please commit this for me with `Julian Schmidt <44101708+5chmi...@users.noreply.github.com>`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D141757 __

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

kaz7 added a comment. I cannot write inline comment, so I'm leaving message here. openmp/runtime/test/target/target_thread_limit.cpp: > // checking consecutive target regions with different thread_limits > #pragma omp target thread_limit(3) > > { > printf("\nsecond target: thread_limit = %

[PATCH] D159480: [Clang][AArch64] Fine-grained ldp and stp policies.

dmgreen added a comment. We do not usually add front-end clang options for optimizations like this. Users are more likely to use them incorrectly, or just not know that they exist. The usual method would be to make a subtarget tuning feature that controls whether ldp are created, and enable it

[clang] [Clang][AArch64] Define x86_64 macros for ARM64EC targets (PR #65420)

cjacek wrote: LGTM https://github.com/llvm/llvm-project/pull/65420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/65887: evalIntegralCast is using APInt method to get the value of _BitInt() values after _BitInt() changes were introduced. Some of those methods assume values are less than or equal to 64-bits, which is not true f

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/65888: Recent changes to add _BitInt support have caused our internal random testing to fail. This change just avoids a readability magic numbers check for now if a _BitInt. The crash seen (edited for clarity) is s

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

llvmbot wrote: @llvm/pr-subscribers-clang Changes evalIntegralCast is using APInt method to get the value of _BitInt() values after _BitInt() changes were introduced. Some of those methods assume values are less than or equal to 64-bits, which is not true for _BitInt() types. This change si

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/vabridgers created https://github.com/llvm/llvm-project/pull/65889: This crash was exposed recently in our randomized testing. _BitInts were not being handled properly during IntegerLiteral visitation. This patch addresses the problem for now. The BitIntType has no getKind(

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/vabridgers review_requested https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes Recent changes to add _BitInt support have caused our internal random testing to fail. This change just avoids a readability magic numbers check for now if a _BitInt. The crash seen (edited for clarity) is shown below. /llvm/include/llv

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes This crash was exposed recently in our randomized testing. _BitInts were not being handled properly during IntegerLiteral visitation. This patch addresses the problem for now. The BitIntType has no getKind() method, so the FoldingSetID

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This crash was exposed recently in our randomized testing. _BitInts were not being handled properly during IntegerLiteral visitation. This patch addresses the problem for now. The BitIntType has no getKind() method, so the FoldingSetID is ta

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

steakhal wrote: I guess this is one sideeffect of `getZExtValue` and `getSExtValue`. To me, it feels like all such calls could hit the same assert, thus it fixes this instance, but we still lack a generic solution to this problem at other places. I'm not opposing to this fix, but it might make

[clang] [clang][ExtractAPI] Create extractapi::RecordLocation (PR #65891)

https://github.com/Arsenic-ATG review_requested https://github.com/llvm/llvm-project/pull/65891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Create extractapi::RecordLocation (PR #65891)

https://github.com/Arsenic-ATG labeled https://github.com/llvm/llvm-project/pull/65891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Create extractapi::RecordLocation (PR #65891)

https://github.com/Arsenic-ATG created https://github.com/llvm/llvm-project/pull/65891: Create and use `extractapi::RecordLocation` instead of conventional `clang::PresumedLoc` to track the location of an APIRecord, this reduces the dependency of APISet on SourceManager and would help if someo

[clang] [clang][ExtractAPI] Create extractapi::RecordLocation (PR #65891)

https://github.com/Arsenic-ATG review_requested https://github.com/llvm/llvm-project/pull/65891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExtractAPI] Create extractapi::RecordLocation (PR #65891)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Create and use `extractapi::RecordLocation` instead of conventional `clang::PresumedLoc` to track the location of an APIRecord, this reduces the dependency of APISet on SourceManager and would help if someone wants to create APISet from JSON

[clang] [clang][ExtractAPI] Create extractapi::RecordLocation (PR #65891)

@@ -134,7 +134,48 @@ class Template { bool empty() const { return Parameters.empty() && Constraints.empty(); } }; -/// DocComment is a vector of RawComment::CommentLine. +/// Slightly cut down version of PresumedLoc to suit the needs of +/// ExtractAPI. +class RecordLocation

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

PiotrZSL added a comment. In D158371#4640664 , @loskutov wrote: > However, I don't have push access to the repo, so could you commit the change? Name / Email (to be used as author) ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699: >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in the

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This change is symmetric with the one reviewed in and handles the exception handling specific intrinsic, which slipped through the cracks, in the same way, by inserting an address-space cast iff RTTI is in

[clang] [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger (PR #65894)

https://github.com/Arsenic-ATG review_requested https://github.com/llvm/llvm-project/pull/65894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger (PR #65894)

https://github.com/Arsenic-ATG labeled https://github.com/llvm/llvm-project/pull/65894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger (PR #65894)

https://github.com/Arsenic-ATG labeled https://github.com/llvm/llvm-project/pull/65894 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger (PR #65894)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Create a clang tool to merge all the JSON symbolgraph emited by --emit-symbol-graph or -extract-api options into one unified JSON symbolgraph file. Differential Revision: https://reviews.llvm.org/D158646 -- Patch is 127.06 KiB, truncated to

[PATCH] D158646: [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger

Arsenic added a comment. In D158646#4639599 , @dang wrote: > As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we > should move this review to GitHub to make sure we don't lose track of it. The patch has been moved to GitHub ( h

[clang-tools-extra] [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger (PR #65894)

Arsenic-ATG wrote: - The changes were initially being tracked on llvm Phabricator Differential Revision: https://reviews.llvm.org/D158646 - Dependent on #65891 - Currently keeping this as draft pull request and would be opening it for review once it is ready and tested completely. https://git

[clang] Extension: allow recursive macros (PR #65851)

https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851: >From 2f807b312baef8c6038c2452b84232acb6d6d2c2 Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 1/2] add define2 pp directive --- clang/include/clang/Basic/TokenKin

[PATCH] D156057: [Clang][Sema] Diagnose indeterminately sequenced accesses

cor3ntin added a comment. @aaron.ballman that's been waiting for a while - i don't feel comfortable reviewing it, mind looking at it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156057/new/ https://reviews.llvm.org/D156057 ___ cfe-commits

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

loskutov added a comment. In D158371#4642758 , @PiotrZSL wrote: > Name / Email (to be used as author) ? Ignat Loskutov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158371/new/ https://reviews.llvm.org/D

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/65896: Before: array.cpp:319:10: note: read of uninitialized object is not allowed in a constant expression 319 |return aaa; | ^ After: array.cpp:319:10: note: read of uninitialized object is

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Before: ``` array.cpp:319:10: note: read of uninitialized object is not allowed in a constant expression 319 |return aaa; | ^ ``` After: ``` array.cpp:319:10: note: read of uninitialized object is not allowed in a con

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

@@ -4443,7 +,7 @@ struct CompoundAssignSubobjectHandler { return foundVector(Subobj, SubobjType); case APValue::Indeterminate: Info.FFDiag(E, diag::note_constexpr_access_uninit) - << /*read of=*/0 << /*uninitialized object=*/1; + << /*read

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

https://github.com/PiotrZSL approved this pull request. LGTM, not perfect, as we going to ignore big ints, but still better than crashing for now. https://github.com/llvm/llvm-project/pull/65888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 01c1156 - [clang-tidy] Add IgnoreTypes option to modernize-use-nullptr

Author: Piotr Zegar Date: 2023-09-10T12:22:53Z New Revision: 01c11569fc67b2a00403f64695fff6d2b4e78fe5 URL: https://github.com/llvm/llvm-project/commit/01c11569fc67b2a00403f64695fff6d2b4e78fe5 DIFF: https://github.com/llvm/llvm-project/commit/01c11569fc67b2a00403f64695fff6d2b4e78fe5.diff LOG: [

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

tbaederr wrote: Meh this breaks a test in `clang/AST/Interp`, for unrelated reasons. https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] f2e5000 - [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

Author: Ignat Loskutov Date: 2023-09-10T12:52:47Z New Revision: f2e5000937235aa35a9ee4423045b265c2c79e85 URL: https://github.com/llvm/llvm-project/commit/f2e5000937235aa35a9ee4423045b265c2c79e85 DIFF: https://github.com/llvm/llvm-project/commit/f2e5000937235aa35a9ee4423045b265c2c79e85.diff LOG

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

@@ -1149,7 +1149,10 @@ static void emitCatchDispatchBlock(CodeGenFunction &CGF, assert(handler.Type.Flags == 0 && "landingpads do not support catch handler flags"); assert(typeValue && "fell into catch-all case!"); -typeValue = CGF.Builder.CreateBitCast(t

[PATCH] D158928: [clang-tidy] Add IgnoreTypes option to modernize-use-nullptr

PiotrZSL closed this revision. PiotrZSL added a comment. Commited in 01c11569fc67b2a00403f64695fff6d2b4e78fe5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158928/new/ https://reviews.llvm.org/D158928 __

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

@@ -1149,7 +1149,10 @@ static void emitCatchDispatchBlock(CodeGenFunction &CGF, assert(handler.Type.Flags == 0 && "landingpads do not support catch handler flags"); assert(typeValue && "fell into catch-all case!"); -typeValue = CGF.Builder.CreateBitCast(t

[PATCH] D158371: [clang-tidy] Fix DanglingHandleCheck to work in C++17 and later mode

PiotrZSL closed this revision. PiotrZSL added a comment. Commited in f2e5000937235aa35a9ee4423045b265c2c79e85 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158371/new/ https://reviews.llvm.org/D158371 __

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

@@ -4443,7 +,7 @@ struct CompoundAssignSubobjectHandler { return foundVector(Subobj, SubobjType); case APValue::Indeterminate: Info.FFDiag(E, diag::note_constexpr_access_uninit) - << /*read of=*/0 << /*uninitialized object=*/1; + << /*read

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/65896: >From 698f706c66fd5332afbc8f99de30727d08faf430 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 10 Sep 2023 14:28:02 +0200 Subject: [PATCH] [clang][Diagnostics] Add source range to uninit

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

@@ -4443,7 +,7 @@ struct CompoundAssignSubobjectHandler { return foundVector(Subobj, SubobjType); case APValue::Indeterminate: Info.FFDiag(E, diag::note_constexpr_access_uninit) - << /*read of=*/0 << /*uninitialized object=*/1; + << /*read

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr resolved https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/65896: >From 3d0a747ef78fb85fc09d6de65ccf57d4b832823a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 10 Sep 2023 14:28:02 +0200 Subject: [PATCH] [clang][Diagnostics] Add source range to uninit

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

https://github.com/hazohelet approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

@@ -1149,7 +1149,10 @@ static void emitCatchDispatchBlock(CodeGenFunction &CGF, assert(handler.Type.Flags == 0 && "landingpads do not support catch handler flags"); assert(typeValue && "fell into catch-all case!"); -typeValue = CGF.Builder.CreateBitCast(t

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 89471d5 - [Fuchsia] Disable libcxx timezone database (#65870)

Author: Alex Brachet Date: 2023-09-10T10:04:04-04:00 New Revision: 89471d50e8fc72b5157db17d7c9f77790b76b840 URL: https://github.com/llvm/llvm-project/commit/89471d50e8fc72b5157db17d7c9f77790b76b840 DIFF: https://github.com/llvm/llvm-project/commit/89471d50e8fc72b5157db17d7c9f77790b76b840.diff

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

https://github.com/abrachet closed https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

tianshilei1992 added a comment. In D152054#4642725 , @kaz7 wrote: > I run check-openmp on our machine, this omp_get_thread_limit() returns > default thread limit 2147483647 (=0x7fff). That is something wrong because this patch is about host instead

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699: >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx resolved https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/65699: >From f4271e03667b64c8d10d7e4de16e78b37e845229 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Fri, 8 Sep 2023 00:21:59 +0100 Subject: [PATCH 1/2] AS_cast the argument to `eh_typeid_for` iff typeinfo is not in

[clang-tools-extra] [clang][CodeGen] The `eh_typeid_for` intrinsic needs special care too (PR #65699)

https://github.com/AlexVlx resolved https://github.com/llvm/llvm-project/pull/65699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >