[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

2023-09-16 Thread via cfe-commits
https://github.com/antangelo closed https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] da35b2e - [clang][Docs] Document X86 interrupt attribute (#65662)

2023-09-16 Thread via cfe-commits
Author: antangelo Date: 2023-09-17T01:26:26-04:00 New Revision: da35b2e57a164ec62278f1685d0c684c5bc2d666 URL: https://github.com/llvm/llvm-project/commit/da35b2e57a164ec62278f1685d0c684c5bc2d666 DIFF: https://github.com/llvm/llvm-project/commit/da35b2e57a164ec62278f1685d0c684c5bc2d666.diff

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-16 Thread Jocelyn Castellano via cfe-commits
pandaninjas wrote: Any idea why the CI is failing? It mentions line 86 not being constexpr because of assert, but it doesn't seem like I've done anything which should affect that... https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-16 Thread Jocelyn Castellano via cfe-commits
pandaninjas wrote: Any idea why the CI is failing? It mentions line 86 not being constexpr because of assert, but it doesn't seem like I've done anything which should affect that... https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-16 Thread via cfe-commits
@@ -0,0 +1,25 @@ +.. title:: clang-tidy - modernize-use-std-numbers + +modernize-use-std-numbers += + +This check finds constants and function calls to math functions that can be replaced EugeneZelenko wrote: Please synchronize first

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-16 Thread via cfe-commits
@@ -168,6 +168,12 @@ New checks Replace ``enable_if`` with C++20 requires clauses. +- New :doc:`modernize-use-std-numbers + ` check. + + Finds constants and function calls to math functions that can be replaced + with c++20's mathematical constants ('numbers' header).

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-16 Thread via cfe-commits
@@ -0,0 +1,377 @@ +//===--- UseStdNumbersCheck.cpp - clang_tidy -===// EugeneZelenko wrote: Please make it same length as similar line at bottom of comment. https://github.com/llvm/llvm-project/pull/66583

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-16 Thread via cfe-commits
@@ -0,0 +1,25 @@ +.. title:: clang-tidy - modernize-use-std-numbers + +modernize-use-std-numbers += + +This check finds constants and function calls to math functions that can be replaced +with c++20's mathematical constants ('numbers' header) and offers

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

2023-09-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Adds documentation for the X86 `__attribute__((interrupt))` attribute, in a similar format to interrupt attributes of other platforms. Migrated from https://reviews.llvm.org/D159317 --- Full diff:

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

2023-09-16 Thread via cfe-commits
https://github.com/antangelo updated https://github.com/llvm/llvm-project/pull/65662 >From adab00268e5a6ca765dd2b70b2b3a7a332641ab9 Mon Sep 17 00:00:00 2001 From: Antonio Abbatangelo Date: Thu, 31 Aug 2023 16:40:06 -0400 Subject: [PATCH] [clang][Docs] Document X86 interrupt attribute ---

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Emilia Kond via cfe-commits
https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-16 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 47422fc341cc2a830aa7abec6d105018271f13bd Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 03:00:59 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-16 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-16 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 87c21561e1c087caeb6105f5824e809da85e67ac Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 02:36:45 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-16 Thread Balint Cristian via cfe-commits
cbalint13 wrote: @DavidSpickett , This PR list all flags for a specific target. --- Additionally, beyond this PR: * We can limit to list flags only for a desired e.g. -mcpu=XYZ, e.g. the user can query like: ```./bin/clang -target x86_64-linux-gnu -mcpu=sandybridge

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

2023-09-16 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D152279#4638173 , @asb wrote: > In D152279#4612099 , @craig.topper > wrote: > >> In D152279#4612087 , @MaskRay >> wrote: >> >>> I am still

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-16 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 created https://github.com/llvm/llvm-project/pull/66586 This uses MCSubtargetInfo instead to cover all the architectures. This now also list descriptions along with the names. The advantage fetching from MCSubtargetInfo is that we rely on tablegen architecture

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -370,9 +364,9 @@ bool UnwrappedLineParser::parseLevel(const FormatToken *OpeningBrace, else if (FormatTok->getType() == TT_MacroBlockEnd) kind = tok::r_brace; -auto ParseDefault = [this, OpeningBrace, NextLevelLBracesType, IfKind, +auto ParseDefault =

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH 1/2] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

2023-09-16 Thread Andrei Lebedev via cfe-commits
andreil99 wrote: @cor3ntin No, I did not update all the sphinx bots, only specific ones, as I mentioned above in https://github.com/llvm/llvm-project/pull/65664#issuecomment-1714983618 > I can update the publishing bots. For the bots running on > https://lab.llvm.org/buildbot/#/workers/92 we

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Emilia Kond via cfe-commits
@@ -370,9 +364,9 @@ bool UnwrappedLineParser::parseLevel(const FormatToken *OpeningBrace, else if (FormatTok->getType() == TT_MacroBlockEnd) kind = tok::r_brace; -auto ParseDefault = [this, OpeningBrace, NextLevelLBracesType, IfKind, +auto ParseDefault =

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Emilia Kond via cfe-commits
https://github.com/rymiel resolved https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Emilia Kond via cfe-commits
https://github.com/rymiel resolved https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Emilia Kond via cfe-commits
https://github.com/rymiel resolved https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/65908 >From 0cfeaee5ec5c431bc15fb037f2a20c944c508c2a Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Sun, 10 Sep 2023 23:01:39 +0300 Subject: [PATCH 1/3] [clang-format] Fix requires misannotation with comma

[clang] [Clang] Allow mixed scalar type constraints for inline asm (PR #65465)

2023-09-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: %clang_cc1 %s -emit-llvm -o /dev/null + +unsigned test(float f) topperc wrote: This test is using -emit-llvm, but the patch is in SelectionDAG. SelectionDAG doesn't run with -emit-llvm https://github.com/llvm/llvm-project/pull/65465

[clang] [Clang] Allow mixed scalar type constraints for inline asm (PR #65465)

2023-09-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: %clang_cc1 %s -emit-llvm -o /dev/null + +unsigned test(float f) topperc wrote: What IR does this generate? https://github.com/llvm/llvm-project/pull/65465 ___ cfe-commits mailing list

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause);

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause);

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
@@ -1135,6 +1145,14 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresExpressions) { EXPECT_TOKEN(Tokens[3], tok::kw_requires, TT_RequiresExpression); EXPECT_TOKEN(Tokens[4], tok::l_paren, TT_RequiresExpressionLParen); EXPECT_TOKEN(Tokens[14], tok::l_brace,

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: Nits. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam resolved https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam resolved https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

2023-09-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66381 >From 997e3b69ac5c20a9130b957c86c08b16d23af07c Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 14 Sep 2023 06:27:35 -0700 Subject: [PATCH 1/6] Fix math-errno issue ---

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

2023-09-16 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added inline comments. Comment at: clang/test/Sema/warn-thread-safety-analysis.c:26 + // Define the mutex struct. Oh, I wouldn't mind if you were to drop this spurious added newline. But you can do this when committing, no need for a new patch

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

2023-09-16 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert accepted this revision. aaronpuchert added a comment. Thanks, looks good! I'd like to hear from @aaron.ballman if this warrants a release note, but that can be added separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 1/3] [clang-tidy]

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 26fb41a2903110b6fc8bd986284d41b1fe6814d5 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 0f14b63b7336532f45abd40749a2a7cd11cfe7e6 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
5chmidti wrote: > I'ts not only about category but also name, check suggests std::numbers, then > better name it modernize-use-std-numbers, reason for that is simple. Before > C++20 we may want to have a check for example -prefer-math-constants that > would change 3.14 hardcoded in code into

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

2023-09-16 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: Simply better to reduce scope of check name to avoid overlap, unless check would support pre-c++20, then it could be fine. https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

2023-09-16 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: > Sure thing. I don't have a strong feeling about the category. I'ts not only about category but also name, check suggests std::numbers, then better name it modernize-use-std-numbers, reason for that is simple. Before C++20 we may want to have a check for example

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-09-16 Thread Faisal Vali via Phabricator via cfe-commits
faisalv closed this revision. faisalv added a comment. Sorry about the delay - this patch has landed - https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 248c433be176806766f8c2ae9f19ca61f392220e Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 32d56e1bfb79ec0be5344ec11bb465777c2fd236 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang] 5bdd5d0 - Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

2023-09-16 Thread faisal vali via cfe-commits
Author: faisal vali Date: 2023-09-16T13:29:59-05:00 New Revision: 5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea URL: https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea DIFF: https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea.diff

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
5chmidti wrote: > In general scope of the check is fine, but specially as it's limited to C++20 > and way how its written would be good to rename it into > modernize-use-std-numbers. Sure thing. I don't have a strong feeling about the category. https://github.com/llvm/llvm-project/pull/66583

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
5chmidti wrote: - How do I correctly parse the values in a macro? While the test locally works, it doesn't in CI. I also don't differentiate between what kind of numeric constant the token is, which might be another problem. Any pointers on how to do this correctly are greatly appreciated. -

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: In general scope of the check is fine, but specially as it's limited to C++20 and way how its written would be good to rename it into modernize-use-std-numbers. https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 6e14980c7b7fe22e8b614d641ba72117982b798f Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add

[clang] [Clang][test] Replace legacy -target with --target=. (PR #66572)

2023-09-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/66572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
5chmidti wrote: For macros I have only implemented matching literals, not function calls or formulas. I also don't suggest using modern language constructs for macros, there are other checks that do this. https://github.com/llvm/llvm-project/pull/66583

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes This check finds constants and function calls to math functions that can be replaced with c++20's mathematical constants ('numbers' header) and offers fixit-hints. Does not match the use of variables or macros with that value and

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

2023-09-16 Thread via cfe-commits
https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/66583 This check finds constants and function calls to math functions that can be replaced with c++20's mathematical constants ('numbers' header) and offers fixit-hints. Does not match the use of variables or macros

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-16 Thread via cfe-commits
https://github.com/sstwcw closed https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 00e794b - [clang-format] Properly indent lines inside Verilog case structure (#65861)

2023-09-16 Thread via cfe-commits
Author: sstwcw Date: 2023-09-16T14:30:19Z New Revision: 00e794b4dd9699403f2df3ac9c8147fc139730b2 URL: https://github.com/llvm/llvm-project/commit/00e794b4dd9699403f2df3ac9c8147fc139730b2 DIFF: https://github.com/llvm/llvm-project/commit/00e794b4dd9699403f2df3ac9c8147fc139730b2.diff LOG:

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-16 Thread via cfe-commits
https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/65861 >From c1982d451e6ca8e3cf1269677aabe984000f6801 Mon Sep 17 00:00:00 2001 From: sstwcw Date: Sat, 9 Sep 2023 20:35:33 + Subject: [PATCH 1/3] [clang-format] Properly indent lines inside Verilog case structure

[clang] [ValueTracking] Simplify uaddo pattern (PR #65910)

2023-09-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Changes This patch simplifies the overflow check of unsigned addition. `a + b u a` implies `a + b u b` `a + b =u a` implies `a + b =u b` Alive2: https://alive2.llvm.org/ce/z/H8oK8n Fixes #65863. --- Full diff:

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

2023-09-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Changes This patch simplifies the overflow check of unsigned addition. `a + b u a` implies `a + b u b` `a + b =u a` implies `a + b =u b` Alive2: https://alive2.llvm.org/ce/z/H8oK8n Fixes #65863. --- Full diff:

[clang] [ValueTracking] Simplify uaddo pattern (PR #65910)

2023-09-16 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65910 >From 9bb817aa40dd9bc1bbb18b4cf4bc079145c8ecaa Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Mon, 11 Sep 2023 03:58:02 +0800 Subject: [PATCH] [ValueTracking] Simplify uaddo pattern ---

[clang-tools-extra] [ValueTracking] Simplify uaddo pattern (PR #65910)

2023-09-16 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65910 >From 9bb817aa40dd9bc1bbb18b4cf4bc079145c8ecaa Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Mon, 11 Sep 2023 03:58:02 +0800 Subject: [PATCH] [ValueTracking] Simplify uaddo pattern ---

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

2023-09-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/66553 >From d67dbfb1e926e90b2f4a067c86732bd41783791d Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Fri, 15 Sep 2023 21:39:17 + Subject: [PATCH 1/2] [clang-tidy] Fix handling --driver-mode= Driver mode passed

[clang-tools-extra] [clang-tidy] Improve bugprone-unused-return-value check (PR #66573)

2023-09-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes Improve diagnostic message to be more straight forward, fix handling of casting to non-void and add new option AllowCastToVoid to control casting to void behavior. Closes #66570 --- Patch is 23.93 KiB, truncated to 20.00 KiB below,

[clang-tools-extra] [clang-tidy] Improve bugprone-unused-return-value check (PR #66573)

2023-09-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL created https://github.com/llvm/llvm-project/pull/66573 Improve diagnostic message to be more straight forward, fix handling of casting to non-void and add new option AllowCastToVoid to control casting to void behavior. Closes #66570 >From

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-09-16 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk edited https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-09-16 Thread Yeting Kuo via cfe-commits
@@ -1220,3 +1220,15 @@ // RUN: -march=rv64i_zve32x_zvkt1p0 -x c -E -dM %s \ // RUN: -o - | FileCheck --check-prefix=CHECK-ZVKT-EXT %s // CHECK-ZVKT-EXT: __riscv_zvkt 100{{$}} + +// RUN: %clang -target riscv32-unknown-linux-gnu -march=rv32i -x c -E -dM %s \

[clang] [Clang][test] Replace legacy -target with --target=. (PR #66572)

2023-09-16 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk created https://github.com/llvm/llvm-project/pull/66572 None >From 368db97ba8cb62106980abe320a61f48a96da68b Mon Sep 17 00:00:00 2001 From: Yeting Kuo Date: Sat, 16 Sep 2023 19:34:50 +0800 Subject: [PATCH] [Clang][test] Replace legacy -target with --target=. ---

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added inline comments. Comment at: clang/test/SemaCXX/static-assert-cxx26.cpp:304 +static_assert('\u{9}' == (char)1, ""); // expected-error {{failed}} \ + // expected-note {{evaluates to ''\t' (0x09, 9) == '' (0x01, 1)'}}

[PATCH] D158595: [clang][Interp] Allow zero-init of primitives with an empty init list

2023-09-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158595/new/ https://reviews.llvm.org/D158595

[PATCH] D159351: [Sema] Change order of displayed overloads in diagnostics

2023-09-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added subscribers: hubert.reinterpretcast, rsmith, cor3ntin. cor3ntin added a comment. @hubert.reinterpretcast @rsmith Opinions on that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159351/new/ https://reviews.llvm.org/D159351

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

2023-09-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. We should take a decision on this before the move off Phab. Generally the changes look sensible to me so I'm not sure there are blockers left Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/

[PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

2023-09-16 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. It would be nice to figure out a plan for this PR in the next few weeks, before we get kicked out of Phab! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 ___ cfe-commits

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-16 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/3] [Clang] Static member initializers are not immediate

[clang] [Clang] Static member initializers are not immediate escalating context. (PR #66021)

2023-09-16 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66021 >From a3390c4ac8bba43e73ea41f4af85b37df97b1098 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 11 Sep 2023 23:40:38 +0200 Subject: [PATCH 1/3] [Clang] Static member initializers are not immediate

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Reassociate loop invariant GEP index calculations.

2023-09-16 Thread Dmitriy Smirnov via Phabricator via cfe-commits
d-smirnov updated this revision to Diff 556894. d-smirnov added a comment. unit test fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGen/SystemZ/systemz-inline-asm-03.c

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

2023-09-16 Thread via cfe-commits
cor3ntin wrote: @andreil99 did you update all the sphinx bots or just specific ones? https://github.com/llvm/llvm-project/pull/65664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

2023-09-16 Thread John Paul Adrian Glaubitz via Phabricator via cfe-commits
glaubitz added a comment. Any news on this? I guess it would be nice to get the remaining m68k patches merged before the Phrabricator shutdown. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___

[clang] [analyzer] TaintPropagation checker strlen() should not propagate (PR #66086)

2023-09-16 Thread Daniel Krupp via cfe-commits
https://github.com/dkrupp updated https://github.com/llvm/llvm-project/pull/66086 >From f8997b16c74543eb57b272c4dd4abca1a10d9ac7 Mon Sep 17 00:00:00 2001 From: Daniel Krupp Date: Fri, 8 Sep 2023 16:57:49 +0200 Subject: [PATCH] [analyzer] TaintPropagation checker strlen() should not propagate

[PATCH] D159522: [Clang][C] Fixed a bug where we reject an _Atomic qualified integer in a switch statment

2023-09-16 Thread Guillot Tony via Phabricator via cfe-commits
to268 updated this revision to Diff 556892. to268 marked an inline comment as done. to268 added a comment. I have fixed the ReleaseNote formatting error. Please land this patch on my behalf "Guillot Tony " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-09-16 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk edited https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-09-16 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk edited https://github.com/llvm/llvm-project/pull/65756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support predefined marcro __riscv_misaligned_{fast,avoid}. (PR #65756)

2023-09-16 Thread Yeting Kuo via cfe-commits
@@ -1220,3 +1220,15 @@ // RUN: -march=rv64i_zve32x_zvkt1p0 -x c -E -dM %s \ // RUN: -o - | FileCheck --check-prefix=CHECK-ZVKT-EXT %s // CHECK-ZVKT-EXT: __riscv_zvkt 100{{$}} + +// RUN: %clang -target riscv32-unknown-linux-gnu -march=rv32i -x c -E -dM %s \

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

2023-09-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/66553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

2023-09-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL resolved https://github.com/llvm/llvm-project/pull/66553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

2023-09-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/66553 >From d67dbfb1e926e90b2f4a067c86732bd41783791d Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Fri, 15 Sep 2023 21:39:17 + Subject: [PATCH] [clang-tidy] Fix handling --driver-mode= Driver mode passed as

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

2023-09-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From 83b81df954391c38c123a116ab5c39acd29a3a87 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [Driver] Change default PCH extension name from .gch to .pch (PR #66165)

2023-09-16 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/66165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4da1c18 - [Driver] Change default PCH extension name from .gch to .pch (#66165)

2023-09-16 Thread via cfe-commits
Author: Fangrui Song Date: 2023-09-16T00:27:45-07:00 New Revision: 4da1c180b996ca0a7f8d64782d1a875eb162ce9c URL: https://github.com/llvm/llvm-project/commit/4da1c180b996ca0a7f8d64782d1a875eb162ce9c DIFF: https://github.com/llvm/llvm-project/commit/4da1c180b996ca0a7f8d64782d1a875eb162ce9c.diff

[clang] Introduce paged vector (PR #66430)

2023-09-16 Thread Richard Smith via cfe-commits
@@ -0,0 +1,133 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-16 Thread Richard Smith via cfe-commits
@@ -0,0 +1,131 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-16 Thread Richard Smith via cfe-commits
@@ -1625,6 +1625,35 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h

[clang] Introduce paged vector (PR #66430)

2023-09-16 Thread Richard Smith via cfe-commits
@@ -1625,6 +1625,35 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h

  1   2   >