[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

2023-09-17 Thread Nikolas Klauser via Phabricator via cfe-commits
philnik abandoned this revision. philnik added a comment. Abandoning, since it seems like we want to extend `diagnose_if` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157572/new/ https://reviews.llvm.org/D157572

[clang] [InstSimplify] Fold icmp of `X and/or C1` and `X and/or C2` into constant (PR #65905)

2023-09-17 Thread via cfe-commits
https://github.com/goldsteinn approved this pull request. https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Fold icmp of `X and/or C1` and `X and/or C2` into constant (PR #65905)

2023-09-17 Thread via cfe-commits
https://github.com/goldsteinn approved this pull request. https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstSimplify] Fold icmp of `X and/or C1` and `X and/or C2` into constant (PR #65905)

2023-09-17 Thread via cfe-commits
goldsteinn wrote: LGTM, but please cleanup commits. https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Fold icmp of `X and/or C1` and `X and/or C2` into constant (PR #65905)

2023-09-17 Thread via cfe-commits
goldsteinn wrote: LGTM, but please cleanup commits. https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

2023-09-17 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Sorry for letting this collect dust. I think it's a valuable addition, and looks pretty good, except that I think we should use the expected exit set instead of the entry set. These can be legitimately different for appropriately annotated functions, i.e. with

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-17 Thread via cfe-commits
@@ -1333,7 +1333,15 @@ void StmtProfiler::VisitPredefinedExpr(const PredefinedExpr *S) { void StmtProfiler::VisitIntegerLiteral(const IntegerLiteral *S) { VisitExpr(S); S->getValue().Profile(ID); - ID.AddInteger(S->getType()->castAs()->getKind()); + + int FoldingSetID =

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-17 Thread via cfe-commits
https://github.com/vabridgers resolved https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-17 Thread via cfe-commits
@@ -0,0 +1,10 @@ +// RUN: %check_clang_tidy %s bugprone-inc-dec-in-conditions %t + +#define foo(x) \ + ({ \ +_BitInt(5) y = x; \

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-17 Thread via cfe-commits
https://github.com/vabridgers resolved https://github.com/llvm/llvm-project/pull/65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-17 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/65889 >From 753f8fd0fba767a5ba1abd30d35df379292e454c Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Sat, 9 Sep 2023 12:19:07 +0200 Subject: [PATCH] [clang] [C23] Fix crash with _BitInt running clang-tidy This

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-17 Thread via cfe-commits
https://github.com/vabridgers edited https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-17 Thread via cfe-commits
https://github.com/vabridgers resolved https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-17 Thread via cfe-commits
@@ -598,6 +598,12 @@ SVal SValBuilder::evalIntegralCast(ProgramStateRef state, SVal val, APSIntType ToType(getContext().getTypeSize(castTy), castTy->isUnsignedIntegerType()); llvm::APSInt ToTypeMax = ToType.getMaxValue(); + // With the introduction of

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-17 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/65887 >From ae0b0a015778e38041ee0a0d00f7be38c2c81226 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Sat, 9 Sep 2023 21:08:47 +0200 Subject: [PATCH] [analyzer] Do not use APInt methods on _BitInt() Types

[clang] [analyzer] Do not use APInt methods on _BitInt() Types (PR #65887)

2023-09-17 Thread via cfe-commits
@@ -0,0 +1,11 @@ + // RUN: %clang_analyze_cc1 -analyzer-checker=core \ + // RUN: -analyzer-checker=debug.ExprInspection \ + // RUN: -verify %s + +// Don't crash when using _BitInt() +// expected-no-diagnostics +_BitInt(256) a; +_BitInt(129) b; +void c() { + b = a; +}

[clang-tools-extra] [clang-tidy] Avoid checking magic numbers if _BitInt (PR #65888)

2023-09-17 Thread via cfe-commits
https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/65888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4b5366c - [clang-tidy] Avoid checking magic numbers if _BitInt (#65888)

2023-09-17 Thread via cfe-commits
Author: vabridgers Date: 2023-09-17T14:00:57-05:00 New Revision: 4b5366c9512aa273a5272af1d833961e1ed156e7 URL: https://github.com/llvm/llvm-project/commit/4b5366c9512aa273a5272af1d833961e1ed156e7 DIFF: https://github.com/llvm/llvm-project/commit/4b5366c9512aa273a5272af1d833961e1ed156e7.diff

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

2023-09-17 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. This was never mentioned in the review, but I have a late question: Why did we need to implement a new flag, instead of using `getFullyQualifiedName` from `QualTypeNames.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

2023-09-17 Thread Carlos Galvez via cfe-commits
@@ -207,11 +211,13 @@ void UseEmplaceCheck::registerMatchers(MatchFinder *Finder) { auto HasConstructExpr = has(ignoringImplicit(SoughtConstructExpr)); // allow for T{} to be replaced, even if no CTOR is declared - auto HasConstructInitListExpr = has(initListExpr(anyOf(

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

2023-09-17 Thread Carlos Galvez via cfe-commits
@@ -207,11 +211,13 @@ void UseEmplaceCheck::registerMatchers(MatchFinder *Finder) { auto HasConstructExpr = has(ignoringImplicit(SoughtConstructExpr)); // allow for T{} to be replaced, even if no CTOR is declared - auto HasConstructInitListExpr = has(initListExpr(anyOf(

[clang-tools-extra] [clang-tidy] Fix bug in modernize-use-emplace (PR #66169)

2023-09-17 Thread Carlos Galvez via cfe-commits
@@ -1332,6 +1337,17 @@ void testBracedInitTemporaries() { v3.push_back(NonTrivialWithCtor{{}}); v3.push_back({{0}}); v3.push_back({{}}); + + std::vector v4; + + // These should not be noticed or fixed; after the correction, the code won't + // compile. +

[clang-tools-extra] [clang-tidy] Update llvmlibc-implementation-in-namespace to new rules (PR #66504)

2023-09-17 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp commented: Should this change be reflected in the Release Notes? https://github.com/llvm/llvm-project/pull/66504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/65845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Fold icmp of `X and/or C1` and `X and/or C2` into constant (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstSimplify] Fold icmp of `X and/or C1` and `X and/or C2` into constant (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstSimplify] Fold icmp of `X and/or C1` and `X and/or C2` into constant (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Fold icmp of `X and/or C1` and `X and/or C2` into constant (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65905 >From f178af6d47ce6d982c6568ba6e0db517de124291 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Mon, 11 Sep 2023 02:01:12 +0800 Subject: [PATCH 1/2] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 &

[clang] [AArch64]: Refactor target parser to use Bitset. (PR #65423)

2023-09-17 Thread Craig Topper via cfe-commits
@@ -96,65 +97,67 @@ static_assert(FEAT_MAX <= 64, // Arch extension modifiers for CPUs. These are labelled with their Arm ARM // feature name (though the canonical reference for those is AArch64.td) // clang-format off -enum ArchExtKind : uint64_t { - AEK_NONE =1, -

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-17 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 1/5] [clang-tidy]

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-17 Thread via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-17 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Yes, cc1 flag would be useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-17 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D74094#4646975 , @xbolva00 wrote: >>> So we can start by giving these objects full-expression lifetime, chase >>> down any program bugs that that uncovers (which will all *unquestionably* >>> be program bugs under the

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

2023-09-17 Thread Luo Jia via Phabricator via cfe-commits
luojia added a comment. In D70401#4635875 , @koute wrote: > I know that there are still open issues regarding the psABI, but considering > how slow it's been going, couldn't we merge this in anyway and mark it as > experimental and subject to change?

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 689b322408caff8340ffef4dd526d3640958ea03 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 16:52:15 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 7bbe54c0649c2abd29d51e538d2b0bf77359d0f8 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 16:16:40 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Changes This patch simplifies the pattern `icmp X C1, X C2` when one constant mask is the subset of the other. Alive2: https://alive2.llvm.org/ce/z/s-IEK7 Fixes #65833. --- Full diff:

[clang] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65905 >From f178af6d47ce6d982c6568ba6e0db517de124291 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Mon, 11 Sep 2023 02:01:12 +0800 Subject: [PATCH] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2)

[clang] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2) == C1/C2` (PR #65905)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65905 >From f178af6d47ce6d982c6568ba6e0db517de124291 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Mon, 11 Sep 2023 02:01:12 +0800 Subject: [PATCH] [InstSimplify] Simplify `icmp X & C1, X & C2` when `(C1 & C2)

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 17f855f12757ee66ff99cf24abe4be0dcffc3532 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 15:42:27 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang-tools-extra] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 6111b800196cee9ee45ebb5c800e17e56b843152 Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 15:24:23 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang-tools-extra] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65845 >From 91af70acd72c8e889f542ba6dfff6401b89b2dc5 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 16:47:24 +0800 Subject: [PATCH 1/2] [InstCombine] Fix transforms of select (~a | c), a, b and

[clang] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65845 >From 91af70acd72c8e889f542ba6dfff6401b89b2dc5 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 16:47:24 +0800 Subject: [PATCH 1/2] [InstCombine] Fix transforms of select (~a | c), a, b and

[clang] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65845 >From 91af70acd72c8e889f542ba6dfff6401b89b2dc5 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 16:47:24 +0800 Subject: [PATCH] [InstCombine] Fix transforms of select (~a | c), a, b and select

[clang-tools-extra] [InstCombine] Fix transforms of two select patterns (PR #65845)

2023-09-17 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65845 >From 91af70acd72c8e889f542ba6dfff6401b89b2dc5 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 16:47:24 +0800 Subject: [PATCH] [InstCombine] Fix transforms of select (~a | c), a, b and select

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From ac90fe17df0f7212e675ddf38dbce5b608933b8e Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 14:20:10 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 633e258d41bf15e77f592f4e95eda729e6da5a4b Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 14:16:13 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
cbalint13 wrote: @DavidSpickett , > * We can limit to list flags only for a desired e.g. -mcpu=XYZ, so the user > can query like: > Let me know if it would be another interesting command-line feature, I'll be > happy doing it in a subsecvent PR. Implemented the -mcpu filter option too. ``` $

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

2023-09-17 Thread Balint Cristian via cfe-commits
https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From fbbc72c2f3d0cbcbb34eca2c9dcb6214076d38de Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 14:06:05 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-17 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. >> So we can start by giving these objects full-expression lifetime, chase down >> any program bugs that that uncovers (which will all *unquestionably* be >> program bugs under the standard), and then gradually work on landing the >> more aggressive rule (perhaps even

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-17 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 1/4] [clang-tidy]

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

2023-09-17 Thread Younan Zhang via Phabricator via cfe-commits
zyounan added a comment. Thank you Nathan for your constructive opinions! I've updated this patch again, hopefully this becomes better. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1387 - // When completing a non-static member function (and not via - // dot/arrow

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

2023-09-17 Thread Younan Zhang via Phabricator via cfe-commits
zyounan updated this revision to Diff 556909. zyounan marked 2 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files:

[clang] de56ceb - [clang] fix stray whitespace in release notes to fix CI failure

2023-09-17 Thread via cfe-commits
Author: Nuno Lopes Date: 2023-09-17T10:25:53+01:00 New Revision: de56ceb54a14487245ec70d2a291182a9501d9ba URL: https://github.com/llvm/llvm-project/commit/de56ceb54a14487245ec70d2a291182a9501d9ba DIFF: https://github.com/llvm/llvm-project/commit/de56ceb54a14487245ec70d2a291182a9501d9ba.diff

[clang] Document runtime config directory options (PR #66593)

2023-09-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes In the clang user manual the build options `CLANG_CONFIG_FILE_USER_DIR` and `CLANG_CONFIG_FILE_SYSTEM_DIR` are documented, but the run time overrides `--config-user-dir` and `--config-system-dir` are not. I have updated the manual to add

[clang] Document runtime config directory options (PR #66593)

2023-09-17 Thread via cfe-commits
https://github.com/xbjfk created https://github.com/llvm/llvm-project/pull/66593 In the clang user manual the build options `CLANG_CONFIG_FILE_USER_DIR` and `CLANG_CONFIG_FILE_SYSTEM_DIR` are documented, but the run time overrides `--config-user-dir` and `--config-system-dir` are not. I have

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

2023-09-17 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D74094#4646297 , @tellenbach wrote: > No real comment on the issue itself but on the example as a former Eigen > maintainer (sorry for the noise if that's all obvious for you): > > auto round (Tensor m) { > return (m