[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread via cfe-commits
@@ -6380,7 +6380,74 @@ Instruction *InstCombinerImpl::foldICmpUsingBoolRange(ICmpInst ) { Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULE) return BinaryOperator::CreateOr(Builder.CreateIsNull(X), Y); + // icmp eq/ne X, (zext/sext (icmp eq/ne X,

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread via cfe-commits
@@ -6380,7 +6380,74 @@ Instruction *InstCombinerImpl::foldICmpUsingBoolRange(ICmpInst ) { Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULE) return BinaryOperator::CreateOr(Builder.CreateIsNull(X), Y); + // icmp eq/ne X, (zext/sext (icmp eq/ne X,

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread via cfe-commits
@@ -6380,7 +6380,74 @@ Instruction *InstCombinerImpl::foldICmpUsingBoolRange(ICmpInst ) { Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULE) return BinaryOperator::CreateOr(Builder.CreateIsNull(X), Y); + // icmp eq/ne X, (zext/sext (icmp eq/ne X,

[clang] [clang][doc] Add documentation for the ASTs used to represent C++ templates (PR #66436)

2023-09-18 Thread Scott McPeak via cfe-commits
smcpeak wrote: # On the utility of the diagrams I'm surprised this is a point of contention. Could someone elaborate on why the diagrams are troublesome? To me, saying that the diagrams are not useful is sort of like saying the `-ast-dump` output is not useful. Isn't it better to be able

[clang] [Clang] Fix a crash in the diagnostic emission of invalid immediate calls (PR #66699)

2023-09-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/66699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes When dealing with short-circuiting coroutines (e.g. `expected`), the deferred calls that resolve the `get_return_object` are currently being emitted *after* we delete the coroutine frame. This was caught by ASAN when using

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-18 Thread Alexander Smarus via cfe-commits
lxbndr wrote: A short summary of changes: - added link to the issue - narrowed checks to aim cl.exe only (clang-cl.exe doesn't need this) - changed approach a bit. Now we're looking for /O2 and /O1 flags in the general flag set for the current configuration. Last effective found flag is

[clang] [Clang][Coroutines] Improve GRO handling to better fit scopes and cleanups (PR #66706)

2023-09-18 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes created https://github.com/llvm/llvm-project/pull/66706 When dealing with short-circuiting coroutines (e.g. `expected`), the deferred calls that resolve the `get_return_object` are currently being emitted *after* we delete the coroutine frame. This was caught

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > I think the 2013 GCC feature adding -fuse-ld= made this change, which is, > > frankly, strange. I wish that we don't this... > > It's too late now. Build system code in the wild uses `$CC > -print-prog-name=ld` and then expects to be able to invoke that program to > get

[clang] Fix math-errno issue (PR #66381)

2023-09-18 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel approved this pull request. https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158476: [driver] Search for compatible Android runtime directories

2023-09-18 Thread Pirama Arumuga Nainar via Phabricator via cfe-commits
pirama accepted this revision. pirama added a comment. LGTM from the Android platform/NDK side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158476/new/ https://reviews.llvm.org/D158476 ___ cfe-commits

[clang] Re-apply "[Parse] Split incremental-extensions" (PR #66446)

2023-09-18 Thread Ben Barham via cfe-commits
bnbarham wrote: > I have no objections to this if that makes your workflow work. However I > think this cures the symptom and not the real cause. It might be worth > investigating how to adapt lldb to the incremental processing change more > deeply. To be clear, this is re-applying

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes MSVC has a major performance regression observed when targeting ARM64 since v19.32 (VS 17.2.0). `cl.exe` spends a lot of time on compiling `StandardLibrary.cpp` and `CGBuiltin.cpp`, and total build duration rises extremely. This makes

[clang] Workaround for MSVC ARM64 build performance regression (PR #65215)

2023-09-18 Thread Alexander Smarus via cfe-commits
https://github.com/lxbndr updated https://github.com/llvm/llvm-project/pull/65215 >From c97d9a28ef8cdb232670a960a46bc30b269983f7 Mon Sep 17 00:00:00 2001 From: Alexander Smarus Date: Tue, 19 Sep 2023 00:34:54 +0300 Subject: [PATCH] Workaround for MSVC ARM64 build performance regression ---

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #65887)

2023-09-18 Thread Björn Pettersson via cfe-commits
bjope wrote: I reverted this patch since buildbots have been complaining for almost an hour. Here is the first failure mail I got: ``` The Buildbot has detected a failed build on builder clang-armv8-quick while building clang. Full details are available at:

[clang] Support target names with dots in more utilities (PR #65812)

2023-09-18 Thread via cfe-commits
https://github.com/dankm updated https://github.com/llvm/llvm-project/pull/65812 >From 4a30a862b41aa6c570b0dc4d1eb82a7feef4ed8e Mon Sep 17 00:00:00 2001 From: Dan McGregor Date: Mon, 14 Aug 2023 18:44:08 -0600 Subject: [PATCH 1/2] Support: hoist lld's executable name code to Path Instead of

[clang] 929662b - Revert "[analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (#65887)"

2023-09-18 Thread Bjorn Pettersson via cfe-commits
Author: Bjorn Pettersson Date: 2023-09-18T23:35:48+02:00 New Revision: 929662b489225ac22dd59553f1c67842abe4dd29 URL: https://github.com/llvm/llvm-project/commit/929662b489225ac22dd59553f1c67842abe4dd29 DIFF:

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread Roland McGrath via cfe-commits
frobtech wrote: > I think the 2013 GCC feature adding -fuse-ld= made this change, which is, > frankly, strange. I wish that we don't this... It's too late now. Build system code in the wild uses `$CC -print-prog-name=ld` and then expects to be able to invoke that program to get the linker

[clang] [RISCV] Recognize veyron-v1 processor in clang driver. (PR #66703)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Subsequent PRs will add the scheduling model and support for macro fusions. --- Full diff: https://github.com/llvm/llvm-project/pull/66703.diff 3 Files Affected: - (modified) clang/test/Driver/riscv-cpus.c (+25) - (modified)

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread Fangrui Song via cfe-commits
MaskRay wrote: I think the 2013 GCC feature adding -fuse-ld= made this change, which is, frankly, strange. I wish that we don't this... lld has several names. For windows-msvc target triples it is `lld-link`, and for wasm triples it is wasm-ld. https://github.com/llvm/llvm-project/pull/66698

[clang] [RISCV] Recognize veyron-v1 processor in clang driver. (PR #66703)

2023-09-18 Thread via cfe-commits
https://github.com/mgudim created https://github.com/llvm/llvm-project/pull/66703 Subsequent PRs will add the scheduling model and support for macro fusions. >From 414ecd5d2abe13767668a89045be2ef2f460509d Mon Sep 17 00:00:00 2001 From: Mikhail Gudim Date: Mon, 18 Sep 2023 17:01:40 -0400

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread Roland McGrath via cfe-commits
https://github.com/frobtech ready_for_review https://github.com/llvm/llvm-project/pull/66698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Changes Enable -rpath, -shared, and -static for the flang frontend. This brings it in line with clang. Fixes issue #65546. --- Full diff: https://github.com/llvm/llvm-project/pull/66702.diff 2 Files Affected: - (modified)

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

2023-09-18 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu created https://github.com/llvm/llvm-project/pull/66702 Enable -rpath, -shared, and -static for the flang frontend. This brings it in line with clang. Fixes issue #65546. >From 3302fb4937d75c0920e7bcf8f215e12fbe770a36 Mon Sep 17 00:00:00 2001 From: Tarun Prabhu

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

2023-09-18 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/66122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DependencyScanningFilesystem] Make sure the local/shared cache filename lookups use only absolute paths (PR #66122)

2023-09-18 Thread Ben Langmuir via cfe-commits
@@ -330,3 +359,24 @@ DependencyScanningWorkerFilesystem::openFileForRead(const Twine ) { return Result.getError(); return DepScanFile::create(Result.get()); } + +std::error_code DependencyScanningWorkerFilesystem::setCurrentWorkingDirectory( +const Twine ) { +

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-18 Thread Artem Belevich via cfe-commits
@@ -794,7 +794,7 @@ void CodeGenModule::Release() { AddGlobalCtor(ObjCInitFunction); if (Context.getLangOpts().CUDA && CUDARuntime) { if (llvm::Function *CudaCtorFunction = CUDARuntime->finalizeModule()) - AddGlobalCtor(CudaCtorFunction); +

[libunwind] [libunwind][AIX] Fix up TOC register if unw_getcontext is called from a different module (PR #66549)

2023-09-18 Thread via cfe-commits
https://github.com/stephenpeckham commented: No further comments https://github.com/llvm/llvm-project/pull/66549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix a crash in the diagnostic emission of invalid immediate calls (PR #66699)

2023-09-18 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/66699 >From c3267c587368eec3744640f895f9fc88d6c4414d Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Mon, 18 Sep 2023 23:06:11 +0200 Subject: [PATCH] [Clang] Fix a crash in the diagnostic emission of invalid

[clang] [Clang] Fix a crash in the diagnostic emission of invalid immediate calls (PR #66699)

2023-09-18 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/66699 `CXXCtorInitializer` may not refer to a FieldDecl because it might also denote another constructor call. Fixes #66324 >From b7438d2ea42fbdaabaea186fb0d185712fd48826 Mon Sep 17 00:00:00 2001 From: Corentin

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes GCC makes `-print-prog-name=ld` a special case that looks up the linker that will be used according to the `-fuse-ld=...` option state. This makes Clang follow suit. --- Full diff: https://github.com/llvm/llvm-project/pull/66698.diff 2

[clang] [clang][Driver] Obey -fuse-ld=... for -print-prog-name=ld output (PR #66698)

2023-09-18 Thread Roland McGrath via cfe-commits
https://github.com/frobtech created https://github.com/llvm/llvm-project/pull/66698 GCC makes `-print-prog-name=ld` a special case that looks up the linker that will be used according to the `-fuse-ld=...` option state. This makes Clang follow suit. >From

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-18 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/66658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-18 Thread Vassil Vassilev via cfe-commits
@@ -794,7 +794,7 @@ void CodeGenModule::Release() { AddGlobalCtor(ObjCInitFunction); if (Context.getLangOpts().CUDA && CUDARuntime) { if (llvm::Function *CudaCtorFunction = CUDARuntime->finalizeModule()) - AddGlobalCtor(CudaCtorFunction); +

[clang] [clang] Fix null dereference on return in lambda attribute statement expr (PR #66643)

2023-09-18 Thread Shafik Yaghmour via cfe-commits
shafik wrote: LGTM https://github.com/llvm/llvm-project/pull/66643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

2023-09-18 Thread Bill Wendling via Phabricator via cfe-commits
void added inline comments. Comment at: clang/include/clang/AST/Decl.h:4272-4275 +FieldDecl *FD = nullptr; +for (FieldDecl *Field : fields()) + FD = Field; +return FD; erichkeane wrote: > aaron.ballman wrote: > > void wrote: > > > aaron.ballman

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-18 Thread Erich Keane via cfe-commits
@@ -1333,7 +1333,14 @@ void StmtProfiler::VisitPredefinedExpr(const PredefinedExpr *S) { void StmtProfiler::VisitIntegerLiteral(const IntegerLiteral *S) { VisitExpr(S); S->getValue().Profile(ID); - ID.AddInteger(S->getType()->castAs()->getKind()); + + QualType T =

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread via cfe-commits
https://github.com/mgudim closed https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-18 Thread Artem Belevich via cfe-commits
@@ -794,7 +794,7 @@ void CodeGenModule::Release() { AddGlobalCtor(ObjCInitFunction); if (Context.getLangOpts().CUDA && CUDARuntime) { if (llvm::Function *CudaCtorFunction = CUDARuntime->finalizeModule()) - AddGlobalCtor(CudaCtorFunction); +

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #65887)

2023-09-18 Thread via cfe-commits
https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4898c33 - [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (#65887)

2023-09-18 Thread via cfe-commits
Author: vabridgers Date: 2023-09-18T15:18:33-05:00 New Revision: 4898c33527f90b067f353a115442a9a702319fce URL: https://github.com/llvm/llvm-project/commit/4898c33527f90b067f353a115442a9a702319fce DIFF: https://github.com/llvm/llvm-project/commit/4898c33527f90b067f353a115442a9a702319fce.diff

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #65887)

2023-09-18 Thread via cfe-commits
https://github.com/vabridgers edited https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash analyzing _BitInt() in evalIntegralCast (PR #65887)

2023-09-18 Thread via cfe-commits
https://github.com/vabridgers edited https://github.com/llvm/llvm-project/pull/65887 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-18 Thread Louis Dionne via cfe-commits
@@ -37,9 +37,10 @@ struct __fn { _LIBCPP_ASSERT_UNCATEGORIZED(!bool(std::invoke(__comp, std::invoke(__proj, __high), std::invoke(__proj, __low))), "Bad bounds passed to std::ranges::clamp"); -if (std::invoke(__comp,

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-18 Thread Louis Dionne via cfe-commits
@@ -108,7 +108,34 @@ constexpr bool test() { auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove { return x; }; assert(::ranges::clamp(val, low, high, moving_comp, prvalue_proj) == ); } + { // Make sure we don't call the projection more than three

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-18 Thread Louis Dionne via cfe-commits
@@ -108,7 +108,34 @@ constexpr bool test() { auto prvalue_proj = [](const CheckDoubleMove& x) -> CheckDoubleMove { return x; }; assert(::ranges::clamp(val, low, high, moving_comp, prvalue_proj) == ); } + { // Make sure we don't call the projection more than three

[clang] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-18 Thread via cfe-commits
@@ -1333,7 +1333,14 @@ void StmtProfiler::VisitPredefinedExpr(const PredefinedExpr *S) { void StmtProfiler::VisitIntegerLiteral(const IntegerLiteral *S) { VisitExpr(S); S->getValue().Profile(ID); - ID.AddInteger(S->getType()->castAs()->getKind()); + + QualType T =

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

2023-09-18 Thread Louis Dionne via cfe-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

2023-09-18 Thread via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 1/6] [clang-tidy]

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153132: [clang analysis][NFCI] Preparatory work for D153131.

2023-09-18 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D153132#4431627 , @courbet wrote: >> Is this actually required for the subsequent change? I don't see the >> connection. > > In the followup change, we have to check the returns after the enter and exit > CFG block are

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw resolved https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
@@ -366,19 +366,10 @@ define void @simplify_before_foldAndOfICmps(ptr %p) { ; CHECK-LABEL: @simplify_before_foldAndOfICmps( ; CHECK-NEXT:[[A8:%.*]] = alloca i16, align 2 ; CHECK-NEXT:[[L7:%.*]] = load i16, ptr [[A8]], align 2 -; CHECK-NEXT:[[TMP1:%.*]] = icmp eq

[clang-tools-extra] [clang] [C23] Fix crash with _BitInt running clang-tidy (PR #65889)

2023-09-18 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/65889 >From 73d3a59e98ca78931e07428f945c26107812383b Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Sat, 9 Sep 2023 12:19:07 +0200 Subject: [PATCH] [clang] [C23] Fix crash with _BitInt running clang-tidy This

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq c))` (PR #65852)

2023-09-18 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 1/5] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

2023-09-18 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert accepted this revision. aaronpuchert added a subscriber: rupprecht. aaronpuchert added a comment. This revision is now accepted and ready to land. Looks good to me, but let's wait a few days in case @aaron.ballman has anything to add. @rupprecht, in case you're still doing

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread Michael Maitland via cfe-commits
michaelmaitland wrote: > > I think you can drop the merge commit using `git rebase -i`. You may have > > to pass `--rebase-merges` to have the ability to drop the merge commit. > > Then you can pull upstream and `git rebase upstream/main`. > > Thanks Michael, I tried but messed it up (I see

[clang] [clang] Fix null dereference on return in lambda attribute statement expr (PR #66643)

2023-09-18 Thread Piotr Fusik via cfe-commits
pfusik wrote: Rebased resolving the conflict in release notes. https://github.com/llvm/llvm-project/pull/66643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix null dereference on return in lambda attribute statement expr (PR #66643)

2023-09-18 Thread Piotr Fusik via cfe-commits
https://github.com/pfusik updated https://github.com/llvm/llvm-project/pull/66643 >From c313074ca50cae80698154991273717e5a8cc13a Mon Sep 17 00:00:00 2001 From: Piotr Fusik Date: Mon, 18 Sep 2023 19:56:10 +0200 Subject: [PATCH] [clang] Fix null dereference on return in lambda attribute

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread via cfe-commits
mgudim wrote: > I think you can drop the merge commit using `git rebase -i`. You may have to > pass `--rebase-merges` to have the ability to drop the merge commit. Then you > can pull upstream and `git rebase upstream/main`. Thanks Michael, I tried but messed it up (I see more changes than I

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread via cfe-commits
https://github.com/mgudim updated https://github.com/llvm/llvm-project/pull/65535 >From 8dff19fbb00ce7dcd818eb851601b36a7cdeea42 Mon Sep 17 00:00:00 2001 From: Mikhail Gudim Date: Wed, 6 Sep 2023 17:15:56 -0400 Subject: [PATCH 1/2] [RISCV] Added definition of Ventana veyron-v1 processor. ---

[clang-tools-extra] [clang-tidy] Fix handling --driver-mode= (PR #66553)

2023-09-18 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/66553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

2023-09-18 Thread Douglas Yung via Phabricator via cfe-commits
dyung added a comment. Sorry to comment so late, but I just had time to look into this a little bit. This change broke running lit tests for me on Windows, and I wanted to see if there was a way I could restore it. For reference, my sources are stored locally at `C:\Dev\git\dev`, but I until

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

2023-09-18 Thread Tom Honermann via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG256a0b298c68: [clang] Correct source locations for instantiations of function templates. (authored by tahonermann). Repository: rG LLVM Github

[clang] 256a0b2 - [clang] Correct source locations for instantiations of function templates.

2023-09-18 Thread Tom Honermann via cfe-commits
Author: Tom Honermann Date: 2023-09-18T12:51:45-07:00 New Revision: 256a0b298c68b89688b80350b034daf2f7785b67 URL: https://github.com/llvm/llvm-project/commit/256a0b298c68b89688b80350b034daf2f7785b67 DIFF: https://github.com/llvm/llvm-project/commit/256a0b298c68b89688b80350b034daf2f7785b67.diff

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/66683 >From 5b4748e3ae06a5b90ecb2c84b7df989a94733175 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 18 Sep 2023 11:38:12 -0700 Subject: [PATCH 1/2] In ExprRequirement building, treat OverloadExpr as

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread Erich Keane via cfe-commits
@@ -9063,7 +9063,8 @@ Sema::BuildExprRequirement( concepts::ExprRequirement::ReturnTypeRequirement ReturnTypeRequirement) { auto Status = concepts::ExprRequirement::SS_Satisfied; ConceptSpecializationExpr *SubstitutedConstraintExpr = nullptr; - if

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread Erich Keane via cfe-commits
erichkeane wrote: > Do we need a release note for this (probably!)? Bah, yes we do... https://github.com/llvm/llvm-project/pull/66683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

2023-09-18 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann updated this revision to Diff 556970. tahonermann added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64087/new/ https://reviews.llvm.org/D64087 Files: clang/docs/ReleaseNotes.rst

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread via cfe-commits
cor3ntin wrote: Do we need a release note for this (probably!)? https://github.com/llvm/llvm-project/pull/66683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread via cfe-commits
@@ -9063,7 +9063,8 @@ Sema::BuildExprRequirement( concepts::ExprRequirement::ReturnTypeRequirement ReturnTypeRequirement) { auto Status = concepts::ExprRequirement::SS_Satisfied; ConceptSpecializationExpr *SubstitutedConstraintExpr = nullptr; - if

[clang-tools-extra] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland resolved https://github.com/llvm/llvm-project/pull/65535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159292: [driver] Conditionally include installed libc++ headers for Android

2023-09-18 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb1e3cd1d7944: [driver] Conditionally include installed libc++ headers for Android (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159293: [driver] Perform fallback target searches for stdlib

2023-09-18 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1212d1b51125: [driver] Perform fallback target searches for stdlib (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159293/new/

[clang] 1212d1b - [driver] Perform fallback target searches for stdlib

2023-09-18 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-09-18T12:18:51-07:00 New Revision: 1212d1b511251de69939c8aa380f660373e26419 URL: https://github.com/llvm/llvm-project/commit/1212d1b511251de69939c8aa380f660373e26419 DIFF: https://github.com/llvm/llvm-project/commit/1212d1b511251de69939c8aa380f660373e26419.diff

[clang] b1e3cd1 - [driver] Conditionally include installed libc++ headers for Android

2023-09-18 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-09-18T12:18:45-07:00 New Revision: b1e3cd1d79443603dc003441e07cdd8d30bb7f26 URL: https://github.com/llvm/llvm-project/commit/b1e3cd1d79443603dc003441e07cdd8d30bb7f26 DIFF: https://github.com/llvm/llvm-project/commit/b1e3cd1d79443603dc003441e07cdd8d30bb7f26.diff

[clang] Support target names with dots in more utilities (PR #65812)

2023-09-18 Thread via cfe-commits
@@ -5,11 +5,14 @@ # RUN: mkdir %t # RUN: ln -s llvm-ranlib %t/llvm-ranlib-9 # RUN: ln -s llvm-ranlib %t/ranlib.exe +# RUN: ln -s llvm-ranlib %t/x86_64-unknown-freebsd13.2-llvm-ranlib dankm wrote: Yep, your second point is why I didn't bother making the second

[clang-tools-extra] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread Michael Maitland via cfe-commits
michaelmaitland wrote: > Is there a way to fix this now? I think you can drop the merge commit using `git rebase -i`. You may have to pass `--rebase-merges` to have the ability to drop the merge commit. Then you can pull upstream and `git rebase upstream/main`.

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread via cfe-commits
mgudim wrote: > > [Merge branch 'llvm:main' into > > mgudim_veyron_def](https://github.com/llvm/llvm-project/pull/65535/commits/454b41eea50a3583ab5c29bffbd46bcd633b) > > The [LLVM GitHub User Guide](https://llvm.org/docs//GitHub.html) recommends > to rebase on main instead of merge main.

[clang-tools-extra] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread Michael Maitland via cfe-commits
michaelmaitland wrote: > [Merge branch 'llvm:main' into > mgudim_veyron_def](https://github.com/llvm/llvm-project/pull/65535/commits/454b41eea50a3583ab5c29bffbd46bcd633b) The [LLVM GitHub User Guide](https://llvm.org/docs//GitHub.html) recommends to rebase on main instead of merge main.

[PATCH] D158730: [DebugMetadata][DwarfDebug] Don't retain local types with -fno-eliminate-unused-debug-types

2023-09-18 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. Nice and easy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158730/new/ https://reviews.llvm.org/D158730 ___ cfe-commits mailing list

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread Erich Keane via cfe-commits
@@ -9063,7 +9063,8 @@ Sema::BuildExprRequirement( concepts::ExprRequirement::ReturnTypeRequirement ReturnTypeRequirement) { auto Status = concepts::ExprRequirement::SS_Satisfied; ConceptSpecializationExpr *SubstitutedConstraintExpr = nullptr; - if

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes As reported in #66612, we aren't correctly treating the placeholder expression type correctly, so we ended up trying to get a reference version of it, and this resulted in an assertion, since the placeholder type cannot have a reference

[clang] In ExprRequirement building, treat OverloadExpr as dependent (PR #66683)

2023-09-18 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/66683 As reported in #66612, we aren't correctly treating the placeholder expression type correctly, so we ended up trying to get a reference version of it, and this resulted in an assertion, since the placeholder

[clang-tools-extra] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread via cfe-commits
https://github.com/mgudim updated https://github.com/llvm/llvm-project/pull/65535 >From d1ba27988840703b9a7a12ad48ecfb282752e7e2 Mon Sep 17 00:00:00 2001 From: Mikhail Gudim Date: Wed, 6 Sep 2023 17:15:56 -0400 Subject: [PATCH 1/2] [RISCV] Added definition of Ventana veyron-v1 processor. ---

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread via cfe-commits
https://github.com/mgudim updated https://github.com/llvm/llvm-project/pull/65535 >From d1ba27988840703b9a7a12ad48ecfb282752e7e2 Mon Sep 17 00:00:00 2001 From: Mikhail Gudim Date: Wed, 6 Sep 2023 17:15:56 -0400 Subject: [PATCH 1/2] [RISCV] Added definition of Ventana veyron-v1 processor. ---

[clang] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-18 Thread via cfe-commits
https://github.com/mgudim updated https://github.com/llvm/llvm-project/pull/65535 >From d1ba27988840703b9a7a12ad48ecfb282752e7e2 Mon Sep 17 00:00:00 2001 From: Mikhail Gudim Date: Wed, 6 Sep 2023 17:15:56 -0400 Subject: [PATCH 1/2] [RISCV] Added definition of Ventana veyron-v1 processor. ---

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -2325,6 +2325,7 @@ void CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D, B.addAttribute(llvm::Attribute::Naked); // OptimizeNone wins over OptimizeForSize and MinSize. +F->removeFnAttr(llvm::Attribute::OptimizeForDebugging);

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -7944,9 +7944,13 @@ void ASTReader::PrintStats() { std::fprintf(stderr, "*** AST File Statistics:\n"); unsigned NumTypesLoaded = - TypesLoaded.size() - llvm::count(TypesLoaded, QualType()); + TypesLoaded.size() - std::count(TypesLoaded.materialisedBegin(),

[clang] Introduce paged vector (PR #66430)

2023-09-18 Thread David Blaikie via cfe-commits
@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

<    1   2   3   4   5   >