[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] [OpenMP] Implicitly include the 'cgpu' and 'mgpu' libraries for OpenMP (PR #67557)

2023-09-27 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67557 >From bdf663fd966546c01cf80e727e72084240cb874a Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 27 Sep 2023 09:03:16 -0500 Subject: [PATCH] [OpenMP] Implicitly include the 'cgpu' and 'mgpu' libraries for

[clang] [clang-format] Disable OuterScope lambda indentation behaviour for constructor initializers (PR #66755)

2023-09-27 Thread Jon Phillips via cfe-commits
jp4a50 wrote: > You should adapt the documentation. Done. Tried to capture the original intention of the option which is to minimize (and make consistent) indentation of lambdas at block scope. This PR addresses the most obvious exception to block scope but there may be more that we can

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: CC @vgvassilev @pcanal @Sterling-Augustine As the removed workaround dates back to the initial implementation imported in 0dd191a5c4bf27cc8a2b6033436b00f0cbdc4ce7 from Cling. https://github.com/llvm/llvm-project/pull/67566 ___

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From ecea06aeedac75896e4d243420bc590e07891713 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH] [clang][MBD] set up module build daemon infrastructure The module

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue deleted https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue deleted https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 4153aeb4e06c6bec6e27dd2c814708a3a8b8c842 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH] [clang][MBD] set up module build daemon infrastructure The module

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9eeb0293e27c0f1b44304fd9681dcd88fd9edc0a 34b4e7939c88627ce433c96cdcc5e54d71ada94d --

[clang] [OpenMP] Implicitly include the 'cgpu' and 'mgpu' libraries for OpenMP (PR #67557)

2023-09-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff cd7f1714dea16261e0362b80958296f9782d625e b87a2fd522c874a222aa497e0db1f5de5d35ff51 --

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes …ation When `clang::TypeName::getFullyQualifiedType`/`clang::TypeName::getFullyQualifiedName` encounter a non-dependent type/type alias that is defined under a templated class/struct, it qualifies the type/type alias under a

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
diseraluca wrote: This might be a breaking change, so I'm not sure if it will be possible to merge it, but I would like to give some context on where the change is coming from. I'm trying (in my position as an employee of The Qt Company), to migrate our documentation generation tool, QDoc,

[clang] Qualify non-dependent types of a class template with the class declar… (PR #67566)

2023-09-27 Thread Luca Di sera via cfe-commits
https://github.com/diseraluca created https://github.com/llvm/llvm-project/pull/67566 …ation When `clang::TypeName::getFullyQualifiedType`/`clang::TypeName::getFullyQualifiedName` encounter a non-dependent type/type alias that is defined under a templated class/struct, it qualifies the

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-27 Thread Erich Keane via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,249 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-27 Thread Alexander Richardson via cfe-commits
arichardson wrote: > > With regard to arguments: I know that the [FreeBSD runtime > > linker](https://github.com/freebsd/freebsd-src/blob/d06328c37bbcf3d3d3c7601372d29237996a6f6a/libexec/rtld-elf/aarch64/rtld_machdep.h#L59) > > (and according to https://stackoverflow.com/a/46331112 also glibc)

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread Erich Keane via cfe-commits
@@ -718,3 +718,8 @@ void foo() { void GH48527() { auto a = []()__attribute__((b(({ return 0; }{}; // expected-warning {{unknown attribute 'b' ignored}} } + +void GH67492() { + constexpr auto test = 42; + auto lambda = (test, []() noexcept(true) {});

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-09-27 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D147844#4651113 , @chaitanyav wrote: > Bootstrapping build failed due to -werror flag > (https://buildkite.com/llvm-project/libcxx-ci/builds/30031) > >| >

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread via cfe-commits
@@ -718,3 +718,8 @@ void foo() { void GH48527() { auto a = []()__attribute__((b(({ return 0; }{}; // expected-warning {{unknown attribute 'b' ignored}} } + +void GH67492() { + constexpr auto test = 42; + auto lambda = (test, []() noexcept(true) {});

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane resolved https://github.com/llvm/llvm-project/pull/67538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread Erich Keane via cfe-commits
@@ -718,3 +718,8 @@ void foo() { void GH48527() { auto a = []()__attribute__((b(({ return 0; }{}; // expected-warning {{unknown attribute 'b' ignored}} } + +void GH67492() { + constexpr auto test = 42; + auto lambda = (test, []() noexcept(true) {});

[clang] [clang][Interp] Three-way comparisons (PR #65901)

2023-09-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/65901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread via cfe-commits
@@ -718,3 +718,8 @@ void foo() { void GH48527() { auto a = []()__attribute__((b(({ return 0; }{}; // expected-warning {{unknown attribute 'b' ignored}} } + +void GH67492() { + constexpr auto test = 42; + auto lambda = (test, []() noexcept(true) {});

[clang] [OpenMP] Implicitly include the 'cgpu' and 'mgpu' libraries for OpenMP (PR #67557)

2023-09-27 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67557 >From b87a2fd522c874a222aa497e0db1f5de5d35ff51 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 27 Sep 2023 09:03:16 -0500 Subject: [PATCH] [OpenMP] Implicitly include the 'lcgpu' and 'lmgpu' libraries

[clang] [analyzer] Fix false negative when accessing a nonnull property from … (PR #67563)

2023-09-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Changes ``` @interface A : NSObject @property (nonnull, nonatomic, strong) NSString *name; + (nullable instancetype)shared; @end @[[A shared].name]; ``` Consider the code above, the nullability of the name property should depend

[clang] Add option to dump IR to files instead of stderr (PR #66412)

2023-09-27 Thread Nuri Amari via cfe-commits
https://github.com/NuriAmari updated https://github.com/llvm/llvm-project/pull/66412 >From da5da863d20cd8bef88066bba931c068042833cf Mon Sep 17 00:00:00 2001 From: Nuri Amari Date: Thu, 7 Sep 2023 12:34:15 -0700 Subject: [PATCH 1/3] Add option to dump IR to files intstead of stderr This patch

[clang] [analyzer] Fix false negative when accessing a nonnull property from … (PR #67563)

2023-09-27 Thread via cfe-commits
https://github.com/tripleCC created https://github.com/llvm/llvm-project/pull/67563 ``` @interface A : NSObject @property (nonnull, nonatomic, strong) NSString *name; + (nullable instancetype)shared; @end @[[A shared].name]; ``` Consider the code above, the nullability of the name property

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-09-27 Thread Hans Wennborg via Phabricator via cfe-commits
hans added a comment. We saw a new warning in Chromium after this, and I wasn't sure if that's intentional: #include template float foo(T input) { if (sizeof(T) > 2) { return 42; } else { constexpr float inverseMax = 1.0f / std::numeric_limits::max(); return

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread Erich Keane via cfe-commits
@@ -718,3 +718,8 @@ void foo() { void GH48527() { auto a = []()__attribute__((b(({ return 0; }{}; // expected-warning {{unknown attribute 'b' ignored}} } + +void GH67492() { + constexpr auto test = 42; + auto lambda = (test, []() noexcept(true) {});

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue edited https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue edited https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
@@ -0,0 +1,273 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
@@ -0,0 +1,273 @@ +//===--- cc1modbuildd_main.cpp - Clang CC1 Module Build Daemon ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes The module build daemon (mbd) will be a cc1 tool that helps convert implicit module command lines to explicit module command lines. The basic workflow is as follows: A clang invocation will check whether a mbd exists. If not, the

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-27 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue created https://github.com/llvm/llvm-project/pull/67562 The module build daemon (mbd) will be a cc1 tool that helps convert implicit module command lines to explicit module command lines. The basic workflow is as follows: A clang invocation will check whether a

[clang] [OpenMP] Implicitly include the 'cgpu' and 'mgpu' libraries for OpenMP (PR #67557)

2023-09-27 Thread Joseph Huber via cfe-commits
jhuber6 wrote: We may want to add something like `-nogpulibc` to maybe disable this in cases where the user wants to use the functions from CUDA / HIP. https://github.com/llvm/llvm-project/pull/67557 ___ cfe-commits mailing list

[clang] [OpenMP] Implicitly include the 'cgpu' and 'mgpu' libraries for OpenMP (PR #67557)

2023-09-27 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/67557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159549: [analyzer] Fix false negative when accessing a nonnull property from a nullable object

2023-09-27 Thread tripleCC via Phabricator via cfe-commits
tripleCC added a comment. In D159549#4651290 , @steakhal wrote: > For new revisions, prefer creating a PR at GitHub. ok, In D159549#4651290 , @steakhal wrote: > For new revisions, prefer creating a PR at

[clang] [OpenMP] Implicitly include the 'lcgpu' and 'lmgpu' libraries for OpenMP (PR #67557)

2023-09-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes Summary: [The LLVM C library for GPUs](https://libc.llvm.org/gpu/) supports standard function calls on the GPU that users are familiar with. Currently, this requires that users include these manually. The support for this library is

[clang] [OpenMP] Implicitly include the 'lcgpu' and 'lmgpu' libraries for OpenMP (PR #67557)

2023-09-27 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/67557 Summary: [The LLVM C library for GPUs](https://libc.llvm.org/gpu/) supports standard function calls on the GPU that users are familiar with. Currently, this requires that users include these manually. The support

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

2023-09-27 Thread Carlos Galvez via cfe-commits
Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: https://github.com/carlosgalvezp resolved https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D159549: [analyzer] Fix false negative when accessing a nonnull property from a nullable object

2023-09-27 Thread tripleCC via Phabricator via cfe-commits
tripleCC added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:903-904 if (!TrackedNullability && - getNullabilityAnnotation(ReturnType) == Nullability::Nullable) { + getNullabilityAnnotation(Call.getOriginExpr()->getType()) ==

[PATCH] D159549: [analyzer] Fix false negative when accessing a nonnull property from a nullable object

2023-09-27 Thread tripleCC via Phabricator via cfe-commits
tripleCC updated this revision to Diff 557405. tripleCC added a comment. adjust return type after checking getOriginExpr is non-null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159549/new/ https://reviews.llvm.org/D159549 Files:

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

2023-09-27 Thread Carlos Galvez via cfe-commits
Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: carlosgalvezp wrote: I would need some help with the failing pre-merge test, I don't really understand why that failure would be related to this patch... https://github.com/llvm/llvm-project/pull/67528

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

2023-09-27 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158069/new/ https://reviews.llvm.org/D158069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159549: [analyzer] Fix false negative when accessing a nonnull property from a nullable object

2023-09-27 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. For new revisions, prefer creating a PR at GitHub. Comment at: clang/lib/StaticAnalyzer/Checkers/NullabilityChecker.cpp:903-904 if (!TrackedNullability && - getNullabilityAnnotation(ReturnType) == Nullability::Nullable) { +

[PATCH] D158156: [analyzer] Add C++ array delete checker

2023-09-27 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. The code looks good now. Let's have one last round. Do you have real-world reports? Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:762-763 +def CXXArrayDeleteChecker : Checker<"ArrayDelete">, + HelpText<"Reports destructions of

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Giulio Eulisse via cfe-commits
ktf wrote: @zygoloid @vgvassilev Ping. I think I have addressed all of your concerns. AFAICT, the only things I deliberately did not do are: * Fix the comment as suggested in https://github.com/llvm/llvm-project/pull/66430#discussion_r1338111904. Unless I misread the code, I think the

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-27 Thread Louis Dionne via cfe-commits
ldionne wrote: @kasuga-fj Ok, let's take the diff I posted earlier in the comments and silence the warning in libc++ then. Once you do that, the libc++ test suite shouldn't fail with your patch anymore so your CI should be green. Then libc++ will be out of your way and it's up to the Clang

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

2023-09-27 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf closed https://github.com/llvm/llvm-project/pull/67410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ccd5b8d - [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (#67410)

2023-09-27 Thread via cfe-commits
Author: Freddy Ye Date: 2023-09-27T21:24:22+08:00 New Revision: ccd5b8db48a4cfa9e6868301cbab5fe033434e46 URL: https://github.com/llvm/llvm-project/commit/ccd5b8db48a4cfa9e6868301cbab5fe033434e46 DIFF: https://github.com/llvm/llvm-project/commit/ccd5b8db48a4cfa9e6868301cbab5fe033434e46.diff

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-09-27 Thread Louis Dionne via cfe-commits
ldionne wrote: I just want to slide in to say that I *really* like this patch from the point of view of `std::string`'s implementation. Our `__default_init()` method and the `if (is_constant_evaluated())` were pretty awful, and I think it's great to remove them. I agree it could cause a

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 47392e5996cccada1d638495a9376b0430142c8c Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/16] Introduce PagedVector

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

2023-09-27 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon approved this pull request. LGTM - cheers https://github.com/llvm/llvm-project/pull/67410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

2023-09-27 Thread Louis Dionne via cfe-commits
ldionne wrote: > > @arichardson > > Sorry about that! It looks like the cmake file quoting needs to be updated. > Alternatively I could revert the part of this change that deprecates the > executor variable. Let's not un-deprecate the executor variables -- it's really great that we're

[clang] [CodeGenPrepare] Transform ldexp into target supported intrinsics (PR #67552)

2023-09-27 Thread Nikita Popov via cfe-commits
nikic wrote: Why does this need special handling in CGP instead of being a normal custom lowering for FLDEXP? https://github.com/llvm/llvm-project/pull/67552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CodeGenPrepare] Transform ldexp into target supported intrinsics (PR #67552)

2023-09-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Changes There are more efficient implementations for llvm.ldexp on different targets. This patch transforms llvm.ldexp into target supported intrinsics before lowering. --- Full diff:

[clang] [CodeGenPrepare] Transform ldexp into target supported intrinsics (PR #67552)

2023-09-27 Thread via cfe-commits
https://github.com/huhu233 created https://github.com/llvm/llvm-project/pull/67552 There are more efficient implementations for llvm.ldexp on different targets. This patch transforms llvm.ldexp into target supported intrinsics before lowering. >From dce0b8f8a76da24b27dd6ed61087e97b5f9415ec

[PATCH] D159549: [analyzer] Fix false negative when accessing a nonnull property from a nullable object

2023-09-27 Thread tripleCC via Phabricator via cfe-commits
tripleCC created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. tripleCC requested review of this

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-09-27 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6167-6183 + if (isOpenMPWorksharingDirective(ParentDirective) || + ParentDirective == OMPD_loop) { +Diag(StartLoc, diag::err_omp_prohibited_region) +<< true <<

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2023-09-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr converted_to_draft https://github.com/llvm/llvm-project/pull/67520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 47392e5996cccada1d638495a9376b0430142c8c Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 01/15] Introduce PagedVector

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-27 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I think we're going to be stuck with 'warning-as-default-error' here, and let > compiler-rt and tests/etc opt-out. I realize that makes the error not as > effective, but it is really the one 'good' way for the 'implementation' in > this case to handle itself. Yeah,

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > With regard to arguments: I know that the [FreeBSD runtime > linker](https://github.com/freebsd/freebsd-src/blob/d06328c37bbcf3d3d3c7601372d29237996a6f6a/libexec/rtld-elf/aarch64/rtld_machdep.h#L59) > (and according to https://stackoverflow.com/a/46331112 also glibc)

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

2023-09-27 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: > Are we still missing SSE vs AVX sema checking test coverage? yes, added in 96ca4d04529e70d8ec75e7f44ddd35f072fe4d10 https://github.com/llvm/llvm-project/pull/67410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

2023-09-27 Thread Freddy Ye via cfe-commits
FreddyLeaf wrote: Can we land this patch now? https://github.com/llvm/llvm-project/pull/67410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/66997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 918863d - [clang][Diagnostics] Make 'note' color CYAN (#66997)

2023-09-27 Thread via cfe-commits
Author: Timm Baeder Date: 2023-09-27T14:07:10+02:00 New Revision: 918863deb0af1986de2df96ca6094eb625adafed URL: https://github.com/llvm/llvm-project/commit/918863deb0af1986de2df96ca6094eb625adafed DIFF: https://github.com/llvm/llvm-project/commit/918863deb0af1986de2df96ca6094eb625adafed.diff

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

2023-09-27 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf resolved https://github.com/llvm/llvm-project/pull/67410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

2023-09-27 Thread Freddy Ye via cfe-commits
@@ -2936,6 +2936,162 @@ _mm_movemask_ps(__m128 __a) return __builtin_ia32_movmskps((__v4sf)__a); } +/* Compare */ +#define _CMP_EQ_OQ 0x00 /* Equal (ordered, non-signaling) */ +#define _CMP_LT_OS 0x01 /* Less-than (ordered, signaling) */ +#define _CMP_LE_OS 0x02 /*

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

2023-09-27 Thread via cfe-commits
DonatNagyE wrote: > No-no, I mean whatever I said in the next sentence, like literally the same > buffer, not the same allocation site, not the same variable, but literally > the same allocation, except it has multiple size-aware operations performed > on it, [...] Thanks for the

[clang] [Driver] -include: deprecate probing .gch (PR #67084)

2023-09-27 Thread via cfe-commits
zmodem wrote: The .gch probing has been part of Clang since 2009, and it matches GCC's behavior, so of course there are going to be users depending on it (Hyrum's law etc.). We don't have to look far for those users: Jan reported that Xcode relies on it, and I have reported that Chromium does

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

2023-09-27 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/67410 >From 3ae0fa2592d3a11dd084d3aefb54c26819016781 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Tue, 26 Sep 2023 16:44:01 +0800 Subject: [PATCH 1/7] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx

[clang] [clang][CodeGen] Introduce class RawAddress and modify Address in preparation for adding information to it that is needed for pointer authentication (PR #67454)

2023-09-27 Thread Florian Hahn via cfe-commits
https://github.com/fhahn commented: It might be helpful for reviewers to add a brief description to the PR explaining the motivation and implementation https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list

[clang] [clang][CodeGen] Introduce class RawAddress and modify Address in preparation for adding information to it that is needed for pointer authentication (PR #67454)

2023-09-27 Thread Florian Hahn via cfe-commits
https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/67454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Introduce class RawAddress and modify Address in preparation for adding information to it that is needed for pointer authentication (PR #67454)

2023-09-27 Thread Florian Hahn via cfe-commits
@@ -15,35 +15,42 @@ #define LLVM_CLANG_LIB_CODEGEN_ADDRESS_H #include "clang/AST/CharUnits.h" +#include "clang/AST/Type.h" #include "llvm/ADT/PointerIntPair.h" #include "llvm/IR/Constants.h" #include "llvm/Support/MathExtras.h" namespace clang { namespace CodeGen {

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-27 Thread via cfe-commits
https://github.com/Munesanz resolved https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-27 Thread via cfe-commits
https://github.com/Munesanz resolved https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-27 Thread via cfe-commits
https://github.com/Munesanz resolved https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-27 Thread via cfe-commits
https://github.com/Munesanz resolved https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-27 Thread via cfe-commits
https://github.com/Munesanz resolved https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2023-09-27 Thread via cfe-commits
https://github.com/Munesanz resolved https://github.com/llvm/llvm-project/pull/66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly annotate keyword operator function name (PR #66904)

2023-09-27 Thread Emilia Kond via cfe-commits
https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/66904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-09-27 Thread via cfe-commits
vabridgers wrote: I'll resolve the comments in an update. Thanks for the comments! https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes The conditions of a noexcept and explicit specifier are full expressions. Before this patch, we would call ActOnFinishFullExpr on these in the context of the enclosing expression, which would cause the collect of odr-used variables (and

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-09-27 Thread via cfe-commits
@@ -298,6 +301,9 @@ BasicValueFactory::evalAPSInt(BinaryOperator::Opcode Op, if (V2.isSigned() && V2.isNegative()) return nullptr; + if (V2.getBitWidth() > 64) vabridgers wrote: Will do, thanks

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-09-27 Thread via cfe-commits
@@ -275,6 +275,9 @@ BasicValueFactory::evalAPSInt(BinaryOperator::Opcode Op, if (V2.isSigned() && V2.isNegative()) return nullptr; + if (V2.getBitWidth() > 64) vabridgers wrote: Will do, thanks

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-09-27 Thread via cfe-commits
@@ -0,0 +1,10 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=optin.portability.UnixAPI \ +// RUN:-triple x86_64-pc-linux-gnu -x c %s + +// Don't crash! +// expected-no-diagnostics +const __int128_t a = ( ((__int128_t)1) << 64 | 1); vabridgers wrote: Hmm, I

[clang] [Clang] Handle sema of noexcept condition in their evaluation context. (PR #67538)

2023-09-27 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/67538 The conditions of a noexcept and explicit specifier are full expressions. Before this patch, we would call ActOnFinishFullExpr on these in the context of the enclosing expression, which would cause the collect

<    1   2   3   4   5   6   >