[clang] -fsanitize=alignment: check memcpy/memmove arguments (PR #67766)

2023-09-30 Thread Fangrui Song via cfe-commits
MaskRay wrote: Thanks for the comment. > I think the choice we're making here is probably worth it, though we should > probably document it better. I think you can remove the alignment assumption > by explicitly casting the operands to char* before passing them to memcpy; if > you can't, I'd

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

2023-09-30 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Pointer.h:81-88 + /// Equality operators are just for tests. + bool operator==(const Pointer ) const { +return Pointee == P.Pointee && Base == P.Base && Offset == P.Offset; + } + + bool operator!=(const

[clang] 18461dc - [clang][Interp] Add IntegralAP for arbitrary-precision integers (#65844)

2023-09-30 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-01T07:11:07+02:00 New Revision: 18461dc45483f6f589de143a287ca80a832ab260 URL: https://github.com/llvm/llvm-project/commit/18461dc45483f6f589de143a287ca80a832ab260 DIFF: https://github.com/llvm/llvm-project/commit/18461dc45483f6f589de143a287ca80a832ab260.diff

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

2023-09-30 Thread David Stone via cfe-commits
https://github.com/davidstone updated https://github.com/llvm/llvm-project/pull/67900 >From 0253be550776631980d77e7847c6337786d64911 Mon Sep 17 00:00:00 2001 From: David Stone Date: Sat, 30 Sep 2023 22:57:34 -0600 Subject: [PATCH 1/2] [clang][Modules] Make `Module::Requirement` a struct

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

2023-09-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e7247f1010b546ca4d98a6ee40414d2d1cae0381 0253be550776631980d77e7847c6337786d64911 --

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

2023-09-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes `Module::Requirement` was defined as a `std::pairstd::string, bool`. This required a comment to explain what the data members mean and makes the usage harder to understand. Replace this with a struct with two members, `FeatureName` and

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

2023-09-30 Thread David Stone via cfe-commits
https://github.com/davidstone created https://github.com/llvm/llvm-project/pull/67900 `Module::Requirement` was defined as a `std::pair`. This required a comment to explain what the data members mean and makes the usage harder to understand. Replace this with a struct with two members,

[clang] remove duplicate ModuleId alias (PR #67899)

2023-09-30 Thread David Stone via cfe-commits
davidstone wrote: The description got a little messed up somehow, but should be fixed. https://github.com/llvm/llvm-project/pull/67899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] remove duplicate ModuleId alias (PR #67899)

2023-09-30 Thread David Stone via cfe-commits
https://github.com/davidstone updated https://github.com/llvm/llvm-project/pull/67899 >From 9bce0ece5bf8adaa094475305c44bcd06cd79e7f Mon Sep 17 00:00:00 2001 From: David Stone Date: Sat, 30 Sep 2023 22:30:29 -0600 Subject: [PATCH] [clang] Remove duplicate `ModuleId` alias This alias is

[clang] remove duplicate ModuleId alias (PR #67899)

2023-09-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Changes [clang] Remove duplicate `ModuleId` alias --- Full diff: https://github.com/llvm/llvm-project/pull/67899.diff 1 Files Affected: - (modified) clang/lib/Lex/ModuleMap.cpp (-2) ``diff diff --git

[clang] remove duplicate ModuleId alias (PR #67899)

2023-09-30 Thread David Stone via cfe-commits
https://github.com/davidstone edited https://github.com/llvm/llvm-project/pull/67899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] remove duplicate ModuleId alias (PR #67899)

2023-09-30 Thread David Stone via cfe-commits
https://github.com/davidstone created https://github.com/llvm/llvm-project/pull/67899 - [ADT] Guard PagedVector death tests - [InstSimplify] Avoid use of ConstantExpr::getICmp. NFC (#67873) - [RISCV][MC] Recognise that fcvt.d.s with frm != 0b000 is valid (#67555) - [lipo] Support creating

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-09-30 Thread via cfe-commits
@@ -483,6 +483,72 @@ struct FragmentCompiler { FullyQualifiedNamespaces.begin(), FullyQualifiedNamespaces.end()); }); } + +// TODO: Share this code with Diagnostics.Includes.IgnoreHeader +#ifdef CLANGD_PATH_CASE_INSENSITIVE +static

[PATCH] D156599: [profiling] Move option declarations into headers

2023-09-30 Thread Tom Stellard via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7247f1010b5: [profiling] Move option declarations into headers (authored by tstellar). Changed prior to commit:

[clang] e7247f1 - [profiling] Move option declarations into headers

2023-09-30 Thread Tom Stellard via cfe-commits
Author: Tom Stellard Date: 2023-09-30T18:51:28-07:00 New Revision: e7247f1010b546ca4d98a6ee40414d2d1cae0381 URL: https://github.com/llvm/llvm-project/commit/e7247f1010b546ca4d98a6ee40414d2d1cae0381 DIFF: https://github.com/llvm/llvm-project/commit/e7247f1010b546ca4d98a6ee40414d2d1cae0381.diff

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

2023-09-30 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet abandoned this revision. hazohelet added a comment. Thank you so much to everyone for guiding this patch onto the right track! I'll submit GitHub PR after making suggested changes. Since Phabricator is going to be shutdown, I mark this differential as abandoned. CHANGES SINCE LAST

[libunwind] [libunwind] Add Unwind-wasm.c to CMakeLists.txt (PR #67770)

2023-09-30 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/67770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Add Unwind-wasm.c to CMakeLists.txt (PR #67770)

2023-09-30 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin updated https://github.com/llvm/llvm-project/pull/67770 >From 3277e2c8058c5d9b0afcc073d711646ebbf7ed62 Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Thu, 28 Sep 2023 23:43:26 -0700 Subject: [PATCH 1/6] [libunwind] Add Unwind-wasm.c to CMakeLists.txt This was

[libunwind] [libunwind] Add Unwind-wasm.c to CMakeLists.txt (PR #67770)

2023-09-30 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin updated https://github.com/llvm/llvm-project/pull/67770 >From 3277e2c8058c5d9b0afcc073d711646ebbf7ed62 Mon Sep 17 00:00:00 2001 From: Heejin Ahn Date: Thu, 28 Sep 2023 23:43:26 -0700 Subject: [PATCH 1/5] [libunwind] Add Unwind-wasm.c to CMakeLists.txt This was

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-09-30 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav marked an inline comment as done. chaitanyav added a comment. Ran llvm with the boolean and operator change. attaching the log file with errors .F29524460: llvm.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-09-30 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav updated this revision to Diff 557513. chaitanyav added a comment. rebase upstream changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-30 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67373 >From beab5db738483795ecb0bace2842acdbb1c9869a Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Mon, 25 Sep 2023 13:56:43 -0700 Subject: [PATCH 1/2] [Clang] Fix crash when ill-formed code is treated as a

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-09-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-platform-windows Changes Prior to 591c4b64b3650884c2c68eb47d755ebb62981b99, the mingw specific linker options -mthreads, -mconsole, -mwindows and -mdll would be tolerated also at compile time, but generating a warning about being unused. After that

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-09-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/67891 From da64c467a35cf544df5346b512746715ffc3db32 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sun, 1 Oct 2023 00:29:21 +0300 Subject: [PATCH] [clang] [MinGW] Tolerate mingw specific

[clang] [clang] [MinGW] Tolerate mingw specific linker options during compilation (PR #67891)

2023-09-30 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo created https://github.com/llvm/llvm-project/pull/67891 Prior to 591c4b64b3650884c2c68eb47d755ebb62981b99, the mingw specific linker options -mthreads, -mconsole, -mwindows and -mdll would be tolerated also at compile time, but generating a warning about being

[clang] [Clang][OpenMP][OMPIRBuilder] Move Clang's OpenMP Member/MemberOf flag helpers into the OMPIRBuilder (PR #67844)

2023-09-30 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert approved this pull request. LG, tested via the clang tests. https://github.com/llvm/llvm-project/pull/67844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Jakub Kuderski via cfe-commits
kuhar wrote: @vgvassilev > I find the use of the macro I proposed cleaner though. Ideally, I think we could have an llvm-specific macro that combines the guard and the check (say `LLVM_EXPECT_DEATH`), so that it's less of a footgun. In any case, the failures should be resolved now, and we

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > @vgvassilev I've seen other tests use the pattern from my fix. Feel free to > overwrite with your version if that's preferred. Too late in the night in my end and I closed my laptop already. I am fine with your fix - I find the use of the macro I proposed cleaner though.

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Jakub Kuderski via cfe-commits
kuhar wrote: Also, don't use have to guard that with `#ifdef EXPECT_DEBUG_DEATH`? https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Jakub Kuderski via cfe-commits
kuhar wrote: @vgvassilev I've seen other tests use the pattern from my fix. Feel free to overwrite with your version if that's preferred. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @kuhar, thanks, you overtook me. Here is my diff: ```diff diff --git a/llvm/unittests/ADT/PagedVectorTest.cpp b/llvm/unittests/ADT/PagedVectorTest.cpp index e1b0c62d3395..c45df6d9e7e8 100644 --- a/llvm/unittests/ADT/PagedVectorTest.cpp +++

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Jakub Kuderski via cfe-commits
kuhar wrote: @vvereschaka I submitted a fix for death tests in https://github.com/llvm/llvm-project/commit/8580010672e9ff37b0744927296ca00dbcbef5be https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-30 Thread Nikita Popov via cfe-commits
@@ -6380,7 +6380,71 @@ Instruction *InstCombinerImpl::foldICmpUsingBoolRange(ICmpInst ) { Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULE) return BinaryOperator::CreateOr(Builder.CreateIsNull(X), Y); + // icmp eq/ne X, (zext/sext (icmp eq/ne X,

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-30 Thread Nikita Popov via cfe-commits
@@ -6380,7 +6380,71 @@ Instruction *InstCombinerImpl::foldICmpUsingBoolRange(ICmpInst ) { Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULE) return BinaryOperator::CreateOr(Builder.CreateIsNull(X), Y); + // icmp eq/ne X, (zext/sext (icmp eq/ne X,

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @vgvassilev , got failed tests: https://lab.llvm.org/buildbot/#/builders/86/builds/66095 * LLVM-Unit :: ADT/./ADTTests.exe/PagedVectorTest/EmptyTest * LLVM-Unit :: ADT/./ADTTests.exe/PagedVectorTest/HalfPageFillingTest * LLVM-Unit ::

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-09-30 Thread Alan Phipps via Phabricator via cfe-commits
alanphipps added a comment. In D138846#4649609 , @w2yehia wrote: > Please update InstrProfilingPlatformAIX.c as well, specifically add new dummy > vars for the new section. > Edit: I can post the patch if you wish. I just added the dummy vars, but you

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

2023-09-30 Thread Alan Phipps via Phabricator via cfe-commits
alanphipps added a comment. > I added steps to download the profile here: > https://bugs.chromium.org/p/chromium/issues/detail?id=1485303#c4 > I think this should be reverted while being investigated: > https://github.com/llvm/llvm-project/commit/53a2923bf67bc164558d489493176630123abf7e Thank

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-30 Thread Alexandre Ganea via cfe-commits
aganea wrote: I managed to repro. It is actually this, still open, issue: https://github.com/microsoft/STL/issues/1066 https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-09-30 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: Ping. https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-30 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 5def87462e3b48cfebafdc2526ac929f5cb9cea3 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH 1/5] [clang][MBD] set up module build daemon infrastructure The

[clang] 4bae636 - Revert "[clang][Interp] Add IntegralAP for arbitrary-precision integers (#65844)"

2023-09-30 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-30T20:12:14+02:00 New Revision: 4bae636abfe4d9ef4b778fc3e4ea0a3fc33e2f37 URL: https://github.com/llvm/llvm-project/commit/4bae636abfe4d9ef4b778fc3e4ea0a3fc33e2f37 DIFF: https://github.com/llvm/llvm-project/commit/4bae636abfe4d9ef4b778fc3e4ea0a3fc33e2f37.diff

[clang] [Clang][OpenMP][OMPIRBuilder] Move Clang's OpenMP Member/MemberOf flag helpers into the OMPIRBuilder (PR #67844)

2023-09-30 Thread via cfe-commits
shraiysh wrote: LGTM. Is it possible to add some tests for this? I think we might be able to add some in OpenMPIRBuilderTest.cpp. https://github.com/llvm/llvm-project/pull/67844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-30 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits

[clang] 16b9e6f - [clang][Interp] Add IntegralAP for arbitrary-precision integers (#65844)

2023-09-30 Thread via cfe-commits
Author: Timm Baeder Date: 2023-09-30T20:08:22+02:00 New Revision: 16b9e6fbac4c0bd94c66e7670a41b5c266cf7bff URL: https://github.com/llvm/llvm-project/commit/16b9e6fbac4c0bd94c66e7670a41b5c266cf7bff DIFF: https://github.com/llvm/llvm-project/commit/16b9e6fbac4c0bd94c66e7670a41b5c266cf7bff.diff

[clang] [clang][Interp] Handle variadic functions (PR #67814)

2023-09-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67814 >From 64aae1cdf960f3edb34f1cf82ae3e66eb692247a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 29 Sep 2023 16:43:59 +0200 Subject: [PATCH] [clang][Interp] Handle variadic functions

[clang] [clang][Interp] Handle variadic functions (PR #67814)

2023-09-30 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67814 >From 64aae1cdf960f3edb34f1cf82ae3e66eb692247a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 29 Sep 2023 16:43:59 +0200 Subject:

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-09-30 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

2023-09-30 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/6] Fix value of __FUNCTION__ and __func__ in MSVC mode. ---

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-30 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 5def87462e3b48cfebafdc2526ac929f5cb9cea3 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH 1/4] [clang][MBD] set up module build daemon infrastructure The

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

2023-09-30 Thread Mark Danial via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6403287eff71: [Flang] [FlangRT] Introduce FlangRT project as

Suffix l missing in C++ standard header

2023-09-30 Thread Helmut Burkhardt via cfe-commits
Dear llvm front end team The clang precision of mathematical constants is the same as for Please add the suffix l. Example : template inline constexpr _Tp e_v<_Tp> = 2.718281828459045235360287471352662; —> template inline constexpr _Tp e_v<_Tp> =

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-30 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue edited https://github.com/llvm/llvm-project/pull/67562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

2023-09-30 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/5] Fix value of __FUNCTION__ and __func__ in MSVC mode. ---

[clang] [clang-cl] Fix value of __FUNCTION__ and __func__ in MSVC mode. (PR #67592)

2023-09-30 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/5] Fix value of __FUNCTION__ and __func__ in MSVC mode. ---

[clang] [clang][Interp] Fix `ArrayInitLoopExpr` handling (PR #67886)

2023-09-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This patch implements the changes from #67722 in Interp. --- Full diff: https://github.com/llvm/llvm-project/pull/67886.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/ByteCodeExprGen.cpp (+1) - (modified)

[clang] [clang][Interp] Fix `ArrayInitLoopExpr` handling (PR #67886)

2023-09-30 Thread via cfe-commits
https://github.com/isuckatcs created https://github.com/llvm/llvm-project/pull/67886 This patch implements the changes from #67722 in Interp. >From df530e60872abc4a74e561b8479c4a28dfb39d85 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Sat, 30 Sep

[clang] [clang][MBD] set up module build daemon infrastructure (PR #67562)

2023-09-30 Thread Connor Sughrue via cfe-commits
https://github.com/cpsughrue updated https://github.com/llvm/llvm-project/pull/67562 >From 5def87462e3b48cfebafdc2526ac929f5cb9cea3 Mon Sep 17 00:00:00 2001 From: cpsughrue Date: Sun, 9 Jul 2023 23:19:58 -0400 Subject: [PATCH 1/3] [clang][MBD] set up module build daemon infrastructure The

[clang-tools-extra] [LLD]lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

2023-09-30 Thread via cfe-commits
https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/65966 >From 8b44aa203b97b8944f236701bfeb92f0b1e8f407 Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Mon, 11 Sep 2023 14:42:27 +0100 Subject: [PATCH 1/2] [LLD][AARCH64] lld incorrectly handles .eh_frame when it

[clang] [LLD]lld incorrectly handles .eh_frame when it has a non-zero offset within its output section. (PR #65966)

2023-09-30 Thread via cfe-commits
https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/65966 >From 8b44aa203b97b8944f236701bfeb92f0b1e8f407 Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Mon, 11 Sep 2023 14:42:27 +0100 Subject: [PATCH 1/2] [LLD][AARCH64] lld incorrectly handles .eh_frame when it

[clang-tools-extra] [X86][RFC] Support AVX10 options (PR #67278)

2023-09-30 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/67278 >From eaf36c8cac3fe6d9bb3dcb1387b0b4f1febf5ef7 Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Mon, 25 Sep 2023 10:31:37 +0800 Subject: [PATCH 1/2] [X86][RFC] Support AVX10 options AVX10 Architecture

[clang] 62205c2 - [clang] Remove uses of llvm::Type::getPointerTo() (NFC)

2023-09-30 Thread via cfe-commits
Author: JOE1994 Date: 2023-09-30T08:05:46-04:00 New Revision: 62205c2e60e375f1af7a498be370dd64ff6d8b2a URL: https://github.com/llvm/llvm-project/commit/62205c2e60e375f1af7a498be370dd64ff6d8b2a DIFF: https://github.com/llvm/llvm-project/commit/62205c2e60e375f1af7a498be370dd64ff6d8b2a.diff LOG:

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

2023-09-30 Thread Nouman Amir via Phabricator via cfe-commits
NoumanAmir657 added a comment. In D158540#4652051 , @aaron.ballman wrote: > In D158540#4651859 , @NoumanAmir657 > wrote: > >> @aaron.Ballman >> Do I need to make changes other than this? The virtual base

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

2023-09-30 Thread Nouman Amir via Phabricator via cfe-commits
NoumanAmir657 updated this revision to Diff 557507. NoumanAmir657 set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files:

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-09-30 Thread Sunil K via Phabricator via cfe-commits
koops updated this revision to Diff 557506. koops added a comment. Moving checks of Work Sharing Directive in mapLoopConstruct to checkNestingOfRegions(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files:

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-09-30 Thread kleines Filmröllchen via cfe-commits
kleinesfilmroellchen wrote: I investigated the test failures some more in the context of where the bug affects real uses and I'm unsure as to what's going on. ```yaml Style: QuotedHeaders: ["blahblahblah"] AngledHeaders: ["AK/.*", "Userland/.*", "Kernel/.*", "Applications/.*", "Lib.*/.*"]

[clang] 511662b - [clang-format][NFC] Don't call startsSequence() in the parser

2023-09-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-30T02:09:52-07:00 New Revision: 511662b88c36f8d5d02f0b758b15c1b84d4ee6c1 URL: https://github.com/llvm/llvm-project/commit/511662b88c36f8d5d02f0b758b15c1b84d4ee6c1 DIFF: https://github.com/llvm/llvm-project/commit/511662b88c36f8d5d02f0b758b15c1b84d4ee6c1.diff

[clang] 36c1e56 - [clang-format][NFC] Simplify the UnwrappedLine constructor

2023-09-30 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-09-30T02:03:14-07:00 New Revision: 36c1e568bb4f8e482e3f713c8cb9460c5cf19863 URL: https://github.com/llvm/llvm-project/commit/36c1e568bb4f8e482e3f713c8cb9460c5cf19863 DIFF: https://github.com/llvm/llvm-project/commit/36c1e568bb4f8e482e3f713c8cb9460c5cf19863.diff

[clang] [Support] Add KnownBits::computeForSubBorrow (PR #67788)

2023-09-30 Thread Christian Kissig via cfe-commits
https://github.com/christiankissig updated https://github.com/llvm/llvm-project/pull/67788 >From 5d86936c3a48c613460983c980271fcab8128b75 Mon Sep 17 00:00:00 2001 From: Christian Kissig Date: Tue, 26 Sep 2023 12:18:59 + Subject: [PATCH 1/5] [Support] Add KnownBits::computeForSubBorrow *

[libunwind] [Support] Add KnownBits::computeForSubBorrow (PR #67788)

2023-09-30 Thread Christian Kissig via cfe-commits
https://github.com/christiankissig updated https://github.com/llvm/llvm-project/pull/67788 >From 5d86936c3a48c613460983c980271fcab8128b75 Mon Sep 17 00:00:00 2001 From: Christian Kissig Date: Tue, 26 Sep 2023 12:18:59 + Subject: [PATCH 1/5] [Support] Add KnownBits::computeForSubBorrow *

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-30 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > Wouldn't isExplicitSpecializationOrInstantiation be a stronger guarantee than > isExplicitSpecialization, such that it would exclude a superset of what is > excluded by isExplicitSpecialization? If I did not misunderstand their source > code. I wanted to filter out

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-30 Thread Luca Di sera via cfe-commits
diseraluca wrote: > > > > I gave it a quick try, and we would still end up with the same result > > > > in our codebase. But, generally, this would not probably be feasible > > > > for us as a solution. > > > > > > > > > do you have an idea why? Can you show the diff of the changes you made?

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

2023-09-30 Thread Nouman Amir via Phabricator via cfe-commits
NoumanAmir657 updated this revision to Diff 557504. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > Looks like this causes a compile-time regression: > https://llvm-compile-time-tracker.com/compare.php?from=abcaebfe3aacb13d46be5e949fd6ed9b4321e2f6=4ae51570806ba5c5fcabe6d6dcbe52e3a5d5453b=instructions%3Au > About 0.5% at `O0`. It is probably the change in the

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Nikita Popov via cfe-commits
nikic wrote: Looks like this causes a compile-time regression: https://llvm-compile-time-tracker.com/compare.php?from=abcaebfe3aacb13d46be5e949fd6ed9b4321e2f6=4ae51570806ba5c5fcabe6d6dcbe52e3a5d5453b=instructions%3Au About 0.5% at `O0`. https://github.com/llvm/llvm-project/pull/66430

[clang] Introduce paged vector (PR #66430)

2023-09-30 Thread Giulio Eulisse via cfe-commits
ktf wrote: Thanks! If I were younger I would probably know how to post a dancing banana emoji at this point... ;-) https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-30 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-30 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-30 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM Modulo nit https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-30 Thread via cfe-commits
@@ -375,6 +375,10 @@ Bug Fixes to C++ Support - Fixed a bug causing destructors of constant-evaluated structured bindings initialized by array elements to be called in the wrong evaluation context. +- Fix crash where ill-formed code was being treated as a deduction guide

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-30 Thread Vassil Vassilev via cfe-commits
@@ -794,7 +794,7 @@ void CodeGenModule::Release() { AddGlobalCtor(ObjCInitFunction); if (Context.getLangOpts().CUDA && CUDARuntime) { if (llvm::Function *CudaCtorFunction = CUDARuntime->finalizeModule()) - AddGlobalCtor(CudaCtorFunction); +

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2023-09-30 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: cc: @hahnjo https://github.com/llvm/llvm-project/pull/66658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix returning nullptr from functions (PR #67229)

2023-09-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67229 >From c3fcded8f926789ee6b00dcb676231b3c8285ac6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 23 Sep 2023 11:41:52 +0200 Subject: [PATCH] [clang][Interp] Fix returning nullptr from

[clang] [clang][Interp] Zero-init remaining string literal elements (PR #66862)

2023-09-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/66862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4909e7c - [clang][Interp] Zero-init remaining string literal elements (#66862)

2023-09-30 Thread via cfe-commits
Author: Timm Baeder Date: 2023-09-30T08:28:09+02:00 New Revision: 4909e7cac7100ee0bc9ce755ffab114d320ac0e3 URL: https://github.com/llvm/llvm-project/commit/4909e7cac7100ee0bc9ce755ffab114d320ac0e3 DIFF: https://github.com/llvm/llvm-project/commit/4909e7cac7100ee0bc9ce755ffab114d320ac0e3.diff

[clang] [clang][Interp] Handle CXXScalarValueInitExprs (PR #67147)

2023-09-30 Thread Timm Baeder via cfe-commits
@@ -31,6 +31,33 @@ static_assert(b, ""); constexpr int one = true; static_assert(one == 1, ""); +constexpr bool b2 = bool(); +static_assert(!b2, ""); + +namespace ScalarTypes { + constexpr int ScalarInitInt = int(); + static_assert(ScalarInitInt == 0, ""); + constexpr

[clang] Qualify non-dependent types of a class template with its declaration (PR #67566)

2023-09-30 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > > > I gave it a quick try, and we would still end up with the same result in > > > our codebase. But, generally, this would not probably be feasible for us > > > as a solution. > > > > > > do you have an idea why? Can you show the diff of the changes you made? Is > > the

[PATCH] D159541: [UEFI] X86_64 UEFI Clang Driver

2023-09-30 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:68 + // "Terminal Service Aware" flag is not needed for UEFI applications. +