mib added a comment.
Hey @iana, I think this broke the lldb bot
https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/6698/
Can you take a look ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159064/new/
https://reviews.llvm.org/D159064
_
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 40c1f5b2fb88b17c6ed6911466002824d1880871
0e798f3fdd7dc8816a71e3e147ca14616ad4a123 --
https://github.com/shafik approved this pull request.
Thank you for the follow-up work.
LGTM
https://github.com/llvm/llvm-project/pull/66487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
goldsteinn wrote:
Note on compile time affect:
https://llvm-compile-time-tracker.com/compare.php?from=2da4960f20f7e5d88a68ce25636a895284dc66d8&to=f8c9f5bce65756598da22e8aec5d91fb66b16d5c&stat=instructions%3Au
Minimal for normal O3, a bit more significant for LTO.
https://github.com/llvm/llvm-p
https://github.com/goldsteinn updated
https://github.com/llvm/llvm-project/pull/68164
>From 73290d5992e6a395fc953a9223173e9fd60a8775 Mon Sep 17 00:00:00 2001
From: Noah Goldstein
Date: Thu, 7 Sep 2023 18:48:26 -0500
Subject: [PATCH 1/2] [Inliner] Propagate callee function memory access
attribu
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/68130
>From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 3 Oct 2023 16:43:50 +
Subject: [PATCH 1/4] [mlir][sparse] Print new syntax
Printing changes from #s
https://github.com/ian-twilightcoder closed
https://github.com/llvm/llvm-project/pull/68163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ian Anderson
Date: 2023-10-03T15:58:38-07:00
New Revision: b855ae99036085267b4f7482f996c7d83d0d2983
URL:
https://github.com/llvm/llvm-project/commit/b855ae99036085267b4f7482f996c7d83d0d2983
DIFF:
https://github.com/llvm/llvm-project/commit/b855ae99036085267b4f7482f996c7d83d0d2983.diff
PiJoules wrote:
> The change to `clang/test/CodeGenCXX/fixed-point-mangle.cpp` is unrelated.
Woops. Yeah, removed.
https://github.com/llvm/llvm-project/pull/67755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/PiJoules updated
https://github.com/llvm/llvm-project/pull/67755
>From 0e798f3fdd7dc8816a71e3e147ca14616ad4a123 Mon Sep 17 00:00:00 2001
From: Leonard Chan
Date: Fri, 29 Sep 2023 00:25:44 +
Subject: [PATCH] [clang][RelativeVTables] Make the rtti_proxy LinkOnceODR
instead
@@ -533,7 +533,7 @@ func.func @sparse_compression(%tensor: tensor<8x8xf64,
#CSR>,
// CHECK: %[[A13:.*]]:4 = scf.for %[[A14:.*]] = %[[A11]] to %[[A7]]
step %[[A12]] iter_args(%[[A15:.*]] = %[[A0]], %[[A16:.*]] = %[[A1]],
%[[A17:.*]] = %[[A2]], %[[A18:.*]] = %[[A3]]) -
https://github.com/yinying-lisa-li updated
https://github.com/llvm/llvm-project/pull/68130
>From 47b34bb327e1078678d3ba0c96ebce3fc89cf2ae Mon Sep 17 00:00:00 2001
From: Yinying Li
Date: Tue, 3 Oct 2023 16:43:50 +
Subject: [PATCH 1/3] [mlir][sparse] Print new syntax
Printing changes from #s
shraiysh wrote:
Ping for review!
https://github.com/llvm/llvm-project/pull/67723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4122,6 +4122,9 @@ def RestrictDocs : Documentation {
The ``malloc`` attribute indicates that the function acts like a system memory
allocation function, returning a pointer to allocated storage disjoint from the
storage for any other object accessible to the caller.
+
+The
shraiysh wrote:
Ping for review!
https://github.com/llvm/llvm-project/pull/67723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1cfaa863bc36d25625114b432e2ddf35d2302452
f8c9f5bce65756598da22e8aec5d91fb66b16d5c --
https://github.com/shraiysh closed
https://github.com/llvm/llvm-project/pull/68042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shraiysh closed
https://github.com/llvm/llvm-project/pull/68042
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michaelrj-google updated
https://github.com/llvm/llvm-project/pull/68134
>From baf9d8e19d2b064c05527757c6173f875b59b286 Mon Sep 17 00:00:00 2001
From: Michael Jones
Date: Tue, 3 Oct 2023 10:39:02 -0700
Subject: [PATCH 1/2] [clang-tidy][libc] Fix namespace check with macro
Th
https://github.com/Bigcheese approved this pull request.
https://github.com/llvm/llvm-project/pull/68163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Yes, I mean to do it as a direct follow-up. 😊
-bw
On Tue, Oct 3, 2023, 6:31 AM Aaron Ballman via Phabricator <
revi...@reviews.llvm.org> wrote:
> aaron.ballman added inline comments.
>
>
>
> Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8420-8428
> +if (Result.getResultKind()
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
- [Inliner] Propagate callee function memory access attributes before inlining
- [Inliner] Propagate callee argument memory access attributes before inlining
---
Patch is 24.83 KiB, truncated to 20.00 KiB below, full version:
https://git
https://github.com/goldsteinn edited
https://github.com/llvm/llvm-project/pull/68164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/goldsteinn created
https://github.com/llvm/llvm-project/pull/68164
- [Inliner] Propagate callee function memory access attributes before inlining
- [Inliner] Propagate callee argument memory access attributes before inlining
>From 73290d5992e6a395fc953a9223173e9fd60a8775 Mon
https://github.com/HerrCai0907 approved this pull request.
LGTM. Please update the release notes.
https://github.com/llvm/llvm-project/pull/68134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
5chmidti wrote:
> * How do I correctly parse the values in a macro? While the test locally
> works, it doesn't in CI. I also don't differentiate between what kind of
> numeric constant the token is, which might be another problem. Any pointers
> on how to do this correctly are greatly apprecia
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -458,11 +458,14 @@ SourceManager::AllocateLoadedSLocEntries(unsigned
NumSLocEntries,
CurrentLoadedOffset - TotalSize < NextLocalOffset) {
return std::make_pair(0, 0);
}
- LoadedSLocEntryTable.resize(LoadedSLocEntryTable.size() + NumSLocEntries);
- SLocEntryLoa
@@ -701,6 +701,10 @@ class SourceManager : public RefCountedBase
{
/// use (-ID - 2).
SmallVector LoadedSLocEntryTable;
+ /// For each allocation in LoadedSLocEntryTable, we keep the new size. This
+ /// can be used to determine whether two FileIDs come from the same AS
ian-twilightcoder wrote:
Fix for https://lab.llvm.org/buildbot/#/builders/186/builds/12412
https://github.com/llvm/llvm-project/pull/68163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Changes
Sometimes unwind.h needs uint32_t also.
---
Full diff: https://github.com/llvm/llvm-project/pull/68163.diff
1 Files Affected:
- (modified) clang/test/Modules/Inputs/System/usr/include/stdint.h (+1)
``diff
diff --git a/
Author: Alex Voicu
Date: 2023-10-03T23:00:13+01:00
New Revision: 1cfaa863bc36d25625114b432e2ddf35d2302452
URL:
https://github.com/llvm/llvm-project/commit/1cfaa863bc36d25625114b432e2ddf35d2302452
DIFF:
https://github.com/llvm/llvm-project/commit/1cfaa863bc36d25625114b432e2ddf35d2302452.diff
LO
https://github.com/ian-twilightcoder created
https://github.com/llvm/llvm-project/pull/68163
Sometimes unwind.h needs uint32_t also.
>From cd2cc782937f9b0415733c48dcd1d9d8ab19ea48 Mon Sep 17 00:00:00 2001
From: Ian Anderson
Date: Tue, 3 Oct 2023 14:51:58 -0700
Subject: [PATCH] Fix the Modules/
NoQ added inline comments.
Comment at:
clang/test/SemaCXX/warn-unsafe-buffer-usage-debug-unclaimed/lit.local.cfg:6
+
+config.substitutions.append(('PYTHON_EXE', python_executable));
I might be overthinking/cargo-culting, but folks seem to never expose the
pytho
https://github.com/ilinpv closed https://github.com/llvm/llvm-project/pull/68104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Pavel Iliin
Date: 2023-10-03T22:52:01+01:00
New Revision: b04fe222d21277f8359130cd50ae7303b3d15254
URL:
https://github.com/llvm/llvm-project/commit/b04fe222d21277f8359130cd50ae7303b3d15254
DIFF:
https://github.com/llvm/llvm-project/commit/b04fe222d21277f8359130cd50ae7303b3d15254.diff
L
5chmidti wrote:
Added a comment to the release notes
https://github.com/llvm/llvm-project/pull/67939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti updated
https://github.com/llvm/llvm-project/pull/67939
>From d0ac0cdb0f9ccbe78ec236932ca9b9a85768ecf2 Mon Sep 17 00:00:00 2001
From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com>
Date: Mon, 2 Oct 2023 01:34:24 +0200
Subject: [PATCH] [clang] fix hasAnyBa
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilg-ul wrote:
> You make it sound like nobody else might ever have used such symlinks before
> - isn't that quite a big assumption?
Ah, sorry for the confusion, I did not intend to make it sound like a big
assumption.
I'm convinced that such links were occasionally used before, just that the
Author: Douglas Yung
Date: 2023-10-03T14:27:53-07:00
New Revision: 344e735c172e3f976c0b91c4bccc0d3291f644b7
URL:
https://github.com/llvm/llvm-project/commit/344e735c172e3f976c0b91c4bccc0d3291f644b7
DIFF:
https://github.com/llvm/llvm-project/commit/344e735c172e3f976c0b91c4bccc0d3291f644b7.diff
https://github.com/benlangmuir approved this pull request.
This seems reasonable to me, but I would like @jansvoboda11 to also look at it.
https://github.com/llvm/llvm-project/pull/68023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
Author: Alex Voicu
Date: 2023-10-03T22:17:12+01:00
New Revision: dce54eae46685116ca0fe60f1dcabced2d0d297e
URL:
https://github.com/llvm/llvm-project/commit/dce54eae46685116ca0fe60f1dcabced2d0d297e
DIFF:
https://github.com/llvm/llvm-project/commit/dce54eae46685116ca0fe60f1dcabced2d0d297e.diff
LO
https://github.com/goldsteinn closed
https://github.com/llvm/llvm-project/pull/67756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
goldsteinn wrote:
Pushed.
https://github.com/llvm/llvm-project/pull/67756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
We should also update [this
line](https://github.com/llvm/llvm-project/pull/68154/files#diff-13a957866eda585a177e1d10139b157956e9d82c40d2275b500c2b1bcb2ad8c0R452)
to:
```
assert(Shift > 0 || Changes[i].NewlinesBefore > 0 ||
```
https://
rnk added a subscriber: akhuang.
rnk added a comment.
Regarding upgrade-datalayout2.ll, I don't think we need to be too constrained
by it. @akhuang , do you recall why you added it?
In other words, I think your direction is reasonable, we should go forward with
this.
Repository:
rG LLVM Git
@@ -2082,6 +2082,11 @@ std::pair
SourceManager::isInTheSameTranslationUnit(
if (LOffs.first == ROffs.first)
return std::make_pair(true, LOffs.second < ROffs.second);
+ // Built-ins are not considered part of any TU.
benlangmuir wrote:
Yes, this commen
@@ -533,7 +533,7 @@ func.func @sparse_compression(%tensor: tensor<8x8xf64,
#CSR>,
// CHECK: %[[A13:.*]]:4 = scf.for %[[A14:.*]] = %[[A11]] to %[[A7]]
step %[[A12]] iter_args(%[[A15:.*]] = %[[A0]], %[[A16:.*]] = %[[A1]],
%[[A17:.*]] = %[[A2]], %[[A18:.*]] = %[[A3]]) -
@@ -2082,6 +2082,11 @@ std::pair
SourceManager::isInTheSameTranslationUnit(
if (LOffs.first == ROffs.first)
return std::make_pair(true, LOffs.second < ROffs.second);
+ // Built-ins are not considered part of any TU.
jansvoboda11 wrote:
This comment ap
https://github.com/benlangmuir approved this pull request.
🎉
https://github.com/llvm/llvm-project/pull/68157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -284,7 +284,6 @@ TEST_F(FileManagerTest,
getFileRefReturnsCorrectNameForDifferentStatPath) {
ASSERT_FALSE(!F1Alias);
ASSERT_FALSE(!F1Alias2);
EXPECT_EQ("dir/f1.cpp", F1->getName());
- EXPECT_EQ("dir/f1.cpp", F1->getFileEntry().getName());
benlangmuir
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/68157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -458,11 +458,14 @@ SourceManager::AllocateLoadedSLocEntries(unsigned
NumSLocEntries,
CurrentLoadedOffset - TotalSize < NextLocalOffset) {
return std::make_pair(0, 0);
}
- LoadedSLocEntryTable.resize(LoadedSLocEntryTable.size() + NumSLocEntries);
- SLocEntryLoa
@@ -458,11 +458,14 @@ SourceManager::AllocateLoadedSLocEntries(unsigned
NumSLocEntries,
CurrentLoadedOffset - TotalSize < NextLocalOffset) {
return std::make_pair(0, 0);
}
- LoadedSLocEntryTable.resize(LoadedSLocEntryTable.size() + NumSLocEntries);
- SLocEntryLoa
@@ -701,6 +701,10 @@ class SourceManager : public RefCountedBase
{
/// use (-ID - 2).
SmallVector LoadedSLocEntryTable;
+ /// For each allocation in LoadedSLocEntryTable, we keep the new size. This
+ /// can be used to determine whether two FileIDs come from the same AS
@@ -2082,6 +2082,11 @@ std::pair
SourceManager::isInTheSameTranslationUnit(
if (LOffs.first == ROffs.first)
return std::make_pair(true, LOffs.second < ROffs.second);
+ // Built-ins are not considered part of any TU.
benlangmuir wrote:
Does this have t
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rampitec wrote:
I have measured compile time performance impact with timing
check-llvm-codegen-amdgpu on the release build:
```
before the patch: 11.06s
add folding:11.09s +0.2%
remove folding from shrink: 11.02s -0.4%
```
In general the impact smaller than run to run
rampitec wrote:
I have measured compile time performance impact with timing
check-llvm-codegen-amdgpu on the release build:
```
before the patch: 11.06s
add folding:11.09s +0.2%
remove folding from shrink: 11.02s -0.4%
```
In general the impact smaller than run to run
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
All uses of `FileEntry::getName()` were removed in favor of
`FileEntryRef::getName()`. This patch finally formally deprecates that
function. The plan is to remove it entirely in the main branch after we cut the
release branch for LLVM 18.
jansvoboda11 wrote:
(Note that this is currently blocked on #67839.)
https://github.com/llvm/llvm-project/pull/68157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67955
>From 15d37075331311020020c5741e2432cd3fc0be74 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 1 Oct 2023 23:01:30 -0700
Subject: [PATCH 1/2] [clang-format] Annotate ctors/dtors as CtorDtorDeclName
instead
Af
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/68157
All uses of `FileEntry::getName()` were removed in favor of
`FileEntryRef::getName()`. This patch finally formally deprecates that
function. The plan is to remove it entirely in the main branch after we cut
owenca wrote:
> https://buildkite.com/llvm-project/clang-ci/builds/4275#018af20e-3d3c-4344-b92d-88ac8b09b484
> Tests do not pass?
I saw that but don't know why. Did you have the same failures? I'll push
another commit shortly to trigger buildkite again.
https://github.com/llvm/llvm-project/pu
mstorsjo wrote:
> > it makes me wonder if someone actually is relying on the current behaviour
>
> To rephrase your question, you ask if someone is using a configuration with a
> folder where various custom libraries are and bin folder with a link to the
> actual clang, and expects for clang t
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/68156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jan Svoboda
Date: 2023-10-03T13:37:39-07:00
New Revision: 25a6b891cbcd9aacee404cc0ccceed3248d93dd3
URL:
https://github.com/llvm/llvm-project/commit/25a6b891cbcd9aacee404cc0ccceed3248d93dd3
DIFF:
https://github.com/llvm/llvm-project/commit/25a6b891cbcd9aacee404cc0ccceed3248d93dd3.diff
L
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/68156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
The last usage of the deprecated `FileEntry::getLastRef()` was removed in #67838, let's remove it entirely.
---
Full diff: https://github.com/llvm/llvm-project/pull/68156.diff
1 Files Affected:
- (modified) clang/include/clang/Basic/File
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/68156
The last usage of the deprecated `FileEntry::getLastRef()` was removed in
#67838, let's remove it entirely.
>From 2691f3e3c5867a8102fe2b288534f6c794318d3c Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: T
@@ -3447,9 +3447,13 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const {
Tok = Tok->Next) {
if (Tok->Previous->EndsCppAttributeGroup)
AfterLastAttribute = Tok;
-if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line, Closing
ilg-ul wrote:
> resolving this to the actual clang binary would indeed seem like the right
> thing to do.
Great! The new simplified patch does exactly this.
> it makes me wonder if someone actually is relying on the current behaviour
To rephrase your question, you ask if someone is using a co
@@ -16339,7 +16345,7 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) {
verifyFormat("int f();", SpaceFuncDef);
verifyFormat("void f (int a, T b) {}", SpaceFuncDef);
- verifyFormat("A::A () : a(1) {}", SpaceFuncDef);
+ verifyFormat("A::A() : a(1) {}", SpaceFuncDef);
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Changes
When Shift is 0 there does nothing happen in the remainder of the loop, express
that directly.
---
Full diff: https://github.com/llvm/llvm-project/pull/68154.diff
1 Files Affected:
- (modified) clang/lib/Format/WhitespaceManager.
https://github.com/HazardyKnusperkeks created
https://github.com/llvm/llvm-project/pull/68154
When Shift is 0 there does nothing happen in the remainder of the loop, express
that directly.
From cd77a3cce4497c12c1d65d2f41d71b4ef3b5c079 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Changes
…hange
To improve debugging experience.
---
Full diff: https://github.com/llvm/llvm-project/pull/68153.diff
1 Files Affected:
- (modified) clang/lib/Format/WhitespaceManager.cpp (+31-30)
``diff
diff --git a/clang/lib/F
https://github.com/HazardyKnusperkeks created
https://github.com/llvm/llvm-project/pull/68153
…hange
To improve debugging experience.
From ae3cc1f37e4b0f3640250f4f0ac58c9c7c4f2ca6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?=
Date: Tue, 3 Oct 2023 17:31:21 +0200
Subjec
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Changes
To improve debugging experience.
---
Full diff: https://github.com/llvm/llvm-project/pull/68152.diff
1 Files Affected:
- (modified) clang/lib/Format/WhitespaceManager.cpp (+13-12)
``diff
diff --git a/clang/lib/Format/Wh
https://github.com/HazardyKnusperkeks created
https://github.com/llvm/llvm-project/pull/68152
To improve debugging experience.
From 323ddd1948aa738419fd5afd848293b1a73e4cc4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?=
Date: Tue, 3 Oct 2023 16:26:18 +0200
Subject: [PATC
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/67838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jan Svoboda
Date: 2023-10-03T13:07:46-07:00
New Revision: 27254ae51192d83fd45777cc33b004d06c2ceb50
URL:
https://github.com/llvm/llvm-project/commit/27254ae51192d83fd45777cc33b004d06c2ceb50
DIFF:
https://github.com/llvm/llvm-project/commit/27254ae51192d83fd45777cc33b004d06c2ceb50.diff
L
rampitec wrote:
> I've just tested this on 1 graphics shaders and it seems to make no
> difference at all. I tried gfx900 and gfx1100. Can anyone else from the
> graphics team confirm this?
It seems the most impact is on the pre-gfx9 targets, very similar to
https://github.com/llvm/llvm-p
rampitec wrote:
> I've just tested this on 1 graphics shaders and it seems to make no
> difference at all. I tried gfx900 and gfx1100. Can anyone else from the
> graphics team confirm this?
It seems the most impact is on the pre-gfx9 targets, very similar to
https://github.com/llvm/llvm-p
@@ -3447,9 +3447,13 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const {
Tok = Tok->Next) {
if (Tok->Previous->EndsCppAttributeGroup)
AfterLastAttribute = Tok;
-if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line, Closing
https://github.com/smeenai closed
https://github.com/llvm/llvm-project/pull/68060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Shoaib Meenai
Date: 2023-10-03T13:04:22-07:00
New Revision: c6fed74f6f2e0c208ea0324fa1668b2cba5277a9
URL:
https://github.com/llvm/llvm-project/commit/c6fed74f6f2e0c208ea0324fa1668b2cba5277a9
DIFF:
https://github.com/llvm/llvm-project/commit/c6fed74f6f2e0c208ea0324fa1668b2cba5277a9.diff
https://github.com/smeenai updated
https://github.com/llvm/llvm-project/pull/68060
>From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001
From: Shoaib Meenai
Date: Mon, 2 Oct 2023 17:50:36 -0700
Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23
The C23 standa
mstorsjo wrote:
> > I haven't checked closely
>
> Hi Martin, please check the #66704 bug report, the current behaviour is
> plainly wrong,
I would kind of agree with that in general - resolving this to the actual clang
binary would indeed seem like the right thing to do. But it makes me wonde
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/68091
>From f3812174546270051c4a2903b9a99408bf5b7ba0 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 3 Oct 2023 14:07:48 +0300
Subject: [PATCH 1/3] [clang][driver] Use platform specific calls to get the
executa
efriedma-quic wrote:
Maybe start a discourse thread to get more eyes on this discussion? We might
be able to use a hook to make llvmbot do something automatically.
https://github.com/llvm/llvm-project/pull/67066
___
cfe-commits mailing list
cfe-commi
kstoimenov wrote:
Maybe one way is to add @mention which should trigger a new email message?
On Tue, Oct 3, 2023 at 12:42 PM Vitaly Buka ***@***.***>
wrote:
> I didn't get an an email notification for that.
>
> Thanks, good to know.
> I like that in Phabricator it was possible just reopen revie
rymiel wrote:
https://buildkite.com/llvm-project/clang-ci/builds/4275#018af20e-3d3c-4344-b92d-88ac8b09b484
Tests do not pass?
https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
vitalybuka wrote:
> I didn't get an an email notification for that.
Thanks, good to know.
I like that in Phabricator it was possible just reopen review making revert
very visible to the author.
https://github.com/llvm/llvm-project/pull/67066
___
cfe-
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9a7a6dd3c358: [Modules] Make clang modules for the C
standard library headers (authored by iana).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159064/new/
Author: Ian Anderson
Date: 2023-10-03T12:41:11-07:00
New Revision: 9a7a6dd3c358ca7becef75c0a9581dcfa3e6b5f4
URL:
https://github.com/llvm/llvm-project/commit/9a7a6dd3c358ca7becef75c0a9581dcfa3e6b5f4
DIFF:
https://github.com/llvm/llvm-project/commit/9a7a6dd3c358ca7becef75c0a9581dcfa3e6b5f4.diff
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3447,9 +3447,13 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine &Line) const {
Tok = Tok->Next) {
if (Tok->Previous->EndsCppAttributeGroup)
AfterLastAttribute = Tok;
-if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line, Closing
101 - 200 of 498 matches
Mail list logo
