[clang] [TSAN] add support for riscv64 (PR #68735)

2023-10-11 Thread via cfe-commits
https://github.com/hiraditya updated https://github.com/llvm/llvm-project/pull/68735 >From 5b85613483861b3734edf9c94be390f2b3b0dd2a Mon Sep 17 00:00:00 2001 From: Alex Fan Date: Fri, 6 Oct 2023 12:32:38 -0700 Subject: [PATCH] add support for riscv64 Implements for sv39 and sv48 VMA layout.

[clang] [TSAN] add support for riscv64 (PR #68735)

2023-10-11 Thread via cfe-commits
https://github.com/hiraditya updated https://github.com/llvm/llvm-project/pull/68735 >From bcd63227792a992d6e5cd851d2fa2355d2f3c4f8 Mon Sep 17 00:00:00 2001 From: Alex Fan Date: Fri, 6 Oct 2023 12:32:38 -0700 Subject: [PATCH] [TSAN] add support for riscv64 Implements for sv39 and sv48 VMA

[clang] [TSAN] add support for riscv64 (PR #68735)

2023-10-11 Thread Alex Fan via cfe-commits
https://github.com/alexfanqi requested changes to this pull request. I missed a little piece for sv48 here ``` --- a/compiler-rt/lib/sanitizer_common/sanitizer_platform.h +++ b/compiler-rt/lib/sanitizer_common/sanitizer_platform.h @@ -303,7 +303,7 @@ #define SANITIZER_MMAP_RANGE_SIZE

[clang] [TSAN] add support for riscv64 (PR #68735)

2023-10-11 Thread Alex Fan via cfe-commits
alexfanqi wrote: Sorry. It took some time to reply. Since newer linux kernel supports sv57 and sv48, I tested this again with latest qemu and 6.6 kernel, by passing `-cpu rv64,sv48=on` to qemu. I missed a little piece here for sv48, Also to note, if we want to support sv57, we could directly

[clang] [Driver] Group together linker options using addAllArgs (PR #68349)

2023-10-11 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/68349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 894927b - [Driver] Group together linker options using addAllArgs (#68349)

2023-10-11 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-12T00:34:19-04:00 New Revision: 894927b491b7c62917ffa7ad665841683095317c URL: https://github.com/llvm/llvm-project/commit/894927b491b7c62917ffa7ad665841683095317c DIFF: https://github.com/llvm/llvm-project/commit/894927b491b7c62917ffa7ad665841683095317c.diff

[clang] [Docs][Clang] Missing DR status for C++23-era papers in cxx_status.html (PR #68846)

2023-10-11 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja created https://github.com/llvm/llvm-project/pull/68846 I'm unsure whether [P2460R2](https://wg21.link/p2460r2) should be listed in the page. The paper seemingly requires no changes. ### References - [N4891](https://wg21.link/n4891) -

[clang] [Driver] Group together linker options using addAllArgs (PR #68349)

2023-10-11 Thread Brad Smith via cfe-commits
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/68349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Group together usage of AddAllArgs (PR #68349)

2023-10-11 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/68349 >From c01c08f813264327f1c641b4aa49ea7a20dd45cd Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 16:09:04 -0400 Subject: [PATCH] [Driver] Group together linker options using addAllArgs ---

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-10-11 Thread Mingming Liu via cfe-commits
minglotus-6 wrote: > we prioritize inlining the memcpy code for a specific range based on the > hotness of that range in a particular inline context @htyu Pretty much a drive-by question if it's convenient for you to share more, how ranges are selected out of sampled values? For example, are

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Chen Zheng via cfe-commits
https://github.com/chenzheng1030 closed https://github.com/llvm/llvm-project/pull/68476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c661c4f - [AIX] recognize vsr in inline asm for AIX (#68476)

2023-10-11 Thread via cfe-commits
Author: Chen Zheng Date: 2023-10-12T08:54:45+08:00 New Revision: c661c4f57613b5f85af94ee4e905708e0ba820f8 URL: https://github.com/llvm/llvm-project/commit/c661c4f57613b5f85af94ee4e905708e0ba820f8 DIFF: https://github.com/llvm/llvm-project/commit/c661c4f57613b5f85af94ee4e905708e0ba820f8.diff

[PATCH] D8484: Allow -gsplit-dwarf for all ELF targets, not just Linux

2023-10-11 Thread Ed Maste via Phabricator via cfe-commits
emaste abandoned this revision. emaste added a comment. Herald added a project: All. Allowed for all ELF OSes as of commit ee957e045f526ce45d24b0f081f277262c3da43d Author: Fangrui Song Date: Thu Mar 28 08:24:00 2019 + [Driver] Allow -gsplit-dwarf on ELF OSes other than

[clang] [Driver] Remove identifier with the comment (PR #68351)

2023-10-11 Thread Brad Smith via cfe-commits
brad0 wrote: ping. https://github.com/llvm/llvm-project/pull/68351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/68276 >From 3bb0c8483c61e04f5ff76de920dcad89793f1326 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 5 Oct 2023 02:39:12 +0200 Subject: [PATCH] [Sema] Add check for bitfield assignments to integral types

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-10-11 Thread Snehasish Kumar via cfe-commits
snehasish wrote: > @david-xl It's interesting to know this. How is that going on your end? Currently we are exploring the design space to accommodate the variety of platforms and FDO types we use internally. This is a priority for us though so we should have some updates to share externally

[clang] [clang][Sema] Emit more specific diagnostic for auto in lambda before C++14 (#46059) (PR #68540)

2023-10-11 Thread via cfe-commits
https://github.com/weltschildkroete edited https://github.com/llvm/llvm-project/pull/68540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

2023-10-11 Thread Hongtao Yu via cfe-commits
htyu wrote: > The AutoFDO support Mingming mentioned is the vtable profiling part using > MEM_INST_RETIRED event that captures data address. This data access profiling > will/can also be used for global variable layout. However this is current > Intel only so having a branch profiling based

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Tom Eccles via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) tblah wrote: Yeah that

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread via cfe-commits
@@ -6171,6 +6171,11 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "conversion

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-11 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/68750 >From b7b0c40542589e9c54c21140dbb5b163dd8ffc7b Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Oct 2023 17:55:49 -0700 Subject: [PATCH 1/4] [Clang] Implement the 'counted_by' attribute The

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-11 Thread Bill Wendling via cfe-commits
bwendling wrote: @AaronBallman I just added a patch that modifies the diagnostics to be more in line with what you wanted. PTAL. https://github.com/llvm/llvm-project/pull/68750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Clang] Implement the 'counted_by' attribute (PR #68750)

2023-10-11 Thread Bill Wendling via cfe-commits
https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/68750 >From b7b0c40542589e9c54c21140dbb5b163dd8ffc7b Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Wed, 4 Oct 2023 17:55:49 -0700 Subject: [PATCH 1/3] [Clang] Implement the 'counted_by' attribute The

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread via cfe-commits
vabridgers wrote: > > Hi @AaronBallman , I ran a compile using this change on clang as you asked > > and have results. The compile ran with no crashes or errors, and produced > > 1478 bitfield-conversion warnings. I'll show a few examples below. To put > > that number into context, I enabled

[clang] [flang][driver] Mark -fcommon and -mtune as visible in Flang (PR #68657)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/68657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][driver] Mark -fcommon and -mtune as visible in Flang (PR #68657)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
@@ -5077,6 +5077,7 @@ def module_file_info : Flag<["-"], "module-file-info">, Flags<[NoXarchOption]>, HelpText<"Provide information about a particular module file">; def mthumb : Flag<["-"], "mthumb">, Group; def mtune_EQ : Joined<["-"], "mtune=">, Group, +

[clang] [flang][driver] Mark -fcommon and -mtune as visible in Flang (PR #68657)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space requested changes to this pull request. Thanks for working on. I would appreciate if you could add a bit more testing. https://github.com/llvm/llvm-project/pull/68657 ___ cfe-commits mailing list

[clang] [flang][driver] Mark -fcommon and -mtune as visible in Flang (PR #68657)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/68657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang][driver] Mark -fcommon and -mtune as visible in Flang (PR #68657)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
@@ -10,6 +10,9 @@ ! Make sure that `-L' is "visible" to Flang's driver ! RUN: %flang -L/ -### %s +! Make sure that `-fcommon' is "visible" to Flang's driver banach-space wrote: This is not clear because I didn't leave any comment in this file (mea culpa,

[clang] [WIP][-Wunsafe-buffer-usage] Start emitting std::array fixits (PR #68037)

2023-10-11 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: We will need a new warning text here. "To preserve bounds information" isn't our goal; the traditional C array already preserves bounds information as part of the type. Theoretically, we could teach the compiler to harden all raw C array operations without converting it to

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/68276 >From f70a9fb484d5bdee8319833cde28ee02f3a248ff Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 5 Oct 2023 02:39:12 +0200 Subject: [PATCH] [Sema] Add check for bitfield assignments to integral types

[clang] [clang][Sema] Emit more specific diagnostic for auto in lambda before C++14 (#46059) (PR #68540)

2023-10-11 Thread via cfe-commits
https://github.com/weltschildkroete updated https://github.com/llvm/llvm-project/pull/68540 >From 613ea6809b478ff7391614b24ec177fc19339cdd Mon Sep 17 00:00:00 2001 From: Leonardo Duarte Date: Sun, 8 Oct 2023 12:59:15 +0200 Subject: [PATCH 1/6] [clang][Sema] Emit more specific diagnostic for

[clang] [clang][Sema] Emit more specific diagnostic for auto in lambda before C++14 (#46059) (PR #68540)

2023-10-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 606f89ab7d537ca068fb1be9fd89d96a30de38f8 031e76900f6e63c97ed8666066ff98d967305af4 --

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Renaud Kauffmann via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) Renaud-K wrote: I am

[clang] [clang][Sema] Emit more specific diagnostic for auto in lambda before C++14 (#46059) (PR #68540)

2023-10-11 Thread via cfe-commits
@@ -3605,8 +3605,11 @@ static QualType GetDeclSpecTypeForDeclarator(TypeProcessingState , Info = (); } else { // In C++14, generic lambdas allow 'auto' in their parameters. -if (!SemaRef.getLangOpts().CPlusPlus14 || !Auto || -

[clang] [clang][Sema] Emit more specific diagnostic for auto in lambda before C++14 (#46059) (PR #68540)

2023-10-11 Thread via cfe-commits
https://github.com/weltschildkroete updated https://github.com/llvm/llvm-project/pull/68540 >From 613ea6809b478ff7391614b24ec177fc19339cdd Mon Sep 17 00:00:00 2001 From: Leonardo Duarte Date: Sun, 8 Oct 2023 12:59:15 +0200 Subject: [PATCH 1/5] [clang][Sema] Emit more specific diagnostic for

[libunwind] [OpenMP] Improve omp offload profiler (PR #68016)

2023-10-11 Thread via cfe-commits
fel-cab wrote: I have prepared a presentation to better explain the proposed changes https://docs.google.com/presentation/d/1lLlR7g29MWidaX9BLCUaKZhdvN-dphUE2BGMXhZCIoA/edit?usp=sharing https://github.com/llvm/llvm-project/pull/68016 ___ cfe-commits

[clang] [OpenMP] Improve omp offload profiler (PR #68016)

2023-10-11 Thread via cfe-commits
fel-cab wrote: I have prepared a presentation to better explain the proposed changes https://docs.google.com/presentation/d/1lLlR7g29MWidaX9BLCUaKZhdvN-dphUE2BGMXhZCIoA/edit?usp=sharing https://github.com/llvm/llvm-project/pull/68016 ___ cfe-commits

[clang-tools-extra] [OpenMP] Improve omp offload profiler (PR #68016)

2023-10-11 Thread via cfe-commits
fel-cab wrote: I have prepared a presentation to better explain the proposed changes https://docs.google.com/presentation/d/1lLlR7g29MWidaX9BLCUaKZhdvN-dphUE2BGMXhZCIoA/edit?usp=sharing https://github.com/llvm/llvm-project/pull/68016 ___ cfe-commits

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-10-11 Thread Alexander Richardson via cfe-commits
arichardson wrote: > This would look good to me, but we seem to be failing the Windows tests! Unfortunately I can't see what's going wrong there and I don't have an easy way of reproducing it. I'll try to add some debugging code to this PR in the coming days.

[clang] [clang][dataflow] Add support for lambda captures (PR #68558)

2023-10-11 Thread Stanislav Gatev via cfe-commits
https://github.com/sgatev closed https://github.com/llvm/llvm-project/pull/68558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 52d0696 - [clang][dataflow] Add support for lambda captures (#68558)

2023-10-11 Thread via cfe-commits
Author: Stanislav Gatev Date: 2023-10-11T22:18:46+02:00 New Revision: 52d06963551938cfe9a2cf481608699cd988d824 URL: https://github.com/llvm/llvm-project/commit/52d06963551938cfe9a2cf481608699cd988d824 DIFF:

[clang] [flang] Add flags controlling whether to run the fir alias tags pass (PR #68595)

2023-10-11 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. LGTM, thank you for addressing my comments! https://github.com/llvm/llvm-project/pull/68595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Tom Eccles via cfe-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/68727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Tom Eccles via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) tblah wrote: So, if I

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread via cfe-commits
@@ -6171,6 +6171,11 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "conversion

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68820 >From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 10 Oct 2023 08:31:41 -0700 Subject: [PATCH 1/2] Add support for -fcx-limited-range and #pragma

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

2023-10-11 Thread Erich Keane via cfe-commits
@@ -274,20 +274,27 @@ class DefaultIntArgument : IntArgument { } // This argument is more complex, it includes the enumerator type name, -// a list of strings to accept, and a list of enumerators to map them to. -class EnumArgument values, +// a list of possible values, and

[clang] [flang] add tbaa tags to global variables (PR #68727)

2023-10-11 Thread Renaud Kauffmann via cfe-commits
@@ -406,7 +406,7 @@ AliasAnalysis::Source AliasAnalysis::getSource(mlir::Value v) { attributes.set(Attribute::Pointer); } - if (type == SourceKind::Global) + if (type == SourceKind::Global || type == SourceKind::Direct) Renaud-K wrote: Would

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -282,7 +282,7 @@ LANGOPT(HIPUseNewLaunchAPI, 1, 0, "Use new kernel launching API for HIP") LANGOPT(OffloadUniformBlock, 1, 0, "Assume that kernels are launched with uniform block sizes (default true for CUDA/HIP and false otherwise)") LANGOPT(HIPStdPar, 1, 0, "Enable

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -2821,6 +2821,10 @@ def fms_compatibility : Flag<["-"], "fms-compatibility">, Group, Visibility<[ClangOption, CC1Option, CLOption]>, HelpText<"Enable full Microsoft Visual C++ compatibility">, MarshallingInfoFlag>; +def fms_define_stdc : Flag<["-"],

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -123,6 +123,10 @@ // CHECK-CHAR8_T_: "-fno-char8_t" +// RUN: %clang_cl /dev/null /E -Xclang -dM 2> /dev/null | FileCheck -match-full-lines %s --check-prefix=STDCOFF +// RUN: %clang_cl /dev/null /E -Xclang -dM /Zc:__STDC__ 2> /dev/null | FileCheck -match-full-lines %s

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! Please be sure to add a release note to `clang/docs/ReleaseNotes.rst` so users know about the new functionality. https://github.com/llvm/llvm-project/pull/68690 ___ cfe-commits

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -7922,6 +7926,10 @@ void Clang::AddClangCLArgs(const ArgList , types::ID InputType, CmdArgs.push_back("-fno-wchar"); } + if (Args.hasArg(options::OPT_fms_define_stdc)) { + CmdArgs.push_back("-fms-define-stdc"); + } AaronBallman wrote: ```suggestion

[clang] [clang] Add /Zc:__STDC__ flag to clang-cl (PR #68690)

2023-10-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/68690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-10-11 Thread kleines Filmröllchen via cfe-commits
@@ -483,6 +483,56 @@ struct FragmentCompiler { FullyQualifiedNamespaces.begin(), FullyQualifiedNamespaces.end()); }); } +auto QuotedFilter = compileHeaderRegexes(F.QuotedHeaders); +if (QuotedFilter.has_value()) { + Out.Apply.push_back( +

[clang] [clang] Differentiate between identifier and string EnumArgument (PR #68550)

2023-10-11 Thread Alexander Richardson via cfe-commits
@@ -886,7 +893,7 @@ def ARMInterrupt : InheritableAttr, TargetSpecificAttr { // MSP430Interrupt's, MipsInterrupt's and AnyX86Interrupt's spellings // must match. let Spellings = [GCC<"interrupt">]; - let Args = [EnumArgument<"Interrupt", "InterruptType", + let Args =

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/68815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] eb21049 - [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (#68815)

2023-10-11 Thread via cfe-commits
Author: Alexander Richardson Date: 2023-10-11T19:46:09+01:00 New Revision: eb21049b4b904b072679ece60e73c6b0dc0d1ebf URL: https://github.com/llvm/llvm-project/commit/eb21049b4b904b072679ece60e73c6b0dc0d1ebf DIFF:

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Hi @AaronBallman , I ran a compile using this change on clang as you asked > and have results. The compile ran with no crashes or errors, and produced > 1478 bitfield-conversion warnings. I'll show a few examples below. To put > that number into context, I enabled

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -6171,6 +6171,11 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "conversion

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/68815 >From 5d4e2bc5570f9fbcdebff2532370ad21f5cef2bb Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 11 Oct 2023 08:52:45 -0700 Subject: [PATCH] [libunwind] Avoid reading OOB for non-existent

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/68815 >From 63415241cd457cd4bcd0661e077b9f8c48e246e2 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 11 Oct 2023 08:52:45 -0700 Subject: [PATCH] [libunwind] Avoid reading OOB for non-existent

[libunwind] [libunwind] Fix wrong end argument passed to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] 05181a8 - [libunwind] Fix wrong end argument passed to decodeEHHdr() (#68813)

2023-10-11 Thread via cfe-commits
Author: Alexander Richardson Date: 2023-10-11T19:35:11+01:00 New Revision: 05181a849b4c1ec14fdd6d667285d6f5ad34a5a2 URL: https://github.com/llvm/llvm-project/commit/05181a849b4c1ec14fdd6d667285d6f5ad34a5a2 DIFF:

[clang-tools-extra] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68825 >From ff635ce0ce910f0cde248a4babb3c27333ddc108 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Sun, 3 Sep 2023 22:40:10 -0500 Subject: [PATCH 1/3] [mlir][OpenMP] Added omp.region operation This patch

[clang] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/68825 >From ff635ce0ce910f0cde248a4babb3c27333ddc108 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Sun, 3 Sep 2023 22:40:10 -0500 Subject: [PATCH 1/3] [mlir][OpenMP] Added omp.region operation This patch

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/68815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
shraiysh wrote: Restarting discussion about yield here because something went wrong with rebasing on previous PR. Hopefully this won't have the same issues. Sorry :( I will push commit with yield as terminator soon. https://github.com/llvm/llvm-project/pull/68825

[clang] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
shraiysh wrote: Restarting discussion about yield here because something went wrong with rebasing on previous PR. Hopefully this won't have the same issues. Sorry :( I will push commit with yield as terminator soon. https://github.com/llvm/llvm-project/pull/68825

[clang-tools-extra] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Shraiysh (shraiysh) Changes This patch adds `omp.structured_region` operation. This is equivalent to a code block surrounded by an OpenMP construct in C/C++/Fortran. This is a part of the effort to implement the canonical loop operation

[clang] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Shraiysh (shraiysh) Changes This patch adds `omp.structured_region` operation. This is equivalent to a code block surrounded by an OpenMP construct in C/C++/Fortran. This is a part of the effort to implement the canonical loop operation

[clang-tools-extra] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/68825 This patch adds `omp.structured_region` operation. This is equivalent to a code block surrounded by an OpenMP construct in C/C++/Fortran. This is a part of the effort to implement the canonical loop operation

[clang] [mlir][OpenMP] Added `omp.structured_region` operation (PR #68825)

2023-10-11 Thread via cfe-commits
https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/68825 This patch adds `omp.structured_region` operation. This is equivalent to a code block surrounded by an OpenMP construct in C/C++/Fortran. This is a part of the effort to implement the canonical loop operation

[clang] [clang] static operators should evaluate object argument (PR #68485)

2023-10-11 Thread Tianlan Zhou via cfe-commits
https://github.com/SuperSodaSea updated https://github.com/llvm/llvm-project/pull/68485 >From 03276260c48d9cafb2a0d80825156e77cdf02eba Mon Sep 17 00:00:00 2001 From: SuperSodaSea Date: Sat, 7 Oct 2023 21:05:17 +0800 Subject: [PATCH 1/6] [clang] static operators should evaluate object argument

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -136,6 +136,17 @@ int main(void) { // Cleanup happens automatically -> no warning. } + /// Function pointers + { +int __attribute__((requires_capability())) (*function_ptr)(int) = Foo_fun1;

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -8141,6 +8141,16 @@ static void handleRequiresCapabilityAttr(Sema , Decl *D, if (!AL.checkAtLeastNumArgs(S, 1)) return; + // We allow this on function declaration as well as + // variable declarations of function

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman commented: The changes also need a release note at some point. https://github.com/llvm/llvm-project/pull/67095 ___ cfe-commits mailing list

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/67095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][TSA] Make RequiresCapability a DeclOrType attribute (PR #67095)

2023-10-11 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -3315,7 +3315,7 @@ def RequiresCapability : InheritableAttr { let TemplateDependent = 1; let ParseArgumentsAsUnevaluated = 1; let InheritEvenIfAlreadyPresent = 1; - let Subjects = SubjectList<[Function]>; + /*let

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -289,6 +289,11 @@ Bug Fixes to Compiler Builtins Bug Fixes to Attribute Support ^^ +- Clang now emits a warning instead of an error when using the one or two + argument form of GCC 11's ``__attribute__((malloc(deallocator)))`` + or

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -1,12 +1,14 @@ -// RUN: %clang_cc1 -verify -Wunused -Wused-but-marked-unused -Wunused-parameter -fsyntax-only %s +// RUN: %clang_cc1 -verify -Wunused -Wused-but-marked-unused -Wunused-parameter -fsyntax-only -fdeclspec %s int a; inline __attribute__((noreturn(a))) void

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

2023-10-11 Thread Aaron Ballman via cfe-commits
@@ -177,6 +177,10 @@ def warn_unknown_attribute_ignored : Warning< "unknown attribute %0 ignored">, InGroup; def warn_attribute_ignored : Warning<"%0 attribute ignored">, InGroup; +def warn_multiarg_malloc_attribute_ignored: Warning< + "'malloc' attribute ignored because"

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Hubert Tong via cfe-commits
hubert-reinterpretcast wrote: The code formatting check failure seems to be a infrastructure problem: https://discourse.llvm.org/t/clang-format-github-action-cannot-find-merge-base/73894 https://github.com/llvm/llvm-project/pull/68476 ___ cfe-commits

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm edited https://github.com/llvm/llvm-project/pull/68476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Stefan Pintilie via cfe-commits
https://github.com/stefanp-ibm approved this pull request. Thank you for fixing this! LGTM. https://github.com/llvm/llvm-project/pull/68476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Stefan Pintilie via cfe-commits
@@ -828,10 +829,7 @@ const TargetInfo::AddlRegName GCCAddlRegNames[] = { }; ArrayRef PPCTargetInfo::getGCCAddlRegNames() const { - if (ABI == "elfv2") -return llvm::ArrayRef(GCCAddlRegNames); - else -return TargetInfo::getGCCAddlRegNames(); + return

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c1b6ed42b75a17d1718aa377f76633b27e15a4e2 91de35737b74233f29da76573b4099bf64e8bdd4 --

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2023-10-11 Thread Andrew Kaster via cfe-commits
@@ -483,6 +483,56 @@ struct FragmentCompiler { FullyQualifiedNamespaces.begin(), FullyQualifiedNamespaces.end()); }); } +auto QuotedFilter = compileHeaderRegexes(F.QuotedHeaders); +if (QuotedFilter.has_value()) { + Out.Apply.push_back( +

[clang] Add support for -fcx-limited-range and #pragma CX_LIMITED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/68820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add support for -fcx-limited-range and #pragma CX_LIMTED_RANGE. (PR #68820)

2023-10-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/68820 None >From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 10 Oct 2023 08:31:41 -0700 Subject: [PATCH] Add support for -fcx-limited-range and #pragma

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

2023-10-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158069/new/ https://reviews.llvm.org/D158069 ___ cfe-commits mailing

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/68815 >From ff360ee7f304424dd0d12d00b8c0ba6801241410 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 11 Oct 2023 08:34:55 -0700 Subject: [PATCH 1/2] [libunwind] Fix wrong end argument passed to

[libunwind] [libunwind] Fix wrong end argument passed to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
arichardson wrote: > > Can we merge this into #68815 please? > > I'd like to keep the two commits separate since they are addressing different > bugs. This would be a lot easier if I could chose rebase+merge in the PR flow. https://github.com/llvm/llvm-project/pull/68813

[libunwind] [libunwind] Fix wrong end argument passed to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
arichardson wrote: > Can we merge this into #68815 please? I'd like to keep the two commits separate since they are addressing different bugs. https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [AIX] recognize vsr in inline asm for AIX (PR #68476)

2023-10-11 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast approved this pull request. LGTM, but I am not sure if @stefanp-ibm continues to be concerned about enabling this for ABIs that have not been updated to specify a treatment of the VSX registers. https://github.com/llvm/llvm-project/pull/68476

[libunwind] [libunwind] Fix wrong end argument passed to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Consistently pass start+length to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/68813 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Consistently pass start+length to decodeEHHdr() (PR #68813)

2023-10-11 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/68813 >From ff360ee7f304424dd0d12d00b8c0ba6801241410 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 11 Oct 2023 08:34:55 -0700 Subject: [PATCH] [libunwind] Fix wrong end argument passed to decodeEHHdr()

[libunwind] [libunwind] Avoid reading OOB for non-existent .eh_frame_hdr (PR #68815)

2023-10-11 Thread Saleem Abdulrasool via cfe-commits
@@ -53,8 +53,21 @@ template class EHHeaderParser { template bool EHHeaderParser::decodeEHHdr(A , pint_t ehHdrStart, -pint_t ehHdrEnd, EHHeaderInfo ) { +size_t ehHdrSize, EHHeaderInfo ) { pint_t p =

  1   2   3   >