Author: Kazu Hirata
Date: 2023-10-19T23:55:02-07:00
New Revision: 8c88a823985a6cb4de9d5c1bba9b03747c75c622
URL:
https://github.com/llvm/llvm-project/commit/8c88a823985a6cb4de9d5c1bba9b03747c75c622
DIFF:
https://github.com/llvm/llvm-project/commit/8c88a823985a6cb4de9d5c1bba9b03747c75c622.diff
L
@@ -354,6 +354,48 @@ define <2 x i64> @fshl_select_vector(<2 x i64> %x, <2 x
i64> %y, <2 x i64> %sham
ret <2 x i64> %r
}
+; Convert 'or concat' to fshl if opposite 'or concat' exists.
+
+define i32 @fshl_concat(i8 %x, i24 %y, ptr %addr) {
+; CHECK-LABEL: @fshl_concat(
+; CH
@@ -2840,6 +2841,46 @@ static Instruction *matchFunnelShift(Instruction &Or,
InstCombinerImpl &IC) {
return nullptr;
FShiftArgs = {ShVal0, ShVal1, ShAmt};
+ } else if (isa(Or0) || isa(Or1)) {
+// If there are two 'or' instructions concat variables in opposite o
https://github.com/HaohaiWen updated
https://github.com/llvm/llvm-project/pull/68502
>From 5b3b1bbb5b263bc5711adde031d85b1461ccbab6 Mon Sep 17 00:00:00 2001
From: Haohai Wen
Date: Sat, 7 Oct 2023 13:48:32 +0800
Subject: [PATCH 1/3] [InstCombine] Refactor matchFunnelShift to allow more
pattern
@@ -257,14 +256,9 @@ const char *const Runtimes = R"(
void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, long double);
void __clang_Interpreter_SetValueNoAlloc(void*,void*,void*,unsigned long
long);
template
-void __clang_Interpreter_SetValueCopyArr
https://github.com/makslevental edited
https://github.com/llvm/llvm-project/pull/69072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder marked an inline comment as done.
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/Descriptor.h:207
/// Initializes the map with no fields set.
InitMap(unsigned N);
aaron.ballman wrote:
> Now that this is public, can we make it `exp
tbaeder updated this revision to Diff 557801.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154581/new/
https://reviews.llvm.org/D154581
Files:
clang/lib/AST/Interp/Descriptor.cpp
clang/lib/AST/Interp/Descriptor.h
clang/lib/AST/Interp/EvalEmitter.cpp
clang/lib/AST/Interp/EvalEmit
tbaederr wrote:
FWIW this failed for me locally as well but I'm not using `BUILD_SHARED_LIBS`.
I am linking with the clang dylib though, which has the same problem I think.
https://github.com/llvm/llvm-project/pull/69078
___
cfe-commits mailing list
c
wangpc-pp wrote:
Ping. Any suggestions?
https://github.com/llvm/llvm-project/pull/67646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Carlos Alberto Enciso (CarlosAlbertoEnciso)
Changes
Do not emit call to llvm.dbg.declare when the variable declaration
is a DecompositionDecl as its instance class is always unnamed.
The emitted debug declare looks like:
```
call void @llv
https://github.com/CarlosAlbertoEnciso created
https://github.com/llvm/llvm-project/pull/69681
Do not emit call to llvm.dbg.declare when the variable declaration
is a DecompositionDecl as its instance class is always unnamed.
The emitted debug declare looks like:
```
call void @llvm.dbg.declare
Author: Kazu Hirata
Date: 2023-10-19T23:28:25-07:00
New Revision: 24f03d9b19dda40f757341ffa1ea89faa64cfbde
URL:
https://github.com/llvm/llvm-project/commit/24f03d9b19dda40f757341ffa1ea89faa64cfbde
DIFF:
https://github.com/llvm/llvm-project/commit/24f03d9b19dda40f757341ffa1ea89faa64cfbde.diff
L
balazske wrote:
The checker was tested additionally on projects libwebm, bitcoin, contour and
produced no results.
https://github.com/llvm/llvm-project/pull/69469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -24,6 +24,7 @@
#include "llvm/ExecutionEngine/Orc/LLJIT.h"
#include "llvm/Support/ManagedStatic.h"
#include "llvm/Support/TargetSelect.h"
+#include "llvm/TargetParser/Host.h"
vgvassilev wrote:
The changes in this file should not be needed.
https://github.
@@ -148,12 +161,12 @@ TEST(InterpreterTest, UndoCommand) {
auto Interp = createInterpreter(ExtraArgs, DiagPrinter.get());
// Fail to undo.
- auto Err1 = Interp->Undo();
+ auto Err1 = Interp->Undo(2);
vgvassilev wrote:
Likewise.
https://github.com/llvm
https://github.com/vgvassilev edited
https://github.com/llvm/llvm-project/pull/69072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -257,14 +256,9 @@ const char *const Runtimes = R"(
void __clang_Interpreter_SetValueNoAlloc(void*, void*, void*, long double);
void __clang_Interpreter_SetValueNoAlloc(void*,void*,void*,unsigned long
long);
template
-void __clang_Interpreter_SetValueCopyArr
@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and
reduced .bc file
that bugpoint emits. If something goes wrong with bugpoint, please submit
the "foo.bc" file and the option that llc crashes with.
+LTO bugs
+---
+
+If you
@@ -450,6 +474,18 @@ multiclass VPatVC_XVV;
+ // Add another patterns for float type return value.
+ if !ne(wti.SEW, 8) then {
+defvar wfti = !cast("VF"#wti.SEW#wti.LMul.MX);
topperc wrote:
some mix is probably good enough
https://github.com/llvm/llvm-proj
https://github.com/mdfazlay updated
https://github.com/llvm/llvm-project/pull/69534
>From 0b162fd70f24f734f823816171ee0ae5df466d87 Mon Sep 17 00:00:00 2001
From: Fazlay Rabbi
Date: Wed, 18 Oct 2023 13:21:17 -0700
Subject: [PATCH] [OpenMP 5.2] Deprecate syntax of map modifiers without comma
sep
https://github.com/yubingex007-a11y closed
https://github.com/llvm/llvm-project/pull/69569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yubingex007-a11y
Date: 2023-10-20T13:43:34+08:00
New Revision: f2517cbceec0bd9b049ba24f36cb3a2508c988fa
URL:
https://github.com/llvm/llvm-project/commit/f2517cbceec0bd9b049ba24f36cb3a2508c988fa
DIFF:
https://github.com/llvm/llvm-project/commit/f2517cbceec0bd9b049ba24f36cb3a2508c988fa.di
https://github.com/makslevental updated
https://github.com/llvm/llvm-project/pull/69072
>From 891cdd5ceea279362c3df221fd4ae73c142b2f7e Mon Sep 17 00:00:00 2001
From: max
Date: Sat, 14 Oct 2023 12:46:42 -0500
Subject: [PATCH] [clang][repl] fix `new`
---
clang/lib/Interpreter/Interpreter.cpp
makslevental wrote:
@vgvassilev this seems acceptable?
https://github.com/llvm/llvm-project/pull/69072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo wrote:
> I hope that we do not drop `LLVM_LIBRARY_VISIBILITY` arbitrarily from
> `clang::driver::toolchains::*` classes, just because some unittests need to
> reference the symbols in a shared object.
That’s a reasonable point.
> ```c
> #if !defined(LLVM_BUILD_SHARED_LIBS)
> ```
>
>
https://github.com/makslevental updated
https://github.com/llvm/llvm-project/pull/69072
>From 940da2de0fc92e8e0da64fd35ad08effb6093447 Mon Sep 17 00:00:00 2001
From: max
Date: Sat, 14 Oct 2023 12:46:42 -0500
Subject: [PATCH] [clang][repl] fix `new`
---
clang/lib/Interpreter/Interpreter.cpp
@@ -450,6 +474,18 @@ multiclass VPatVC_XVV;
+ // Add another patterns for float type return value.
+ if !ne(wti.SEW, 8) then {
+defvar wfti = !cast("VF"#wti.SEW#wti.LMul.MX);
4vtomat wrote:
Do you think test cases all of combination of vector type arguments
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/69106
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14,13 +14,42 @@ using namespace clang::ast_matchers;
namespace clang::tidy::cppcoreguidelines {
+static bool hasConstQualifier(QualType Type) {
+ const QualType PtrType = Type->getPointeeType();
+ if (!PtrType.isNull())
+return hasConstQualifier(PtrType);
+
+ retur
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/69501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/69501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/69501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -450,6 +474,18 @@ multiclass VPatVC_XVV;
+ // Add another patterns for float type return value.
+ if !ne(wti.SEW, 8) then {
+defvar wfti = !cast("VF"#wti.SEW#wti.LMul.MX);
4vtomat wrote:
Yes, I'll add some tests for it~
https://github.com/llvm/llvm-proj
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/69501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14,13 +14,42 @@ using namespace clang::ast_matchers;
namespace clang::tidy::cppcoreguidelines {
+static bool hasConstQualifier(QualType Type) {
+ const QualType PtrType = Type->getPointeeType();
+ if (!PtrType.isNull())
+return hasConstQualifier(PtrType);
+
+ retur
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/69501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/makslevental updated
https://github.com/llvm/llvm-project/pull/69072
>From 737bef4f36139f0347e9ab58838e41aadbb45d16 Mon Sep 17 00:00:00 2001
From: max
Date: Sat, 14 Oct 2023 12:46:42 -0500
Subject: [PATCH] [clang][repl] fix `new`
---
clang/lib/Interpreter/Interpreter.cpp
https://github.com/makslevental updated
https://github.com/llvm/llvm-project/pull/69072
>From f2d35a0f0356d5ea570019bc02558bd5fc143afb Mon Sep 17 00:00:00 2001
From: max
Date: Sat, 14 Oct 2023 12:46:42 -0500
Subject: [PATCH 1/3] [clang][repl] fix `new`
---
clang/lib/Interpreter/Interpreter.cp
MaskRay wrote:
I hope that we do not drop `LLVM_LIBRARY_VISIBILITY` arbitrarily from
`clang::driver::toolchains::*` classes, just because some unittests need to
reference the symbols in a shared object.
```c
#if !defined(LLVM_BUILD_SHARED_LIBS)
```
is not great but is not too bad. `-DBUILD_SH
@@ -36,10 +36,12 @@
// RUN: | FileCheck --check-prefix=CHECK-MIPS64-LD %s
// RUN: %clang --target=mips64el-unknown-openbsd -### %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-MIPS64EL-LD %s
-// CHECK-LD-R: "-r"
+// CHECK-LD-R-NOT: "-e" "__start"
Mas
@@ -0,0 +1,65 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
MaskRay wrote:
`-Bdynamic` is the linker default, so you can remove it. Gnu.cpp uses
`-Bdynamic` like `)` to close `-Bstatic`: `-Bstatic ... `-Bdynamic`
https://github.com/llvm/llvm-project/pull/67254
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/67254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/karka228 updated
https://github.com/llvm/llvm-project/pull/69521
>From a9bfc65f6d6b0953cd762f851fb6044e1c4b8ab8 Mon Sep 17 00:00:00 2001
From: Karl-Johan Karlsson
Date: Wed, 18 Oct 2023 16:40:53 +0200
Subject: [PATCH 1/2] [Sema] Fixed faulty shift count warning
Constant valu
@@ -450,6 +474,18 @@ multiclass VPatVC_XVV;
+ // Add another patterns for float type return value.
+ if !ne(wti.SEW, 8) then {
+defvar wfti = !cast("VF"#wti.SEW#wti.LMul.MX);
topperc wrote:
Do we need new tests for this?
https://github.com/llvm/llvm-projec
antangelo wrote:
I've posted a candidate reland of this PR at #69676 .
https://github.com/llvm/llvm-project/pull/68379
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (antangelo)
Changes
Reland of dd0fba11690f9fef304d5f48cde646e5eca8d3c0
When a nested template is instantiated, the template pattern of the inner class
is not copied into the outer class
ClassTemplateSpecializationDecl. The specializa
https://github.com/antangelo created
https://github.com/llvm/llvm-project/pull/69676
Reland of dd0fba11690f9fef304d5f48cde646e5eca8d3c0
When a nested template is instantiated, the template pattern of the inner class
is not copied into the outer class
ClassTemplateSpecializationDecl. The specia
https://github.com/makslevental updated
https://github.com/llvm/llvm-project/pull/69072
>From d7c57d94d7e75ed1e0df87ebf3c4464e7b951453 Mon Sep 17 00:00:00 2001
From: max
Date: Sat, 14 Oct 2023 12:46:42 -0500
Subject: [PATCH 1/3] [clang][repl] fix `new`
---
clang/lib/Interpreter/Interpreter.cp
smeenai added a comment.
This looks great to me, thanks. @rjmccall should sign off on it though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108905/new/
https://reviews.llvm.org/D108905
___
cfe-commits
https://github.com/4vtomat closed
https://github.com/llvm/llvm-project/pull/68295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
h-vetinari wrote:
JeanHeyd wrote up a [blog
post](https://thephd.dev/implementing-embed-c-and-c++) about this
implementation, which is probably helpful as background material for any
prospective reviewers. :)
https://github.com/llvm/llvm-project/pull/68620
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/68295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay updated this revision to Diff 557798.
MaskRay retitled this revision from "[ItaniumCXXABI] Make __cxa_end_catch calls
unconditionally nounwind" to "[ItaniumCXXABI] Add
-fassume-nothrow-exception-dtor to assume that an exception object' destructor
is nothrow".
MaskRay edited the summary o
https://github.com/whousemyname updated
https://github.com/llvm/llvm-project/pull/69411
>From 043d29cd597a7447037286293fe1a1b3ccf8d79d Mon Sep 17 00:00:00 2001
From: angryZ
Date: Wed, 18 Oct 2023 10:39:56 +0800
Subject: [PATCH] [llvm][Tablegen][BUG] : The correct td file ending with
#endif (th
https://github.com/whousemyname updated
https://github.com/llvm/llvm-project/pull/69411
>From 043d29cd597a7447037286293fe1a1b3ccf8d79d Mon Sep 17 00:00:00 2001
From: angryZ
Date: Wed, 18 Oct 2023 10:39:56 +0800
Subject: [PATCH] [llvm][Tablegen][BUG] : The correct td file ending with
#endif (th
@@ -476,6 +524,31 @@ class GetFTypeInfo {
!eq(Scalar, f64) : "FPR64");
}
+multiclass VPatVMACC info_pairs, ValueType vec_m1> {
+ foreach pair = info_pairs in {
+defvar VdInfo = pair.Wti;
+defvar Vs2Info = pair.Vti;
+let Predicates = [
@@ -558,6 +558,12 @@ DecodeStatus RISCVDisassembler::getInstruction(MCInst &MI,
uint64_t &Size,
"XTHeadVdot custom opcode table");
TRY_TO_DECODE_FEATURE(RISCV::FeatureVendorXSfvcp, DecoderTableXSfvcp32,
"SiFive VCIX custo
yxsamliu wrote:
[AMD Official Use Only - General]
Fixed by 9d10fbbb299eae4a63f1028274e2ffe92bf8e75a
From: Nico Weber ***@***.***>
Sent: Thursday, October 19, 2023 8:03 PM
To: llvm/llvm-project ***@***.***>
Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***>
Subject: Re: [llvm/llvm-proj
Author: Yaxun (Sam) Liu
Date: 2023-10-19T21:48:05-04:00
New Revision: 9d10fbbb299eae4a63f1028274e2ffe92bf8e75a
URL:
https://github.com/llvm/llvm-project/commit/9d10fbbb299eae4a63f1028274e2ffe92bf8e75a
DIFF:
https://github.com/llvm/llvm-project/commit/9d10fbbb299eae4a63f1028274e2ffe92bf8e75a.dif
https://github.com/kazutakahirata approved this pull request.
LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/69569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yxsamliu wrote:
[AMD Official Use Only - General]
Will fix it now. Thanks.
Sam
From: Nico Weber ***@***.***>
Sent: Thursday, October 19, 2023 8:03 PM
To: llvm/llvm-project ***@***.***>
Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***>
Subject: Re: [llvm/llvm-project] Let clang-cl su
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool
ExpectClassBody) {
SmallVector LBraceStack;
assert(Tok->is(tok::l_brace));
do {
-// Get next non-comment token.
-FormatToken *NextTok;
-do {
- NextTok = Tokens->getNextToken();
-
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool
ExpectClassBody) {
SmallVector LBraceStack;
assert(Tok->is(tok::l_brace));
do {
-// Get next non-comment token.
-FormatToken *NextTok;
-do {
- NextTok = Tokens->getNextToken();
-
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool
ExpectClassBody) {
SmallVector LBraceStack;
assert(Tok->is(tok::l_brace));
do {
-// Get next non-comment token.
-FormatToken *NextTok;
-do {
- NextTok = Tokens->getNextToken();
-
owenca wrote:
@mydeveloperday what do you think?
https://github.com/llvm/llvm-project/pull/69228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nico wrote:
Hello, it looks like this breaks check-clang on mac:
http://45.33.8.238/macm1/71368/step_7.txt
Please take a look and revert for now if it takes a while to fix.
https://github.com/llvm/llvm-project/pull/68921
___
cfe-commits mailing list
@@ -275,7 +274,14 @@ Interpreter::create(std::unique_ptr CI) {
if (Err)
return std::move(Err);
- auto PTU = Interp->Parse(Runtimes);
+ std::string runtimes = "";
+ if (llvm::Triple(llvm::sys::getProcessTriple()).isOSDarwin())
+runtimes += "#include \n";
--
https://github.com/ributzka updated
https://github.com/llvm/llvm-project/pull/69262
>From ceaf58ba2f752b8a5353568013ff18603b0e615b Mon Sep 17 00:00:00 2001
From: Juergen Ributzka
Date: Mon, 28 Aug 2023 15:25:48 -0700
Subject: [PATCH] [llvm] Use XMACROS for MachO platforms.
This change adds the
@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and
reduced .bc file
that bugpoint emits. If something goes wrong with bugpoint, please submit
the "foo.bc" file and the option that llc crashes with.
+LTO bugs
+---
+
+If you
ributzka wrote:
Unrelated build issue on windows:
C:\ws\src\mlir\include\mlir/IR/BuiltinTypeInterfaces.h(14): fatal error C1083:
Cannot open include file: 'mlir/IR/BuiltinTypeInterfaces.h.inc': No such file
or directory
https://github.com/llvm/llvm-project/pull/69262
__
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> Here's my solution to one of the regressions I caused (#68404)
I don't think it's a regression. On the contrary, it actually exposed another
bug. :)
https://github.com/llvm/llvm-project/pull/69473
___
cfe-commits mailing list
cfe-com
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool
ExpectClassBody) {
SmallVector LBraceStack;
assert(Tok->is(tok::l_brace));
do {
-// Get next non-comment token.
-FormatToken *NextTok;
-do {
- NextTok = Tokens->getNextToken();
-
https://github.com/Bigcheese approved this pull request.
LGTM. The rest of clang reasons about this at the top level module, so so
should this.
https://github.com/llvm/llvm-project/pull/69651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/69649
>From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 19 Oct 2023 22:23:03 +
Subject: [PATCH 1/3] Update stdckdint.h and make it available in pre-C23
modes.
https://github.com/ian-twilightcoder updated
https://github.com/llvm/llvm-project/pull/69651
>From 7b88bf3102240d1734feab8919a049f8a92ca0e0 Mon Sep 17 00:00:00 2001
From: Ian Anderson
Date: Thu, 19 Oct 2023 15:22:11 -0700
Subject: [PATCH] [Modules] textual headers in submodules never resolve th
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/69649
>From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 19 Oct 2023 22:23:03 +
Subject: [PATCH 1/2] Update stdckdint.h and make it available in pre-C23
modes.
Author: Ryosuke Niwa
Date: 2023-10-19T16:10:57-07:00
New Revision: 5070c1e3b07c5b384fe0a064aa99f25b8af4b7e9
URL:
https://github.com/llvm/llvm-project/commit/5070c1e3b07c5b384fe0a064aa99f25b8af4b7e9
DIFF:
https://github.com/llvm/llvm-project/commit/5070c1e3b07c5b384fe0a064aa99f25b8af4b7e9.diff
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/69649
>From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 19 Oct 2023 22:23:03 +
Subject: [PATCH 1/2] Update stdckdint.h and make it available in pre-C23
modes.
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/69649
>From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 19 Oct 2023 22:23:03 +
Subject: [PATCH] Update stdckdint.h and make it available in pre-C23 modes.
Upda
https://github.com/david-xl approved this pull request.
https://github.com/llvm/llvm-project/pull/69656
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Zequan Wu (ZequanWu)
Changes
Refactor some code from #69493.
---
Patch is 37.13 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/69656.diff
21 Files Affected:
- (modified) clang/lib/C
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/69656
Refactor some code from #69493.
>From 89f041c62da8c0924ee45a6ed8d9ab7afb560935 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Thu, 19 Oct 2023 18:55:08 -0400
Subject: [PATCH] [Profile] Refactor profile correla
@@ -21,9 +21,6 @@
/* C23 7.20.1 Defines several macros for performing checked integer
arithmetic*/
-#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 202311L
-#define __STDC_VERSION_STDCKDINT_H__ 202311L
jrtc27 wrote:
This needs to stay, `__STDC_VERSION_
@@ -177,7 +177,7 @@ C23 Feature Support
- Clang now supports ``N3007 Type inference for object definitions``.
- Clang now supports which defines several macros for
performing
- checked integer arithmetic.
+ checked integer arithmetic. And it is also exposed in pre-C23
@@ -33,8 +33,3 @@
#error "__STDC_VERSION_STDINT_H__ not defined"
// expected-error@-1 {{"__STDC_VERSION_STDINT_H__ not defined"}}
#endif
-
-#include
-#ifndef __STDC_VERSION_STDCKDINT_H__
-#error "__STDC_VERSION_STDCKDINT_H__ not defined"
jrtc27 wrote:
And thi
@@ -44,9 +46,25 @@ bool hasPublicRefAndDeref(const CXXRecordDecl *R) {
namespace clang {
-std::optional
-isRefCountable(const CXXBaseSpecifier* Base)
-{
+std::optional
+hasPublicRefInBase(const CXXBaseSpecifier *Base) {
+ assert(Base);
+
+ const Type *T = Base->getType().ge
@@ -70,29 +88,45 @@ std::optional isRefCountable(const CXXRecordDecl* R)
if (!R)
return std::nullopt;
- if (hasPublicRefAndDeref(R))
+ bool hasRef = hasPublicRefMethod(R);
+ bool hasDeref = hasPublicDerefMethod(R);
+ if (hasRef && hasDeref)
return true;
CXX
@@ -18,24 +18,26 @@ using namespace clang;
namespace {
-bool hasPublicRefAndDeref(const CXXRecordDecl *R) {
+bool hasPublicRefMethod(const CXXRecordDecl *R) {
assert(R);
assert(R->hasDefinition());
- bool hasRef = false;
- bool hasDeref = false;
for (const CXXMet
https://github.com/haoNoQ commented:
@rniwa I had a look and I think everything looks mostly good! I found one
possible bug and made a couple comments about how I'm frustrated about code
duplication.
https://github.com/llvm/llvm-project/pull/68170
__
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/68170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: Ian Anderson (ian-twilightcoder)
Changes
When an include from a textual header is resolved, the textual header's
submodule is used as the requesting module. The submodule's uses are resolved,
but that doesn't work because only top
ian-twilightcoder wrote:
Somewhat indirectly caused by https://reviews.llvm.org/D132779
https://github.com/llvm/llvm-project/pull/69651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ian-twilightcoder created
https://github.com/llvm/llvm-project/pull/69651
When an include from a textual header is resolved, the textual header's
submodule is used as the requesting module. The submodule's uses are resolved,
but that doesn't work because only top level modul
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: None (ZijunZhaoCCK)
Changes
Update some tests and docs.
---
Full diff: https://github.com/llvm/llvm-project/pull/69649.diff
6 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+1-1)
- (modified) clang/lib/Headers/stdckdin
https://github.com/ZijunZhaoCCK ready_for_review
https://github.com/llvm/llvm-project/pull/69649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 424 matches
Mail list logo
