[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge planned changes to this revision. nridge added a comment. The updated patch additionally implements the "simple lookup optimization" discussed in the review. With this version, memory usage on the test workload is: background_index 574MB (index 387MB, slabs 187MB). This is an increase o

[PATCH] D93829: [clangd] Support outgoing calls in call hierarchy

nridge updated this revision to Diff 557829. nridge added a comment. Implement the "simple lookup optimization" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93829/new/ https://reviews.llvm.org/D93829 Files: clang-tools-extra/clangd/ClangdLSPSer

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a63dc79d113915048c932eca7732838206898e9a d490fc90f49d83d7b5ec26086c59a3f512b552ba --

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

brad0 wrote: Fix a typo in the commit message. https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused architecture related bits for *BSD's (PR #69809)

https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/69809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Clean up unused archicture related bits for *BSD's (PR #69809)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/69809 >From d490fc90f49d83d7b5ec26086c59a3f512b552ba Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 5 Oct 2023 18:41:03 -0400 Subject: [PATCH] [Driver] Clean up unused architecture related bits for *BSD's - FreeBSD

[clang] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

goldsteinn wrote: See most recent comments about missing tests. That being said code looks functionally correct to me. Still not 100% sure this is a desirable change. Will defer to @nikic about that. https://github.com/llvm/llvm-project/pull/68502 ___

[clang-tools-extra] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

goldsteinn wrote: See most recent comments about missing tests. That being said code looks functionally correct to me. Still not 100% sure this is a desirable change. Will defer to @nikic about that. https://github.com/llvm/llvm-project/pull/68502 ___

[clang] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

@@ -2840,6 +2841,60 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { return nullptr; FShiftArgs = {ShVal0, ShVal1, ShAmt}; + } else if (isa(Or0) || isa(Or1)) { +// If there are two 'or' instructions concat variables in opposite o

[clang-tools-extra] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

@@ -2840,6 +2841,60 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { return nullptr; FShiftArgs = {ShVal0, ShVal1, ShAmt}; + } else if (isa(Or0) || isa(Or1)) { +// If there are two 'or' instructions concat variables in opposite o

[clang] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

@@ -2840,6 +2841,60 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { return nullptr; FShiftArgs = {ShVal0, ShVal1, ShAmt}; + } else if (isa(Or0) || isa(Or1)) { +// If there are two 'or' instructions concat variables in opposite o

[clang-tools-extra] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

@@ -2840,6 +2841,60 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { return nullptr; FShiftArgs = {ShVal0, ShVal1, ShAmt}; + } else if (isa(Or0) || isa(Or1)) { +// If there are two 'or' instructions concat variables in opposite o

[PATCH] D156370: [clang-format] Fix bug with parsing of function/variable names.

owenpan added a comment. In D156370#4540257 , @HazardyKnusperkeks wrote: > Yes that stuff. Tests are in: > https://github.com/llvm/llvm-project/blob/main/clang/unittests/Format/TokenAnnotatorTest.cpp > If there is none that matches, just create a new on

[clang] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

@@ -2840,6 +2841,46 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { return nullptr; FShiftArgs = {ShVal0, ShVal1, ShAmt}; + } else if (isa(Or0) || isa(Or1)) { +// If there are two 'or' instructions concat variables in opposite o

[clang-tools-extra] [InstCombine] Convert or concat to fshl if opposite or concat exists (PR #68502)

@@ -2840,6 +2841,46 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC) { return nullptr; FShiftArgs = {ShVal0, ShVal1, ShAmt}; + } else if (isa(Or0) || isa(Or1)) { +// If there are two 'or' instructions concat variables in opposite o

[clang] a63dc79 - [Clang][OHOS] Keep ARM ABI selection logic in sync between Clang and LLVM (#68656)

Author: Brad Smith Date: 2023-10-22T08:48:41+03:00 New Revision: a63dc79d113915048c932eca7732838206898e9a URL: https://github.com/llvm/llvm-project/commit/a63dc79d113915048c932eca7732838206898e9a DIFF: https://github.com/llvm/llvm-project/commit/a63dc79d113915048c932eca7732838206898e9a.diff LO

[clang] [Clang][OHOS] Keep ARM ABI selection logic in sync between Clang and LLVM (PR #68656)

https://github.com/kpdev closed https://github.com/llvm/llvm-project/pull/68656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OHOS] Keep ARM ABI selection logic in sync between Clang and LLVM (PR #68656)

kpdev wrote: @brad0 Thank you for the patch, and sorry for late reply - there were wrong settings with notifications, won't happen again https://github.com/llvm/llvm-project/pull/68656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [clang-format] Don't align comments over scopes (PR #68743)

@@ -1118,16 +1121,48 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [Driver][Solaris][NFC] A little bit of clean up (PR #69867)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0b7ae41b23fc05c2ac3afc8566b8a923d7f76c45 e2c5b620b7d527dc0ba886122a0a510c058dcd17 --

[clang] [clang][Interp] Fix scalar inits of void type (PR #69868)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/69868 None >From 537c917cab1fe8bd8dc7dfd849bff9cd5be5efc2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 22 Oct 2023 06:56:46 +0200 Subject: [PATCH] [clang][Interp] Fix scalar inits of void t

[clang] [Driver][Solaris][NFC] A little bit of clean up (PR #69867)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/69867 None >From e2c5b620b7d527dc0ba886122a0a510c058dcd17 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sun, 22 Oct 2023 00:55:07 -0400 Subject: [PATCH] [Driver][Solaris][NFC] A little bit of clean up --- clang/lib/D

[clang] [clang][Interp] Implement builtin_expect (PR #69713)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69713 >From 1d60343ec3acb89764ab56a7035e1d7355e741ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 20 Oct 2023 14:16:22 +0200 Subject: [PATC

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

s1Sharp wrote: I have no way to link the issues related to the PR issue. I don't know why, but add a link to issue to this comment https://github.com/llvm/llvm-project/issues/44363 . So, I want to start a little discussion about the solution. I'll start with the problem - when using the BreakB

[clang] [mlir][DeadCodeAnalysis] Don't Require `RegionBranchTerminatorOpInterface` in `visitRegionTerminator()` (PR #69043)

https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/69043 >From 8f8b644792d5e26f76d98bd8ba45440443f9a260 Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Fri, 13 Oct 2023 18:16:45 -0700 Subject: [PATCH 1/4] Initial commit --- .../mlir/Analysis/DataFlow/DeadC

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

@@ -140,11 +140,12 @@ void g28(void) { typedef short v12i16 __attribute((vector_size(24))); typedef long double v2f80 __attribute((vector_size(24))); // CHECK: @g28.a = internal global <1 x i64> - // CHECK: @g28.b = internal global <12 x i16> - // CHECK: @g28.c = inte

[clang] [clang-format] unexpected break after binOp '<<' (PR #69859)

https://github.com/s1Sharp created https://github.com/llvm/llvm-project/pull/69859 the problem occurred while checking for the correctness of the break after binary operators. The output statement 'tok::lessless' is then break line every possible time, which is not expected with the BreakBefor

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

robozati wrote: Rewrote the test and now it passes. Sorry for pinging you @HighCommander4, but I don't know who to ping and you participated in that issue. https://github.com/llvm/llvm-project/pull/69849 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

https://github.com/robozati ready_for_review https://github.com/llvm/llvm-project/pull/69849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

https://github.com/robozati updated https://github.com/llvm/llvm-project/pull/69849 >From 239302d66dea74333e27288acbceffdf3f2d3b6b Mon Sep 17 00:00:00 2001 From: Gabriel Pezati Date: Sat, 21 Oct 2023 19:28:57 -0300 Subject: [PATCH] Fix UB on unclosed parentheses, brackets or braces in Tokens -

[PATCH] D156565: Diagnose use of VLAs in C++ by default

nathanchance added a comment. Is it expected that this introduces a warning for C code, as the commit message and tests appear to only affect C++? A trivial example from the Linux kernel: https://elixir.bootlin.com/linux/v6.5.8/source/tools/lib/bpf/btf_dump.c#L1678 #include #include #in

[clang] [clang-format] Add a new style for the clang-format source code (PR #69814)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/69814 >From 78a2661ba7a18ecf8b09be71f6959fbc9fcf70fe Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 20 Oct 2023 23:01:38 -0700 Subject: [PATCH 1/2] [clang-format] Add a new style for the clang-format source code -

[clang] [LLVM] Add IRNormalizer Pass (PR #68176)

https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/20] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/68620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

@@ -816,6 +821,14 @@ will be ignored}]>; def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">; +def embed_dir : JoinedOrSeparate<["-"], "embed-dir">,

[clang-tools-extra] [LLVM] Add IRNormalizer Pass (PR #68176)

https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/20] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] [LLVM] Add IRNormalizer Pass (PR #68176)

https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/68176 >From f792a030ac1761a96176332fea906cd2d1826c7b Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Sat, 12 Aug 2023 10:58:45 -0700 Subject: [PATCH 01/20] Add IRCanonicalizer.cpp --- llvm/lib/Transforms/U

[clang] [clang-format] Add a new style for the clang-format source code (PR #69814)

owenca wrote: Yep. Each file will contain only `BasedOnStyle: clang-format`. https://github.com/llvm/llvm-project/pull/69814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

https://github.com/Overhatted created https://github.com/llvm/llvm-project/pull/69856 I haven't finished all of the tests and formatting so it's a bit in a POC stage but I would like to know if this change would be accepted. The change is to support relative paths in the "directory" field in c

[clang] [clang-format] Don't align comments over scopes (PR #68743)

https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/68743 From 8df1b77e223cd5ab5d759ae2d57f4c79306f9149 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Tue, 10 Oct 2023 22:50:43 +0200 Subject: [PATCH] [clang-format] Don't align com

[clang] [clang-format] Add a new style for the clang-format source code (PR #69814)

HazardyKnusperkeks wrote: > > What is your goal with that style? > > It was actually your [idea](https://reviews.llvm.org/D153208#4431239). 😉 I know, but I thought the thought was dropped. :) So the intent is to use it on our `.clang-format` files? https://github.com/llvm/llvm-project/pull/69

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

https://github.com/sr-tream edited https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

https://github.com/sr-tream edited https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

sr-tream wrote: In force-push changed alignment render, to render it in same line with size  https://github.com/llvm/llvm-project/pull/67213 ___ cfe-co

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/67213 >From b9b5bc27c7ab8c8faca7f8bf66aead59b817b6b7 Mon Sep 17 00:00:00 2001 From: SR_team Date: Sat, 21 Oct 2023 21:24:26 +0300 Subject: [PATCH] [clangd] Show alignment for records and fields decls --- clang-tools

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

https://github.com/sr-tream updated https://github.com/llvm/llvm-project/pull/67213 >From bf024310a4fe796a497880c0e2bd6a27c86ce7f5 Mon Sep 17 00:00:00 2001 From: SR_team Date: Sat, 21 Oct 2023 21:24:26 +0300 Subject: [PATCH] [clangd] Show alignment for records and fields decls --- clang-tools

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

@@ -1488,6 +1491,8 @@ markup::Document HoverInfo::present() const { llvm::formatv(" (+{0} padding)", formatSize(*Padding)).str()); } } + if (Align) +Output.addParagraph().appendText("Align: " + formatSize(*Align)); sr-tream wrote: Yeah, it

[clang] [clang][Interp] Implement builtin_expect (PR #69713)

https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/69713 >From 1d60343ec3acb89764ab56a7035e1d7355e741ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 20 Oct 2023 14:16:22 +0200 Subject: [PATCH] [clang][Interp] Implement builtin_expect --- c

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder updated this revision to Diff 557826. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157252/new/ https://reviews.llvm.org/D157252 Files: clang/lib/AST/ExprConstant.cpp clang/test/Sema/builtin-memcpy.c Index: clang/test/Sema/builtin-memcpy.c ==

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder added inline comments. Comment at: clang/test/Sema/builtin-memcpy.c:4-8 +int b() { + struct { } a[10]; + __builtin_memcpy(&a[2], a, 2); // expected-warning {{buffer has size 0, but size argument is 2}} + return 0; +} aaron.ballman wrote: > The on

[clang] [NFC] use `StringSet::insert(iter, iter)` instead for loop to insert (PR #69851)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/69851 None >From 37f6822035845f120d2fb995a607561621c3892e Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sun, 22 Oct 2023 00:27:04 +0800 Subject: [PATCH] [NFC] use `StringSet::insert(iter, iter)` instead for lo

[clang] [clang-format] Add a new style for the clang-format source code (PR #69814)

owenca wrote: I was wondering myself. Will undo it before merging. https://github.com/llvm/llvm-project/pull/69814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang]improve diagnosing redefined defaulted constructor with different exception specs (PR #69688)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/69688 >From 2629b346123f9838a4fc3d8b6fb6a98508773965 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Fri, 20 Oct 2023 15:45:42 +0800 Subject: [PATCH 1/2] [clang]improve diagnosing redefined defaulted constructor

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

https://github.com/robozati converted_to_draft https://github.com/llvm/llvm-project/pull/69849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

robozati wrote: Tests are failing because of the `findExpanded` function, but it didn’t result in UB. Will fix the test later. https://github.com/llvm/llvm-project/pull/69849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

https://github.com/robozati updated https://github.com/llvm/llvm-project/pull/69849 >From e57657cf296e1e93fa17f021bb8ce591071b2176 Mon Sep 17 00:00:00 2001 From: robozati <139823421+roboz...@users.noreply.github.com> Date: Sat, 21 Oct 2023 12:04:14 -0300 Subject: [PATCH 1/2] Fix UB on unclosed p

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

@@ -1488,6 +1491,8 @@ markup::Document HoverInfo::present() const { llvm::formatv(" (+{0} padding)", formatSize(*Padding)).str()); } } + if (Align) +Output.addParagraph().appendText("Align: " + formatSize(*Align)); Endilll wrote: That woul

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

@@ -1488,6 +1491,8 @@ markup::Document HoverInfo::present() const { llvm::formatv(" (+{0} padding)", formatSize(*Padding)).str()); } } + if (Align) +Output.addParagraph().appendText("Align: " + formatSize(*Align)); sr-tream wrote: > My pre

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

Endilll wrote: On the topic of ABI, Itanium and Microsoft type layouts are not compatible, even for standard-layout (POD) types. For [example](https://godbolt.org/z/zxfvMa9nE), bit-fields are [allowed](http://eel.is/c++draft/class.prop#3) in standard-layout types, but only Microsoft ABI manda

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

@@ -1488,6 +1491,8 @@ markup::Document HoverInfo::present() const { llvm::formatv(" (+{0} padding)", formatSize(*Padding)).str()); } } + if (Align) +Output.addParagraph().appendText("Align: " + formatSize(*Align)); Endilll wrote: My prefer

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bounds checking on unclosed parentheses, brackets or braces in Expanded Tokens (PR #69849)

https://github.com/robozati created https://github.com/llvm/llvm-project/pull/69849 When getting the AST from clangd, if there is an unclosed token, a segfault or an UB can happen when accessing `File.SpelledTokens` because the supposed closing token is not present, so its index is greater tha

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

https://github.com/Endilll approved this pull request. LGTM, but you should wait for other reviewers before merging. https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] Pass QualifiedRenameRule strings by reference to reduce copies (PR #69848)

https://github.com/mfdeakin created https://github.com/llvm/llvm-project/pull/69848 Fixes #34652 >From 0052d66e15451af47ebf8f2c4b060ea21a75f4a4 Mon Sep 17 00:00:00 2001 From: Michael Deakin Date: Thu, 19 Oct 2023 19:28:46 -0700 Subject: [PATCH] Pass QualifiedRenameRule strings by reference to

[clang] [analyzer][NFC] Substitute operator() with lambda in StreamChecker (PR #69844)

https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/69844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f990650 - [analyzer][NFC] Substitute operator() with lambda in StreamChecker

Author: Ben Shi Date: 2023-10-21T16:29:14+02:00 New Revision: f9906508bc4f05d3950e2219b4c56f6c078a61ef URL: https://github.com/llvm/llvm-project/commit/f9906508bc4f05d3950e2219b4c56f6c078a61ef DIFF: https://github.com/llvm/llvm-project/commit/f9906508bc4f05d3950e2219b4c56f6c078a61ef.diff LOG:

[clang] [analyzer][NFC] Substitute operator() with lambda in StreamChecker (PR #69844)

https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/69844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Substitute operator() with lambda in StreamChecker (PR #69844)

@@ -407,23 +407,15 @@ class StreamChecker : public Checker std::string { + if (BR.isInteresting(StreamSym) && + &BR.getBugType() == &(this->BT_ResourceLeak)) benshi001 wrote: Thanks. I fixed it. https://github.com/llvm/llvm-project/pull/698

[clang] [analyzer][NFC] Substitute operator() with lambda in StreamChecker (PR #69844)

https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/69844 >From 615c6f8ecc4a97eeedc69c04b9a805ee56822c30 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Sat, 21 Oct 2023 21:33:50 +0800 Subject: [PATCH] [analyzer][NFC] Substitute operator() with lambda in StreamChecker

[clang] [analyzer][NFC] Substitute operator() with lambda in StreamChecker (PR #69844)

https://github.com/steakhal approved this pull request. Thanks. https://github.com/llvm/llvm-project/pull/69844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Substitute operator() with lambda in StreamChecker (PR #69844)

@@ -407,23 +407,15 @@ class StreamChecker : public Checker std::string { + if (BR.isInteresting(StreamSym) && + &BR.getBugType() == &(this->BT_ResourceLeak)) steakhal wrote: ```suggestion &BR.getBugType() == &BT_ResourceLeak) `

[clang] [analyzer][NFC] Substitute operator() with lambda in StreamChecker (PR #69844)

https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/69844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Substitute operator() with lambda in StreamChecker (PR #69844)

https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/69844 None >From 0e8edd8448b0bacfaf35f415a5760d5d1a3aabb7 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Sat, 21 Oct 2023 21:33:50 +0800 Subject: [PATCH] [analyzer][NFC] Substitute operator() with lambda in StreamChe

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/69224 >From 89e486690f1a28900152d4eef023be6fdfcf296a Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 16 Oct 2023 22:50:08 +0800 Subject: [PATCH] [clang][Sema] Avoid non-empty unexpanded pack assertion for Funct

[clang] 7d7e4d2 - [Windows] Add git-clang-format wrapper bat file (#69228)

Author: Chris B Date: 2023-10-21T08:14:29-05:00 New Revision: 7d7e4d20b077c1f64b0db88ab844ccb9214bd38c URL: https://github.com/llvm/llvm-project/commit/7d7e4d20b077c1f64b0db88ab844ccb9214bd38c DIFF: https://github.com/llvm/llvm-project/commit/7d7e4d20b077c1f64b0db88ab844ccb9214bd38c.diff LOG:

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/69228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/69224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/69224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

robozati wrote: @sam-mccall @kadircet Hello! I mentioned this PR in discord, but no one assigned themselves to review so I am pinging you. https://github.com/llvm/llvm-project/pull/69775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [clang-format] Add a new style for the clang-format source code (PR #69814)

https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/69814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add a new style for the clang-format source code (PR #69814)

rymiel wrote: > I don't want to "advertise" this new style in the documentation but am > willing to be overruled by the majority. But you added it to the help text? (I'm fine with this being undocumented) https://github.com/llvm/llvm-project/pull/69814

[clang] [clang][Sema] Don't assert non-empty unexpanded packs following Colle… (PR #69224)

zyn0217 wrote: Sorry for my late update - I've had a busy week ;) > I don't think so as they don't have parameter or capture list +1. and it looks like we don't allow expanding a pack outside a statement expression, which more or less prevents the appearance of `FunctionParmPackExpr`. > so i

[clang] [Clang] Add __datasizeof (PR #67805)

@@ -0,0 +1,34 @@ +// RUN: %clang_cc1 -fsyntax-only -triple x86_64-linux-gnu -verify %s philnik777 wrote: It looks like the VLA test can't be constant evaluated. Should I add a CodeGen test for that? https://github.com/llvm/llvm-project/pull/67805 __

[PATCH] D157896: Clang: Define macro _MIPS_SPFPSET

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2f02e3bd6a5: Clang: Define macro _MIPS_SPFPSET (authored by brad). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c2f02e3 - Clang: Define macro _MIPS_SPFPSET

Author: Brad Smith Date: 2023-10-21T07:08:54-04:00 New Revision: c2f02e3bd6a5b287a221ae9038e6727abc3e6652 URL: https://github.com/llvm/llvm-project/commit/c2f02e3bd6a5b287a221ae9038e6727abc3e6652 DIFF: https://github.com/llvm/llvm-project/commit/c2f02e3bd6a5b287a221ae9038e6727abc3e6652.diff LO

[clang-tools-extra] 9322216 - [clang-tidy][DOC] Fix 'table cell spanning'

Author: Piotr Zegar Date: 2023-10-21T10:30:06Z New Revision: 9322216021f1d8241b87a81c12321b05aa6d1cfb URL: https://github.com/llvm/llvm-project/commit/9322216021f1d8241b87a81c12321b05aa6d1cfb DIFF: https://github.com/llvm/llvm-project/commit/9322216021f1d8241b87a81c12321b05aa6d1cfb.diff LOG: [

[clang-tools-extra] Clang tools docs ci test (PR #69826)

https://github.com/boomanaiden154 closed https://github.com/llvm/llvm-project/pull/69826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Clang tools docs ci test (PR #69826)

https://github.com/boomanaiden154 created https://github.com/llvm/llvm-project/pull/69826 None >From f8bd3e5f45e05f68522f41bb0b6ea733095eb7a4 Mon Sep 17 00:00:00 2001 From: Aiden Grossman Date: Sat, 21 Oct 2023 02:33:56 -0700 Subject: [PATCH 1/2] [Github] Add clang-tools-extra docs to CI This

[clang-tools-extra] [mlir][tosa] Check for unranked tensors during validation (PR #68509)

gptsarthak wrote: This patch is ready to be merged. https://github.com/llvm/llvm-project/pull/68509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][tosa] Check for unranked tensors during validation (PR #68509)

gptsarthak wrote: This patch is ready to be merged. https://github.com/llvm/llvm-project/pull/68509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][tosa] Check for unranked tensors during validation (PR #68509)

https://github.com/gptsarthak updated https://github.com/llvm/llvm-project/pull/68509 >From cf45b9d2dc8c120b0269992ff6740abbe72f93f3 Mon Sep 17 00:00:00 2001 From: gptsarthak Date: Wed, 11 Oct 2023 13:58:59 +0530 Subject: [PATCH] [mlir][tosa] Check for unranked tensors during validation levelC

[clang-tools-extra] [mlir][tosa] Check for unranked tensors during validation (PR #68509)

https://github.com/gptsarthak updated https://github.com/llvm/llvm-project/pull/68509 >From cf45b9d2dc8c120b0269992ff6740abbe72f93f3 Mon Sep 17 00:00:00 2001 From: gptsarthak Date: Wed, 11 Oct 2023 13:58:59 +0530 Subject: [PATCH] [mlir][tosa] Check for unranked tensors during validation levelC

[clang] [clang][dataflow] Remove `declToLocConsistent()` assertion. (PR #69819)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 386f3903910aa1897c424ced8e1af7993a6df5ce 9508b6fe43730c4ba6568ae2e86cf1807e911727 --

[clang] 09b02f5 - [Driver][NetBSD][NFC] Some cleaning up

Author: Brad Smith Date: 2023-10-21T04:45:41-04:00 New Revision: 09b02f5d569adbbb29186479953cd55bd6b29402 URL: https://github.com/llvm/llvm-project/commit/09b02f5d569adbbb29186479953cd55bd6b29402 DIFF: https://github.com/llvm/llvm-project/commit/09b02f5d569adbbb29186479953cd55bd6b29402.diff LO

[clang] [clang][dataflow] Remove `declToLocConsistent()` assertion. (PR #69819)

llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes As described [here](https://discourse.llvm.org/t/70086/6), there are legitimate non-bug scenarios where two `DeclToLoc` maps to be joined contain different storage locations for the same declaration. Thi

[clang] [clang][dataflow] Remove `declToLocConsistent()` assertion. (PR #69819)

https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/69819 As described [here](https://discourse.llvm.org/t/70086/6), there are legitimate non-bug scenarios where two `DeclToLoc` maps to be joined contain different storage locations for the same declaration. This pat

  1   2   >