[clang] Add Obj-C bridging-related attributes to C-Index API (PR #69899)

2023-10-22 Thread Jevin Sweval via cfe-commits
https://github.com/jevinskie created https://github.com/llvm/llvm-project/pull/69899 Yowza, I haven't tried to upstream anything to LLVM in a long time. It was so long ago I just had my coworker submit it for me with their SVN access... Anyways, this adds `ObjCBridgeAttr`, `ObjCBridgeMutableAt

[clang] [clang-format] Don't alter SpacesRequiredBefore of finalized tokens (PR #69897)

2023-10-22 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/69897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support target names with dots in more utilities (PR #65812)

2023-10-22 Thread James Henderson via cfe-commits
jh7370 wrote: I can merge it for you, but first I just want to confirm that all 4 commits in this PR are intended to be for the PR? If not, you'll need to rebase and force push. There's no need for you to manually squash the fixups (although you might as well if you do end up rebasing). When

[clang] [clang-format] Don't alter SpacesRequiredBefore of finalized tokens (PR #69897)

2023-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #69237. --- Full diff: https://github.com/llvm/llvm-project/pull/69897.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+1-1) - (modified) clang/unittests/Format/FormatTest

[clang] [clang-format] Don't alter SpacesRequiredBefore of finalized tokens (PR #69897)

2023-10-22 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/69897 Fixes #69237. >From 69e39f7e19e7f2538df0b8c6ba89d5efa493dd7b Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 22 Oct 2023 23:15:08 -0700 Subject: [PATCH] [clang-format] Don't alter SpacesRequiredBefore of final

[clang] [clang][dataflow] Remove `DataflowAnalysisContext::flowConditionIsTautology()`. (PR #69601)

2023-10-22 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/69601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3eed23d - [clang][dataflow] Remove `DataflowAnalysisContext::flowConditionIsTautology()`. (#69601)

2023-10-22 Thread via cfe-commits
Author: martinboehme Date: 2023-10-23T08:18:12+02:00 New Revision: 3eed23d31caab9f19a8fa142aa26ee970a2c60ea URL: https://github.com/llvm/llvm-project/commit/3eed23d31caab9f19a8fa142aa26ee970a2c60ea DIFF: https://github.com/llvm/llvm-project/commit/3eed23d31caab9f19a8fa142aa26ee970a2c60ea.diff

[clang] [clang-format] Add a new style for the clang-format source code (PR #69814)

2023-10-22 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/69814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0374bbb - [clang-format] Add a new style for the clang-format source code (#69814)

2023-10-22 Thread via cfe-commits
Author: Owen Pan Date: 2023-10-22T23:01:27-07:00 New Revision: 0374bbba4c455e5f862a32581cc8d37690fb3b60 URL: https://github.com/llvm/llvm-project/commit/0374bbba4c455e5f862a32581cc8d37690fb3b60 DIFF: https://github.com/llvm/llvm-project/commit/0374bbba4c455e5f862a32581cc8d37690fb3b60.diff LOG:

[clang] -fstack-usage: fix filename for functions in an included file (PR #69896)

2023-10-22 Thread via cfe-commits
https://github.com/androm3da approved this pull request. https://github.com/llvm/llvm-project/pull/69896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Introduce initial support for C++20 Modules (PR #66462)

2023-10-22 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: @sam-mccall gentle ping~ https://github.com/llvm/llvm-project/pull/66462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100509: Support GCC's -fstack-usage flag

2023-10-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Herald added a subscriber: ormris. Herald added a project: All. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1208 + + *StackUsageStream << MF.getFunction().getParent()->getName(); + if (const DISubprogram *DSP = MF.getFunction().getSubpr

[clang] -fstack-usage: fix filename for functions in an included file (PR #69896)

2023-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes Fix #69889 --- Full diff: https://github.com/llvm/llvm-project/pull/69896.diff 2 Files Affected: - (modified) clang/test/CodeGen/stack-usage.c (+8-5) - (modified) llvm/lib/CodeGen/AsmPrinter/AsmPrinter.c

[clang] -fstack-usage: fix filename for functions in an included file (PR #69896)

2023-10-22 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/69896 Fix #69889 >From 343f5abcd269701f526b64508237fb992ad7828d Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sun, 22 Oct 2023 22:04:31 -0700 Subject: [PATCH] -fstack-usage: fix filename for functions in an inclu

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-22 Thread Nathan Ridge via cfe-commits
@@ -859,7 +872,9 @@ class InlayHintVisitor : public RecursiveASTVisitor { else ForwardedParams = {Params.begin(), Params.end()}; -NameVec ParameterNames = chooseParameterNames(ForwardedParams); +auto ForwardedParamsRef = HighCommander4 wrote

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/68177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Adapt Inlay Hint support for Deducing This (PR #68177)

2023-10-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! I have one suggestion for your consideration, otherwise this looks good to me. https://github.com/llvm/llvm-project/pull/68177 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang-tools-extra] `clangd`: support `-stdlib=` flags from `compile_commands.json`. (PR #69283)

2023-10-22 Thread Nathan Ridge via cfe-commits
@@ -203,6 +214,7 @@ template <> struct DenseMapInfo { Val.Driver, Val.StandardIncludes, Val.StandardCXXIncludes, +Val.Stdlib, HighCommander4 wrote: nit: it looks like the previous patch which introduced `Target` forgot to add i

[clang] clangd: Show argument names for function pointer struct fields (PR #69011)

2023-10-22 Thread Nathan Ridge via cfe-commits
@@ -6133,7 +6133,17 @@ ProduceSignatureHelp(Sema &SemaRef, MutableArrayRef Candidates, // so that we can recover argument names from it. static FunctionProtoTypeLoc GetPrototypeLoc(Expr *Fn) { TypeLoc Target; - if (const auto *T = Fn->getType().getTypePtr()->getAs()) { + +

[clang-tools-extra] clangd: Show argument names for function pointer struct fields (PR #69011)

2023-10-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/69011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clangd: Show argument names for function pointer struct fields (PR #69011)

2023-10-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Thanks for the patch! https://github.com/llvm/llvm-project/pull/69011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] a5dca53 - Use llvm::count (NFC)

2023-10-22 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2023-10-22T21:18:23-07:00 New Revision: a5dca533bdc32258d3f3334cdec44f0ac9028251 URL: https://github.com/llvm/llvm-project/commit/a5dca533bdc32258d3f3334cdec44f0ac9028251 DIFF: https://github.com/llvm/llvm-project/commit/a5dca533bdc32258d3f3334cdec44f0ac9028251.diff L

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-22 Thread Nathan Ridge via cfe-commits
@@ -76,7 +82,7 @@ bool RawStringLiteral::prepare(const Selection &Inputs) { if (!N) return false; Str = dyn_cast_or_null(N->ASTNode.get()); - return Str && + return Str && isFeatureAvailable(Inputs) && HighCommander4 wrote: I would move this language

[clang] [Clang][RISCV] Support CSRs in clobbered registers of inline assembly (PR #67646)

2023-10-22 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp closed https://github.com/llvm/llvm-project/pull/67646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 05b5188 - [Clang][RISCV] Support CSRs in clobbered registers of inline assembly (#67646)

2023-10-22 Thread via cfe-commits
Author: Wang Pengcheng Date: 2023-10-23T11:15:20+08:00 New Revision: 05b5188c1257785c4138834b81ec86047517376d URL: https://github.com/llvm/llvm-project/commit/05b5188c1257785c4138834b81ec86047517376d DIFF: https://github.com/llvm/llvm-project/commit/05b5188c1257785c4138834b81ec86047517376d.diff

[clang] 366ffba - [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 (#69431)

2023-10-22 Thread via cfe-commits
Author: Chuanqi Xu Date: 2023-10-23T10:06:16+08:00 New Revision: 366ffbaf627d0b6867299458cf57f8464259e550 URL: https://github.com/llvm/llvm-project/commit/366ffbaf627d0b6867299458cf57f8464259e550 DIFF: https://github.com/llvm/llvm-project/commit/366ffbaf627d0b6867299458cf57f8464259e550.diff LO

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-22 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/69431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-22 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Comments addressed. https://github.com/llvm/llvm-project/pull/69431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-22 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/69431 >From 9c0d81ef5fdae40d378170eebd848f099902dc98 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Wed, 18 Oct 2023 15:58:03 +0800 Subject: [PATCH] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsi

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-22 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Ping https://github.com/llvm/llvm-project/pull/67817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-22 Thread Lu Weining via cfe-commits
https://github.com/SixWeining requested changes to this pull request. - For the commits `[LoongArch][CodeGen][clang] Add builtin functions test cases for LASX` and `[LoongArch][CodeGen][clang] Add builtin functions test cases for LSX`, `Change-Id`s can be removed. - Please fix the test failure.

[clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-22 Thread Lu Weining via cfe-commits
SixWeining wrote: > Given you've already split your changes into several smaller commits, it's > probably better to file them as separate PRs, so each one is smaller than the > current 3+-line diff, and become more reviewable that way. I'm not sure seperate PRs are appropriate since some o

[clang-tools-extra] [MLIR][scf.parallel] Don't allow a tile size of 0 (PR #68762)

2023-10-22 Thread Matthias Springer via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: mlir-opt %s -pass-pipeline='builtin.module(func.func(scf-parallel-loop-tiling{parallel-loop-tile-sizes=0,0}))' -split-input-file -verify-diagnostics + +// XFAIL: * matthias-springer wrote: I didn't know that. Sounds good! https://githu

[clang] [MLIR][scf.parallel] Don't allow a tile size of 0 (PR #68762)

2023-10-22 Thread Justin Fargnoli via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: mlir-opt %s -pass-pipeline='builtin.module(func.func(scf-parallel-loop-tiling{parallel-loop-tile-sizes=0,0}))' -split-input-file -verify-diagnostics + +// XFAIL: * justinfargnoli wrote: It looks like it isn't possible to use `expected-e

[clang-tools-extra] [mlir][DeadCodeAnalysis] Don't Require `RegionBranchTerminatorOpInterface` in `visitRegionTerminator()` (PR #69043)

2023-10-22 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli closed https://github.com/llvm/llvm-project/pull/69043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

2023-10-22 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-22 Thread Owen Pan via cfe-commits
@@ -3191,20 +3198,150 @@ TEST_F(FormatTestComments, DontAlignNamespaceComments) { "}\n" "// Comment"; -#if 0 - // FIXME: The following comment is aligned with the namespace comment. verifyFormat("namespace A {\n" " int Foo;\n"

[clang-tools-extra] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

2023-10-22 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph approved this pull request. https://github.com/llvm/llvm-project/pull/69878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-22 Thread Owen Pan via cfe-commits
@@ -1118,16 +1121,48 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-22 Thread Owen Pan via cfe-commits
@@ -5118,10 +5118,6 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, return true; if (Left.IsUnterminatedLiteral) return true; - if (Right.is(tok::lessless) && Right.Next && Left.is(tok::string_literal) && owenca wrote: No, it sti

[clang] In compilation databases, add support for relative directories (PR #69856)

2023-10-22 Thread via cfe-commits
https://github.com/Overhatted updated https://github.com/llvm/llvm-project/pull/69856 >From 5d4642378e6f74da0b15d8524aeb1ed1fa257568 Mon Sep 17 00:00:00 2001 From: Overhatted <15021741+overhat...@users.noreply.github.com> Date: Sat, 21 Oct 2023 14:16:38 +0100 Subject: [PATCH] In compilation data

[clang] 3e86cc4 - [clang-format][NFC] Simplify the logic in a return statement

2023-10-22 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-22T13:46:32-07:00 New Revision: 3e86cc4b864f609720c12cc97ff70a20aabb956f URL: https://github.com/llvm/llvm-project/commit/3e86cc4b864f609720c12cc97ff70a20aabb956f DIFF: https://github.com/llvm/llvm-project/commit/3e86cc4b864f609720c12cc97ff70a20aabb956f.diff LOG:

[clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2023-10-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f3ff0a67be46f2380ca597d21fe551cf2bbf41fd 01c1271b9e0f9583262bf00d5853ef362764909a --

[clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2023-10-22 Thread via cfe-commits
https://github.com/Overhatted ready_for_review https://github.com/llvm/llvm-project/pull/69856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2023-10-22 Thread via cfe-commits
https://github.com/Overhatted updated https://github.com/llvm/llvm-project/pull/69856 >From 01c1271b9e0f9583262bf00d5853ef362764909a Mon Sep 17 00:00:00 2001 From: Overhatted <15021741+overhat...@users.noreply.github.com> Date: Sat, 21 Oct 2023 14:16:38 +0100 Subject: [PATCH] In compilation data

[clang-tools-extra] Fix #68492: point to the correct const location (PR #69103)

2023-10-22 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69103 >From 354a8e4034afd82e6ea854848a86b9011e26269b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Fri, 13 Oct 2023 19:27:15 +0100 Subject: [PATCH 1/4] Fix #68492: point to the correct const location --- .../read

[clang-tools-extra] Fix #41439: Update the documentation with the correct information. (PR #69377)

2023-10-22 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69377 >From 0e0a3e7ad1a0a7098e05a5164413369eaa58c55b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Tue, 17 Oct 2023 20:49:47 +0100 Subject: [PATCH] Fix #41439: Update the documentation with the correct information

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-22 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/3] Fix #35272: Don't replace typedefs in extern c scope --- ...

[clang] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (PR #69747)

2023-10-22 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/69747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (PR #69747)

2023-10-22 Thread Fangrui Song via cfe-commits
@@ -694,6 +694,16 @@ void tools::addLTOOptions(const ToolChain &ToolChain, const ArgList &Args, CmdArgs.push_back(Args.MakeArgString(Twine(PluginOptPrefix) + ParallelismOpt + Parallelism)); + // Pass down GlobalISel options. + if

[clang] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (PR #69747)

2023-10-22 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/69747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Hook up Haiku PowerPC support (PR #69134)

2023-10-22 Thread Fangrui Song via cfe-commits
MaskRay wrote: It seems that there is no usable Haiku kernel: https://www.haiku-os.org/guides/building/port_status/ Then we shouldn't add this? https://github.com/llvm/llvm-project/pull/69134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-22 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-22 Thread Piotr Zegar via cfe-commits
@@ -28,6 +28,15 @@ After: using R_t = struct { int a; }; using R_p = R_t*; +The checker ignores `typedef` within `extern "C" { ... }` blocks. PiotrZSL wrote: I think so, for example I would like to enable this for my projects. Ignoring extern "C" makes on

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-22 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/68922 >From 8aa439a97a56ef80bfc9ccc90a9f093680e455f5 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Sun, 22 Oct 2023 11:11:53 +0200 Subject: [PATCH 1/2] rebase... --- clang/docs/ReleaseNotes.rst |

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-22 Thread Utkarsh Saxena via cfe-commits
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema &S, SourceLocation OpLoc, return true; } // Otherwise the search scope is the namespace scope of which F is a member. - LookupResult NonMembers(S, NotEqOp, OpLoc, - Sema::LookupNameK

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-22 Thread via cfe-commits
@@ -285,6 +285,10 @@ Changes in existing checks ` check to fix function pointer and forward declared ``typedef`` correctly. +- Improved :doc:`modernize-use-using Da-Viper wrote: done https://github.com/llvm/llvm-project/pull/69102 ___

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-22 Thread via cfe-commits
@@ -28,6 +28,15 @@ After: using R_t = struct { int a; }; using R_p = R_t*; +The checker ignores `typedef` within `extern "C" { ... }` blocks. + +.. code-block:: c++ + + extern "C" { + Da-Viper wrote: done https://github.com/llvm/llvm-project/pull/69102

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-22 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69102 >From 21156656433fb8d2dc5a805d97cbd20fa916fff9 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 15 Oct 2023 11:39:42 +0100 Subject: [PATCH 1/3] Fix #35272: Don't replace typedefs in extern c scope --- ...

[clang-tools-extra] Fix #35272: Don't replace typedefs in extern c scope (PR #69102)

2023-10-22 Thread via cfe-commits
@@ -28,6 +28,15 @@ After: using R_t = struct { int a; }; using R_p = R_t*; +The checker ignores `typedef` within `extern "C" { ... }` blocks. Da-Viper wrote: Would it be preferred to make this an option ? https://github.com/llvm/llvm-project/pull/69102

[clang-tools-extra] Fix #68492: point to the correct const location (PR #69103)

2023-10-22 Thread via cfe-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/69103 >From 354a8e4034afd82e6ea854848a86b9011e26269b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Fri, 13 Oct 2023 19:27:15 +0100 Subject: [PATCH 1/4] Fix #68492: point to the correct const location --- .../read

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-22 Thread Jerin Philip via cfe-commits
jerinphilip wrote: I have rebased the PR with main (which appears to fix the formatting workflow). For the time being, I have left the C23 test using `alignas` in with the active error message and a `FIXME`. I've altered the state of this PR to be close to [D141177](https://reviews.llvm.org/D

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-22 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 919be6b69cf12e5d9dd9f74a4570ea0a87c9a265 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH] [clang] Improve _Alignas on declaration diagnostic Adds `isAl

[clang-tools-extra] In compilation databases, add support for relative directories (PR #69856)

2023-10-22 Thread via cfe-commits
https://github.com/Overhatted converted_to_draft https://github.com/llvm/llvm-project/pull/69856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-22 Thread Björn Schäpers via cfe-commits
@@ -1118,16 +1121,48 @@ void WhitespaceManager::alignTrailingComments() { } } -// We don't want to align namespace end comments. -const bool DontAlignThisComment = -I > 0 && C.NewlinesBefore == 0 && -Changes[I - 1].Tok->is(TT_NamespaceRBrace);

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-22 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/68743 From 2efda4c7d5e99b3506a874d514adcb16fe46adce Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Tue, 10 Oct 2023 22:50:43 +0200 Subject: [PATCH] [clang-format] Don't align com

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-22 Thread Björn Schäpers via cfe-commits
@@ -5118,10 +5118,6 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, return true; if (Left.IsUnterminatedLiteral) return true; - if (Right.is(tok::lessless) && Right.Next && Left.is(tok::string_literal) && HazardyKnusperkeks wrote:

[clang] Added removal of file extension when guessing the toolchain (PR #69887)

2023-10-22 Thread via cfe-commits
https://github.com/Overhatted created https://github.com/llvm/llvm-project/pull/69887 I'm using Buck2 to create the compile_commands.json and since it uses a cl.bat wrapper around cl.exe, that's what shows up in the compile_commands.json. Of course Buck2 could be changed to create a compile_co

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-10-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/66481 From 1948d226de16bda2899ca562276370d20ceba236 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 15 Sep 2023 10:21:30 +0200 Subject: [PATCH 1/6] [analyzer] Add std::variant checker Adding a checker that check

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-10-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/66481 From 1948d226de16bda2899ca562276370d20ceba236 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 15 Sep 2023 10:21:30 +0200 Subject: [PATCH 1/5] [analyzer] Add std::variant checker Adding a checker that check

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-10-22 Thread via cfe-commits
=?utf-8?q?Gábor?= Spaits Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ce8b8b1639bc9592d2db291db4bb289b04

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-10-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/66481 From 1948d226de16bda2899ca562276370d20ceba236 Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 15 Sep 2023 10:21:30 +0200 Subject: [PATCH 1/4] [analyzer] Add std::variant checker Adding a checker that check

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-22 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 74b62efe15496e0024271fe93418f0963c8aedd0 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH] [clang] Improve _Alignas on declaration diagnostic Adds `isAl

[clang] [analyzer] Add std::variant checker (PR #66481)

2023-10-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/66481 From ce62d3e1924b497b3e7160579a87557119c9e35d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 15 Sep 2023 10:21:30 +0200 Subject: [PATCH 1/4] [analyzer] Add std::variant checker Adding a checker that check

[clang-tools-extra] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

2023-10-22 Thread via cfe-commits
goldsteinn wrote: LGTM. https://github.com/llvm/llvm-project/pull/67917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] c300884 - [clangd] Show alignment for records and fields decls (#67213)

2023-10-22 Thread via cfe-commits
Author: SR_team Date: 2023-10-22T20:37:12+04:00 New Revision: c3008842bf19e3a00db1f8adbd95d43f71b4f09f URL: https://github.com/llvm/llvm-project/commit/c3008842bf19e3a00db1f8adbd95d43f71b4f09f DIFF: https://github.com/llvm/llvm-project/commit/c3008842bf19e3a00db1f8adbd95d43f71b4f09f.diff LOG:

[clang-tools-extra] [analyzer] Add std::variant checker (PR #66481)

2023-10-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/66481 From ce62d3e1924b497b3e7160579a87557119c9e35d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 15 Sep 2023 10:21:30 +0200 Subject: [PATCH 1/4] [analyzer] Add std::variant checker Adding a checker that check

[clang-tools-extra] [analyzer] Add std::variant checker (PR #66481)

2023-10-22 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/66481 From ce62d3e1924b497b3e7160579a87557119c9e35d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Fri, 15 Sep 2023 10:21:30 +0200 Subject: [PATCH 1/3] [analyzer] Add std::variant checker Adding a checker that check

[clang-tools-extra] [analyzer] Add std::variant checker (PR #66481)

2023-10-22 Thread Gábor Spaits via cfe-commits
@@ -0,0 +1,104 @@ +//===- TaggedUnionModeling.h -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-22 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-22 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From cce937359c918246cdf515045808e8868b1944d4 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH] [clang] Improve _Alignas on declaration diagnostic Adds `isAl

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-22 Thread via cfe-commits
sr-tream wrote: > Do you have access to land the PR No, help me please to merge this PR https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-22 Thread Emilia Kond via cfe-commits
@@ -5118,10 +5118,6 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, return true; if (Left.IsUnterminatedLiteral) return true; - if (Right.is(tok::lessless) && Right.Next && Left.is(tok::string_literal) && rymiel wrote: https://gi

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-22 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. > Any concerns with this approach? Sounds reasonable to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156565/new/ https://reviews.llvm.org/D156565 ___ cfe-commits mailing li

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-22 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 01/18] Fix `Form` to recognize `_Alignas` in addition to `alig

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D156565#4654818 , @aaron.ballman wrote: > In D156565#4654773 , @nathanchance > wrote: > >> Is it expected that this introduces a warning for C code, as the commit >> message an

[clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-22 Thread WÁNG Xuěruì via cfe-commits
xen0n wrote: According to [the *LLVM GitHub user guide*](https://llvm.org/docs/GitHub.html#creating-pull-requests): > If you have multiple changes you want to introduce, it’s recommended to > create separate pull requests for each change. Given you've already split your changes into several s

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-22 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 01/14] Fix `Form` to recognize `_Alignas` in addition to `alig

[clang] [clang][Interp] Fix `ArrayInitLoopExpr` handling (PR #67886)

2023-10-22 Thread via cfe-commits
isuckatcs wrote: ping @tbaederr https://github.com/llvm/llvm-project/pull/67886 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D156565#4654773 , @nathanchance wrote: > Is it expected that this introduces a warning for C code, as the commit > message and tests appear to only affect C++? A trivial example from the Linux > kernel: > > https://eli

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-22 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/69871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-22 Thread Björn Schäpers via cfe-commits
@@ -5118,10 +5118,6 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine &Line, return true; if (Left.IsUnterminatedLiteral) return true; - if (Right.is(tok::lessless) && Right.Next && Left.is(tok::string_literal) && HazardyKnusperkeks wrote:

[clang] [clang-format] Don't break between string literal operands of << (PR #69871)

2023-10-22 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/69871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-22 Thread via cfe-commits
https://github.com/isuckatcs updated https://github.com/llvm/llvm-project/pull/68039 >From 6748bd2171cca24c46ade12d57b57e97c3312501 Mon Sep 17 00:00:00 2001 From: isuckatcs <65320245+isucka...@users.noreply.github.com> Date: Mon, 2 Oct 2023 22:29:14 +0200 Subject: [PATCH 1/6] impl --- clang/li

[clang] [clang][Interp] Only evaluate the source array initialization of an `ArrayInitLoopExpr` once (PR #68039)

2023-10-22 Thread via cfe-commits
@@ -847,7 +845,33 @@ template bool ByteCodeExprGen::VisitOpaqueValueExpr(const OpaqueValueExpr *E) { if (Initializing) return this->visitInitializer(E->getSourceExpr()); - return this->visit(E->getSourceExpr()); + + PrimType CacheVariableTy = classify(E).value_or(PT_Pt

[clang-tools-extra] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

2023-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir Author: Rik Huijzer (rikhuijzer) Changes Fixes https://github.com/llvm/llvm-project/issues/61871. This PR fixes two small things. First and foremost, it throws a clear error in the `-test-elements-attr-interface` when those tests are called on ele

[clang-tools-extra] [mlir] Verify TestBuiltinAttributeInterfaces eltype (PR #69878)

2023-10-22 Thread Rik Huijzer via cfe-commits
https://github.com/rikhuijzer created https://github.com/llvm/llvm-project/pull/69878 Fixes https://github.com/llvm/llvm-project/issues/61871. This PR fixes two small things. First and foremost, it throws a clear error in the `-test-elements-attr-interface` when those tests are called on eleme

[clang-tools-extra] [clangd] Show alignment for records and fields decls (PR #67213)

2023-10-22 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Thank you @Endilll for the explanation. The remaining part looks good; @sr-tream Do you have access to land the PR? If not, I'm glad to help you. :) https://github.com/llvm/llvm-project/pull/67213 ___ cfe-commits mailing list cfe-commit

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-22 Thread Jerin Philip via cfe-commits
@@ -94,7 +94,7 @@ class AttributeCommonInfo { IsRegularKeywordAttribute(IsRegularKeywordAttribute) {} constexpr Form(tok::TokenKind Tok) : SyntaxUsed(AS_Keyword), SpellingIndex(SpellingNotCalculated), - IsAlignas(Tok == tok::kw_alignas), +

  1   2   >