[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-25 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Ping https://github.com/llvm/llvm-project/pull/69079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D110252: Added note about Whatstyle and Unformat

2023-10-25 Thread Owen Pan via Phabricator via cfe-commits
owenpan commandeered this revision. owenpan edited reviewers, added: Volker-Weissmann; removed: owenpan. Herald added a project: All. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your review contains a change to ClangFormatStyleOptions.rst but not a change to clang/in

[clang] [C23] Use thread_local semantics (PR #70107)

2023-10-25 Thread Aaron Ballman via cfe-commits
@@ -493,6 +493,9 @@ Bug Fixes in This Version Fixes (`#65143 `_) - Fix crash in formatting the real/imaginary part of a complex lvalue. Fixes (`#69218 `_) +- No longer use

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-10-25 Thread Sunil K via Phabricator via cfe-commits
koops updated this revision to Diff 557877. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/loop_bin

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,78 @@ +//===- Utility.cpp -- Collection of geneirc offloading utilities --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Offloading][NFC] Move creation of offloading entries from OpenMP (PR #70116)

2023-10-25 Thread Matt Arsenault via cfe-commits
arsenm wrote: > to allow for more code re-use in the registeration Typo 'registeration' https://github.com/llvm/llvm-project/pull/70116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang-tools-extra] [RFC] Perform lifetime bound checks for arguments to coroutine (PR #69360)

2023-10-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 ready_for_review https://github.com/llvm/llvm-project/pull/69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AMDGPU] Rematerialize scalar loads (PR #68778)

2023-10-25 Thread Piotr Sobczak via cfe-commits
https://github.com/piotrAMD updated https://github.com/llvm/llvm-project/pull/68778 >From 6b5ada294d999ba1412020806ce8fab8e34a408e Mon Sep 17 00:00:00 2001 From: Piotr Sobczak Date: Wed, 11 Oct 2023 10:32:57 +0200 Subject: [PATCH 1/5] [AMDGPU] Rematerialize scalar loads Extend the list of inst

[clang] [NFC][Clang] Fix potential deref of end iterator (PR #70193)

2023-10-25 Thread Nathan Gauër via cfe-commits
https://github.com/Keenuts created https://github.com/llvm/llvm-project/pull/70193 This was found by doing bound-checking on SmallVector iterator usage. When the count is 0, the end iterator is dereferenced to get its address. This doesn't seem to be an issue in practice as most of the time, a

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-25 Thread Simon Tatham via cfe-commits
@@ -152,6 +180,7 @@ template <> struct llvm::yaml::MappingTraits { static void mapping(llvm::yaml::IO &io, MultilibSerialization &V) { io.mapRequired("Dir", V.Dir); io.mapRequired("Flags", V.Flags); +io.mapOptional("ExclusiveGroup", V.ExclusiveGroup); ---

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-25 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/68743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5efa84c - [clang-format] Don't align comments over scopes

2023-10-25 Thread via cfe-commits
Author: Björn Schäpers Date: 2023-10-25T12:50:15+02:00 New Revision: 5efa84cf6feaaa03e6325836f89503b0ab2be0d8 URL: https://github.com/llvm/llvm-project/commit/5efa84cf6feaaa03e6325836f89503b0ab2be0d8 DIFF: https://github.com/llvm/llvm-project/commit/5efa84cf6feaaa03e6325836f89503b0ab2be0d8.diff

[clang] [flang] add tbaa tags to global and direct values (PR #68727)

2023-10-25 Thread Tom Eccles via cfe-commits
tblah wrote: Merged manually in https://github.com/llvm/llvm-project/commit/6242c8ca18bcd6765094c73dd2c8b49200a6cec8 https://github.com/llvm/llvm-project/pull/68727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [flang] add tbaa tags to global and direct values (PR #68727)

2023-10-25 Thread Tom Eccles via cfe-commits
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/68727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Fold xored one-complemented operand comparisons (PR #69882)

2023-10-25 Thread via cfe-commits
elhewaty wrote: @dtcxzyw can you help me, what is wrong here? https://github.com/llvm/llvm-project/pull/69882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

2023-10-25 Thread Sunil K via Phabricator via cfe-commits
koops updated this revision to Diff 557876. koops added a comment. Removing multiple calls to Sema::checkNestingOfRegions() in Sema::ActOnOpenMPExecutableDirective() . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/cla

[clang-tools-extra] [InstCombine] Fold xored one-complemented operand comparisons (PR #69882)

2023-10-25 Thread via cfe-commits
https://github.com/elhewaty updated https://github.com/llvm/llvm-project/pull/69882 >From 3a6ddf5192264e2dc32adc67184e06529151b343 Mon Sep 17 00:00:00 2001 From: Mohamed Atef Date: Tue, 24 Oct 2023 16:54:14 +0300 Subject: [PATCH 1/2] [InstCombine] Add test coverage for comparisons of operands

[clang] [analyzer] Loop should contain CXXForRangeStmt (PR #70190)

2023-10-25 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/70190 >From b1b49db9f155d0bf0aef626d620b6287509fb538 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Wed, 25 Oct 2023 18:13:21 +0800 Subject: [PATCH] [analyzer] Loop should contain CXXForRangeStmt --- clang/lib/StaticAna

[clang] [analyzer] Loop should contain CXXForRangeStmt (PR #70190)

2023-10-25 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/70190 >From f65ad2217e169b1d6876696201b97ffca5f9c886 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Wed, 25 Oct 2023 18:13:21 +0800 Subject: [PATCH] [analyzer] Loop should contain CXXForRangeStmt --- clang/lib/StaticAna

[clang] [analyzer] Loop should contain CXXForRangeStmt (PR #70190)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qizhi Hu (jcsxky) Changes Static analyze can't report diagnose when statement after a CXXForRangeStmt and enable widen, because `ExprEngine::processCFGBlockEntrance` lacks of CXXForRangeStmt and when `AMgr.options.maxBlockVisitOnPath - 1`

[clang] [analyzer] Loop should contain CXXForRangeStmt (PR #70190)

2023-10-25 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/70190 Static analyze can't report diagnose when statement after a CXXForRangeStmt and enable widen, because `ExprEngine::processCFGBlockEntrance` lacks of CXXForRangeStmt and when `AMgr.options.maxBlockVisitOnPath - 1`

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Balázs Kéri via cfe-commits
@@ -1349,7 +1349,7 @@ def warn_omp_extra_tokens_at_eol : Warning< "extra tokens at the end of '#pragma omp %0' are ignored">, InGroup; def err_omp_multiple_step_or_linear_modifier : Error< - "multiple %select{'step size'|'linear modifier'}0 found in linear clause">; + "m

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Balázs Kéri via cfe-commits
https://github.com/balazske requested changes to this pull request. Probably add [clang] tag to the commit message, and remove the change in DiagnosticParseKinds.td, otherwise the change looks good. https://github.com/llvm/llvm-project/pull/70170 ___

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Balázs Kéri via cfe-commits
https://github.com/balazske edited https://github.com/llvm/llvm-project/pull/70170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Disable memtag sanitization for global fnptrs going into .ctors (PR #70186)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mitch Phillips (hctim) Changes Looks like there's code out there that, instead of using '__attribute__((constructor(x)))' to add constructor functions, they just declare a global function pointer and use '__attribute__((section('.ctors')))'

[clang] Disable memtag sanitization for global fnptrs going into .ctors (PR #70186)

2023-10-25 Thread Mitch Phillips via cfe-commits
hctim wrote: @P1119r1m https://github.com/llvm/llvm-project/pull/70186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Disable memtag sanitization for global fnptrs going into .ctors (PR #70186)

2023-10-25 Thread Mitch Phillips via cfe-commits
https://github.com/hctim created https://github.com/llvm/llvm-project/pull/70186 Looks like there's code out there that, instead of using '__attribute__((constructor(x)))' to add constructor functions, they just declare a global function pointer and use '__attribute__((section('.ctors')))' instea

[clang] [mlir][LLVM] Verify too many indices in GEP verifier (PR #70174)

2023-10-25 Thread Markus Böck via cfe-commits
https://github.com/zero9178 closed https://github.com/llvm/llvm-project/pull/70174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][DebugInfo] Clang generates an extra spurious unnamed 'dbg.declare' (PR #69681)

2023-10-25 Thread Carlos Alberto Enciso via cfe-commits
https://github.com/CarlosAlbertoEnciso closed https://github.com/llvm/llvm-project/pull/69681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2399c77 - [Clang][DebugInfo] Clang generates an extra spurious unnamed 'dbg.declare' (#69681)

2023-10-25 Thread via cfe-commits
Author: Carlos Alberto Enciso Date: 2023-10-25T10:35:03+01:00 New Revision: 2399c77c8593b0ed3bd3988a5b72f8bf6b30b0de URL: https://github.com/llvm/llvm-project/commit/2399c77c8593b0ed3bd3988a5b72f8bf6b30b0de DIFF: https://github.com/llvm/llvm-project/commit/2399c77c8593b0ed3bd3988a5b72f8bf6b30b0

[clang] [Clang][DebugInfo] Clang generates an extra spurious unnamed 'dbg.declare' (PR #69681)

2023-10-25 Thread Carlos Alberto Enciso via cfe-commits
CarlosAlbertoEnciso wrote: @adrian-prantl, @OCHyams Thanks for your reviews. https://github.com/llvm/llvm-project/pull/69681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-25 Thread Timm Baeder via cfe-commits
@@ -7748,6 +7748,24 @@ bool Sema::CheckExplicitlyDefaultedSpecialMember(CXXMethodDecl *MD, HadError = true; } } +// [C++23][dcl.fct.def.default]/p2.2 +// if F2 has an implicit object parameter of type “reference to C”, +// F1 may be an explicit ob

[clang] [libc++] Implement ranges::iota (PR #68494)

2023-10-25 Thread via cfe-commits
philnik777 wrote: Yes, it should be the `ranges_robust_against_*` tests in both `test/libcxx` and `test/std`. https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-25 Thread via cfe-commits
philnik777 wrote: Yes, it should be the `ranges_robust_against_*` tests in both `test/libcxx` and `test/std`. https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [Clang][DebugInfo] Clang generates an extra spurious unnamed 'dbg.declare' (PR #69681)

2023-10-25 Thread Orlando Cazalet-Hyams via cfe-commits
https://github.com/OCHyams approved this pull request. New changes LGTM, thanks! https://github.com/llvm/llvm-project/pull/69681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::iota (PR #68494)

2023-10-25 Thread via cfe-commits
@@ -0,0 +1,54 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[clang] [analyzer] Improve reports from ArrayBoundCheckerV2 (PR #70056)

2023-10-25 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: DonatNagyE wrote: I renamed some variables because (1) they weren't CamelCased because they were "inherited" from the old versions of this checker and (2) their names were slightly too long and they introduced extra linebreaks in the newly adde

[clang] [AArch64] Stack probing for function prologues (PR #66524)

2023-10-25 Thread Momchil Velikov via cfe-commits
momchil-velikov wrote: > I haven't been able to produce a minimal, sharable example as of yet, but I'm > encountering a runtime error associated with an inlined function where stack > probing is active. The error manifests as a null pointer dereference, > originating from a stack value that i

[clang] [Clang][DebugInfo] Clang generates an extra spurious unnamed 'dbg.declare' (PR #69681)

2023-10-25 Thread Carlos Alberto Enciso via cfe-commits
CarlosAlbertoEnciso wrote: Uploaded new patch to address minor details with the test case: - Added check for missing captured `a` variable. - Check for the specific values in `DW_OP_plus_uconst`. https://github.com/llvm/llvm-project/pull/69681 ___ cfe-

[clang] [analyzer] Improve reports from ArrayBoundCheckerV2 (PR #70056)

2023-10-25 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: https://github.com/DonatNagyE updated https://github.com/llvm/llvm-project/pull/70056 >From 77143e74edda6177248bebdf0424db915aa68a05 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Don=C3=A1t=20Nagy?= Date: Mon, 2 Oct 2023 13:32:31 +0200 Subject: [PAT

[clang] [Clang][DebugInfo] Clang generates an extra spurious unnamed 'dbg.declare' (PR #69681)

2023-10-25 Thread Carlos Alberto Enciso via cfe-commits
https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/69681 >From 42df544996bb8fee93e5d1bab72e71578645bcc4 Mon Sep 17 00:00:00 2001 From: Carlos Alberto Enciso Date: Fri, 20 Oct 2023 06:09:04 +0100 Subject: [PATCH 1/3] [Clang][DebugInfo] Clang generates an ext

[clang] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #69313)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7df92fbe74e3c1b41c06f5fc784473f7f22aeed7 0bd36f11c5d1da2447b1c123445a1472372a096b --

[clang] [mlir][LLVM] Verify too many indices in GEP verifier (PR #70174)

2023-10-25 Thread Markus Böck via cfe-commits
https://github.com/zero9178 updated https://github.com/llvm/llvm-project/pull/70174 From 03fb7aceae81227c3a64cf4b9ba1e53a69e46511 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Markus=20B=C3=B6ck?= Date: Wed, 25 Oct 2023 09:54:16 +0200 Subject: [PATCH 1/3] [mlir][LLVM] Verify too many indices in GEP

[clang] [C23] Use thread_local semantics (PR #70107)

2023-10-25 Thread Mariya Podchishchaeva via cfe-commits
@@ -493,6 +493,9 @@ Bug Fixes in This Version Fixes (`#65143 `_) - Fix crash in formatting the real/imaginary part of a complex lvalue. Fixes (`#69218 `_) +- No longer use

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-25 Thread Vlad Serebrennikov via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-25 Thread Vlad Serebrennikov via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-25 Thread Vlad Serebrennikov via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-25 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/70176 >From 6fd05adec162b2d18b4b163cc0a0f6d6e6710139 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 25 Oct 2023 10:08:24 +0200 Subject: [PATCH] [Clang] Diagnose defaulted assignment operator with incompatib

[clang] [clang][NFC] Refactor `Selector` to use `PointerIntPair` inside (PR #69916)

2023-10-25 Thread Vlad Serebrennikov via cfe-commits
@@ -809,43 +927,42 @@ class Selector { enum IdentifierInfoFlag { // Empty selector = 0. Note that these enumeration values must // correspond to the enumeration values of DeclarationName::StoredNameKind -ZeroArg = 0x01, -OneArg = 0x02, +ZeroArg = 0x01,

[clang] [RISCV] Run mem2reg to simplify Zbc tests (PR #70169)

2023-10-25 Thread Wang Pengcheng via cfe-commits
https://github.com/wangpc-pp closed https://github.com/llvm/llvm-project/pull/70169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a7700985577694d6cc2498833f27b4fb5eeaf252 441f24714729f35588487d3109e3c42d59e0a610 --

[clang] 0e27cbe - [RISCV] Run mem2reg to simplify Zbc tests (#70169)

2023-10-25 Thread via cfe-commits
Author: Wang Pengcheng Date: 2023-10-25T16:23:32+08:00 New Revision: 0e27cbe1879f400d64088d8770803e884782a34e URL: https://github.com/llvm/llvm-project/commit/0e27cbe1879f400d64088d8770803e884782a34e DIFF: https://github.com/llvm/llvm-project/commit/0e27cbe1879f400d64088d8770803e884782a34e.diff

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-10-25 Thread Nikita Popov via cfe-commits
@@ -984,7 +1041,7 @@ Value *InstCombinerImpl::SimplifyDemandedUseBits(Value *V, APInt DemandedMask, // If the client is only demanding bits that we know, return the known // constant. - if (DemandedMask.isSubsetOf(Known.Zero|Known.One)) + if (MaySimplifyAsConstant && De

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-10-25 Thread Nikita Popov via cfe-commits
@@ -143,7 +155,7 @@ Value *InstCombinerImpl::SimplifyDemandedUseBits(Value *V, APInt DemandedMask, return SimplifyMultipleUseDemandedBits(I, DemandedMask, Known, Depth, CxtI); KnownBits LHSKnown(BitWidth), RHSKnown(BitWidth); - + bool MaySimplifyAsConstant = true; ---

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-25 Thread Yeting Kuo via cfe-commits
@@ -0,0 +1,86 @@ +//===-- RISCVInstrInfoZicfiss.td - RISC-V Zicfiss -*- tablegen -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-25 Thread Yeting Kuo via cfe-commits
@@ -0,0 +1,86 @@ +//===-- RISCVInstrInfoZicfiss.td - RISC-V Zicfiss -*- tablegen -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-25 Thread Yeting Kuo via cfe-commits
@@ -0,0 +1,86 @@ +//===-- RISCVInstrInfoZicfiss.td - RISC-V Zicfiss -*- tablegen -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-25 Thread Yeting Kuo via cfe-commits
@@ -0,0 +1,86 @@ +//===-- RISCVInstrInfoZicfiss.td - RISC-V Zicfiss -*- tablegen -*--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

2023-10-25 Thread Yeting Kuo via cfe-commits
https://github.com/yetingk updated https://github.com/llvm/llvm-project/pull/66043 >From 91bb1d9884276a37f93515a648aa6ece353fdc70 Mon Sep 17 00:00:00 2001 From: Yeting Kuo Date: Tue, 12 Sep 2023 12:28:00 +0800 Subject: [PATCH 1/3] [RISCV] Add MC layer support for Zicfiss. The patch adds the in

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Per https://eel.is/c++draft/dcl.fct.def.default#2.2, the explicit object parameter of a defaulted special member function must be of the same type as the one of an equivalent implicitly defaulted function, igno

[clang] [Clang] Diagnose defaulted assignment operator with incompatible object parameter (PR #70176)

2023-10-25 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/70176 Per https://eel.is/c++draft/dcl.fct.def.default#2.2, the explicit object parameter of a defaulted special member function must be of the same type as the one of an equivalent implicitly defaulted function, igno

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/70171 >From fca61de1d6cf5fe68cfb51bfe5ca73d5d3948ba5 Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 25 Oct 2023 02:10:32 -0500 Subject: [PATCH] [PassBuilder] Add a mechanism for adding passbuilder callba

[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

2023-10-25 Thread Chuanqi Xu via cfe-commits
@@ -617,24 +617,27 @@ void ASTDeclReader::VisitDecl(Decl *D) { Reader.getContext()); } D->setLocation(ThisDeclLoc); - D->InvalidDecl = Record.readInt(); - if (Record.readInt()) { // hasAttrs + + uint64_t DeclBits = Record.readInt(); + D->Inval

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/70171 >From 8b0e0939ea51768b9e1257e816556d245c91134b Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 25 Oct 2023 02:10:32 -0500 Subject: [PATCH] [PassBuilder] Add a mechanism for adding passbuilder callba

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
https://github.com/wsmoses updated https://github.com/llvm/llvm-project/pull/70171 >From 9ccb8b7bff8adc03bf027766005762b350a803bc Mon Sep 17 00:00:00 2001 From: "William S. Moses" Date: Wed, 25 Oct 2023 02:10:32 -0500 Subject: [PATCH] [PassBuilder] Add a mechanism for adding passbuilder callba

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-10-25 Thread Nikita Popov via cfe-commits
@@ -1973,6 +1978,28 @@ Instruction *InstCombinerImpl::visitCallInst(CallInst &CI) { *II, Builder.CreateIntrinsic(InnerPtr->getType(), Intrinsic::ptrmask, {InnerPtr, NewMask})); } +bool Changed = false; +// See if we

[clang] [NFC] [Serializer] Pack information in serializer (PR #69287)

2023-10-25 Thread Vassil Vassilev via cfe-commits
@@ -617,24 +617,27 @@ void ASTDeclReader::VisitDecl(Decl *D) { Reader.getContext()); } D->setLocation(ThisDeclLoc); - D->InvalidDecl = Record.readInt(); - if (Record.readInt()) { // hasAttrs + + uint64_t DeclBits = Record.readInt(); + D->Inval

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-10-25 Thread Nikita Popov via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-25 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Done. Sorry for leaving irrelevant changes ;) https://github.com/llvm/llvm-project/pull/69224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-25 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/69224 >From 880f271cbad4aacb7647bc402f636adf12ca1147 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Mon, 16 Oct 2023 22:50:08 +0800 Subject: [PATCH] [clang][Sema] Avoid non-empty unexpanded pack assertion for Funct

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/70170 >From 3c23adbb74972c5ba98e08561a48bfd14a06b70f Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Wed, 25 Oct 2023 14:58:55 +0800 Subject: [PATCH] [analyzer][NFC] Combine similar methods of StreamChecker Methods Str

[clang] [clang][Interp] Fix truncateCast() (PR #69911)

2023-10-25 Thread via cfe-commits
@@ -81,14 +89,20 @@ template class IntegralAP final { } explicit operator bool() const { return !V.isZero(); } - explicit operator int8_t() const { return truncateCast(V); } - explicit operator uint8_t() const { return truncateCast(V); } - explicit operator int16_t() c

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

2023-10-25 Thread Karl-Johan Karlsson via cfe-commits
https://github.com/karka228 closed https://github.com/llvm/llvm-project/pull/69521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d25e0aa - [Sema] Fixed faulty shift count warning (#69521)

2023-10-25 Thread via cfe-commits
Author: Karl-Johan Karlsson Date: 2023-10-25T09:48:01+02:00 New Revision: d25e0aac415f45ce98c3700010acb5a98f016cef URL: https://github.com/llvm/llvm-project/commit/d25e0aac415f45ce98c3700010acb5a98f016cef DIFF: https://github.com/llvm/llvm-project/commit/d25e0aac415f45ce98c3700010acb5a98f016cef

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -738,6 +738,37 @@ objcopy::parseObjcopyOptions(ArrayRef RawArgsArr, if (auto Arg = InputArgs.getLastArg(OBJCOPY_extract_partition)) Config.ExtractPartition = Arg->getValue(); + if (const auto *A = InputArgs.getLastArg(OBJCOPY_gap_fill)) { +if (Config.OutputForma

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -0,0 +1,198 @@ +# RUN: yaml2obj --docnum=1 %s -o %t + +# RUN: not llvm-objcopy --gap-fill 1 %t 2>&1 | FileCheck %s --check-prefix=NOT-BINARY +# NOT-BINARY: error: '--gap-fill' is only supported for binary output + +# RUN: not llvm-objcopy -O binary --gap-fill= %t %t.bin 2>&1 |

[clang] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -0,0 +1,94 @@ +# RUN: yaml2obj %s -o %t + +# RUN: not llvm-objcopy --pad-to=1 %t 2>&1 | FileCheck %s --check-prefix=NOT-BINARY +# NOT-BINARY: error: '--pad-to' is only supported for binary output + +# RUN: not llvm-objcopy -O binary --pad-to= %t 2>&1 | FileCheck %s --check-pr

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -1,39 +1,32 @@ -# RUN: yaml2obj %s > %t +# RUN: yaml2obj %s -o %t -## Verify section headers before we perform several testings. -# RUN: llvm-readelf -S %t | FileCheck %s --check-prefix=ORG-SHDR -# ORG-SHDR: Section Headers: -# ORG-SHDR: [Nr] Name Type

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -738,6 +738,37 @@ objcopy::parseObjcopyOptions(ArrayRef RawArgsArr, if (auto Arg = InputArgs.getLastArg(OBJCOPY_extract_partition)) Config.ExtractPartition = Arg->getValue(); + if (const auto *A = InputArgs.getLastArg(OBJCOPY_gap_fill)) { +if (Config.OutputForma

[clang] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -2635,9 +2635,36 @@ template Error ELFWriter::finalize() { } Error BinaryWriter::write() { - for (const SectionBase &Sec : Obj.allocSections()) + SmallVector LoadableSections; + for (const SectionBase &Sec : Obj.allocSections()) { +if (Sec.Type != SHT_NOBITS) +

[clang-tools-extra] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -0,0 +1,94 @@ +# RUN: yaml2obj %s -o %t + +# RUN: not llvm-objcopy --pad-to=1 %t 2>&1 | FileCheck %s --check-prefix=NOT-BINARY +# NOT-BINARY: error: '--pad-to' is only supported for binary output + +# RUN: not llvm-objcopy -O binary --pad-to= %t 2>&1 | FileCheck %s --check-pr

[clang] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -0,0 +1,94 @@ +# RUN: yaml2obj %s -o %t + +# RUN: not llvm-objcopy --pad-to=1 %t 2>&1 | FileCheck %s --check-prefix=NOT-BINARY +# NOT-BINARY: error: '--pad-to' is only supported for binary output + +# RUN: not llvm-objcopy -O binary --pad-to= %t 2>&1 | FileCheck %s --check-pr

[clang] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -0,0 +1,198 @@ +# RUN: yaml2obj --docnum=1 %s -o %t + +# RUN: not llvm-objcopy --gap-fill 1 %t 2>&1 | FileCheck %s --check-prefix=NOT-BINARY +# NOT-BINARY: error: '--gap-fill' is only supported for binary output + +# RUN: not llvm-objcopy -O binary --gap-fill= %t %t.bin 2>&1 |

[clang] [llvm-objcopy] Add --gap-fill and --pad-to options (PR #65815)

2023-10-25 Thread James Henderson via cfe-commits
@@ -738,6 +738,37 @@ objcopy::parseObjcopyOptions(ArrayRef RawArgsArr, if (auto Arg = InputArgs.getLastArg(OBJCOPY_extract_partition)) Config.ExtractPartition = Arg->getValue(); + if (const auto *A = InputArgs.getLastArg(OBJCOPY_gap_fill)) { +if (Config.OutputForma

[clang] [clang][Sema] Avoid non-empty unexpanded pack assertion for FunctionParmPackExpr (PR #69224)

2023-10-25 Thread via cfe-commits
cor3ntin wrote: Looks generally good to me. can you remove the whitespace only changes? thanks! https://github.com/llvm/llvm-project/pull/69224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Matt Arsenault via cfe-commits
@@ -7995,15 +7995,24 @@ enum SpecialRegisterAccessKind { Write, }; +// Generates the IR for __builtin_read_exec_*. +// Lowers the builtin to amdgcn_ballot intrinsic. static Value *EmitAMDGCNBallotForExec(CodeGenFunction &CGF, const CallExpr *E,

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Matt Arsenault via cfe-commits
@@ -21,6 +23,28 @@ void test_ballot_wave32_target_attr(global uint* out, int a, int b) *out = __builtin_amdgcn_ballot_w32(a == b); } +// CHECK-LABEL: @test_read_exec( +// CHECK: call i64 @llvm.amdgcn.ballot.i64(i1 true) +void test_read_exec(global uint* out) { + *out = __b

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: lgtm with a nit https://github.com/llvm/llvm-project/pull/69567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Lower __builtin_amdgcn_read_exec_hi to use amdgcn_ballot (PR #69567)

2023-10-25 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/69567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-25 Thread Petr Hosek via cfe-commits
@@ -0,0 +1,69 @@ +# REQUIRES: shell +# UNSUPPORTED: system-windows + +# RUN: rm -rf %t + +# RUN: mkdir -p %t/baremetal_multilib/bin +# RUN: ln -s %clang %t/baremetal_multilib/bin/clang + +# RUN: mkdir -p %t/baremetal_multilib/lib/clang-runtimes +# RUN: ln -s %s %t/baremetal_multil

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: William Moses (wsmoses) Changes Adding passbuilder callbacks presently can be done one of two ways: * a shared library plugin * modifying the extensions list (and thus extensions.def) This prevents the use of such functionality for

[clang] [Driver] Add `--` to some test clang-cl command lines. (PR #70055)

2023-10-25 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm closed https://github.com/llvm/llvm-project/pull/70055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9ae11a5 - [Driver] Add `--` to some test clang-cl command lines. (#70055)

2023-10-25 Thread via cfe-commits
Author: Simon Tatham Date: 2023-10-25T08:27:06+01:00 New Revision: 9ae11a5bacb781f6899861ab2197a8cd711c5e6c URL: https://github.com/llvm/llvm-project/commit/9ae11a5bacb781f6899861ab2197a8cd711c5e6c DIFF: https://github.com/llvm/llvm-project/commit/9ae11a5bacb781f6899861ab2197a8cd711c5e6c.diff

[clang] [PassBuilder] Add a mechanism for adding passbuilder callbacks for static builds (PR #70171)

2023-10-25 Thread William Moses via cfe-commits
https://github.com/wsmoses created https://github.com/llvm/llvm-project/pull/70171 Adding passbuilder callbacks presently can be done one of two ways: * a shared library plugin * modifying the extensions list (and thus extensions.def) This prevents the use of such functionality for static build

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-25 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/68743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't align comments over scopes (PR #68743)

2023-10-25 Thread Owen Pan via cfe-commits
@@ -182,7 +182,7 @@ TEST_F(FormatTestComments, UnderstandsSingleLineComments) { "int a; // This is unrelated")); EXPECT_EQ("class C {\n" " void f() { // This does something ..\n" -" } // awesome..\n" +"

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-25 Thread Petr Hosek via cfe-commits
@@ -152,6 +180,7 @@ template <> struct llvm::yaml::MappingTraits { static void mapping(llvm::yaml::IO &io, MultilibSerialization &V) { io.mapRequired("Dir", V.Dir); io.mapRequired("Flags", V.Flags); +io.mapOptional("ExclusiveGroup", V.ExclusiveGroup); ---

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/70170 >From d32442f4f38d45ca9a8fab490f3618ccc31dd632 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Wed, 25 Oct 2023 14:58:55 +0800 Subject: [PATCH] [analyzer][NFC] Combine similar methods of StreamChecker Methods Str

[clang] [analyzer][NFC] Combine similar methods of StreamChecker (PR #70170)

2023-10-25 Thread Ben Shi via cfe-commits
https://github.com/benshi001 edited https://github.com/llvm/llvm-project/pull/70170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Combine similar methods in StreamChecker (PR #70170)

2023-10-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ben Shi (benshi001) Changes Methods StreamChecker::preFread and StreamChecker::preFwrite are quite similar, so they can be combined to StreamChecker::preFreadFwrite. --- Full diff: https://github.com/llvm/llvm-project/pu

<    1   2   3   4   5   6   >