jayfoad wrote:
Typo in subject "**Guard** return ..."?
https://github.com/llvm/llvm-project/pull/71989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HaohaiWen wrote:
> Thanks for the updated example!
>
> To explain what I meant in first comment using this example: We would perform
> the transform https://alive2.llvm.org/ce/z/nllcB_, which does not depend at
> all on how `%yx` is constructed, and whether there is any way to form the
>
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/72047
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Brad Smith
Date: 2023-11-13T02:42:14-05:00
New Revision: 4d5a8ccf25a6c43930c332e75ecead287778af6b
URL:
https://github.com/llvm/llvm-project/commit/4d5a8ccf25a6c43930c332e75ecead287778af6b
DIFF:
https://github.com/llvm/llvm-project/commit/4d5a8ccf25a6c43930c332e75ecead287778af6b.diff
https://github.com/HighCommander4 commented:
Is it not possible to tell based on the `CallExpr` only (rather than checking
an ancestor of it during traversal of the tree) that "this `CallExpr` is not
explicitly written in the source"?
https://github.com/llvm/llvm-project/pull/71366
zyn0217 wrote:
> If so, get its TemplateTypeParmDecl, find the template whose parameter it is,
> and see if the template has a getOnlyInstantiation.
Thanks for the suggestion! Admittedly, it looks neat and terse. However, I
suspect it won't work with the present `TemplateTypeParm{Type,Decl}`
tru wrote:
17.0.5 is going to be released tomorrow, is this fix good to go for the
backport?
https://github.com/llvm/llvm-project/pull/70646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/72047
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: None (ls-Mou)
Changes
-rdynamic option should not use with -static, as shown in the following code
https://github.com/ls-Mou created
https://github.com/llvm/llvm-project/pull/72089
-rdynamic option should not use with -static, as shown in the following code
https://github.com/llvm/llvm-project/blob/f86770aa073ac9c17d9ccb6409254e879dca2de6/clang/lib/Driver/ToolChains/Gnu.cpp#L460-L472
So I
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/70817
>From 7fbc229ee7316d826517480ee7896c91dad941f3 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 31 Oct 2023 17:09:04 +0200
Subject: [PATCH 01/10] Add \/../include/c++/v1 to include path
On macOS, when
https://github.com/HighCommander4 commented:
Thanks very much for looking at this!
I'm wondering if it's possible to achieve the same results (and also solve your
`CXXUnresolvedConstructExpr` issue) with a more targeted change that may also
be simpler.
While I haven't experimented with this
https://github.com/HaohaiWen updated
https://github.com/llvm/llvm-project/pull/71021
>From 1be56cf6541d34e4e2ead3f4b3d3ce482d69f68f Mon Sep 17 00:00:00 2001
From: Haohai Wen
Date: Thu, 2 Nov 2023 12:14:15 +0800
Subject: [PATCH 1/4] [DebugInfo] Add debug info test for jump table
Test whether
Author: Fangrui Song
Date: 2023-11-12T22:26:27-08:00
New Revision: 65f2cf25c36d8fd349405f83c65f7530c6fb2bb2
URL:
https://github.com/llvm/llvm-project/commit/65f2cf25c36d8fd349405f83c65f7530c6fb2bb2
DIFF:
https://github.com/llvm/llvm-project/commit/65f2cf25c36d8fd349405f83c65f7530c6fb2bb2.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/71780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Michael Buch
Date: 2023-11-13T06:04:27Z
New Revision: 638a8393615e911b729d5662096f60ef49f1c65e
URL:
https://github.com/llvm/llvm-project/commit/638a8393615e911b729d5662096f60ef49f1c65e
DIFF:
https://github.com/llvm/llvm-project/commit/638a8393615e911b729d5662096f60ef49f1c65e.diff
LOG:
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/69559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
4vtomat wrote:
ping
https://github.com/llvm/llvm-project/pull/69559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -307,11 +307,9 @@ Changes in existing checks
- Improved :doc:`misc-const-correctness
` check to avoid false positive
when
using pointer to member function.
-
-- Improved :doc:`misc-const-correctness
- ` check to not warn on uses in
- type-dependent binary operators,
lukel97 wrote:
> > Oh nice, I'm running into something similar in #71657. Are all these dead
> > ADDIs coming from the backwards local postpass?
>
> Yes. I believe this PR can address the issue.
My suspicion is that these LIs only become dead because the backwards local
postpass deletes a
Author: Fangrui Song
Date: 2023-11-12T21:29:03-08:00
New Revision: abeffc9fd6b0cd8f6f25f854e97cd73310c8a7e5
URL:
https://github.com/llvm/llvm-project/commit/abeffc9fd6b0cd8f6f25f854e97cd73310c8a7e5
DIFF:
https://github.com/llvm/llvm-project/commit/abeffc9fd6b0cd8f6f25f854e97cd73310c8a7e5.diff
https://github.com/yubingex007-a11y closed
https://github.com/llvm/llvm-project/pull/70611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/71969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/69224
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Younan Zhang
Date: 2023-11-13T12:44:17+08:00
New Revision: 868007a03c74f7c718e0e74c8bdac677eb3f09ba
URL:
https://github.com/llvm/llvm-project/commit/868007a03c74f7c718e0e74c8bdac677eb3f09ba
DIFF:
https://github.com/llvm/llvm-project/commit/868007a03c74f7c718e0e74c8bdac677eb3f09ba.diff
Any chance this could/should reference the length by name, rather than by
casts and pointer math? (so it's resilient to at least some changes to
StringLiteral/StringRef?) Or is this the preferred way to write Natvis
visualizers, so they're resilient to missing debug info or something?
On Sun, Nov
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/71969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/71969
>From ceb7d2236df5ffedcddc2c5b0bbed1c3d0db7c43 Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Thu, 9 Nov 2023 23:51:54 -0800
Subject: [PATCH 1/4] MapVector: add C++17-style try_emplace and
insert_or_assign
https://github.com/HaohaiWen updated
https://github.com/llvm/llvm-project/pull/71021
>From 1be56cf6541d34e4e2ead3f4b3d3ce482d69f68f Mon Sep 17 00:00:00 2001
From: Haohai Wen
Date: Thu, 2 Nov 2023 12:14:15 +0800
Subject: [PATCH 1/4] [DebugInfo] Add debug info test for jump table
Test whether
heiher wrote:
cc @xen0n @xry111
https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/heiher updated
https://github.com/llvm/llvm-project/pull/72078
>From 323a8f851acb085a9464b3edca1206481f2aee23 Mon Sep 17 00:00:00 2001
From: WANG Rui
Date: Fri, 10 Nov 2023 21:07:48 -0600
Subject: [PATCH] [clang] Add per-global code model attribute
This adds a per-global
heiher wrote:
Part 1: #72077
Part 3: #72079
https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 18415c8365047841c4671798e0129ca9bbd03c40
29c89161a55c2d7355a0d0b544044ea72348c086 --
https://github.com/heiher converted_to_draft
https://github.com/llvm/llvm-project/pull/72078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: hev (heiher)
Changes
This adds a per-global code model attribute, which can override the target's
code model to access global variables.
Link:
jhuber6 wrote:
> Would it be feasible to consider switching to the new offloading driver mode
> and really link with the library instead? It may be a conveniently isolated
> use case with little/no existing users that would disrupt.
I've thought a reasonable amount about a `compiler-rt` for
https://github.com/heiher created
https://github.com/llvm/llvm-project/pull/72078
This adds a per-global code model attribute, which can override the target's
code model to access global variables.
Link:
@@ -3630,10 +3631,17 @@ SDValue SITargetLowering::LowerCall(CallLoweringInfo
,
std::vector Ops;
Ops.push_back(Chain);
+ bool AddTargetGlobalAddr = true;
+ // Try to find the callee in the current module.
+ if (isa(Callee)) {
+Callee =
@@ -937,27 +938,105 @@ bool CodeGenAction::loadLinkModules(CompilerInstance
) {
for (const CodeGenOptions::BitcodeFileToLink :
CI.getCodeGenOpts().LinkBitcodeFiles) {
-auto BCBuf = CI.getFileManager().getBufferForFile(F.Filename);
-if (!BCBuf) {
+
+auto
@@ -596,6 +596,7 @@ static bool mustPreserveGV(const GlobalValue ) {
if (const Function *F = dyn_cast())
return F->isDeclaration() || F->getName().startswith("__asan_") ||
F->getName().startswith("__sanitizer_") ||
+ F->getName() == "__divti3" ||
@@ -937,27 +938,105 @@ bool CodeGenAction::loadLinkModules(CompilerInstance
) {
for (const CodeGenOptions::BitcodeFileToLink :
CI.getCodeGenOpts().LinkBitcodeFiles) {
-auto BCBuf = CI.getFileManager().getBufferForFile(F.Filename);
-if (!BCBuf) {
+
+auto
@@ -937,27 +938,105 @@ bool CodeGenAction::loadLinkModules(CompilerInstance
) {
for (const CodeGenOptions::BitcodeFileToLink :
CI.getCodeGenOpts().LinkBitcodeFiles) {
-auto BCBuf = CI.getFileManager().getBufferForFile(F.Filename);
-if (!BCBuf) {
+
+auto
@@ -937,27 +938,105 @@ bool CodeGenAction::loadLinkModules(CompilerInstance
) {
for (const CodeGenOptions::BitcodeFileToLink :
CI.getCodeGenOpts().LinkBitcodeFiles) {
-auto BCBuf = CI.getFileManager().getBufferForFile(F.Filename);
-if (!BCBuf) {
+
+auto
@@ -937,27 +938,105 @@ bool CodeGenAction::loadLinkModules(CompilerInstance
) {
for (const CodeGenOptions::BitcodeFileToLink :
CI.getCodeGenOpts().LinkBitcodeFiles) {
-auto BCBuf = CI.getFileManager().getBufferForFile(F.Filename);
-if (!BCBuf) {
+
+auto
@@ -937,27 +938,105 @@ bool CodeGenAction::loadLinkModules(CompilerInstance
) {
for (const CodeGenOptions::BitcodeFileToLink :
CI.getCodeGenOpts().LinkBitcodeFiles) {
-auto BCBuf = CI.getFileManager().getBufferForFile(F.Filename);
-if (!BCBuf) {
+
+auto
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/71978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm commented:
128-bit division should already work, we have an IR integer division expansion
for > 64-bit divides. I think moving towards getting the infrastructure to a
place where we can link in compiler-rt binaries is a good thing, but I don't
think we're in a
@@ -2227,14 +2227,6 @@ Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) {
llvm::Value *V = CE->changesVolatileQualification()
? EmitLoadOfLValue(CE)
: Visit(const_cast(E));
-if (V) {
- // CK_NoOp can model a
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/72072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/72072
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wenju-he wrote:
> I think it would be better if we could eliminate ConstantExpr addrspacecasts
> from the IR altogether, which would avoid most of the complexity here. I
> would also somewhat prefer to push this DFS into a helper function, but can
> live with it inline as-is
thank you for
https://github.com/HaohaiWen updated
https://github.com/llvm/llvm-project/pull/71021
>From 1be56cf6541d34e4e2ead3f4b3d3ce482d69f68f Mon Sep 17 00:00:00 2001
From: Haohai Wen
Date: Thu, 2 Nov 2023 12:14:15 +0800
Subject: [PATCH 1/4] [DebugInfo] Add debug info test for jump table
Test whether
phoebewang wrote:
@ronlieb The reproducer can compile successfully in trunk:
https://godbolt.org/z/hvKhGq9bq
Are you using a downstream compiler? You can check if the "emmintrin.h" has the
same change as main trunk.
You can also check it through pre-compile the code:
```
$ clang++ -E
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Youngsuk Kim (JOE1994)
Changes
Remove bitcast added back in dcd74716f9d18 .
---
Full diff: https://github.com/llvm/llvm-project/pull/72072.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CGExprScalar.cpp (-8)
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Youngsuk Kim (JOE1994)
Changes
Remove bitcast added back in dcd74716f9d18 .
---
Full diff: https://github.com/llvm/llvm-project/pull/72072.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CGExprScalar.cpp (-8)
``diff
https://github.com/JOE1994 created
https://github.com/llvm/llvm-project/pull/72072
Remove bitcast added back in dcd74716f9d18 .
>From b9db2565d3d2d251bde7cd84b704861d5b41bd14 Mon Sep 17 00:00:00 2001
From: JOE1994
Date: Sun, 12 Nov 2023 20:04:44 -0500
Subject: [PATCH] [clang][CGExprScalar]
@@ -143,7 +143,7 @@ _Unwind_Backtrace(_Unwind_Trace_Fn callback, void *ref) {
// Create a mock exception object for force unwinding.
_Unwind_Exception ex;
memset(, '\0', sizeof(ex));
- strcpy((char *)_class, "CLNGUNW");
+ memcpy(_class, "CLNGUNW",
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
michael-kenzel wrote:
I found another use of the same string copying in `tests/forceunwind.pass.cpp`
and updated that to match.
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/michael-kenzel updated
https://github.com/llvm/llvm-project/pull/72043
>From d5adc242a9c52c7de2a860489a4292b7461b6164 Mon Sep 17 00:00:00 2001
From: Michael Kenzel
Date: Sun, 12 Nov 2023 02:46:15 +0100
Subject: [PATCH] [libunwind] Remove unnecessary strcpy dependency
---
shiltian wrote:
Gentle ping
https://github.com/llvm/llvm-project/pull/70612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shiltian wrote:
Gentle ping
https://github.com/llvm/llvm-project/pull/68373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/72010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2023-11-12T15:55:06-08:00
New Revision: a533b76468ac1df54e2e541b05ba4c060a77c603
URL:
https://github.com/llvm/llvm-project/commit/a533b76468ac1df54e2e541b05ba4c060a77c603
DIFF:
https://github.com/llvm/llvm-project/commit/a533b76468ac1df54e2e541b05ba4c060a77c603.diff
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilg-ul wrote:
I tried to write the test, but after several atempts I was not able to properly
check the paths... :-(
@ldionne, do you have any suggestions on how to fix the test?
https://github.com/llvm/llvm-project/pull/70817
___
cfe-commits
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/70817
>From 7fbc229ee7316d826517480ee7896c91dad941f3 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 31 Oct 2023 17:09:04 +0200
Subject: [PATCH 1/9] Add \/../include/c++/v1 to include path
On macOS, when clang
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -308,6 +308,11 @@ Changes in existing checks
` check to avoid false positive
when
using pointer to member function.
+- Improved :doc:`misc-const-correctness
5chmidti wrote:
Done. I have also reworded the release note, I think it reads better now.
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/5chmidti updated
https://github.com/llvm/llvm-project/pull/70559
>From b29eb35fe8597ceefc4c615817174181a16f3c4c Mon Sep 17 00:00:00 2001
From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com>
Date: Sat, 28 Oct 2023 18:08:51 +0200
Subject: [PATCH 1/5] [clang-tidy]
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -143,7 +143,7 @@ _Unwind_Backtrace(_Unwind_Trace_Fn callback, void *ref) {
// Create a mock exception object for force unwinding.
_Unwind_Exception ex;
memset(, '\0', sizeof(ex));
- strcpy((char *)_class, "CLNGUNW");
+ memcpy(_class, "CLNGUNW",
https://github.com/michael-kenzel edited
https://github.com/llvm/llvm-project/pull/72043
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/70817
>From 7fbc229ee7316d826517480ee7896c91dad941f3 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 31 Oct 2023 17:09:04 +0200
Subject: [PATCH 1/8] Add \/../include/c++/v1 to include path
On macOS, when clang
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/70559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -308,6 +308,11 @@ Changes in existing checks
` check to avoid false positive
when
using pointer to member function.
+- Improved :doc:`misc-const-correctness
PiotrZSL wrote:
there is already entry for this check, just merge changes.
https://github.com/PiotrZSL approved this pull request.
Description for a change (commit / PR) needed.
Except that looks fine.
https://github.com/llvm/llvm-project/pull/72068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -412,6 +412,10 @@ Changes in existing checks
do-while loops into account for the `AllowIntegerConditions` and
`AllowPointerConditions` options.
+- Improved :doc:`readability-implicit-bool-conversion
PiotrZSL wrote:
merge release notes, one entry for a
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/70817
>From 7fbc229ee7316d826517480ee7896c91dad941f3 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 31 Oct 2023 17:09:04 +0200
Subject: [PATCH 1/7] Add \/../include/c++/v1 to include path
On macOS, when clang
michael-kenzel wrote:
> I would assume this is already transformed to memcpy but I guess it won't be
> for -O0
[I did some testing on this](https://godbolt.org/z/YMEjbxYd9): it seems that
gcc replaces the `strcpy` with a simple `mov` even under `-O0`, but not the
`memcpy`. clang does the
5chmidti wrote:
> In tests we usually use `-fno-delayed-template-parsing` to overcome this
> issue with templates and windows.
Done. I changed the test in `ExprMutationAnalyzerTest.cpp` to use the flag,
`const-correctness-templates.cpp` already had it, and I changed the tested code
back to
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/70817
>From 7fbc229ee7316d826517480ee7896c91dad941f3 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 31 Oct 2023 17:09:04 +0200
Subject: [PATCH 1/6] Add \/../include/c++/v1 to include path
On macOS, when clang
5chmidti wrote:
Could someone please reapply the `clang` label to trigger the pr subscriber
action?
https://github.com/llvm/llvm-project/pull/71245
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/5chmidti updated
https://github.com/llvm/llvm-project/pull/70559
>From b29eb35fe8597ceefc4c615817174181a16f3c4c Mon Sep 17 00:00:00 2001
From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com>
Date: Sat, 28 Oct 2023 18:08:51 +0200
Subject: [PATCH 1/4] [clang-tidy]
firewave wrote:
> Hi @firewave, I think you are referencing a different issue. If I test #71852
> with PR #72050 I do not get the expected behavior.
Of course you are right. I missed there being two different issues. Sorry about
the noise.
https://github.com/llvm/llvm-project/pull/72068
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/70817
>From 7fbc229ee7316d826517480ee7896c91dad941f3 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 31 Oct 2023 17:09:04 +0200
Subject: [PATCH 1/5] Add \/../include/c++/v1 to include path
On macOS, when clang
felix642 wrote:
Hi @firewave, I think you are referencing a different issue. If I test #71852
with PR #72050 I do not get the expected behavior.
https://github.com/llvm/llvm-project/pull/72068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
firewave wrote:
Another PR for this was opened a few hours ago: #71848.
https://github.com/llvm/llvm-project/pull/72068
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/felix642 updated
https://github.com/llvm/llvm-project/pull/72068
From 649c7b8b936d848100b58e733dd358fa1d5914fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?F=C3=A9lix-Antoine=20Constantin?=
Date: Sun, 12 Nov 2023 16:07:13 -0500
Subject: [PATCH] [clang-tidy] Improved
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4c3206c5d5dee9dc3c7ad32c09d57a7fc592bcea
54743ceec9845cdc450d5c163a293e73884a8df9 --
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Félix-Antoine Constantin (felix642)
Changes
Fixes #71852
---
Full diff: https://github.com/llvm/llvm-project/pull/72068.diff
3 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/readability/ImplicitBoolConversionCheck.cpp
1 - 100 of 130 matches
Mail list logo
