[flang] [clang-tools-extra] [compiler-rt] [llvm] [clang] [Legalizer] Expand fmaximum and fminimum (PR #67301)

2023-12-11 Thread Craig Topper via cfe-commits
topperc wrote: > LGTM. It will be great if you could add RISCV test too, but please don't let > this block you. RISC-V uses custom lowering. We should already have tests. https://github.com/llvm/llvm-project/pull/67301 ___ cfe-commits mailing list cf

[flang] [clang-tools-extra] [compiler-rt] [llvm] [clang] [Legalizer] Expand fmaximum and fminimum (PR #67301)

2023-12-11 Thread Craig Topper via cfe-commits
@@ -8262,6 +8262,64 @@ SDValue TargetLowering::expandFMINNUM_FMAXNUM(SDNode *Node, return SDValue(); } +SDValue TargetLowering::expandFMINIMUM_FMAXIMUM(SDNode *N, +SelectionDAG &DAG) const { + SDLoc DL(N); + SDValue LHS = N-

[clang] [clang] Add size filter for stack auto init (PR #74777)

2023-12-11 Thread Vitaly Buka via cfe-commits
@@ -656,6 +656,13 @@ def err_drv_trivial_auto_var_init_stop_after_missing_dependency : Error< def err_drv_trivial_auto_var_init_stop_after_invalid_value : Error< "'-ftrivial-auto-var-init-stop-after=*' only accepts positive integers">; +def err_drv_trivial_auto_var_init_siz

[clang] [clang] Add size filter for stack auto init (PR #74777)

2023-12-11 Thread Vitaly Buka via cfe-commits
@@ -656,6 +656,13 @@ def err_drv_trivial_auto_var_init_stop_after_missing_dependency : Error< def err_drv_trivial_auto_var_init_stop_after_invalid_value : Error< "'-ftrivial-auto-var-init-stop-after=*' only accepts positive integers">; +def err_drv_trivial_auto_var_init_siz

[clang] [compiler-rt] [llvm] [clang-tools-extra] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,115 @@ +// This is a regression test for ThinLTO indirect-call-promotion when candidate +// callees need to be imported from another IR module. In the C++ test case, +// `main` calls `global_func` which is defined in another module. `global_func` +// has two indirect c

[clang-tools-extra] [llvm] LLVM is not needed for chapter two. (PR #69823)

2023-12-11 Thread via cfe-commits
https://github.com/gonsolo updated https://github.com/llvm/llvm-project/pull/69823 >From 7a8e793c0017ee98584d1c29bdc511cc878d2899 Mon Sep 17 00:00:00 2001 From: Gon Solo Date: Sat, 21 Oct 2023 11:16:07 +0200 Subject: [PATCH] LLVM is not needed for chapter two. --- llvm/docs/tutorial/MyFirstLa

[compiler-rt] [flang] [clang-tools-extra] [clang] [llvm] [Legalizer] Expand fmaximum and fminimum (PR #67301)

2023-12-11 Thread Min-Yih Hsu via cfe-commits
@@ -523,9 +523,10 @@ RISCVTargetLowering::RISCVTargetLowering(const TargetMachine &TM, setOperationAction(ISD::FP_TO_FP16, MVT::f32, Custom); setOperationAction(ISD::FP16_TO_FP, MVT::f32, Custom); -if (Subtarget.hasStdExtZfa()) +if (Subtarget.hasStdExtZfa()) {

[flang] [clang-tools-extra] [compiler-rt] [llvm] [clang] [Legalizer] Expand fmaximum and fminimum (PR #67301)

2023-12-11 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave edited https://github.com/llvm/llvm-project/pull/67301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [flang] [compiler-rt] [Legalizer] Expand fmaximum and fminimum (PR #67301)

2023-12-11 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave approved this pull request. LGTM. It will be great if you could add RISCV test too, but please don't let this block you. https://github.com/llvm/llvm-project/pull/67301 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [Clang][Sema] Check the number of lambda non-concept tempate parameters (PR #74885)

2023-12-11 Thread via cfe-commits
https://github.com/knightXun closed https://github.com/llvm/llvm-project/pull/74885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][Clang] Force use of `num_teams` and `thread_limit` for bare kernel (PR #68373)

2023-12-11 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/68373 >From ef3d7309feb1fcedb27f10bd11273eeb08ebf7aa Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Mon, 11 Dec 2023 19:25:01 -0500 Subject: [PATCH] [OpenMP][Clang] Force use of `num_teams` and `thread_limit` for b

[llvm] [lldb] [clang-tools-extra] [compiler-rt] [flang] [clang] [mlir] [Profile] Add binary profile correlation for code coverage. (PR #69493)

2023-12-11 Thread Fangrui Song via cfe-commits
MaskRay wrote: We have this team: @llvm/pr-subscribers-pgo https://github.com/llvm/llvm-project/pull/69493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/74790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-11 Thread Fangrui Song via cfe-commits
@@ -611,3 +611,9 @@ // CHECK-INT-OBJEMITTER-NOT: unsupported option '-fintegrated-objemitter' for target // RUN: not %clang -### -fno-integrated-objemitter --target=x86_64 %s 2>&1 | FileCheck -check-prefix=CHECK-NOINT-OBJEMITTER %s // CHECK-NOINT-OBJEMITTER: unsupported optio

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/74790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-11 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. > And it's a pretty straightforward extension to support (it just slightly > modifies IR generation), so I don't think there's much long-term support > burden. I find that compelling, but make sure others' concerns are addressed. https://gith

[flang] [lldb] [llvm] [clang-tools-extra] [compiler-rt] [mlir] [clang] [Profile] Add binary profile correlation for code coverage. (PR #69493)

2023-12-11 Thread David Li via cfe-commits
david-xl wrote: > @david-xl , Zequan posted an > [RFC](https://discourse.llvm.org/t/rfc-add-binary-profile-correlation-to-not-load-profile-metadata-sections-into-memory-at-runtime/74565/8) > for this. Is there a PGO tag, or something we can use to increase visibility > for PGO reviewers? I thi

[llvm] [clang] [clang-tools-extra] [compiler-rt] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,97 @@ +// This is a regression test for ThinLTO indirect-call-promotion when candidate +// callees need to be imported from another IR module. In the C++ test case, +// `main` calls `global_func` which is defined in another module. `global_func` +// has two indirect ca

[compiler-rt] [llvm] [clang] [clang-tools-extra] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -147,6 +147,9 @@ def exclude_unsupported_files_for_aix(dirname): config.substitutions.append( ("%clang_pgouse=", build_invocation(clang_cflags) + " -fprofile-use=") ) +config.substitutions.append( +("%clangxx_pgouse=", build_invocation(clang_cxxflags) + " -fprofile-u

[clang] [clang][Driver] Support -fms-volatile as equivalent to /volatile:ms (PR #74790)

2023-12-11 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I got a request for this feature from a user that ran into issues porting code from cl to clang for a baremetal target. I expect scenarios like that to continue to be relevant for a while. I don't expect anyone would want to use this for new code because current practice

[clang] 863b938 - [clang] Remove stale release note

2023-12-11 Thread Shoaib Meenai via cfe-commits
Author: Shoaib Meenai Date: 2023-12-11T15:37:49-08:00 New Revision: 863b9388687d01c67de1248e48cee0df698515c0 URL: https://github.com/llvm/llvm-project/commit/863b9388687d01c67de1248e48cee0df698515c0 DIFF: https://github.com/llvm/llvm-project/commit/863b9388687d01c67de1248e48cee0df698515c0.diff

[compiler-rt] [clang-tools-extra] [llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,97 @@ +// This is a regression test for ThinLTO indirect-call-promotion when candidate +// callees need to be imported from another IR module. In the C++ test case, +// `main` calls `global_func` which is defined in another module. `global_func` +// has two indirect ca

[llvm] [clang] [Clang][SVE2.1] Add floating-point variants of `svrevd_XX` (PR #75117)

2023-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Momchil Velikov (momchil-velikov) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/75117.diff 4 Files Affected: - (modified) clang/include/clang/Basic/arm_sve.td (+2-2) - (modified) clang/test/CodeGen/aarch64-sve2-intr

[llvm] [clang] [Clang][SVE2.1] Add floating-point variants of `svrevd_XX` (PR #75117)

2023-12-11 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov created https://github.com/llvm/llvm-project/pull/75117 None >From 4fe606a2cf764ae4281789727d241c91c3cb9c39 Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Mon, 11 Dec 2023 23:25:07 + Subject: [PATCH] [Clang][SVE2.1] Add floating-point variants of `s

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

2023-12-11 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/75116 >From a3971a65e7c7297295a6db154360c205a254c708 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH] [clangd] Add test for GH75115 Add test for https://github.com

[compiler-rt] [clang-tools-extra] [llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Fangrui Song via cfe-commits
@@ -147,6 +147,9 @@ def exclude_unsupported_files_for_aix(dirname): config.substitutions.append( ("%clang_pgouse=", build_invocation(clang_cflags) + " -fprofile-use=") ) +config.substitutions.append( +("%clangxx_pgouse=", build_invocation(clang_cxxflags) + " -fprofile-u

[clang] [NFC][CLANG] Fix static analyzer bugs about large copy by values (PR #75060)

2023-12-11 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. https://github.com/llvm/llvm-project/pull/75060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CLANG] Fix static analyzer bugs about large copy by values (PR #75060)

2023-12-11 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: Thanks for catching these! I wonder what would it take to delete the copy constructors on these classes, so that these mistakes are never made again. https://github.com/llvm/llvm-project/pull/75060 ___ cfe-commits mailing list cfe-commi

[clang] [Sema] atomic_compare_exchange: check failure memory order (PR #74959)

2023-12-11 Thread Fangrui Song via cfe-commits
@@ -8728,7 +8728,13 @@ def err_atomic_op_needs_atomic_int : Error< "%select{|atomic }0integer (%1 invalid)">; def warn_atomic_op_has_invalid_memory_order : Warning< "memory order argument to atomic operation is invalid">, - InGroup>; + InGroup; +def warn_atomic_op_has_inv

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 81d1df2 - [SpecialCaseList] Use glob by default (#74809)

2023-12-11 Thread via cfe-commits
Author: Fangrui Song Date: 2023-12-11T15:30:28-08:00 New Revision: 81d1df2a39f0616be4b530cbf86b3f575442a347 URL: https://github.com/llvm/llvm-project/commit/81d1df2a39f0616be4b530cbf86b3f575442a347 DIFF: https://github.com/llvm/llvm-project/commit/81d1df2a39f0616be4b530cbf86b3f575442a347.diff

[llvm] [clang] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/74809 >From 4aba7a65213971887db7432911e7743365f4f417 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 7 Dec 2023 21:17:24 -0800 Subject: [PATCH 1/2] [SpecialCaseList] Use glob by default https://reviews.llvm.org

[compiler-rt] [clang-tools-extra] [llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,97 @@ +// This is a regression test for ThinLTO indirect-call-promotion when candidate +// callees need to be imported from another IR module. In the C++ test case, +// `main` calls `global_func` which is defined in another module. `global_func` +// has two indirect ca

[clang] [compiler-rt] [clang-tools-extra] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -1,39 +0,0 @@ -; Do setup work for all below tests: generate bitcode and combined index minglotus-6 wrote: this is a valid point. Add the test back (in the new commit), use `rm -rf %t && split-file %s %t && cd %t` on IR and apply the `trap-on-exit` clean-up o

[compiler-rt] [clang-tools-extra] [llvm] [clang] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,97 @@ +// This is a regression test for ThinLTO indirect-call-promotion when candidate +// callees need to be imported from another IR module. In the C++ test case, +// `main` calls `global_func` which is defined in another module. `global_func` +// has two indirect ca

[llvm] [clang-tools-extra] [clang] [compiler-rt] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,97 @@ +// This is a regression test for ThinLTO indirect-call-promotion when candidate +// callees need to be imported from another IR module. In the C++ test case, +// `main` calls `global_func` which is defined in another module. `global_func` +// has two indirect ca

[clang] [compiler-rt] [clang-tools-extra] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -41,6 +41,10 @@ namespace Intrinsic { typedef unsigned ID; } // end namespace Intrinsic +// Choose ';' as the delimiter. ':' was used once but it doesn't work well for +// Objective-C functions which commonly have :'s in their names minglotus-6 wrote: done

[compiler-rt] [llvm] [clang] [clang-tools-extra] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -147,6 +147,9 @@ def exclude_unsupported_files_for_aix(dirname): config.substitutions.append( ("%clang_pgouse=", build_invocation(clang_cflags) + " -fprofile-use=") ) +config.substitutions.append( +("%clangxx_pgouse=", build_invocation(clang_cxxflags) + " -fprofile-u

[clang-tools-extra] [clang] [llvm] [compiler-rt] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,97 @@ +// This is a regression test for ThinLTO indirect-call-promotion when candidate +// callees need to be imported from another IR module. In the C++ test case, +// `main` calls `global_func` which is defined in another module. `global_func` +// has two indirect ca

[clang-tools-extra] [clang] [llvm] [compiler-rt] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -144,25 +145,27 @@ void GlobalObject::copyAttributesFrom(const GlobalObject *Src) { std::string GlobalValue::getGlobalIdentifier(StringRef Name, GlobalValue::LinkageTypes Linkage, Stri

[clang] [clang-tools-extra] [compiler-rt] [llvm] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
@@ -0,0 +1,97 @@ +// This is a regression test for ThinLTO indirect-call-promotion when candidate +// callees need to be imported from another IR module. In the C++ test case, +// `main` calls `global_func` which is defined in another module. `global_func` +// has two indirect ca

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

2023-12-11 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/75116 >From f3c8adf8b08369ba2e90e237957d4205526f64e1 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH] [clangd] Add test for GH75115 Add test for https://github.com

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

2023-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Matheus Izvekov (mizvekov) Changes Add test for https://github.com/llvm/llvm-project/issues/75115 --- Full diff: https://github.com/llvm/llvm-project/pull/75116.diff 1 Files Affected: - (added) clang-tools-extra/clangd/test/GH75115.tes

[clang-tools-extra] [clangd] Add test for GH75115 (PR #75116)

2023-12-11 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/75116 Add test for https://github.com/llvm/llvm-project/issues/75115 >From bd01b0d71c05fa7d728b6db08d14d51fe332ae2c Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 11 Dec 2023 17:36:44 -0300 Subject: [PATCH

[clang] [NFC][CLANG] Fix static analyzer bugs about large copy by values (PR #75060)

2023-12-11 Thread via cfe-commits
smanna12 wrote: > Could you also update the description of the patch? Done. Thank you @Xazax-hun for reviews! https://github.com/llvm/llvm-project/pull/75060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [NFC][CLANG] Fix static analyzer bugs about large copy by values (PR #75060)

2023-12-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/75060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] atomic_compare_exchange: check failure memory order (PR #74959)

2023-12-11 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/74959 >From 56a63cd9f910dc78163adda15252e7818cc7a419 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sat, 9 Dec 2023 16:37:51 -0800 Subject: [PATCH 1/2] [Sema] atomic_compare_exchange: check failure memory order Fo

[clang] [NFC][CLANG] Fix static analyzer bugs about large copy by values (PR #75060)

2023-12-11 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: Could you also update the description of the patch? https://github.com/llvm/llvm-project/pull/75060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CLANG] Fix static analyzer bugs about large copy by values (PR #75060)

2023-12-11 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/75060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DebugInfo] Fix duplicate DIFile when main file is preprocessed (PR #75022)

2023-12-11 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. Sounds good to me, thanks! https://github.com/llvm/llvm-project/pull/75022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-11 Thread Jan Svoboda via cfe-commits
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction Preprocessor::HandleHeaderIncludeOrImport( // The drive letter is optional for absolute paths on Windows, but // clang currently cannot process absolute paths in #include lines that // don't have a driv

[clang] [-Wunsafe-buffer-usage] Add FixableGadget for AddAssign in UnspecifiedUntypedContext (PR #71862)

2023-12-11 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud closed https://github.com/llvm/llvm-project/pull/71862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e1655a9 - [-Wunsafe-buffer-usage] Add FixableGadget for AddAssign in UnspecifiedUntypedContext (#71862)

2023-12-11 Thread via cfe-commits
Author: Rashmi Mudduluru Date: 2023-12-11T15:00:08-08:00 New Revision: e1655a98cb9c098fa941ed199664927ba8a4b031 URL: https://github.com/llvm/llvm-project/commit/e1655a98cb9c098fa941ed199664927ba8a4b031 DIFF: https://github.com/llvm/llvm-project/commit/e1655a98cb9c098fa941ed199664927ba8a4b031.di

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/74782 >From 6ab18edae7b86ca216848b7fcaff5e58fb3e186c Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 7 Dec 2023 15:15:16 -0800 Subject: [PATCH 1/6] [clang][lex] Fix non-portability diagnostics with absolute

[clang] [llvm] [clang] NFC: Remove `{File, Directory}Entry::getName()` (PR #74910)

2023-12-11 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/74910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [clang] [llvm] [compiler-rt] [lldb] [openmp] [mlir] [lld] [libc] [libcxx] fix issue 73559. (PR #74926)

2023-12-11 Thread via cfe-commits
ChipsSpectre wrote: The pull request is updated now, and passing tests and formatting checks. Is it ready to be merged in its new state? https://github.com/llvm/llvm-project/pull/74926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [llvm] [clang] NFC: Remove `{File, Directory}Entry::getName()` (PR #74910)

2023-12-11 Thread Duncan P . N . Exon Smith via cfe-commits
https://github.com/dexonsmith approved this pull request. Amazing! LGTM, once the branch is clear. https://github.com/llvm/llvm-project/pull/74910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [llvm] [clang] NFC: Remove `{File, Directory}Entry::getName()` (PR #74910)

2023-12-11 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Note: I'd like to merge this PR after we branch off for Clang 18 in January or February 2024. I had the patch lying around, so I figured I might as well create the PR. https://github.com/llvm/llvm-project/pull/74910 ___ cfe-commit

[llvm] [clang] [clang] NFC: Remove `{File, Directory}Entry::getName()` (PR #74910)

2023-12-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/74910 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [clang] [llvm] [compiler-rt] [lldb] [openmp] [mlir] [lld] [libc] [libcxx] fix issue 73559. (PR #74926)

2023-12-11 Thread via cfe-commits
https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 8269060e6b50721a847742ff8d0af2c819e52578 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sat, 9 Dec 2023 12:07:02 +0100 Subject: [PATCH 1/4] fix issue 73559. --- clang/lib/Parse/ParseDecl.cpp|

[clang] [llvm] [SpecialCaseList] Use glob by default (PR #74809)

2023-12-11 Thread David Blaikie via cfe-commits
dwblaikie wrote: Still seems like an unfortunate and subtle silent change in behavior to me. But *shrug* if folks who own these features think it's fine, so be it. https://github.com/llvm/llvm-project/pull/74809 ___ cfe-commits mailing list cfe-commit

[clang-tools-extra] [clang] [llvm] [compiler-rt] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/74008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [compiler-rt] [PGO][GlobalValue][LTO]In GlobalValues::getGlobalIdentifier, use semicolon as delimiter for local-linkage varibles. (PR #74008)

2023-12-11 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/74008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][NFC] Remove redundant function call (PR #75076)

2023-12-11 Thread Gábor Spaits via cfe-commits
https://github.com/spaits updated https://github.com/llvm/llvm-project/pull/75076 From f3d7181073996dd94e6d0b7ac403e9a3d97f4e0d Mon Sep 17 00:00:00 2001 From: Gabor Spaits Date: Mon, 11 Dec 2023 16:59:16 +0100 Subject: [PATCH 1/3] [Analyzer][NFC] Remove redundant function call PRValueHandler's

[compiler-rt] [clang] [flang] [clang-tools-extra] [mlir] [lldb] [llvm] [Profile] Add binary profile correlation for code coverage. (PR #69493)

2023-12-11 Thread Reid Kleckner via cfe-commits
rnk wrote: @david-xl , Zequan posted an [RFC](https://discourse.llvm.org/t/rfc-add-binary-profile-correlation-to-not-load-profile-metadata-sections-into-memory-at-runtime/74565/8) for this. Is there a PGO tag, or something we can use to increase visibility for PGO reviewers? I think most of th

[clang] [Analyzer][NFC] Remove redundant function call (PR #75076)

2023-12-11 Thread via cfe-commits
@@ -2565,21 +2565,24 @@ class PRValueHandler final : public ExpressionHandler { using ExpressionHandler::ExpressionHandler; Tracker::Result handle(const Expr *E, const ExplodedNode *InputNode, - const ExplodedNode *ExprNode, +

[clang] [Analyzer][NFC] Remove redundant function call (PR #75076)

2023-12-11 Thread via cfe-commits
isuckatcs wrote: > Consider downstream users that might use this reporting system and have their > own trackers. (We don't at Sonar, but pretend), then they would need to > remove one more unjust assert. This is also a fair point, though as far as I know, LLVM doesn't keep API compatibility e

[clang] [Clang][SVE2.1] Add intrinsics for `WHILEcc` resulting in predicate pair (PR #75107)

2023-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Momchil Velikov (momchil-velikov) Changes Add intrinsics of the form: svboolx2_t svwhile_b{8,16,32,64}_[{s,u}64]_x2([u]int64_t, [u]int64_t); and their overloaded variants as specified in https://github.com/ARM-software/acle/pul

[clang] [clang][lex] Fix non-portability diagnostics with absolute path (PR #74782)

2023-12-11 Thread Steven Wu via cfe-commits
@@ -2466,15 +2466,21 @@ Preprocessor::ImportAction Preprocessor::HandleHeaderIncludeOrImport( // The drive letter is optional for absolute paths on Windows, but // clang currently cannot process absolute paths in #include lines that // don't have a driv

[llvm] [clang] [clang-tools-extra] [X86] Use plain load/store instead of cmpxchg16b for atomics with AVX (PR #74275)

2023-12-11 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/74275 >From 7baffd6d1f4254b1bd725ddc883a360d79267435 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Sat, 2 Dec 2023 23:05:26 -0500 Subject: [PATCH 1/2] [X86] Use plain load/store instead of cmpxchg16b for atomic

[compiler-rt] [llvm] [lld] [clang] [flang] [libc] [openmp] [clang-tools-extra] [libcxx] [lldb] [mlir] fix issue 73559. (PR #74926)

2023-12-11 Thread via cfe-commits
https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 8269060e6b50721a847742ff8d0af2c819e52578 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sat, 9 Dec 2023 12:07:02 +0100 Subject: [PATCH 1/3] fix issue 73559. --- clang/lib/Parse/ParseDecl.cpp|

[compiler-rt] [llvm] [lld] [clang] [flang] [libc] [openmp] [clang-tools-extra] [libcxx] [lldb] [mlir] fix issue 73559. (PR #74926)

2023-12-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f92d970c8cc27747478abb7df66bb8b6701cea49 e8419c3750f7b1cf877b042942204abaab48344b --

[compiler-rt] [llvm] [lld] [clang] [flang] [libc] [openmp] [clang-tools-extra] [libcxx] [lldb] [mlir] fix issue 73559. (PR #74926)

2023-12-11 Thread via cfe-commits
https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 8269060e6b50721a847742ff8d0af2c819e52578 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sat, 9 Dec 2023 12:07:02 +0100 Subject: [PATCH 1/2] fix issue 73559. --- clang/lib/Parse/ParseDecl.cpp|

[compiler-rt] [llvm] [lld] [clang] [flang] [libc] [clang-tools-extra] [libcxx] [lldb] fix issue 73559. (PR #74926)

2023-12-11 Thread via cfe-commits
https://github.com/ChipsSpectre updated https://github.com/llvm/llvm-project/pull/74926 >From 8269060e6b50721a847742ff8d0af2c819e52578 Mon Sep 17 00:00:00 2001 From: ChipsSpectre Date: Sat, 9 Dec 2023 12:07:02 +0100 Subject: [PATCH 1/2] fix issue 73559. --- clang/lib/Parse/ParseDecl.cpp|

[clang] [Sema] atomic_compare_exchange: check failure memory order (PR #74959)

2023-12-11 Thread James Y Knight via cfe-commits
@@ -8728,7 +8728,13 @@ def err_atomic_op_needs_atomic_int : Error< "%select{|atomic }0integer (%1 invalid)">; def warn_atomic_op_has_invalid_memory_order : Warning< "memory order argument to atomic operation is invalid">, - InGroup>; + InGroup; +def warn_atomic_op_has_inv

[clang] [Sema] atomic_compare_exchange: check failure memory order (PR #74959)

2023-12-11 Thread James Y Knight via cfe-commits
@@ -8728,7 +8728,13 @@ def err_atomic_op_needs_atomic_int : Error< "%select{|atomic }0integer (%1 invalid)">; def warn_atomic_op_has_invalid_memory_order : Warning< "memory order argument to atomic operation is invalid">, - InGroup>; + InGroup; +def warn_atomic_op_has_inv

[clang] [Sema] atomic_compare_exchange: check failure memory order (PR #74959)

2023-12-11 Thread James Y Knight via cfe-commits
https://github.com/jyknight edited https://github.com/llvm/llvm-project/pull/74959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] atomic_compare_exchange: check failure memory order (PR #74959)

2023-12-11 Thread James Y Knight via cfe-commits
https://github.com/jyknight requested changes to this pull request. https://github.com/llvm/llvm-project/pull/74959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4a11222 - [RISCV] Correct the SEW=64 MUL diagnostic to refer to V as an extension.

2023-12-11 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2023-12-11T12:45:27-08:00 New Revision: 4a11222f50dbe95e61c7cd7ddc2de8b3e87cddd7 URL: https://github.com/llvm/llvm-project/commit/4a11222f50dbe95e61c7cd7ddc2de8b3e87cddd7 DIFF: https://github.com/llvm/llvm-project/commit/4a11222f50dbe95e61c7cd7ddc2de8b3e87cddd7.diff

[clang] 0d44c9f - [RISCV] Shorten diagnostic a bit.

2023-12-11 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2023-12-11T12:45:27-08:00 New Revision: 0d44c9f99a7d9d9444d1656ca52fa0784c711680 URL: https://github.com/llvm/llvm-project/commit/0d44c9f99a7d9d9444d1656ca52fa0784c711680 DIFF: https://github.com/llvm/llvm-project/commit/0d44c9f99a7d9d9444d1656ca52fa0784c711680.diff

[clang] [mlir] [llvm] [AMDGPU] - Add address space for strided buffers (PR #74471)

2023-12-11 Thread Nicolai Hähnle via cfe-commits
https://github.com/nhaehnle approved this pull request. FWIW, this LGTM. Give it another day or two for other feedback. https://github.com/llvm/llvm-project/pull/74471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [mlir] [llvm] [AMDGPU] - Add address space for strided buffers (PR #74471)

2023-12-11 Thread Nicolai Hähnle via cfe-commits
nhaehnle wrote: > 1. Isn't a strided buffer one where the field that's named something like > `stride` (bits 61:48 or 63:48) is non-zero Yes, and one that is meant to use with buffer instructions using `idxen`. > 2. And therefore it uses structured buffers and the > `llvm.struct[.ptr]

[clang] [llvm] [RISCV] Add support for experimental Zimop extension (PR #74824)

2023-12-11 Thread Craig Topper via cfe-commits
topperc wrote: What is the use case for someone to write the maybe ops directly? Wouldn't you program to the extensions built on top of them like Zicfiss? https://github.com/llvm/llvm-project/pull/74824 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2023-12-11 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm updated https://github.com/llvm/llvm-project/pull/75092 >From fe05f64f7ae0decc17d98bb694bbade178df7a4b Mon Sep 17 00:00:00 2001 From: wlei Date: Sun, 10 Dec 2023 18:30:42 -0800 Subject: [PATCH] [PseudoProbe] Mix and reorder block and call probe ID in lexical order

[clang] [AArch64][Clang] Fix linker error for function multiversioning (PR #74358)

2023-12-11 Thread via cfe-commits
@@ -1752,8 +1754,10 @@ static void AppendTargetClonesMangling(const CodeGenModule &CGM, const TargetInfo &TI = CGM.getTarget(); if (TI.getTriple().isAArch64()) { elizabethandrews wrote: Can you please explain why AArch64 needs to be 'specially' handled her

[clang] [NFC][CLANG] Fix static analyzer bugs about large copy by values (PR #75060)

2023-12-11 Thread via cfe-commits
@@ -110,7 +110,7 @@ void ModuleDepCollector::addOutputPaths(CowCompilerInvocation &CI, } static CowCompilerInvocation -makeCommonInvocationForModuleBuild(CompilerInvocation CI) { +makeCommonInvocationForModuleBuild(const CompilerInvocation &CI) { smanna12 wro

[clang] [NFC][CLANG] Fix static analyzer bugs about large copy by values (PR #75060)

2023-12-11 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/75060 >From bd008b0d67bb08ef9414d93720bcb2f024997c0f Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 11 Dec 2023 07:26:40 -0800 Subject: [PATCH 1/2] [NFC][CLANG] Fix static analyzer bugs about large copy by

[clang] 1366221 - [RISCV] Simplify checking whether SEW=64 multiply builtins require V. NFC

2023-12-11 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2023-12-11T12:21:09-08:00 New Revision: 13662211c32cb9034b67d7fe0fb73fdebd15471e URL: https://github.com/llvm/llvm-project/commit/13662211c32cb9034b67d7fe0fb73fdebd15471e DIFF: https://github.com/llvm/llvm-project/commit/13662211c32cb9034b67d7fe0fb73fdebd15471e.diff

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

2023-12-11 Thread Alexey Bataev via cfe-commits
@@ -7485,6 +7485,99 @@ void CodeGenModule::printPostfixForExternalizedDecl(llvm::raw_ostream &OS, } } +namespace { +/// A 'teams loop' with a nested 'loop bind(parallel)' or generic function +/// call in the associated loop-nest cannot be a 'parllel for'. +class TeamsLoopCh

[llvm] [clang] [CUDA] Add support for CUDA-12.3 and sm_90a (PR #74895)

2023-12-11 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B closed https://github.com/llvm/llvm-project/pull/74895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 631c6e8 - [CUDA] Add support for CUDA-12.3 and sm_90a (#74895)

2023-12-11 Thread via cfe-commits
Author: Artem Belevich Date: 2023-12-11T12:18:28-08:00 New Revision: 631c6e834cb07b2769e2c8f1e186dd3a3e0777a1 URL: https://github.com/llvm/llvm-project/commit/631c6e834cb07b2769e2c8f1e186dd3a3e0777a1 DIFF: https://github.com/llvm/llvm-project/commit/631c6e834cb07b2769e2c8f1e186dd3a3e0777a1.diff

[llvm] [clang] [CUDA] Add support for CUDA-12.3 and sm_90a (PR #74895)

2023-12-11 Thread Artem Belevich via cfe-commits
Artem-B wrote: Tested the changes with cuda test-suite, with cuda-12.1 and 12.3 targeting `sm_{60,70,80,90,90a}`. https://github.com/llvm/llvm-project/pull/74895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

2023-12-11 Thread via cfe-commits
@@ -7485,6 +7485,99 @@ void CodeGenModule::printPostfixForExternalizedDecl(llvm::raw_ostream &OS, } } +namespace { +/// A 'teams loop' with a nested 'loop bind(parallel)' or generic function +/// call in the associated loop-nest cannot be a 'parllel for'. +class TeamsLoopCh

[clang] [llvm] [RISCV] Remove experimental from Vector Crypto extensions (PR #74213)

2023-12-11 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/74213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][CodeGen] Improved codegen for combined loop directives (PR #72417)

2023-12-11 Thread Alexey Bataev via cfe-commits
@@ -7485,6 +7485,99 @@ void CodeGenModule::printPostfixForExternalizedDecl(llvm::raw_ostream &OS, } } +namespace { +/// A 'teams loop' with a nested 'loop bind(parallel)' or generic function +/// call in the associated loop-nest cannot be a 'parllel for'. +class TeamsLoopCh

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2023-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-transforms Author: Lei Wang (wlei-llvm) Changes Before all the call probe ids are after block ids, in this change, it mixed the call probe and block probe by reordering them in lexical(line-number) order. For example: `

[clang] [llvm] [PseudoProbe] Mix and reorder block and call probe ID in lexical order (PR #75092)

2023-12-11 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm created https://github.com/llvm/llvm-project/pull/75092 Before all the call probe ids are after block ids, in this change, it mixed the call probe and block probe by reordering them in lexical(line-number) order. For example: ``` main(): BB1 if(...) BB2 foo(..)

[clang] [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign (PR #75091)

2023-12-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (smanna12) Changes This patch adds missing assignment operator to the class which has user-defined copy constructor. --- Full diff: https://github.com/llvm/llvm-project/pull/75091.diff 1 Files Affected: - (modified) clang/utils/Ta

[clang] [NFC][Clang] Fix Static Code Analysis Concerns with copy without assign (PR #75091)

2023-12-11 Thread via cfe-commits
https://github.com/smanna12 created https://github.com/llvm/llvm-project/pull/75091 This patch adds missing assignment operator to the class which has user-defined copy constructor. >From 8772661bda9c93b8bcfeb67f236468c85d1d0253 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 11 Dec

[clang] 1bbf722 - [RISCV] Use getBuiltinVectorTypeInfo to simplify code. NFC

2023-12-11 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2023-12-11T11:58:58-08:00 New Revision: 1bbf7225c1f0dde8c59c8acfc0b54999391df184 URL: https://github.com/llvm/llvm-project/commit/1bbf7225c1f0dde8c59c8acfc0b54999391df184 DIFF: https://github.com/llvm/llvm-project/commit/1bbf7225c1f0dde8c59c8acfc0b54999391df184.diff

<    1   2   3   4   >