[clang] [RISCV] Change required features for Zvfhmin intrinsics from ZvfhminOrZvfh to Zvfhmin (PR #77866)

2024-01-12 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/77866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] f489fb3 - [clangd] Fix sysroot flag handling in CommandMangler to prevent duplicates (#75694)

2024-01-12 Thread via cfe-commits
Author: Kon Date: 2024-01-12T03:11:38-05:00 New Revision: f489fb3d75aaedf6f056113370a8b3b8659b9f17 URL: https://github.com/llvm/llvm-project/commit/f489fb3d75aaedf6f056113370a8b3b8659b9f17 DIFF: https://github.com/llvm/llvm-project/commit/f489fb3d75aaedf6f056113370a8b3b8659b9f17.diff LOG: [cla

[clang-tools-extra] [clangd] Fix sysroot flag handling in CommandMangler to prevent duplicates (PR #75694)

2024-01-12 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/75694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix sysroot flag handling in CommandMangler to prevent duplicates (PR #75694)

2024-01-12 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > Thank you for the review. Since I don't have permission to commit the change, > could you merge this on my behalf? Sure, done. https://github.com/llvm/llvm-project/pull/75694 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [Clang][RISCV][RVV Intrinsic] Fix codegen redundant intrinsic names (PR #77889)

2024-01-12 Thread via cfe-commits
https://github.com/circYuan created https://github.com/llvm/llvm-project/pull/77889 This patch avoids adding redundant vcreate_v intrinsics to the RISCV IntrinsicList. Since vcreate_v uses LFixedLog2LMUL, I believe we can simply set Log2LMUL to the smallest value (-3) to prevent the creation o

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-12 Thread via cfe-commits
https://github.com/martinboehme approved this pull request. Approved with comments https://github.com/llvm/llvm-project/pull/77481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-12 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/77481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-12 Thread via cfe-commits
@@ -138,13 +138,20 @@ struct TypeErasedDataflowAnalysisState { /// dataflow analysis cannot be performed successfully. Otherwise, calls /// `PostVisitCFG` on each CFG element with the final analysis results at that /// program point. +/// +/// `MaxBlockVisits` caps the number o

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-12 Thread via cfe-commits
@@ -186,6 +186,14 @@ template struct DataflowAnalysisState { /// the dataflow analysis cannot be performed successfully. Otherwise, calls /// `PostVisitCFG` on each CFG element with the final analysis results at that /// program point. +/// +/// `MaxBlockVisits` caps the numbe

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-12 Thread via cfe-commits
@@ -186,6 +186,14 @@ template struct DataflowAnalysisState { /// the dataflow analysis cannot be performed successfully. Otherwise, calls /// `PostVisitCFG` on each CFG element with the final analysis results at that /// program point. +/// +/// `MaxBlockVisits` caps the numbe

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-12 Thread via cfe-commits
@@ -261,14 +270,23 @@ auto createAnalysis(ASTContext &ASTCtx, Environment &Env) /// iterations. /// - This limit is still low enough to keep runtimes acceptable (on typical /// machines) in cases where we hit the limit. +/// +/// `MaxBlockVisits` caps the number of block vi

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-12 Thread via cfe-commits
@@ -138,13 +138,20 @@ struct TypeErasedDataflowAnalysisState { /// dataflow analysis cannot be performed successfully. Otherwise, calls /// `PostVisitCFG` on each CFG element with the final analysis results at that /// program point. +/// +/// `MaxBlockVisits` caps the number o

[clang] [Clang][RISCV][RVV Intrinsic] Fix codegen redundant intrinsic names (PR #77889)

2024-01-12 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [Clang][RISCV][RVV Intrinsic] Fix codegen redundant intrinsic names (PR #77889)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: 袁銓嶽 (circYuan) Changes This patch avoids adding redundant vcreate_v intrinsics to the RISCV IntrinsicList. Since vcreate_v uses LFixedLog2LMUL, I believe we can simply set Log2LMUL to the smallest value (-3) to prevent the creation of red

[clang] [Clang][RISCV][RVV Intrinsic] Fix codegen redundant intrinsic names (PR #77889)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: 袁銓嶽 (circYuan) Changes This patch avoids adding redundant vcreate_v intrinsics to the RISCV IntrinsicList. Since vcreate_v uses LFixedLog2LMUL, I believe we can simply set Log2LMUL to the smallest value (-3) to prevent the creati

[clang] [clang] WIP: Implement CTAD for type alias template. (PR #77890)

2024-01-12 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/77890 Fixes #54051 This is a preliminary, WIP and messy implementation. While it is still missing many pieces (see FIXMEs), it works for simple cases. CC @ilya-biryukov, @sam-mccall , @usx95 >From ccf08bb5e209c98bd

[clang-tools-extra] dabc901 - [clangd] Use starts_with instead of startswith in CompileCommands.cpp (NFC)

2024-01-12 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-01-12T16:18:14+08:00 New Revision: dabc9018ee856dee672fb1035fd3eb1bb39bd7a6 URL: https://github.com/llvm/llvm-project/commit/dabc9018ee856dee672fb1035fd3eb1bb39bd7a6 DIFF: https://github.com/llvm/llvm-project/commit/dabc9018ee856dee672fb1035fd3eb1bb39bd7a6.diff LOG: [

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

2024-01-12 Thread via cfe-commits
@@ -489,6 +482,31 @@ transferCFGBlock(const CFGBlock &Block, AnalysisContext &AC, } AC.Log.recordState(State); } + + // If we have a terminator, evaluate its condition. + // This `Expr` may not appear as a `CFGElement` anywhere else, and it's + // important that w

[clang] [clang] WIP: Implement CTAD for type alias template. (PR #77890)

2024-01-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 98c6aa72299caeff6b188e1ff2fc1b39c5b893b6 ccf08bb5e209c98bddcb39b28256cd85cecd93cd --

[clang] 537bbb4 - [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (#77750)

2024-01-12 Thread via cfe-commits
Author: martinboehme Date: 2024-01-12T09:20:58+01:00 New Revision: 537bbb4688b021c7eb7045ffd0d5f63087af83c3 URL: https://github.com/llvm/llvm-project/commit/537bbb4688b021c7eb7045ffd0d5f63087af83c3 DIFF: https://github.com/llvm/llvm-project/commit/537bbb4688b021c7eb7045ffd0d5f63087af83c3.diff

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

2024-01-12 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/77750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Add function 'fprintf' to StreamChecker. (PR #77613)

2024-01-12 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/77613 From 96a786f07ca5fb84b372e0b7c60f371bf4cdfd7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 10 Jan 2024 10:55:27 +0100 Subject: [PATCH] [clang][analyzer] Add function 'fprintf' to

[clang] ef156f9 - [clang][dataflow] Remove unused private field 'StmtToEnv' (NFC)

2024-01-12 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-01-12T16:26:00+08:00 New Revision: ef156f91262e960eea5ca93f95dd6111cfa3c5cc URL: https://github.com/llvm/llvm-project/commit/ef156f91262e960eea5ca93f95dd6111cfa3c5cc DIFF: https://github.com/llvm/llvm-project/commit/ef156f91262e960eea5ca93f95dd6111cfa3c5cc.diff LOG: [

[clang] [clang][Interp] Implement IntegralAP::{div, rem} (PR #72614)

2024-01-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/72614 >From 8b657f24c900d9e123a74c76eb3c12c1d34f1a93 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 16 Nov 2023 18:05:17 +0100 Subject: [PATCH] [clang][Interp] Implement IntegralAP::{div, rem}

[clang] [clang][Interp] Implement IntegralAP::{div, rem} (PR #72614)

2024-01-12 Thread Timm Baeder via cfe-commits
@@ -44,6 +44,24 @@ static_assert(MulA * MulB == 50, ""); // ref-error {{not an integral constant ex static_assert(MulA * 5 == 25, ""); static_assert(-1 * MulB == -7, ""); + +constexpr _BitInt(4) DivA = 2; +constexpr _BitInt(2) DivB = 1; +static_assert(DivA / DivB == 2, ""); +

[clang] [llvm] AMDGPU/GFX12: Add new dot4 fp8/bf8 instructions (PR #77892)

2024-01-12 Thread Mariusz Sikora via cfe-commits
https://github.com/mariusz-sikora-at-amd created https://github.com/llvm/llvm-project/pull/77892 Endoding is VOP3P. Tagged as deep/machine learning instructions. i32 type (v4fp8 or v4bf8 packed in i32) is used for src0 and src1. src0 and src1 have no src_modifiers. src2 is f32 and has src_modi

[clang] [llvm] AMDGPU/GFX12: Add new dot4 fp8/bf8 instructions (PR #77892)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Mariusz Sikora (mariusz-sikora-at-amd) Changes Endoding is VOP3P. Tagged as deep/machine learning instructions. i32 type (v4fp8 or v4bf8 packed in i32) is used for src0 and src1. src0 and src1 have no src_modifiers. src2 is f32 a

[clang] c65b939 - [clang-format] SpacesInSquareBrackets not working for Java (#77833)

2024-01-12 Thread via cfe-commits
Author: MyDeveloperDay Date: 2024-01-12T08:30:53Z New Revision: c65b939fb795ce4688d33531341d460a47d16664 URL: https://github.com/llvm/llvm-project/commit/c65b939fb795ce4688d33531341d460a47d16664 DIFF: https://github.com/llvm/llvm-project/commit/c65b939fb795ce4688d33531341d460a47d16664.diff LOG

[lldb] [lld] [openmp] [libcxx] [mlir] [clang] [compiler-rt] [flang] [llvm] [clang-format] SpacesInSquareBrackets not working for Java (PR #77833)

2024-01-12 Thread via cfe-commits
https://github.com/mydeveloperday closed https://github.com/llvm/llvm-project/pull/77833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [lldb] [libc] [lld] [flang] [clang-tools-extra] [libcxx] [clang] [llvm] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-12 Thread Matt Arsenault via cfe-commits
@@ -1183,9 +1228,21 @@ bool SIInsertWaitcnts::generateWaitcntInstBefore(MachineInstr &MI, // No need to wait before load from VMEM to LDS. if (TII->mayWriteLDSThroughDMA(MI)) continue; -unsigned RegNo = SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS; +

[lldb] [libc] [lld] [libcxx] [clang] [compiler-rt] [flang] [clang-tools-extra] [llvm] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-12 Thread Matt Arsenault via cfe-commits
@@ -130,6 +130,8 @@ ; GCN-O0-NEXT:MachineDominator Tree Construction ; GCN-O0-NEXT:Machine Natural Loop Construction ; GCN-O0-NEXT:MachinePostDominator Tree Construction +; GCN-O0-NEXT:Basic Alias Analysis (stateless AA impl) +; GCN-O0-NEXT:

[libc] [clang] [libcxx] [llvm] [clang-tools-extra] [flang] [compiler-rt] [lldb] [lld] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-12 Thread Matt Arsenault via cfe-commits
@@ -703,8 +713,37 @@ void WaitcntBrackets::updateByEvent(const SIInstrInfo *TII, setRegScore(RegNo, T, CurrScore); } } -if (Inst.mayStore() && (TII->isDS(Inst) || mayWriteLDSThroughDMA(Inst))) { - setRegScore(SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS, T, Curr

[llvm] [clang] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-12 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,34 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=i686 < %s | FileCheck %s +; RUN: llc -mtriple=x86_64 < %s | FileCheck %s + +@var = external dso_local global i32, align 4 + +define dso_local void @test() { +; CHEC

[llvm] [clang] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-12 Thread Phoebe Wang via cfe-commits
@@ -56966,6 +56965,17 @@ void X86TargetLowering::LowerAsmOperandForConstraint(SDValue Op, } return; } + case 'W': { +assert(Constraint[1] == 's'); +if (const auto *GA = dyn_cast(Op)) { + Ops.push_back(DAG.getTargetGlobalAddress(GA->getGlobal(), SDLoc(Op

[llvm] [clang] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-12 Thread Phoebe Wang via cfe-commits
@@ -5336,6 +5336,7 @@ X86: operand in a SSE register. If AVX is also enabled, can also be a 256-bit vector operand in an AVX register. If AVX-512 is also enabled, can also be a 512-bit vector operand in an AVX512 register. Otherwise, an error. +- ``Ws``: A symbolic refere

[clang] [clang] Fix crash when compiling error with invalid decl (PR #77893)

2024-01-12 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/77893 `APValue::LValueBase::LValueBase` constructs `ValueDecl` with its canonicalDecl, even though it's invalid. And when obtain its type, it also check all redecls and ignore checking if it's valid. This will cause cr

[clang] [clang] Fix crash when compiling error with invalid decl (PR #77893)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qizhi Hu (jcsxky) Changes `APValue::LValueBase::LValueBase` constructs `ValueDecl` with its canonicalDecl, even though it's invalid. And when obtain its type, it also check all redecls and ignore checking if it's valid. This will cause cr

[clang] [clang][dataflow] Process terminator condition within `transferCFGBlock()`. (PR #77750)

2024-01-12 Thread via cfe-commits
martinboehme wrote: Reverting: Causes build bots to fail because `TerminatorVisitor::StmtToEnv` is now unused. https://github.com/llvm/llvm-project/pull/77750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] Revert "[clang][dataflow] Process terminator condition within `transferCFGBlock()`." (PR #77895)

2024-01-12 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/77895 Reverts llvm/llvm-project#77750 >From 44fbb43480c8779e8164a21dacb4d524d69b0e07 Mon Sep 17 00:00:00 2001 From: martinboehme Date: Fri, 12 Jan 2024 09:53:53 +0100 Subject: [PATCH] Revert "[clang][dataflow] Pr

[clang] 1aacdfe - Revert "[clang][dataflow] Process terminator condition within `transferCFGBlock()`." (#77895)

2024-01-12 Thread via cfe-commits
Author: martinboehme Date: 2024-01-12T09:54:50+01:00 New Revision: 1aacdfe473276ad631db773310fe167ec93fb764 URL: https://github.com/llvm/llvm-project/commit/1aacdfe473276ad631db773310fe167ec93fb764 DIFF: https://github.com/llvm/llvm-project/commit/1aacdfe473276ad631db773310fe167ec93fb764.diff

[clang] Revert "[clang][dataflow] Process terminator condition within `transferCFGBlock()`." (PR #77895)

2024-01-12 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/77895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][dataflow] Process terminator condition within `transferCFGBlock()`." (PR #77895)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-analysis Author: None (martinboehme) Changes Reverts llvm/llvm-project#77750 --- Full diff: https://github.com/llvm/llvm-project/pull/77895.diff 3 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/TypeEras

[clang] [ObjC]: Make type encoding safe in symbol names (PR #77797)

2024-01-12 Thread David Chisnall via cfe-commits
https://github.com/davidchisnall approved this pull request. https://github.com/llvm/llvm-project/pull/77797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3168192 - [ObjC]: Make type encoding safe in symbol names (#77797)

2024-01-12 Thread via cfe-commits
Author: Frederik Carlier Date: 2024-01-12T09:03:37Z New Revision: 3168192de567815c511e384707a3a5063b81189b URL: https://github.com/llvm/llvm-project/commit/3168192de567815c511e384707a3a5063b81189b DIFF: https://github.com/llvm/llvm-project/commit/3168192de567815c511e384707a3a5063b81189b.diff L

[clang] [ObjC]: Make type encoding safe in symbol names (PR #77797)

2024-01-12 Thread David Chisnall via cfe-commits
https://github.com/davidchisnall closed https://github.com/llvm/llvm-project/pull/77797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix bug in `Value` comparison. (PR #76746)

2024-01-12 Thread via cfe-commits
https://github.com/martinboehme approved this pull request. Sorry for the delay! https://github.com/llvm/llvm-project/pull/76746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-01-12 Thread Henry Linjamäki via cfe-commits
https://github.com/linehill created https://github.com/llvm/llvm-project/pull/77897 Prefer using `llvm-spirv-` tool (i.e. `llvm-spirv-18`) over plain `llvm-spirv`. If the versioned tool is not found in PATH, fall back to use the plain `llvm-spirv`. An issue with the using `llvm-spirv` is that

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-01-12 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-spir-v Author: Henry Linjamäki (linehill) Changes Prefer using `llvm-spirv-` tool (i.e. `llvm-spirv-18`) over plain `llvm-spirv`. If the versioned tool is not found in PATH, fall back to use the pl

[llvm] [clang-tools-extra] LLVM is not needed for chapter two. (PR #69823)

2024-01-12 Thread via cfe-commits
gonsolo wrote: Adding commiters to doc/tutorial since LLVM 17 to get this merged: @Logikable @aemerson @aeubanks @MaskRay @youkaichao @hanickadot https://github.com/llvm/llvm-project/pull/69823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] fbac3b0 - Revert "[clang][dataflow] Remove unused private field 'StmtToEnv' (NFC)"

2024-01-12 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-01-12T17:17:39+08:00 New Revision: fbac3b0db5ff1d409f90219aeb6460ec5d14f19a URL: https://github.com/llvm/llvm-project/commit/fbac3b0db5ff1d409f90219aeb6460ec5d14f19a DIFF: https://github.com/llvm/llvm-project/commit/fbac3b0db5ff1d409f90219aeb6460ec5d14f19a.diff LOG: R

[llvm] [clang-tools-extra] LLVM is not needed for chapter two. (PR #69823)

2024-01-12 Thread via cfe-commits
youkaichao wrote: Hey, anything required from my side? https://github.com/llvm/llvm-project/pull/69823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] WIP: Implement CTAD for type alias template. (PR #77890)

2024-01-12 Thread via cfe-commits
cor3ntin wrote: I'm thrilled to see work in this area. Thanks! Note that Clang 18 is going to branch soon, so this PR is going to target Clang 19. However, because it took a while to stabilize other CTAD related works, i think it might be worth it to try to complete that work early in the Clan

[llvm] [clang] [clang][Driver] Don't ignore -gmodules .gch files (PR #77711)

2024-01-12 Thread via cfe-commits
https://github.com/zmodem approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/77711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang] [clang-tools-extra] [compiler-rt] [llvm] [AArch64][SME] Fix multi vector cvt builtins (PR #77656)

2024-01-12 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau updated https://github.com/llvm/llvm-project/pull/77656 >From 67be98b05d771dabe11af54b69532641fa548fb1 Mon Sep 17 00:00:00 2001 From: Matt Devereau Date: Wed, 10 Jan 2024 17:58:30 + Subject: [PATCH 1/3] [AArch64][SME] Fix multi vector cvt builtins This fixes cv

[clang] a8f83cc - [AArch64][SME] Fix multi vector cvt builtins (#77656)

2024-01-12 Thread via cfe-commits
Author: Matthew Devereau Date: 2024-01-12T09:55:52Z New Revision: a8f83cc1597216821b41c69dcfc8251f73b08848 URL: https://github.com/llvm/llvm-project/commit/a8f83cc1597216821b41c69dcfc8251f73b08848 DIFF: https://github.com/llvm/llvm-project/commit/a8f83cc1597216821b41c69dcfc8251f73b08848.diff L

[flang] [clang] [clang-tools-extra] [compiler-rt] [llvm] [AArch64][SME] Fix multi vector cvt builtins (PR #77656)

2024-01-12 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau closed https://github.com/llvm/llvm-project/pull/77656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][SME2] Fix SME2 mla/mls tests (PR #76711)

2024-01-12 Thread Matthew Devereau via cfe-commits
https://github.com/MDevereau closed https://github.com/llvm/llvm-project/pull/76711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 42fe3bc - [AArch64][SME2] Fix SME2 mla/mls tests (#76711)

2024-01-12 Thread via cfe-commits
Author: Matthew Devereau Date: 2024-01-12T09:56:50Z New Revision: 42fe3bc186b938197b3dfe3bd0445674c33fc5eb URL: https://github.com/llvm/llvm-project/commit/42fe3bc186b938197b3dfe3bd0445674c33fc5eb DIFF: https://github.com/llvm/llvm-project/commit/42fe3bc186b938197b3dfe3bd0445674c33fc5eb.diff L

[llvm] [clang] [AMDGPU] Add GFX12 WMMA and SWMMAC instructions (PR #77795)

2024-01-12 Thread Piotr Sobczak via cfe-commits
@@ -18240,65 +18240,211 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu4_w32: case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu4_w64: case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu8_w32: -

[clang] 4d46721 - [Clang] Revert inintentional changes to cmake committed in 33e5db6e0

2024-01-12 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2024-01-12T10:59:46+01:00 New Revision: 4d467215f162b487381e17b8cb59283af75ca50e URL: https://github.com/llvm/llvm-project/commit/4d467215f162b487381e17b8cb59283af75ca50e DIFF: https://github.com/llvm/llvm-project/commit/4d467215f162b487381e17b8cb59283af75ca50e.diff

[clang-tools-extra] [llvm] [Matrix] Convert column-vector ops feeding dot product to row-vectors. (PR #72647)

2024-01-12 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/72647 >From 3dfe86782806f048b130d46afa6293712919f672 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Fri, 14 Apr 2023 14:33:57 +0100 Subject: [PATCH 1/2] [Matrix] Convert column-vector ops feeding dot product to row-ve

[llvm] [clang] [AMDGPU] Add GFX12 WMMA and SWMMAC instructions (PR #77795)

2024-01-12 Thread Piotr Sobczak via cfe-commits
@@ -18240,65 +18240,211 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu4_w32: case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu4_w64: case AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x16_iu8_w32: -

[clang] [clang] Reapply Handle templated operators with reversed arguments (PR #72213)

2024-01-12 Thread Ilya Biryukov via cfe-commits
@@ -324,6 +324,113 @@ bool x = X() == X(); // expected-warning {{ambiguous}} } } // namespace P2468R2 +namespace GH53954{ +namespace friend_template_1 { +struct P { + template + friend bool operator==(const P&, const T&) { return true; } // expected-note {{candidate}} \ +

[clang] [clang] Reapply Handle templated operators with reversed arguments (PR #72213)

2024-01-12 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/72213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Reapply Handle templated operators with reversed arguments (PR #72213)

2024-01-12 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. I only have minor requests to add a new test and update the release note a bit. Otherwise LGMT https://github.com/llvm/llvm-project/pull/72213 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [clang] Reapply Handle templated operators with reversed arguments (PR #72213)

2024-01-12 Thread Ilya Biryukov via cfe-commits
@@ -37,6 +37,27 @@ These changes are ones which we think may surprise users when upgrading to Clang |release| because of the opportunity they pose for disruption to existing code bases. +- Fix a bug in reversed argument for templated operators. + This breaks code in C++20 wh

[clang] [clang] Reapply Handle templated operators with reversed arguments (PR #72213)

2024-01-12 Thread Ilya Biryukov via cfe-commits
@@ -10088,9 +10088,13 @@ static bool allowAmbiguity(ASTContext &Context, const FunctionDecl *F1, const FunctionDecl *F2) { if (declaresSameEntity(F1, F2)) return true; - if (F1->isTemplateInstantiation() && F2->isTemplateInstantiation() && -

[clang-tools-extra] [llvm] [Matrix] Convert column-vector ops feeding dot product to row-vectors. (PR #72647)

2024-01-12 Thread Florian Hahn via cfe-commits
@@ -1391,7 +1394,26 @@ class LowerMatrixIntrinsics { return TTI.getMemoryOpCost(Instruction::Load, VecTy, Align(1), 0) - N * TTI.getMemoryOpCost(Instruction::Load, EltTy, Align(1), 0); }; -auto LHSCost = GetCostForArg(LHS, LShape.NumColumns); + --

[clang-tools-extra] [clang-tidy] Add readability-redundant-casting check (PR #70595)

2024-01-12 Thread Congcong Cai via cfe-commits
@@ -0,0 +1,242 @@ +//===--- RedundantCastingCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add readability-redundant-casting check (PR #70595)

2024-01-12 Thread Congcong Cai via cfe-commits
@@ -0,0 +1,200 @@ +// RUN: %check_clang_tidy -std=c++11-or-later %s readability-redundant-casting %t +// RUN: %check_clang_tidy -std=c++11-or-later -check-suffix=,MACROS %s readability-redundant-casting %t -- \ +// RUN: -config='{CheckOptions: { readability-redundant-casting.

[clang] [clang][analyzer] Improve modeling of 'fseeko' and 'ftello' in StdLibraryFunctionsChecker (PR #77902)

2024-01-12 Thread Ben Shi via cfe-commits
https://github.com/benshi001 created https://github.com/llvm/llvm-project/pull/77902 None >From 97d753446ffc8eb9c701effb52dd671afc73e1dd Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Fri, 12 Jan 2024 18:17:39 +0800 Subject: [PATCH] [clang][analyzer] Improve modeling of 'fseeko' and 'ftello' in

[clang] [clang][analyzer] Improve modeling of 'fseeko' and 'ftello' in StdLibraryFunctionsChecker (PR #77902)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ben Shi (benshi001) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/77902.diff 2 Files Affected: - (modified) clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp (+9-3) - (modified) clang/test/Analysis/s

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77903)

2024-01-12 Thread via cfe-commits
https://github.com/hstk30-hw created https://github.com/llvm/llvm-project/pull/77903 SizeInBytes of empty structure is 0 in C, while 1 in C++. And empty structure argument of the function is ignored in X86_64 backend.As a result, the value of variable arguments in C++ is incorrect. #77036 >F

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77903)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (hstk30-hw) Changes SizeInBytes of empty structure is 0 in C, while 1 in C++. And empty structure argument of the function is ignored in X86_64 backend.As a result, the value of variable arguments in C++ is incorrect. #77036

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77903)

2024-01-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4d467215f162b487381e17b8cb59283af75ca50e ebb2cdbea5e2c29b52f3bd46d31af105cf395e6d --

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77903)

2024-01-12 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/77903 >From a9e8e956870668f32f7394c949f7c47cf2018dd1 Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 12 Jan 2024 18:24:08 +0800 Subject: [PATCH] [X86_64] fix empty structure vaarg in c++ SizeInBytes of empty

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77903)

2024-01-12 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/77903 >From a9e8e956870668f32f7394c949f7c47cf2018dd1 Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 12 Jan 2024 18:24:08 +0800 Subject: [PATCH 1/2] [X86_64] fix empty structure vaarg in c++ SizeInBytes of e

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77903)

2024-01-12 Thread via cfe-commits
https://github.com/hstk30-hw closed https://github.com/llvm/llvm-project/pull/77903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1807 (PR #77637)

2024-01-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/77637 >From 545ee4900e48b186e1c9fff93dc62a459ee19754 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 10 Jan 2024 20:27:53 +0300 Subject: [PATCH 1/5] [clang] Add test for CWG1807 The test checks that objec

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77907)

2024-01-12 Thread via cfe-commits
https://github.com/hstk30-hw created https://github.com/llvm/llvm-project/pull/77907 SizeInBytes of empty structure is 0 in C, while 1 in C++. And empty structure argument of the function is ignored in X86_64 backend.As a result, the value of variable arguments in C++ is incorrect. fix #77036

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77907)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (hstk30-hw) Changes SizeInBytes of empty structure is 0 in C, while 1 in C++. And empty structure argument of the function is ignored in X86_64 backend.As a result, the value of variable arguments in C++ is incorrect. fix #77036 ---

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77907)

2024-01-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (hstk30-hw) Changes SizeInBytes of empty structure is 0 in C, while 1 in C++. And empty structure argument of the function is ignored in X86_64 backend.As a result, the value of variable arguments in C++ is incorrect. fix #7703

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77907)

2024-01-12 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4d467215f162b487381e17b8cb59283af75ca50e 8e4aa168b2e7b2aa71be7f1c88f940ef141fb77c --

[llvm] [clang] [Clang][IR] add TBAA metadata on pointer, union and array types. (PR #75177)

2024-01-12 Thread Sam James via cfe-commits
thesamesam wrote: > I put union TBAA under the option that is disabled by default. I am also > considering to put pointer TBAA under option too, if it raises enough > concerns too. Let's please file a bug once this is merged so we remember to come back to that. https://github.com/llvm/llvm-pr

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77907)

2024-01-12 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/77907 >From fa84978a2e7d787ff6681e1e239347d0c80f2458 Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 12 Jan 2024 18:24:08 +0800 Subject: [PATCH] [X86_64] fix empty structure vaarg in c++ SizeInBytes of empty

[clang] [Clang][AArch64] Change SME attributes for shared/new/preserved state. (PR #76971)

2024-01-12 Thread Sander de Smalen via cfe-commits
@@ -255,6 +255,22 @@ class AttributeCommonInfo { return SpellingIndex != SpellingNotCalculated; } }; + +enum class KeywordAttributeParseArgumentsKind { None, Optional, Required }; sdesmalen-arm wrote: Done. https://github.com/llvm/llvm-project/pull/7697

[clang] [Clang][AArch64] Change SME attributes for shared/new/preserved state. (PR #76971)

2024-01-12 Thread Sander de Smalen via cfe-commits
@@ -8806,26 +8806,90 @@ static bool MustDelayAttributeArguments(const ParsedAttr &AL) { return false; } +static bool checkArmNewAttrMutualExclusion(Sema &S, const ParsedAttr &AL, + const FunctionProtoType *FPT, +

[clang] [Clang][AArch64] Change SME attributes for shared/new/preserved state. (PR #76971)

2024-01-12 Thread Sander de Smalen via cfe-commits
@@ -6898,13 +6941,18 @@ at the end of the function. }]; } -def ArmSmeNewZADocs : Documentation { +def ArmNewDocs : Documentation { let Category = DocCatArmSmeAttributes; let Content = [{ -The ``__arm_new_za`` keyword applies to function declarations and specifies -that

[clang] [Clang][AArch64] Change SME attributes for shared/new/preserved state. (PR #76971)

2024-01-12 Thread Sander de Smalen via cfe-commits
@@ -1,60 +1,60 @@ // RUN: %clang_cc1 -fsyntax-only -triple aarch64-none-linux-gnu -target-feature +sme -verify=expected,notc2x -Wno-strict-prototypes %s // RUN: %clang_cc1 -fsyntax-only -triple aarch64-none-linux-gnu -target-feature +sme -verify=expected,c2x %s -enum __arm_s

[clang] [Clang][AArch64] Change SME attributes for shared/new/preserved state. (PR #76971)

2024-01-12 Thread Sander de Smalen via cfe-commits
@@ -66,7 +66,7 @@ void test_svzero_mask_za_2(void) __arm_shared_za { // CHECK-CXX-NEXT:tail call void @llvm.aarch64.sme.zero(i32 255) // CHECK-CXX-NEXT:ret void // -void test_svzero_za(void) __arm_shared_za { +void test_svzero_za(void) __arm_inout("za") { --

[clang] [Clang][AArch64] Change SME attributes for shared/new/preserved state. (PR #76971)

2024-01-12 Thread Sander de Smalen via cfe-commits
@@ -30,7 +30,7 @@ // CPP-CHECK-NEXT:tail call void @llvm.aarch64.sme.write.ver.vg2.nxv16i8(i32 0, i32 [[BASE:%.*]], [[TMP0]], [[TMP1]]) // CPP-CHECK-NEXT:ret void // -void test_svwrite_ver_za8_u8_vg2(uint32_t base, svuint8x2_t val) __arm_streaming __arm_shared_za {

[clang] [X86_64] fix empty structure vaarg in c++ (PR #77907)

2024-01-12 Thread via cfe-commits
https://github.com/hstk30-hw updated https://github.com/llvm/llvm-project/pull/77907 >From 63ed15b49cfb87b85c858fe826c6a401a1f052eb Mon Sep 17 00:00:00 2001 From: Longsheng Mou Date: Fri, 12 Jan 2024 18:24:08 +0800 Subject: [PATCH] [X86_64] fix empty structure vaarg in c++ SizeInBytes of empty

[clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-12 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/77816 >From 1883d987b2f83adaef05fdb47ae25c7b06582a64 Mon Sep 17 00:00:00 2001 From: 11happy Date: Fri, 12 Jan 2024 00:02:46 +0530 Subject: [PATCH 1/9] Add readability check to suggest replacement of conditional statem

[clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-12 Thread Bhuminjay Soni via cfe-commits
11happy wrote: Thank you for all the suggestions , I think I have tried to incorporate all of them . https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-12 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/77816 >From 1883d987b2f83adaef05fdb47ae25c7b06582a64 Mon Sep 17 00:00:00 2001 From: 11happy Date: Fri, 12 Jan 2024 00:02:46 +0530 Subject: [PATCH 01/10] Add readability check to suggest replacement of conditional stat

[clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-12 Thread Bhuminjay Soni via cfe-commits
https://github.com/11happy updated https://github.com/llvm/llvm-project/pull/77816 >From 1883d987b2f83adaef05fdb47ae25c7b06582a64 Mon Sep 17 00:00:00 2001 From: 11happy Date: Fri, 12 Jan 2024 00:02:46 +0530 Subject: [PATCH 01/11] Add readability check to suggest replacement of conditional stat

[clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-12 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,27 @@ +// RUN: %check_clang_tidy %s readability-ConditionalToStdMinMax %t + +void foo() { + int value1,value2; + + // CHECK-MESSAGES: :[[@LINE+1]]:3: warning: use std::max instead of < [readability-ConditionalToStdMinMax] + if (value1 < value2) +value1 = value2;

[clang-tools-extra] [clang] [llvm] [flang] [Flang][OpenMP] Avoid default none errors for seq loop indices in par… (PR #76258)

2024-01-12 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan updated https://github.com/llvm/llvm-project/pull/76258 >From 03e611d413cffa6ff7432a8a88db5d6901449f3c Mon Sep 17 00:00:00 2001 From: Kiran Chandramohan Date: Fri, 22 Dec 2023 18:35:00 + Subject: [PATCH] [Flang][OpenMP] Avoid default none errors for seq

[clang-tools-extra] [clang] [llvm] [flang] [Flang][OpenMP] Avoid default none errors for seq loop indices in par… (PR #76258)

2024-01-12 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan ready_for_review https://github.com/llvm/llvm-project/pull/76258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >