[clang] [Clang][Sema] Allow elaborated-type-specifiers that declare member class template explict specializations (PR #78720)

2024-01-19 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/78720 According to [[dcl.type.elab] p2](http://eel.is/c++draft/dcl.type.elab#2): > If an > [elaborated-type-specifier](http://eel.is/c++draft/dcl.type.elab#nt:elaborated-type-specifier) > is the sole constituent

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -342,331 +342,331 @@ let TargetGuard = "sme2" in { // let TargetGuard = "sme2" in { - def SVSMOPA : Inst<"svmopa_za32[_{d}]_m", "viPPdd", "s", MergeNone, "aarch64_sme_smopa_za32", [IsSharedZA, IsStreaming], [ImmCheck<0, ImmCheck0_3>]>; - def SVUSMOPA :

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -136,10 +136,10 @@ defm SVWRITE_ZA128 : ZAWrite<"za128", "csilUcUsUiUlhbfd", "aarch64_sme_writeq", let TargetGuard = "sme" in { def SVZERO_MASK_ZA : SInst<"svzero_mask_za", "vi", "", MergeNone, "aarch64_sme_zero", - [IsOverloadNone,

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -342,331 +342,331 @@ let TargetGuard = "sme2" in { // let TargetGuard = "sme2" in { - def SVSMOPA : Inst<"svmopa_za32[_{d}]_m", "viPPdd", "s", MergeNone, "aarch64_sme_smopa_za32", [IsSharedZA, IsStreaming], [ImmCheck<0, ImmCheck0_3>]>; - def SVUSMOPA :

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -3005,6 +3005,15 @@ enum ArmStreamingType { ArmStreamingOrSVE2p1 }; +enum ArmSMEState : unsigned { + ArmNoState = 0, + + ArmInZA = 0b01, + ArmOutZA = 0b10, + ArmInOutZA = 0b11, + ArmZAMask = 0b11, sdesmalen-arm wrote: I'm not really convinced

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -1720,21 +1720,29 @@ void SVEEmitter::createBuiltinZAState(raw_ostream ) { for (auto *R : RV) createIntrinsic(R, Defs); - std::map> DefsZAState; - - uint64_t IsSharedZAFlag = getEnumValueForFlag("IsSharedZA"); + std::map> IntrinsicsPerState; for (auto : Defs)

[clang] [Clang] Refactor diagnostics for SME builtins. (PR #78258)

2024-01-19 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm updated https://github.com/llvm/llvm-project/pull/78258 >From 545866d530ebeab04384ce85e61a7eb29d343167 Mon Sep 17 00:00:00 2001 From: Sander de Smalen Date: Mon, 15 Jan 2024 16:06:36 + Subject: [PATCH 1/2] [Clang] Refactor diagnostics for SME builtins. The

[llvm] [clang] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-19 Thread via cfe-commits
@@ -1119,6 +1119,14 @@ Windows Support LoongArch Support ^ +- Added a code model attribute for the global variable. The following values heiher wrote: Thanks. https://github.com/llvm/llvm-project/pull/78664

[llvm] [clang] [docs] Add llvm and clang release notes for the global-var code model attribute (PR #78664)

2024-01-19 Thread via cfe-commits
https://github.com/heiher updated https://github.com/llvm/llvm-project/pull/78664 >From ccb95a2f40e94ab773dd8897dd287dba7a38 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Fri, 19 Jan 2024 11:13:39 +0800 Subject: [PATCH 1/3] [docs] Add llvm and clang release notes for the global-var code

[libcxx] [mlir] [llvm] [compiler-rt] [clang] [asan] Enable StackSafetyAnalysis by default (PR #77210)

2024-01-19 Thread Ulrich Weigand via cfe-commits
uweigand wrote: @MaskRay I've done a bit more analysis now, and what seems to be going on is that with stack safety analysis off, this check: ``` char array[len]; assert(!(reinterpret_cast(array) & 31L)); ``` succeeds because the VLA allocation gets instrumented, and therefore the VLA

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

2024-01-19 Thread via cfe-commits
https://github.com/chenshanzhi edited https://github.com/llvm/llvm-project/pull/78716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [lld] [lld][AArch64][ELF][PAC] Support AUTH relocations and AUTH ELF marking (PR #72714)

2024-01-19 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: @MaskRay A kind reminder regarding the PR https://github.com/llvm/llvm-project/pull/72714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Bhuminjay Soni via cfe-commits
11happy wrote: > I found some things that should be addressed. > > @PiotrZSL you had a comment about "improving readability and promoting the > use of standard library functions." in `ReleaseNotes.rst`, I just want to > mention that this sentence is also present in the header and check >

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-19 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From fb05243d0c0c3702b1615239a9337df337ad0c7c Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 01/12] add warning and test ---

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-19 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From fb05243d0c0c3702b1615239a9337df337ad0c7c Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 01/11] add warning and test ---

[clang-tools-extra] [libcxx] [libunwind] [llvm] [libcxxabi] [flang] [libc] [compiler-rt] [lld] [clang] [lldb] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

2024-01-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/78330 >From 8f8917528e30d2ba67f669cfd1a893bc85c21121 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 16 Jan 2024 11:24:03 -0800 Subject: [PATCH 1/5] Fixed a bug in Smith's algorithm and made sure last option

[compiler-rt] [clang-tools-extra] [mlir] [libcxx] [libunwind] [openmp] [libcxxabi] [flang] [libc] [clang] [lld] [llvm] [lldb] [clang] static operators should evaluate object argument (PR #68485)

2024-01-19 Thread via cfe-commits
cor3ntin wrote: @SuperSodaSea I can merge this for you if both @MitalAshok and @shafik are happy with it! https://github.com/llvm/llvm-project/pull/68485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [AMDGPU] Do not emit `V_DOT2C_F32_F16_e32` on GFX12 (PR #78709)

2024-01-19 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/78709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ed12388 - [AMDGPU] Do not emit `V_DOT2C_F32_F16_e32` on GFX12 (#78709)

2024-01-19 Thread via cfe-commits
Author: Jay Foad Date: 2024-01-19T14:36:27Z New Revision: ed123880826cd9a4acdcd05409b1fac4203a436a URL: https://github.com/llvm/llvm-project/commit/ed123880826cd9a4acdcd05409b1fac4203a436a DIFF: https://github.com/llvm/llvm-project/commit/ed123880826cd9a4acdcd05409b1fac4203a436a.diff LOG:

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

2024-01-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shanzhi (chenshanzhi) Changes This crash is basically caused by calling `ASTContext::getRawCommentForDeclNoCacheImp` with its input arguments `RepresentativeLocForDecl` and `CommentsInTheFile` refering to different files. A reduced

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-19 Thread via cfe-commits
https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/78200 >From fb05243d0c0c3702b1615239a9337df337ad0c7c Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Mon, 15 Jan 2024 22:24:34 +0400 Subject: [PATCH 01/10] add warning and test ---

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

2024-01-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang][AST] Fix a crash on attaching doc comments (PR #78716)

2024-01-19 Thread via cfe-commits
https://github.com/chenshanzhi created https://github.com/llvm/llvm-project/pull/78716 This crash is basically caused by calling `ASTContext::getRawCommentForDeclNoCacheImp` with its input arguments `RepresentativeLocForDecl` and `CommentsInTheFile` refering to different files. A reduced

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

2024-01-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/77454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

2024-01-19 Thread Utkarsh Saxena via cfe-commits
@@ -60,6 +61,45 @@ static bool isTrivialDoWhile(const CFGBlock *B, const Stmt *S) { return false; } +// Check if the block starts with a coroutine statement and see if the given +// unreachable 'S' is the substmt of the coroutine statement. +// +// We suppress the

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

2024-01-19 Thread Utkarsh Saxena via cfe-commits
@@ -60,6 +61,45 @@ static bool isTrivialDoWhile(const CFGBlock *B, const Stmt *S) { return false; } +// Check if the block starts with a coroutine statement and see if the given +// unreachable 'S' is the substmt of the coroutine statement. +// +// We suppress the

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

2024-01-19 Thread Utkarsh Saxena via cfe-commits
@@ -0,0 +1,50 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-unknown %s -std=c++20 -fsyntax-only -verify -Wunreachable-code + +#include "Inputs/std-coroutine.h" + +extern void abort (void) __attribute__ ((__noreturn__)); + +struct task { + struct promise_type { +

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

2024-01-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 requested changes to this pull request. This also disables the warning when it was actually correct. See comments. https://github.com/llvm/llvm-project/pull/77454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

2024-01-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/77454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-01-19 Thread via cfe-commits
NagyDonat wrote: I didn't check for potential solutions yet, I wanted to document and report this ASAP and then switch to other tasks. I think I'll leave this commit here without merging it for some time, and if I don't end up resolving this within a month, then I'll find a place for this TC

[clang] [clang-format] Separate License text and include blocks (PR #77918)

2024-01-19 Thread via cfe-commits
https://github.com/seranu updated https://github.com/llvm/llvm-project/pull/77918 >From af4bd7c1a75b1bb17cf4facde2f3caf86f01511e Mon Sep 17 00:00:00 2001 From: Serban Ungureanu Date: Tue, 16 Jan 2024 22:19:52 +0200 Subject: [PATCH] [clang-format] Add formatting options

[clang] [Clang] Fix build with GCC 14 on ARM (PR #78704)

2024-01-19 Thread Nikita Popov via cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/78704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d54dfdd - [Clang] Fix build with GCC 14 on ARM (#78704)

2024-01-19 Thread via cfe-commits
Author: Nikita Popov Date: 2024-01-19T15:19:58+01:00 New Revision: d54dfdd1b53ff72344287d250c2b67329792c840 URL: https://github.com/llvm/llvm-project/commit/d54dfdd1b53ff72344287d250c2b67329792c840 DIFF: https://github.com/llvm/llvm-project/commit/d54dfdd1b53ff72344287d250c2b67329792c840.diff

[compiler-rt] [clang] [llvm] [libc] [clang-tools-extra] [flang] [flang] use setsid to assign the child to prevent zombie as it will be clean up by init process (PR #77944)

2024-01-19 Thread Yi Wu via cfe-commits
https://github.com/yi-wu-arm closed https://github.com/llvm/llvm-project/pull/77944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding support of AMDLIBM vector library (PR #78560)

2024-01-19 Thread Phoebe Wang via cfe-commits
@@ -3190,10 +3190,10 @@ def fno_experimental_isel : Flag<["-"], "fno-experimental-isel">, Group, - Values<"Accelerate,libmvec,MASSV,SVML,SLEEF,Darwin_libsystem_m,ArmPL,none">, + Values<"Accelerate,libmvec,MASSV,SVML,SLEEF,Darwin_libsystem_m,ArmPL,AMDLIBM,none">,

[compiler-rt] [clang] [libcxx] [libcxxabi] [libunwind] [llvm] [lldb] [lld] [libc] [clang-tools-extra] [flang] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

2024-01-19 Thread Zahira Ammarguellat via cfe-commits
@@ -2712,9 +2712,22 @@ static void EmitComplexRangeDiag(const Driver , << EnumComplexRangeToStr(Range1) << EnumComplexRangeToStr(Range2); } -static std::string RenderComplexRangeOption(std::string Range) { +static std::string

[clang] [coroutine] Suppress unreachable-code warning on coroutine statements. (PR #77454)

2024-01-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/77454 >From 3d7d3e5e5bc613637cb019e5e370654e0c58b5cd Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Tue, 9 Jan 2024 12:29:45 +0100 Subject: [PATCH 1/2] [coroutine] Suppress unreachable-code warning on coroutine

[llvm] [clang] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,143 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,143 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,143 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -336,6 +336,7 @@ Clang-Tidy Checks :doc:`portability-restrict-system-includes `, "Yes" :doc:`portability-simd-intrinsics `, :doc:`portability-std-allocator-const `, + :doc:`readability-use-std-min-max `, "Yes" 5chmidti wrote: Sorting, same as

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -224,6 +224,12 @@ New checks Recommends the smallest possible underlying type for an ``enum`` or ``enum`` class based on the range of its enumerators. +- New :doc:`readability-use-std-min-max + ` check. + + Replaces certain conditional statements with equivalent

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,143 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,143 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -56,13 +56,16 @@ #include "UniqueptrDeleteReleaseCheck.h" #include "UppercaseLiteralSuffixCheck.h" #include "UseAnyOfAllOfCheck.h" +#include "UseStdMinMaxCheck.h" namespace clang::tidy { namespace readability { class ReadabilityModule : public ClangTidyModule {

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,143 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,143 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,143 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-19 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti requested changes to this pull request. I found some things that should be addressed. @PiotrZSL you had a comment about "improving readability and promoting the use of standard library functions." in `ReleaseNotes.rst`, I just want to mention that this sentence is

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-19 Thread Aaron Ballman via cfe-commits
@@ -11801,6 +11801,26 @@ static bool CheckMultiVersionFunction(Sema , FunctionDecl *NewFD, OldDecl, Previous); } +static void CheckFunctionDeclarationAttributesUsage(Sema , AaronBallman wrote: ```suggestion static

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-19 Thread Aaron Ballman via cfe-commits
@@ -692,6 +692,13 @@ def warn_maybe_falloff_nonvoid_function : Warning< def warn_falloff_nonvoid_function : Warning< "non-void function does not return a value">, InGroup; +def warn_const_attr_with_pure_attr : Warning< + "'const' attribute imposes more restrictions,

[clang] Warning for incorrect useof 'pure' attribute (PR #78200)

2024-01-19 Thread Aaron Ballman via cfe-commits
@@ -11801,6 +11801,26 @@ static bool CheckMultiVersionFunction(Sema , FunctionDecl *NewFD, OldDecl, Previous); } +static void CheckFunctionDeclarationAttributesUsage(Sema , +

[clang] [clang-format] Separate License text and include blocks (PR #77918)

2024-01-19 Thread via cfe-commits
https://github.com/seranu updated https://github.com/llvm/llvm-project/pull/77918 >From d98120c41139cc674088258599c2c3cc9f2921dd Mon Sep 17 00:00:00 2001 From: Serban Ungureanu Date: Tue, 16 Jan 2024 22:19:52 +0200 Subject: [PATCH] [clang-format] Add formatting options

[libc] [compiler-rt] [flang] [lld] [llvm] [clang] [lldb] [clang-tools-extra] [libcxx] [AMDGPU][GFX12] VOP encoding and codegen - add support for v_cvt fp8/… (PR #78414)

2024-01-19 Thread Jay Foad via cfe-commits
jayfoad wrote: Can you add a GFX12 RUN line to clang/test/CodeGenOpenCL/builtins-amdgcn-fp8.cl? That will probably require adding "fp8-conversion-insts" to the GFX12 part of TargetParser.cpp. You can do this in a separate patch if you want. https://github.com/llvm/llvm-project/pull/78414

[clang] [clang-format] Separate License text and include blocks (PR #77918)

2024-01-19 Thread via cfe-commits
https://github.com/seranu updated https://github.com/llvm/llvm-project/pull/77918 >From ae7d3b51663d60dd5365bbcb47001f964ba54456 Mon Sep 17 00:00:00 2001 From: Serban Ungureanu Date: Tue, 16 Jan 2024 22:19:52 +0200 Subject: [PATCH] [clang-format] Add formatting options

[libcxx] [clang] [libc] [libcxxabi] [libunwind] [compiler-rt] [lld] [clang-tools-extra] [flang] [lldb] [llvm] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

2024-01-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I think the current changes are reasonable to land for Clang 18 so we get the fix out to users. I don't have strong opinions on pushing this down into LLVM or outlining the function like John suggested; either approach is fine by me. I think

[libcxxabi] [libc] [compiler-rt] [flang] [llvm] [lld] [libunwind] [clang] [lldb] [clang-tools-extra] [libcxx] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

2024-01-19 Thread Aaron Ballman via cfe-commits
@@ -2712,9 +2712,22 @@ static void EmitComplexRangeDiag(const Driver , << EnumComplexRangeToStr(Range1) << EnumComplexRangeToStr(Range2); } -static std::string RenderComplexRangeOption(std::string Range) { +static std::string

[llvm] [libcxxabi] [libc] [clang-tools-extra] [libunwind] [lldb] [libcxx] [clang] [lld] [flang] [compiler-rt] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

2024-01-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/78330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Separate License text and include blocks (PR #77918)

2024-01-19 Thread via cfe-commits
seranu wrote: I updated the implementation and tried to include all the feedback I received. Regarding "NewLines between IncludeGroups" I think this is a separate option that, in my opinion, would be best implemented together with "IncludeBlocksStyle::IBS_Regroup" option. @mydeveloperday I'm

[clang-tools-extra] [include-cleaner] Add --only-headers flag, opposite of --ignore-headers (PR #78714)

2024-01-19 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall created https://github.com/llvm/llvm-project/pull/78714 None >From 97276e961ffb146182712832a346b2ee5d13bc30 Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Fri, 19 Jan 2024 14:45:51 +0100 Subject: [PATCH] [include-cleaner] Add --only-headers flag, opposite of

[clang] [Rewrite] Fix offset computation in RemoveText (PR #73827)

2024-01-19 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: Ping https://github.com/llvm/llvm-project/pull/73827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Separate License text and include blocks (PR #77918)

2024-01-19 Thread via cfe-commits
https://github.com/seranu updated https://github.com/llvm/llvm-project/pull/77918 >From 8cc2aca8ab3d7b5d244dc7f1dfd42242ee888b15 Mon Sep 17 00:00:00 2001 From: Serban Ungureanu Date: Tue, 16 Jan 2024 22:19:52 +0200 Subject: [PATCH] [clang-format] Add formatting options

[clang] [libclang] Compute the right spelling location (PR #72400)

2024-01-19 Thread Sebastian Poeplau via cfe-commits
sebastianpoeplau wrote: Ping https://github.com/llvm/llvm-project/pull/72400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang] [SemaCXX] Implement CWG2137 (list-initialization from objects of the same type) (PR #77768)

2024-01-19 Thread Mital Ashok via cfe-commits
MitalAshok wrote: @cor3ntin Still waiting for Windows checks, but yes, could you merge if you please https://github.com/llvm/llvm-project/pull/77768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] CI Test - Please ignore (PR #78712)

2024-01-19 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/78712 None >From e502c00bd9f1606c82507cb1684328d187523110 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Fri, 19 Jan 2024 14:40:38 +0100 Subject: [PATCH] CI Test - Please ignore ---

[llvm] [clang-tools-extra] [clang] [VPlan] Implement cloning of VPlans. (PR #73158)

2024-01-19 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/73158 >From 13a26e8e7440c3b501730b22588af393a3e543cd Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 6 Jul 2023 08:07:45 +0100 Subject: [PATCH] [VPlan] Implement cloning of VPlans. This patch implements cloning

[llvm] [libcxxabi] [libc] [clang-tools-extra] [libunwind] [lldb] [libcxx] [clang] [lld] [flang] [compiler-rt] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

2024-01-19 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @AaronBallman any comments about this? Thanks. https://github.com/llvm/llvm-project/pull/78330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AMDGPU] Remove gws feature from GFX12 (PR #78711)

2024-01-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jay Foad (jayfoad) Changes This was already done for LLVM. This patch just updates the Clang builtin handling to match. --- Full diff: https://github.com/llvm/llvm-project/pull/78711.diff 3 Files Affected: - (modified)

[llvm] [libcxxabi] [libc] [clang-tools-extra] [libunwind] [lldb] [libcxx] [clang] [lld] [flang] [compiler-rt] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

2024-01-19 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @rjmccall thanks for the review and clarification. @andykaylor do you have any other comments about this? https://github.com/llvm/llvm-project/pull/78330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[llvm] [clang] [AMDGPU] Remove gws feature from GFX12 (PR #78711)

2024-01-19 Thread Jay Foad via cfe-commits
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/78711 This was already done for LLVM. This patch just updates the Clang builtin handling to match. >From 8ec83bbc08c6a364efda3724d5886dbd568f956f Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Fri, 19 Jan 2024

[llvm] [clang] [Clang] Correct __builtin_dynamic_object_size for subobject types (PR #78526)

2024-01-19 Thread Nikita Popov via cfe-commits
nikic wrote: @bwendling I think you are reading the GCC docs too pedantically. In particular, they also say > If there are multiple objects ptr can point to and all of them are known at > compile time, the returned number is the maximum of remaining byte counts in > those objects if type & 2

[llvm] [clang] [AMDGPU] Do not emit `V_DOT2C_F32_F16_e32` on GFX12 (PR #78709)

2024-01-19 Thread Mirko Brkušanin via cfe-commits
https://github.com/mbrkusanin approved this pull request. https://github.com/llvm/llvm-project/pull/78709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix build with GCC 14 on ARM (PR #78704)

2024-01-19 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. https://github.com/llvm/llvm-project/pull/78704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix build with GCC 14 on ARM (PR #78704)

2024-01-19 Thread Sander de Smalen via cfe-commits
@@ -760,8 +760,9 @@ KEYWORD(__builtin_available , KEYALL) KEYWORD(__builtin_sycl_unique_stable_name, KEYSYCL) // Keywords defined by Attr.td. +// The "EMPTY ## X" is used to prevent early macro-expansion of the keyword. #ifndef KEYWORD_ATTRIBUTE -#define

[clang] [Clang] [NFC] Remove default argument in ASTUnit.h (PR #78566)

2024-01-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/78566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 061eb62 - [Clang] [NFC] Remove default argument in ASTUnit.h (#78566)

2024-01-19 Thread via cfe-commits
Author: Sirraide Date: 2024-01-19T08:29:23-05:00 New Revision: 061eb62a9051ed06935135ffa3ea03eb250fd55e URL: https://github.com/llvm/llvm-project/commit/061eb62a9051ed06935135ffa3ea03eb250fd55e DIFF: https://github.com/llvm/llvm-project/commit/061eb62a9051ed06935135ffa3ea03eb250fd55e.diff

[clang] [libc++] fix _Atomic c11 compare exchange does not update expected results (PR #78707)

2024-01-19 Thread via cfe-commits
https://github.com/huixie90 updated https://github.com/llvm/llvm-project/pull/78707 >From 37c3f40a4bd118dbcf3a1727e6bcf083b9826cdb Mon Sep 17 00:00:00 2001 From: Hui Date: Fri, 19 Jan 2024 12:33:43 + Subject: [PATCH] [libc++] fix _Atomic c11 compare exchange does not update expected

[clang-tools-extra] [clang] [llvm] Move ExpandMemCmp and MergeIcmp to the middle end (PR #77370)

2024-01-19 Thread Gabriel Baraldi via cfe-commits
gbaraldi wrote: That's encouraging at least. https://github.com/llvm/llvm-project/pull/77370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-19 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/78699 >From 5b25a78e888086f5a9c25acab2dc446a85252ee4 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Fri, 19 Jan 2024 12:04:29 +0100 Subject: [PATCH 1/2] [Clang][NFC] Optimize isAsciiIdentifierContinue

[clang] [Tooling] Fix FixedCompilationDatabase with header compile flags (PR #73913)

2024-01-19 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall closed https://github.com/llvm/llvm-project/pull/73913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1ab418b - [Tooling] Fix FixedCompilationDatabase with header compile flags (#73913)

2024-01-19 Thread via cfe-commits
Author: Sam McCall Date: 2024-01-19T14:02:04+01:00 New Revision: 1ab418beb3cc9c31ebb2d5779069426d761ceb8f URL: https://github.com/llvm/llvm-project/commit/1ab418beb3cc9c31ebb2d5779069426d761ceb8f DIFF: https://github.com/llvm/llvm-project/commit/1ab418beb3cc9c31ebb2d5779069426d761ceb8f.diff

[clang] [Tooling] Fix FixedCompilationDatabase with header compile flags (PR #73913)

2024-01-19 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall updated https://github.com/llvm/llvm-project/pull/73913 >From 98768562935cdf1c42e41d9bbe09cfdc0a545c2a Mon Sep 17 00:00:00 2001 From: Sam McCall Date: Thu, 30 Nov 2023 10:22:00 +0100 Subject: [PATCH] [Tooling] Fix FixedCompilationDatabase with header compile

[clang-tools-extra] [clang-apply-replacements] Deduplicate Implementation of `collectReplacementsFromDirectory` (NFC) (PR #78630)

2024-01-19 Thread Daniil Dudkin via cfe-commits
https://github.com/unterumarmung closed https://github.com/llvm/llvm-project/pull/78630 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 24e5229 - [clang-apply-replacements] Deduplicate Implementation of `collectReplacementsFromDirectory` (NFC) (#78630)

2024-01-19 Thread via cfe-commits
Author: Daniil Dudkin Date: 2024-01-19T15:57:02+03:00 New Revision: 24e5229230786b650a24d70bf7b10611ceb910fb URL: https://github.com/llvm/llvm-project/commit/24e5229230786b650a24d70bf7b10611ceb910fb DIFF: https://github.com/llvm/llvm-project/commit/24e5229230786b650a24d70bf7b10611ceb910fb.diff

[clang-tools-extra] [clang-apply-replacements] Deduplicate Implementation of `collectReplacementsFromDirectory` (NFC) (PR #78630)

2024-01-19 Thread Daniil Dudkin via cfe-commits
unterumarmung wrote: The Windows build in the CI is stuck. The change is pretty trivial and doesn't use any features that cannot be found in C++98. So, we can skip the Windows check. https://github.com/llvm/llvm-project/pull/78630 ___ cfe-commits

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-19 Thread via cfe-commits
cor3ntin wrote: I did try to apply the same treatment to the whitespace tables but it made thing strictly worse https://github.com/llvm/llvm-project/pull/78699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [analyzer] Demonstrate superfluous unsigned >= 0 assumption (PR #78442)

2024-01-19 Thread Balazs Benics via cfe-commits
steakhal wrote: I'd advise against introducing a separate file for this, but I'm okay with landing tests. Given this issue, I'd be interested to look at how difficult it is to actually fix it and commit the case along with the fix. Have you looked at potential solutions?

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-19 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/78699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-19 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > I tried applying this patch to ROOT/Cling and it fails to build because > something is of the opinion that `std::is_integral::value` is not true. > I don't have time right now to investigate further, but since this is the > only change I did it is highly likely that it's

[clang] [Clang][NFC] Optimize isAsciiIdentifierContinue (PR #78699)

2024-01-19 Thread via cfe-commits
@@ -59,12 +59,29 @@ LLVM_READONLY inline bool isAsciiIdentifierStart(unsigned char c, return AllowDollar && c == '$'; } + +LLVM_READONLY inline bool isAsciiIdentifierContinue(unsigned char c) { + // Precomputed CHAR_UPPER|CHAR_LOWER|CHAR_DIGIT|CHAR_UNDER + static

[mlir] [clang] [libcxx] [flang] [libc] [llvm] [clang-tools-extra] [lldb] [compiler-rt] Added settings for DEBUGINFOD cache location and timeout (PR #78605)

2024-01-19 Thread Kevin Frei via cfe-commits
https://github.com/kevinfrei updated https://github.com/llvm/llvm-project/pull/78605 >From 48c6e5edc1dc5f832f8f5c922c61af9070ad341d Mon Sep 17 00:00:00 2001 From: Kevin Frei Date: Thu, 18 Jan 2024 09:09:50 -0800 Subject: [PATCH 1/8] Added settings for cache location and timeout ---

[llvm] [clang] [AMDGPU] Do not emit `V_DOT2C_F32_F16_e32` on GFX12 (PR #78709)

2024-01-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang Author: Jay Foad (jayfoad) Changes That instruction is not supported on GFX12. Added a testcase which previously crashed without this change. --- Full diff: https://github.com/llvm/llvm-project/pull/78709.diff

[llvm] [clang] [AMDGPU] Do not emit `V_DOT2C_F32_F16_e32` on GFX12 (PR #78709)

2024-01-19 Thread Jay Foad via cfe-commits
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/78709 That instruction is not supported on GFX12. Added a testcase which previously crashed without this change. >From b212d63828ae87b8e40f9d6de7622bc7a14ce48f Mon Sep 17 00:00:00 2001 From: pvanhout Date: Mon, 30

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-19 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: I tried applying this patch to ROOT/Cling and it fails to build because something is of the opinion that `std::is_integral::value` is not true. I don't have time right now to investigate further, but since this is the only change I did it is highly likely that it's caused by

[clang] [libcxx] [SemaCXX] Implement CWG2137 (list-initialization from objects of the same type) (PR #77768)

2024-01-19 Thread via cfe-commits
cor3ntin wrote: Do you want me to merge on your behalf? https://github.com/llvm/llvm-project/pull/77768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix build with GCC 14 on ARM (PR #78704)

2024-01-19 Thread Nikita Popov via cfe-commits
@@ -760,8 +760,9 @@ KEYWORD(__builtin_available , KEYALL) KEYWORD(__builtin_sycl_unique_stable_name, KEYSYCL) // Keywords defined by Attr.td. +// The "EMPTY ## X" is used to prevent early macro-expansion of the keyword. #ifndef KEYWORD_ATTRIBUTE -#define

[clang] [libc++] fix _Atomic c11 compare exchange does not update expected results (PR #78707)

2024-01-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e4c8c5851738b7475efa1b9d500078133159369a 08092c466cc04a2e41634421a1bb7f18aa612815 --

[clang] [libc++] fix _Atomic c11 compare exchange does not update expected results (PR #78707)

2024-01-19 Thread via cfe-commits
https://github.com/huixie90 created https://github.com/llvm/llvm-project/pull/78707 None >From 08092c466cc04a2e41634421a1bb7f18aa612815 Mon Sep 17 00:00:00 2001 From: Hui Date: Fri, 19 Jan 2024 12:33:43 + Subject: [PATCH] [libc++] fix _Atomic c11 compare exchange does not update expected

[libc] [clang-tools-extra] [compiler-rt] [flang] [llvm] [clang] [flang] use setsid to assign the child to prevent zombie as it will be clean up by init process (PR #77944)

2024-01-19 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan approved this pull request. LG. https://github.com/llvm/llvm-project/pull/77944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >