[flang] [clang-tools-extra] [libc] [compiler-rt] [lldb] [libcxx] [libcxxabi] [lld] [clang] [libclc] [llvm] [Thumb,ELF] Fix access to dso_preemptable __stack_chk_guard with static relocation model (PR

2024-01-22 Thread Fangrui Song via cfe-commits
MaskRay wrote: > (the commit message seems odd; intentional?) Hopefully clarified:) https://github.com/llvm/llvm-project/pull/78950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [clang-tools-extra] [libc] [compiler-rt] [lldb] [libcxx] [libcxxabi] [lld] [clang] [libclc] [llvm] [Thumb,ELF] Fix access to dso_preemptable __stack_chk_guard with static relocation model (PR

2024-01-22 Thread Fangrui Song via cfe-commits
@@ -135,14 +135,15 @@ void Thumb1InstrInfo::loadRegFromStackSlot(MachineBasicBlock , void Thumb1InstrInfo::expandLoadStackGuard( MachineBasicBlock::iterator MI) const { MachineFunction = *MI->getParent()->getParent(); - const TargetMachine = MF.getTarget(); const

[flang] [clang-tools-extra] [libc] [compiler-rt] [lldb] [libcxx] [libcxxabi] [lld] [clang] [libclc] [llvm] [Thumb,ELF] Fix access to dso_preemptable __stack_chk_guard with static relocation model (PR

2024-01-22 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/78950 >From 2ce57488682873d2dc005144db57fbb555f29d8a Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Mon, 22 Jan 2024 00:29:09 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[libc] [libcxxabi] [libcxx] [lld] [flang] [libclc] [clang] [compiler-rt] [clang-tools-extra] [lldb] [llvm] [Thumb,ELF] Fix access to dso_preemptable __stack_chk_guard with static relocation model (PR

2024-01-22 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/78950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [clang] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

2024-01-22 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/76873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-22 Thread kleines Filmröllchen via cfe-commits
kleinesfilmroellchen wrote: After some discussion, I would like to land the feature "partially" as-is without support for "include cleaner" header insertion. (Case 3 in @HighCommander4's elaboration above.) This is motivated by two factors: - Having looked at a way of supporting all three

[clang] 1e2a4cc - [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (#76873)

2024-01-22 Thread via cfe-commits
Author: Zahira Ammarguellat Date: 2024-01-22T14:38:30-05:00 New Revision: 1e2a4ccb6237b6db9db7dc3fd11a94410ec9b0df URL: https://github.com/llvm/llvm-project/commit/1e2a4ccb6237b6db9db7dc3fd11a94410ec9b0df DIFF:

[clang] 0dd72eb - [OpenACC] Implement 'vector' and 'worker' cluase argument parsing

2024-01-22 Thread via cfe-commits
Author: erichkeane Date: 2024-01-22T11:35:30-08:00 New Revision: 0dd72eb269dd485b98afba2c58a1d747db53dcad URL: https://github.com/llvm/llvm-project/commit/0dd72eb269dd485b98afba2c58a1d747db53dcad DIFF: https://github.com/llvm/llvm-project/commit/0dd72eb269dd485b98afba2c58a1d747db53dcad.diff

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
@@ -18,6 +18,45 @@ namespace clang::tidy::readability { static const llvm::StringRef AlgorithmHeader(""); +static bool MinCondition(const BinaryOperator::Opcode ,const Expr *CondLhs,const Expr *CondRhs,const Expr *AssignLhs,const Expr *AssignRhs,const ASTContext ){ +

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
@@ -18,6 +18,45 @@ namespace clang::tidy::readability { static const llvm::StringRef AlgorithmHeader(""); +static bool MinCondition(const BinaryOperator::Opcode ,const Expr *CondLhs,const Expr *CondRhs,const Expr *AssignLhs,const Expr *AssignRhs,const ASTContext ){ +

[clang] [FatLTO] output of -ffat-lto-objects -S should be assembly. (PR #79041)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Sean Fertile (mandlebug) Changes Fat lto with -c compiles to an object file with the IR embedded in a section of the object, the combination of fat-lto with -S should then produce an assembly file equivalent of that. The IR output

[clang] [FatLTO] output of -ffat-lto-objects -S should be assembly. (PR #79041)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lto Author: Sean Fertile (mandlebug) Changes Fat lto with -c compiles to an object file with the IR embedded in a section of the object, the combination of fat-lto with -S should then produce an assembly file equivalent of that. The IR output can

[clang] [FatLTO] output of -ffat-lto-objects -S should be assembly. (PR #79041)

2024-01-22 Thread Sean Fertile via cfe-commits
https://github.com/mandlebug created https://github.com/llvm/llvm-project/pull/79041 Fat lto with -c compiles to an object file with the IR embedded in a section of the object, the combination of fat-lto with -S should then produce an assembly file equivalent of that. The IR output can still

[mlir] [llvm] [clang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam edited https://github.com/llvm/llvm-project/pull/79039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [clang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Saiyedul Islam via cfe-commits
@@ -99,6 +99,7 @@ class ROCDLDialectLLVMIRTranslationInterface if (!llvmFunc->hasFnAttribute("amdgpu-flat-work-group-size")) { llvmFunc->addFnAttr("amdgpu-flat-work-group-size", "1,256"); } + llvmFunc->addFnAttr("amdgpu-implicitarg-num-bytes", "256");

[clang-tools-extra] [clang] [compiler-rt] [PGO] Reland PGO's Counter Reset and File Dumping APIs #76471 (PR #78285)

2024-01-22 Thread Wael Yehia via cfe-commits
https://github.com/w2yehia approved this pull request. https://github.com/llvm/llvm-project/pull/78285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [clang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Joseph Huber via cfe-commits
@@ -99,6 +99,7 @@ class ROCDLDialectLLVMIRTranslationInterface if (!llvmFunc->hasFnAttribute("amdgpu-flat-work-group-size")) { llvmFunc->addFnAttr("amdgpu-flat-work-group-size", "1,256"); } + llvmFunc->addFnAttr("amdgpu-implicitarg-num-bytes", "256");

[mlir] [llvm] [clang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. https://github.com/llvm/llvm-project/pull/79039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/79039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [mlir] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm Author: Saiyedul Islam (saiislam) Changes Depends on #79038 which makes cov5 as the default code object version. --- Full diff: https://github.com/llvm/llvm-project/pull/79039.diff 19 Files Affected: - (modified)

[llvm] [clang] [mlir] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam created https://github.com/llvm/llvm-project/pull/79039 Depends on #79038 which makes cov5 as the default code object version. >From 4c156a11e943b85c1fe9f7f0ff5b651cf4d3946d Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Mon, 22 Jan 2024 13:11:22 -0600

[llvm] [clang] [mlir] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Seems straightforward enough https://github.com/llvm/llvm-project/pull/79038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [mlir] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir @llvm/pr-subscribers-clang Author: Saiyedul Islam (saiislam) Changes Also update LIT tests and docs. For more details, see https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata Corresponding llvm-objdump AMDGPU lit tests are updated in a

[llvm] [clang] [mlir] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam created https://github.com/llvm/llvm-project/pull/79038 Also update LIT tests and docs. For more details, see https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata Corresponding llvm-objdump AMDGPU lit tests are updated in a follow-up PR. >From

[clang] 73ff017 - [Sema] Fix a warning

2024-01-22 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-22T11:17:21-08:00 New Revision: 73ff017c9b39d8a1ecc350f0572e3274dd4c9146 URL: https://github.com/llvm/llvm-project/commit/73ff017c9b39d8a1ecc350f0572e3274dd4c9146 DIFF: https://github.com/llvm/llvm-project/commit/73ff017c9b39d8a1ecc350f0572e3274dd4c9146.diff

[clang-tools-extra] [llvm] [Matrix] Convert column-vector ops feeding dot product to row-vectors. (PR #72647)

2024-01-22 Thread Visoiu Mistrih Francis via cfe-commits
https://github.com/francisvm approved this pull request. https://github.com/llvm/llvm-project/pull/72647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Zic64b, Ziccamoa, Ziccif, Zicclsm, Ziccrse, and Za64rs to sifive-p450. (PR #79030)

2024-01-22 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/79030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [Matrix] Convert column-vector ops feeding dot product to row-vectors. (PR #72647)

2024-01-22 Thread Visoiu Mistrih Francis via cfe-commits
@@ -1391,7 +1394,26 @@ class LowerMatrixIntrinsics { return TTI.getMemoryOpCost(Instruction::Load, VecTy, Align(1), 0) - N * TTI.getMemoryOpCost(Instruction::Load, EltTy, Align(1), 0); }; -auto LHSCost = GetCostForArg(LHS, LShape.NumColumns); +

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f73bf45d68bd2c17602a909751da4a23138d711a c3de96925ea288fa50e72b597428d3e47c2e4595 --

[lld] [flang] [mlir] [libcxx] [libc] [openmp] [compiler-rt] [clang] [lldb] [llvm] [clang-tools-extra] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

2024-01-22 Thread Hristo Hristov via cfe-commits
H-G-Hristov wrote: > This is still broken so I'm going to revert the change. Thanks! Sorry for the inconvenience. I didn't see your message earlier. https://github.com/llvm/llvm-project/pull/76449 ___ cfe-commits mailing list

[llvm] [clang] [mlir] [AMDGPU] Add GFX12 WMMA and SWMMAC instructions (PR #77795)

2024-01-22 Thread Krzysztof Drewniak via cfe-commits
@@ -253,22 +253,22 @@ def ROCDL_mfma_f32_32x32x16_fp8_fp8 : ROCDL_Mfma_IntrOp<"mfma.f32.32x32x16.fp8.f //===-===// // WMMA intrinsics -class ROCDL_Wmma_IntrOp traits = []> : +class ROCDL_Wmma_IntrOp

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-22 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-22 Thread Carl Peto via cfe-commits
https://github.com/carlos4242 created https://github.com/llvm/llvm-project/pull/79037 - Sema::isSimpleTypeSpecifier return true for _Bool in c99 (currently returns false for _Bool, regardless of C dialect). (Fixes #72203) - move simple type decision code into shared location (IdentifierInfo) -

[llvm] [clang] [RISCV] Add sifive-p670 processor (PR #79015)

2024-01-22 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland updated https://github.com/llvm/llvm-project/pull/79015 >From 639d404b3b8a8ca7e92160fa8512459be07e631f Mon Sep 17 00:00:00 2001 From: Michael Maitland Date: Mon, 22 Jan 2024 07:53:55 -0800 Subject: [PATCH 1/4] [RISCV] Add sifive-p670 processor This is an OOO

[llvm] [clang] [RISCV] Add sifive-p670 processor (PR #79015)

2024-01-22 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland updated https://github.com/llvm/llvm-project/pull/79015 >From 639d404b3b8a8ca7e92160fa8512459be07e631f Mon Sep 17 00:00:00 2001 From: Michael Maitland Date: Mon, 22 Jan 2024 07:53:55 -0800 Subject: [PATCH 1/3] [RISCV] Add sifive-p670 processor This is an OOO

[flang] [clang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Andrzej Warzyński via cfe-commits
@@ -1193,6 +1193,16 @@ static void addFortranMain(const ToolChain , const ArgList , return; } + const Driver = TC.getDriver(); + const char *LinkFlag = "-lFortran_main"; + + // warn if -lFortran_main was already specified + for (const char *arg : CmdArgs) { +

[flang] [clang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Andrzej Warzyński via cfe-commits
@@ -1193,6 +1193,16 @@ static void addFortranMain(const ToolChain , const ArgList , return; } + const Driver = TC.getDriver(); banach-space wrote: Move this whole block below the `// 2. GNU and similar`? Otherwise it seems that this is still part

[flang] [clang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Andrzej Warzyński via cfe-commits
@@ -1193,6 +1193,16 @@ static void addFortranMain(const ToolChain , const ArgList , return; } + const Driver = TC.getDriver(); + const char *LinkFlag = "-lFortran_main"; + + // warn if -lFortran_main was already specified banach-space wrote:

[clang] [flang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Andrzej Warzyński via cfe-commits
@@ -1193,6 +1193,16 @@ static void addFortranMain(const ToolChain , const ArgList , return; } + const Driver = TC.getDriver(); + const char *LinkFlag = "-lFortran_main"; banach-space wrote: ```suggestion const char *FortranMainLinkFlag =

[clang] [flang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space edited https://github.com/llvm/llvm-project/pull/79016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. > Intended to warn users of the 19.x release not to do this. > > A better solution should be found for the 20.x release. See discussion in > https://github.com/llvm/llvm-project/pull/78152. > > Unfortunately there is no warning on

[llvm] [clang] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,130 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
@@ -241,6 +241,12 @@ New checks Detects C++ code where a reference variable is used to extend the lifetime of a temporary object that has just been constructed. +- New :doc:`readability-use-std-min-max + ` check. + + Replaces certain conditional statements with

[clang-tools-extra] [clang] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,41 @@ +//===--- UseStdMinMaxCheck.h - clang-tidy ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-22 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/78763 >From 0d68286bd8b7206c5045062f65ccaf1c3fb54714 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Thu, 18 Jan 2024 16:20:41 -0800 Subject: [PATCH 1/4] Add option -fstdlib-hardening= The option allows users to

[llvm] [clang] [AArch64] Make Armv8.3-a extension set +pauth by default (PR #78027)

2024-01-22 Thread Anatoly Trosinenko via cfe-commits
https://github.com/atrosinenko updated https://github.com/llvm/llvm-project/pull/78027 >From 304b5e7834ff071822fbd4e85eb4655d220d4e49 Mon Sep 17 00:00:00 2001 From: Anatoly Trosinenko Date: Thu, 18 Jan 2024 19:54:04 +0300 Subject: [PATCH 1/2] [AArch64] Make Armv8.3-a extension set +pauth by

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-22 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/78763 >From 0d68286bd8b7206c5045062f65ccaf1c3fb54714 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Thu, 18 Jan 2024 16:20:41 -0800 Subject: [PATCH 1/3] Add option -fstdlib-hardening= The option allows users to

[clang] [libcxxabi] [lldb] [libcxx] [libc] [llvm] [clang-tools-extra] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2024-01-22 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/69498 >From 6f89b118ed56ad7a3af1996e19ccd30cc893c51e Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 14 Jun 2023 17:49:22 -0700 Subject: [PATCH 1/8] [libc++] Fix the behavior of throwing `operator new` under

[clang] [llvm] [clang-tools-extra] [CLANG] Add warning when INF or NAN are used in a binary operation or as function argument in fast math mode. (PR #76873)

2024-01-22 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. I'm happy with this. https://github.com/llvm/llvm-project/pull/76873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1be0d9d - [AArch64][Clang] Fix linker error for function multiversioning (#74358)

2024-01-22 Thread via cfe-commits
Author: Dani Date: 2024-01-22T19:55:16+01:00 New Revision: 1be0d9d7d88a9bdabe6ef4d81720ddf4cf6f71c1 URL: https://github.com/llvm/llvm-project/commit/1be0d9d7d88a9bdabe6ef4d81720ddf4cf6f71c1 DIFF: https://github.com/llvm/llvm-project/commit/1be0d9d7d88a9bdabe6ef4d81720ddf4cf6f71c1.diff LOG:

[clang] [AArch64][Clang] Fix linker error for function multiversioning (PR #74358)

2024-01-22 Thread via cfe-commits
https://github.com/DanielKristofKiss closed https://github.com/llvm/llvm-project/pull/74358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][Clang] Fix linker error for function multiversioning (PR #74358)

2024-01-22 Thread via cfe-commits
@@ -1752,8 +1754,10 @@ static void AppendTargetClonesMangling(const CodeGenModule , const TargetInfo = CGM.getTarget(); if (TI.getTriple().isAArch64()) { DanielKristofKiss wrote: It was not supported in the original function multi versioning neither and

[clang] [clang][driver] Add -mtls-dialect option (PR #79031)

2024-01-22 Thread Fangrui Song via cfe-commits
@@ -401,6 +401,8 @@ static bool initTargetOptions(DiagnosticsEngine , Options.UniqueBasicBlockSectionNames = CodeGenOpts.UniqueBasicBlockSectionNames; Options.TLSSize = CodeGenOpts.TLSSize; + // TODO: Add correct codegen options in LLVM + // Options.TLSDesc =

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #75647)

2024-01-22 Thread Jun Wang via cfe-commits
https://github.com/jwanggit86 closed https://github.com/llvm/llvm-project/pull/75647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #75647)

2024-01-22 Thread Jun Wang via cfe-commits
jwanggit86 wrote: Reimplemented in [79035](https://github.com/llvm/llvm-project/pull/79035). https://github.com/llvm/llvm-project/pull/75647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] [clang] [lld] [lldb] [flang] [libunwind] [compiler-rt] [libc] [libcxx] [llvm] [clang-tools-extra] Fix a bug in Smith's algorithm used in complex div. (PR #78330)

2024-01-22 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/78330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Add -mtls-dialect option (PR #79031)

2024-01-22 Thread Fangrui Song via cfe-commits
@@ -72,6 +72,11 @@ class CodeGenOptions : public CodeGenOptionsBase { LocalExecTLSModel }; + enum TLSDialect { MaskRay wrote: Prefer enum class (I think it has been more popular in other parts of Clang, perhaps CodeGen/Sema).

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-22 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/77481 >From f114ac46b58118cc8d4a07119b8a51787f481ded Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Thu, 4 Jan 2024 15:36:40 + Subject: [PATCH] [clang][dataflow] Make cap on block visits configurable by

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Jun Wang (jwanggit86) Changes A new function attribute named amdgpu-num-work-groups is added. This attribute, which consists of three integers, allows programmers to let the compiler know the number of workgroups to be launched

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #79035)

2024-01-22 Thread Jun Wang via cfe-commits
https://github.com/jwanggit86 created https://github.com/llvm/llvm-project/pull/79035 A new function attribute named amdgpu-num-work-groups is added. This attribute, which consists of three integers, allows programmers to let the compiler know the number of workgroups to be launched in each

[clang] [-Wunsafe-buffer-usage] Fix the crash introduced by the unsafe invocation of span::data warning (PR #78815)

2024-01-22 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak closed https://github.com/llvm/llvm-project/pull/78815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 414df70 - [-Wunsafe-buffer-usage] Fix the crash introduced by the unsafe invocation of span::data warning (#78815)

2024-01-22 Thread via cfe-commits
Author: Malavika Samak Date: 2024-01-22T10:46:59-08:00 New Revision: 414df7051ac90f186fac9d3d8968aa827eceb697 URL: https://github.com/llvm/llvm-project/commit/414df7051ac90f186fac9d3d8968aa827eceb697 DIFF:

[clang] [clang][dataflow] Make cap on block visits configurable by caller. (PR #77481)

2024-01-22 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/77481 >From 1e37ced06198e9d8b7c583e01f22e53508182902 Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Thu, 4 Jan 2024 15:36:40 + Subject: [PATCH 1/3] [clang][dataflow] Make cap on block visits configurable by

[clang] [clang][driver] Add -mtls-dialect option (PR #79031)

2024-01-22 Thread Paul Kirth via cfe-commits
ilovepi wrote: Note: codegen changes to support meaningful `-mtls-dialect` changes are introduced in https://github.com/llvm/llvm-project/pull/66915. https://github.com/llvm/llvm-project/pull/79031 ___ cfe-commits mailing list

[clang] [clang][driver] Add -mtls-dialect option (PR #79031)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Kirth (ilovepi) Changes GCC an other ELF compilers support -mlts-dialect= options to control the use of ELF TLS Descriptors as part of the TLS model. This patch only adds support to the clang driver for the flag. Support for the

[clang] 04952c5 - [OpenACC] Implement remaining 'simple' int-expr clauses.

2024-01-22 Thread via cfe-commits
Author: erichkeane Date: 2024-01-22T10:43:13-08:00 New Revision: 04952c5bec69c197ea6ffb718ae80fcf78c7828a URL: https://github.com/llvm/llvm-project/commit/04952c5bec69c197ea6ffb718ae80fcf78c7828a DIFF: https://github.com/llvm/llvm-project/commit/04952c5bec69c197ea6ffb718ae80fcf78c7828a.diff

[clang] [clang][driver] Add -mtls-dialect option (PR #79031)

2024-01-22 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/79031 GCC an other ELF compilers support -mlts-dialect= options to control the use of ELF TLS Descriptors as part of the TLS model. This patch only adds support to the clang driver for the flag. Support for the

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-01-22 Thread Mark de Wever via cfe-commits
https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/76451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a301fb1 - [clang][modules] Print library module manifest path. (#76451)

2024-01-22 Thread via cfe-commits
Author: Mark de Wever Date: 2024-01-22T19:42:32+01:00 New Revision: a301fb11014f9cfdf4ee8cada173c46a7677d9d3 URL: https://github.com/llvm/llvm-project/commit/a301fb11014f9cfdf4ee8cada173c46a7677d9d3 DIFF: https://github.com/llvm/llvm-project/commit/a301fb11014f9cfdf4ee8cada173c46a7677d9d3.diff

[clang] [clang][modules] Print library module manifest path. (PR #76451)

2024-01-22 Thread Mark de Wever via cfe-commits
mordante wrote: > LGTM with a few nits. Can you double check modules.json is inside `lib/` > (`usr/lib/x86_64-linux-gnu{{/|\\}}modules.json`) instead of some directory > under `include`? Thanks for the review. The json will indeed be installed in the lib dir in libc++.

[compiler-rt] [clang] [clang-tools-extra] [PGO] Reland PGO's Counter Reset and File Dumping APIs #76471 (PR #78285)

2024-01-22 Thread Qiongsi Wu via cfe-commits
qiongsiwu wrote: Thanks for to comments/suggestions @w2yehia ! The test is modified so that 1. The profile files are generated. 2. The test does not support Windows to avoid known limitations on Windows. https://github.com/llvm/llvm-project/pull/78285

[clang] [clang-tools-extra] [compiler-rt] [PGO] Reland PGO's Counter Reset and File Dumping APIs #76471 (PR #78285)

2024-01-22 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu updated https://github.com/llvm/llvm-project/pull/78285 >From ebae7155814ad83ebd1a0159b86550c14c72b2b6 Mon Sep 17 00:00:00 2001 From: Qiongsi Wu Date: Fri, 12 Jan 2024 11:45:50 -0500 Subject: [PATCH 1/3] Reland https://github.com/llvm/llvm-project/pull/76471 ---

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,29 @@ +.. title:: clang-tidy - readability-use-std-min-max + +readability-use-std-min-max +=== + +Replaces certain conditional statements with equivalent ``std::min`` or +``std::max`` expressions. Note: This may impact PiotrZSL

[clang] [clang-tools-extra] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,29 @@ +.. title:: clang-tidy - readability-use-std-min-max + +readability-use-std-min-max +=== + +Replaces certain conditional statements with equivalent ``std::min`` or +``std::max`` expressions. Note: This may impact PiotrZSL

[clang-tools-extra] [clang] [llvm] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-22 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/77816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [clang] [CGProfile] Use callee's PGO name when caller->callee is an indirect call. (PR #78610)

2024-01-22 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 closed https://github.com/llvm/llvm-project/pull/78610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [RISCV] Add Zic64b, Ziccamoa, Ziccif, Zicclsm, Ziccrse, and Za64rs to sifive-p450. (PR #79030)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Craig Topper (topperc) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/79030.diff 2 Files Affected: - (modified) clang/test/Driver/riscv-cpus.c (+6) - (modified) llvm/lib/Target/RISCV/RISCVProcessors.td (+6)

[llvm] [clang] [RISCV] Add Zic64b, Ziccamoa, Ziccif, Zicclsm, Ziccrse, and Za64rs to sifive-p450. (PR #79030)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Craig Topper (topperc) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/79030.diff 2 Files Affected: - (modified) clang/test/Driver/riscv-cpus.c (+6) - (modified) llvm/lib/Target/RISCV/RISCVProcessors.td (+6)

[llvm] [clang] [RISCV] Add Zic64b, Ziccamoa, Ziccif, Zicclsm, Ziccrse, and Za64rs to sifive-p450. (PR #79030)

2024-01-22 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/79030 None >From a3f43ca1e5bc1ab4fd9c41f86d1904a54242a281 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Mon, 22 Jan 2024 10:33:39 -0800 Subject: [PATCH] [RISCV] Add Zic64b, Ziccamoa, Ziccif, Zicclsm, Ziccrse, and

[llvm] [clang] [RISCV] Add sifive-p670 processor (PR #79015)

2024-01-22 Thread Craig Topper via cfe-commits
topperc wrote: Need to update docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/79015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up the driver and getStyle() in Format.cpp (PR #74794)

2024-01-22 Thread Ben Hamilton via cfe-commits
@@ -544,28 +544,23 @@ static void PrintVersion(raw_ostream ) { } // Dump the configuration. -static int dumpConfig() { - StringRef FileName; +static int dumpConfig(bool IsSTDIN) { std::unique_ptr Code; - if (FileNames.empty()) { -// We can't read the code to detect

[clang] [-Wunsafe-buffer-usage] Fix the crash introduced by the unsafe invocation of span::data warning (PR #78815)

2024-01-22 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/78815 >From 6334cd361f79fc79f32b8ca95c6f31a083704332 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Fri, 19 Jan 2024 15:16:12 -0800 Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Fix the crash introduced by

[clang] [NVPTX][AMDGPU][CodeGen] Fix `local_space nullptr` handling for NVPTX and local/private `nullptr` value for AMDGPU. (PR #78759)

2024-01-22 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B commented: It would be great to add some tests for local AS null pointers for NVPTX and AMDGPU back-ends. https://github.com/llvm/llvm-project/pull/78759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [OpenCL] Allow -fno-offload-uniform-block for 1.2 (PR #79026)

2024-01-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Yaxun (Sam) Liu (yxsamliu) Changes OpenCL 1.2 kernel assumes uniform workgroup size. By default a function attr is added to allow backend to do optimizations. These optimizations may cause UB if such

[clang] [OpenCL] Allow -fno-offload-uniform-block for 1.2 (PR #79026)

2024-01-22 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/79026 OpenCL 1.2 kernel assumes uniform workgroup size. By default a function attr is added to allow backend to do optimizations. These optimizations may cause UB if such kernels are launched with non-uniform

[clang] [FPEnv] Add strictfp in some C++ constructors lacking a FunctionDecl. (PR #74883)

2024-01-22 Thread John McCall via cfe-commits
https://github.com/rjmccall requested changes to this pull request. I'm sorry for failing to notice this in my previous review, but I don't think this patch is right. A global initializer should be FP-constrained based on whether the variable is defined in an FP-constrained context. This is

[clang] [-Wunsafe-buffer-usage] Fix the crash introduced by the unsafe invocation of span::data warning (PR #78815)

2024-01-22 Thread Malavika Samak via cfe-commits
@@ -2263,15 +2263,27 @@ class UnsafeBufferUsageReporter : public UnsafeBufferUsageHandler { MsgParam = 3; } else if (const auto *ECE = dyn_cast(Operation)) { QualType destType = ECE->getType(); -const uint64_t dSize = -

[clang] Improved is simple type specifier (PR #78903)

2024-01-22 Thread Carl Peto via cfe-commits
https://github.com/carlos4242 updated https://github.com/llvm/llvm-project/pull/78903 >From 2622ca430d7edb1c49cda9bbbf6145b60e2e37c4 Mon Sep 17 00:00:00 2001 From: Carl Peto Date: Tue, 14 Nov 2023 03:50:14 + Subject: [PATCH] [clang] Sema::isSimpleTypeSpecifier return true for _Bool in c99

[clang] [clang-format][NFC] Clean up the driver and getStyle() in Format.cpp (PR #74794)

2024-01-22 Thread Ben Hamilton via cfe-commits
bhamiltoncx wrote: Seems like this regressed `clang-format - -dump_config < path/to/objc_file.m`. I filed https://github.com/llvm/llvm-project/issues/79023. https://github.com/llvm/llvm-project/pull/74794 ___ cfe-commits mailing list

[clang] [compiler-rt] [clang-tools-extra] [PGO] Reland PGO's Counter Reset and File Dumping APIs #76471 (PR #78285)

2024-01-22 Thread Wael Yehia via cfe-commits
w2yehia wrote: @qiongsiwu explained to me offline that the issue on Windows is that calls __llvm_orderfile_dump fail so he's not able to execute the instrumented program if it calls that function. Regarding the `compiler-rt/test/profile/instrprof-api.c` test. The disadvantage of having a

[clang] [libcxx] [llvm] [mlir] [compiler-rt] [sanitizer] Skip /include/c++/ from summary (PR #78534)

2024-01-22 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > Note that on Gentoo, this isn't right either, we have e.g.: > > ``` > /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/bits/new_allocator.h > /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/ext/new_allocator.h > ``` I guess it's fine to expand the FrameIsInternal to

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-22 Thread Shourya Goel via cfe-commits
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { -

[clang-tools-extra] [llvm] [clang] [Clang] Fix : More Detailed "No expected directives found" (PR #78338)

2024-01-22 Thread Shourya Goel via cfe-commits
@@ -1098,7 +1098,16 @@ void VerifyDiagnosticConsumer::CheckDiagnostics() { // Produce an error if no expected-* directives could be found in the // source file(s) processed. if (Status == HasNoDirectives) { -

[libcxx] [lld] [mlir] [openmp] [llvm] [compiler-rt] [clang] [HEXAGON] Inlining Division (PR #79021)

2024-01-22 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[libcxx] [lld] [mlir] [openmp] [llvm] [compiler-rt] [clang] [HEXAGON] Inlining Division (PR #79021)

2024-01-22 Thread via cfe-commits
https://github.com/quic-asaravan created https://github.com/llvm/llvm-project/pull/79021 This patch inlines float division function calls for hexagon. >From e8beb77010becb9a9c82d875597bdedbfed9be9e Mon Sep 17 00:00:00 2001 From: Awanish Pandey Date: Sun, 6 Sep 2020 14:39:57 +0530 Subject:

[flang] [clang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Kelvin Li via cfe-commits
https://github.com/kkwli approved this pull request. LG. Thanks https://github.com/llvm/llvm-project/pull/79016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang] [llvm] [AMDGPU] Add GFX12 WMMA and SWMMAC instructions (PR #77795)

2024-01-22 Thread Mirko Brkušanin via cfe-commits
mbrkusanin wrote: If there are no further comments, should I merge this? https://github.com/llvm/llvm-project/pull/77795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Michael Klemm via cfe-commits
https://github.com/mjklemm approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/79016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][driver] deprecate manual usage of -lFortran_main (PR #79016)

2024-01-22 Thread Michael Klemm via cfe-commits
mjklemm wrote: I'm OK with landing this for Linux only at this point. https://github.com/llvm/llvm-project/pull/79016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   7   >