[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > @HighCommander4 Thanks for the review. I've updated the comments, but don't > have merge access, could you merge this? Thanks Done https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing list cfe-commits@lists.

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-27 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 23b233c - [clangd] Fix isSpelledInSource crash on invalid FileID (#76668)

2024-01-27 Thread via cfe-commits
Author: Andrew Schenk Date: 2024-01-28T02:34:44-05:00 New Revision: 23b233c8adad5b81e185e50d04356fab64c2f870 URL: https://github.com/llvm/llvm-project/commit/23b233c8adad5b81e185e50d04356fab64c2f870 DIFF: https://github.com/llvm/llvm-project/commit/23b233c8adad5b81e185e50d04356fab64c2f870.diff

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-27 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2024-01-27 Thread via cfe-commits
cor3ntin wrote: Oh wow, thanks for this fix! Does it fixes any of these issues? https://github.com/llvm/llvm-project/issues/68885 https://github.com/llvm/llvm-project/pull/79733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > > It's sad that there's not a single codepath that would handle all these, > > but maybe the perfect is the enemy of the good here. > > The code duplication was my reason for looking at the common path. If you're > fine with duplicating the code I will go ahead and do t

[clang] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2024-01-27 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/79733 >From 9834d065580a668f94f74adaf8507ca672e9118f Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 28 Jan 2024 15:12:01 +0800 Subject: [PATCH] [Clang][Sema] fix deducing auto& from const int in template parameters

[clang] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2024-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qizhi Hu (jcsxky) Changes Fix [issue](https://github.com/llvm/llvm-project/issues/77189) AutoType is possible cv qualified. --- Full diff: https://github.com/llvm/llvm-project/pull/79733.diff 2 Files Affected: - (modified) clang/lib/Sem

[clang] [Clang][Sema] fix deducing auto& from const int in template parameters is impossible in partial specializations (PR #79733)

2024-01-27 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/79733 Fix [issue](https://github.com/llvm/llvm-project/issues/77189) AutoType is possible cv qualified. >From 35662b8929952af13eb31bc127144df2d7c1d003 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Sun, 28 Jan 2024 15:12

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: (In the future, it would greatly help me as a reviewer if rebases are pushed separately from updates to address review comments, so that the latter get their own Compare link.) https://github.com/llvm/llvm-project/pull/67749 ___

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Anyways, I rebased the old version of the patch locally so that I could generate an interdiff, which I'll attach for reference: ```diff diff --git a/clang-tools-extra/clangd/Config.h b/clang-tools-extra/clangd/Config.h index 12ed1420c93e..3559591fce00 100644 --- a/clang

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

2024-01-27 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > The compare button is a bit useless when it has a bunch of changes from main > on it > (https://github.com/llvm/llvm-project/compare/8a2b22e69f82e3f4caa271b57b998d1c03b21d39..67971ca27ef5e2767aba5cfe2cec1021c4de5ec1) Thanks. Yeah, it looks like the "Compare" link next t

[clang] [clang][Interp] Support zero init for complex types (PR #79728)

2024-01-27 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79728 >From 0b6925d01645fbe3af9a1ac51ee6e396cbe67a03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 07:21:06 +0100 Subject: [PATC

[clang] [clang][Interp] Support zero init for complex types (PR #79728)

2024-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Initialize both elements to 0. --- Full diff: https://github.com/llvm/llvm-project/pull/79728.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/ByteCodeExprGen.cpp (+23-1) - (modified) clang/test/A

[clang] [clang][Interp] Support zero init for complex types (PR #79728)

2024-01-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79728 Initialize both elements to 0. >From 0b6925d01645fbe3af9a1ac51ee6e396cbe67a03 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 28 Jan 2024 07:21:06 +0100 Subject: [PATCH] [clang][Interp]

[clang-tools-extra] d6ad67d - [clang-tidy] Use StringRef::consume_back (NFC)

2024-01-27 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-27T22:20:24-08:00 New Revision: d6ad67df6bdd1e49f4f57ae8dfa1b05daf081c6e URL: https://github.com/llvm/llvm-project/commit/d6ad67df6bdd1e49f4f57ae8dfa1b05daf081c6e DIFF: https://github.com/llvm/llvm-project/commit/d6ad67df6bdd1e49f4f57ae8dfa1b05daf081c6e.diff L

[clang] [llvm] [mlir] Fix unsigned typos (PR #76670)

2024-01-27 Thread via cfe-commits
https://github.com/MaheshRavishankar closed https://github.com/llvm/llvm-project/pull/76670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5f4c89e - Fix unsigned typos (#76670)

2024-01-27 Thread via cfe-commits
Author: Rageking8 Date: 2024-01-27T22:20:08-08:00 New Revision: 5f4c89edd0ade97ab3e2d6df5375974f4b975d58 URL: https://github.com/llvm/llvm-project/commit/5f4c89edd0ade97ab3e2d6df5375974f4b975d58 DIFF: https://github.com/llvm/llvm-project/commit/5f4c89edd0ade97ab3e2d6df5375974f4b975d58.diff LOG

[clang] [mlir] [llvm] Fix unsigned typos (PR #76670)

2024-01-27 Thread via cfe-commits
MaheshRavishankar wrote: Yes, you can merge it. Thanks! Let me know if you don't have access https://github.com/llvm/llvm-project/pull/76670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-27 Thread via cfe-commits
yronglin wrote: Should we also dump the sub-expr which in `CXXDefaultArgExpr`: for example: Consider: ``` struct A { A(); ~A(); }; typedef int vec3[3]; vec3 &f(const A &a = A{}); void foo() { for (auto e : f()) {} } ``` Current AST Dump: ``` FunctionDecl 0x126813170 line:85:6 foo 'void (

[clang] 179ade6 - [clang-format] Fix an issue reported by static analyzer

2024-01-27 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-01-27T21:21:01-08:00 New Revision: 179ade6a6d78533179205640dd161bf179daa9ee URL: https://github.com/llvm/llvm-project/commit/179ade6a6d78533179205640dd161bf179daa9ee DIFF: https://github.com/llvm/llvm-project/commit/179ade6a6d78533179205640dd161bf179daa9ee.diff LOG:

[libcxxabi] [libunwind] [libcxx] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-27 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From b5fee4962c347016a732a1310275651a8c74f23a Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind] Fix build for wasm The wasm unwind build appears to be

[compiler-rt] [libcxx] [llvm] [clang] [clang-tools-extra] [libunwind] [mlir] [lldb] [libcxxabi] [flang] [libc] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wasm (PR #79667)

2024-01-27 Thread via cfe-commits
https://github.com/trcrsired edited https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [llvm] [clang] [clang-tools-extra] [libunwind] [mlir] [lldb] [libcxxabi] [flang] [libc] [libunwind][libcxx][libcxxabi] Fix build for wasm (PR #79667)

2024-01-27 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 55c3537800b0a310999f58e2b410dc5c1a6f91e4 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/3] [libunwind] Fix build for wasm The wasm unwind build appears t

[compiler-rt] [libcxx] [llvm] [clang] [clang-tools-extra] [libunwind] [mlir] [lldb] [libcxxabi] [flang] [libc] [libunwind][libcxx][libcxxabi] Fix build for wasm (PR #79667)

2024-01-27 Thread via cfe-commits
https://github.com/trcrsired edited https://github.com/llvm/llvm-project/pull/79667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [llvm] [clang] [clang-tools-extra] [libunwind] [mlir] [lldb] [libcxxabi] [flang] [libc] [libunwind] Fix build for wasm (PR #79667)

2024-01-27 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 55c3537800b0a310999f58e2b410dc5c1a6f91e4 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH 1/2] [libunwind] Fix build for wasm The wasm unwind build appears t

[clang] [Clang] Implement P2718R0 "Lifetime extension in range-based for loops" (PR #76361)

2024-01-27 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/76361 >From cff4446c697e4abfb18ea0a17ca2b6596c23015f Mon Sep 17 00:00:00 2001 From: yronglin Date: Sat, 27 Jan 2024 23:25:57 +0800 Subject: [PATCH] [Clang] Implement P2718R0 "Lifetime extension in range-based for loo

[mlir] [clang] [clang-tools-extra] [llvm] [mlir] Declare promised interfaces for all dialects [2/3] (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/78368 >From 7edcf1ad0820457cc2c6530668dd30a758cf42f7 Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Thu, 11 Jan 2024 20:00:53 -0800 Subject: [PATCH 1/6] Declare Affine Interfaces --- mlir/lib/Dialect/Affi

[mlir] [libc] [lldb] [flang] [libcxxabi] [lld] [libcxx] [clang-tools-extra] [compiler-rt] [llvm] [clang] [mlir][complex] Prevent underflow in complex.abs (PR #76316)

2024-01-27 Thread Mehdi Amini via cfe-commits
joker-eph wrote: I had to revert because this broke a bot: https://lab.llvm.org/buildbot/#/builders/264/builds/6131 ``` # RUN: at line 1 /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/bin/mlir-opt /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/mlir/test/Integration/Dialect/Complex/CPU/co

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-27 Thread Amir Ayupov via cfe-commits
aaupov wrote: These are all annotated builders. I tried triggering rebuilds with clean build dir through buildbot UI but it didn't have an effect. I don't think it's a reasonable expectation that every change must configure cleanly from an existing build directory. https://github.com/llvm/llv

[clang] 5a5ce01 - Reland [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (#69133)

2024-01-27 Thread Amir Ayupov via cfe-commits
Author: Amir Ayupov Date: 2024-01-27T19:01:40-08:00 New Revision: 5a5ce012e4de627c52efa1638993fd23c5e74afa URL: https://github.com/llvm/llvm-project/commit/5a5ce012e4de627c52efa1638993fd23c5e74afa DIFF: https://github.com/llvm/llvm-project/commit/5a5ce012e4de627c52efa1638993fd23c5e74afa.diff L

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Declare promised interfaces for all dialects [2/3] (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/78368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Declare promised interfaces for all dialects [2/3] (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/78368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Declare promised interfaces for all dialects (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: Open question: where should I declare promised interfaces for the `builtin` Dialect? https://github.com/llvm/llvm-project/pull/78368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[mlir] [clang-tools-extra] [llvm] [clang] [mlir] Declare promised interfaces for all dialects (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli edited https://github.com/llvm/llvm-project/pull/78368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [clang-tools-extra] [clang] [llvm] Jf/promise interfaces (PR #78368)

2024-01-27 Thread Justin Fargnoli via cfe-commits
https://github.com/justinfargnoli updated https://github.com/llvm/llvm-project/pull/78368 >From 7edcf1ad0820457cc2c6530668dd30a758cf42f7 Mon Sep 17 00:00:00 2001 From: justinfargnoli Date: Thu, 11 Jan 2024 20:00:53 -0800 Subject: [PATCH 1/5] Declare Affine Interfaces --- mlir/lib/Dialect/Affi

[clang-tools-extra] [clangd] Fix is spelled in source bug (PR #76668)

2024-01-27 Thread Andrew Schenk via cfe-commits
schenka0 wrote: @HighCommander4 Thanks for the review. I've updated the comments, but don't have merge access, could you merge this? Thanks https://github.com/llvm/llvm-project/pull/76668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-01-27 Thread via cfe-commits
https://github.com/fpasserby edited https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [polly] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-27 Thread via cfe-commits
rmarker wrote: Updated FormatTests to account for the change to the style. (Forgetting them is what I get for coding late). This should help when evaluating the scope of the change. https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits maili

[clang] [polly] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-27 Thread via cfe-commits
https://github.com/rmarker updated https://github.com/llvm/llvm-project/pull/78011 >From a1312a0a463bb946f336977b5b01ef7afbede678 Mon Sep 17 00:00:00 2001 From: rmarker Date: Thu, 11 Jan 2024 15:01:18 +1030 Subject: [PATCH 1/8] [clang-format] Add ShortReturnTypeColumn option. --- clang/docs/C

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-27 Thread Craig Hesling via cfe-commits
linux4life798 wrote: > @linux4life798 Can you review the last update? This change LGTM (I don't actually have reviewer rights). https://github.com/llvm/llvm-project/pull/77269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-01-27 Thread via cfe-commits
https://github.com/fpasserby edited https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-27 Thread Craig Hesling via cfe-commits
linux4life798 wrote: > Added flush before calling `writeMainFileToStdOut`. I think that's reasonable. > Personally I didn't find this function particularly useful: I was hoping to > perform rewriting without creating new files, but seems like capturing stdout > from a shared library requires

[clang] [flang] [llvm] [libcxx] [libc] [clang-tools-extra] [lldb] [libc++][ranges] LWG4001: `iota_view` should provide `empty` (PR #79687)

2024-01-27 Thread Hristo Hristov via cfe-commits
https://github.com/Zingam updated https://github.com/llvm/llvm-project/pull/79687 >From 87fe530b0a6afffb041f727ce261affc59d39d50 Mon Sep 17 00:00:00 2001 From: Zingam Date: Thu, 11 Jan 2024 10:04:20 +0200 Subject: [PATCH 1/3] [libc++][ranges] LWG4001: `iota_view` should provide `empty` Implem

[clang] [llvm] [coroutine] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-01-27 Thread via cfe-commits
https://github.com/fpasserby edited https://github.com/llvm/llvm-project/pull/79712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-01-27 Thread via cfe-commits
https://github.com/fpasserby updated https://github.com/llvm/llvm-project/pull/79712 >From e4ee79b135ff7f6cc79669cc296d334c6c45a95a Mon Sep 17 00:00:00 2001 From: fpasserby <125797601+fpasse...@users.noreply.github.com> Date: Sun, 28 Jan 2024 00:02:15 +0100 Subject: [PATCH] Implement llvm.coro.a

[clang] [llvm] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-01-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 53fea6fd6f228eb1dbd282b8d076af545dcd8228 858e207bc33466ed85ecf6a7e8718c2e6153f4fe --

[clang] [llvm] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines @llvm/pr-subscribers-clang Author: None (fpasserby) Changes Implement `llvm.coro.await.suspend` intrinsics, to deal with performance regression after prohibiting `.await_suspend` inlining, as suggested in #64945. Actually, there are three new

[clang] [llvm] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-01-27 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [llvm] Implement llvm.coro.await.suspend intrinsic (PR #79712)

2024-01-27 Thread via cfe-commits
https://github.com/fpasserby created https://github.com/llvm/llvm-project/pull/79712 Implement `llvm.coro.await.suspend` intrinsics, to deal with performance regression after prohibiting `.await_suspend` inlining, as suggested in #64945. Actually, there are three new intrinsics, which directly

[llvm] [clang] [flang] [clang-tools-extra] [compiler-rt] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

2024-01-27 Thread via cfe-commits
https://github.com/jathu updated https://github.com/llvm/llvm-project/pull/67626 >From 20d9ca99fbf11868a5816df217b2aad09e079fb6 Mon Sep 17 00:00:00 2001 From: jathu Date: Wed, 27 Sep 2023 18:01:19 -0700 Subject: [PATCH] [clang-tidy][bazel] Include builtin headers with clang-tidy --- .../clang-

[llvm] [mlir] [clang-tools-extra] [libcxx] [compiler-rt] [flang] [libc] [lldb] [clang] intrinsic to generate a bfi instruction (PR #79672)

2024-01-27 Thread Rama Malladi via cfe-commits
https://github.com/RamaMalladiAWS updated https://github.com/llvm/llvm-project/pull/79672 >From 1928947cf7563aea26bffd7a8f3603ade1ca31d6 Mon Sep 17 00:00:00 2001 From: Rama Malladi Date: Sat, 27 Jan 2024 02:11:47 + Subject: [PATCH] intrinsic to generate a bfi instruction BFI: Bit Field Ins

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-27 Thread Sam James via cfe-commits
thesamesam wrote: > > Yes, please, unless there's a strong reason not to, consider `-fhardened`. > > `-fhardened` also enables a few compiler flags. I think it would be better to > have a separate flag that only affects the library and hopefully in the > future start supporting `-fhardened` fl

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-27 Thread Fangrui Song via cfe-commits
MaskRay wrote: I am on the fence whether a driver option is really needed. It is a very shallow layer of extra abstraction that a curious reader has to look through. I guess I'll not object to this, though. https://github.com/llvm/llvm-project/pull/78763 ___

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-27 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/78763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-27 Thread Fangrui Song via cfe-commits
@@ -1256,6 +1256,14 @@ void Clang::AddPreprocessingOptions(Compilation &C, const JobAction &JA, if (Arg *A = Args.getLastArg(options::OPT_I_)) D.Diag(diag::err_drv_I_dash_not_supported) << A->getAsString(Args); + if (Arg *A = Args.getLastArg(options::OPT_stdlib_hardeni

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
https://github.com/wheatman updated https://github.com/llvm/llvm-project/pull/78742 >From 82d227ec4f4d52231fbafd1193f8f1448e8f9c4e Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Fri, 19 Jan 2024 11:13:33 -0500 Subject: [PATCH] [clang][Sema] Fix for enums overflowing (#24667) Enums which d

[polly] [clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-27 Thread Owen Pan via cfe-commits
owenca wrote: @llvm/pr-subscribers-clang-format this patch fixes a very old bug and will cause behavior changes whether the default is changed to the new `AllowShortType` or left at `None`. Which way should we go? https://github.com/llvm/llvm-project/pull/78011

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
@@ -19807,20 +19807,46 @@ EnumConstantDecl *Sema::CheckEnumConstant(EnumDecl *Enum, // sufficient to contain the incremented value. If no such type // exists, the program is ill-formed. QualType T = getNextLargerIntegralType(Context, EltTy);

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
@@ -19807,20 +19807,46 @@ EnumConstantDecl *Sema::CheckEnumConstant(EnumDecl *Enum, // sufficient to contain the incremented value. If no such type // exists, the program is ill-formed. QualType T = getNextLargerIntegralType(Context, EltTy);

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
https://github.com/wheatman updated https://github.com/llvm/llvm-project/pull/78742 >From 73a0cf747ef506398a489d69a32e5525f53539b0 Mon Sep 17 00:00:00 2001 From: Brian Wheatman Date: Fri, 19 Jan 2024 11:13:33 -0500 Subject: [PATCH] [clang][Sema] Fix for enums overflowing (#24667) Enums which d

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,189 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang] [llvm] [PGO] Sampled instrumentation in PGO to speed up instrumentation binary (PR #69535)

2024-01-27 Thread via cfe-commits
WenleiHe wrote: `split-indirectbr-critical-edges.ll` need to be updated https://github.com/llvm/llvm-project/pull/69535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang] [llvm] [PGO] Sampled instrumentation in PGO to speed up instrumentation binary (PR #69535)

2024-01-27 Thread via cfe-commits
@@ -770,7 +770,7 @@ BasicBlock *FuncPGOInstrumentation::getInstrBB(Edge *E) { auto canInstrument = [](BasicBlock *BB) -> BasicBlock * { // There are basic blocks (such as catchswitch) cannot be instrumented. // If the returned first insertion point is the end of BB, s

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,189 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang-tools-extra] [mlir] [clang] fix vulnerabilities (PR #79697)

2024-01-27 Thread via cfe-commits
https://github.com/NxPKG updated https://github.com/llvm/llvm-project/pull/79697 >From f7b4f61db6016a1a02d775efc1e921fac785e823 Mon Sep 17 00:00:00 2001 From: snyk-bot Date: Fri, 19 Jan 2024 07:12:22 + Subject: [PATCH 1/6] feat: upgrade vscode-languageclient from 8.0.2-next.5 to 9.0.1 Snyk

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Félix-Antoine Constantin via cfe-commits
@@ -0,0 +1,189 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[flang] [lld] [clang] [libcxxabi] [compiler-rt] [libc] [llvm] [clang-tools-extra] [libcxx] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2205,93 +2230,141 @@ void SampleProfileMatcher::countMismatchedSamples(const FunctionSamples &FS) { countMismatchedSamples(CS.second); } -void SampleProfileMatcher::countProfileMismatches( -const Function &F, const FunctionSamples &FS, -const std::map &IRAnc

[libc] [libcxx] [lld] [compiler-rt] [flang] [clang] [libcxxabi] [llvm] [clang-tools-extra] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { + const Module &M; + SampleProfileReader &Reader; + const PseudoProbeManager *ProbeManager; + +public: + ProfileM

[libc] [lld] [llvm] [compiler-rt] [libcxx] [flang] [clang-tools-extra] [libcxxabi] [clang] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2205,93 +2230,141 @@ void SampleProfileMatcher::countMismatchedSamples(const FunctionSamples &FS) { countMismatchedSamples(CS.second); } -void SampleProfileMatcher::countProfileMismatches( -const Function &F, const FunctionSamples &FS, -const std::map &IRAnc

[flang] [lld] [clang] [libcxxabi] [compiler-rt] [libc] [llvm] [clang-tools-extra] [libcxx] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { + const Module &M; + SampleProfileReader &Reader; + const PseudoProbeManager *ProbeManager; + +public: + ProfileM

[libcxx] [llvm] [lld] [libc] [flang] [clang-tools-extra] [clang] [compiler-rt] [libcxxabi] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { + const Module &M; + SampleProfileReader &Reader; + const PseudoProbeManager *ProbeManager; + +public: + ProfileM

[clang-tools-extra] [clang] [libc] [flang] [libcxxabi] [libcxx] [lld] [llvm] [compiler-rt] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { WenleiHe wrote: I was mostly thinking about a simple struct to encapsulate different stats, while

[llvm] [libcxxabi] [clang] [lld] [compiler-rt] [libcxx] [flang] [libc] [clang-tools-extra] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2460,63 +2528,108 @@ void SampleProfileMatcher::runOnFunction(const Function &F) { !ProbeManager->profileIsValid(F, *FSFlattened)) { // The matching result will be saved to IRToProfileLocationMap, create a new // map for each function. +auto &IRToProfile

[libcxx] [clang-tools-extra] [flang] [compiler-rt] [libc] [llvm] [libcxxabi] [lld] [clang] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2205,93 +2230,141 @@ void SampleProfileMatcher::countMismatchedSamples(const FunctionSamples &FS) { countMismatchedSamples(CS.second); } -void SampleProfileMatcher::countProfileMismatches( -const Function &F, const FunctionSamples &FS, -const std::map &IRAnc

[llvm] [clang] [compiler-rt] [libcxx] [clang-tools-extra] [libcxxabi] [lld] [libc] [flang] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -433,6 +433,44 @@ using CandidateQueue = PriorityQueue, CandidateComparer>; +// Profile matching statstics. +class ProfileMatchStats { + const Module &M; + SampleProfileReader &Reader; + const PseudoProbeManager *ProbeManager; + +public: + ProfileM

[clang-tools-extra] [llvm] [clang] [libc] [compiler-rt] [flang] [lld] [libcxx] [libcxxabi] [CSSPGO] Compute and report post-match profile staleness (PR #79090)

2024-01-27 Thread via cfe-commits
@@ -2205,93 +2230,141 @@ void SampleProfileMatcher::countMismatchedSamples(const FunctionSamples &FS) { countMismatchedSamples(CS.second); } -void SampleProfileMatcher::countProfileMismatches( -const Function &F, const FunctionSamples &FS, -const std::map &IRAnc

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,238 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,238 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,195 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[llvm] [clang-tools-extra] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-27 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,189 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[mlir] [clang] [llvm] Fix unsigned typos (PR #76670)

2024-01-27 Thread via cfe-commits
Rageking8 wrote: Is this PR ready to merge? https://github.com/llvm/llvm-project/pull/76670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Resolve redundant predicates (PR #79701)

2024-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Rageking8) Changes Fixes #79686 --- Full diff: https://github.com/llvm/llvm-project/pull/79701.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaChecking.cpp (+4-4) ``diff diff --git a/clang/lib/Sema/SemaChecking.c

[clang] Resolve redundant predicates (PR #79701)

2024-01-27 Thread via cfe-commits
https://github.com/Rageking8 created https://github.com/llvm/llvm-project/pull/79701 Fixes #79686 >From 6d0591f238444674f327ca502a93ad72bdd46110 Mon Sep 17 00:00:00 2001 From: Rageking8 <106309953+rageki...@users.noreply.github.com> Date: Sun, 28 Jan 2024 02:06:39 +0800 Subject: [PATCH] Resolve

[clang] e976053 - [clang, SystemZ] Fix test case for buildbot.

2024-01-27 Thread Jonas Paulsson via cfe-commits
Author: Jonas Paulsson Date: 2024-01-27T19:02:36+01:00 New Revision: e976053a63c251e9b65733ed3574e5c3de62084c URL: https://github.com/llvm/llvm-project/commit/e976053a63c251e9b65733ed3574e5c3de62084c DIFF: https://github.com/llvm/llvm-project/commit/e976053a63c251e9b65733ed3574e5c3de62084c.diff

[clang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes This is a follow-up for the comparison of constraints on out-of-line function template definitions. We require the instantiation of a ParmVarDecl while transforming the expression if that Decl gets reference

[clang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-27 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/79698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-27 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/79698 This is a follow-up for the comparison of constraints on out-of-line function template definitions. We require the instantiation of a ParmVarDecl while transforming the expression if that Decl gets referenced by

[clang] [llvm] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2024-01-27 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 closed https://github.com/llvm/llvm-project/pull/73511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 34dd8ec - [clang, SystemZ] Support -munaligned-symbols (#73511)

2024-01-27 Thread via cfe-commits
Author: Jonas Paulsson Date: 2024-01-27T18:29:37+01:00 New Revision: 34dd8ec8aec17965313b17308faaa6272c235c53 URL: https://github.com/llvm/llvm-project/commit/34dd8ec8aec17965313b17308faaa6272c235c53 DIFF: https://github.com/llvm/llvm-project/commit/34dd8ec8aec17965313b17308faaa6272c235c53.diff

[clang] [llvm] [clang, SystemZ] Pass HasDef flag to getMinGlobalAlign(). (PR #73511)

2024-01-27 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: Thanks for review! https://github.com/llvm/llvm-project/pull/73511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [mlir] [flang] [compiler-rt] [libc] [libcxx] [clang-tools-extra] [lld] [llvm] [clang] [mlir][transform] Add elementwise criteria to `match.structured.body` (PR #79626)

2024-01-27 Thread via cfe-commits
https://github.com/srcarroll updated https://github.com/llvm/llvm-project/pull/79626 >From ab475c9ffb7c3562bad4772389e97b82e9f110c0 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 26 Jan 2024 11:55:06 -0600 Subject: [PATCH 1/3] Add elementwise criteria to match.structured.body --- .../Linalg/Tr

[clang] [llvm] [clang-tools-extra] [mlir] fix vulnerabilities (PR #79697)

2024-01-27 Thread via cfe-commits
https://github.com/NxPKG updated https://github.com/llvm/llvm-project/pull/79697 >From f7b4f61db6016a1a02d775efc1e921fac785e823 Mon Sep 17 00:00:00 2001 From: snyk-bot Date: Fri, 19 Jan 2024 07:12:22 + Subject: [PATCH 1/6] feat: upgrade vscode-languageclient from 8.0.2-next.5 to 9.0.1 Snyk

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 718aac9 - [clang][Diagnostics] Highlight code snippets (#66514)

2024-01-27 Thread via cfe-commits
Author: Timm Baeder Date: 2024-01-27T17:52:20+01:00 New Revision: 718aac9f7a19227b5c5ec85819a3a5ae24ce32e1 URL: https://github.com/llvm/llvm-project/commit/718aac9f7a19227b5c5ec85819a3a5ae24ce32e1 DIFF: https://github.com/llvm/llvm-project/commit/718aac9f7a19227b5c5ec85819a3a5ae24ce32e1.diff L

[clang] [llvm] [clang-tools-extra] [mlir] fix vulnerabilities (PR #79697)

2024-01-27 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it i

[clang] [llvm] [clang-tools-extra] [mlir] fix vulnerabilities (PR #79697)

2024-01-27 Thread via cfe-commits
https://github.com/NxPKG created https://github.com/llvm/llvm-project/pull/79697 [feat: upgrade vscode-languageclient from 8.0.2-next.5 to 9.0.1](https://github.com/llvm/llvm-project/commit/f7b4f61db6016a1a02d775efc1e921fac785e823) [fix: upgrade chokidar from 3.5.2 to 3.5.3](https://github.com/

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
https://github.com/cor3ntin commented: For the C changes, we should make sure we implement the relevant changes of https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3029.htm and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3030.htm https://github.com/llvm/llvm-project/pull/78742

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
@@ -19807,20 +19807,46 @@ EnumConstantDecl *Sema::CheckEnumConstant(EnumDecl *Enum, // sufficient to contain the incremented value. If no such type // exists, the program is ill-formed. QualType T = getNextLargerIntegralType(Context, EltTy);

[clang] [clang][Sema] Fix for enums overflowing (#24667) (PR #78742)

2024-01-27 Thread via cfe-commits
@@ -19807,20 +19807,46 @@ EnumConstantDecl *Sema::CheckEnumConstant(EnumDecl *Enum, // sufficient to contain the incremented value. If no such type // exists, the program is ill-formed. QualType T = getNextLargerIntegralType(Context, EltTy);

  1   2   >