[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

2024-01-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dc4483659fc51890fdc732acc66a4dcda6e68047 046ec7d3e8f509d830e2e6081d697415859811c2 --

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: The deep shade of blue doesn't make sense for both light and dark backgrounds: ![image](https://github.com/llvm/llvm-project/assets/12883766/e9ee6658-1ab1-422f-914b-5f95cac3846d) ![image](https://github.com/llvm/llvm-project/assets/12883766/986ae6f4-2fa9-4d2a-b661-47de3bf92cde) It

[clang] [clang] Only set the trailing bytes to zero when filling a partially … (PR #79502)

2024-01-30 Thread Eli Friedman via cfe-commits
@@ -1209,8 +1301,21 @@ static void emitStoresForConstant(CodeGenModule &CGM, const VarDecl &D, // If the initializer is all or mostly the same, codegen with bzero / memset // then do a few stores afterward. if (shouldUseBZeroPlusStoresToInitialize(constant, ConstantSize)

[clang] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf (PR #79959)

2024-01-30 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/79959 >From beb1a4b89f941f41a6e220447dcda6d6fc231a0b Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Tue, 30 Jan 2024 15:57:35 +0800 Subject: [PATCH] [C++20] [Modules] Introduce -fskip-odr-check-in-gmf Close https:

[clang] [llvm] [clang-tools-extra] [AMDGPU] CodeGen for GFX12 S_WAIT_* instructions (PR #77438)

2024-01-30 Thread via cfe-commits
kalvdans wrote: @jayfoad, can you link to the documentation where these new registers are described? Preferably from a comment in the top of the file(s). It would make it easier to review for correctness. https://github.com/llvm/llvm-project/pull/77438 _

[llvm] [clang] [clang-tools-extra] [AMDGPU] CodeGen for GFX12 S_WAIT_* instructions (PR #77438)

2024-01-30 Thread Jay Foad via cfe-commits
jayfoad wrote: > @jayfoad, can you link to the documentation where these new registers are > described? Preferably from a comment in the top of the file(s). It would make > it easier to review for correctness. ISA documentation will be linked from https://llvm.org/docs/AMDGPUUsage.html#additi

[libc] [libcxx] [compiler-rt] [lldb] [flang] [clang-tools-extra] [lld] [clang] [llvm] LLVM_FAULTMAPS section can be put after the DWARF section. (PR #77107)

2024-01-30 Thread Rafael Ávila de Espíndola via cfe-commits
espindola wrote: I no longer work on llvm: https://lists.llvm.org/pipermail/llvm-dev/2018-May/122922.html shamithoke ***@***.***> writes: > @espindola > > -- > Reply to this email directly or view it on GitHub: > https://github.com/llvm/llvm-project/pull/77107#issuecomment-1914952526 > You

[llvm] [clang-tools-extra] [clang] [AArch64] Implement -fno-plt for SelectionDAG/GlobalISel (PR #78890)

2024-01-30 Thread Matt Arsenault via cfe-commits
@@ -1293,8 +1293,19 @@ bool AArch64CallLowering::lowerCall(MachineIRBuilder &MIRBuilder, !Subtarget.noBTIAtReturnTwice() && MF.getInfo()->branchTargetEnforcement()) Opc = AArch64::BLR_BTI; - else + else { +// For an intrinsic call (e.g. memset),

[llvm] [clang] [PowerPC] AIX TLS allow per function configuration of initial-exec or local-dynamic model (PR #79968)

2024-01-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d1a83ff3e0274f26746e874d480c866bec3818d6 adb312f724f4e76a4edc0e931ffd5f3b8358ea7c --

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Does it look that bad in your local terminal as well? It's okay-ish with the default colors here: ![Screenshot from 2024-01-30 09-48-38](https://github.com/llvm/llvm-project/assets/49720664/ca6fb7d1-d729-4fea-b0fd-0385b0e5fba2) We might have to file a bug against compiler-explo

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-01-30 Thread Nikita Popov via cfe-commits
nikic wrote: > Until this change we sailed fairly well. It seems that the pcm rigorously > records the clang notion of the triple which is probably what we want. > However, if we are building a pcm in the context of `clang-repl` would it > make sense to use the `getProcessTriple` notion for th

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-01-30 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: We have a `LangOption` called `IncrementalExtensions`. We might be able to use it there. https://github.com/llvm/llvm-project/pull/79261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > > > > As far as I can tell from [#76774 > > > > > (comment)](https://github.com/llvm/llvm-project/pull/76774#issuecomment-1914177330) > > > > > above, the last push only changed the default value of > > > > > `LoadExternalSpecializationsLazily`. In that case, my test resu

[clang] 597f56f - [clang][AST][NFC] Take const CXXRecordDecl* in ComparisonCategories

2024-01-30 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-30T10:03:51+01:00 New Revision: 597f56f309815bcda9f38dd6040d7c7e0e520547 URL: https://github.com/llvm/llvm-project/commit/597f56f309815bcda9f38dd6040d7c7e0e520547 DIFF: https://github.com/llvm/llvm-project/commit/597f56f309815bcda9f38dd6040d7c7e0e520547.diff LO

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-01-30 Thread Dinar Temirbulatov via cfe-commits
https://github.com/dtemirbulatov updated https://github.com/llvm/llvm-project/pull/79842 >From af323998a63a72f569d543cf5167d5d28e784682 Mon Sep 17 00:00:00 2001 From: Dinar Temirbulatov Date: Mon, 29 Jan 2024 14:43:13 + Subject: [PATCH 1/2] [Clang][AArch64] Warn when calling streaming/non-

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: It looks a tinybit better in my local terminal, but still significantly harder to read than the rest of the text: ![image](https://github.com/llvm/llvm-project/assets/12883766/5b0136a5-012b-47f5-b888-787d1c060d54) But it's a bit off the point. We should pick colors that have good

[clang] [cfi][CodeGen] Call SetLLVMFunctionAttributes{, ForDefinition} on __cf… (PR #78253)

2024-01-30 Thread Pavel Kosov via cfe-commits
kpdev wrote: Ping https://github.com/llvm/llvm-project/pull/78253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-01-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > IncrementalExtensions But the change itself is to make `IncrementalExtensions` a compatible lang options. So that we don't need to specify it when generating the modules. https://github.com/llvm/llvm-project/pull/79261 ___ cfe-com

[clang] [clang-format] Simplify the AfterPlacementOperator option (PR #79796)

2024-01-30 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/79796 >From d40f2ed71e72c9cee266e63abbae4b9aac1de47c Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 29 Jan 2024 00:43:19 -0800 Subject: [PATCH 1/2] [clang-format] Simplify the AfterPlacementOperator option Change A

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: > But it's a bit off the point. We should pick colors that have good contrast > against both light and dark color themes by default, and not ask everyone to > change their color palette. Also make sure to zoom out when you look at this > yourself: issue is more apparent this wa

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-01-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I am wondering if it helps if we specify the target triple in the test, then it won't be so troublesome. https://github.com/llvm/llvm-project/pull/79261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-30 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,168 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [clang] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-30 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,168 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-30 Thread Bhuminjay Soni via cfe-commits
@@ -0,0 +1,168 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-format] Simplify the AfterPlacementOperator option (PR #79796)

2024-01-30 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/79796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV][Clang] Added builtin support for experimental Zimop extension (PR #79971)

2024-01-30 Thread Jivan Hakobyan via cfe-commits
https://github.com/JivanH created https://github.com/llvm/llvm-project/pull/79971 This change adds builtin of mop.r.[n] and mop.rr.[n] instructions for Zimop extension based on https://github.com/riscv-non-isa/riscv-c-api-doc/blob/master/riscv-c-api.md. >From a2a37921c83511796e051520c887092a3

[clang] [RISCV][Clang] Added builtin support for experimental Zimop extension (PR #79971)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Jivan Hakobyan (JivanH) Changes This change adds builtin of mop.r.[n] and mop.rr.[n] instructions for Zimop extension based on https://github.com/riscv-non-isa/riscv-c-api-doc/blob/master/riscv-c-api.md.

[clang] [RISCV][Clang] Added builtin support for experimental Zimop extension (PR #79971)

2024-01-30 Thread Jivan Hakobyan via cfe-commits
JivanH wrote: Please review @topperc @wangpc-pp @dtcxzyw https://github.com/llvm/llvm-project/pull/79971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang-tools-extra] Add clang-tidy check to suggest replacement of conditional statement with std::min/std::max (PR #77816)

2024-01-30 Thread Bhuminjay Soni via cfe-commits
11happy wrote: > Other thing is that reviewer should mark issues as resolved after checking > with code, not author. Otherwise is hard to figure out what's done and what's > not. Adding some comment like "Done" is sufficient usually unless issues are > simple. > > Next thing regarding your 2

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-01-30 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > > IncrementalExtensions > > But the change itself is to make `IncrementalExtensions` a compatible lang > options. So that we don't need to specify it when generating the modules. I mean conditionally if `IncrementalExtensions` is set we change the target triple in the clan

[clang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-30 Thread Younan Zhang via cfe-commits
zyn0217 wrote: I've seen `llvm-libc++-shared.cfg.in :: libcxx/gdb/gdb_pretty_printer_test.sh.cpp` was failing intermittently on CI recently, which turned out to be unrelated to Concepts. In case I missed anything, I've run the libcxx tests locally, which are all green. ```txt Testing Time: 14

[lld] [flang] [clang] [clang-tools-extra] [libc] [libcxx] [llvm] [lldb] [compiler-rt] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/79698 >From 39f64e6fa02392415f0e2776166d4451346e7e81 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 28 Jan 2024 01:17:32 +0800 Subject: [PATCH] [concepts] Set up an instantiation scope for constraint expressio

[flang] [mlir] [libcxxabi] [clang] [clang-tools-extra] [libc] [libcxx] [llvm] [openmp] [compiler-rt] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-30 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/78632 >From a786cdedc2c9a9898cd0b80d84f5b11aace5da1c Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Tue, 28 Nov 2023 15:44:02 + Subject: [PATCH 1/7] [AArch64] Add custom lowering for load <3 x i8>. Add custom comb

[lld] [flang] [clang] [clang-tools-extra] [libc] [libcxx] [llvm] [lldb] [compiler-rt] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-30 Thread Younan Zhang via cfe-commits
zyn0217 wrote: I'll try the CI again before landing it. https://github.com/llvm/llvm-project/pull/79698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Ah, I see where the limitation comes from. According to [Wikipedia](https://en.wikipedia.org/wiki/ANSI_escape_code#3-bit_and_4-bit), there is bright blue color which many terminals display differently from regular blue. While this means we're expanding 3-bit color palette to 4-b

[clang] [clang-format] Handle generic selections inside parentheses (PR #79785)

2024-01-30 Thread Owen Pan via cfe-commits
@@ -1694,8 +1694,11 @@ void ContinuationIndenter::moveStatePastFakeLParens(LineState &State, // Special case for generic selection expressions, its comma-separated // expressions are not aligned to the opening paren like regular calls, but // rather continuation-in

[compiler-rt] [llvm] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-01-30 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/79086 >From b5c8579c5c8e7ea1e8436348bbf60ecee9c3c799 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 19 Jan 2024 09:22:27 +0800 Subject: [PATCH 1/3] [X86] Support more ISAs to enable __builtin_cpu_supports This

[compiler-rt] [llvm] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-01-30 Thread Freddy Ye via cfe-commits
@@ -750,13 +750,16 @@ unsigned llvm::X86::getFeaturePriority(ProcessorFeatures Feat) { #ifndef NDEBUG // Check that priorities are set properly in the .def file. We expect that // "compat" features are assigned non-duplicate consecutive priorities - // starting from zero

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-01-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > > IncrementalExtensions > > > > > > But the change itself is to make `IncrementalExtensions` a compatible lang > > options. So that we don't need to specify it when generating the modules. > > I mean conditionally if `IncrementalExtensions` is set we change the target >

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Yeah, I read that too when first working on this. Let me try some stuff. https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5877949 - [clang][AST][NFC] Make FieldDecl in SubobjectAdjustment const

2024-01-30 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-30T10:36:24+01:00 New Revision: 58779495d3613386398fc70faeb098674d7757b5 URL: https://github.com/llvm/llvm-project/commit/58779495d3613386398fc70faeb098674d7757b5 DIFF: https://github.com/llvm/llvm-project/commit/58779495d3613386398fc70faeb098674d7757b5.diff LO

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: I also got in touch with Compiler Explorer devs. They should be able to pick a better color to render ANSI blue. https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [RISCV][Clang] Added builtin support for experimental Zimop extension (PR #79971)

2024-01-30 Thread Jim Lin via cfe-commits
@@ -21189,6 +21189,10 @@ Value *CodeGenFunction::EmitRISCVBuiltinExpr(unsigned BuiltinID, case RISCV::BI__builtin_riscv_clmulh_64: case RISCV::BI__builtin_riscv_clmulr_32: case RISCV::BI__builtin_riscv_clmulr_64: + case RISCV::BI__builtin_riscv_mopr_32:

[clang] [clang][Interp] Fix MemberExpr initializing an existing value (PR #79973)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/79973 This is similar to c1ad363e6eba308fa94c47374ee98b3c79693a35, but with the additional twist that initializing an existing value from a `MemberExpr` was not working correctly. >From 0e729521b99147d66d8a1aa2c4d33

[clang] [clang][Interp] Fix MemberExpr initializing an existing value (PR #79973)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This is similar to c1ad363e6eba308fa94c47374ee98b3c79693a35, but with the additional twist that initializing an existing value from a `MemberExpr` was not working correctly. --- Full diff: https://github.co

[clang] e9e1a72 - [Sema] Restructure and extend the testing of template pack deduction (#79881)

2024-01-30 Thread via cfe-commits
Author: Gábor Spaits Date: 2024-01-30T10:46:02+01:00 New Revision: e9e1a72c22181993edf5bd0b660538081c2cdfb5 URL: https://github.com/llvm/llvm-project/commit/e9e1a72c22181993edf5bd0b660538081c2cdfb5 DIFF: https://github.com/llvm/llvm-project/commit/e9e1a72c22181993edf5bd0b660538081c2cdfb5.diff

[clang] [Sema] Restructure and extend the testing of template pack deduction (PR #79881)

2024-01-30 Thread Gábor Spaits via cfe-commits
https://github.com/spaits closed https://github.com/llvm/llvm-project/pull/79881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libc] [mlir] [flang] [clang] [openmp] [clang-tools-extra] [libcxxabi] [libcxx] [compiler-rt] [llvm] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-30 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/78632 >From a786cdedc2c9a9898cd0b80d84f5b11aace5da1c Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Tue, 28 Nov 2023 15:44:02 + Subject: [PATCH 1/9] [AArch64] Add custom lowering for load <3 x i8>. Add custom comb

[libc] [mlir] [flang] [clang] [openmp] [clang-tools-extra] [libcxxabi] [libcxx] [compiler-rt] [llvm] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-30 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/78632 >From a786cdedc2c9a9898cd0b80d84f5b11aace5da1c Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Tue, 28 Nov 2023 15:44:02 + Subject: [PATCH 01/10] [AArch64] Add custom lowering for load <3 x i8>. Add custom co

[compiler-rt] [llvm] [clang] [X86] Support more ISAs to enable __builtin_cpu_supports (PR #79086)

2024-01-30 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/79086 >From b5c8579c5c8e7ea1e8436348bbf60ecee9c3c799 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Fri, 19 Jan 2024 09:22:27 +0800 Subject: [PATCH 1/4] [X86] Support more ISAs to enable __builtin_cpu_supports This

[libc] [mlir] [flang] [clang] [openmp] [clang-tools-extra] [libcxxabi] [libcxx] [compiler-rt] [llvm] [AArch64] Add custom lowering for load <3 x i8>. (PR #78632)

2024-01-30 Thread Florian Hahn via cfe-commits
fhahn wrote: Thanks for taking a look @TNorthover! I tried to address the comments, but with them addressed it turned out to not really be feasible to go down that path. I changed the codegen back to use the slightly longer (but using instructions that are cheaper/less complex usually) below,

[clang] f214933 - [FMV] Change feature priorities according to ACLE. (#79316)

2024-01-30 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-01-30T09:57:53Z New Revision: f214933bc538c719403804069941de301487c39b URL: https://github.com/llvm/llvm-project/commit/f214933bc538c719403804069941de301487c39b DIFF: https://github.com/llvm/llvm-project/commit/f214933bc538c719403804069941de301487c39b.di

[llvm] [clang] [FMV] Change feature priorities according to ACLE. (PR #79316)

2024-01-30 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/79316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[polly] [clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-30 Thread Owen Pan via cfe-commits
owenca wrote: Let's leave `None` alone and add `ExceptShortType`, e.g.: ``` --- a/clang/lib/Format/ContinuationIndenter.cpp +++ b/clang/lib/Format/ContinuationIndenter.cpp @@ -329,12 +329,18 @@ bool ContinuationIndenter::canBreak(const LineState &State) { // Don't break after very short retur

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-30 Thread Owen Pan via cfe-commits
owenca wrote: > Does it look like a genuine failure I should address or a spurious build > quirk? The latter. https://github.com/llvm/llvm-project/pull/79037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [clang] Improved isSimpleTypeSpecifier (PR #79037)

2024-01-30 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/79037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix MemberExpr initializing an existing value (PR #79973)

2024-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/79973 >From 46f91cbdda7d11ca597f3727151bd11232b0415f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 30 Jan 2024 08:50:34 +0100 Subject: [PATCH] [clang][Interp] Fix MemberExpr initializing an e

[clang] c61686e - [clang][NFC] Use no-param version of skipRValueSubobjectAdjustments

2024-01-30 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-01-30T11:25:28+01:00 New Revision: c61686e8abc2aee6e2e0ad09c6d1ade534e497b3 URL: https://github.com/llvm/llvm-project/commit/c61686e8abc2aee6e2e0ad09c6d1ade534e497b3 DIFF: https://github.com/llvm/llvm-project/commit/c61686e8abc2aee6e2e0ad09c6d1ade534e497b3.diff LO

[clang] [Clang][RISCV] Add assumptions to vsetvli/vsetvlimax (PR #79975)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang Author: Wang Pengcheng (wangpc-pp) Changes There are some assumptions of the return value of vsetvli/vsetvlimax, we add them via `llvm.assume` so that middle-end optimizations can benefit from them. --- Patch

[llvm] [clang] Revert "[RISCV] Relax march string order constraint" (PR #79976)

2024-01-30 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/79976 Reverts llvm/llvm-project#78120 Buildbot is broken: llvm/lib/Support/RISCVISAInfo.cpp:910:18: error: call to deleted constructor of 'llvm::Error' return E; ^ >From 193b711e4e1596c

[clang] 5a00cb1 - Revert "[RISCV] Relax march string order constraint" (#79976)

2024-01-30 Thread via cfe-commits
Author: Mehdi Amini Date: 2024-01-30T02:32:52-08:00 New Revision: 5a00cb1abfedbcc0fb60a9b11b4a9876160e3a92 URL: https://github.com/llvm/llvm-project/commit/5a00cb1abfedbcc0fb60a9b11b4a9876160e3a92 DIFF: https://github.com/llvm/llvm-project/commit/5a00cb1abfedbcc0fb60a9b11b4a9876160e3a92.diff L

[llvm] [clang] Revert "[RISCV] Relax march string order constraint" (PR #79976)

2024-01-30 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/79976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] Revert "[RISCV] Relax march string order constraint" (PR #79976)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang Author: Mehdi Amini (joker-eph) Changes Reverts llvm/llvm-project#78120 Buildbot is broken: llvm/lib/Support/RISCVISAInfo.cpp:910:18: error: call to deleted constructor of 'llvm::Error' return E;

[clang] Mention compilation database generator tool `basset` (PR #79758)

2024-01-30 Thread via cfe-commits
https://github.com/i-ky updated https://github.com/llvm/llvm-project/pull/79758 >From b75a4a9b0a125145f88df66f71b49514c9cb8b86 Mon Sep 17 00:00:00 2001 From: i-ky Date: Sun, 28 Jan 2024 18:12:14 +0200 Subject: [PATCH] Mention compilation database generator tool `basset` Its operation principles

[llvm] [clang] [RISCV] Relax march string order constraint (PR #78120)

2024-01-30 Thread Mehdi Amini via cfe-commits
joker-eph wrote: Sorry, had to revert because this broke a buildbot: ``` llvm/lib/Support/RISCVISAInfo.cpp:910:18: error: call to deleted constructor of 'llvm::Error' return E; ^ ``` https://lab.llvm.org/buildbot/#/builders/61/builds/53704 https://github.com/llvm/llvm-project/pull/78120 __

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

2024-01-30 Thread Timm Baeder via cfe-commits
tbaederr wrote: Nice, thanks! https://github.com/llvm/llvm-project/pull/66514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[polly] [clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-30 Thread via cfe-commits
rmarker wrote: Right, I'll look into adding `ExceptShortType`. https://github.com/llvm/llvm-project/pull/78011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-30 Thread Ilya Biryukov via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: rm -rf %t +// RUN: mkdir -p %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -std=c++20 -emit-module-interface %t/usings.cppm -o %t/usings.pcm +// RUN: %clang_cc1 -std=c++20 -fmodule-file=usings=%t/usings.pcm %t/use.cpp -verify -fsyntax-only -Wno-stac

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-30 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > Could you show the stack (omitting/annotating the repeated part) that leads > to failure? and/or the AST shape that leads to failure? See the test I added. All you need is ~10k overloads of a method in a class and a `using Base::func` in the derived class.\ The AST repre

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-30 Thread Ilya Biryukov via cfe-commits
@@ -4099,7 +4099,9 @@ Decl *ASTReader::ReadDeclRecord(DeclID ID) { // calls to Decl::getASTContext() by Decl's methods will find the // TranslationUnitDecl without crashing. D->setDeclContext(Context.getTranslationUnitDecl()); - Reader.Visit(D); + + // Reading some decl

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-30 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: > To make this testable, maybe we can refactor > `clang::runWithSufficientStackSpace` a little bit to make `DesiredStackSize` > and `isStackNearlyExhausted::SufficientStack` configurable. Maybe... As long as we only use this in tests. However, for this particular case, we

[polly] [clang] [clang-format] Add AllowShortType option for AlwaysBreakAfterReturnType. (PR #78011)

2024-01-30 Thread via cfe-commits
rmarker wrote: @owenca, thinking on it, do you think `NeverShortType` would be a better name? I'm wondering whether `ExceptShortType` could imply that non-short return types are always broken after. https://github.com/llvm/llvm-project/pull/78011 ___

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread Jay Foad via cfe-commits
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/79980 None >From cace712a8f379df3498dd76bc1f95eb4671e997c Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Tue, 30 Jan 2024 11:04:33 + Subject: [PATCH] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins --- clang

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang Author: Jay Foad (jayfoad) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/79980.diff 4 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsAMDGPU.def (+17-17) - (modified) clang

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-30 Thread Chuanqi Xu via cfe-commits
@@ -4099,7 +4099,9 @@ Decl *ASTReader::ReadDeclRecord(DeclID ID) { // calls to Decl::getASTContext() by Decl's methods will find the // TranslationUnitDecl without crashing. D->setDeclContext(Context.getTranslationUnitDecl()); - Reader.Visit(D); + + // Reading some decl

[clang] [Serialization] Check for stack exhaustion when reading declarations (PR #79875)

2024-01-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > I am not saying it's a bad idea to add this for testing purposes, but given > how fragile this approach is, I think we should not provide configuration > knobs to users there. At least everyone sees crashes at roughly the same > points right now (although variation is still

[llvm] [clang] [FMV] Change feature priorities according to ACLE. (PR #79316)

2024-01-30 Thread Alexandros Lamprineas via cfe-commits
@@ -659,21 +659,21 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._Mfp16fmlMsimd +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MsimdMfp16fml // CHECK-SAME: () #[[ATTR7]] { // CHECK-NEXT: entry: // CH

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-30 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/79981 Covers CWG issues 1150, 1487, 1567, 1738, 2273, 2277, 2356, 2504. On top of the wording in proposed resolutions, [P0136R1](https://wg21.link/p0136r1) "Rewording inheriting constructors (core issue 1941 et al)"

[clang] [clang][dataflow] Extend debug output for `Environment`. (PR #79982)

2024-01-30 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/79982 * Print `ReturnLoc`, `ReturnVal`, and `ThisPointeeLoc` if applicable. * For entries in `LocToVal` that correspond to declarations, print the names of the declarations next to them. I've removed the FIX

[clang] [clang] Add tests for DRs about inheriting constructors (PR #79981)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes Covers CWG issues 1150, 1487, 1567, 1738, 2273, 2277, 2356, 2504. On top of the wording in proposed resolutions, [P0136R1](https://wg21.link/p0136r1) "Rewording inheriting constructors (core issue 194

[clang] [clang][dataflow] Extend debug output for `Environment`. (PR #79982)

2024-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis @llvm/pr-subscribers-clang Author: None (martinboehme) Changes * Print `ReturnLoc`, `ReturnVal`, and `ThisPointeeLoc` if applicable. * For entries in `LocToVal` that correspond to declarations, print the names of the declarations nex

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-30 Thread via cfe-commits
zmodem wrote: Thanks! It would be great to get this landed as soon as possible to unbreak trunk. (I believe we need it for the 18.x branch too?) https://github.com/llvm/llvm-project/pull/79764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang][dataflow] Extend debug output for `Environment`. (PR #79982)

2024-01-30 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/79982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [concepts] Push a CurContext before substituting into out-of-line constraints for comparison (PR #79985)

2024-01-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/79985 `InjectedClassNameType` is such that every template specialization within the Record scope ought to canonicalize to it, as outlined above the definition of that Type. This invariant is maintained during the tre

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread Christudasan Devadasan via cfe-commits
@@ -21,14 +21,14 @@ void test_amdgcn_wmma_f32_16x16x16_bf16_w64(global v4f* out4f, v16h a16h, v16h b global v8s* out8s, v4i a4i, v4i b4i, v8s c8s, global v4i* out4i, v2i a2i, v2i b2i, v4i

[lld] [clang] [llvm] [lldb] [clang-tools-extra] [libc] [compiler-rt] [libcxx] [flang] [concepts] Push a CurContext before substituting into out-of-line constraints for comparison (PR #79985)

2024-01-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/79985 >From 7ee1874af426d7879d218c6b8852fca0a87b1836 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 30 Jan 2024 18:49:08 +0800 Subject: [PATCH] [concepts] Push a CurContext before substituting into out-of-line

[clang] 04d20b1 - [concepts] Set up an instantiation scope for constraint expression comparison (#79698)

2024-01-30 Thread via cfe-commits
Author: Younan Zhang Date: 2024-01-30T19:34:52+08:00 New Revision: 04d20b17050203e07394b4f9ee61b5affe2d5347 URL: https://github.com/llvm/llvm-project/commit/04d20b17050203e07394b4f9ee61b5affe2d5347 DIFF: https://github.com/llvm/llvm-project/commit/04d20b17050203e07394b4f9ee61b5affe2d5347.diff

[lld] [clang] [llvm] [lldb] [clang-tools-extra] [libc] [compiler-rt] [libcxx] [flang] [concepts] Set up an instantiation scope for constraint expression comparison (PR #79698)

2024-01-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/79698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [libc] [lldb] [llvm] [clang-tools-extra] [flang] [libcxx] [compiler-rt] [concepts] Push a CurContext before substituting into out-of-line constraints for comparison (PR #79985)

2024-01-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/79985 >From 7ee1874af426d7879d218c6b8852fca0a87b1836 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 30 Jan 2024 18:49:08 +0800 Subject: [PATCH] [concepts] Push a CurContext before substituting into out-of-line

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-30 Thread Balazs Benics via cfe-commits
steakhal wrote: > Thanks! It would be great to get this landed as soon as possible to unbreak > trunk. (I believe we need it for the 18.x branch too?) I'll take care of the backport, after this PR is merged by @bolshakov-a https://github.com/llvm/llvm-project/pull/79764 ___

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread Piotr Sobczak via cfe-commits
piotrAMD wrote: Do you think it makes sense to add two gfx11 tests where _w32 variant is now rejected with w64, and _w64 variant rejected with w32? Maybe what is being printed in *-gfx10-err.cl test is enough, though. https://github.com/llvm/llvm-project/pull/79980

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-30 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: I'm just waiting for someone who would do it instead of me... I don't have commit access. https://github.com/llvm/llvm-project/pull/79764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread Jay Foad via cfe-commits
@@ -21,14 +21,14 @@ void test_amdgcn_wmma_f32_16x16x16_bf16_w64(global v4f* out4f, v16h a16h, v16h b global v8s* out8s, v4i a4i, v4i b4i, v8s c8s, global v4i* out4i, v2i a2i, v2i b2i, v4i

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread Jay Foad via cfe-commits
jayfoad wrote: > Do you think it makes sense to add two gfx11 tests where _w32 variant is now > rejected with w64, and _w64 variant rejected with w32? Maybe, but i didn't have the energy to add yet more tests. > Maybe what is being printed in *-gfx10-err.cl test is enough, though. Right, that

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread Piotr Sobczak via cfe-commits
https://github.com/piotrAMD approved this pull request. https://github.com/llvm/llvm-project/pull/79980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ef67f63 - Fix analyzer crash on 'StructuralValue' (#79764)

2024-01-30 Thread via cfe-commits
Author: Andrey Ali Khan Bolshakov Date: 2024-01-30T13:03:55+01:00 New Revision: ef67f63fa5f950f4056b5783e92e137342805d74 URL: https://github.com/llvm/llvm-project/commit/ef67f63fa5f950f4056b5783e92e137342805d74 DIFF: https://github.com/llvm/llvm-project/commit/ef67f63fa5f950f4056b5783e92e137342

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-30 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/79764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [mlir] [flang] [llvm] [clang] [Flang][OpenMP] : Add a temporary lowering for workshare directive (PR #78268)

2024-01-30 Thread Tom Eccles via cfe-commits
tblah wrote: This patch also needs to remove the TODO here https://github.com/llvm/llvm-project/blob/ef67f63fa5f950f4056b5783e92e137342805d74/flang/lib/Lower/OpenMP.cpp#L3550 https://github.com/llvm/llvm-project/pull/78268 ___ cfe-commits mailing list

[clang] [AMDGPU] Check wavefrontsize for GFX11 WMMA builtins (PR #79980)

2024-01-30 Thread Christudasan Devadasan via cfe-commits
https://github.com/cdevadas approved this pull request. https://github.com/llvm/llvm-project/pull/79980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix analyzer crash on 'StructuralValue' (PR #79764)

2024-01-30 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: Thanks! https://github.com/llvm/llvm-project/pull/79764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   7   >