[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread S. Bharadwaj Yadavalli via cfe-commits
@@ -831,6 +831,40 @@ uint64_t3 reversebits(uint64_t3); _HLSL_BUILTIN_ALIAS(__builtin_elementwise_bitreverse) uint64_t4 reversebits(uint64_t4); +//===--===// +// frac builtins

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread S. Bharadwaj Yadavalli via cfe-commits
@@ -0,0 +1,43 @@ +; RUN: opt -S -dxil-op-lower < %s | FileCheck %s + +; Make sure dxil operation function calls for round are generated for float and half. +; CHECK:call float @dx.op.unary.f32(i32 26, float %{{.*}}) +; CHECK:call half @dx.op.unary.f16(i32 26, half %{{.*}}) +

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy approved this pull request. A few simple suggestions. Otherwise looks good. https://github.com/llvm/llvm-project/pull/83570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread S. Bharadwaj Yadavalli via cfe-commits
https://github.com/bharadwajy edited https://github.com/llvm/llvm-project/pull/83570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprEngineCXX] Fix crash on dereference invalid return value of getAdjustedParameterIndex() (PR #83585)

2024-03-01 Thread via cfe-commits
https://github.com/mzyKi updated https://github.com/llvm/llvm-project/pull/83585 >From 6a9f7a996c127462fa787a2626bc0676d4e04ff3 Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Fri, 1 Mar 2024 22:45:20 +0800 Subject: [PATCH] [clang][ExprEngineCXX] Fix crash on dereference invalid return value

[clang] [clang][ExprEngineCXX] Fix crash on dereference invalid return value of getAdjustedParameterIndex() (PR #83585)

2024-03-01 Thread via cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/83585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprEngineCXX] Fix crash on dereference invalid return value of getAdjustedParameterIndex() (PR #83585)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-static-analyzer-1 Author: Exile (mzyKi) Changes fix #78810 --- Full diff: https://github.com/llvm/llvm-project/pull/83585.diff 2 Files Affected: - (modified) clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp (+7-2) -

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > @philnik777 - thank you for the patch at #68324 You're welcome! FWIW I'd find a syntax like `_ExtVector` better. The underscore and upper case to make it clear that it's non-standard and the angle bracket syntax since it's kind-of a template. This unfortunately doesn't

[clang] [clang][ExprEngineCXX] Fix crash on dereference invalid return value of getAdjustedParameterIndex() (PR #83585)

2024-03-01 Thread via cfe-commits
https://github.com/mzyKi created https://github.com/llvm/llvm-project/pull/83585 fix #78810 >From f0291dde10251269627022a9b7331211a3d6a91f Mon Sep 17 00:00:00 2001 From: miaozhiyuan Date: Fri, 1 Mar 2024 22:45:20 +0800 Subject: [PATCH] [clang][ExprEngineCXX] Fix crash on dereference invalid

[clang] b92c3fe - [OpenMP] Fix test after updating library search paths (#83573)

2024-03-01 Thread via cfe-commits
Author: Joseph Huber Date: 2024-03-01T09:48:14-06:00 New Revision: b92c3fe0274f3ba3bb7c58a8529bd9c4303a3b51 URL: https://github.com/llvm/llvm-project/commit/b92c3fe0274f3ba3bb7c58a8529bd9c4303a3b51 DIFF: https://github.com/llvm/llvm-project/commit/b92c3fe0274f3ba3bb7c58a8529bd9c4303a3b51.diff

[clang] 2b4d67b - [Clang][Sema]: Allow copy constructor side effects (#81127)

2024-03-01 Thread via cfe-commits
Author: Vinayak Dev Date: 2024-03-01T10:40:46-05:00 New Revision: 2b4d67bf59d609321701540a15f48eda04688652 URL: https://github.com/llvm/llvm-project/commit/2b4d67bf59d609321701540a15f48eda04688652 DIFF: https://github.com/llvm/llvm-project/commit/2b4d67bf59d609321701540a15f48eda04688652.diff

[clang] Issue #63106: [сlang] Representation of ellipsis in AST (PR #80976)

2024-03-01 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Hi @cor3ntin , I tried but didn't work as per design, Can you pls review this > , I m not updating the Decl , updating the VarDecl I'd like more information on what was tried and why it didn't work. It would be better for us to associate the data with catch statements

[clang] [OpenMP] Fix test after updating library search paths (PR #83573)

2024-03-01 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/83573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli updated https://github.com/llvm/llvm-project/pull/83584 >From 2b4d67bf59d609321701540a15f48eda04688652 Mon Sep 17 00:00:00 2001 From: Vinayak Dev <104419489+vinayakd...@users.noreply.github.com> Date: Fri, 1 Mar 2024 21:10:46 +0530 Subject: [PATCH 1/3]

[clang] [OpenMP] Fix test after updating library search paths (PR #83573)

2024-03-01 Thread Björn Pettersson via cfe-commits
https://github.com/bjope approved this pull request. https://github.com/llvm/llvm-project/pull/83573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 06bd74b - Fix implementation of [temp.param]p14's first sentence. (#83487)

2024-03-01 Thread via cfe-commits
Author: Erich Keane Date: 2024-03-01T07:27:06-08:00 New Revision: 06bd74ba4ac5229f01b64772b49e025be5eb7b53 URL: https://github.com/llvm/llvm-project/commit/06bd74ba4ac5229f01b64772b49e025be5eb7b53 DIFF: https://github.com/llvm/llvm-project/commit/06bd74ba4ac5229f01b64772b49e025be5eb7b53.diff

[clang] [OpenMP] Fix test after updating library search paths (PR #83573)

2024-03-01 Thread Björn Pettersson via cfe-commits
@@ -101,17 +101,6 @@ /// ### -/// Check that the warning is thrown when the libomptarget bitcode library is not found. -/// Libomptarget requires sm_52 or newer so an sm_52 bitcode library should never

[clang] a038f97 - [clang][Interp] Fix virtual calls with reference instance pointers

2024-03-01 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-01T16:19:45+01:00 New Revision: a038f9758e02812803b7efce10ecf784f9842bbb URL: https://github.com/llvm/llvm-project/commit/a038f9758e02812803b7efce10ecf784f9842bbb DIFF: https://github.com/llvm/llvm-project/commit/a038f9758e02812803b7efce10ecf784f9842bbb.diff

[clang] b0181be - [OpenACC] Implement Duffs-Device restriction for Compute Constructs (#83460)

2024-03-01 Thread via cfe-commits
Author: Erich Keane Date: 2024-03-01T07:11:17-08:00 New Revision: b0181be36cace3460e4ec5d0d11ecbf49484cc55 URL: https://github.com/llvm/llvm-project/commit/b0181be36cace3460e4ec5d0d11ecbf49484cc55 DIFF: https://github.com/llvm/llvm-project/commit/b0181be36cace3460e4ec5d0d11ecbf49484cc55.diff

[clang] [OpenMP] Fix test after updating library search paths (PR #83573)

2024-03-01 Thread Joseph Huber via cfe-commits
@@ -101,17 +101,6 @@ /// ### -/// Check that the warning is thrown when the libomptarget bitcode library is not found. -/// Libomptarget requires sm_52 or newer so an sm_52 bitcode library should never

[clang] [Clang][Sema]: Allow copy constructor side effects (PR #81127)

2024-03-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/81127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli edited https://github.com/llvm/llvm-project/pull/83584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Botond István Horváth via cfe-commits
@@ -14478,7 +14478,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2445.html;>2445 C++20 Partial ordering with rewritten candidates -Unknown +Clang 18 HoBoIs wrote: done

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Timm Baeder via cfe-commits
Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/83279 >From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Francesco Petrogalli via cfe-commits
fpetrogalli wrote: @philnik777 - thank you for the patch at https://github.com/llvm/llvm-project/pull/68324 I am extending the parser to be able to recognise clang extended vectors. Thanks! Francesco https://github.com/llvm/llvm-project/pull/83584

[clang] f15d799 - [clang][Interp] Fix variadic operator calls

2024-03-01 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-01T15:46:00+01:00 New Revision: f15d799f16092918b948536775475dfd8675c7d9 URL: https://github.com/llvm/llvm-project/commit/f15d799f16092918b948536775475dfd8675c7d9 DIFF: https://github.com/llvm/llvm-project/commit/f15d799f16092918b948536775475dfd8675c7d9.diff

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Francesco Petrogalli (fpetrogalli) Changes Clang extended vector types are mangled as follows: ext_vector_type_lanes_scalar type This is used to defetmine the builtins signature for builtins that use parmeters defined as typedef

[clang] [llvm] [openmp] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2024-03-01 Thread via cfe-commits
Munesanz wrote: > > This patch is now only for the front end. @shiltian @alexey-bataev, let us > > know what you think about landing just this. We are going to push another > > PR with the runtime changes, and that one will include numbers for > > performance. > > Hi! Can someone post a link

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli created https://github.com/llvm/llvm-project/pull/83584 Clang extended vector types are mangled as follows: ext_vector_type__ This is used to defetmine the builtins signature for builtins that use parmeters defined as typedef ext_vector_type__

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Vlad Serebrennikov via cfe-commits
Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -14478,7 +14478,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2445.html;>2445 C++20

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-03-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/83487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-03-01 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/83487 >From 1c443bec9f11c14f8971d5dcb03d12e50c080afc Mon Sep 17 00:00:00 2001 From: erichkeane Date: Thu, 29 Feb 2024 13:29:02 -0800 Subject: [PATCH 1/3] Fix implementation of [temp.param]p14's first sentence. The

[clang] f651f13 - [clang][Interp][NFC] Add precondition assertions

2024-03-01 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-01T15:41:49+01:00 New Revision: f651f134bbaec069968f6b12bdcdb5f7752fd700 URL: https://github.com/llvm/llvm-project/commit/f651f134bbaec069968f6b12bdcdb5f7752fd700 DIFF: https://github.com/llvm/llvm-project/commit/f651f134bbaec069968f6b12bdcdb5f7752fd700.diff

[clang] [OpenMP] Fix test after updating library search paths (PR #83573)

2024-03-01 Thread Björn Pettersson via cfe-commits
@@ -101,17 +101,6 @@ /// ### -/// Check that the warning is thrown when the libomptarget bitcode library is not found. -/// Libomptarget requires sm_52 or newer so an sm_52 bitcode library should never

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-03-01 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/83487 >From 1c443bec9f11c14f8971d5dcb03d12e50c080afc Mon Sep 17 00:00:00 2001 From: erichkeane Date: Thu, 29 Feb 2024 13:29:02 -0800 Subject: [PATCH 1/3] Fix implementation of [temp.param]p14's first sentence. The

[clang] e59681d - [clang][Interp] Allow inc/dec on boolean values

2024-03-01 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-01T15:40:45+01:00 New Revision: e59681d96327e2ed1963ec1c0f2bc3d40df26443 URL: https://github.com/llvm/llvm-project/commit/e59681d96327e2ed1963ec1c0f2bc3d40df26443 DIFF: https://github.com/llvm/llvm-project/commit/e59681d96327e2ed1963ec1c0f2bc3d40df26443.diff

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-03-01 Thread Vinayak Dev via cfe-commits
vinayakdsci wrote: Great catch! The usage of template instantiation didn't seem very obvious while adding the tests, and hence the missed test case. Thanks a lot for the fix! https://github.com/llvm/llvm-project/pull/83497 ___ cfe-commits mailing

[clang] [OpenACC] Implement Duffs-Device restriction for Compute Constructs (PR #83460)

2024-03-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/83460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Erich Keane via cfe-commits
Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate(

[clang] [clang-tools-extra] [flang] [lld] [llvm] [flang][clang] Add Visibility specific help text for options (PR #81869)

2024-03-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/81869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-03-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Thanks for the details, then LGTM with a release note added when landing. https://github.com/llvm/llvm-project/pull/83487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-03-01 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: My plan is to add tests to this PR, but if you want to land this sooner, I can do tests in a separate PR. https://github.com/llvm/llvm-project/pull/83487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-03-01 Thread Erich Keane via cfe-commits
erichkeane wrote: > The changes look correct to me, but I think we should add a DR test for this > so that we can properly regenerate cxx_dr_status.html > > Also, the changes should come with a release note. Ooof, yeah, forgot the release note. @Endilll has volunteered to do the DR test in

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Botond István Horváth via cfe-commits
https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Botond István Horváth via cfe-commits
@@ -14478,7 +14478,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2445.html;>2445 C++20 Partial ordering with rewritten candidates -Unknown +Clang 18 HoBoIs wrote: I'm on it. While we are at here:

[clang] [llvm] [openmp] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2024-03-01 Thread Terry Wilmarth via cfe-commits
TerryLWilmarth wrote: > This patch is now only for the front end. @shiltian @alexey-bataev, let us > know what you think about landing just this. We are going to push another PR > with the runtime changes, and that one will include numbers for performance. Hi! Can someone post a link here to

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread Xiang Li via cfe-commits
https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/83570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add `clang::behaves_like_std(...)` attribute (PR #76596)

2024-03-01 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: One question I have is related to: > Last year MSVC added [[msvc::intrinsic]] for us game devs > [here](https://github.com/MicrosoftDocs/cpp-docs/blob/main/docs/cpp/attributes.md#msvcintrinsic). > This was explicitly added as an attribute under the request of us since a >

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: in HIP headers, warpSize is defined with __AMDGCN_WAVEFRONT_SIZE and there are a bunch of uses of __AMDGCN_WAVEFRONT_SIZE or warpSize as constants: https://github.com/search?q=repo%3AROCm%2Fclr%20__AMDGCN_WAVEFRONT_SIZE=code These can be fixed relatively easily by conditioning

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread Xiang Li via cfe-commits
@@ -831,6 +831,40 @@ uint64_t3 reversebits(uint64_t3); _HLSL_BUILTIN_ALIAS(__builtin_elementwise_bitreverse) uint64_t4 reversebits(uint64_t4); +//===--===// +// frac builtins python3kgae

[clang] [openmp] [OpenMP] Respect LLVM per-target install directories (PR #83282)

2024-03-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Problem 1 can be solved by flipping the order. But Problem 2 would remain as > it doesn't depend on the order. https://github.com/llvm/llvm-project/pull/83573 I made a patch to fix it. https://github.com/llvm/llvm-project/pull/83282

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-03-01 Thread Aaron Ballman via cfe-commits
@@ -1847,19 +1847,33 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. -.. option:: -fcx-limited-range: - - This option enables the naive

[clang] dbf3d77 - [clang][Interp][NFC] Remove unused paramter

2024-03-01 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-01T15:28:15+01:00 New Revision: dbf3d779bdb3cc22652b6ab24ac9827e9f228f4e URL: https://github.com/llvm/llvm-project/commit/dbf3d779bdb3cc22652b6ab24ac9827e9f228f4e DIFF: https://github.com/llvm/llvm-project/commit/dbf3d779bdb3cc22652b6ab24ac9827e9f228f4e.diff

[clang] 18d2ff4 - [clang][Interp] Allow recursive intepretation

2024-03-01 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-03-01T15:28:14+01:00 New Revision: 18d2ff4be7898eaf666564dcca07ad6bd38ababf URL: https://github.com/llvm/llvm-project/commit/18d2ff4be7898eaf666564dcca07ad6bd38ababf DIFF: https://github.com/llvm/llvm-project/commit/18d2ff4be7898eaf666564dcca07ad6bd38ababf.diff

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: for example, rocprim assumes warpSize is constant https://github.com/ROCm/rocPRIM/blob/6325547d514b46d1ab51aff0195851b3fcc626d1/rocprim/include/rocprim/intrinsics/thread.hpp#L54 since device_warp_size() is used as non-type template arguments and these code are not conditioned

[clang] [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (PR #83065)

2024-03-01 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/83065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b873847 - [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (#83065)

2024-03-01 Thread via cfe-commits
Author: Nikolas Klauser Date: 2024-03-01T15:15:11+01:00 New Revision: b873847a53ae638e2146e3657fe33efe30c2afe1 URL: https://github.com/llvm/llvm-project/commit/b873847a53ae638e2146e3657fe33efe30c2afe1 DIFF:

[clang] [Clang] Fix __has_cpp_attribute and C++11 attributes with arguments in C++03 (PR #83065)

2024-03-01 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: The CI failure is unrelated. https://github.com/llvm/llvm-project/pull/83065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Fix test after updating library search paths (PR #83573)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: We still use this bitcode library in one case, the NVPTX non-LTO build. The patch updated the search paths to treat it the same as other libraries, which unintentionally prioritized system paths over

[clang] [OpenMP] Fix test after updating library search paths (PR #83573)

2024-03-01 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/83573 Summary: We still use this bitcode library in one case, the NVPTX non-LTO build. The patch updated the search paths to treat it the same as other libraries, which unintentionally prioritized system paths over

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-01 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy ,NagyDonat Message-ID: In-Reply-To: @@ -27,20 +27,48 @@ class IdentifierInfo; namespace clang { namespace ento { - -enum CallDescriptionFlags : unsigned { - CDF_None = 0, - - /// Describes a C standard function that is sometimes implemented as a

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-03-01 Thread via cfe-commits
@@ -1369,13 +1369,50 @@ class TargetInfo : public TransferrableTargetInfo, } struct BranchProtectionInfo { -LangOptions::SignReturnAddressScopeKind SignReturnAddr = -LangOptions::SignReturnAddressScopeKind::None; -LangOptions::SignReturnAddressKeyKind

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-01 Thread Balázs Kéri via cfe-commits
@@ -27,20 +27,48 @@ class IdentifierInfo; namespace clang { namespace ento { - -enum CallDescriptionFlags : unsigned { - CDF_None = 0, - - /// Describes a C standard function that is sometimes implemented as a macro - /// that expands to a compiler builtin with some

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Yaxun Liu via cfe-commits
@@ -4306,10 +4306,10 @@ // Begin amdgcn tests -// RUN: %clang -mcpu=gfx803 -E -dM %s -o - 2>&1 \ +// RUN: %clang -mcpu=gfx803 -E -dM -Xclang -fcuda-is-device %s -o - 2>&1 \ yxsamliu wrote: C code compiled with target amdgcn should not

[clang] [openmp] [OpenMP] Respect LLVM per-target install directories (PR #83282)

2024-03-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Problem 1 can be solved by flipping the order. But Problem 2 would remain as > it doesn't depend on the order. Honestly, we should just remove the second test. We just treat these things as libraries and it doesn't make sense for a test to ensure that `-lstdc++` doesn't

[clang] [analyzer] Refactor CallDescription match mode (NFC) (PR #83432)

2024-03-01 Thread Balázs Kéri via cfe-commits
@@ -27,20 +27,48 @@ class IdentifierInfo; namespace clang { namespace ento { - -enum CallDescriptionFlags : unsigned { - CDF_None = 0, - - /// Describes a C standard function that is sometimes implemented as a macro - /// that expands to a compiler builtin with some

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Yaxun Liu via cfe-commits
@@ -6,32 +6,32 @@ // R600-based processors. // -// RUN: %clang -E -dM -target r600 -mcpu=r600 %s 2>&1 | FileCheck --check-prefixes=ARCH-R600,R600 %s -DCPU=r600 -// RUN: %clang -E -dM -target r600 -mcpu=rv630 %s 2>&1 | FileCheck --check-prefixes=ARCH-R600,R600 %s -DCPU=r600

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: Did you try this patch with internal PSDB? This will likely break all HIP programs. This is because HIP is single source program and users usually expect the common device-side predefined macros is seen in both host and device compilations. e.g. they could write a kernel

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Vlad Serebrennikov via cfe-commits
Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -14478,7 +14478,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2445.html;>2445 C++20

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Vlad Serebrennikov via cfe-commits
Botond =?utf-8?q?Istv=C3=A1n_Horv=C3=A1th?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/Endilll requested changes to this pull request. https://github.com/llvm/llvm-project/pull/83279

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Vlad Serebrennikov via cfe-commits
Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Pierre van Houtryve via cfe-commits
Pierre-vh wrote: > This was the original behavior of my patch, but I reverted it because it > broke all the HIP headers that were unintentionally relying on this. Has that > been resolved? Was an issue opened for that? How many headers are affected?

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: This was the original behavior of my patch, but I reverted it because it broke all the HIP headers that were unintentionally relying on this. Has that been resolved? https://github.com/llvm/llvm-project/pull/83558 ___ cfe-commits

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/83570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-backend-directx Author: Farzon Lotfi (farzonl) Changes hlsl_intrinsics.h - add the round api DXIL.td add the llvm intrinsic to DXIL lowering mapping This chane reuses llvms existing `__builtin_elementwise_round`\`int_round`

[clang] [llvm] [HLSL][DXIL] Implementation of round intrinsic (PR #83570)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/83570 hlsl_intrinsics.h - add the round api DXIL.td add the llvm intrinsic to DXIL lowering mapping This chane reuses llvms existing `__builtin_elementwise_round`\`int_round` This change implements: #70077 >From

[clang] [openmp] [OpenMP] Respect LLVM per-target install directories (PR #83282)

2024-03-01 Thread Björn Pettersson via cfe-commits
bjope wrote: Problem 1 can be solved by flipping the order. But Problem 2 would remain as it doesn't depend on the order. https://github.com/llvm/llvm-project/pull/83282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [lld] [llvm] [RISCV] Support .note.gnu.property for enable Zicfiss and Zicfilp extension (PR #77414)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: None (SuHo-llrr) Changes Emit Zicfiss/Zicfilp to .note.gnu.property sections 1. for spec v0.4.0 Zicifss/Zicfilp is AND feature means that all objects need to have this feature. 2. Emit note section when Zicifss/Zicfilp extension

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Botond István Horváth via cfe-commits
https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 1/5] Bugfix for choosing the more specialized overload

[clang] [lld] [llvm] [RISCV] Support .note.gnu.property for enable Zicfiss and Zicfilp extension (PR #77414)

2024-03-01 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng edited https://github.com/llvm/llvm-project/pull/77414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] [OpenMP] Respect LLVM per-target install directories (PR #83282)

2024-03-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Hi @jhuber6, @MaskRay > > We are having some problems with this patch on a server where the file > /lib64/libomptarget-nvptx-sm_52.bc exists. The test case that fails is > clang/test/Driver/openmp-offload-gpu.c. > > **Problem 1** I think one problem is related to this check

[clang] [analyzer] Improve some comments in ArrayBoundCheckerV2 (NFC) (PR #83545)

2024-03-01 Thread via cfe-commits
=?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: @@ -301,21 +301,27 @@ compareValueToThreshold(ProgramStateRef State, NonLoc Value, NonLoc Threshold, // calling `evalBinOpNN`: if (isNegative(SVB, State, Value) && isUnsigned(SVB, Threshold)) { if (CheckEquality) { -

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-03-01 Thread Douglas Deslauriers via cfe-commits
https://github.com/vapdrs updated https://github.com/llvm/llvm-project/pull/83476 >From f66254c6be64a7270ce2df8556c540344ade0619 Mon Sep 17 00:00:00 2001 From: Douglas Deslauriers Date: Thu, 29 Feb 2024 20:18:34 + Subject: [PATCH] [clang] Sequence C++20 Parenthesized List Init

[clang] [llvm] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2024-03-01 Thread Vikram Hegde via cfe-commits
@@ -202,12 +207,20 @@ RValue CodeGenFunction::EmitAMDGPUDevicePrintfCallExpr(const CallExpr *E) { Args.push_back(Arg); } - llvm::IRBuilder<> IRB(Builder.GetInsertBlock(), Builder.GetInsertPoint()); - IRB.SetCurrentDebugLocation(Builder.getCurrentDebugLocation()); +

[clang] Fix implementation of [temp.param]p14's first sentence. (PR #83487)

2024-03-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The changes look correct to me, but I think we should add a DR test for this so that we can properly regenerate cxx_dr_status.html Also, the changes should come with a release note. https://github.com/llvm/llvm-project/pull/83487

[clang] [llvm] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2024-03-01 Thread Vikram Hegde via cfe-commits
@@ -2550,6 +2550,11 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, ().getLongDoubleFormat() == ::APFloat::IEEEquad()) BuiltinID = mutateLongDoubleBuiltin(BuiltinID); + // Mutate the printf builtin ID so that we use the same

[clang] [llvm] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2024-03-01 Thread Vikram Hegde via cfe-commits
@@ -3616,6 +3617,12 @@ unsigned FunctionDecl::getBuiltinID(bool ConsiderWrapperFunctions) const { if (!ConsiderWrapperFunctions && getStorageClass() == SC_Static) return 0; + // AMDGCN implementation supports printf as a builtin + // for OpenCL + if

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-03-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM with a minor commenting nit. Thank you for catching this and the quick patch! https://github.com/llvm/llvm-project/pull/83497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-03-01 Thread Aaron Ballman via cfe-commits
@@ -92,6 +92,19 @@ void foo() { bool is_true = [](){ return true; }; // expected-warning@-1{{address of lambda function pointer conversion operator will always evaluate to 'true'}} } + +template +static bool IsFalse(const Ts&...) { return false; } +template +static bool

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-03-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/83497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Sequence C++20 Parenthesized List Init (PR #83476)

2024-03-01 Thread Douglas Deslauriers via cfe-commits
https://github.com/vapdrs edited https://github.com/llvm/llvm-project/pull/83476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh updated https://github.com/llvm/llvm-project/pull/83558 >From 3730631ac58425f559f4bc3cfe3da89e6367c1c5 Mon Sep 17 00:00:00 2001 From: pvanhout Date: Fri, 1 Mar 2024 12:43:55 +0100 Subject: [PATCH 1/2] [clang][AMDGPU] Don't define feature macros on host code Those

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-03-01 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: ping https://github.com/llvm/llvm-project/pull/80540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-03-01 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/80540 >From d2c973c8ebd7605b47a8c5fc928d2d85426c8a6d Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Tue, 30 Jan 2024 11:17:55 + Subject: [PATCH] [TargetParser][AArch64] Add alias for FEAT_RDM. This

[clang] [clang][RISCV] Reorder sema check for RVV type (PR #83553)

2024-03-01 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng commented: Could you add a testcase? https://github.com/llvm/llvm-project/pull/83553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Improve some comments in ArrayBoundCheckerV2 (NFC) (PR #83545)

2024-03-01 Thread Gábor Spaits via cfe-commits
@@ -301,21 +301,27 @@ compareValueToThreshold(ProgramStateRef State, NonLoc Value, NonLoc Threshold, // calling `evalBinOpNN`: if (isNegative(SVB, State, Value) && isUnsigned(SVB, Threshold)) { if (CheckEquality) { - // negative_value == unsigned_value is always

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-03-01 Thread via cfe-commits
rayroudc wrote: @owenca, thanks for the review! As I do not have write access, would it be possible for you to merge this change ? https://github.com/llvm/llvm-project/pull/83380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Matt Arsenault via cfe-commits
@@ -292,8 +292,14 @@ void AMDGPUTargetInfo::getTargetDefines(const LangOptions , } Builder.defineMacro(Twine("__") + Twine(CanonName) + Twine("__")); + + // Don't emit feature macros in host code because in such cases the + // feature list is not accurate. + if

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pierre van Houtryve (Pierre-vh) Changes Those macros are unreliable because our features are mostly uninitialized at that stage, so any macro we define is unreliable. Fixes SWDEV-447308 --- Full diff:

[clang] [clang][AMDGPU] Don't define feature macros on host code (PR #83558)

2024-03-01 Thread Pierre van Houtryve via cfe-commits
https://github.com/Pierre-vh created https://github.com/llvm/llvm-project/pull/83558 Those macros are unreliable because our features are mostly uninitialized at that stage, so any macro we define is unreliable. Fixes SWDEV-447308 >From 3730631ac58425f559f4bc3cfe3da89e6367c1c5 Mon Sep 17

<    1   2   3   4   >