llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Joseph Huber (jhuber6)
Changes
Summary:
The new driver does not need this hash and it can lead to redefined
symbol errors when the CUID hash isn't set.
---
Full diff: https://github.com/llvm/llvm-project/pull/84332.diff
1 Files
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/84332
Summary:
The new driver does not need this hash and it can lead to redefined
symbol errors when the CUID hash isn't set.
>From 012ead550448376f4fefd9fb70418e32f02dba6b Mon Sep 17 00:00:00 2001
From: Joseph
satmandu wrote:
Will there be a backport for 18.1.x? (The current patch doesn't apply cleanly
to 18.1.0.)
https://github.com/llvm/llvm-project/pull/84230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -641,3 +652,53 @@ bool Sema::CheckRebuiltStmtAttributes(ArrayRef Attrs) {
CheckForDuplicateLoopAttrs(*this, Attrs);
return false;
}
+
+ExprResult Sema::ActOnCXXAssumeAttr(Stmt *St, const ParsedAttr ,
+SourceRange Range) {
+ if
https://github.com/erichkeane requested changes to this pull request.
I think this is a case of 'cure is worse than the disease'. Unless this
implements our 'identifier' rules, it is just going to reject valid code.
Any sort of enforcement here on individual characters NEEDS to follow the
@@ -999,25 +1002,42 @@ bool
WebAssemblyLowerEmscriptenEHSjLj::runOnModule(Module ) {
// Register __wasm_longjmp function, which calls __builtin_wasm_longjmp.
FunctionType *FTy = FunctionType::get(
IRB.getVoidTy(), {Int8PtrTy, IRB.getInt32Ty()}, false);
-
https://github.com/sbc100 edited https://github.com/llvm/llvm-project/pull/84137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sbc100 commented:
Thanks for working on this!
I'm excited to see this land and become less emscripten-specific.
I'm hoping that once we get the emscripten side landed we can remove the new
option very soon too.
https://github.com/llvm/llvm-project/pull/84137
ekliptik wrote:
Hi, this broke our downstream. What is the motivation for this, and how is this
intended to be used with compiler-rt locations being set by multilib.yaml? We
have something similar to what ARM does for multilibs.yaml but with different
paths, and this prevents the driver from
@@ -1162,6 +1162,11 @@ class Sema final {
/// CurContext - This is the current declaration context of parsing.
DeclContext *CurContext;
+ SemaOpenACC () {
+assert(OpenACCPtr);
erichkeane wrote:
I don't buy the 'noticeable impact on assertion build'
@@ -1162,6 +1162,11 @@ class Sema final {
/// CurContext - This is the current declaration context of parsing.
DeclContext *CurContext;
+ SemaOpenACC () {
+assert(OpenACCPtr);
cor3ntin wrote:
Sure. But that's not yet the case. I think we should add
cor3ntin wrote:
> Thank you for all the reviews, I will wait 1 or 2 days before merging it in
> case anyone has more comments.
Sure!
Do you plan to keep working on completing this feature?
https://github.com/llvm/llvm-project/pull/77890
___
@@ -1162,6 +1162,11 @@ class Sema final {
/// CurContext - This is the current declaration context of parsing.
DeclContext *CurContext;
+ SemaOpenACC () {
+assert(OpenACCPtr);
erichkeane wrote:
IMO, there is value to having the assert. I can
@@ -19185,7 +19185,8 @@ static bool isLayoutCompatible(ASTContext , EnumDecl
*ED1, EnumDecl *ED2) {
/// Check if two fields are layout-compatible.
static bool isLayoutCompatible(ASTContext , FieldDecl *Field1,
- FieldDecl *Field2) {
+
tbaederr wrote:
Ping @cor3ntin @cjdb
https://github.com/llvm/llvm-project/pull/74852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NagyDonat wrote:
> The change looks correct, but it would be more accurate if 3 different index
> error cases would be possible, index is too small (negative), too large, or
> can be both too small and too large.
>From the point of view of the user this is already true, we have three
cor3ntin wrote:
> I have removed this entirely, although it may still not be optimal, it did
> reduce few more test failures:
>
> ```c++
> Constructor->hasOneParamOrDefaultArgs() &&
> Constructor->getTemplateSpecializationKind() !=
> TSK_ImplicitInstantiation
> ```
>
> Any
cor3ntin wrote:
https://github.com/llvm/llvm-project/pull/81658 replaces this PR
https://github.com/llvm/llvm-project/pull/80244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/80244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/78356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2215,6 +2215,15 @@ let TargetGuard = "sve2p1" in {
def SVTBXQ : SInst<"svtbxq[_{d}]", "dddu", "cUcsUsiUilUlbhfd", MergeNone,
"aarch64_sve_tbxq">;
// EXTQ
def EXTQ : SInst<"svextq[_{d}]", "dddk", "cUcsUsiUilUlbhfd", MergeNone,
"aarch64_sve_extq", [], [ImmCheck<2,
@@ -10007,6 +10007,16 @@ multiclass sve2p1_dupq {
bits<1> index;
let Inst{20} = index;
}
+
+ def : SVE_2_Op_Imm_Pat(NAME # _B)>;
Lukacma wrote:
DOne
https://github.com/llvm/llvm-project/pull/83260
___
https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/84195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Yaxun (Sam) Liu
Date: 2024-03-07T09:26:16-05:00
New Revision: 61b13e0dfe1b476d9bf0fe477983be8471cfd26b
URL:
https://github.com/llvm/llvm-project/commit/61b13e0dfe1b476d9bf0fe477983be8471cfd26b
DIFF:
https://github.com/Lukacma edited
https://github.com/llvm/llvm-project/pull/83260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@MitalAshok ping
https://github.com/llvm/llvm-project/pull/78060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Lukacma updated
https://github.com/llvm/llvm-project/pull/83260
>From c5bceafca67d15bad05afa17ac8875421e4259a3 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Wed, 21 Feb 2024 11:11:45 +
Subject: [PATCH 1/2] [AArch64] [SVE] Created intrinsics for DUPQ instr.
This
cor3ntin wrote:
@bwendling feel free to fix the conflicts and merge
https://github.com/llvm/llvm-project/pull/79365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@xbjfk Once you fix the conflicts, would you like us to merge that for you?
Thanks!
https://github.com/llvm/llvm-project/pull/68690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
balazske wrote:
The change looks correct, but it would be more accurate if 3 different index
error cases would be possible, index is too small (negative), too large, or can
be both too small and too large.
https://github.com/llvm/llvm-project/pull/84201
@@ -603,6 +611,8 @@ void ArrayBoundCheckerV2::performCheck(const Expr *E,
CheckerContext ) const {
auto [WithinUpperBound, ExceedsUpperBound] =
compareValueToThreshold(State, ByteOffset, *KnownSize, SVB);
+bool AssumedNonNegative = SUR.assumedNonNegative();
@@ -19185,7 +19185,8 @@ static bool isLayoutCompatible(ASTContext , EnumDecl
*ED1, EnumDecl *ED2) {
/// Check if two fields are layout-compatible.
static bool isLayoutCompatible(ASTContext , FieldDecl *Field1,
- FieldDecl *Field2) {
+
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/84322
>From 8ffd2e22efc5ae6cc939802f6a2913f334dfcc54 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Thu, 7 Mar 2024 07:48:38 -0600
Subject: [PATCH] [LinkerWrapper] Use the correct empty file on Windows
Summary:
@@ -410,7 +410,10 @@ fatbinary(ArrayRef>
InputFiles,
Targets.push_back(Saver.save("hipv4-amdgcn-amd-amdhsa--" + Arch));
CmdArgs.push_back(Saver.save(llvm::join(Targets, ",")));
- CmdArgs.push_back("-input=/dev/null");
+ if (Triple.isOSWindows())
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 597be90f8b72fde59505f3650c20cf9e57b47d57
4a1e095d962e5b76d529fe579f2b449a36117c65 --
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/84322
>From 4a1e095d962e5b76d529fe579f2b449a36117c65 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Thu, 7 Mar 2024 07:48:38 -0600
Subject: [PATCH] [LinkerWrapper] Use the correct empty file on Windows
Summary:
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/84164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -410,7 +410,10 @@ fatbinary(ArrayRef>
InputFiles,
Targets.push_back(Saver.save("hipv4-amdgcn-amd-amdhsa--" + Arch));
CmdArgs.push_back(Saver.save(llvm::join(Targets, ",")));
- CmdArgs.push_back("-input=/dev/null");
+ if (Triple.isOSWindows())
https://github.com/Meinersbur edited
https://github.com/llvm/llvm-project/pull/84322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Meinersbur requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/84322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -799,6 +806,16 @@ PointerValue
::getOrCreateNullPointerValue(QualType PointeeType) {
return DACtx->getOrCreateNullPointerValue(PointeeType);
}
+void Environment::initializeFieldsWithValues(RecordStorageLocation ) {
ymand wrote:
I don't know of any
@@ -414,8 +414,15 @@ void Environment::initialize() {
}
} else if (MethodDecl->isImplicitObjectMemberFunction()) {
QualType ThisPointeeType = MethodDecl->getFunctionObjectParameterType();
- setThisPointeeStorageLocation(
-
hokein wrote:
Thank you for all the reviews, I will wait 1 or 2 days before merging it in
case anyone has more comments.
https://github.com/llvm/llvm-project/pull/77890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -10598,10 +10598,34 @@ QualType
Sema::DeduceTemplateSpecializationFromInitializer(
if (TemplateName.isDependent())
return SubstAutoTypeDependent(TSInfo->getType());
- // We can only perform deduction for class templates.
+ // We can only perform deduction for
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Joseph Huber (jhuber6)
Changes
Summary:
The clang-offload-bundler uses an empty file to control the bundles made
for embedding. Previously this still used `/dev/null` by mistake even on
Windows.
---
Full diff:
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/84322
Summary:
The clang-offload-bundler uses an empty file to control the bundles made
for embedding. Previously this still used `/dev/null` by mistake even on
Windows.
>From eb6dd7ac6cfd52ce18b17a683e55835a261f7138
Sirraide wrote:
This needs a release note, but LGTM otherwise.
https://github.com/llvm/llvm-project/pull/84318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide approved this pull request.
https://github.com/llvm/llvm-project/pull/84318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
abidh wrote:
Thanks @kiranchandramohan and @tblah for your comments. I do plan to work on
this long term to bring the full debug support to flang. I will work on
creating a design document.
https://github.com/llvm/llvm-project/pull/84202
___
Author: Joseph Huber
Date: 2024-03-07T07:40:38-06:00
New Revision: 597be90f8b72fde59505f3650c20cf9e57b47d57
URL:
https://github.com/llvm/llvm-project/commit/597be90f8b72fde59505f3650c20cf9e57b47d57
DIFF:
https://github.com/llvm/llvm-project/commit/597be90f8b72fde59505f3650c20cf9e57b47d57.diff
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/84253
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2024-03-07T14:40:30+01:00
New Revision: 48dd118f56e007a173b30019e860f0bd373a8ff8
URL:
https://github.com/llvm/llvm-project/commit/48dd118f56e007a173b30019e860f0bd373a8ff8
DIFF:
https://github.com/llvm/llvm-project/commit/48dd118f56e007a173b30019e860f0bd373a8ff8.diff
jhuber6 wrote:
> > [NFC]
>
> From a strict interpretation, this is not NFC as this changes clang driver
> behavior. The overall behavior combining clang + clang-linker-wrapper may not
> change, though...
I suppose I just wanted to make it clear that this option didn't do anything,
but it
github-actions[bot] wrote:
@aniplcc Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/84228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: aniplcc
Date: 2024-03-07T14:39:04+01:00
New Revision: 2acccf6717996bea8ade96dafdfc3343e9604694
URL:
https://github.com/llvm/llvm-project/commit/2acccf6717996bea8ade96dafdfc3343e9604694
DIFF:
https://github.com/llvm/llvm-project/commit/2acccf6717996bea8ade96dafdfc3343e9604694.diff
LOG:
cor3ntin wrote:
> [This page](https://clang.llvm.org/cxx_status.html) still refers to
> [P2266R1](https://wg21.link/p2266r1) but the approved revision is
> [P2266R3](https://wg21.link/p2266r3). Should we fix the citation in this PR
> or another?
I'll do that as NFC, thanks for noticing
@@ -1996,6 +1996,30 @@ Here is an example:
}];
}
+def AssumeDocs : Documentation {
+ let Category = DocCatStmt;
+ let Heading = "assume";
+ let Content = [{
+The ``assume`` attribute is used to indicate to the optimizer that a
+certain condition can be assumed to be true
@@ -1996,6 +1996,30 @@ Here is an example:
}];
}
+def AssumeDocs : Documentation {
+ let Category = DocCatStmt;
+ let Heading = "assume";
+ let Content = [{
+The ``assume`` attribute is used to indicate to the optimizer that a
+certain condition can be assumed to be true
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/84150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Stefan Gränitz
Date: 2024-03-07T14:27:04+01:00
New Revision: 4b70d17bcffaffd75a5d8c420396f8dc755b4652
URL:
https://github.com/llvm/llvm-project/commit/4b70d17bcffaffd75a5d8c420396f8dc755b4652
DIFF:
https://github.com/cor3ntin commented:
Generally looks good to me.
You should modify cxx_status
https://github.com/llvm/llvm-project/pull/81014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -641,3 +652,53 @@ bool Sema::CheckRebuiltStmtAttributes(ArrayRef Attrs) {
CheckForDuplicateLoopAttrs(*this, Attrs);
return false;
}
+
+ExprResult Sema::ActOnCXXAssumeAttr(Stmt *St, const ParsedAttr ,
+SourceRange Range) {
+ if
https://github.com/cor3ntin approved this pull request.
LGTM
Thanks for working on that!
https://github.com/llvm/llvm-project/pull/77890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -10598,10 +10598,34 @@ QualType
Sema::DeduceTemplateSpecializationFromInitializer(
if (TemplateName.isDependent())
return SubstAutoTypeDependent(TSInfo->getType());
- // We can only perform deduction for class templates.
+ // We can only perform deduction for
@@ -414,8 +414,15 @@ void Environment::initialize() {
}
} else if (MethodDecl->isImplicitObjectMemberFunction()) {
QualType ThisPointeeType = MethodDecl->getFunctionObjectParameterType();
- setThisPointeeStorageLocation(
-
@@ -799,6 +806,16 @@ PointerValue
::getOrCreateNullPointerValue(QualType PointeeType) {
return DACtx->getOrCreateNullPointerValue(PointeeType);
}
+void Environment::initializeFieldsWithValues(RecordStorageLocation ) {
martinboehme wrote:
I consciously put
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/83027
From 5c919832f9176d4b1af1312a4ee7cf30b788958a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Wed, 21 Feb 2024 14:46:01 +0100
Subject: [PATCH 1/7]
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/83027
From 5c919832f9176d4b1af1312a4ee7cf30b788958a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Wed, 21 Feb 2024 14:46:01 +0100
Subject: [PATCH 1/6]
@@ -1183,6 +1315,20 @@ void StreamChecker::evalGetdelim(const FnDescription
*Desc,
State->BindExpr(E.CE, C.getLocationContext(), RetVal);
StateNotFailed =
E.assumeBinOpNN(StateNotFailed, BO_GE, RetVal, E.getZeroVal(Call));
+// The buffer size `*n` must
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: OverMighty (overmighty)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/84318.diff
4 Files Affected:
- (modified) clang/docs/LanguageExtensions.rst (+1)
- (modified) clang/include/clang/Basic/Builtins.td (+1-1)
-
overmighty wrote:
cc @RKSimon
https://github.com/llvm/llvm-project/pull/84318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (martinboehme)
Changes
I'm making some changes to `Environment::getResultObjectLocation()`, with the
ultimate goal of eliminating `RecordValue` entirely, and I'd like to make sure
I don't break this behavior (and I've realized we
https://github.com/overmighty created
https://github.com/llvm/llvm-project/pull/84318
None
>From 929165caaec24463763a2074f920253c8cb2ae44 Mon Sep 17 00:00:00 2001
From: OverMighty
Date: Thu, 7 Mar 2024 12:58:14 +
Subject: [PATCH] [clang] Implement constexpr support for __builtin_popcountg
https://github.com/martinboehme created
https://github.com/llvm/llvm-project/pull/84317
I'm making some changes to `Environment::getResultObjectLocation()`, with the
ultimate goal of eliminating `RecordValue` entirely, and I'd like to make sure
I don't break this behavior (and I've realized we
@@ -1162,6 +1162,11 @@ class Sema final {
/// CurContext - This is the current declaration context of parsing.
DeclContext *CurContext;
+ SemaOpenACC () {
+assert(OpenACCPtr);
cor3ntin wrote:
In the current design, the assert does nothing useful.
AaronBallman wrote:
Thank you for this factoring! Personally, I think this is a good model to go
with for factoring functionality out of Sema and adding a tiny bit of layering
to this part of the compiler (full disclosure: Vlad and I worked on this design
offline). However, I added several
https://github.com/cor3ntin commented:
I have mixed feelings about that.
One one hand, i appreciate efforts to decouple Sema, on the other hand It's
unclear to me how much benefit we will be able to realize.
I think I'm fine with the change as long as there is no attempt to remove
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/84184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -63,17 +67,17 @@ void Sema::ActOnOpenACCConstruct(OpenACCDirectiveKind K,
// here as these constructs do not take any arguments.
break;
default:
-Diag(StartLoc, diag::warn_acc_construct_unimplemented) << K;
+SemaRef.Diag(StartLoc,
@@ -1196,6 +1342,11 @@ void StreamChecker::evalGetdelim(const FnDescription
*Desc,
E.isStreamEof() ? ErrorFEof : ErrorFEof | ErrorFError;
StateFailed = E.setStreamState(
StateFailed, StreamState::getOpened(Desc, NewES, !NewES.isFEof()));
+ // On failure, the
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/83027
From 5c919832f9176d4b1af1312a4ee7cf30b788958a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Wed, 21 Feb 2024 14:46:01 +0100
Subject: [PATCH 1/4]
https://github.com/alejandro-alvarez-sonarsource updated
https://github.com/llvm/llvm-project/pull/83027
From 5c919832f9176d4b1af1312a4ee7cf30b788958a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?=
Date: Wed, 21 Feb 2024 14:46:01 +0100
Subject: [PATCH 1/3]
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/jcsxky edited https://github.com/llvm/llvm-project/pull/83847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
I haven't gone deep into this PR, but it looks good to me.
Please wait for someone else to sign it too.
https://github.com/llvm/llvm-project/pull/84191
___
cfe-commits mailing list
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -1158,6 +1173,123 @@ void StreamChecker::evalUngetc(const FnDescription
*Desc, const CallEvent ,
C.addTransition(StateFailed);
}
+ProgramStateRef
+StreamChecker::ensurePtrNotNull(SVal PtrVal, const Expr
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -1158,6 +1173,123 @@ void StreamChecker::evalUngetc(const FnDescription
*Desc, const CallEvent ,
C.addTransition(StateFailed);
}
+ProgramStateRef
+StreamChecker::ensurePtrNotNull(SVal PtrVal, const Expr
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -1196,6 +1342,11 @@ void StreamChecker::evalGetdelim(const FnDescription
*Desc,
E.isStreamEof() ? ErrorFEof : ErrorFEof | ErrorFError;
StateFailed = E.setStreamState(
StateFailed,
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
@@ -1183,6 +1315,20 @@ void StreamChecker::evalGetdelim(const FnDescription
*Desc,
State->BindExpr(E.CE, C.getLocationContext(), RetVal);
StateNotFailed =
E.assumeBinOpNN(StateNotFailed, BO_GE,
Alejandro =?utf-8?q?=C3=81lvarez_Ayll=C3=B3n?=
Message-ID:
In-Reply-To:
https://github.com/steakhal requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/83027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -19185,7 +19185,8 @@ static bool isLayoutCompatible(ASTContext , EnumDecl
*ED1, EnumDecl *ED2) {
/// Check if two fields are layout-compatible.
static bool isLayoutCompatible(ASTContext , FieldDecl *Field1,
- FieldDecl *Field2) {
+
https://github.com/cor3ntin commented:
I only have a comment otherwise LGTM
https://github.com/llvm/llvm-project/pull/84313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/84313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -603,6 +611,8 @@ void ArrayBoundCheckerV2::performCheck(const Expr *E,
CheckerContext ) const {
auto [WithinUpperBound, ExceedsUpperBound] =
compareValueToThreshold(State, ByteOffset, *KnownSize, SVB);
+bool AssumedNonNegative = SUR.assumedNonNegative();
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/83847
>From 2bb165ac6264b36f72716cb35ed2e1b4f72f3eaa Mon Sep 17 00:00:00 2001
From: huqizhi
Date: Mon, 4 Mar 2024 21:51:07 +0800
Subject: [PATCH] [Clang][Sema] Allow access to a public template alias
declaration that
Author: martinboehme
Date: 2024-03-07T13:31:23+01:00
New Revision: d5aecf0c19fc8850d7d34ac8c339bcc7e133b5fb
URL:
https://github.com/llvm/llvm-project/commit/d5aecf0c19fc8850d7d34ac8c339bcc7e133b5fb
DIFF:
https://github.com/llvm/llvm-project/commit/d5aecf0c19fc8850d7d34ac8c339bcc7e133b5fb.diff
https://github.com/martinboehme closed
https://github.com/llvm/llvm-project/pull/82611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/84313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
301 - 400 of 492 matches
Mail list logo
