@@ -42,10 +44,30 @@ void AvoidReturnWithVoidValueCheck::check(
const auto *VoidReturn = Result.Nodes.getNodeAs("void_return");
if (IgnoreMacros && VoidReturn->getBeginLoc().isMacroID())
return;
- if (!StrictMode && !Result.Nodes.getNodeAs("compound_parent"))
+ const a
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Danny Mösch (SimplyDanny)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90173.diff
1 Files Affected:
- (modified)
clang-tools-extra/clang-tidy/readability/AvoidReturnWithVoidValueCheck.cpp
(+5-2)
```
https://github.com/SimplyDanny created
https://github.com/llvm/llvm-project/pull/90173
None
From f8e0509e0586ae7cb1a236e27b8be27a94bf7cf5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danny=20M=C3=B6sch?=
Date: Fri, 26 Apr 2024 08:38:40 +0200
Subject: [PATCH] [clang-tidy] Ensure nullable variable i
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/89807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/89807
>From 3f6e50edc7b4d4bf4781c71bd29f48224b62822d Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Tue, 9 Apr 2024 01:14:28 -0300
Subject: [PATCH] [clang] Enable C++17 relaxed template template argument
matchi
https://github.com/Endilll commented:
`Sema.h` changes look good.
https://github.com/llvm/llvm-project/pull/89809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll approved this pull request.
Thank you for spotting and fixing this!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Endilll wrote:
@shafik I wonder how checking size of a vector is now considered an expensive
check.
(I stumbled upon it while reviewing)
https://github.com/llvm/llvm-project/blob/47682e4b4a0c8e7637d65868a7208aa6806a50f4/clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp#L99-L101
https://gith
cor3ntin wrote:
> > @codemzs Any news? Thanks a lot for your work!
>
> @cor3ntin Sorry for the delay, I plan to get back to this PR in the next few
> weeks. Do you need this change for something?
Nothing specific, I was just wondering sifting through PRs and our conformance
page
https://githu
vgvassilev wrote:
The pre-merge windows test failure in `Clang :: Driver/amdgpu-toolchain.c`
seems unrelated to this PR.
https://github.com/llvm/llvm-project/pull/89804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -0,0 +1,55 @@
+// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \
+// RUN: -DWIN -emit-llvm -o - %s | FileCheck %s --check-prefixes=WIN
+
+// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \
+// RUN: -emit-llvm -o - %s | FileCheck %s --check
@@ -3440,7 +3440,7 @@ def Fmod : FPMathTemplate, LibBuiltin<"math.h"> {
def Frexp : FPMathTemplate, LibBuiltin<"math.h"> {
let Spellings = ["frexp"];
- let Attributes = [NoThrow];
+ let Attributes = [NoThrow, Constexpr];
let Prototype = "T(T, int*)";
let AddBuiltinPr
@@ -0,0 +1,57 @@
+// RUN: %clang_cc1 -DWIN -verify -std=c++23 -fsyntax-only %s
+// RUN: %clang_cc1 -verify -std=c++23 -fsyntax-only %s
+
+// expected-no-diagnostics
+
+
+#ifdef WIN
+#define INFINITY ((float)(1e+300 * 1e+300))
+#define NAN (-(float)(INFINITY * 0.0F))
+#else
@@ -14638,6 +14649,8 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
return true;
}
+ case Builtin::BIfmin:
+ case Builtin::BIfminf:
hubert-reinterpretcast wrote:
Don't make these evaluate in `constexpr`. Not only does this extend C (n
@@ -14547,6 +14547,17 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
default:
return false;
+ case Builtin::BI__builtin_frexpf:
+ case Builtin::BI__builtin_frexp: {
hubert-reinterpretcast wrote:
Why no `long double`?
https://github.c
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89154
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90169
>From f7640709bf3cebbd3f1b04f6eba4b8f60bb18c13 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 25 Apr 2024 23:03:00 -0700
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Treat true/false as
trivial
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Ryosuke Niwa (rniwa)
Changes
Treat boolean literal "true" and "false" as trivial.
---
Full diff: https://github.com/llvm/llvm-project/pull/90169.diff
2 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/Web
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90169
Treat boolean literal "true" and "false" as trivial.
>From c44d58eb513325c52199788aafa9d4112e3bfbb6 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Thu, 25 Apr 2024 23:03:00 -0700
Subject: [PATCH] [alpha.webkit.U
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/89942
>From 8c5f1d0f92d77bffec88759c19133a0bac130f32 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Wed, 24 Apr 2024 23:36:10 +0800
Subject: [PATCH 1/6] [Clang] Implement P2748R5 "Disallow Binding a Returned
Glvalue t
https://github.com/timmyhoa edited
https://github.com/llvm/llvm-project/pull/90165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/timmyhoa edited
https://github.com/llvm/llvm-project/pull/90165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21ef187654c819fd097171afcc6c9855dccdb36d
0ee6abe93159a29052af3ef9befff6a7e029eb31 --
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/89942
>From 8c5f1d0f92d77bffec88759c19133a0bac130f32 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Wed, 24 Apr 2024 23:36:10 +0800
Subject: [PATCH 1/3] [Clang] Implement P2748R5 "Disallow Binding a Returned
Glvalue t
https://github.com/timmyhoa edited
https://github.com/llvm/llvm-project/pull/90165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/timmyhoa converted_to_draft
https://github.com/llvm/llvm-project/pull/90165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Tim Pham (timmyhoa)
Changes
Closes #88917
Do I really know what is going on? Nope.
Do I know what the bug is? Enough to fix it (hopefully) :)
I'm just a beginner so sorry for any obvious mistake.
---
Full diff: https://githu
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/2] [clang] MangledSymbol: remove pointless copy of vector
---
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/timmyhoa created
https://github.com/llvm/llvm-project/pull/90165
Closes #88917
Do I really know what is going on? Nope.
Do I know what the bug is? Enough to fix it (hopefully) :)
I'm just a beginner so sorry for any obvious mistake.
>From 99a85014b6dd2193afcaff1cb92b92a
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH] [clang] MangledSymbol: remove pointless copy of vector
---
cla
https://github.com/soukatch updated
https://github.com/llvm/llvm-project/pull/90012
>From b8e20a5a3e37ab9a657ac640b848f638387215fa Mon Sep 17 00:00:00 2001
From: Andrew Sukach
Date: Wed, 24 Apr 2024 22:50:50 -0400
Subject: [PATCH 1/2] [clang] MangledSymbol: remove pointless copy of vector
---
https://github.com/kovdan01 closed
https://github.com/llvm/llvm-project/pull/84384
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Daniil Kovalev
Date: 2024-04-26T08:26:15+03:00
New Revision: f4efa067435c8137718c907bf0de2b891b76552d
URL:
https://github.com/llvm/llvm-project/commit/f4efa067435c8137718c907bf0de2b891b76552d
DIFF:
https://github.com/llvm/llvm-project/commit/f4efa067435c8137718c907bf0de2b891b76552d.diff
shafik wrote:
> Looking at the logs, and the error seems to be unrelated to the changes made
> https://buildkite.com/llvm-project/clang-ci/builds/16430#018f132d-506e-440c-b18b-fed98237def9/54-5446
You can try using `--allow-empty` to do an empty commit to kick off the build
again.
https://git
yetingk wrote:
I fix the issue by using feature to control the permission of experimental
extension.
> Does this disable use of experimental extensions for a `.option arch` in an
> inline assembly block without -menable-experimental-extensions.
https://github.com/llvm/llvm-project/pull/8972
https://github.com/sandeepkosuri closed
https://github.com/llvm/llvm-project/pull/90022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: SunilKuravinakop
Date: 2024-04-26T10:31:55+05:30
New Revision: 4b255085833b58392d7699aaf5c20ea49559fda9
URL:
https://github.com/llvm/llvm-project/commit/4b255085833b58392d7699aaf5c20ea49559fda9
DIFF:
https://github.com/llvm/llvm-project/commit/4b255085833b58392d7699aaf5c20ea49559fda9.di
https://github.com/yetingk updated
https://github.com/llvm/llvm-project/pull/89727
>From a43014cf3daa1b0fd9092bfe41da979205ba64aa Mon Sep 17 00:00:00 2001
From: Yeting Kuo
Date: Tue, 23 Apr 2024 02:16:04 -0700
Subject: [PATCH 1/4] [RISCV] Teach .option arch to support experimental
extensions.
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d26002ac38ee1dea32053e7d12f1bb5dc420ac2d
2fa7299db558c2a953f641ffe760369f31a98b3d --
HighCommander4 wrote:
Here is a reduced testcase for the OpenMP test failure:
```c++
#pragma omp declare target
static long double ld_return1e() { return 0; }
void external() {
void *p1 = reinterpret_cast(&ld_return1e);
}
#pragma omp end declare target
```
When built with the following com
@@ -27,3 +26,20 @@ namespace rdar10544564 {
X (Y::*func_mem_ptr1)() = &Y::memfunc1;
X (Y::*func_mem_ptr2)() = &Y::memfunc2;
}
+
+namespace test2 {
+ struct A {
+int val;
+void func() {}
+ };
+
+ void test() {
+decltype(&(A::val)) ptr1; // expected-error {{inv
https://github.com/Khao7342 updated
https://github.com/llvm/llvm-project/pull/89359
>From e51498e67409836b099fa892b17d71e44a7d403b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E9=83=9D=E5=BA=B7=E8=BE=BE?=
Date: Fri, 19 Apr 2024 17:18:10 +0800
Subject: [PATCH] [RISCV] Add processor definition for X
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/77456
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: NorthBlue333
Date: 2024-04-25T20:34:49-07:00
New Revision: 2de0bedfebb77a6c8a5b0d00902f796fa4022fd6
URL:
https://github.com/llvm/llvm-project/commit/2de0bedfebb77a6c8a5b0d00902f796fa4022fd6
DIFF:
https://github.com/llvm/llvm-project/commit/2de0bedfebb77a6c8a5b0d00902f796fa4022fd6.diff
soukatch wrote:
Looking at the logs, and the error seems to be unrelated to the changes made
https://buildkite.com/llvm-project/clang-ci/builds/16430#018f132d-506e-440c-b18b-fed98237def9/54-5446
https://github.com/llvm/llvm-project/pull/90012
___
cfe-c
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #78166.
---
Full diff: https://github.com/llvm/llvm-project/pull/90161.diff
2 Files Affected:
- (modified) clang/lib/Format/TokenAnnotator.cpp (+7-19)
- (modified) clang/unittests/Format/FormatTes
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/90161
Fixes #78166.
>From 3f59076142bd6a87f4875dc79e95e4570f4af7c2 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 25 Apr 2024 20:08:03 -0700
Subject: [PATCH] [clang-format] Add a space after a word token only if
r
HighCommander4 wrote:
> I'm planning to revise the patch to make the following changes:
>
>1. Put the new behaviour behind a config option (I'm thinking `Hover` -->
> `ShowFields`)
>2. Add C language mode tests
>3. Use `PrintingCallbacks` instead of a `PrintingPolicy` flag
These ch
https://github.com/HighCommander4 ready_for_review
https://github.com/llvm/llvm-project/pull/89557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/89557
>From fcb2ac4c68554d9c708b3db779b5570ff94725e8 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Sun, 21 Apr 2024 20:30:16 -0400
Subject: [PATCH] [clangd] Show struct fields and enum members in hovers
Fix
codemzs wrote:
> @codemzs Any news? Thanks a lot for your work!
@cor3ntin Sorry for the delay, I plan to get back to this PR in the next few
weeks. Do you need this change for something?
https://github.com/llvm/llvm-project/pull/78503
___
cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
MSVC linker merges functions having comdat which have identical set of
instructions. CUDA uses kernel stub function as key to look up kernels in
device executables. If kernel stub function for di
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/90155
MSVC linker merges functions having comdat which have identical set of
instructions. CUDA uses kernel stub function as key to look up kernels in
device executables. If kernel stub function for different kernels
https://github.com/haoNoQ approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/90153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tcreech-intel updated
https://github.com/llvm/llvm-project/pull/88438
>From fe3404cbdf78b434f16f8351dc242175b4543112 Mon Sep 17 00:00:00 2001
From: Tim Creech
Date: Thu, 11 Apr 2024 16:03:52 -0400
Subject: [PATCH 1/3] Improve documented sampling profiler steps to best known
https://github.com/owenca unassigned
https://github.com/llvm/llvm-project/pull/78176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/90134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Andreas Jonson
Date: 2024-04-26T11:04:47+09:00
New Revision: 93de97d750548cd90c53efd4367dbd0367aa30fd
URL:
https://github.com/llvm/llvm-project/commit/93de97d750548cd90c53efd4367dbd0367aa30fd
DIFF:
https://github.com/llvm/llvm-project/commit/93de97d750548cd90c53efd4367dbd0367aa30fd.diff
https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8340,8 +8340,17 @@ void Sema::checkInitializerLifetime(const
InitializedEntity &Entity,
<< Entity.getType()->isReferenceType() << CLE->getInitializer() <<
2
<< DiagRange;
} else {
-Diag(DiagLoc, diag::warn_ret_local_temp_addr_ref)
-
nikic wrote:
FYI I'm seeing about 0.6% compile-time regressions for `O0` test-suite builds
with this change
(https://llvm-compile-time-tracker.com/compare.php?from=ef2ca97f48f1aee1483f0c29de5ba52979bec454&to=18376810f359dbd39d2a0aa0ddfc0f7f50eac199&stat=instructions:u).
Though there is also a
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
Skip the analysis of Ref, RefPtr, and their variant classes in
UncountedCallArgsChecker since these classes are "trusted" to not do anything
dangerous.
---
Full di
nikic wrote:
FYI this change has some visible compile-time impact, with some 0.5-1%
regressions on various LLVM files
(https://llvm-compile-time-tracker.com/compare_clang.php?from=2f2e31c3c980407b2660b4f5d10e7cdb3fa79138&to=a8fd0d029dca7d17eee72d0445223c2fe1ee7758&stat=instructions%3Au&sortBy=i
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90153
Skip the analysis of Ref, RefPtr, and their variant classes in
UncountedCallArgsChecker since these classes are "trusted" to not do anything
dangerous.
>From 04d9b292a48604ec0601e869d48d4f2c481f91bc Mon Sep 17 00:
DavidTruby wrote:
As regards the backwards compatibility break here, I guess my take is that this
change needs to happen some time and sooner is always going to be better than
later. While we are still called flang-new and marked experimental I'm inclined
to think we should just rip the band a
DavidTruby wrote:
> Great work David, thanks! Could you add some documentation explaining _where_
> `main` would be coming from in the case of mixed-source compilation? In fact,
> is that tested anywhere?
>
> Also, IMHO it would be good to advertise this on Discourse (thinking
> specifically
nihui wrote:
@ostannard hi, would you please review my fix :)
https://github.com/llvm/llvm-project/pull/89062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3859,7 +3862,7 @@ def warn_availability_fuchsia_unavailable_minor : Warning<
InGroup;
def warn_unguarded_availability :
- Warning<"%0 is only available on %1 %2 or newer">,
+ Warning<"%0 %select{is only|is not}5 available %select{|in %4 environment
}3on %1 %2 %select{
@@ -3859,7 +3862,7 @@ def warn_availability_fuchsia_unavailable_minor : Warning<
InGroup;
def warn_unguarded_availability :
- Warning<"%0 is only available on %1 %2 or newer">,
+ Warning<"%0 %select{is only|is not}5 available %select{|in %4 environment
}3on %1 %2 %select{
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/89809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz commented:
Overall I really like the direction of this. I'm curious if any of the
maintainers from Apple have thoughts since they're the primary users of
availability annotations.
I think this dramatically simplifies things for what we need, but it might also
hav
MaskRay wrote:
(BTW:
https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it/74223
The recommendation is to avoid the github "hidden email" feature.)
https://github.com/llvm/llvm-project/pull/88427
___
cfe-commits mailing
Author: Fangrui Song
Date: 2024-04-25T17:50:59-07:00
New Revision: 5a12f2867a167bbe11099150f3cb6b6cb77d767c
URL:
https://github.com/llvm/llvm-project/commit/5a12f2867a167bbe11099150f3cb6b6cb77d767c
DIFF:
https://github.com/llvm/llvm-project/commit/5a12f2867a167bbe11099150f3cb6b6cb77d767c.diff
@@ -75,6 +76,7 @@
// RUN: --check-prefix=WARN12 %s
// RUN: %clang -### -ffast-math -ffp-model=strict -c %s 2>&1 | FileCheck \
// RUN: --check-prefix=WARN12 %s
+// WARN12: clang
MaskRay wrote:
`clang` is unneeded. For diagnostics or -cc1 options, we just av
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/89477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1462,6 +1460,14 @@ floating point semantic models: precise (the default),
strict, and fast.
"allow_approximate_fns", "off", "off", "on"
"allow_reassociation", "off", "off", "on"
+The ``-fp-model`` option does not modify the "fdenormal-fp-math" or
+"fdenormal-fp-math-f
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-hlsl
Author: Helena Kotas (hekota)
Changes
Add `environment` parameter to Clang availability attribute. The allowed values
for this parameter are a subset of values allowed in the `llvm::Triple`
environment component. If the
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Helena Kotas (hekota)
Changes
Add `environment` parameter to Clang availability attribute. The allowed values
for this parameter are a subset of values allowed in the `llvm::Triple`
environment component. If the `environment` parame
https://github.com/hekota ready_for_review
https://github.com/llvm/llvm-project/pull/89809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/89809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
Will add tests tomorrow...
https://github.com/llvm/llvm-project/pull/90152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Krystian Stasiowski (sdkrystian)
Changes
Reapplies #84050, addressing a bug which cases a crash when an
expression with the type of the current instantiation is used as the
_postfix-expression_ in a class member access expression (ar
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/90152
Reapplies #84050, addressing a bug which cases a crash when an expression with
the type of the current instantiation is used as the _postfix-expression_ in a
class member access expression (arrow form).
>Fro
pranavk wrote:
Sorry, I just pushed the reverts. I reverted the commits for now. Feel free to
re-land with fixes.
https://github.com/llvm/llvm-project/pull/84050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
sdkrystian wrote:
@pranavk @ilovepi I have a potential fix ready... give me a few to test some
edge cases
https://github.com/llvm/llvm-project/pull/84050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
Author: Pranav Kant
Date: 2024-04-26T00:18:08Z
New Revision: 0c6e1ca1c704a3a0fb53ae54f7e3723736f477c7
URL:
https://github.com/llvm/llvm-project/commit/0c6e1ca1c704a3a0fb53ae54f7e3723736f477c7
DIFF:
https://github.com/llvm/llvm-project/commit/0c6e1ca1c704a3a0fb53ae54f7e3723736f477c7.diff
LOG: R
Author: Pranav Kant
Date: 2024-04-26T00:17:28Z
New Revision: 45fc0e6b38b62a61b0ddcda2e7fe9b4fee7e3e58
URL:
https://github.com/llvm/llvm-project/commit/45fc0e6b38b62a61b0ddcda2e7fe9b4fee7e3e58
DIFF:
https://github.com/llvm/llvm-project/commit/45fc0e6b38b62a61b0ddcda2e7fe9b4fee7e3e58.diff
LOG: R
JustinStitt wrote:
@efriedma-quic:
> Attributes mostly do modify the type. The few that don't, like "aligned" and
> "may_alias", are a constant source of problems because they get accidentally
> stripped off. (I don't have any personal experience with "noderef".)
So do you believe the current
pranavk wrote:
Yes, I also think that this should be reverted. This commit seems to
erroneously fail on cases like this:
https://github.com/tink-crypto/tink-cc/blob/4501627fe9ee312ad5d413600f050827b5f725ed/tink/util/secret_proto.h#L62
Note that ParseFromArray is being on an instance of T. So c
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Eli Friedman (efriedma-quic)
Changes
In the context of determining whether a class counts as an "aggregate", a
constructor template counts as a user-provided constructor.
Fixes #86384
---
Full diff: https://github.com/llvm/llvm-p
https://github.com/efriedma-quic created
https://github.com/llvm/llvm-project/pull/90151
In the context of determining whether a class counts as an "aggregate", a
constructor template counts as a user-provided constructor.
Fixes #86384
>From 9adeffc9ee780c84a525ce0535a84508105e05ae Mon Sep 17
https://github.com/hubert-reinterpretcast requested changes to this pull
request.
https://github.com/llvm/llvm-project/pull/88978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,57 @@
+// RUN: %clang_cc1 -DWIN -verify -std=c++23 -fsyntax-only %s
+// RUN: %clang_cc1 -verify -std=c++23 -fsyntax-only %s
+
+// expected-no-diagnostics
+
+
+#ifdef WIN
+#define INFINITY ((float)(1e+300 * 1e+300))
+#define NAN (-(float)(INFINITY * 0.0F))
+#else
@@ -14547,6 +14547,17 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
default:
return false;
+ case Builtin::BI__builtin_frexpf:
+ case Builtin::BI__builtin_frexp: {
+LValue Pointer;
+if (!EvaluateFloat(E->getArg(0), Result, Info) ||
+!E
https://github.com/hubert-reinterpretcast edited
https://github.com/llvm/llvm-project/pull/88978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/89809
>From 22b67d30ca087d6a912183039c87fd1790eedfe4 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Tue, 23 Apr 2024 00:49:28 -0700
Subject: [PATCH 1/3] Add environment parameter to clang availability attribute
---
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/90112
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/89809
>From 22b67d30ca087d6a912183039c87fd1790eedfe4 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Tue, 23 Apr 2024 00:49:28 -0700
Subject: [PATCH 1/3] Add environment parameter to clang availability attribute
---
ilovepi wrote:
we're seeing similar crashes when building Fuchsia.
https://ci.chromium.org/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.arm64-host_test_only-mac/b8749648123122633169/overview
A reproducer can be found here:
https://storage.googleapis.com/fuchsia-artifacts/builds/87496481231
1 - 100 of 392 matches
Mail list logo
