@@ -11,16 +11,116 @@
#include "PtrTypesSemantics.h"
#include "clang/AST/CXXInheritance.h"
#include "clang/AST/RecursiveASTVisitor.h"
+#include "clang/AST/StmtVisitor.h"
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
#include "clang/StaticAnalyzer/Core/B
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/93383
>From ce5f58180635968c1525b9a3d267f91c495f3058 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Sat, 25 May 2024 20:49:22 +0200
Subject: [PATCH 1/2] [Clang] Rewrite SourceLocExpr in default args
In order for
Author: cor3ntin
Date: 2024-05-26T09:18:33+02:00
New Revision: 70d6e7c09fd1a79ca5c2c2deeb72e6b0e1e80a52
URL:
https://github.com/llvm/llvm-project/commit/70d6e7c09fd1a79ca5c2c2deeb72e6b0e1e80a52
DIFF:
https://github.com/llvm/llvm-project/commit/70d6e7c09fd1a79ca5c2c2deeb72e6b0e1e80a52.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/93383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/93402
Closes #92999.
>From fc9097e064e2d64832acc611b2a8d50d332119d6 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 26 May 2024 00:23:35 -0700
Subject: [PATCH] [clang-format] Add LeftWithLastLine to AlignEscapedNewl
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Owen Pan (owenca)
Changes
Closes #92999.
---
Full diff: https://github.com/llvm/llvm-project/pull/93402.diff
7 Files Affected:
- (modified) clang/docs/ClangFormatStyleOptions.rst (+10-2)
- (modified) clang/docs/ReleaseNotes.rst (+2-1)
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Closes #92999.
---
Full diff: https://github.com/llvm/llvm-project/pull/93402.diff
7 Files Affected:
- (modified) clang/docs/ClangFormatStyleOptions.rst (+10-2)
- (modified) clang/docs/ReleaseNotes.rst
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/93403
None
>From 4f5b6ac39e709bddf7f1ced314ebb1984a1942de Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 26 May 2024 00:34:15 -0700
Subject: [PATCH] Fix the warning in RefCntblBaseVirtualDtorChecker.cpp:61
---
@@ -11,16 +11,116 @@
#include "PtrTypesSemantics.h"
#include "clang/AST/CXXInheritance.h"
#include "clang/AST/RecursiveASTVisitor.h"
+#include "clang/AST/StmtVisitor.h"
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
#include "clang/StaticAnalyzer/Core/B
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Ryosuke Niwa (rniwa)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/93403.diff
1 Files Affected:
- (modified)
clang/lib/StaticAnalyzer/Checkers/WebKit/RefCntblBaseVirtualDtorChecker.cpp
(+1-1)
`
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/93403.diff
1 Files Affected:
- (modified)
clang/lib/StaticAnalyzer/Checkers/WebKit/RefCntblBaseVirtualDtorChecker.cpp
(+1-1)
``diff
diff
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/93404
The issue with the previous implementation bc31be7 was that getApproximateType
could potentially return a null QualType for a dereferencing operator, which is
not what its caller wants.
>From 7639cb738dfb876c7a
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Younan Zhang (zyn0217)
Changes
The issue with the previous implementation bc31be7 was that getApproximateType
could potentially return a null QualType for a dereferencing operator, which is
not what its caller wants.
---
Full
VoltrexKeyva wrote:
Pinging again after another week of no reviews.
https://github.com/llvm/llvm-project/pull/91874
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2024-05-26T10:50:44+02:00
New Revision: 5220b7bea8b01f46e9f7326b9c9a7e550e8451d1
URL:
https://github.com/llvm/llvm-project/commit/5220b7bea8b01f46e9f7326b9c9a7e550e8451d1
DIFF:
https://github.com/llvm/llvm-project/commit/5220b7bea8b01f46e9f7326b9c9a7e550e8451d1.diff
LO
Author: Timm Bäder
Date: 2024-05-26T10:50:45+02:00
New Revision: d0bb91739022e1f15b1ec9a6fd7fc92cd0f95444
URL:
https://github.com/llvm/llvm-project/commit/d0bb91739022e1f15b1ec9a6fd7fc92cd0f95444
DIFF:
https://github.com/llvm/llvm-project/commit/d0bb91739022e1f15b1ec9a6fd7fc92cd0f95444.diff
LO
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/93394
>From 00c93043fca8f8a1f20634ea1b281c60926bd571 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Sat, 25 May 2024 20:42:43 -0500
Subject: [PATCH 1/2] [clang][Sema] Don't emit 'declared here' note for builtin
fun
https://github.com/chapuni approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/93403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/93408
This change enables more accurate modeling of the write effects of `fread`. In
particular, instead of invalidating the whole buffer, in a best-effort basis,
we would try to invalidate the actually accesses elem
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Balazs Benics (steakhal)
Changes
This change enables more accurate modeling of the write effects of `fread`. In
particular, instead of invalidating the whole buffer, in a best-effort basis,
we would try to invalidate the
tbaederr wrote:
Would be nice if you could add new explicit tests for this.
https://github.com/llvm/llvm-project/pull/93394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5,7 +5,7 @@ void similar() { // expected-note {{'similar' declared here}}
if constexpr (similer<>) {} // expected-error {{use of undeclared identifier
'similer'; did you mean 'similar'?}}
}
void a() { if constexpr (__adl_swap<>) {}} // expected-error{{use of
undeclared
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/93408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/93299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal commented:
The patch makes sense to me.
Have you considered applying the same heuristic to C++ array new allocations?
I'll port this patch downstream to see how this would behave on the Juliet C++
benchmark or on some real-world code.
https://github.com/llvm/llvm-pr
steakhal wrote:
> I'll port this patch downstream to see how this would behave on the Juliet
> C++ benchmark or on some real-world code.
Ah nvm. llvm/main diverged quite a bit since 18.1.6. I can't just pick this
one. Given this, I won't backport and test this PR.
https://github.com/llvm/llvm
https://github.com/cor3ntin approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/93385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky created
https://github.com/llvm/llvm-project/pull/93411
Consider the following testcase:
```cpp
namespace PR12884_original {
template struct A {
struct B { ##1
template struct X {};
typedef int arg;
};
struct C {
typedef B::X x;
};
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qizhi Hu (jcsxky)
Changes
Consider the following testcase:
```cpp
namespace PR12884_original {
template struct A {
struct B { ##1
template struct X {};
typedef int arg;
};
struct C {
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/93411
>From f5f0b14945a70e3e4fd92d5e5cbdb428334fe2b8 Mon Sep 17 00:00:00 2001
From: Qizhi Hu <836744...@qq.com>
Date: Sat, 25 May 2024 16:30:27 +0800
Subject: [PATCH 1/2] [Clang][Sema] Use correct TemplateName when trans
https://github.com/jcsxky updated
https://github.com/llvm/llvm-project/pull/93411
>From f5f0b14945a70e3e4fd92d5e5cbdb428334fe2b8 Mon Sep 17 00:00:00 2001
From: Qizhi Hu <836744...@qq.com>
Date: Sat, 25 May 2024 16:30:27 +0800
Subject: [PATCH 1/2] [Clang][Sema] Use correct TemplateName when trans
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/93338
>From 43050fe6f93436b43b4aa336013a91eed1d6d23a Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Fri, 24 May 2024 22:46:53 +0300
Subject: [PATCH 1/3] fix(93284): replace direct access to ExprEvalContexts
with
https://github.com/Endilll commented:
LGTM
https://github.com/llvm/llvm-project/pull/93338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/90830
>From 24cbbd0c87ab2a06381d210da1dff5f966b72773 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 2 May 2024 15:44:45 +0800
Subject: [PATCH 1/7] reformat
---
.../clang-tidy/readability/CMakeLists.txt
kimgr wrote:
@sdkrystian It looks like this PR broke IWYU with respect to this assumption:
> Moreover, we don't ever need the type as written -- in almost all cases, we
> only want the template arguments (e.g. in tooling use-cases).
As I understand it, IWYU did use the type as written to do res
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/93338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Oleksandr T
Date: 2024-05-26T15:46:08+02:00
New Revision: a4a436672a2c179274e07aeb68e9acd6f483a653
URL:
https://github.com/llvm/llvm-project/commit/a4a436672a2c179274e07aeb68e9acd6f483a653
DIFF:
https://github.com/llvm/llvm-project/commit/a4a436672a2c179274e07aeb68e9acd6f483a653.diff
L
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/93338
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tomershafir wrote:
@sebastiankreutzer hey, were you able to reach the maintainers of llvm-xray and
probe them about its dev status? If yes, can you pls share how to reach them
and what did they say?
https://github.com/llvm/llvm-project/pull/90959
___
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/93394
>From 00c93043fca8f8a1f20634ea1b281c60926bd571 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Sat, 25 May 2024 20:42:43 -0500
Subject: [PATCH 1/3] [clang][Sema] Don't emit 'declared here' note for builtin
fun
@@ -5,7 +5,7 @@ void similar() { // expected-note {{'similar' declared here}}
if constexpr (similer<>) {} // expected-error {{use of undeclared identifier
'similer'; did you mean 'similar'?}}
}
void a() { if constexpr (__adl_swap<>) {}} // expected-error{{use of
undeclared
@@ -7216,9 +7216,30 @@
TreeTransform::TransformElaboratedType(TypeLocBuilder &TLB,
return QualType();
}
- QualType NamedT = getDerived().TransformType(TLB, TL.getNamedTypeLoc());
- if (NamedT.isNull())
-return QualType();
+ QualType NamedT;
+ if (SemaRef.getLa
@@ -28,16 +28,17 @@ namespace PR12884_original {
typedef int arg;
};
struct C {
- typedef B::X x; // precxx17-warning{{missing 'typename'
prior to dependent type name B::X; implicit 'typename' is a C++20 extension}}
zyn0217 wrote:
A drive-b
@@ -7216,9 +7216,30 @@
TreeTransform::TransformElaboratedType(TypeLocBuilder &TLB,
return QualType();
}
- QualType NamedT = getDerived().TransformType(TLB, TL.getNamedTypeLoc());
- if (NamedT.isNull())
-return QualType();
+ QualType NamedT;
+ if (SemaRef.getLa
https://github.com/davidstone created
https://github.com/llvm/llvm-project/pull/93417
None
>From f4b9852b0c11a9b5087c5fdb7794b5cab7f4d22c Mon Sep 17 00:00:00 2001
From: David Stone
Date: Sun, 26 May 2024 10:34:09 -0600
Subject: [PATCH] [clang][Modules] Remove unnecessary includes of `Module.h`
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clangd
Author: David Stone (davidstone)
Changes
---
Patch is 28.19 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/93417.diff
10 Files
Author: Ryosuke Niwa
Date: 2024-05-26T10:50:53-07:00
New Revision: f28085aac2b2202f911911a6f6e459a9fd099460
URL:
https://github.com/llvm/llvm-project/commit/f28085aac2b2202f911911a6f6e459a9fd099460
DIFF:
https://github.com/llvm/llvm-project/commit/f28085aac2b2202f911911a6f6e459a9fd099460.diff
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/93403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,7 +11,7 @@
//
s-barannikov wrote:
I guess this file should've been removed.
https://github.com/llvm/llvm-project/pull/93388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/davidstone updated
https://github.com/llvm/llvm-project/pull/93388
>From f4b9852b0c11a9b5087c5fdb7794b5cab7f4d22c Mon Sep 17 00:00:00 2001
From: David Stone
Date: Sun, 26 May 2024 10:34:09 -0600
Subject: [PATCH 1/3] [clang][Modules] Remove unnecessary includes of
`Module.h`
https://github.com/davidstone edited
https://github.com/llvm/llvm-project/pull/93388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davidstone wrote:
> I don't like the PR since I don't feel it makes the code cleaner and it may
> make the downstream suffering backporting.
>
> If there are deeper reasons or following patches, we can discuss them
> seperately.
On its own, I would agree. My goal is to split several more thin
davidstone wrote:
To give a little more detail about my plans as of right now:
* Move `VisibleModuleSet` into its own file
* Move `ASTFileSignature` into its own file
* Take some of the related members of `Module`, group them together into their
own class, and move the resulting classes into th
andjo403 wrote:
It was the usage of exactIntersectWith in
https://github.com/llvm/llvm-project/pull/91101 vs the intersectWith that I
used that I wanted to sort out but think that we have conluded that it shall be
intersectWith.
so this it ready for review
https://github.com/llvm/llvm-project
https://github.com/lnihlen converted_to_draft
https://github.com/llvm/llvm-project/pull/93428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lnihlen created
https://github.com/llvm/llvm-project/pull/93428
This is a re-application of #71540, with the hopes I can get some help from
@pmatos and others to finish it. Right now the
'../clang/test/CodeGen/WebAssembly/wasm-funcref.c' test fails with an assertion
trying
llvmbot wrote:
@llvm/pr-subscribers-backend-webassembly
Author: Lucile Rose Nihlen (lnihlen)
Changes
This is a re-application of #71540, with the hopes I can get some help
from @pmatos and others to finish it. Right now the
'../clang/test/CodeGen/WebAssembly/wasm-funcref.c' test fails wi
https://github.com/lnihlen updated
https://github.com/llvm/llvm-project/pull/93428
>From fc5e70b0f4e3182487ddb52b0b675b798dff62ba Mon Sep 17 00:00:00 2001
From: Lucile Nihlen
Date: Sat, 25 May 2024 18:55:09 +
Subject: [PATCH 1/2] Apply patch from #71540
---
.../test/CodeGen/WebAssembly/bu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff faef8b4aa245a671e2013319e8073a9fc52ae12e
e79363aed798ce22f408fea3c283bb7d6387535a --
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/93430
Implement wg21.link/P2797.
Because taking the address of an explicit object member function results in a
function pointer, a call expression where the id-expression is an explicit
object member is made to beha
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
Implement wg21.link/P2797.
Because taking the address of an explicit object member function results in a
function pointer, a call expression where the id-expression is an explicit
object member is made to beha
pmatos wrote:
> This is a re-application of #71540, with the hopes I can get some help from
> @pmatos and others to finish it. Right now the
> '../clang/test/CodeGen/WebAssembly/wasm-funcref.c' test fails with an
> assertion trying to cast the target("wasm.funcref") instruction to a pointer.
https://github.com/AtariDreams converted_to_draft
https://github.com/llvm/llvm-project/pull/85316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/93431
This improves and unifies our approach to printing all template arguments.
The same approach to printing types is extended to all TemplateArguments: A
sugared version is printed in quotes, followed by printing
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
This improves and unifies our approach to printing all template arguments.
The same approach to printing types is extended to all TemplateArguments: A
sugared version is printed in quotes, followed by pr
https://github.com/5chmidti edited
https://github.com/llvm/llvm-project/pull/89490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -501,70 +506,72 @@ def main():
# Build up a big regexy filter from all command line arguments.
file_name_re = re.compile("|".join(args.files))
+files = {f for f in files if file_name_re.search(f)}
-return_code = 0
+returncode = 0
try:
-# S
@@ -501,70 +506,72 @@ def main():
# Build up a big regexy filter from all command line arguments.
file_name_re = re.compile("|".join(args.files))
+files = {f for f in files if file_name_re.search(f)}
-return_code = 0
+returncode = 0
try:
-# S
https://github.com/5chmidti commented:
Thanks for the cleanup, it looks overall good (w.r.t `asyncio`: I only know
about `asyncio` what I read in this pr).
> Only print the filename after completion, not the entire Clang-Tidy
> invocation command. I find this neater but the behavior can easily
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/93431
>From c23a96038a8233b44b49bc0a1d2a2475e4d2a8ae Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Fri, 24 May 2024 12:22:55 -0300
Subject: [PATCH] [clang] Improve ast-dumper text printing of TemplateArgument
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/92997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/93431
>From 031e7c235ce5cbae31504c21eeecc7655fbd1566 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Fri, 24 May 2024 12:22:55 -0300
Subject: [PATCH] [clang] Improve ast-dumper text printing of TemplateArgument
https://github.com/mizvekov commented:
The problem here is the loss of the qualification on the TemplateNames
This patch fixes the problem, without taking any workarounds:
https://github.com/llvm/llvm-project/pull/93433
It also doesn't cause any change in diagnostics in
`clang/test/SemaTempla
@@ -159,7 +159,8 @@ class APINotesManager {
ArrayRef getCurrentModuleReaders() const {
bool HasPublic = CurrentModuleReaders[ReaderKind::Public];
bool HasPrivate = CurrentModuleReaders[ReaderKind::Private];
-assert((!HasPrivate || HasPublic) && "private module req
ChuanqiXu9 wrote:
BTW, I tried to split `Module` class into `ModuleBase`, `ClangModule` and
`Cpp20Modules` (and HeaderUnits) classes to improve the readability. But it
showed too hard and too many things get changes then I stopped.
https://github.com/llvm/llvm-project/pull/93388
__
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/93431
>From f9892ebed002d73c74f44629e926386006f7bec1 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Fri, 24 May 2024 12:22:55 -0300
Subject: [PATCH] [clang] Improve ast-dumper text printing of TemplateArgument
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,106 @@
+//===-- ModuleDependencyScanner.h *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -740,6 +741,21 @@
DirectoryBasedGlobalCompilationDatabase::getProjectInfo(PathRef File) const {
return Res->PI;
}
+std::shared_ptr
+DirectoryBasedGlobalCompilationDatabase::getProjectModules(PathRef File) const
{
+ CDBLookupRequest Req;
+ Req.FileName = File;
+ Req.S
@@ -0,0 +1,106 @@
+//===-- ModuleDependencyScanner.h *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,106 @@
+//===-- ModuleDependencyScanner.h *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,81 @@
+//=== ModuleDependencyScanner.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,106 @@
+//===-- ModuleDependencyScanner.h *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,106 @@
+//===-- ModuleDependencyScanner.h *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,106 @@
+//===-- ModuleDependencyScanner.h *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,106 @@
+//===-- ModuleDependencyScanner.h *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,81 @@
+//=== ModuleDependencyScanner.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/ChuanqiXu9 commented:
Thanks for reviewing. It makes the code looks better indeed.
https://github.com/llvm/llvm-project/pull/66462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
@@ -0,0 +1,339 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,106 @@
+//===-- ModuleDependencyScanner.h *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,71 @@
+//===- ModulesBuilder.h --*-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,71 @@
+//===- ModulesBuilder.h --*-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,339 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,62 @@
+//===-- ProjectModules.h -*-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,339 @@
+//===- ModulesBuilder.cpp *-
C++-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
simonzgx wrote:
Hi @erichkeane , can this patch be merged? Or if there is anything else I need
to do, please let me know.
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
ChuanqiXu9 wrote:
Oh, I don't know why I didn't get this in files page so I missed this.
But since we can't get rid of writing/reading the modules actually in
`ModulesBuilder` (Or it is pretty hard). Then it looks not so worthy to
introduce the layer.
https
gulfemsavrun wrote:
We started seeing the following issue after this patch in our Clang toolchain
builders:
```
1448/1517](45) Linking CXX executable unittests/LineEditor/LineEditorTests
FAILED: unittests/LineEditor/LineEditorTests
: && /b/s/w/ir/x/w/cipd/bin/clang++ --sysroot=/b/s/w/ir/x/w/ci
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/77522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 123 matches
Mail list logo
