[clang] [analyzer][NFC] Use ArrayRef for input parameters (PR #93203)

2024-06-26 Thread Gábor Horváth via cfe-commits
@@ -672,7 +672,7 @@ class StdLibraryFunctionsChecker StringRef getNote() const { return Note; } }; - using ArgTypes = std::vector>; + using ArgTypes = ArrayRef>; Xazax-hun wrote: I am also wondering if `optional` is a smell, since QualType can be nul

[clang] [analyzer][NFC] Use ArrayRef for input parameters (PR #93203)

2024-06-26 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/93203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e096b28 - [clang][Interp] Fix CXXUuidOfExprs with incomplete record types

2024-06-26 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-27T08:53:20+02:00 New Revision: e096b282cc228f8c5c774c857a943eaa0f5e1586 URL: https://github.com/llvm/llvm-project/commit/e096b282cc228f8c5c774c857a943eaa0f5e1586 DIFF: https://github.com/llvm/llvm-project/commit/e096b282cc228f8c5c774c857a943eaa0f5e1586.diff LO

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-26 Thread David Green via cfe-commits
davemgreen wrote: Could you explain more about what broke? Are you using target(..) attributes? https://github.com/llvm/llvm-project/pull/96832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] [clang-tidy] Attempt to fix issue 96247 (PR #96856)

2024-06-26 Thread via cfe-commits
https://github.com/trcrsired edited https://github.com/llvm/llvm-project/pull/96856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Attempt to fix issue 96247 (PR #96856)

2024-06-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/96856 >From e824af82ad45b0e1392173d0f0f4f3463413d038 Mon Sep 17 00:00:00 2001 From: cqwrteur <100043421+trcrsi...@users.noreply.github.com> Date: Thu, 27 Jun 2024 02:10:40 -0400 Subject: [PATCH] Attempt to fix issue 9

[clang-tools-extra] Attempt to fix issue 96247 (PR #96856)

2024-06-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: cqwrteur (trcrsired) Changes https://github.com/llvm/llvm-project/issues/96247 These libraries are not linked for windows gnu targets since the libraries are not linked. I need to find out what's going on here. But first, I wi

[clang-tools-extra] Attempt to fix issue 96247 (PR #96856)

2024-06-26 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] Attempt to fix issue 96247 (PR #96856)

2024-06-26 Thread via cfe-commits
https://github.com/trcrsired created https://github.com/llvm/llvm-project/pull/96856 https://github.com/llvm/llvm-project/issues/96247 These libraries are not linked for windows gnu targets since the libraries are not linked. I need to find out what's going on here. But first, I will just run

[clang] [clang][transformer] Introduce a `constructExprArgs` range selector. (PR #95901)

2024-06-26 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle closed https://github.com/llvm/llvm-project/pull/95901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6b931ab - [clang][transformer] Introduce a `constructExprArgs` range selector. (#95901)

2024-06-26 Thread via cfe-commits
Author: Clement Courbet Date: 2024-06-27T07:56:06+02:00 New Revision: 6b931ab516616127ce4cd5a0ad5e37d5a1d1696b URL: https://github.com/llvm/llvm-project/commit/6b931ab516616127ce4cd5a0ad5e37d5a1d1696b DIFF: https://github.com/llvm/llvm-project/commit/6b931ab516616127ce4cd5a0ad5e37d5a1d1696b.dif

[clang] [Clang] Clarify diagnostic notes for implicitly generated deduction guides (PR #96084)

2024-06-26 Thread Younan Zhang via cfe-commits
@@ -108,8 +108,11 @@ struct Foo { Foo(T const (&)[N]); }; +// FIXME: Prefer non-canonical template arguments in the deduction guide? template using Bar = Foo; // expected-note {{candidate template ignored: couldn't infer template argument 'X'}} \ +

[clang] [Clang] Clarify diagnostic notes for implicitly generated deduction guides (PR #96084)

2024-06-26 Thread Younan Zhang via cfe-commits
@@ -108,8 +108,11 @@ struct Foo { Foo(T const (&)[N]); }; +// FIXME: Prefer non-canonical template arguments in the deduction guide? template using Bar = Foo; // expected-note {{candidate template ignored: couldn't infer template argument 'X'}} \ +

[libcxx] [libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-26 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/93429 >From 8c1b899aa174b107fece1edbf99eaf261bdea516 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 25 Apr 2022 09:45:22 +0300 Subject: [PATCH 1/8] [runtimes] [CMake] Use CMAKE_REQUIRED_

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
dougsonos wrote: > I guess you meant to link to > https://llvm-compile-time-tracker.com/compare.php?from=f03cb005eb4ba3c6fb645aca2228e907db8cd452&to=038b39d3235c6c8151127c34d34f498dd298273c&stat=instructions:u > directly? Thanks! https://github.com/llvm/llvm-project/pull/96844 ___

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: I guess you meant to link to https://llvm-compile-time-tracker.com/compare.php?from=f03cb005eb4ba3c6fb645aca2228e907db8cd452&to=038b39d3235c6c8151127c34d34f498dd298273c&stat=instructions:u directly? https://github.com/llvm/llvm-project/pull/96844 ___

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
@@ -5132,6 +5130,10 @@ class FunctionProtoType final return hasExtParameterInfos() ? getNumParams() : 0; } + unsigned numTrailingObjects(OverloadToken) const { dougsonos wrote: Seems necessary when making Qualifiers no longer last. https://github.com/

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
@@ -8619,6 +8621,18 @@ QualType DecayedType::getPointeeType() const { void FixedPointValueToString(SmallVectorImpl &Str, llvm::APSInt Val, unsigned Scale); +inline FunctionEffectsRef FunctionEffectsRef::get(QualType QT) { dougsonos

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
@@ -7623,6 +7623,7 @@ handleNonBlockingNonAllocatingTypeAttr(TypeProcessingState &TPState, FunctionEffectSet FX(EPI.FunctionEffects); FunctionEffectSet::Conflicts Errs; bool Success = FX.insert(NewEC, Errs); + (void)Success; dougsonos wrote: >From the

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
@@ -3857,9 +3857,19 @@ void FunctionProtoType::Profile(llvm::FoldingSetNodeID &ID, QualType Result, } epi.ExtInfo.Profile(ID); - ID.AddInteger((epi.AArch64SMEAttributes << 1) | epi.HasTrailingReturn); - epi.FunctionEffects.Profile(ID); + unsigned EffectCount = epi.Fu

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
@@ -3857,9 +3857,19 @@ void FunctionProtoType::Profile(llvm::FoldingSetNodeID &ID, QualType Result, } epi.ExtInfo.Profile(ID); - ID.AddInteger((epi.AArch64SMEAttributes << 1) | epi.HasTrailingReturn); - epi.FunctionEffects.Profile(ID); + unsigned EffectCount = epi.Fu

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
@@ -132,7 +132,6 @@ class TemplateArgument; class TemplateArgumentListInfo; class TemplateArgumentLoc; class TemplateTypeParmDecl; -template class TreeTransform; dougsonos wrote: Was made unnecessary by a late change in the previous branch. https://github.co

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
dougsonos wrote: This reduces the compile-time regression introduced by f03cb005eb4ba3c6fb645aca2228e907db8cd452 [Clang] Introduce `nonblocking`/`nonallocating` attributes (#84983) https://github.com/llvm/llvm-project/pull/96844 ___ cfe-commits mailin

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Doug Wyatt (dougsonos) Changes - Put new FunctionProtoType trailing objects last. - Inline FunctionEffectsRef::get() - Manually inline FunctionEffectsRef::Profile(). --- Full diff: https://github.com/llvm/llvm-project/pull/96844.diff 4 F

[clang] Performance optimizations for function effects (nonblocking attribute etc.) (PR #96844)

2024-06-26 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos created https://github.com/llvm/llvm-project/pull/96844 - Put new FunctionProtoType trailing objects last. - Inline FunctionEffectsRef::get() - Manually inline FunctionEffectsRef::Profile(). >From 038b39d3235c6c8151127c34d34f498dd298273c Mon Sep 17 00:00:00 2001 Fro

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
@@ -652,6 +652,134 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/96453 >From a035ae25314f3168f73108988f2bb7671e7d9e7f Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Mon, 24 Jun 2024 11:41:23 +0800 Subject: [PATCH 1/3] [Doc] Update documentation for no-transitive-change --- cla

[clang] Try to fix llvm/llvm-project#41441 (PR #96464)

2024-06-26 Thread via cfe-commits
awson wrote: @erichkeane, @cor3ntin I see you actively reviewed (related, failed) #89036. Could you look into this? The idea of the fix is extremely simple: if we want to do something once, but mistakenly do it twice, just don't do it the first time. https://github.com/llvm/llvm-project/pull

[clang] [clang] fix the unexpected controlflow in `ParseTentative.cpp` (PR #95917)

2024-06-26 Thread via cfe-commits
https://github.com/c8ef closed https://github.com/llvm/llvm-project/pull/95917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement pointer authentication for C++ virtual functions, v-tables, and VTTs (PR #94056)

2024-06-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin` running on `doug-worker-3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/407 Here is the rel

[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-26 Thread Evgenii Kudriashov via cfe-commits
e-kud wrote: > I think the specific checks clang is doing here have to be part of clang: in > particular, clang needs to translate from gcc syntax to LLVM IR asm syntax, > and that requires parsing the constraints. So these checks are necessary, and > emitting better diagnostics for checks we

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-06-26 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I don't see any issues with the code. I'd prefer if we has a TYSan-instrumented bootstrap build of LLVM before we merge this, so we're confident this doesn't cause any unexpected issues. https://github.com/llvm/llvm-project/pull/76612 _

[clang] [llvm] [RISCV] Add processor definition for SpacemiT-X60 (PR #94564)

2024-06-26 Thread Yangyu Chen via cfe-commits
cyyself wrote: I have a question: SpacemiT-X60 does not support Zicclsm on Vector, which is the same as K230, as discussed in #88029 . Is the Zicclsm safe here? https://github.com/llvm/llvm-project/pull/94564 ___ cfe-commits mailing list cfe-commits@l

[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-26 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud updated https://github.com/llvm/llvm-project/pull/96363 >From 4f8504878da33925609d52912e8d0e1f64c41066 Mon Sep 17 00:00:00 2001 From: Evgenii Kudriashov Date: Fri, 21 Jun 2024 14:00:58 -0700 Subject: [PATCH 1/3] [clang] Improve diagnostics for constraints of inline asm

[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-06-26 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/94693 >From 210121e2ba5c5e7d759b6e603d1daece5e1e9d12 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH] [Clang] Introduce [[clang::coro_inplace_task]] --- clang/in

[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-26 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud updated https://github.com/llvm/llvm-project/pull/96363 >From 4f8504878da33925609d52912e8d0e1f64c41066 Mon Sep 17 00:00:00 2001 From: Evgenii Kudriashov Date: Fri, 21 Jun 2024 14:00:58 -0700 Subject: [PATCH 1/2] [clang] Improve diagnostics for constraints of inline asm

[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-26 Thread Evgenii Kudriashov via cfe-commits
https://github.com/e-kud edited https://github.com/llvm/llvm-project/pull/96363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-26 Thread Evgenii Kudriashov via cfe-commits
@@ -309,6 +309,39 @@ def err_asm_invalid_type : Error< def err_ms_asm_bitfield_unsupported : Error< "an inline asm block cannot have an operand which is a bit-field">; +def asm_invalid_constraint_generic : TextSubstitution< + "invalid %select{input|output}0 constraint '%1'

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/96453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Doc] Update documentation for no-transitive-change (PR #96453)

2024-06-26 Thread Chuanqi Xu via cfe-commits
@@ -652,6 +652,141 @@ in the future. The expected roadmap for Reduced BMIs as of Clang 19.x is: comes, the term BMI will refer to the Reduced BMI and the Full BMI will only be meaningful to build systems which elect to support two-phase compilation. +Experimental No Tra

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-26 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: The grammer looks exactly the same with modules. May it be compatible with modules? https://github.com/llvm/llvm-project/pull/96823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement pointer authentication for C++ virtual functions, v-tables, and VTTs (PR #94056)

2024-06-26 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha closed https://github.com/llvm/llvm-project/pull/94056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
@@ -12,16 +12,25 @@ #include "clang/AST/Comment.h" #include "clang/Index/USRGeneration.h" #include "llvm/ADT/StringExtras.h" -#include "llvm/Support/Error.h" +#include "llvm/Support/Mutex.h" +#include namespace clang { namespace doc { + +static std::unordered_set USRVisi

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
@@ -12,16 +12,25 @@ #include "clang/AST/Comment.h" #include "clang/Index/USRGeneration.h" #include "llvm/ADT/StringExtras.h" -#include "llvm/Support/Error.h" +#include "llvm/Support/Mutex.h" +#include namespace clang { namespace doc { + +static std::unordered_set USRVisi

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi requested changes to this pull request. While this is likely a step in the right direction, I'm a bit skeptical that this patch is entirely correct. First, I think we need to understand why we only want to cache/memoize the USR strings from definitions. Second, th

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-26 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/96809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Support --sysroot= for ${arch}-windows-msvc targets (PR #96417)

2024-06-26 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/96417 >From 3a1790211a993908d6a9ab3cca1fa6eb2421e710 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Sun, 23 Jun 2024 00:07:19 -0400 Subject: [PATCH] Support --sysroot= for ${arch}-windows-msvc targets I think it is

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-26 Thread William G Hatch via cfe-commits
willghatch wrote: @labrinea please take a look. The [PR mentioned](https://github.com/llvm/llvm-project/pull/94279) above removed this code and broke AArch64 feature detection for us. https://github.com/llvm/llvm-project/pull/96832 ___ cfe-commits m

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-26 Thread weiwei chen via cfe-commits
weiweichen wrote: Not sure if this is the right fix, so any clang experts here, please take a look to see if this is acceptable? https://github.com/llvm/llvm-project/pull/96832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-26 Thread weiwei chen via cfe-commits
weiweichen wrote: @willghatch 👀 https://github.com/llvm/llvm-project/pull/96832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-26 Thread weiwei chen via cfe-commits
https://github.com/weiweichen updated https://github.com/llvm/llvm-project/pull/96832 >From 37e0ff835b7ade8def6e141ae7a55d55380f887e Mon Sep 17 00:00:00 2001 From: Weiwei Chen Date: Wed, 26 Jun 2024 19:28:58 -0400 Subject: [PATCH 1/2] Bring initFeatureMap back to AArch64TargetInfo. --- clang/

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-26 Thread weiwei chen via cfe-commits
https://github.com/weiweichen updated https://github.com/llvm/llvm-project/pull/96832 >From 37e0ff835b7ade8def6e141ae7a55d55380f887e Mon Sep 17 00:00:00 2001 From: Weiwei Chen Date: Wed, 26 Jun 2024 19:28:58 -0400 Subject: [PATCH 1/2] Bring initFeatureMap back to AArch64TargetInfo. --- clang/

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: weiwei chen (weiweichen) Changes We noticed that `TargetInfo::CreateTargetInfo` is giving up back empty `opt->featureMap` for AArch64, which is probably related to [this change](https://github.com/llvm/llvm-project/commit/a03d06

[clang] [Clang] Bring initFeatureMap back to AArch64TargetInfo. (PR #96832)

2024-06-26 Thread weiwei chen via cfe-commits
https://github.com/weiweichen created https://github.com/llvm/llvm-project/pull/96832 We noticed that `TargetInfo::CreateTargetInfo` is giving up back empty `opt->featureMap` for AArch64, which is probably related to [this change](https://github.com/llvm/llvm-project/commit/a03d06a736fd8921c8f

[clang] [llvm] [openmp] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-06-26 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/76587 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/23] Add profiling functions to libomptarget

[clang] [clang][NFC] Use range-based for loops (PR #96831)

2024-06-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (MagentaTreehouse) Changes Use range-based for loops. In addition, extracted a loop from `CXXRecordDecl::completeDefinition` to eliminate the `Done` flag, and only construct `MyFinalOverriders` when `FinalOverriders` is null. --- Fu

[clang] [clang][NFC] Use range-based for loops (PR #96831)

2024-06-26 Thread via cfe-commits
https://github.com/MagentaTreehouse created https://github.com/llvm/llvm-project/pull/96831 Use range-based for loops. In addition, extracted a loop from `CXXRecordDecl::completeDefinition` to eliminate the `Done` flag, and only construct `MyFinalOverriders` when `FinalOverriders` is null. >F

[clang-tools-extra] [clang-tidy] add option to avoid "no checks enabled" error (PR #96122)

2024-06-26 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/96122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4558e45 - [clang-tidy] add option to avoid "no checks enabled" error (#96122)

2024-06-26 Thread via cfe-commits
Author: Congcong Cai Date: 2024-06-27T07:27:58+08:00 New Revision: 4558e45e7e33d1cfc1a54af761085e358dbab64b URL: https://github.com/llvm/llvm-project/commit/4558e45e7e33d1cfc1a54af761085e358dbab64b DIFF: https://github.com/llvm/llvm-project/commit/4558e45e7e33d1cfc1a54af761085e358dbab64b.diff

[clang] [libc] [libc] Remove atomic alignment diagnostics globally (PR #96803)

2024-06-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang,libc` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/756 Here is

[clang-tools-extra] [clang-tidy] add default value for misc-use-internal-linkage [NFC] (PR #96779)

2024-06-26 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/96779 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 8f2d74a - [clang-tidy] add default value for misc-use-internal-linkage [NFC] (#96779)

2024-06-26 Thread via cfe-commits
Author: Congcong Cai Date: 2024-06-27T07:26:37+08:00 New Revision: 8f2d74affd8f4f182a2e9f05e86b494aad1b707c URL: https://github.com/llvm/llvm-project/commit/8f2d74affd8f4f182a2e9f05e86b494aad1b707c DIFF: https://github.com/llvm/llvm-project/commit/8f2d74affd8f4f182a2e9f05e86b494aad1b707c.diff

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-26 Thread Philip Reames via cfe-commits
https://github.com/preames approved this pull request. LGTM w/minor comments https://github.com/llvm/llvm-project/pull/94352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-26 Thread Philip Reames via cfe-commits
@@ -83,8 +83,14 @@ void riscv::getRISCVTargetFeatures(const Driver &D, const llvm::Triple &Triple, // and other features (ex. mirco architecture feature) from mcpu if (Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) { StringRef CPU = A->getValue(); -if (CPU == "nat

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-26 Thread Philip Reames via cfe-commits
@@ -2002,6 +2003,76 @@ bool sys::getHostCPUFeatures(StringMap &Features) { return true; } +#elif defined(__linux__) && defined(__riscv) +// struct riscv_hwprobe +struct RISCVHwProbe { + int64_t Key; + uint64_t Value; +}; +bool sys::getHostCPUFeatures(StringMap &Features) {

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-26 Thread Philip Reames via cfe-commits
@@ -2002,6 +2003,76 @@ bool sys::getHostCPUFeatures(StringMap &Features) { return true; } +#elif defined(__linux__) && defined(__riscv) +// struct riscv_hwprobe +struct RISCVHwProbe { + int64_t Key; + uint64_t Value; +}; +bool sys::getHostCPUFeatures(StringMap &Features) {

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-26 Thread Philip Reames via cfe-commits
@@ -2002,6 +2003,76 @@ bool sys::getHostCPUFeatures(StringMap &Features) { return true; } +#elif defined(__linux__) && defined(__riscv) +// struct riscv_hwprobe +struct RISCVHwProbe { + int64_t Key; + uint64_t Value; +}; +bool sys::getHostCPUFeatures(StringMap &Features) {

[clang] [llvm] [RISCV] Add support for getHostCPUFeatures using hwprobe (PR #94352)

2024-06-26 Thread Philip Reames via cfe-commits
https://github.com/preames edited https://github.com/llvm/llvm-project/pull/94352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [libc] Remove atomic alignment diagnostics globally (PR #96803)

2024-06-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/96803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f23a5f0 - [libc] Remove atomic alignment diagnostics globally (#96803)

2024-06-26 Thread via cfe-commits
Author: Joseph Huber Date: 2024-06-26T18:12:46-05:00 New Revision: f23a5f08f4b8d7734cf11342b2c1a405823e899e URL: https://github.com/llvm/llvm-project/commit/f23a5f08f4b8d7734cf11342b2c1a405823e899e DIFF: https://github.com/llvm/llvm-project/commit/f23a5f08f4b8d7734cf11342b2c1a405823e899e.diff

[clang] [libc] [libc] Remove atomic alignment diagnostics globally (PR #96803)

2024-06-26 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/96803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [libc] Remove atomic alignment diagnostics globally (PR #96803)

2024-06-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96803 >From 66b82f970e8914a920259dd12decd65fbb325356 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 26 Jun 2024 12:58:22 -0500 Subject: [PATCH] [libc] Remove atomic alignment diagnostics globally Summary: Thes

[clang] [MS ABI]: Support preserve_none in MS ABI (PR #96487)

2024-06-26 Thread via cfe-commits
https://github.com/antangelo closed https://github.com/llvm/llvm-project/pull/96487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5dcf3d5 - [MS ABI]: Support preserve_none in MS ABI (#96487)

2024-06-26 Thread via cfe-commits
Author: antangelo Date: 2024-06-26T18:54:41-04:00 New Revision: 5dcf3d5335a8bd936c89a4cdf1da909e6b995b6f URL: https://github.com/llvm/llvm-project/commit/5dcf3d5335a8bd936c89a4cdf1da909e6b995b6f DIFF: https://github.com/llvm/llvm-project/commit/5dcf3d5335a8bd936c89a4cdf1da909e6b995b6f.diff LOG

[libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-26 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/93429 >From 8c1b899aa174b107fece1edbf99eaf261bdea516 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 25 Apr 2022 09:45:22 +0300 Subject: [PATCH 1/7] [runtimes] [CMake] Use CMAKE_REQUIRED_

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-26 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/96823 >From b67ecd20cc2c11f4f99c2d90c95fdbd988659947 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Wed, 26 Jun 2024 12:31:39 -0700 Subject: [PATCH 1/2] [HLSL] Implement `export` keyword Fixes #92812 --- .../clang/

[clang] [ParserHLSL] Attempt to parse HLSL annotations on Field Decls. (PR #96346)

2024-06-26 Thread Chris B via cfe-commits
@@ -0,0 +1,30 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -o - %s -verify + +// previously, this test would result in an error shown below on the line that +// declares variable a in struct Eg9: +// error: use of undeclared identifier +// 'SV_Dispat

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
https://github.com/minglotus-6 edited https://github.com/llvm/llvm-project/pull/81442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -277,35 +626,160 @@ CallBase &llvm::pgo::promoteIndirectCall(CallBase &CB, Function *DirectCallee, // Promote indirect-call to conditional direct-call for one callsite. bool IndirectCallPromoter::tryToPromoteWithFuncCmp( -CallBase &CB, const std::vector &Candidates, -

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -322,14 +796,133 @@ bool IndirectCallPromoter::processFunction(ProfileSummaryInfo *PSI) { if (!NumCandidates || (PSI && PSI->hasProfileSummary() && !PSI->isHotCount(TotalCount))) continue; + auto PromotionCandidates = getPromotionCandidatesForCallSite

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -322,14 +796,133 @@ bool IndirectCallPromoter::processFunction(ProfileSummaryInfo *PSI) { if (!NumCandidates || (PSI && PSI->hasProfileSummary() && !PSI->isHotCount(TotalCount))) continue; + auto PromotionCandidates = getPromotionCandidatesForCallSite

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -103,27 +112,226 @@ static cl::opt ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden, cl::desc("Dump IR after transformation happens")); +// Indirect call promotion pass will fall back to function-based comparison if +// vtable-count / function-

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -1425,16 +1430,27 @@ MDNode *getPGOFuncNameMetadata(const Function &F) { return F.getMetadata(getPGOFuncNameMetadataName()); } -void createPGOFuncNameMetadata(Function &F, StringRef PGOFuncName) { - // Only for internal linkage functions. - if (PGOFuncName == F.getName(

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -103,27 +112,226 @@ static cl::opt ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden, cl::desc("Dump IR after transformation happens")); +// Indirect call promotion pass will fall back to function-based comparison if +// vtable-count / function-

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -277,35 +626,160 @@ CallBase &llvm::pgo::promoteIndirectCall(CallBase &CB, Function *DirectCallee, // Promote indirect-call to conditional direct-call for one callsite. bool IndirectCallPromoter::tryToPromoteWithFuncCmp( -CallBase &CB, const std::vector &Candidates, -

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -322,14 +796,133 @@ bool IndirectCallPromoter::processFunction(ProfileSummaryInfo *PSI) { if (!NumCandidates || (PSI && PSI->hasProfileSummary() && !PSI->isHotCount(TotalCount))) continue; + auto PromotionCandidates = getPromotionCandidatesForCallSite

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -140,14 +348,56 @@ class IndirectCallPromoter { // indirect callee with functions. Returns true if there are IR // transformations and false otherwise. bool tryToPromoteWithFuncCmp( - CallBase &CB, const std::vector &Candidates, - uint64_t TotalCount, ArrayRe

[clang] [compiler-rt] [llvm] [TypeProf][InstrFDO]Implement more efficient comparison sequence for indirect-call-promotion with vtable profiles. (PR #81442)

2024-06-26 Thread Mingming Liu via cfe-commits
@@ -103,27 +112,226 @@ static cl::opt ICPDUMPAFTER("icp-dumpafter", cl::init(false), cl::Hidden, cl::desc("Dump IR after transformation happens")); +// Indirect call promotion pass will fall back to function-based comparison if +// vtable-count / function-

  1   2   3   4   >