[clang] [clang][bytecode][NFC] Add an additional assertion (PR #105927)

2024-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes Since this must be true, add an assertion instead of just documenting it via the comment. --- Full diff: https://github.com/llvm/llvm-project/pull/105927.diff 1 Files Affected: - (modified) clang/lib/AST/

[clang] [clang][bytecode][NFC] Add an additional assertion (PR #105927)

2024-08-23 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/105927 Since this must be true, add an assertion instead of just documenting it via the comment. >From 65ac59cb18b097251c7e6083f785562ba6278d82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat,

[clang] [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (PR #102131)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -972,8 +972,15 @@ static const Expr *SubstituteConstraintExpressionWithoutSatisfaction( // equivalence. LocalInstantiationScope ScopeForParameters(S); if (auto *FD = DeclInfo.getDecl()->getAsFunction()) -for (auto *PVD : FD->parameters()) - ScopeForParameters

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-23 Thread Vitaly Buka via cfe-commits
@@ -314,26 +314,55 @@ Currently, this option supports three overflow-dependent code idioms: unsigned long foo = -1UL; // No longer causes a negation overflow warning unsigned long bar = -2UL; // and so on... -``post-decr-while`` +``unsigned-post-decr-while`` .. cod

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-23 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/105709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 76236fa - [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (#105709)

2024-08-23 Thread via cfe-commits
Author: Justin Stitt Date: 2024-08-23T23:33:23-07:00 New Revision: 76236fafda19ff3760443196edcd3cd9610ed733 URL: https://github.com/llvm/llvm-project/commit/76236fafda19ff3760443196edcd3cd9610ed733 DIFF: https://github.com/llvm/llvm-project/commit/76236fafda19ff3760443196edcd3cd9610ed733.diff

[clang] 62e7b59 - [clang][bytecode][NFC] Move test case to -verify=expected,both style

2024-08-23 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-08-24T08:24:58+02:00 New Revision: 62e7b59f10d9af809dd54fc064e2f60f0b48938c URL: https://github.com/llvm/llvm-project/commit/62e7b59f10d9af809dd54fc064e2f60f0b48938c DIFF: https://github.com/llvm/llvm-project/commit/62e7b59f10d9af809dd54fc064e2f60f0b48938c.diff LO

[clang] [llvm] [NFC] Use const members of `StringToOffsetTable` (PR #105824)

2024-08-23 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/105824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 68030f8 - [clang][bytecode][NFC] Fix printing signed IntegralAP values

2024-08-23 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-08-24T08:21:25+02:00 New Revision: 68030f86aef11558c9ed14a34250433f57923c84 URL: https://github.com/llvm/llvm-project/commit/68030f86aef11558c9ed14a34250433f57923c84 DIFF: https://github.com/llvm/llvm-project/commit/68030f86aef11558c9ed14a34250433f57923c84.diff LO

[clang] [clang][bytecode] Fix IntegralAP::is{Positive, Negative} (PR #105924)

2024-08-23 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 10 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/4371 Here is the re

[clang] [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (PR #102131)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -972,8 +972,15 @@ static const Expr *SubstituteConstraintExpressionWithoutSatisfaction( // equivalence. LocalInstantiationScope ScopeForParameters(S); if (auto *FD = DeclInfo.getDecl()->getAsFunction()) -for (auto *PVD : FD->parameters()) - ScopeForParameters

[clang] [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (PR #102131)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -972,8 +972,15 @@ static const Expr *SubstituteConstraintExpressionWithoutSatisfaction( // equivalence. LocalInstantiationScope ScopeForParameters(S); if (auto *FD = DeclInfo.getDecl()->getAsFunction()) -for (auto *PVD : FD->parameters()) - ScopeForParameters

[clang] [clang][bytecode] Fix IntegralAP::is{Positive, Negative} (PR #105924)

2024-08-23 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/105924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c81d666 - [clang][bytecode] Fix IntegralAP::is{Positive,Negative} (#105924)

2024-08-23 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-24T07:50:23+02:00 New Revision: c81d6665601d648c1a5349b665ee6019f3786352 URL: https://github.com/llvm/llvm-project/commit/c81d6665601d648c1a5349b665ee6019f3786352 DIFF: https://github.com/llvm/llvm-project/commit/c81d6665601d648c1a5349b665ee6019f3786352.diff L

[clang] [clang][ARM] Fix warning for using VFP from interrupts. (PR #91870)

2024-08-23 Thread Chris Copeland via cfe-commits
chrisnc wrote: @ahmedbougacha yes, I think it's correct that calling an `__attribute__((interrupt))` function is safe to do on M-profile because there is no difference in the return sequence; all it does is not assume that the stack is 8-byte aligned initially. Even then, this is only needed w

[clang] [clang] Remove an incorrect assertion in ConstantFoldAttrs (PR #105789)

2024-08-23 Thread Timm Baeder via cfe-commits
tbaederr wrote: > > I guess it might make sense to create the `ConstantExpr` in any case, even > > for a `None` `APValue`? > > The comment above `ConstantFoldAttrArgs` seems to suggest that that’s what’s > supposed to happen if the expression isn’t dependent—I don’t know if there’s > any code

[clang] [clang-tools-extra] [clang][NFC] Un-constify `MultiLevelTemplateArgumentList` (PR #104687)

2024-08-23 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I not opposed to exploring a solution now. I suspect there might be a nicer solution that doesn't involve copies, I just have other priorities right now and it will take me a while until I can sit down and think about this. But if you want to think about the problem and find a

[clang] [clang][bytecode] Fix IntegralAP::is{Positive, Negative} (PR #105924)

2024-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This depends on signed-ness. --- Full diff: https://github.com/llvm/llvm-project/pull/105924.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/IntegralAP.h (+10-2) - (modified) clang/test/AST/Byt

[clang] 75ef955 - [clang][bytecode][NFC] Move test to verify=expected,both style

2024-08-23 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-08-24T07:18:36+02:00 New Revision: 75ef95584d8867d0039a43bad0bd8e53f3293f67 URL: https://github.com/llvm/llvm-project/commit/75ef95584d8867d0039a43bad0bd8e53f3293f67 DIFF: https://github.com/llvm/llvm-project/commit/75ef95584d8867d0039a43bad0bd8e53f3293f67.diff LO

[clang] [clang][bytecode] Fix IntegralAP::is{Positive, Negative} (PR #105924)

2024-08-23 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/105924 This depends on signed-ness. >From c773015150b8a93a37cd6121091a2072b6df5710 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 24 Aug 2024 07:16:54 +0200 Subject: [PATCH] [clang][bytecode]

[clang] [clang-format] Revert "[clang-format][NFC] Delete TT_LambdaArrow (#70… (PR #105923)

2024-08-23 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/105923 >From dbf35d6d7e1b0ba5c80453105757baf5357169d4 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 23 Aug 2024 02:24:39 -0700 Subject: [PATCH 1/2] [clang-format] Revert "[clang-format][NFC] Delete TT_LambdaArrow

[clang] [clang-format] Revert "[clang-format][NFC] Delete TT_LambdaArrow (#70… (PR #105923)

2024-08-23 Thread Owen Pan via cfe-commits
@@ -3369,6 +3371,20 @@ TEST_F(TokenAnnotatorTest, GNULanguageStandard) { EXPECT_TOKEN(Tokens[2], tok::spaceship, TT_BinaryOperator); } +TEST_F(TokenAnnotatorTest, SplitPenalty) { + auto Style = getLLVMStyle(); + Style.ColumnLimit = 20; + + auto Tokens = annotate("class fo

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2024-08-23 Thread via cfe-commits
@@ -9,20 +9,141 @@ #include "Haiku.h" #include "CommonArgs.h" #include "clang/Config/config.h" +#include "clang/Driver/Compilation.h" #include "llvm/Support/Path.h" using namespace clang::driver; +using namespace clang::driver::tools; using namespace clang::driver::toolcha

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2024-08-23 Thread via cfe-commits
@@ -9,20 +9,141 @@ #include "Haiku.h" #include "CommonArgs.h" #include "clang/Config/config.h" +#include "clang/Driver/Compilation.h" #include "llvm/Support/Path.h" using namespace clang::driver; +using namespace clang::driver::tools; using namespace clang::driver::toolcha

[clang] [Driver] Implement ToolChain on Haiku (PR #66038)

2024-08-23 Thread via cfe-commits
X547 wrote: Hello, one of this code authors here. Why I am seeing this patch only now? https://github.com/llvm/llvm-project/pull/66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly compute SplitPenalty of TrailingReturnArrow (PR #105613)

2024-08-23 Thread Owen Pan via cfe-commits
owenca wrote: See #105923. https://github.com/llvm/llvm-project/pull/105613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Correctly compute SplitPenalty of TrailingReturnArrow (PR #105613)

2024-08-23 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/105613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Consolidate tests for default argument substitution (PR #105617)

2024-08-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/105617 >From b837b99272353cb792a9ef19f1f68fd0b4bf8514 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 22 Aug 2024 13:08:12 +0800 Subject: [PATCH] [Clang][NFC] Consolidate tests for default argument substitution

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -944,12 +950,63 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef, TypeAliasTemplateDecl *AliasTemplate) { return {Template, AliasRhsTemplateArgs}; } +// Build the type for a deduction guide generated from an inherited constructor +// [over.match.class.deduct]p1.10: +// ... the

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -1388,6 +1695,33 @@ void Sema::DeclareImplicitDeductionGuides(TemplateDecl *Template, if (!AddedAny) Transform.buildSimpleDeductionGuide(std::nullopt); + // FIXME: Handle explicit deduction guides from inherited constructors antangelo wrote: Done

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -1388,6 +1695,33 @@ void Sema::DeclareImplicitDeductionGuides(TemplateDecl *Template, if (!AddedAny) Transform.buildSimpleDeductionGuide(std::nullopt); + // FIXME: Handle explicit deduction guides from inherited constructors + // when the base deduction guides are

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -944,12 +950,63 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef, TypeAliasTemplateDecl *AliasTemplate) { return {Template, AliasRhsTemplateArgs}; } +// Build the type for a deduction guide generated from an inherited constructor +// [over.match.class.deduct]p1.10: +// ... the

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -944,12 +950,63 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef, TypeAliasTemplateDecl *AliasTemplate) { return {Template, AliasRhsTemplateArgs}; } +// Build the type for a deduction guide generated from an inherited constructor +// [over.match.class.deduct]p1.10: +// ... the

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -944,12 +950,63 @@ getRHSTemplateDeclAndArgs(Sema &SemaRef, TypeAliasTemplateDecl *AliasTemplate) { return {Template, AliasRhsTemplateArgs}; } +// Build the type for a deduction guide generated from an inherited constructor +// [over.match.class.deduct]p1.10: +// ... the

[clang] [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (PR #102131)

2024-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes We established an instantiation scope in order for constraint equivalence checking to properly map the uninstantiated parameters. That mechanism mapped even packs to themselves. Consequently, parameter pack

[clang] [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (PR #102131)

2024-08-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/102131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Revert "[clang-format][NFC] Delete TT_LambdaArrow (#70… (PR #105923)

2024-08-23 Thread Owen Pan via cfe-commits
https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/105923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Revert "[clang-format][NFC] Delete TT_LambdaArrow (#70… (PR #105923)

2024-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes …519)" This reverts commit e00d32afb9d33a1eca48e2b041c9688436706c5b and adds a test for lambda arrow SplitPenalty. Fixes #105480. --- Full diff: https://github.com/llvm/llvm-project/pull/105923.diff 5

[clang] [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (PR #102131)

2024-08-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/102131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Revert "[clang-format][NFC] Delete TT_LambdaArrow (#70… (PR #105923)

2024-08-23 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/105923 …519)" This reverts commit e00d32afb9d33a1eca48e2b041c9688436706c5b and adds a test for lambda arrow SplitPenalty. Fixes #105480. >From dbf35d6d7e1b0ba5c80453105757baf5357169d4 Mon Sep 17 00:00:00 2001 From: O

[clang] [clang-format] Correctly compute SplitPenalty of TrailingReturnArrow (PR #105613)

2024-08-23 Thread Owen Pan via cfe-commits
owenca wrote: After reviewing commit e00d32afb9d33a1eca48e2b041c9688436706c5b, I've come to the conclusion that it would be better to revert it and keep lambda arrows differentiated from function arrows. https://github.com/llvm/llvm-project/pull/105613 _

[clang] [Clang][Concepts] Fix the constraint equivalence checking involving parameter packs (PR #102131)

2024-08-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/102131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Concepts] Fix the constraint equivalence checking for TemplateTypeParmTypes (PR #102131)

2024-08-23 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/102131 >From aa99ac433c9d383bfca732c19e5082a555f64c2d Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 6 Aug 2024 20:08:43 +0800 Subject: [PATCH] [Clang][Concepts] Fix the constraint equivalence checking for Tem

[clang] [clang-format] Fix a misannotation of redundant r_paren as CastRParen (PR #105921)

2024-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #105880. --- Full diff: https://github.com/llvm/llvm-project/pull/105921.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+2) - (modified) clang/unittests/Format/TokenAnnot

[clang] [clang-format] Fix a misannotation of redundant r_paren as CastRParen (PR #105921)

2024-08-23 Thread Owen Pan via cfe-commits
https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/105921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a misannotation of redundant r_paren as CastRParen (PR #105921)

2024-08-23 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/105921 Fixes #105880. >From c3db574bd29bc71e49aa28dc8d1349726f547089 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 23 Aug 2024 20:28:50 -0700 Subject: [PATCH] [clang-format] Fix a misannotation of redundant r_pare

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -1216,10 +1308,225 @@ void DeclareImplicitDeductionGuidesForTypeAlias( ->getDeductionCandidateKind() == DeductionCandidate::Aggregate) continue; -BuildDeductionGuideForTypeAlias(SemaRef, AliasTemplate, F, Loc); +BuildDeductionGuideForTypeAlias(Sema

[clang] [clang-format] Allow ternary in all templates (PR #96801)

2024-08-23 Thread Owen Pan via cfe-commits
owenca wrote: Bisected to 834ac2e205dd8e492d6084a7952e68e19a1f54db. @rymiel https://github.com/llvm/llvm-project/pull/96801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -1216,10 +1308,225 @@ void DeclareImplicitDeductionGuidesForTypeAlias( ->getDeductionCandidateKind() == DeductionCandidate::Aggregate) continue; -BuildDeductionGuideForTypeAlias(SemaRef, AliasTemplate, F, Loc); +BuildDeductionGuideForTypeAlias(Sema

[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

2024-08-23 Thread via cfe-commits
@@ -1216,10 +1308,225 @@ void DeclareImplicitDeductionGuidesForTypeAlias( ->getDeductionCandidateKind() == DeductionCandidate::Aggregate) continue; -BuildDeductionGuideForTypeAlias(SemaRef, AliasTemplate, F, Loc); +BuildDeductionGuideForTypeAlias(Sema

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -5399,11 +5434,85 @@ static QualType GetImplicitObjectParameterType(ASTContext &Context, return Context.getLValueReferenceType(RawType); } +static TemplateDeductionResult FinishTemplateArgumentDeduction( +Sema &S, FunctionTemplateDecl *FTD, int ArgIdx, QualType P, Qu

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -0,0 +1,32 @@ +// RUN: %clang_cc1 -std=c++23 -verify %s + +namespace t1 { +template struct enable_if { typedef void type; }; +template class Foo {}; +template constexpr bool check() { return true; } +template struct Bar {}; + +template void func(Bar()>::type>) {} +// expecte

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Younan Zhang via cfe-commits
@@ -5399,11 +5434,85 @@ static QualType GetImplicitObjectParameterType(ASTContext &Context, return Context.getLValueReferenceType(RawType); } +static TemplateDeductionResult FinishTemplateArgumentDeduction( +Sema &S, FunctionTemplateDecl *FTD, int ArgIdx, QualType P, Qu

[clang] [Headers][X86] Add a couple of tests for MMX/SSE intrinsics (PR #105852)

2024-08-23 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,387 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only \ phoebewang wrote: Move it to clang/test/CodeGen/X86? https://github.com/llvm/llvm-project/pull/105852 ___ cfe-commits mailing list cf

[clang] [Headers][X86] Add a couple of tests for MMX/SSE intrinsics (PR #105852)

2024-08-23 Thread Phoebe Wang via cfe-commits
@@ -0,0 +1,105 @@ +// RUN: %clang_cc1 -triple i386-unknown-unknown -target-feature +mmx \ +// RUN: -target-feature +sse2 -O0 -emit-llvm %s -o - | FileCheck %s + +// Test that mmx/sse2 shift intrinsics map to the expected builtins. + +// Don't include mm_malloc.h, it's system spec

[clang] [Clang] Support initializing array-typed structured bindings with direct-list-initialization (PR #102581)

2024-08-23 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis updated https://github.com/llvm/llvm-project/pull/102581 >From 9d5d8d99db6f7fa0b6973fe55582de9d34740b19 Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Fri, 9 Aug 2024 15:45:40 +0800 Subject: [PATCH 1/3] Support non-reference structured bindings with braced array as in

[clang] [clang] Allow `pragma float_control(precise, *)` to... (PR #105912)

2024-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang-modules Author: Egor Chesakov (echesakov) Changes ...control `FastMathFlags` during code-generation of `ConditionalOperator`. This involves storing `FPOptionsOverride` in trailing storage of `ConditionalOperator

[clang] [clang] Allow `pragma float_control(precise, *)` to... (PR #105912)

2024-08-23 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Allow `pragma float_control(precise, *)` to... (PR #105912)

2024-08-23 Thread Egor Chesakov via cfe-commits
https://github.com/echesakov created https://github.com/llvm/llvm-project/pull/105912 ...control `FastMathFlags` during code-generation of `ConditionalOperator`. This involves storing `FPOptionsOverride` in trailing storage of `ConditionalOperator` and storing `CurFPOptionsOverride` when creat

[clang] [Clang] Support initializing array-typed structured bindings with direct-list-initialization (PR #102581)

2024-08-23 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis updated https://github.com/llvm/llvm-project/pull/102581 >From 9d5d8d99db6f7fa0b6973fe55582de9d34740b19 Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Fri, 9 Aug 2024 15:45:40 +0800 Subject: [PATCH 1/2] Support non-reference structured bindings with braced array as in

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -1307,6 +1304,62 @@ DeduceTemplateArguments(Sema &S, TemplateParameterList *TemplateParams, return TemplateDeductionResult::Success; } +/// Deduce the template arguments by comparing the list of parameter +/// types to the list of argument types, as in the parameter-type

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -859,8 +861,10 @@ class PackDeductionScope { // by this pack expansion, then clear out the deduction. DeducedFromEarlierParameter = !Deduced[Index].isNull(); DeducedPack Pack(Index); -Pack.Saved = Deduced[Index]; -Deduced[Index] = TemplateArgument(); +

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-23 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. I've updated the patch and can land later https://github.com/llvm/llvm-project/pull/105709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-23 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/105709 >From c55507b3d5552d573068140736e8f904640924e9 Mon Sep 17 00:00:00 2001 From: Justin Stitt Date: Wed, 21 Aug 2024 19:29:03 -0700 Subject: [PATCH 1/2] rename some patterns, rewrite docs >From Vitaly's review

[clang] [clang-format] Treat new expressions as simple functions (PR #105168)

2024-08-23 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/105168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e439fdf - [clang-format] Treat new expressions as simple functions (#105168)

2024-08-23 Thread via cfe-commits
Author: kadir çetinkaya Date: 2024-08-24T03:04:30+02:00 New Revision: e439fdf4ea0dbc6f001428f4d4956700bf26bb97 URL: https://github.com/llvm/llvm-project/commit/e439fdf4ea0dbc6f001428f4d4956700bf26bb97 DIFF: https://github.com/llvm/llvm-project/commit/e439fdf4ea0dbc6f001428f4d4956700bf26bb97.dif

[clang-tools-extra] [include-cleaner] Turn new/delete usages to ambiguous references (PR #105844)

2024-08-23 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/105844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 74b538d - [include-cleaner] Turn new/delete usages to ambiguous references (#105844)

2024-08-23 Thread via cfe-commits
Author: kadir çetinkaya Date: 2024-08-24T02:53:59+02:00 New Revision: 74b538d7e6428921b0bc8f1f5d5dc287c430fa29 URL: https://github.com/llvm/llvm-project/commit/74b538d7e6428921b0bc8f1f5d5dc287c430fa29 DIFF: https://github.com/llvm/llvm-project/commit/74b538d7e6428921b0bc8f1f5d5dc287c430fa29.dif

[clang] [Clang] Support initializing array-typed structured bindings with direct-list-initialization (PR #102581)

2024-08-23 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis updated https://github.com/llvm/llvm-project/pull/102581 >From 9d5d8d99db6f7fa0b6973fe55582de9d34740b19 Mon Sep 17 00:00:00 2001 From: Yanzuo Liu Date: Fri, 9 Aug 2024 15:45:40 +0800 Subject: [PATCH 1/2] Support non-reference structured bindings with braced array as in

[clang] [Clang] Support initializing array-typed structured bindings with direct-list-initialization (PR #102581)

2024-08-23 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/102581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-23 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/105709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -5421,34 +5635,139 @@ static bool isAtLeastAsSpecializedAs(Sema &S, SourceLocation Loc, // the partial ordering is done: TemplateDeductionInfo Info(Loc); switch (TPOC) { - case TPOC_Call: -if (DeduceTemplateArguments(S, TemplateParams, Args2.data(), Args2.size(

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-23 Thread Vitaly Buka via cfe-commits
@@ -4806,6 +4806,34 @@ getOverflowPatternBinOp(const BinaryOperator *E) { return {}; } +/// Compute and set the OverflowPatternExclusion bit based on whether the vitalybuka wrote: Maybe this way? ``` static void computeOverflowPatternExclusion(const ASTCont

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -5421,34 +5635,139 @@ static bool isAtLeastAsSpecializedAs(Sema &S, SourceLocation Loc, // the partial ordering is done: TemplateDeductionInfo Info(Loc); switch (TPOC) { - case TPOC_Call: -if (DeduceTemplateArguments(S, TemplateParams, Args2.data(), Args2.size(

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -5395,11 +5520,100 @@ static QualType GetImplicitObjectParameterType(ASTContext &Context, return Context.getLValueReferenceType(RawType); } +static TemplateDeductionResult CheckDeductionConsistency( +Sema &S, FunctionTemplateDecl *FTD, int ArgIdx, QualType P, QualTyp

[clang] [compiler-rt] [clang][compiler-rt][test] Removed dirname command substitutions from tests (PR #105754)

2024-08-23 Thread Connie Zhu via cfe-commits
https://github.com/connieyzhu updated https://github.com/llvm/llvm-project/pull/105754 >From 52addf5d3e0e4752d9a1e6f5145dc37e9132bbe5 Mon Sep 17 00:00:00 2001 From: Connie Zhu Date: Thu, 22 Aug 2024 23:32:40 + Subject: [PATCH 1/3] [clang][compiler-rt][test] Removed dirname command substitu

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-23 Thread Vitaly Buka via cfe-commits
@@ -314,26 +314,55 @@ Currently, this option supports three overflow-dependent code idioms: unsigned long foo = -1UL; // No longer causes a negation overflow warning unsigned long bar = -2UL; // and so on... -``post-decr-while`` +``unsigned-post-decr-while`` .. cod

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -1343,6 +1343,9 @@ namespace { DeclarationName Entity; // Whether to evaluate the C++20 constraints or simply substitute into them. bool EvaluateConstraints = true; +// Whether Substitution was Incomplete, that is, we tried to substitute in +// any templ

[clang] [Clang] Support initializing array-typed structured bindings with direct-list-initialization (PR #102581)

2024-08-23 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/102581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -5554,38 +5869,50 @@ FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( // "that is a member function with no expicit object argument". // Otherwise the ordering rules for methods with expicit objet arguments // against anything else make no sense. -Shou

[clang] [Clang] Support initializing array-typed structured bindings with direct-list-initialization (PR #102581)

2024-08-23 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/102581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusion - rename some patterns, enhance docs (PR #105709)

2024-08-23 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > Here's a screenshot of the rendered table so you don't have to build the html > docs yourself to inspect the layout: With this table, pattern affect only one sanitizer check, so splitting checks, as I suggested is possible. However I chatted with other folks, seems they ar

[clang] [HLSL] Apply NoRecurse attrib to all HLSL functions (PR #105907)

2024-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Greg Roth (pow2clk) Changes Previously, functions named "main" got the NoRecurse attribute consistent with the behavior of C++, which HLSL largely follows. However, standard recursion is not allowed in HLSL, so all functions should really

[clang] [HLSL] Apply NoRecurse attrib to all HLSL functions (PR #105907)

2024-08-23 Thread Greg Roth via cfe-commits
https://github.com/pow2clk created https://github.com/llvm/llvm-project/pull/105907 Previously, functions named "main" got the NoRecurse attribute consistent with the behavior of C++, which HLSL largely follows. However, standard recursion is not allowed in HLSL, so all functions should really

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-08-23 Thread Matheus Izvekov via cfe-commits
@@ -5346,7 +5346,6 @@ static EvalStmtResult EvaluateStmt(StmtResult &Result, EvalInfo &Info, const Expr *RetExpr = cast(S)->getRetValue(); FullExpressionRAII Scope(Info); if (RetExpr && RetExpr->isValueDependent()) { - EvaluateDependentExpr(RetExpr, Info); ---

[clang] [clang][test] Rewrote test to work with lit internal shell syntax (PR #105902)

2024-08-23 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,22 @@ +import argparse ilovepi wrote: @pogo59 You mentioned in the [RFC](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179/29) that when there isn't another good option that a python script may be an OK substitute in

[clang] [clang][ASTImporter] New fix for default template parameter values. (PR #101836)

2024-08-23 Thread Matheus Izvekov via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: @@ -5968,11 +5962,21 @@ ASTNodeImporter::VisitTemplateTypeParmDecl(TemplateTypeParmDecl *D) { } if (D->hasDefaultArgument()) { +// Default argument can be "inherited" when it has a reference to the +// previous d

[clang] [clang][test] Rewrote test to work with lit internal shell syntax (PR #105902)

2024-08-23 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,22 @@ +import argparse +import os + +def get_file_size(file_path): +try: +return os.path.getsize(file_path) +except: +print(f"Unable to get file size of {file_path}") +return None ilovepi wrote: Is the `try/except` bette

[clang] [clang][test] Rewrote test to work with lit internal shell syntax (PR #105902)

2024-08-23 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,22 @@ +import argparse ilovepi wrote: does this require a license/copyright header? I see a `#!/usr/bin/env python` in https://github.com/llvm/llvm-project/blob/cdd11d694a406a98a16d6265168ee2fbe1b6a87c/llvm/utils/lit/tests/Inputs/shtest-env/print_e

[clang] [clang][test] Rewrote test to work with lit internal shell syntax (PR #105902)

2024-08-23 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,22 @@ +import argparse +import os + +def get_file_size(file_path): +try: +return os.path.getsize(file_path) +except: +print(f"Unable to get file size of {file_path}") +return None + +def main(): ilovepi wrote: Please add

[clang] [compiler-rt] [clang][compiler-rt][test] Removed dirname command substitutions from tests (PR #105754)

2024-08-23 Thread Paul Kirth via cfe-commits
@@ -3,63 +3,64 @@ // REQUIRES: amdgpu-registered-target // UNSUPPORTED: system-windows -// RUN: %clang -cc1 %s -triple x86_64-unknown-linux-gnu -emit-obj -o %t.elf.o +// RUN: rm -rf %t && mkdir -p %t +// RUN: %clang -cc1 %s -triple x86_64-unknown-linux-gnu -emit-obj -o %t/elf.

[clang] [compiler-rt] [clang][compiler-rt][test] Removed dirname command substitutions from tests (PR #105754)

2024-08-23 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/105754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [clang][compiler-rt][test] Removed dirname command substitutions from tests (PR #105754)

2024-08-23 Thread Florian Mayer via cfe-commits
https://github.com/fmayer approved this pull request. LGTM for the hwasan test. https://github.com/llvm/llvm-project/pull/105754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [clang][compiler-rt][test] Removed dirname command substitutions from tests (PR #105754)

2024-08-23 Thread Connie Zhu via cfe-commits
@@ -1,8 +1,9 @@ -// RUN: %clang_hwasan -Wl,--build-id -g %s -o %t -// RUN: echo '[{"prefix": "'"$(realpath $(dirname %s))"'/", "link": "http://test.invalid/{file}:{line}"}]' > %t.linkify -// RUN: %env_hwasan_opts=symbolize=0 not %run %t 2>&1 | hwasan_symbolize --html --symbols $

[clang] [compiler-rt] [clang][compiler-rt][test] Removed dirname command substitutions from tests (PR #105754)

2024-08-23 Thread Connie Zhu via cfe-commits
https://github.com/connieyzhu updated https://github.com/llvm/llvm-project/pull/105754 >From cfd90f666e9b6f65e277bc753de973a748a7b275 Mon Sep 17 00:00:00 2001 From: Connie Zhu Date: Thu, 22 Aug 2024 23:32:40 + Subject: [PATCH 1/2] [clang][compiler-rt][test] Removed dirname command substitu

[clang] [clang][test] Rewrote test to work with lit internal shell syntax (PR #105902)

2024-08-23 Thread Connie Zhu via cfe-commits
https://github.com/connieyzhu updated https://github.com/llvm/llvm-project/pull/105902 >From b7cf36a247e480ddefc1708cb68078b440011d63 Mon Sep 17 00:00:00 2001 From: Connie Zhu Date: Fri, 23 Aug 2024 17:23:22 + Subject: [PATCH] [clang][test] Rewrote test to work with lit internal shell synt

[clang] [clang][test] Rewrote test to work with lit internal shell syntax (PR #105902)

2024-08-23 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r f3a47b9e25e7aca0dc2cd2dec30cedd9aeffaecf...ae8f575067ea7035911053b6994e856538c23c3f clang

[clang] [clang][test] Rewrote test to work with lit internal shell syntax (PR #105902)

2024-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Connie Zhu (connieyzhu) Changes This patch rewrites a test that uses command substitution `$()` and the `stat` command, which are not supported by lit's internal shell. Instead of using this syntax to perform the file size comparison done

[clang] [clang][test] Rewrote test to work with lit internal shell syntax (PR #105902)

2024-08-23 Thread Connie Zhu via cfe-commits
https://github.com/connieyzhu created https://github.com/llvm/llvm-project/pull/105902 This patch rewrites a test that uses command substitution `$()` and the `stat` command, which are not supported by lit's internal shell. Instead of using this syntax to perform the file size comparison done

[clang] [clang][ExtractAPI] Fix quirks in interaction with submodules (PR #105868)

2024-08-23 Thread via cfe-commits
https://github.com/QuietMisdreavus approved this pull request. https://github.com/llvm/llvm-project/pull/105868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >