[clang] Revert "Reland: [clang][test] add testing for the AST matcher reference" (PR #116477)

2024-11-15 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Sure! It timed out on the Windows arm builder again, I'm already in contact with the bot owner. https://github.com/llvm/llvm-project/pull/116477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] Revert "Reland: [clang][test] add testing for the AST matcher reference" (PR #116477)

2024-11-15 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > Reverts llvm/llvm-project#112168 > LLVM Buildbot has detected a new failure on builder > `clang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-04` while > building `clang` at step 5 "ninja check 1". > > Full details are available at: > https://lab.llvm.org/buildb

[clang] [Clang][Parser] Make 'T...[N]' within a function parameter a valid pack expansion prior to C++2c (PR #116332)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes This patch makes cases `void f(T... [N])` valid and adds a warning where the parameter is not of a pack indexing but of a pack expansion type, as per https://eel.is/c++draft/diff#cpp23.dcl.dcl-2. Fixes http

[clang] Revert "Reland: [clang][test] add testing for the AST matcher reference" (PR #116477)

2024-11-15 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Can you please describe the reason the patch was reverted? It's better to put this information in the commit message. https://github.com/llvm/llvm-project/pull/116477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [Clang][Driver] report unsupported option error regardless of argument order (PR #116476)

2024-11-15 Thread Reno Dakota via cfe-commits
https://github.com/paparodeo created https://github.com/llvm/llvm-project/pull/116476 Fixes: https://github.com/llvm/llvm-project/issues/116278 This change updates clang to report unsupported option errors regardless of the command line argument order. When clang with a source file and withou

[clang] Disable LIBCXX_INCLUDE_BENCHMARKS in Fuchsia cmake (PR #116446)

2024-11-15 Thread Petr Hosek via cfe-commits
@@ -31,6 +31,7 @@ set(LLVM_STATIC_LINK_CXX_STDLIB ON CACHE BOOL "") set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "") set(LLDB_ENABLE_CURSES OFF CACHE BOOL "") set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "") +set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOOL "") pet

[clang] Revert "Reland: [clang][test] add testing for the AST matcher reference" (PR #116477)

2024-11-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `clang` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/1131 Here is the relevant piece

[clang] Revert "Reland: [clang][test] add testing for the AST matcher reference" (PR #116477)

2024-11-15 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti closed https://github.com/llvm/llvm-project/pull/116477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,567 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-11-15 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/116331 >From 3c792216f88e87b69b3ea7415c2fd74b7f5d7469 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 25 Oct 2024 17:48:41 + Subject: [PATCH 1/5] adding comments --- clang/include/clang/Basic/Attr.td

[clang] Remove device override for operator new when the C++ standard >= 26 (PR #114056)

2024-11-15 Thread Artem Belevich via cfe-commits
Artem-B wrote: The patch request has been already approved. Nothing seems to have changed since then to the patch? Are you asking for help landing the patch? https://github.com/llvm/llvm-project/pull/114056 ___ cfe-commits mailing list cfe-commits@lis

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Fix false positive in cppcoreguidelines-avoid-const-or-ref-data-members when detecting templated classes with inheritance (PR #115180)

2024-11-15 Thread Congcong Cai via cfe-commits
@@ -13,79 +13,92 @@ using namespace clang::ast_matchers; namespace clang::tidy::cppcoreguidelines { -namespace { -AST_MATCHER(FieldDecl, isMemberOfLambda) { - return Node.getParent()->isLambda(); +static bool hasCopyConstructor(CXXRecordDecl const &Node) { + if (Node.needs

[clang] [clang][Driver] Use shared_ptr in the Compilation class (PR #116406)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Victor Campos (vhscampos) Changes This patch replaces uses of raw pointers by shared_ptrs in the Driver's Compilation class. The manual memory management which was done before this patch could be error prone. Plus, code is now sim

[clang] Revert "Reland: [clang][test] add testing for the AST matcher reference" (PR #116477)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Julian Schmidt (5chmidti) Changes Reverts llvm/llvm-project#112168 --- Patch is 905.25 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/116477.diff 8 Files Affected: - (modified) clang/docs/Li

[clang] Revert "[analyzer][Solver] Early return if sym is concrete on assuming" (PR #116362)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes Reverts llvm/llvm-project#115579 This introduced a breakage: https://lab.llvm.org/buildbot/#/builders/46/builds/7928 --- Full diff: https://github.com/llvm/llvm-project/pull/116362.diff 6 Files Affected

[clang] Revert "[analyzer][Solver] Early return if sym is concrete on assuming" (PR #116362)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes Reverts llvm/llvm-project#115579 This introduced a breakage: https://lab.llvm.org/buildbot/#/builders/46/builds/7928 --- Full diff: https://github.com/llvm/llvm-project/pull/116362.diff

[clang] [ASTWriter] Do not allocate source location space for module maps used only for textual headers (PR #116374)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ilya Biryukov (ilya-biryukov) Changes This is a follow up to #112015 and it reduces the unnecessary duplication of source locations further. We do not need to allocate source location space in the serialized PCMs for module maps used onl

[clang] [llvm] Revert "[Driver][SYCL] Add initial SYCL offload compilation support" (PR #116381)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Aaron Ballman (AaronBallman) Changes Reverts llvm/llvm-project#107493 Failing bots include: https://lab.llvm.org/buildbot/#/builders/190/builds/9546 https://lab.llvm.org/buildbot/#/builders/46/builds/7938

[clang] [analyzer] [MallocChecker] Less aggressive analysis of functions (PR #116383)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Yan (likeamahoney) Changes It seems to me that the `unix.Malloc` checker is too aggressive when it comes to analyzing function arguments. For example it warns on such code (there is no directly usage of freed memory - b

[clang] [Clang][Driver] report unsupported option error regardless of argument order (PR #116476)

2024-11-15 Thread Reno Dakota via cfe-commits
https://github.com/paparodeo edited https://github.com/llvm/llvm-project/pull/116476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Add 'gpuintrin.h' to the release notes (PR #116410)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/116410.diff 1 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+11) ``diff diff --git a/clang/docs/ReleaseNotes.rst b/clang/doc

[clang] [Clang][Driver] report unsupported option error regardless of argument order (PR #116476)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Reno Dakota (paparodeo) Changes Fixes: https://github.com/llvm/llvm-project/issues/116278 This change updates clang to report unsupported option errors regardless of the command line argument order. When clang with a source file a

[clang] [Clang][Driver] report unsupported option error regardless of argument order (PR #116476)

2024-11-15 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-15 Thread Congcong Cai via cfe-commits
@@ -102,6 +102,210 @@ void BranchCloneCheck::registerMatchers(MatchFinder *Finder) { this); Finder->addMatcher(switchStmt().bind("switch"), this); Finder->addMatcher(conditionalOperator().bind("condOp"), this); + Finder->addMatcher(ifStmt(hasDescendant(ifStmt())).b

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vinay Deshmukh (vinay-deshmukh) Changes Resolves #100762 Gist of the change: 1. All the symbol analysis, constraint manager and expression parsing logic was already present, but the previous code didn't "visit" the expressions within `a

[clang] [-Wunsafe-buffer-usage] Fix bug in unsafe casts to incomplete types (PR #116433)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ziqing Luo (ziqingluo-90) Changes Fixed the crash coming from attempting to get size of incomplete types. Casting `span.data()` to a pointer-to-incomplete-type should be immediately considered unsafe. Solving issue #116286. --- Full di

[clang] [Fuchsia] Include runtimes for armv8.1m.main-none-eabi (PR #116420)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) Changes These are needed by some of our users. --- Full diff: https://github.com/llvm/llvm-project/pull/116420.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+7-1) ``diff d

[clang] [flang] [clang][driver] When -fveclib=ArmPL flag is in use, always link against libamath (PR #116432)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Paul Osmialowski (pawosm-arm) Changes Using `-fveclib=ArmPL` without `-lamath` likely effects in the link-time errors. --- Full diff: https://github.com/llvm/llvm-project/pull/116432.diff 3 Files Affecte

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-spir-v @llvm/pr-subscribers-clang-codegen Author: None (joaosaffran) Changes - adding Flatten and Branch to if stmt. - adding dxil control flow hint metadata generation - modifing spirv OpSelectMerge to account for the specific attributes. Close

[clang] [Lex] Remove unused includes (NFC) (PR #116460)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Identified with misc-include-cleaner. --- Full diff: https://github.com/llvm/llvm-project/pull/116460.diff 17 Files Affected: - (modified) clang/lib/Lex/HeaderMap.cpp (-4) - (modified) clang/lib/Le

[libunwind] [libunwind][Haiku] Improve support (PR #115462)

2024-11-15 Thread via cfe-commits
@@ -2917,7 +2980,8 @@ template int UnwindCursor::step(bool stage2) { // Use unwinding info to modify register set as if function returned. int result; -#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) +#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) ||

[clang] [Sema] Remove unused includes (NFC) (PR #116461)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines Author: Kazu Hirata (kazutakahirata) Changes Identified with misc-include-cleaner. --- Patch is 27.93 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/116461.diff 40 Files Affected: - (modified)

[clang] [CodeGen] Remove unused includes (NFC) (PR #116459)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Identified with misc-include-cleaner. --- Full diff: https://github.com/llvm/llvm-project/pull/116459.diff 32 Files Affected: - (modified) clang/lib/CodeGen/BackendUti

[clang] [Lex] Remove unused includes (NFC) (PR #116460)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Kazu Hirata (kazutakahirata) Changes Identified with misc-include-cleaner. --- Full diff: https://github.com/llvm/llvm-project/pull/116460.diff 17 Files Affected: - (modified) clang/lib/Lex/HeaderMap.cpp (-4) - (modified) clan

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Author: Vinay Deshmukh (vinay-deshmukh) Changes Resolves #100762 Gist of the change: 1. All the symbol analysis, constraint manager and expression parsing logic was already present, but the previous code didn't "visit" the expressions w

[clang] [llvm] [RISCV] Add TT-Ascalon-d8 processor (PR #115100)

2024-11-15 Thread Petr Penzin via cfe-commits
ppenzin wrote: If we are all good, can someone merge this? I don't have write access. https://github.com/llvm/llvm-project/pull/115100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland: [clang][test] add testing for the AST matcher reference (PR #112168)

2024-11-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-arm64-windows-msvc` running on `linaro-armv8-windows-msvc-04` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/161/builds/3227 Here is the relev

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang] Implement lifetime analysis for lifetime_capture_by(X) (PR #115921)

2024-11-15 Thread Utkarsh Saxena via cfe-commits
@@ -0,0 +1,220 @@ +// RUN: %clang_cc1 --std=c++20 -fsyntax-only -Wdangling -Wdangling-field -Wreturn-stack-address -verify %s + +#include "Inputs/lifetime-analysis.h" + +struct X { + const int *x; + void captureInt(const int& x [[clang::lifetime_capture_by(this)]]) { this->x =

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-15 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt updated https://github.com/llvm/llvm-project/pull/115902 >From 845256b2ed971a4e42f7f871e8b51e711486261a Mon Sep 17 00:00:00 2001 From: Ashley Coleman Date: Mon, 11 Nov 2024 16:34:23 -0700 Subject: [PATCH 01/13] [HLSL] Implement WaveActiveAnyTrue intrinsic --- clang/

[clang] [Sema] Remove unused includes (NFC) (PR #116461)

2024-11-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/116461 Identified with misc-include-cleaner. >From e9b2f89dd4dda089fd93e843e677cc93a638485f Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 15 Nov 2024 16:49:33 -0800 Subject: [PATCH] [Sema] Remove unuse

[clang-tools-extra] [clang-tidy] Fix false positive in cppcoreguidelines-avoid-const-or-ref-data-members when detecting templated classes with inheritance (PR #115180)

2024-11-15 Thread Julian Schmidt via cfe-commits
@@ -13,79 +13,92 @@ using namespace clang::ast_matchers; namespace clang::tidy::cppcoreguidelines { -namespace { -AST_MATCHER(FieldDecl, isMemberOfLambda) { - return Node.getParent()->isLambda(); +static bool hasCopyConstructor(CXXRecordDecl const &Node) { + if (Node.needs

[clang] Enable AST mutation in the constant evaluator (PR #115168)

2024-11-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/115168 >From 5ca48e03412b1b8e9253f13356b9cc957f6fd9e5 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Wed, 6 Nov 2024 17:58:43 +0300 Subject: [PATCH 01/11] Add EvalASTMutator interface with `InstantiateFunctio

[clang] [clang][FMV] Fix crash with cpu_specific attribute. (PR #115762)

2024-11-15 Thread via cfe-commits
elizabethandrews wrote: > > > Wouldn't mind it if @Fznamznon took a look though, IIRC, she did a bunch > > > of work with cpu_specific/cpu_dispatch. > > > > > > I don't think I did. I'm not familiar with this area to provide any opinion. > > Ah, hrmph... maybe it was @elizabethandrews who did

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-11-15 Thread Alex Voicu via cfe-commits
@@ -5390,11 +5390,19 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, V->getType()->isIntegerTy()) V = Builder.CreateZExt(V, ArgInfo.getCoerceToType()); -// If the argument doesn't match, perform a bitcast to coerce it. This -

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/116462 >From daddb9e13db6ca8373dc7298d17aa36a03014aeb Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Fri, 15 Nov 2024 07:37:17 -0500 Subject: [PATCH] [analy

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh edited https://github.com/llvm/llvm-project/pull/116462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Matt Arsenault via cfe-commits
@@ -111,6 +111,18 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo { return getPointerWidthV(AddrSpace); } + virtual bool isAddressSpaceSupersetOf(LangAS A, LangAS B) const override { +// The flat address space AS(0) is a superset of all

[clang] [flang] [clang][driver] When -fveclib=ArmPL flag is in use, always link against libamath (PR #116432)

2024-11-15 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm edited https://github.com/llvm/llvm-project/pull/116432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/115777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Joseph Huber via cfe-commits
@@ -111,6 +111,18 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo { return getPointerWidthV(AddrSpace); } + virtual bool isAddressSpaceSupersetOf(LangAS A, LangAS B) const override { +// The flat address space AS(0) is a superset of all

[clang] [clang-tools-extra] [Clang] Use TargetInfo when deciding if an address space is compatible (PR #115777)

2024-11-15 Thread Matt Arsenault via cfe-commits
@@ -111,6 +111,18 @@ class LLVM_LIBRARY_VISIBILITY AMDGPUTargetInfo final : public TargetInfo { return getPointerWidthV(AddrSpace); } + virtual bool isAddressSpaceSupersetOf(LangAS A, LangAS B) const override { +// The flat address space AS(0) is a superset of all

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh ready_for_review https://github.com/llvm/llvm-project/pull/116462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add concepts to ast (PR #116407)

2024-11-15 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 closed https://github.com/llvm/llvm-project/pull/116407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/116462 >From d4ba202dc8a37f7b3d8eb91f5410410b8e191b31 Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Fri, 15 Nov 2024 07:37:17 -0500 Subject: [PATCH] [analy

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread Vinay Deshmukh via cfe-commits
vinay-deshmukh wrote: @steakhal Can you take a look at this PR when you have a chance? Thanks! https://github.com/llvm/llvm-project/pull/116462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-15 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh created https://github.com/llvm/llvm-project/pull/116462 Resolves #100762 >From 773601ec7d87ac80b1440b0297f3f8f622c83a9b Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Fri, 15 Nov 2024 07:37:17 -0500 Subj

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-15 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/114715 >From 48389a341ece8546261b84de7af79cbb80829254 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 7 Nov 2024 01:58:21 +0100 Subject: [PATCH] [analyzer] Port alpha.core.IdenticalExpr to Tidy checks and

[clang] [Lex] Remove unused includes (NFC) (PR #116460)

2024-11-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/116460 Identified with misc-include-cleaner. >From ff95c21b5a5dbc4164c26d0d1760be2aa3d4 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 15 Nov 2024 17:34:23 -0800 Subject: [PATCH] [Lex] Remove unused

[clang] [CodeGen] Remove unused includes (NFC) (PR #116459)

2024-11-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/116459 Identified with misc-include-cleaner. >From f2b2c8a5119586cb5680ea097936a4fbc325089c Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 15 Nov 2024 15:58:42 -0800 Subject: [PATCH] [CodeGen] Remove un

[clang] [clang] Fix a crash issue that caused by handling of fields with initializers in nested anonymous unions (PR #113049)

2024-11-15 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Just wanted to ping on this and see how it was going. https://github.com/llvm/llvm-project/pull/113049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,724 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-15 Thread via cfe-commits
vabridgers wrote: I'll follow up after this PR is merged with a subsequent PR to split this LIT. If that's not acceptable please reopen this comment. Thanks. https://github.com/llvm/llvm-project/pull/114715 ___ cfe-c

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-15 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/114715 >From 6bcb40f63c1393f45a0acdbe3631b85e20d4e93c Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 7 Nov 2024 01:58:21 +0100 Subject: [PATCH] [analyzer] Port alpha.core.IdenticalExpr to Tidy checks and

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-15 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/114715 >From 699d4b89b23c5b3c1f55223d6983c19a26cf2741 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Thu, 7 Nov 2024 01:58:21 +0100 Subject: [PATCH] [analyzer] Port alpha.core.IdenticalExpr to Tidy checks and

[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)

2024-11-15 Thread via cfe-commits
vabridgers wrote: Thanks @5chmidti for the constructive comments. I believe those have been addressed. I'll follow up after this PR is approved and merged to split the LIT appropriately. Thanks for understanding this approach, it was the only one I could think of where the reviewers could tran

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-11-15 Thread Peter Klausler via cfe-commits
https://github.com/klausler ready_for_review https://github.com/llvm/llvm-project/pull/113504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add TT-Ascalon-d8 processor (PR #115100)

2024-11-15 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/115100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 64c4550 - [docs][asan][lsan] Drop list of supported architechures (#116302)

2024-11-15 Thread via cfe-commits
Author: Vitaly Buka Date: 2024-11-15T15:15:50-08:00 New Revision: 64c455077abe583f96fc19398712da9c1187ad61 URL: https://github.com/llvm/llvm-project/commit/64c455077abe583f96fc19398712da9c1187ad61 DIFF: https://github.com/llvm/llvm-project/commit/64c455077abe583f96fc19398712da9c1187ad61.diff L

[clang-tools-extra] [clang-tidy] Fix false positive in cppcoreguidelines-avoid-const-or-ref-data-members when detecting templated classes with inheritance (PR #115180)

2024-11-15 Thread Julian Schmidt via cfe-commits
@@ -195,6 +195,10 @@ Changes in existing checks fix false positive that floating point variable is only used in increment expression. +- Improved :doc:`cppcoreguidelines-avoid-const-or-ref-data-members + ` check to + avoid false positive when detecting templated class w

[clang-tools-extra] [clang-tidy] Fix false positive in cppcoreguidelines-avoid-const-or-ref-data-members when detecting templated classes with inheritance (PR #115180)

2024-11-15 Thread Julian Schmidt via cfe-commits
@@ -13,79 +13,92 @@ using namespace clang::ast_matchers; namespace clang::tidy::cppcoreguidelines { -namespace { -AST_MATCHER(FieldDecl, isMemberOfLambda) { - return Node.getParent()->isLambda(); +static bool hasCopyConstructor(CXXRecordDecl const &Node) { + if (Node.needs

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-15 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt updated https://github.com/llvm/llvm-project/pull/115902 >From 845256b2ed971a4e42f7f871e8b51e711486261a Mon Sep 17 00:00:00 2001 From: Ashley Coleman Date: Mon, 11 Nov 2024 16:34:23 -0700 Subject: [PATCH 01/12] [HLSL] Implement WaveActiveAnyTrue intrinsic --- clang/

[clang] [Clang][Parser] Make 'T...[N]' within a function parameter a valid pack expansion prior to C++2c (PR #116332)

2024-11-15 Thread Eli Friedman via cfe-commits
@@ -58,8 +58,9 @@ void b(T[] ...); template void c(T ... []); // expected-error {{expected expression}} \ efriedma-quic wrote: To be clear, it's not a "pack-index-specifier" even in C++26: it doesn't match the grammar because there's no constant-expression,

[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

2024-11-15 Thread Ashley Coleman via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -finclude-default-header -fnative-half-type -triple \ +// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o - | \ +// RUN: FileCheck %s --check-prefixes=CHECK,CHECK-DXIL +// RUN: %clang_cc1 -finclude-default-header

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-11-15 Thread Peter Klausler via cfe-commits
klausler wrote: I've exercised all of the operations and intrinsic procedures with end-to-end testing; those tests will end up in llvm-test-suite later. So I'm turning off "draft" status now for this PR, and request your reviews. Thank you in advance. https://github.com/llvm/llvm-project/pul

[clang-tools-extra] Extend bugprone-use-after-move check to handle std::optional::reset() and std::any::reset() (PR #114255)

2024-11-15 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Thank you https://github.com/llvm/llvm-project/pull/114255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add UNSIGNED (PR #113504)

2024-11-15 Thread Peter Klausler via cfe-commits
https://github.com/klausler edited https://github.com/llvm/llvm-project/pull/113504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Disable LIBCXX_INCLUDE_BENCHMARKS in Fuchsia cmake (PR #116446)

2024-11-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Caslyn Tonelli (Caslyn) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/116446.diff 2 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+1) - (modified) clang/cmake/caches/Fuchsia.cmake (+1) ``

[clang] [docs][asan][lsan] Drop list of supported architechures (PR #116302)

2024-11-15 Thread Florian Mayer via cfe-commits
https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/116302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add TT-Ascalon-d8 processor (PR #115100)

2024-11-15 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave approved this pull request. LGTM. I don't have any strong opinion on the CPU name https://github.com/llvm/llvm-project/pull/115100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [docs][asan][lsan] Drop list of supported architechures (PR #116302)

2024-11-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/116302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix false positive in cppcoreguidelines-avoid-const-or-ref-data-members when detecting templated classes with inheritance (PR #115180)

2024-11-15 Thread Julian Schmidt via cfe-commits
@@ -13,79 +13,92 @@ using namespace clang::ast_matchers; namespace clang::tidy::cppcoreguidelines { -namespace { -AST_MATCHER(FieldDecl, isMemberOfLambda) { - return Node.getParent()->isLambda(); +static bool hasCopyConstructor(CXXRecordDecl const &Node) {

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-11-15 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/114062 >From d2d2d3d5db3f639aab178f9ca9a20db2842d2b65 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 29 Oct 2024 14:20:44 + Subject: [PATCH 01/10] `sret` args should always point to the `alloca` AS, so we ca

[clang] [llvm] [RISCV] Add TT-Ascalon-d8 processor (PR #115100)

2024-11-15 Thread Petr Penzin via cfe-commits
ppenzin wrote: Are there still open questions for the sync call? https://github.com/llvm/llvm-project/pull/115100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] `sret` args should always point to the `alloca` AS, so use that (PR #114062)

2024-11-15 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/114062 >From d2d2d3d5db3f639aab178f9ca9a20db2842d2b65 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 29 Oct 2024 14:20:44 + Subject: [PATCH 1/9] `sret` args should always point to the `alloca` AS, so we can

[clang] Disable LIBCXX_INCLUDE_BENCHMARKS in Fuchsia cmake (PR #116446)

2024-11-15 Thread Caslyn Tonelli via cfe-commits
https://github.com/Caslyn created https://github.com/llvm/llvm-project/pull/116446 None >From eacaefef7cb0efe7dec5560803663200cc42302d Mon Sep 17 00:00:00 2001 From: Caslyn Tonelli Date: Fri, 15 Nov 2024 12:24:37 -0800 Subject: [PATCH] Disable LIBCXX_INCLUDE_BENCHMARKS for Fuchsia --- clang/

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Fix minor mistake in error message (PR #116132)

2024-11-15 Thread Julian Schmidt via cfe-commits
@@ -244,7 +244,7 @@ Changes in existing checks - Improved :doc:`modernize-use-starts-ends-with ` check to handle two cases - that can be replaced with ``ends_with`` + that can be replaced with ``ends_with``. Minor change to error message. 5chmidti wrote:

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Fix minor mistake in error message (PR #116132)

2024-11-15 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Please also add a test for the case you're doing this for, i.e., one without `[!=]= 0`, so that these don't regress in the future https://github.com/llvm/llvm-project/pull/116132 ___ cfe-commits maili

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-11-15 Thread via cfe-commits
https://github.com/joaosaffran ready_for_review https://github.com/llvm/llvm-project/pull/116331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Include runtimes for armv8.1m.main-none-eabi (PR #116420)

2024-11-15 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/116420 These are needed by some of our users. >From 028021ded3dee3f55ba26540f5c9cf1a1e8cbb36 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Tue, 12 Nov 2024 19:50:46 + Subject: [PATCH] [Fuchsia] Include runtime

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-11-15 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: This is an LLVM code change, not a clang code change. It's an important principle that we test LLVM at the smallest reasonable granularity. Can you replace the clang test with an IR test? I'm sure we already have existing IR carrying existing sections, we just

[clang] [Clang] Implement CWG2351 `void{}` (PR #78060)

2024-11-15 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Looks like this PR was the cause of this regression: https://github.com/llvm/llvm-project/issues/116440 https://github.com/llvm/llvm-project/pull/78060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea edited https://github.com/llvm/llvm-project/pull/116257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-11-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

2024-11-15 Thread Alexandros Lamprineas via cfe-commits
@@ -48,6 +48,19 @@ std::optional AArch64::ArchInfo::findBySubArch(StringRef SubA return {}; } +unsigned AArch64::getFMVPriority(ArrayRef Features) { + constexpr unsigned MaxFMVPriority = 1000; + unsigned Priority = 0; + unsigned NumFeatures = 0; + for (StringRef Feature

  1   2   3   4   5   >