[clang] [Clang] Diagnose unsatisfied `std::is_assignable`. (PR #144836)

https://github.com/rkirsling created https://github.com/llvm/llvm-project/pull/144836 Part of the work for #141911. Checking `is_assignable` boils down to checking the well-formedness of `declval() = declval()`; this PR recycles logic from EvaluateBinaryTypeTrait in order to produce the relev

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

@@ -417,3 +417,15 @@ void HIPAMDToolChain::checkTargetID( getDriver().Diag(clang::diag::err_drv_bad_target_id) << *PTID.OptionalTargetID; } + +SPIRVAMDToolChain::SPIRVAMDToolChain(const Driver &D, + const llvm::Triple &Triple, +

[clang] [llvm] [X86] Remove CLDEMOTE from Arrowlake and later hybrid processors (PR #144833)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,cpp -- clang/test/Preprocessor/predefined-arch-macros.c l

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

@@ -417,3 +417,15 @@ void HIPAMDToolChain::checkTargetID( getDriver().Diag(clang::diag::err_drv_bad_target_id) << *PTID.OptionalTargetID; } + +SPIRVAMDToolChain::SPIRVAMDToolChain(const Driver &D, + const llvm::Triple &Triple, +

[clang] [llvm] [X86] Remove CLDEMOTE from Arrowlake and later hybrid processors (PR #144833)

https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/144833 >From 8e218d9c4431b021231942e514f175164af35a51 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Thu, 19 Jun 2025 12:14:54 +0800 Subject: [PATCH 1/2] [X86] Remove CLDEMOTE from Arrowlake and later hybrid p

[clang] [llvm] [X86] Remove CLDEMOTE from Arrowlake and later hybrid processors (PR #144833)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Phoebe Wang (phoebewang) Changes Decouple Arrowlake from Sierraforest because the later has CLDEMOTE feature. --- Patch is 20.92 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/144833.diff 3 F

[clang] [llvm] [X86] Remove CLDEMOTE from Arrowlake and later hybrid processors (PR #144833)

https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/144833 Decouple Arrowlake from Sierraforest because the later has CLDEMOTE feature. >From 8e218d9c4431b021231942e514f175164af35a51 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Thu, 19 Jun 2025 12:14:54 +0800

[clang] [HIP] Emit the CUID value in the module with the new driver (PR #144570)

shiltian wrote: No test is needed? https://github.com/llvm/llvm-project/pull/144570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

namazso wrote: Actually, disregard my previous comment. It seems that it's quite a bit more broken than that already and depends on surrounding code. Making it broken in different ways probably won't hurt much. https://github.com/llvm/llvm-project/pull/144745 __

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

namazso wrote: While I haven't checked how exactly this PR interacts with SEH, just here because https://github.com/llvm/llvm-project/issues/54922#issuecomment-2984928111 , I'd like to point out that https://clang.llvm.org/docs/MSVCCompatibility.html has the following snippet for SEH: > Asy

[clang] [lld] Use the Windows SDK arguments over the environment (PR #144805)

https://github.com/Steelskin updated https://github.com/llvm/llvm-project/pull/144805 >From 65576f1cd8a43a0ffbc9b4c9d6636218b3b82097 Mon Sep 17 00:00:00 2001 From: Fabrice de Gans Date: Wed, 18 Jun 2025 15:04:35 -0700 Subject: [PATCH] Use the Windows SDK arguments over the environment If any o

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[clang] HIPSPV: Unbundle SDL (PR #136412)

https://github.com/pvelesko updated https://github.com/llvm/llvm-project/pull/136412 >From fe6a426fc135c7232650b5ebac465ceaa66d7a20 Mon Sep 17 00:00:00 2001 From: Paulius Velesko Date: Sat, 19 Apr 2025 10:02:59 +0300 Subject: [PATCH 1/4] HIPSPV: Unbundle SDL This fixes the issue of rdc linking

[clang] HIPSPV: Unbundle SDL (PR #136412)

https://github.com/pvelesko updated https://github.com/llvm/llvm-project/pull/136412 >From fe6a426fc135c7232650b5ebac465ceaa66d7a20 Mon Sep 17 00:00:00 2001 From: Paulius Velesko Date: Sat, 19 Apr 2025 10:02:59 +0300 Subject: [PATCH 1/4] HIPSPV: Unbundle SDL This fixes the issue of rdc linking

[clang] Fix crash when doing special member lookup on forward-declared classes (Fixes llvm/llvm-project#144642) (PR #144828)

https://github.com/Ameya674 edited https://github.com/llvm/llvm-project/pull/144828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Add option -msve-streaming-vector-bits= . (PR #144611)

@@ -1034,9 +1034,16 @@ class TargetInfo : public TransferrableTargetInfo, /// set of primary and secondary targets. virtual llvm::SmallVector getTargetBuiltins() const = 0; + enum class ArmStreamingKind { +NotStreaming, +StreamingCompatible, +Streaming, + };

[clang] let Neon builtin function accept a const variable (PR #144625)

scout-zeng wrote: > I think something like your patch solves the original testcase from #139033. > (Actually, it crashes in codegen, but that's an easy fix.) And I thought you > wanted specifically that...? > > Your new testcase will never work; the NEON intrinsic is specifically > specified

[clang-tools-extra] [clang-reorder-fields] Prevent rewriting unsupported cases (PR #142149)

https://github.com/alexander-shaposhnikov approved this pull request. LG, thanks! https://github.com/llvm/llvm-project/pull/142149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix crash when doing special member lookup on forward-declared classes (PR #144828)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Ameya Gurjar (Ameya674) Changes The compiler tends to crash when encountering a forward-declared incomplete type in Sema::LookupSpecialMember. Fixed this by adding a check to handle the incomplete types. The patch compiles and clang tri

[clang] Fix crash when doing special member lookup on forward-declared classes (PR #144828)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Fix crash when doing special member lookup on forward-declared classes (PR #144828)

https://github.com/Ameya674 created https://github.com/llvm/llvm-project/pull/144828 The compiler tends to crash when encountering a forward-declared incomplete type in Sema::LookupSpecialMember. Fixed this by adding a check to handle the incomplete types. The patch compiles and clang trigger

[clang] let Neon builtin function accept a const variable (PR #144625)

efriedma-quic wrote: I think something like your patch solves the original testcase from #139033. (Actually, it crashes in codegen, but that's an easy fix.) And I thought you wanted specifically that...? Your new testcase will never work; the NEON intrinsic is specifically specified to only

[clang] [llvm] [InstCombine] remove dead loads, such as memcpy from undef (PR #143958)

https://github.com/vtjnash updated https://github.com/llvm/llvm-project/pull/143958 >From 450eb079e97f1a20ab2547567d81c176fec06cfb Mon Sep 17 00:00:00 2001 From: Jameson Nash Date: Thu, 12 Jun 2025 18:48:00 + Subject: [PATCH 01/12] [instcombine] remove dead loads, such as memcpy from undef

[clang] [HIP] Emit the CUID value in the module with the new driver (PR #144570)

jhuber6 wrote: > > `llvm.compiler.used` global uses AS(0) which makes SPIR-V unhappy, but with > > this global it's AS(4) which makes it happy. Either way, this should be > > fixed. > > llvm.used and llvm.compiler.used should universally use addrspace(0) and > SPIRV should be fixed to not bre

[clang] [llvm] [X86] Remove CLDEMOTE from Alderlake and later hybrid processors (PR #144662)

https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/144662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5875faf - [X86] Remove CLDEMOTE from Alderlake and later hybrid processors (#144662)

Author: Phoebe Wang Date: 2025-06-19T10:30:47+08:00 New Revision: 5875fafdc547889fb089c943a881a9ab6d8a23c0 URL: https://github.com/llvm/llvm-project/commit/5875fafdc547889fb089c943a881a9ab6d8a23c0 DIFF: https://github.com/llvm/llvm-project/commit/5875fafdc547889fb089c943a881a9ab6d8a23c0.diff L

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

https://github.com/Lancern closed https://github.com/llvm/llvm-project/pull/144201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2bcdfa1 - [CIR] Add side effect attribute to call operations (#144201)

Author: Sirui Mu Date: 2025-06-19T09:58:19+08:00 New Revision: 2bcdfa198aa511479c46144c5cf95c7c685384ef URL: https://github.com/llvm/llvm-project/commit/2bcdfa198aa511479c46144c5cf95c7c685384ef DIFF: https://github.com/llvm/llvm-project/commit/2bcdfa198aa511479c46144c5cf95c7c685384ef.diff LOG:

[clang] [HIP] Emit the CUID value in the module with the new driver (PR #144570)

arsenm wrote: > `llvm.compiler.used` global uses AS(0) which makes SPIR-V unhappy, but with > this global it's AS(4) which makes it happy. Either way, this should be fixed. llvm.used and llvm.compiler.used should universally use addrspace(0) and SPIRV should be fixed to not break on this

[clang] let Neon builtin function accept a const variable (PR #144625)

scout-zeng wrote: Hi @efriedma-quic , I do not think this workaround can fix this issue. Because the clang compiler still gives me an error like 'argument to xxx must be a constant integer", which means the if condition in line 5670 is not true. I am confused about that. Can you give me some s

[clang] let Neon builtin function accept a const variable (PR #144625)

scout-zeng wrote: fixes [#139033](https://github.com/llvm/llvm-project/issues/139033#issuecomment-2868006401) https://github.com/llvm/llvm-project/pull/144625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [lld] Use the Windows SDK arguments over the environment (PR #144805)

@@ -94,10 +94,14 @@ void visualstudio::Linker::ConstructJob(Compilation &C, const JobAction &JA, // If the VC environment hasn't been configured (perhaps because the user // did not run vcvarsall), try to build a consistent link environment. If // the environment variab

[clang] [lld] Use the Windows SDK arguments over the environment (PR #144805)

@@ -110,19 +114,15 @@ void visualstudio::Linker::ConstructJob(Compilation &C, const JobAction &JA, llvm::archToLegacyVCArch(TC.getArch())); CmdArgs.push_back(Args.MakeArgString(Twine("-libpath:") + DIAPath)); } - if (!llvm::sys::Process::GetE

[clang] [lld] Use the Windows SDK arguments over the environment (PR #144805)

https://github.com/Steelskin updated https://github.com/llvm/llvm-project/pull/144805 >From 5b875ae1120a5bd4860244bbbf725f0ef28fc83e Mon Sep 17 00:00:00 2001 From: Fabrice de Gans Date: Wed, 18 Jun 2025 15:04:35 -0700 Subject: [PATCH] Use the Windows SDK arguments over the environment If any o

[clang] [AArch64] Add option -msve-streaming-vector-bits= . (PR #144611)

efriedma-quic wrote: Pushed revised patch which correctly handles streaming-compatible functions (the previous version accidentally treated them as non-streaming). https://github.com/llvm/llvm-project/pull/144611 ___ cfe-commits mailing list cfe-commi

[clang] [AArch64] Add option -msve-streaming-vector-bits= . (PR #144611)

https://github.com/efriedma-quic updated https://github.com/llvm/llvm-project/pull/144611 >From c28804a471a9fe6be24479ffbfd7d4aa6c774125 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Tue, 17 Jun 2025 11:48:47 -0700 Subject: [PATCH 1/2] [AArch64] Add option -msve-streaming-vector-bits= . Th

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/144583 >From 80cd92fd1ea93a2f1c1b037d3a5354ee94f565f6 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 16 Jun 2025 16:39:15 -0700 Subject: [PATCH 1/3] [CIR] Add support for member initialization from construct

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

https://github.com/diggerlin edited https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/144583 >From 389f3d95239c28415a95696cc7645e3399a5d9ab Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Mon, 16 Jun 2025 16:39:15 -0700 Subject: [PATCH 1/2] [CIR] Add support for member initialization from construct

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

@@ -190,6 +192,31 @@ insertWaveSizeFeature(StringRef GPU, const Triple &T, StringMap &Features); } // namespace AMDGPU + +struct BasicSubtargetFeatureKV { + const char *Key; ///< K-V key string + unsigned Value; ///< K-V integer value +

[clang] [llvm] [HLSL][RootSignature] Add `hlsl-rootsig-ver` option to specify root signature version (PR #144813)

llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Finn Plummer (inbelic) Changes This pr provides the ability to specify the root signature version as a compiler option and to retain this in the root signature decl. It also updates the methods to serialize the version when dump

[clang] [llvm] [HLSL][RootSignature] Add `hlsl-rootsig-ver` option to specify root signature version (PR #144813)

llvmbot wrote: @llvm/pr-subscribers-llvm-support @llvm/pr-subscribers-clang-codegen Author: Finn Plummer (inbelic) Changes This pr provides the ability to specify the root signature version as a compiler option and to retain this in the root signature decl. It also updates the methods to

[clang] [llvm] [HLSL][RootSignature] Add `hlsl-rootsig-ver` option to specify root signature version (PR #144813)

https://github.com/inbelic created https://github.com/llvm/llvm-project/pull/144813 This pr provides the ability to specify the root signature version as a compiler option and to retain this in the root signature decl. It also updates the methods to serialize the version when dumping the decl

[clang] Revert "[HLSL][SPIRV] Add vk::constant_id attribute." (PR #144812)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Steven Perron (s-perron) Changes Reverts llvm/llvm-project#143544 --- Patch is 38.46 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/144812.diff 15 Files Affected: - (modified) clang/

[clang] Revert "[HLSL][SPIRV] Add vk::constant_id attribute." (PR #144812)

https://github.com/s-perron closed https://github.com/llvm/llvm-project/pull/144812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[HLSL][SPIRV] Add vk::constant_id attribute." (PR #144812)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Steven Perron (s-perron) Changes Reverts llvm/llvm-project#143544 --- Patch is 38.46 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/144812.diff 15 Files Affected: - (modified) clang/include/

[clang] Revert "[HLSL][SPIRV] Add vk::constant_id attribute." (PR #144812)

https://github.com/s-perron created https://github.com/llvm/llvm-project/pull/144812 Reverts llvm/llvm-project#143544 >From 9d775256000726929f826ec164aa514d4a6e2288 Mon Sep 17 00:00:00 2001 From: Steven Perron Date: Wed, 18 Jun 2025 19:30:17 -0400 Subject: [PATCH] Revert "[HLSL][SPIRV] Add vk:

[clang] 5f69d68 - Revert "[HLSL][SPIRV] Add vk::constant_id attribute." (#144812)

Author: Steven Perron Date: 2025-06-18T19:30:43-04:00 New Revision: 5f69d680e2cc94dcb30a7f29e8144725530a6da4 URL: https://github.com/llvm/llvm-project/commit/5f69d680e2cc94dcb30a7f29e8144725530a6da4 DIFF: https://github.com/llvm/llvm-project/commit/5f69d680e2cc94dcb30a7f29e8144725530a6da4.diff

[clang] [libcxx] [libc++][Clang] Added explanation why is_constructible evaluated to false. Updated the diagnostics checks in libc++ tests. (PR #144220)

@@ -1767,7 +1767,8 @@ def note_unsatisfied_trait : Note<"%0 is not %enum_select{" "%TriviallyRelocatable{trivially relocatable}|" "%Replaceable{replaceable}|" - "%TriviallyCopyable{trivially copyable}" + "%TriviallyCopyable{triviall

[clang] [HIP] Remove dots in HIP runtime path (PR #143792)

@@ -743,9 +743,12 @@ void Linux::AddHIPRuntimeLibArgs(const ArgList &Args, Args.MakeArgString(StringRef("-L") + RocmInstallation->getLibPath())); if (Args.hasFlag(options::OPT_frtlib_add_rpath, - options::OPT_fno_rtlib_add_rpath, false)) +

[clang] [HLSL][SPIRV] Add vk::constant_id attribute. (PR #143544)

s-perron wrote: https://lab.llvm.org/buildbot/#/builders/24/builds/9606 https://github.com/llvm/llvm-project/pull/143544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Remove dots in HIP runtime path (PR #143792)

https://github.com/scchan updated https://github.com/llvm/llvm-project/pull/143792 >From 62e627e4b8e68284668ad719d4c717fcd08fad45 Mon Sep 17 00:00:00 2001 From: Siu Chi Chan Date: Wed, 11 Jun 2025 17:18:42 -0400 Subject: [PATCH] [HIP] Remove dots in HIP runtime path Remove the dots in the HIP

[clang] [HIP] Remove dots in HIP runtime path (PR #143792)

https://github.com/scchan updated https://github.com/llvm/llvm-project/pull/143792 >From 9c60ee7b47c3b0f1bea492aafc0413bc73702f1e Mon Sep 17 00:00:00 2001 From: Siu Chi Chan Date: Wed, 11 Jun 2025 17:18:42 -0400 Subject: [PATCH] [HIP] Remove dots in HIP runtime path Remove the dots in the HIP

[clang] Use the Windows SDK arguments over the environment (PR #144805)

https://github.com/Steelskin updated https://github.com/llvm/llvm-project/pull/144805 >From 472cb7e13aa720a3fd53078d45e9c30503029003 Mon Sep 17 00:00:00 2001 From: Fabrice de Gans Date: Wed, 18 Jun 2025 15:04:35 -0700 Subject: [PATCH 1/2] Use the Windows SDK arguments over the environment If a

[clang] Use the Windows SDK arguments over the environment (PR #144805)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Driver/ToolChains/MSVC.cpp ``

[clang] Use the Windows SDK arguments over the environment (PR #144805)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Fabrice de Gans (Steelskin) Changes If any of the Windows SDK (and MSVC)-related argument is passed in the command line, they should take priority over the environment variables like `INCLUDE` or `LIB` set by vcvarsall from the Visual Stu

[clang] Use the Windows SDK arguments over the environment (PR #144805)

https://github.com/Steelskin created https://github.com/llvm/llvm-project/pull/144805 If any of the Windows SDK (and MSVC)-related argument is passed in the command line, they should take priority over the environment variables like `INCLUDE` or `LIB` set by vcvarsall from the Visual Studio De

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

https://github.com/emaxx-google updated https://github.com/llvm/llvm-project/pull/144796 >From 2fd016fd5d0bbc8d9922e7dbdc3bf29fd9099450 Mon Sep 17 00:00:00 2001 From: Maksim Ivanov Date: Wed, 18 Jun 2025 23:13:55 +0200 Subject: [PATCH 1/2] [clang] ODR hashes depth+index and not name of Templat

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

@@ -53,19 +53,135 @@ bool CIRGenFunction::isConstructorDelegationValid( return true; } +static void emitLValueForAnyFieldInitialization(CIRGenFunction &cgf, +CXXCtorInitializer *memberInit, +

[clang] [CIR] Add initial support for bitfields in structs (PR #142041)

@@ -14,6 +14,105 @@ namespace clang::CIRGen { +/// Record with information about how a bitfield should be accessed. This is +/// very similar to what LLVM codegen does, once CIR evolves it's possible we +/// can use a more higher level representation. +/// +/// Often we lay o

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/144583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

https://github.com/bcardosolopes approved this pull request. LGTM module few nits https://github.com/llvm/llvm-project/pull/144583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

@@ -53,19 +53,135 @@ bool CIRGenFunction::isConstructorDelegationValid( return true; } +static void emitLValueForAnyFieldInitialization(CIRGenFunction &cgf, +CXXCtorInitializer *memberInit, +

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

@@ -84,6 +200,34 @@ Address CIRGenFunction::loadCXXThisAddress() { return Address(loadCXXThis(), cxxThisAlignment); } +void CIRGenFunction::emitInitializerForField(FieldDecl *field, LValue lhs, + Expr *init) { + QualType fieldType

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

@@ -53,19 +53,135 @@ bool CIRGenFunction::isConstructorDelegationValid( return true; } +static void emitLValueForAnyFieldInitialization(CIRGenFunction &cgf, +CXXCtorInitializer *memberInit, +

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/144583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

@@ -101,7 +101,8 @@ define void @f5() "frame-pointer"="all" { ; CHECK-NEXT:.seh_endprologue ; CHECK-NEXT:leaq -92(%rbp), %rcx ; CHECK-NEXT:callq external -; CHECK-NEXT:nop +; UEFI does not have SEH, so does not require NOP +; WIN64-NEXT:nop

[clang] [llvm] [LLVM][IRBuilder] Use NUW arithmetic for Create{ElementCount,TypeSize}. (PR #143532)

https://github.com/fhahn approved this pull request. LGTM, thanks https://github.com/llvm/llvm-project/pull/143532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add missing intrinsics to cuda headers (PR #143664)

Artem-B wrote: It's a C++-11 feature. Tests still include c++98. We do not intend to keep everything working with c++98 (we already use c++11 in other headers), but we should not break it either. In this case, you can just enable the new stuff for c++11 or newer standards. https://github.com/

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

@@ -146,6 +146,13 @@ Changes in existing checks ` check to detect conversion in argument of ``std::make_optional``. +- Improved :doc: `bugprone-sizeof-expression + ` check by adding + `WarnOnSizeOfInLoopTermination` option to detect misuses of ``sizeof`` + expression in

[clang] [llvm] [LLVM][IRBuilder] Use NUW arithmetic for Create{ElementCount,TypeSize}. (PR #143532)

@@ -177,16 +177,16 @@ define void @add_unique_ind32(ptr noalias nocapture %a, i64 %n) { ; CHECK-LABEL: @add_unique_ind32( ; CHECK-NEXT: entry: ; CHECK-NEXT:[[TMP0:%.*]] = call i64 @llvm.vscale.i64() -; CHECK-NEXT:[[TMP1:%.*]] = shl i64 [[TMP0]], 2 +; CHECK-NEXT:[[

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

@@ -9,7 +9,6 @@ define i32 @foobar() gc "statepoint-example" personality ptr @__gxx_personality_ ; CHECK-NEXT:.seh_endprologue ; CHECK-NEXT:callq bar ; CHECK-NEXT: .Ltmp0: -; CHECK-NEXT:nop sivadeilra wrote: Since this is for the Windows GNU targ

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

@@ -2660,6 +2644,133 @@ void X86AsmPrinter::emitCallInstruction(const llvm::MCInst &MCI) { OutStreamer->emitInstruction(MCI, getSubtargetInfo()); } +// Checks whether a NOP is required after a CALL and inserts the NOP, if +// necessary. +void X86AsmPrinter::emitNopAfterCall

[clang] [CIR] Implement folder for VecSplatOp (PR #143771)

https://github.com/bcardosolopes approved this pull request. https://github.com/llvm/llvm-project/pull/143771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add initial support for bitfields in structs (PR #142041)

https://github.com/bcardosolopes approved this pull request. LGTM once all existing comments are addressed. https://github.com/llvm/llvm-project/pull/142041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

sivadeilra wrote: @mk No offense intended, of course. I'm happy to change the commit text / comments. What would you suggest? The Windows ABI is vast enough that a lot of it is poorly-documented, or has deeper invariants that are not documented. The requirement that IP2State boundaries alig

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

@@ -5164,6 +5164,29 @@ namespace A { A::X x; #endif +namespace TemplateDecltypeOperator { + +#if defined(FIRST) || defined(SECOND) +template +T6 func(); +#endif + +#if defined(SECOND) +template +using UnrelatedAlias = decltype(func())(); +#endif + +#if defined(FIRST) || defi

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Maksim Ivanov (emaxx-google) Changes Change the ODR hashing logic to use the depth+index indices instead of template parameter names. This prevents spurious ODR errors in header module builds when the type canonicalization picks up differ

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Maksim Ivanov (emaxx-google) Changes Change the ODR hashing logic to use the depth+index indices instead of template parameter names. This prevents spurious ODR errors in header module builds when the type canonicalization picks u

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

https://github.com/emaxx-google created https://github.com/llvm/llvm-project/pull/144796 Change the ODR hashing logic to use the depth+index indices instead of template parameter names. This prevents spurious ODR errors in header module builds when the type canonicalization picks up different

[clang] [flang] [llvm] [llvm] annotate remaining LLVM interfaces for DLL export (PR #144746)

https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/144746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

rnk wrote: > The entries in the IP2State table contain byte offsets within the instruction > stream of the function. The Windows ABI requires that these offsets are > aligned to instruction boundaries; they are not permitted to point to a byte > that is not the first byte of an instruction. >

  1   2   3   4   >