[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-23 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/155143 >From c1cdb3909c0bb55ce21d339f087c1e38616fec3f Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Sat, 23 Aug 2025 23:57:18 -0700 Subject: [PATCH] [clang] Heuristic resolution for explicit object paramete

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-23 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK edited https://github.com/llvm/llvm-project/pull/155143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Heuristic resolution for explicit object parameter (PR #155143)

2025-08-23 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK created https://github.com/llvm/llvm-project/pull/155143 Fixes clangd/clangd#2323. Assumes `self` is of the record type in the declaration. ```cpp struct Foo { int [[memb^er]] {}; auto&& getter1(this auto&& self) { // assume `self` is is `Foo` return self

[clang] [clang] Remove redundant control flow statements (NFC) (PR #155138)

2025-08-23 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/155138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 970516d - [clang] Remove redundant control flow statements (NFC) (#155138)

2025-08-23 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-08-23T22:20:22-07:00 New Revision: 970516de2e3e92bb75324852648d8f027bbac893 URL: https://github.com/llvm/llvm-project/commit/970516de2e3e92bb75324852648d8f027bbac893 DIFF: https://github.com/llvm/llvm-project/commit/970516de2e3e92bb75324852648d8f027bbac893.diff L

[clang] [Clang-Repl] Add Lambda Support, PID Retrieval, and Dynamic liborc_rt Path in Clang-Repl (PR #155140)

2025-08-23 Thread Abhinav Kumar via cfe-commits
https://github.com/kr-2003 created https://github.com/llvm/llvm-project/pull/155140 This PR builds upon the changes introduced in https://github.com/llvm/llvm-project/pull/152562. Introduces: 1. Custom lambda function in launchExecutor. 2. Fetching PID of the launched out-of-process(OOP) JIT

[clang] [clang-format] Add option AllowShortRecordsOnASingleLine (PR #154580)

2025-08-23 Thread via cfe-commits
=?utf-8?q?Tom=C3=A1=C5=A1?= Slanina Message-ID: In-Reply-To: @@ -992,6 +992,32 @@ struct FormatStyle { /// \version 20 bool AllowShortNamespacesOnASingleLine; + /// Different styles for merging short records + /// (``class``,``struct``,``union``). + enum ShortRecordS

[clang] [clang-format] Add option AllowShortRecordsOnASingleLine (PR #154580)

2025-08-23 Thread via cfe-commits
=?utf-8?q?Tomáš?= Slanina Message-ID: In-Reply-To: @@ -992,6 +992,32 @@ struct FormatStyle { /// \version 20 bool AllowShortNamespacesOnASingleLine; + /// Different styles for merging short records + /// (``class``,``struct``,``union``). + enum ShortRecordStyle : int

[clang] [clang-format] Add option AllowShortRecordsOnASingleLine (PR #154580)

2025-08-23 Thread via cfe-commits
=?utf-8?q?Tom=C3=A1=C5=A1?= Slanina Message-ID: In-Reply-To: owenca wrote: With this patch: ``` $ cat a.cc class foo {}; class bar { int i; }; $ cf -style='{AllowShortRecordsOnASingleLine: Empty}' a.cc class foo {}; class bar { int i; }; $ cf -style='{AllowShortRecordsOnASingleLine: Never}'

[clang] [Sema] Compare canonical conversion function (PR #154158)

2025-08-23 Thread Shafik Yaghmour via cfe-commits
@@ -4404,14 +4404,19 @@ CompareImplicitConversionSequences(Sema &S, SourceLocation Loc, Result = CompareStandardConversionSequences(S, Loc, ICS1.Standard, ICS2.Standard); else if (ICS1.isUserDefined()) { +const Function

[clang] [clang] Remove redundant control flow statements (NFC) (PR #155138)

2025-08-23 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab approved this pull request. https://github.com/llvm/llvm-project/pull/155138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove redundant control flow statements (NFC) (PR #155138)

2025-08-23 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: > The title needs to be more specific. Oops. Thank you for pointing this out. https://github.com/llvm/llvm-project/pull/155138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang] Remove redundant control flow statements (NFC) (PR #155138)

2025-08-23 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/155138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove redundant control flow statements (NFC) (PR #155138)

2025-08-23 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/155138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cleanup 20250823 ret clang (PR #155138)

2025-08-23 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. The title needs to be more specific. https://github.com/llvm/llvm-project/pull/155138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] cleanup 20250823 ret clang (PR #155138)

2025-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes - **[clang] Remove redundant control flow statements (NFC)** - **[FLowSensitive] Remove unused using decls (NFC)** --- Full diff: https://github.com/llvm/llvm-project

[clang] cleanup 20250823 ret clang (PR #155138)

2025-08-23 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/155138 - **[clang] Remove redundant control flow statements (NFC)** - **[FLowSensitive] Remove unused using decls (NFC)** >From dd372e97d9ec98eaa92e9aea5d853b1cb01a5eb4 Mon Sep 17 00:00:00 2001 From: Kazu Hirat

[clang] [Clang][Codegen][NFC] Add nullptr check in fillOutputFields (PR #154623)

2025-08-23 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows` running on `linaro-armv8-windows-msvc-05` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/141/builds/11048 Here is the relevant piece of

[clang] [clang] Enable constexpr handling for __builtin_elementwise_fma (PR #152919)

2025-08-23 Thread Shafik Yaghmour via cfe-commits
@@ -11874,6 +11874,28 @@ bool VectorExprEvaluator::VisitCallExpr(const CallExpr *E) { return Success(APValue(ResultElements.data(), ResultElements.size()), E); } + + case Builtin::BI__builtin_elementwise_fma: { +APValue SourceX, SourceY, SourceZ; +if (!Evaluate

[clang] Fix for false positive issue (PR #155131)

2025-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Vidur (vidur2) Changes Hi, I am working on a PR for issue #153300. Currently I dont have a regression test or anything for this yet. This is just the initial fix. --- Patch is 29.71 KiB, truncated to 20.00 KiB below, fu

[clang] Fix for false positive issue (PR #155131)

2025-08-23 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Fix for false positive issue (PR #155131)

2025-08-23 Thread via cfe-commits
https://github.com/vidur2 created https://github.com/llvm/llvm-project/pull/155131 Hi, I am working on a PR for issue #153300. Currently I dont have a regression test or anything for this yet. This is just the initial fix. >From f903652135758b6a7a20d15565177304add16e2c Mon Sep 17 00:00:00 2001

[clang] [clang][bytecode][NFC] Use an anonymous union in Pointer (PR #154405)

2025-08-23 Thread Shafik Yaghmour via cfe-commits
@@ -163,12 +186,11 @@ APValue Pointer::toAPValue(const ASTContext &ASTCtx) const { } if (isTypeidPointer()) { -TypeInfoLValue TypeInfo(PointeeStorage.Typeid.TypePtr); -return APValue( -APValue::LValueBase::getTypeInfo( -TypeInfo, QualType(Point

[clang] [clang][bytecode][NFC] Use an anonymous union in Pointer (PR #154405)

2025-08-23 Thread Shafik Yaghmour via cfe-commits
@@ -95,31 +93,23 @@ class Pointer { static constexpr unsigned RootPtrMark = ~0u; public: - Pointer() { -StorageKind = Storage::Int; -PointeeStorage.Int.Value = 0; -PointeeStorage.Int.Desc = nullptr; - } - Pointer(IntPointer &&IntPtr) : StorageKind(Storage::Int

[clang] [Clang][Codegen][NFC] Add nullptr check in fillOutputFields (PR #154623)

2025-08-23 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/154623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] eadf0eb - [Clang][Codegen][NFC] Add nullptr check in fillOutputFields (#154623)

2025-08-23 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2025-08-23T19:13:22-07:00 New Revision: eadf0ebc9026f4593db10502f26a15ac0cdedbb5 URL: https://github.com/llvm/llvm-project/commit/eadf0ebc9026f4593db10502f26a15ac0cdedbb5 DIFF: https://github.com/llvm/llvm-project/commit/eadf0ebc9026f4593db10502f26a15ac0cdedbb5.dif

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via cfe-commits
@@ -95,24 +95,25 @@ TC https://github.com/llvm/llvm-project/pull/155120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Yanzuo Liu via cfe-commits
@@ -95,24 +95,25 @@ TC https://github.com/llvm/llvm-project/pull/155120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From e1c4ead49256ce93ca35dda58b57d96fdb7e001d Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/include/clang/AST/TemplateBase.h clang/lib/AS

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From 6f039d0a53ef53436624b6493bfcf3b6c9ba36cb Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From 85ba1ffd8726a1596dfd3aebfd56ebed0460cf77 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From f31c4e385a66cf3e6c7aab499bcba7bd271902fb Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[clang] [lldb] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/155120 >From 3996f1f23d55e5d3fa121a75e015ce7fbd3624ca Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Sat, 9 Aug 2025 18:14:46 -0300 Subject: [PATCH] [clang] remove isDefaulted bit from TemplateArgument The IsDe

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: As I explained in the commit message, this is not removing the feature. The information about which arguments were defaulted was already available in the AST before this bit was added. And the bit is not correct as I said, being part of the canonical type means that this infor

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Michael Buch via cfe-commits
Michael137 wrote: uhm i'll have a more detailed look at the motivation for this but i added this specifically for better debugging experience. I'd be surprised if this didnt regress anything in LLDB https://github.com/llvm/llvm-project/pull/155120 __

[clang] [clang-tools-extra] [clang-tidy] `bugprone-unchecked-optional-access`: handle `BloombergLP::bdlb:NullableValue::makeValue` to prevent false-positives (PR #144313)

2025-08-23 Thread Valentyn Yukhymenko via cfe-commits
@@ -985,6 +985,20 @@ auto buildTransferMatchSwitch() { isOptionalMemberCallWithNameMatcher(hasName("isNull")), transferOptionalIsNullCall) + // NullableValue::makeValue, NullableValue::makeValueInplace + // Only NullableValue has these methods, bu

[clang] [clang-tools-extra] [lldb] [llvm] [mlir] [NFC] Fix typos 'seperate' -> 'separate' (PR #144368)

2025-08-23 Thread via cfe-commits
https://github.com/GameRoMan updated https://github.com/llvm/llvm-project/pull/144368 >From 2b50682f230efa03c3b9a1f5c5e48e708734bf4d Mon Sep 17 00:00:00 2001 From: Roman A <121314722+gamero...@users.noreply.github.com> Date: Mon, 16 Jun 2025 15:59:01 +0100 Subject: [PATCH] A couple of grammar fi

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes The IsDefaulted bit being part of a canonical TemplateArgument doesn't make sense, as that information is not information a canonical type should have. In C++, all template specialization types for ther

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Matheus Izvekov (mizvekov) Changes The IsDefaulted bit being part of a canonical TemplateArgument doesn't make sense, as that information is not information a canonical type should have. In C++, all template specialization types for ther s

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Matheus Izvekov (mizvekov) Changes The IsDefaulted bit being part of a canonical TemplateArgument doesn't make sense, as that information is not information a canonical type should have. In C++, all template specialization types for t

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Matheus Izvekov (mizvekov) Changes The IsDefaulted bit being part of a canonical TemplateArgument doesn't make sense, as that information is not information a canonical type should have. In C++, all template specialization types f

[clang] [clang] remove IsDefaulted bit from TemplateArgument (PR #155120)

2025-08-23 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/155120 The IsDefaulted bit being part of a canonical TemplateArgument doesn't make sense, as that information is not information a canonical type should have. In C++, all template specialization types for ther same t

[clang] [llvm] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types (PR #153501)

2025-08-23 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/153501 >From 926ac906473352823e12059322abc6d963890324 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Sat, 23 Aug 2025 14:55:50 -0400 Subject: [PATCH] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types

[clang] [clang-tools-extra] [clang] Improve nested name specifier AST representation (PR #147835)

2025-08-23 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: Ah, sorry. I tested on IWYU and get confused because it transforms a declaration to the definition later. https://github.com/llvm/llvm-project/pull/147835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [clang-tools-extra] [clang] Improve nested name specifier AST representation (PR #147835)

2025-08-23 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > Seems like `getOriginalDecl()` always returns the full definition for > enumerations (and not an opaque declaration for enums with fixed underlying > type), at least in the C language mode. Is it guaranteed? I don't see that happening. Example: https://compiler-explorer.com/z

[clang] [llvm] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types (PR #153501)

2025-08-23 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/153501 >From 1b3f03dfcb03975dc75fb56d929538826716fa06 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Sat, 23 Aug 2025 14:55:50 -0400 Subject: [PATCH] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/132016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] d7390be - [clang-tidy] Skip system macros in readability-identifier-naming check (#132016)

2025-08-23 Thread via cfe-commits
Author: Carlos Galvez Date: 2025-08-23T21:41:05+02:00 New Revision: d7390be0646821d58d104f164c693ce7f1f970cb URL: https://github.com/llvm/llvm-project/commit/d7390be0646821d58d104f164c693ce7f1f970cb DIFF: https://github.com/llvm/llvm-project/commit/d7390be0646821d58d104f164c693ce7f1f970cb.diff

[clang] [clang-tools-extra] [clang] Improve nested name specifier AST representation (PR #147835)

2025-08-23 Thread Andrey Ali Khan Bolshakov via cfe-commits
bolshakov-a wrote: Seems like `getOriginalDecl()` always returns the full definition for enumerations (and not an opaque declaration for enums with fixed underlying type). Is it guaranteed? https://github.com/llvm/llvm-project/pull/147835 ___ cfe-com

[clang] [llvm] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types (PR #153501)

2025-08-23 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu edited https://github.com/llvm/llvm-project/pull/153501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types (PR #153501)

2025-08-23 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/153501 >From ed45edfdf6b027e9d2fa873e2242e4f3ff60157c Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Sat, 23 Aug 2025 14:55:50 -0400 Subject: [PATCH] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types

[clang] [llvm] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types (PR #153501)

2025-08-23 Thread Yaxun Liu via cfe-commits
@@ -61,3 +61,111 @@ Predefined Macros - Defined if FP64 instruction is available (deprecated). Please note that the specific architecture and feature names will vary depending on the GPU. Also, some macros are deprecated and may be removed in future releases. + +AMDGPU

[clang] [llvm] [AMDGPU] Extend __builtin_amdgcn_ds_bpermute argument types (PR #153501)

2025-08-23 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Add some tests with complex and pointers? will do https://github.com/llvm/llvm-project/pull/153501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add detection in container's method except `empty` in `readability-container-size-empty` (PR #154017)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/154017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: > Yes, the patch can be merged and gets rid of about half the remaining > warnings in system headers! I've removed the condition about checking for the > `SystemHeaders` flag, for consistency with similar code in this file for > ignoring the `Decl`s, which further simplifies th

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Yes, the patch can be merged and gets rid of about half the remaining warnings in system headers! I've removed the condition about checking for the `SystemHeaders` flag, for consistency with similar code for ignoring the `Decl`s, which further simplifies the logic. https:

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp edited https://github.com/llvm/llvm-project/pull/132016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/132016 >From f57920884bdc225e453fd0d5508494c35d87b3c2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Wed, 19 Mar 2025 12:28:49 + Subject: [PATCH] [clang-tidy] Skip system macros in rea

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Let me refresh my memory about this patch and come back :) https://github.com/llvm/llvm-project/pull/132016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [llvm] [mlir] [NFC] Fix typos 'seperate' -> 'separate' (PR #144368)

2025-08-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: Hi, could you rebase on fresh main and fix conflicts (should be easy). After that, could be merged https://github.com/llvm/llvm-project/pull/144368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang-tools-extra] [clang][AST][clang-tidy] Do not set a reduced traversal scope in ASTM… (PR #132725)

2025-08-23 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: Yes, thank you, closing! https://github.com/llvm/llvm-project/pull/132725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][AST][clang-tidy] Do not set a reduced traversal scope in ASTM… (PR #132725)

2025-08-23 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp closed https://github.com/llvm/llvm-project/pull/132725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][AST][clang-tidy] Do not set a reduced traversal scope in ASTM… (PR #132725)

2025-08-23 Thread Baranov Victor via cfe-commits
vbvictor wrote: Since patch https://github.com/llvm/llvm-project/pull/151035 is merged, do we still need this one, or it could be closed? https://github.com/llvm/llvm-project/pull/132725 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] [clang-tidy] Skip system macros in readability-identifier-naming check (PR #132016)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM Are you willing to merge this patch or there were some problems encountered? https://github.com/llvm/llvm-project/pull/132016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [Clang]Throw frontend error for target feature mismatch when using flatten attribute (PR #154801)

2025-08-23 Thread Abhishek Kaushik via cfe-commits
https://github.com/abhishek-kaushik22 updated https://github.com/llvm/llvm-project/pull/154801 >From 359de1e5786a413f3bfca6b09b60bd2fd67dbb1f Mon Sep 17 00:00:00 2001 From: Abhishek Kaushik Date: Thu, 21 Aug 2025 22:59:21 +0530 Subject: [PATCH 1/2] [Clang]Throw frontend error for target feature

[clang] [clang-tools-extra] [clangd] extend and rearrange doxygen hover documentation (PR #152918)

2025-08-23 Thread via cfe-commits
tcottin wrote: ping @emaxx-google https://github.com/llvm/llvm-project/pull/152918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] Elide suspension points via [[clang::coro_await_suspend_destroy]] (PR #152623)

2025-08-23 Thread via cfe-commits
snarkmaster wrote: Thanks! I'm happy to distill the conversation above into an RFC, but I first want to ask @ChuanqiXu9 if the `lookupReturnTypeIfAwaitSuspendDestroy()` implementation (and corresponding [discussion of overload resolution](https://github.com/llvm/llvm-project/pull/152623#discus

[clang-tools-extra] [clangd] Add option: --limit-hover-contents (PR #155105)

2025-08-23 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Jaagup Averin (JaagupAverin) Changes Currently macro expansions are hard capped at 2048. This PR adds the CLI option `--limit-hover-contents` which is passed down in place of the hard coded value. Resolves #153355. --- Full diff: https:/

[clang-tools-extra] [clangd] Add option: --limit-hover-contents (PR #155105)

2025-08-23 Thread Jaagup Averin via cfe-commits
https://github.com/JaagupAverin edited https://github.com/llvm/llvm-project/pull/155105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add option: limit-hover-contents (PR #155105)

2025-08-23 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clangd] Add option: limit-hover-contents (PR #155105)

2025-08-23 Thread Jaagup Averin via cfe-commits
https://github.com/JaagupAverin created https://github.com/llvm/llvm-project/pull/155105 Currently macro expansions are hard capped at 2048. This PR adds the CLI option `--limit-hover-contents` which is passed down in place of the hard coded value. Resolves #153355. >From 82c5665913eca5c63c952

[clang] [CIR] Upstream Re-Throw with no return (PR #154994)

2025-08-23 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/154994 >From 0a0c6291aa24acbc4a758b141e0b1e56676d99fd Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Fri, 22 Aug 2025 15:34:47 +0200 Subject: [PATCH 1/4] [CIR] Upstream Re-Throw with no return --- .../CIR/Dia

[clang] [CIR] Upstream Re-Throw with no return (PR #154994)

2025-08-23 Thread Amr Hesham via cfe-commits
@@ -3800,4 +3800,58 @@ def CIR_VAArgOp : CIR_Op<"va_arg"> { }]; } +//===--===// +// ThrowOp +//===--===// + +def CIR_ThrowOp : CIR_Op<"thro

[clang] [CIR] Upstream Re-Throw with no return (PR #154994)

2025-08-23 Thread Henrich Lauko via cfe-commits
@@ -3800,4 +3800,58 @@ def CIR_VAArgOp : CIR_Op<"va_arg"> { }]; } +//===--===// +// ThrowOp +//===--===// + +def CIR_ThrowOp : CIR_Op<"thro

[clang] [CIR] Upstream Re-Throw with no return (PR #154994)

2025-08-23 Thread Henrich Lauko via cfe-commits
@@ -3800,4 +3800,58 @@ def CIR_VAArgOp : CIR_Op<"va_arg"> { }]; } +//===--===// +// ThrowOp +//===--===// + +def CIR_ThrowOp : CIR_Op<"thro

[clang] [NFC][clang] Move simplifyConstraint to TargetInfo.cpp (PR #154905)

2025-08-23 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse commented: This seems fine; note that while your change to use StringRef as a parameter type is cleaner, both call sites you change are passing `char *`'s and I believe this means we'll run `strlen` every time this function is called? Better to construct directly from

[clang] [clang] -fstrict-enums optimization for by-value parameters (PR #154807)

2025-08-23 Thread via cfe-commits
https://github.com/keinflue updated https://github.com/llvm/llvm-project/pull/154807 >From 35308dce96c6901a088422ff85609789064d40e5 Mon Sep 17 00:00:00 2001 From: keinflue Date: Thu, 21 Aug 2025 18:32:21 +0200 Subject: [PATCH] [clang] -fstrict-enums optimization for by-value parameters This ad

[clang-tools-extra] [clang-tidy] Add new check 'llvm-use-ranges' (PR #152047)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/152047 >From bb17fb65d031190efff6a6ec1c0ca6d9c0d35abb Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 5 Aug 2025 01:15:02 +0300 Subject: [PATCH 1/5] [clang-tidy] Add new check 'llvm-use-ranges' --- .../clan

[clang-tools-extra] [clang-tidy] Add new check 'llvm-use-ranges' (PR #152047)

2025-08-23 Thread via cfe-commits
@@ -0,0 +1,60 @@ +.. title:: clang-tidy - llvm-use-ranges + +llvm-use-ranges +=== + +Finds calls to STL library iterator algorithms that could be replaced with +LLVM range-based algorithms from ``llvm/ADT/STLExtras.h``. + +Example +--- + +.. code-block:: c++ + + a

[clang] [clang] Proofread AutomaticReferenceCounting.rst (PR #155071)

2025-08-23 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/155071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4b23606 - [clang] Proofread AutomaticReferenceCounting.rst (#155071)

2025-08-23 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-08-23T07:10:10-07:00 New Revision: 4b236067dcacbb4fcbc1e1aaca4921ab06fe3cad URL: https://github.com/llvm/llvm-project/commit/4b236067dcacbb4fcbc1e1aaca4921ab06fe3cad DIFF: https://github.com/llvm/llvm-project/commit/4b236067dcacbb4fcbc1e1aaca4921ab06fe3cad.diff L

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM I think we should make follow up patch (not high priority) with either making an option to disable "empty by comparing to default-constructed object" or making a regex-option to filter such containers https://github.com/llvm/llvm-pro

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread via cfe-commits
https://github.com/flovent edited https://github.com/llvm/llvm-project/pull/154782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread via cfe-commits
https://github.com/flovent edited https://github.com/llvm/llvm-project/pull/154782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread via cfe-commits
@@ -908,3 +908,37 @@ class foo : public std::string{ }; } + +namespace GH154762 { +class TypeRange { + std::vector b; + +public: + TypeRange(std::vector b = {}); + TypeRange(int); + bool operator==(const TypeRange& other) const; + + size_t size() const { +return b.siz

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/23112 Here is the relevant piece of the

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread via cfe-commits
github-actions[bot] wrote: @tinnamchoi Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/152865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 66eaa80 - [Clang] Remove redundant check for scoped enums in shift operators (#152865)

2025-08-23 Thread via cfe-commits
Author: Timothy Choi Date: 2025-08-23T15:31:02+02:00 New Revision: 66eaa80c39ae0f8aa6cd58024ac6562037038b5f URL: https://github.com/llvm/llvm-project/commit/66eaa80c39ae0f8aa6cd58024ac6562037038b5f DIFF: https://github.com/llvm/llvm-project/commit/66eaa80c39ae0f8aa6cd58024ac6562037038b5f.diff

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread via cfe-commits
https://github.com/Sirraide auto_merge_disabled https://github.com/llvm/llvm-project/pull/152865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread via cfe-commits
Sirraide wrote: CI failure seems to be due to something in LLDB and it looks like other prs are suffering from the same issue. https://github.com/llvm/llvm-project/pull/152865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread via cfe-commits
https://github.com/Sirraide auto_merge_enabled https://github.com/llvm/llvm-project/pull/152865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/152865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/152865 >From fc0a4c73dc2abb74f200619d78f9b0baab1de7b7 Mon Sep 17 00:00:00 2001 From: tinnamchoi Date: Sat, 9 Aug 2025 12:02:43 +0800 Subject: [PATCH] [Clang] Remove redundant check for scoped enums in shift operators

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread Baranov Victor via cfe-commits
@@ -908,3 +908,37 @@ class foo : public std::string{ }; } + +namespace GH154762 { +class TypeRange { + std::vector b; + +public: + TypeRange(std::vector b = {}); + TypeRange(int); + bool operator==(const TypeRange& other) const; + + size_t size() const { +return b.siz

[clang] [Clang] Remove redundant check for scoped enums in shift operators (PR #152865)

2025-08-23 Thread Timothy Choi via cfe-commits
tinnamchoi wrote: @Sirraide The other PR got merged, this should be good upon green CI rerun https://github.com/llvm/llvm-project/pull/152865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [Clang] Added explanation why `is_trivially default_constructible` is false (PR #152888)

2025-08-23 Thread via cfe-commits
abhijeetsharma200 wrote: > Can you fix the merge conflicts? Thanks! Done! https://github.com/llvm/llvm-project/pull/152888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Added explanation why `is_trivially default_constructible` is false (PR #152888)

2025-08-23 Thread via cfe-commits
https://github.com/abhijeetsharma200 updated https://github.com/llvm/llvm-project/pull/152888 >From 48d71f870d21a45c0a197d1853788a4aec80018b Mon Sep 17 00:00:00 2001 From: Abhijeet Sharma Date: Sun, 10 Aug 2025 04:49:15 +0200 Subject: [PATCH 1/2] Added explain is trivially default constructible

[clang-tools-extra] [clang-tidy] Ignore default ctor with user provided argument in `readability-container-size-empty` (PR #154782)

2025-08-23 Thread via cfe-commits
@@ -908,3 +908,37 @@ class foo : public std::string{ }; } + +namespace GH154762 { +class TypeRange { + std::vector b; + +public: + TypeRange(std::vector b = {}); + TypeRange(int); + bool operator==(const TypeRange& other) const; + + size_t size() const { +return b.siz

  1   2   >